[opensource-dev] Review Request: As a music fan, I want audio to fade in gently so my immersion is increased

[Lee ponzu]

An audio glitch I hate...

Listening music in SL, I often turn the SL volume down quite a bit.  When I
exit SL, the music stream continues for a few seconds as SL closes, but AT
FULL VOLUME.

it wakes up the dog.

Ponzu

On Wed, Nov 23, 2011 at 5:59 AM, Jonathan Yap <jhwelch at gmail.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/520/
>   Review request for Viewer.
> By Jonathan Yap.
> Description
>
> Audio fading in has been added for when a music stream starts.  Audio fading out has been added for when there is a change in the music stream that is playing.
>
> Two dead files have been eliminated.
>
> An existing bug in how music was not being paused correctly has been fixed.
>
> When you are teleporting you will hear the music stream from the place you are leaving.  This is a change in behavior; previously the music stream was stopped when the teleport progress bar was being displayed.
>
> This code change affects several areas where music is started or stopped.  The new code has evolved significantly, so please look for things that might not "make sense."
>
>   Testing
>
> See the massive test plan in the jira.
>
>   *Bugs: * STORM-591 <http://jira.secondlife.com/browse/STORM-591>
> Diffs
>
>    - doc/contributions.txt (8b455c1b7a5e)
>    - indra/newview/lloverlaybar.h (8b455c1b7a5e)
>    - indra/newview/lloverlaybar.cpp (8b455c1b7a5e)
>    - indra/newview/llpanelnearbymedia.h (8b455c1b7a5e)
>    - indra/newview/llpanelnearbymedia.cpp (8b455c1b7a5e)
>    - indra/newview/llvieweraudio.h (8b455c1b7a5e)
>    - indra/newview/llvieweraudio.cpp (8b455c1b7a5e)
>    - indra/newview/llviewermedia.cpp (8b455c1b7a5e)
>    - indra/newview/llviewerparcelmgr.cpp (8b455c1b7a5e)
>
> View Diff <http://codereview.secondlife.com/r/520/diff/>
>
> _______________________________________________
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111201/deeca324/attachment.htm