[opensource-dev] Review Request: As a music fan, I want audio to fade in gently so my immersion is increased

[Jonathan Yap]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/520/
-----------------------------------------------------------

(Updated Dec. 5, 2011, 2:07 a.m.)


Review request for Viewer.


Changes
-------

Made changes per code review requests:

Took care of case where division by zero is possible
Removed early returns
Music does not play when the teleport progress bar is displayed

Also made a change so that the fade in timer during login is reset until STATE_STARTED is reached.  This helps fix not hearing a full fade in during login.


Description
-------

Audio fading in has been added for when a music stream starts.  Audio fading out has been added for when there is a change in the music stream that is playing.

Two dead files have been eliminated.

An existing bug in how music was not being paused correctly has been fixed.

When you are teleporting you will hear the music stream from the place you are leaving.  This is a change in behavior; previously the music stream was stopped when the teleport progress bar was being displayed.

This code change affects several areas where music is started or stopped.  The new code has evolved significantly, so please look for things that might not "make sense."


This addresses bug STORM-591.
    http://jira.secondlife.com/browse/STORM-591


Diffs (updated)
-----

  doc/contributions.txt 8b455c1b7a5e 
  indra/newview/lloverlaybar.h 8b455c1b7a5e 
  indra/newview/lloverlaybar.cpp 8b455c1b7a5e 
  indra/newview/llpanelnearbymedia.h 8b455c1b7a5e 
  indra/newview/llpanelnearbymedia.cpp 8b455c1b7a5e 
  indra/newview/llvieweraudio.h 8b455c1b7a5e 
  indra/newview/llvieweraudio.cpp 8b455c1b7a5e 
  indra/newview/llviewermedia.cpp 8b455c1b7a5e 
  indra/newview/llviewerparcelmgr.cpp 8b455c1b7a5e 

Diff: http://codereview.secondlife.com/r/520/diff/diff


Testing
-------

See the massive test plan in the jira.


Thanks,

Jonathan Yap

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111205/d82528b9/attachment.htm