From akanevsky at productengine.com Tue Feb 1 00:03:41 2011 From: akanevsky at productengine.com (Anya Kanevsky) Date: Tue, 1 Feb 2011 00:03:41 -0800 Subject: [opensource-dev] Daily Scrum Summary - Monday, January 31 Message-ID: Monday, January 31, 2011 General Notes ------------------------------ - Welcome Wolf! He will be our UX resource at 50% - which is at least 150% more UX resource than we have now. - MMOTD: Oz Team Status ------------------------------ Merov Linden ------------------------------ *PAST* - STORM-749 : Alpha in KDU: Did extensive tests with a hacked premultiplied implementation. Results were unimpressive in perf and quality (see JIRA for details). Resolved as "Won't Finish". - STORM-937 : Path to python in /scripts/*.py file inconsistent : Done. Moved to review. - Bunch of internal meetings and demos *FUTURE* - STORM-746 : KDU Improvements: Compress j2c with precincts - Triage JIRA in preparation of tomorrow's sprint planning meeting - Take over MM from Oz? *IMPEDIMENTS* - none Oz Linden ------------------------------ *PAST* - Merge Monkey - Got list of problems to be solved w/ autobuild before merge - Clarified line ending issue in Coding Standard (unix style only) - fixed many DOS line endings - created tool to track down who committed DOS line endings - sent dunning notes to offenders - Got Jonathan to start wiki page on how not to do it https://wiki.secondlife.com/wiki/How_to_avoid_DOS_line_endings_in_Windows_tools - My Office Hour *FUTURE* - Merge Monkey - Try to fix using autobuild with VS Express - Create a viewer autobuild usage wiki page - Meet with Team Chopper about opendev tools issues - Create new project for tools/build-process issues? *IMPEDIMENTS* - none Q Linden ------------------------------ *PAST* - travel recovery - meetings - crashhunters *FUTURE* - crash hunting and debugging - meetings - bring wolf on board with process and background *IMPEDIMENTS* - none Grumpity ProductEngine ------------------------------ *PAST* - crashhunters - PO approval requirements - meetings - found victim for STORM-526 (inventory questions) *FUTURE* - determine sprint goal for sprint 11 - sprint review - prepare for sprint planning - crashhunters bizzaro - continue prod others to resolve my impediments *IMPEDIMENTS* - none Paul ProductEngine ------------------------------ *PAST* - BUG STORM-507 (User that has sent p2p call invitation to other user, is not added to Recent tab) - Fixed and sent for review. - BUG STORM-680 (Avaline callers are added to the Recent list) - WIP. Cant't work on this bug constantly because iCall service available periodically. *FUTURE* - BUG STORM-680 (Avaline callers are added to the Recent list) - BUG STORM-655 (mismatched filter extension in snapshot floater (jpeg vs jpg) ) *IMPEDIMENTS* - none Seth Productengine ------------------------------ *PAST* - Story (STORM-526) Log out failure during Login causes loss of pending offers, including inventory. - Reading new comments and logs submitted by users. The problem is still unclear for now. - BUG (STORM-316) Debug: Inventory.Folders by Name/Sort by Date/Sort by Name/System Folders to Top Do not apply and settings changes do not persist after relogging. - Fixed according to Q's latest comments. *FUTURE* - Pick other issues from sprint 10. *IMPEDIMENTS* - BUG (STORM-379) Content permissions aren't refreshed in the "Buy copy of" floater. - Should it be resolved as expected behavior or what should be the expected behavior in more details. - Story (STORM-526) Log out failure during Login causes loss of pending offers, including inventory. - Need help from a person familiar with inventory code. Vadim Productengine ------------------------------ *PAST* - Task STORM-2 (Customizable viewer layouts): - Investigating code written by Andrew. - Bug STORM-610 (Changes to Environment Editor: water color change is not saved): - Submitted my fix. - Reviewed fix of STORM-643 (Mini-map in the nearby people tab). *FUTURE* - Work on STORM-2 issues (mentioned in the ticket and in opensource-dev). *IMPEDIMENTS* - Bug STORM-465 (Missing Strings from strings.xml): - Waiting for Q to provide code-related feedback. Andrey ProductEngine ------------------------------ *PAST* - proceeded with regression testing of the latest v-d build, see spreadsheet - reported 10 issues into VWR *FUTURE* - pick up next Beta build or proceed with regression testing of v-d *IMPEDIMENTS* - list of issues which PEQA cannot verify Jonathan Yapp ------------------------------ *PAST* - Updated wiki page and created new one per Oz's request: - https://wiki.secondlife.com/wiki/Viewer_2_Microsoft_Windows_Builds (updated) - https://wiki.secondlife.com/wiki/Developer_Editors (new) - VWR-24621 (Accidental Self-Muting/Self-Blocking) - I found the area where the trouble is but did not know how to implement a fix. Left comment in jira. *FUTURE* *IMPEDIMENTS* - Oz, pick either my wiki page or yours, no need to have this duplicated. - STORM-435 (There is no space between name of object and value of object in Chat step while creating new gesture) - Done, but has not yet been processed through the system. Wolfpup Lowenhar ------------------------------ *PAST* - Worked @ RL . - STORM-236 : waiting for Oz's suggestions. - Attended Oz's OH. - Tested new Autobuild system for OS Devs and provided feedback. *FUTURE* - Work @ RL - VWR-24256 : continue to monitor. I see this still happening even with my latest build. *IMPEDIMENTS* - STORM-236 : waiting for Oz's suggestions. - Not enough time to actually work on code. Cummere Mayo ------------------------------ *PAST* - jira followups of snow and vwr issues - lots jira organization of voice failure issues - lost sl job - working on guest blog entry re storm-2 rumors - testing viewer dev builds - sketches for accordion replacement feature request *FUTURE* - more jira work - attending office hours - getting feedback and revising on http://jayrcelasecondlifetechnologist.blogspot.com/2011/01/what-is-storm-2.html *IMPEDIMENTS* - time - sick (again) - -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110201/765be802/attachment-0001.htm From sllists at boroon.dasgupta.ch Tue Feb 1 03:41:09 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Tue, 01 Feb 2011 12:41:09 +0100 Subject: [opensource-dev] "Nearby" people tab In-Reply-To: <4D475A6A.5070001@meadowlakearts.com> References: <915020.6066.qm@web23902.mail.ird.yahoo.com> <4D46BE92.1050707@lindenlab.com> <4D475A6A.5070001@meadowlakearts.com> Message-ID: <4D47F155.7050005@boroon.dasgupta.ch> Hi Dave On 02/01/2011 01:57 AM, Dave Booth wrote: > On 1/31/2011 07:52, Oz Linden (Scott Lawrence) wrote: >> It would be interesting to see what was in the log file for the period >> of time that the window was not properly filled in. > I intend to capture some more specific data in the next few days - will > involve laying out precisely positioned prims in 3 dimensions for an av > to sit on and probing what "NearMeRange" distances they appear and > disappear from the nearby tab to an alt sat on the zero-ref prim. If > properly designed, that study will establish any issues with height AGL, > "flat" (2d) vector magnitude and "true" (3d) vector magnitude. Will > include logfile capture and will advise. While broad testing is a very good idea, also to find yet unknown bugs, you might want to test the "interesting" values for this specific issue (and related ones) first, which are heights around 4 * (2^8 - 1) m == 1020 m, if the underlying cause of VWR-9326 and VWR-17050 are the same. Aimee and Henry provide some technical explanation of that value in comments on VWR-6484 . Note that a fix for VWR-17050 is being reviewed at https://codereview.secondlife.com/r/132/. If you document your test well, it could probably also be used to QA that fix. Cheers, Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110201/90796846/attachment.htm From oz at lindenlab.com Tue Feb 1 04:35:25 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Tue, 01 Feb 2011 07:35:25 -0500 Subject: [opensource-dev] Help prevent DOS line endings... Message-ID: <4D47FE0D.6030205@lindenlab.com> Other than a few files that appear to be completely Windows specific, and I did not know for sure did not require them, I've converted all the DOS line endings in viewer-development back to plain linefeeds. I'll be checking regularly for any that get added (hopefully before they get into the main repo) and advising the perpetrators of the error of their ways... So that I have a resource to direct them to, and to help prevent any new developers from committing this minor sin, we need a set of clear instructions on what Windows tools do this correctly and how to configure them to do so. Please help by adding to: https://wiki.secondlife.com/wiki/How_to_avoid_DOS_line_endings_in_Windows_tools From oz at lindenlab.com Tue Feb 1 04:38:22 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Tue, 01 Feb 2011 07:38:22 -0500 Subject: [opensource-dev] problems working with autobuild In-Reply-To: References: Message-ID: <4D47FEBE.4000004@lindenlab.com> On 2011-01-31 21:43, Twisted Laws wrote: > So I figured I'd give the autobuild method of building a try. I've > not made it far yet > and wondering if someone might give me a pointer on what I've done > wrong... > > I read: http://wiki.secondlife.com/wiki/Autobuild_Quick_Start > and read: > https://lists.secondlife.com/pipermail/opensource-dev/2011-January/005633.html > v-autobuild is from: https://bitbucket.org/mani_linden/viewer-autobuild > > I must be missing something here but I'm not sure what. The > autobuild/bin directory is > in the path. Python 2.6 installed. > > Thanks for any hints, session log follows (note that the ./setup.py > install fails, and i have > to use python setup.py install) > > dir: /cygdrive/c/dev/hgbuilds > $ cd autobuild > dir: /cygdrive/c/dev/hgbuilds/autobuild > $ ls > autobuild bin build setup.py > dir: /cygdrive/c/dev/hgbuilds/autobuild > $ ./setup.py install > ./setup.py: line 23: from: command not found > ./setup.py: line 27: PACKAGE_NAME: command not found > ./setup.py: line 28: LLAUTOBUILD_VERSION: command not found > ./setup.py: line 29: LLAUTOBUILD_SOURCE: command not found > ./setup.py: line 30: CLASSIFIERS: command not found > ./setup.py: line 41: ext_modules: command not found > ./setup.py: line 43: syntax error near unexpected token `newline' > ./setup.py: line 43: `setup(' > dir: /cygdrive/c/dev/hgbuilds/autobuild It looks as though your system does not realize that setup.py is a python file and is interpreting it as something else. Try: python setup.py -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110201/0e5d41c1/attachment.htm From latifer at streamgrid.net Tue Feb 1 06:13:02 2011 From: latifer at streamgrid.net (Latif Khalifa) Date: Tue, 1 Feb 2011 15:13:02 +0100 Subject: [opensource-dev] problems working with autobuild In-Reply-To: <366249.72721.qm@web43506.mail.sp1.yahoo.com> References: <366249.72721.qm@web43506.mail.sp1.yahoo.com> Message-ID: The old style build didn't work in cygwin shell either. It wanted cmake and python to be native windows versions. After deleting cygwin versions of those, all worked. Perhaps a similar thing can help for the autobuild? On Tue, Feb 1, 2011 at 4:07 AM, Nicky Perian wrote: > I can't tell but it looks like windows and you using cygwin, Is that > correct? > I was able to us the Visual Studio Command Prompt and all went as planned in > documentation save one patch from Oz. > Realize that isn't help. But, i didn't use cygwin and my Python was a > seperate install in windows. Did not use the cygwin version of Python. > > ________________________________ > From: Twisted Laws > To: SLDEV > Sent: Mon, January 31, 2011 8:43:01 PM > Subject: [opensource-dev] problems working with autobuild > > So I figured I'd give the autobuild method of building a try.?? I've not > made it far yet > and wondering if someone might give me a pointer on what I've done wrong... > > I read: http://wiki.secondlife.com/wiki/Autobuild_Quick_Start > and read: > https://lists.secondlife.com/pipermail/opensource-dev/2011-January/005633.html > v-autobuild is from: https://bitbucket.org/mani_linden/viewer-autobuild > > I must be missing something here but I'm not sure what.? The autobuild/bin > directory is > in the path.?? Python 2.6 installed. > > Thanks for any hints,? session log follows? (note that the ./setup.py > install fails, and i have > to use python setup.py install) > > dir: /cygdrive/c/dev/hgbuilds > $ cd autobuild > dir: /cygdrive/c/dev/hgbuilds/autobuild > $ ls > autobuild? bin? build? setup.py > dir: /cygdrive/c/dev/hgbuilds/autobuild > $ ./setup.py install > ./setup.py: line 23: from: command not found > ./setup.py: line 27: PACKAGE_NAME: command not found > ./setup.py: line 28: LLAUTOBUILD_VERSION: command not found > ./setup.py: line 29: LLAUTOBUILD_SOURCE: command not found > ./setup.py: line 30: CLASSIFIERS: command not found > ./setup.py: line 41: ext_modules: command not found > ./setup.py: line 43: syntax error near unexpected token `newline' > ./setup.py: line 43: `setup(' > dir: /cygdrive/c/dev/hgbuilds/autobuild > $ python setup.py install > running install > running build > running build_py > running build_scripts > running install_lib > running install_scripts > running install_egg_info > Removing C:\Python26\Lib\site-packages\autobuild-0.0.0-py2.6.egg-info > Writing C:\Python26\Lib\site-packages\autobuild-0.0.0-py2.6.egg-info > dir: /cygdrive/c/dev/hgbuilds/autobuild > $ cd ../v-autobuild > dir: /cygdrive/c/dev/hgbuilds/v-autobuild > $ autobuild configure -c OpenSourceRelWithDebInfo > C:\cygwin\bin\python: can't open file > '/cygdrive/c/dev/hgbuilds/autobuild/bin/autobuild': [Errno 2] No such file > or directory > dir: /cygdrive/c/dev/hgbuilds/v-autobuild > $ ls -l /cygdrive/c/dev/hgbuilds/autobuild/bin/autobuild > -rwxr-xr-x 1 John None 2213 Jan 31 20:37 > /cygdrive/c/dev/hgbuilds/autobuild/bin/autobuild > dir: /cygdrive/c/dev/hgbuilds/v-autobuild > $ > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > From wolfpup67 at earthlink.net Tue Feb 1 06:18:03 2011 From: wolfpup67 at earthlink.net (WolfPup Lowenhar) Date: Tue, 1 Feb 2011 09:18:03 -0500 Subject: [opensource-dev] problems working with autobuild In-Reply-To: References: <366249.72721.qm@web43506.mail.sp1.yahoo.com> Message-ID: <000001cbc21a$d743e3c0$85cbab40$@net> Im running autobuild from the windows cmd shell all I have to do right now is add the Vs2005 tools via vsvars32.bat then got the auto build folder and it all works im not running in any other cmd window. From: opensource-dev-bounces at lists.secondlife.com [mailto:opensource-dev-bounces at lists.secondlife.com] On Behalf Of Latif Khalifa Sent: Tuesday, February 01, 2011 9:13 AM To: Nicky Perian Cc: SLDEV Subject: Re: [opensource-dev] problems working with autobuild The old style build didn't work in cygwin shell either. It wanted cmake and python to be native windows versions. After deleting cygwin versions of those, all worked. Perhaps a similar thing can help for the autobuild? On Tue, Feb 1, 2011 at 4:07 AM, Nicky Perian wrote: > I can't tell but it looks like windows and you using cygwin, Is that > correct? > I was able to us the Visual Studio Command Prompt and all went as planned in > documentation save one patch from Oz. > Realize that isn't help. But, i didn't use cygwin and my Python was a > seperate install in windows. Did not use the cygwin version of Python. > > ________________________________ > From: Twisted Laws > To: SLDEV > Sent: Mon, January 31, 2011 8:43:01 PM > Subject: [opensource-dev] problems working with autobuild > > So I figured I'd give the autobuild method of building a try. I've not > made it far yet > and wondering if someone might give me a pointer on what I've done wrong... > > I read: http://wiki.secondlife.com/wiki/Autobuild_Quick_Start > and read: > https://lists.secondlife.com/pipermail/opensource-dev/2011-January/005633.ht ml > v-autobuild is from: https://bitbucket.org/mani_linden/viewer-autobuild > > I must be missing something here but I'm not sure what. The autobuild/bin > directory is > in the path. Python 2.6 installed. > > Thanks for any hints, session log follows (note that the ./setup.py > install fails, and i have > to use python setup.py install) > > dir: /cygdrive/c/dev/hgbuilds > $ cd autobuild > dir: /cygdrive/c/dev/hgbuilds/autobuild > $ ls > autobuild bin build setup.py > dir: /cygdrive/c/dev/hgbuilds/autobuild > $ ./setup.py install > ./setup.py: line 23: from: command not found > ./setup.py: line 27: PACKAGE_NAME: command not found > ./setup.py: line 28: LLAUTOBUILD_VERSION: command not found > ./setup.py: line 29: LLAUTOBUILD_SOURCE: command not found > ./setup.py: line 30: CLASSIFIERS: command not found > ./setup.py: line 41: ext_modules: command not found > ./setup.py: line 43: syntax error near unexpected token `newline' > ./setup.py: line 43: `setup(' > dir: /cygdrive/c/dev/hgbuilds/autobuild > $ python setup.py install > running install > running build > running build_py > running build_scripts > running install_lib > running install_scripts > running install_egg_info > Removing C:\Python26\Lib\site-packages\autobuild-0.0.0-py2.6.egg-info > Writing C:\Python26\Lib\site-packages\autobuild-0.0.0-py2.6.egg-info > dir: /cygdrive/c/dev/hgbuilds/autobuild > $ cd ../v-autobuild > dir: /cygdrive/c/dev/hgbuilds/v-autobuild > $ autobuild configure -c OpenSourceRelWithDebInfo > C:\cygwin\bin\python: can't open file > '/cygdrive/c/dev/hgbuilds/autobuild/bin/autobuild': [Errno 2] No such file > or directory > dir: /cygdrive/c/dev/hgbuilds/v-autobuild > $ ls -l /cygdrive/c/dev/hgbuilds/autobuild/bin/autobuild > -rwxr-xr-x 1 John None 2213 Jan 31 20:37 > /cygdrive/c/dev/hgbuilds/autobuild/bin/autobuild > dir: /cygdrive/c/dev/hgbuilds/v-autobuild > $ > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges _____ No virus found in this message. Checked by AVG - www.avg.com Version: 10.0.1204 / Virus Database: 1435/3416 - Release Date: 02/01/11 -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110201/26d65d25/attachment-0001.htm From latifer at streamgrid.net Tue Feb 1 06:42:46 2011 From: latifer at streamgrid.net (Latif Khalifa) Date: Tue, 1 Feb 2011 15:42:46 +0100 Subject: [opensource-dev] XMPP group chat questions Message-ID: Hi, Since I plan to implement the new XMPP chat available for the clients that are not based on the official viewer, I could use some documentation about the way the new group chat system. Perhaps the best way to start would be with a few questions. Some of these have already been answered by Gez during Oz'es OH, but perhaps it would be beneficial to have them in one place. 1) To which xmpp server should we connect. I'm assuming there will be a new field in the xmlrpc login response specifying it? 2) Apart from the login reponse to find out to which xmpp server to connect to, would there be any other dependency on sims, like getting a CAP to give you authenticated username? (Similar CAP is used to obtain Vivox voice server credentials). 3) Assuming there are no additional dependencies on sims, will the same credentials (username/password) be used to authenticate to xmpp server as those to login to SL? 4) Is group chat implemented based on standard MUC (multi user chat) specification XP-0045? 5) Assuming MUC is used, how is the client supposed to construct addresses of the conferees it's supposed to join. (conference_name at some.xmpps.host.com) 6) Will XMPP server be sending participant list that can be used in SL clients? We would need to know UUID of the participant in order to provide the functionality in the viewer, such us opening profiles, etc. (are we glad we have display names yet? :) 7) Is one of the design goals to allow pure xmpp clients to connect and participate in the group chat? 8) Proposed bridge between two group chat system for the transitional period, will it be sim <-> xmpp server or xmp server <-> legacy group chat backend Latif From vsavchuk at productengine.com Tue Feb 1 07:12:55 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 01 Feb 2011 15:12:55 -0000 Subject: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml In-Reply-To: <20110131231921.15713.85032@domU-12-31-38-00-90-68.compute-1.internal> References: <20110131231921.15713.85032@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110201151255.12851.27733@domU-12-31-38-00-90-68.compute-1.internal> > On Jan. 31, 2011, 3:19 p.m., Merov Linden wrote: > > Good I think. I'm assuming that localization hasn't left those outside strings.xml for a reason (like: make sure no one ever tries to translate them). No, there was no reason. It's just only two keys were initially localized (Home and End) that were described in STORM-362. Obviously, the added localization also introduced the "Missing String" warnings, so to avoid them we now have to localize all keys. - Vadim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review291 ----------------------------------------------------------- On Jan. 19, 2011, 8:30 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/108/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2011, 8:30 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Made all keys localizable. > > > This addresses bug STORM-465. > http://jira.secondlife.com/browse/STORM-465 > > > Diffs > ----- > > indra/newview/skins/default/xui/en/strings.xml 38465c40c060 > > Diff: http://codereview.secondlife.com/r/108/diff > > > Testing > ------- > > Tested on Linux. No keys produce the warning for me. > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110201/7e4d164b/attachment.htm From twisted_laws at hotmail.com Tue Feb 1 08:36:27 2011 From: twisted_laws at hotmail.com (Twisted Laws) Date: Tue, 1 Feb 2011 11:36:27 -0500 Subject: [opensource-dev] problems working with autobuild In-Reply-To: References: , <366249.72721.qm@web43506.mail.sp1.yahoo.com>, Message-ID: just to be clear here, i've no problems configuring and building in vc2005expess the old way. i start the process with "cmake ." in the indra directory in a cygwin window. then i open the .sln file with vc2005express and set the build type and build it. all is fine. I can also use the older way of "./develop.py -G vc80 configure". I don't see a visual studio 2005 command prompt in my vc2005express. i have python26 installed and the one in /usr/bin is linked to that python26. i can run develop.py with "./develop.py -G vc80 configure" and it works ok, so its not a wrong python error (one in /usr/bin is linked to python26). Every python script on my system worked until this one. but i don't understand this sequence... > > $ autobuild configure -c OpenSourceRelWithDebInfo > > C:\cygwin\bin\python: can't open file > > '/cygdrive/c/dev/hgbuilds/autobuild/bin/autobuild': [Errno 2] No such file > > or directory > > dir: /cygdrive/c/dev/hgbuilds/v-autobuild > > $ ls -l /cygdrive/c/dev/hgbuilds/autobuild/bin/autobuild > > -rwxr-xr-x 1 John None 2213 Jan 31 20:37 > > /cygdrive/c/dev/hgbuilds/autobuild/bin/autobuild where it says the file or directory doesn't exist yet it does... it obviously existed or python wouldn't have started to begin with. > The old style build didn't work in cygwin shell either. It wanted > cmake and python to be native windows versions. After deleting cygwin > versions of those, all worked. Perhaps a similar thing can help for > the autobuild? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110201/4be92791/attachment.htm From kf6kjg at gmail.com Tue Feb 1 08:47:36 2011 From: kf6kjg at gmail.com (Ricky) Date: Tue, 1 Feb 2011 08:47:36 -0800 Subject: [opensource-dev] Help prevent DOS line endings... In-Reply-To: <4D47FE0D.6030205@lindenlab.com> References: <4D47FE0D.6030205@lindenlab.com> Message-ID: Added Programmer's Notepad (my favorite for Windows). Ricky Cron Stardust On Tue, Feb 1, 2011 at 4:35 AM, Oz Linden (Scott Lawrence) wrote: > Other than a few files that appear to be completely Windows specific, > and I did not know for sure did not require them, I've converted all the > DOS line endings in viewer-development back to plain linefeeds. ?I'll be > checking regularly for any that get added (hopefully before they get > into the main repo) and advising the perpetrators of the error of their > ways... > > So that I have a resource to direct them to, and to help prevent any new > developers from committing this minor sin, we need a set of clear > instructions on what Windows tools do this correctly and how to > configure them to do so. ? Please help by adding to: > > https://wiki.secondlife.com/wiki/How_to_avoid_DOS_line_endings_in_Windows_tools > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges > From nickyperian at yahoo.com Tue Feb 1 09:57:53 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Tue, 1 Feb 2011 09:57:53 -0800 (PST) Subject: [opensource-dev] autobuild @ 442 (ffcfcf7cde2c) Bug? Message-ID: <547984.59040.qm@web43511.mail.sp1.yahoo.com> C:\lindenhg\viewer-autobuild-vc80>autobuild configure -c OpenSourceRelWithDebInf o CMake Error at cmake/Prebuilt.cmake:51 (message): Failed to download or unpack prebuilt 'ogg-vorbis'. Process returned The system cannot find the file specified. Call Stack (most recent call first): cmake/Audio.cmake:11 (use_prebuilt_binary) llaudio/CMakeLists.txt:6 (include) -- Configuring incomplete, errors occurred! ERROR: default configuration returned 1 For more information: try re-running your command with --verbose or --debug -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110201/339a7eda/attachment.htm From nickyperian at yahoo.com Tue Feb 1 10:02:05 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Tue, 1 Feb 2011 10:02:05 -0800 (PST) Subject: [opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something In-Reply-To: <20110128183452.488.3179@domU-12-31-38-00-90-68.compute-1.internal> References: <20110128132011.10694.10674@domU-12-31-38-00-90-68.compute-1.internal> <20110128183452.488.3179@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <670598.264.qm@web43516.mail.sp1.yahoo.com> the file ogg-vorbis-1.1.3-1.2.0-windows-20101001a.tar.bz2 is in autobuild.xml and is in the install.cache.xxxx and does download manually ________________________________ From: Nicky Perian To: Nicky Perian ; Oz Linden ; Viewer Sent: Fri, January 28, 2011 12:34:52 PM Subject: Re: Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/127/ Ship it! Worked as designed/explained. For other dummies like me if you did setup.py install before the patch, you need to repeat it to get the new patched version working in python. - Nicky On January 28th, 2011, 5:20 a.m., Oz Linden wrote: Review request for Viewer. By Oz Linden. Updated Jan. 28, 2011, 5:20 a.m. Description During initialization, if there is no scp or pscp command found then autobuild fails immediately. This is true whether or not any scp urls need to be used. This change modifies the behavior so that a warning is printed if no command is found, but execution proceeds until an scp command is needed, at which time execution fails with an explanatory message. This patch can print the warning multiple times - I didn't attempt to suppress the extras. Testing I've tested this locally, simulating the error by temporarily modifying the names of the commands to be found for scp. I have not checked it on Windows, where the original problem was found. Diffs * autobuild/common.py (f49808fe3c07) View Diff -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110201/e672fc4a/attachment-0001.htm From nickyperian at yahoo.com Tue Feb 1 10:04:30 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Tue, 1 Feb 2011 10:04:30 -0800 (PST) Subject: [opensource-dev] autobuild @ 442 (ffcfcf7cde2c) Bug? In-Reply-To: <547984.59040.qm@web43511.mail.sp1.yahoo.com> References: <547984.59040.qm@web43511.mail.sp1.yahoo.com> Message-ID: <645421.49025.qm@web43506.mail.sp1.yahoo.com> the file ogg-vorbis-1.1.3-1.2.0-windows-20101001a.tar.bz2 is in autobuild.xml and is in the install.cache.xxxx and does download manually ________________________________ From: Nicky Perian To: opensource-dev at lists.secondlife.com Sent: Tue, February 1, 2011 11:57:53 AM Subject: [opensource-dev] autobuild @ 442 (ffcfcf7cde2c) Bug? C:\lindenhg\viewer-autobuild-vc80>autobuild configure -c OpenSourceRelWithDebInf o CMake Error at cmake/Prebuilt.cmake:51 (message): Failed to download or unpack prebuilt 'ogg-vorbis'. Process returned The system cannot find the file specified. Call Stack (most recent call first): cmake/Audio.cmake:11 (use_prebuilt_binary) llaudio/CMakeLists.txt:6 (include) -- Configuring incomplete, errors occurred! ERROR: default configuration returned 1 For more information: try re-running your command with --verbose or --debug -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110201/49ecfe46/attachment.htm From nickyperian at yahoo.com Tue Feb 1 10:12:53 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Tue, 1 Feb 2011 10:12:53 -0800 (PST) Subject: [opensource-dev] problems working with autobuild In-Reply-To: References: , <366249.72721.qm@web43506.mail.sp1.yahoo.com>, Message-ID: <962825.58922.qm@web43509.mail.sp1.yahoo.com> In Microsoft Visual Studio->Tools->Visual Studio 2005 Command Prompt yields->> C:\VC80\vc\bin>"C:\VC80\Common7\Tools\vsvars32.bat" Setting environment for using Microsoft Visual Studio 2005 x86 tools. Then the Python Path is c:\Python26 ________________________________ From: Twisted Laws To: latifer at streamgrid.net; nickyperian at yahoo.com Cc: SLDEV Sent: Tue, February 1, 2011 10:36:27 AM Subject: RE: [opensource-dev] problems working with autobuild just to be clear here, i've no problems configuring and building in vc2005expess the old way. i start the process with "cmake ." in the indra directory in a cygwin window. then i open the .sln file with vc2005express and set the build type and build it. all is fine. I can also use the older way of "./develop.py -G vc80 configure". I don't see a visual studio 2005 command prompt in my vc2005express. i have python26 installed and the one in /usr/bin is linked to that python26. i can run develop.py with "./develop.py -G vc80 configure" and it works ok, so its not a wrong python error (one in /usr/bin is linked to python26). Every python script on my system worked until this one. but i don't understand this sequence... > > $ autobuild configure -c OpenSourceRelWithDebInfo > > C:\cygwin\bin\python: can't open file > > '/cygdrive/c/dev/hgbuilds/autobuild/bin/autobuild': [Errno 2] No such file > > or directory > > dir: /cygdrive/c/dev/hgbuilds/v-autobuild > > $ ls -l /cygdrive/c/dev/hgbuilds/autobuild/bin/autobuild > > -rwxr-xr-x 1 John None 2213 Jan 31 20:37 > > /cygdrive/c/dev/hgbuilds/autobuild/bin/autobuild where it says the file or directory doesn't exist yet it does... it obviously existed or python wouldn't have started to begin with. > The old style build didn't work in cygwin shell either. It wanted > cmake and python to be native windows versions. After deleting cygwin > versions of those, all worked. Perhaps a similar thing can help for > the autobuild? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110201/53651c77/attachment.htm From Celierra at gmail.com Tue Feb 1 10:54:16 2011 From: Celierra at gmail.com (Celierra Darling) Date: Tue, 1 Feb 2011 13:54:16 -0500 Subject: [opensource-dev] Help prevent DOS line endings... In-Reply-To: <4D47FE0D.6030205@lindenlab.com> References: <4D47FE0D.6030205@lindenlab.com> Message-ID: For those that have already followed the instructions there - the coding standard says to prefer tabs, not spaces, which is the opposite of what the page was instructing until just now. Celi On Tue, Feb 1, 2011 at 7:35 AM, Oz Linden (Scott Lawrence) wrote: > Other than a few files that appear to be completely Windows specific, > and I did not know for sure did not require them, I've converted all the > DOS line endings in viewer-development back to plain linefeeds. I'll be > checking regularly for any that get added (hopefully before they get > into the main repo) and advising the perpetrators of the error of their > ways... > > So that I have a resource to direct them to, and to help prevent any new > developers from committing this minor sin, we need a set of clear > instructions on what Windows tools do this correctly and how to > configure them to do so. Please help by adding to: > > > https://wiki.secondlife.com/wiki/How_to_avoid_DOS_line_endings_in_Windows_tools > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110201/e1d4d2ad/attachment.htm From gez at lindenlab.com Tue Feb 1 11:30:41 2011 From: gez at lindenlab.com (Gez Linden) Date: Tue, 1 Feb 2011 11:30:41 -0800 Subject: [opensource-dev] XMPP group chat questions In-Reply-To: References: Message-ID: Latif, Thank you for summarizing your questions and jumping in on this so quickly. My team just reviewed your questions and we have the following responses for you: > 1) To which xmpp server should we connect. I'm assuming there will be > > a new field in the xmlrpc login response specifying it? > Yes. 'xmpp_host' will be on aditi soon, as its the only grid that will have servers available initially. > > 2) Apart from the login reponse to find out to which xmpp server to > > connect to, would there be any other dependency on sims, like getting > > a CAP to give you authenticated username? (Similar CAP is used to > > obtain Vivox voice server credentials). > Nope > 3) Assuming there are no additional dependencies on sims, will the > > same credentials (username/password) be used to authenticate to xmpp > > server as those to login to SL? > The XMPP JID will be 'slid at chat.$grid.lindenlab.com', and password same as SL password. Make sure to use SSL/TLS, as the SASL mechanism is PLAIN. > 4) Is group chat implemented based on standard MUC (multi user chat) > > specification XP-0045? > Yes. > 5) Assuming MUC is used, how is the client supposed to construct > > addresses of the conferees it's supposed to join. > > (conference_name at some.xmpps.host.com) > For groups with only letters, numbers, and spaces, convert the spaces to '-' and you are good to go (that's - (dash) not _ (underscore)) The muc room jids will be 'your-group-name at conference.chat.aditi.lindenlab.com', where your-group-name follows the munging convention. We'll be posting the project viewer code that shows how we munge more complex group names to build the conference names, and we'll document it on the public wiki when we get closer to public release. > 6) Will XMPP server be sending participant list that can be used in SL > > clients? We would need to know UUID of the participant in order to > > provide the functionality in the viewer, such us opening profiles, > > etc. (are we glad we have display names yet? :) > The XMPP server will provide a room roster, yes, but will not provide UUIDs. For that, you'll need to connect to the People API via its sim capabilities to look up the SLID-to-UUID mapping. We are looking into how to provide a Display Name in the XMPP user information response, but it's not clear yet if we'll do this and which fields will contain that data if we do. > 7) Is one of the design goals to allow pure xmpp clients to connect > > and participate in the group chat? > Its a side benefit of our implementation rather than a design goal. We are still working on the long term product plan for chat, and how we should handle pure xmpp clients, so at the moment, its best to consider their support experimental and subject to change. > > 8) Proposed bridge between two group chat system for the transitional > > period, will it be sim <-> xmpp server or xmp server <-> legacy group > > chat backend > We have a few different ideas for how we're going to be supporting this. We are performing a few investigative dives after we release the project viewer to you guys, and we'll discuss transition strategy. Thanks again for firing up this conversation. The team is excited to work with you all on this and see us move to XMPP. - Gez -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110201/9938ff97/attachment-0001.htm From discrete.dreamscape at gmail.com Tue Feb 1 12:33:34 2011 From: discrete.dreamscape at gmail.com (Discrete Dreamscape) Date: Tue, 1 Feb 2011 15:33:34 -0500 Subject: [opensource-dev] Help prevent DOS line endings... In-Reply-To: References: <4D47FE0D.6030205@lindenlab.com> Message-ID: Possible cover-all solution: use Mercurial's "eol" extension. It's worked pretty well for me so far, and handily autofixed all the DOS endings in a particular fork I looked at in one go. It works much like the autoprops configuration does in Subversion; hopefully with less pain. Enable it (should be included by default in all recent versions, dunno about Tortoise) by adding the following section and options to your system-wide or repo-local .hgrc file: [extensions] eol = Then add a ".hgeol" file to the root of the repository (it can be versioned and thus easily distributed!), and fill it with whatever standard Mercurial pattern entries are needed, like so: [patterns] **.py = native **.txt = native **.h = native **.cpp = native **Makefile = LF As soon as this file exists and the extension is active for you, further hg commands will immediately treat any non-conforming line-endings as modifications to your current working copy. Hope this is helpful; if so, it could be added to that page as well. Discrete On Tue, Feb 1, 2011 at 1:54 PM, Celierra Darling wrote: > For those that have already followed the instructions there - the coding > standard says to prefer tabs, not spaces, which is the opposite of what the > page was instructing until just now. > > Celi > > > On Tue, Feb 1, 2011 at 7:35 AM, Oz Linden (Scott Lawrence) < > oz at lindenlab.com> wrote: > >> Other than a few files that appear to be completely Windows specific, >> and I did not know for sure did not require them, I've converted all the >> DOS line endings in viewer-development back to plain linefeeds. I'll be >> checking regularly for any that get added (hopefully before they get >> into the main repo) and advising the perpetrators of the error of their >> ways... >> >> So that I have a resource to direct them to, and to help prevent any new >> developers from committing this minor sin, we need a set of clear >> instructions on what Windows tools do this correctly and how to >> configure them to do so. Please help by adding to: >> >> >> https://wiki.secondlife.com/wiki/How_to_avoid_DOS_line_endings_in_Windows_tools >> >> _______________________________________________ >> Policies and (un)subscribe information available here: >> http://wiki.secondlife.com/wiki/OpenSource-Dev >> Please read the policies before posting to keep unmoderated posting >> privileges >> > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110201/b7cb8bf3/attachment.htm From latifer at streamgrid.net Tue Feb 1 12:48:07 2011 From: latifer at streamgrid.net (Latif Khalifa) Date: Tue, 1 Feb 2011 21:48:07 +0100 Subject: [opensource-dev] XMPP group chat questions In-Reply-To: References: Message-ID: Gez, Thank you very much for such a fast response. Just two small observations. Authentication takes it's sweet time, possible area to look into... And conference.chat.aditi.lindenlab.com doesn't currently resolve to anything (for those of us too impatient to wait for the project viewer :) Latif On Tue, Feb 1, 2011 at 8:30 PM, Gez Linden wrote: > Latif, > Thank you for summarizing your questions and jumping in on this so quickly. > ?My team just reviewed your questions and we have the following responses > for you: >> >> > 1) To which xmpp server should we connect. I'm assuming there will be >> > a new field in the xmlrpc login response specifying it? > > Yes. ?'xmpp_host' will be on aditi soon, as its the only grid that will have > servers available initially. > >> >> > 2) Apart from the login reponse to find out to which xmpp server to >> > connect to, would there be any other dependency on sims, like getting >> > a CAP to give you authenticated username? (Similar CAP is used to >> > obtain Vivox voice server credentials). > > Nope >> >> > 3) Assuming there are no additional dependencies on sims, will the >> > same credentials (username/password) be used to authenticate to xmpp >> > server as those to login to SL? > > > The XMPP JID will be 'slid at chat.$grid.lindenlab.com', and password > same as SL password. Make sure to use SSL/TLS, as the SASL mechanism > is PLAIN. >> >> > 4) Is group chat implemented based on standard MUC (multi user chat) >> > specification XP-0045? > > Yes. >> >> > 5) Assuming MUC is used, how is the client supposed to construct >> > addresses of the conferees it's supposed to join. >> > (conference_name at some.xmpps.host.com) > > For groups with only letters, numbers, and spaces, convert the spaces to '-' > and you are good to go (that's - (dash) not _ (underscore)) > The muc room jids will be > 'your-group-name at conference.chat.aditi.lindenlab.com', where > your-group-name follows the munging convention. > We'll be posting the project viewer code that shows how we munge more > complex group names to build the conference names, and we'll document it on > the public wiki when we get closer to public release. >> >> > 6) Will XMPP server be sending participant list that can be used in SL >> > clients? We would need to know UUID of the participant in order to >> > provide the functionality in the viewer, such us opening profiles, >> > etc. (are we glad we have display names yet? :) > > > The XMPP server will provide a room roster, yes, but will not provide > UUIDs. For that, you'll need to connect to the People API via its sim > capabilities to look up the SLID-to-UUID mapping. We are looking into > how to provide a Display Name in the XMPP user information response, > but it's not clear yet if we'll do this and which fields will contain > that data if we do. >> >> > 7) Is one of the design goals to allow pure xmpp clients to connect >> > and participate in the group chat? > > Its a side benefit of our implementation rather than a design goal. ?We are > still working on the long term product plan for chat, and how we should > handle pure xmpp clients, so at the moment, its best to consider their > support experimental and subject to change. > >> >> > 8) Proposed bridge between two group chat system for the transitional >> > period, will it be sim <-> xmpp server or xmp server <-> legacy group >> > chat backend > > We have a few different ideas for how we're going to be supporting this. ?We > are performing a few investigative dives after we release the project viewer > to you guys, and we'll discuss transition strategy. > Thanks again for firing up this conversation. ?The team is excited to work > with you all on this and see us move to XMPP. > - Gez > From twisted_laws at hotmail.com Tue Feb 1 13:33:11 2011 From: twisted_laws at hotmail.com (Twisted Laws) Date: Tue, 1 Feb 2011 16:33:11 -0500 Subject: [opensource-dev] problems working with autobuild In-Reply-To: <962825.58922.qm@web43509.mail.sp1.yahoo.com> References: , <366249.72721.qm@web43506.mail.sp1.yahoo.com>, , <962825.58922.qm@web43509.mail.sp1.yahoo.com> Message-ID: Thanks to Nicky, I've made it further. I didn't have a command prompt menu option in vc2005 express but i was able to find information on the net to help me create one. So now autobuild does run in a vc2005 command prompt window for me but still fails with the following (raw) log: (note at the end of it i did verify i was up-to-date) Setting environment for using Microsoft Visual Studio 2005 x86 tools. C:\Program Files (x86)\Microsoft Visual Studio 8\Common7\IDE>echo %PATH% C:\Program Files (x86)\Microsoft Visual Studio 8\Common7\IDE;C:\Program Files (x 86)\Microsoft Visual Studio 8\VC\BIN;C:\Program Files (x86)\Microsoft Visual Stu dio 8\Common7\Tools;C:\Program Files (x86)\Microsoft Visual Studio 8\SDK\v2.0\bi n;C:\Windows\Microsoft.NET\Framework\v2.0.50727;C:\Program Files (x86)\Microsoft Visual Studio 8\VC\VCPackages;C:\Program Files\Common Files\Microsoft Shared\Wi ndows Live;C:\Program Files (x86)\Common Files\Microsoft Shared\Windows Live;C:\ Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Program Files (x86)\Cybe rLink\Power2Go;C:\Program Files (x86)\ATI Technologies\ATI.ACE\Core-Static;c:\Pr ogram Files (x86)\Microsoft SQL Server\100\Tools\Binn\;c:\Program Files (x86)\Mi crosoft SQL Server\100\DTS\Binn\;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\ Program Files (x86)\QuickTime\QTSystem\;C:\Program Files (x86)\Mercurial\;C:\Pro gram Files (x86)\Windows Live\Shared;C:\Python26;C:\Program Files (x86)\CMake 2. 6\bin;C:\Program Files (x86)\Microsoft Visual Studio 8\VC\bin;C:\dev\hgbuilds\au tobuild\bin C:\Program Files (x86)\Microsoft Visual Studio 8\Common7\IDE>cd c:\dev\hgbuilds\ v-autobuild c:\dev\hgbuilds\v-autobuild>autobuild configure -c Release -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 8/VC/bin/cl.exe -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 8/VC/bin/cl.exe -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studi o 8/VC/bin/cl.exe -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studi o 8/VC/bin/cl.exe -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Using autobuild at: C:/dev/hgbuilds/autobuild/bin/autobuild.cmd unable to download file: Traceback (most recent call last): File "C:\Python26\Lib\site-packages\autobuild\common.py", line 243, in downloa d_package file(cachename, 'wb').write(urllib2.urlopen(package).read()) File "C:\Python26\lib\urllib2.py", line 124, in urlopen return _opener.open(url, data, timeout) File "C:\Python26\lib\urllib2.py", line 383, in open response = self._open(req, data) File "C:\Python26\lib\urllib2.py", line 401, in _open '_open', req) File "C:\Python26\lib\urllib2.py", line 361, in _call_chain result = func(*args) File "C:\Python26\lib\urllib2.py", line 1130, in http_open return self.do_open(httplib.HTTPConnection, req) File "C:\Python26\lib\urllib2.py", line 1105, in do_open raise URLError(err) URLError: ERROR: failed to download http://s3-proxy.lindenlab.com/private-builds-secondlif e-com/hg/repo/merov_fmod-autobuild/rev/219050/arch/CYGWIN/installer/fmod-3.75-wi ndows-20110113.tar.bz2 For more information: try re-running your command with --verbose or --debug CMake Error at cmake/Prebuilt.cmake:51 (message): Failed to download or unpack prebuilt 'fmod'. Process returned 1. Call Stack (most recent call first): cmake/FMOD.cmake:12 (use_prebuilt_binary) llaudio/CMakeLists.txt:8 (include) -- Configuring incomplete, errors occurred! ERROR: default configuration returned 1 For more information: try re-running your command with --verbose or --debug c:\dev\hgbuilds\v-autobuild>hg pull pulling from https://bitbucket.org/mani_linden/viewer-autobuild searching for changes no changes found c:\dev\hgbuilds\v-autobuild>cd ../autobuild c:\dev\hgbuilds\autobuild>hg pull pulling from https://bitbucket.org/lindenlab/autobuild searching for changes no changes found c:\dev\hgbuilds\autobuild> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110201/7cc7ada3/attachment.htm From nickyperian at yahoo.com Tue Feb 1 13:40:28 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Tue, 1 Feb 2011 13:40:28 -0800 (PST) Subject: [opensource-dev] problems working with autobuild In-Reply-To: References: , <366249.72721.qm@web43506.mail.sp1.yahoo.com>, , <962825.58922.qm@web43509.mail.sp1.yahoo.com> Message-ID: <638709.3248.qm@web43515.mail.sp1.yahoo.com> Twisted, Looks like a bad link. Nicky This webpage is not available. The webpage at http://s3-proxy.lindenlab.com/private-builds-secondlife-com/hg/repo/merov_fmod-autobuild/rev/219050/arch/CYGWIN/installer/fmod-3.75-windows-20110113.tar.bz2 might be temporarily down or it may have moved permanently to a new web address. More information on this error ________________________________ From: Twisted Laws To: nickyperian at yahoo.com Cc: SLDEV Sent: Tue, February 1, 2011 3:33:11 PM Subject: RE: [opensource-dev] problems working with autobuild Thanks to Nicky, I've made it further. I didn't have a command prompt menu option in vc2005 express but i was able to find information on the net to help me create one. So now autobuild does run in a vc2005 command prompt window for me but still fails with the following (raw) log: (note at the end of it i did verify i was up-to-date) Setting environment for using Microsoft Visual Studio 2005 x86 tools. C:\Program Files (x86)\Microsoft Visual Studio 8\Common7\IDE>echo %PATH% C:\Program Files (x86)\Microsoft Visual Studio 8\Common7\IDE;C:\Program Files (x 86)\Microsoft Visual Studio 8\VC\BIN;C:\Program Files (x86)\Microsoft Visual Stu dio 8\Common7\Tools;C:\Program Files (x86)\Microsoft Visual Studio 8\SDK\v2.0\bi n;C:\Windows\Microsoft.NET\Framework\v2.0.50727;C:\Program Files (x86)\Microsoft Visual Studio 8\VC\VCPackages;C:\Program Files\Common Files\Microsoft Shared\Wi ndows Live;C:\Program Files (x86)\Common Files\Microsoft Shared\Windows Live;C:\ Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Program Files (x86)\Cybe rLink\Power2Go;C:\Program Files (x86)\ATI Technologies\ATI.ACE\Core-Static;c:\Pr ogram Files (x86)\Microsoft SQL Server\100\Tools\Binn\;c:\Program Files (x86)\Mi crosoft SQL Server\100\DTS\Binn\;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\ Program Files (x86)\QuickTime\QTSystem\;C:\Program Files (x86)\Mercurial\;C:\Pro gram Files (x86)\Windows Live\Shared;C:\Python26;C:\Program Files (x86)\CMake 2. 6\bin;C:\Program Files (x86)\Microsoft Visual Studio 8\VC\bin;C:\dev\hgbuilds\au tobuild\bin C:\Program Files (x86)\Microsoft Visual Studio 8\Common7\IDE>cd c:\dev\hgbuilds\ v-autobuild c:\dev\hgbuilds\v-autobuild>autobuild configure -c Release -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 8/VC/bin/cl.exe -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 8/VC/bin/cl.exe -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studi o 8/VC/bin/cl.exe -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studi o 8/VC/bin/cl.exe -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Using autobuild at: C:/dev/hgbuilds/autobuild/bin/autobuild.cmd unable to download file: Traceback (most recent call last): File "C:\Python26\Lib\site-packages\autobuild\common.py", line 243, in downloa d_package file(cachename, 'wb').write(urllib2.urlopen(package).read()) File "C:\Python26\lib\urllib2.py", line 124, in urlopen return _opener.open(url, data, timeout) File "C:\Python26\lib\urllib2.py", line 383, in open response = self._open(req, data) File "C:\Python26\lib\urllib2.py", line 401, in _open '_open', req) File "C:\Python26\lib\urllib2.py", line 361, in _call_chain result = func(*args) File "C:\Python26\lib\urllib2.py", line 1130, in http_open return self.do_open(httplib.HTTPConnection, req) File "C:\Python26\lib\urllib2.py", line 1105, in do_open raise URLError(err) URLError: ERROR: failed to download http://s3-proxy.lindenlab.com/private-builds-secondlif e-com/hg/repo/merov_fmod-autobuild/rev/219050/arch/CYGWIN/installer/fmod-3.75-wi ndows-20110113.tar.bz2 For more information: try re-running your command with --verbose or --debug CMake Error at cmake/Prebuilt.cmake:51 (message): Failed to download or unpack prebuilt 'fmod'. Process returned 1. Call Stack (most recent call first): cmake/FMOD.cmake:12 (use_prebuilt_binary) llaudio/CMakeLists.txt:8 (include) -- Configuring incomplete, errors occurred! ERROR: default configuration returned 1 For more information: try re-running your command with --verbose or --debug c:\dev\hgbuilds\v-autobuild>hg pull pulling from https://bitbucket.org/mani_linden/viewer-autobuild searching for changes no changes found c:\dev\hgbuilds\v-autobuild>cd ../autobuild c:\dev\hgbuilds\autobuild>hg pull pulling from https://bitbucket.org/lindenlab/autobuild searching for changes no changes found c:\dev\hgbuilds\autobuild> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110201/8f247d3b/attachment-0001.htm From nickyperian at yahoo.com Tue Feb 1 13:44:46 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Tue, 1 Feb 2011 13:44:46 -0800 (PST) Subject: [opensource-dev] problems working with autobuild In-Reply-To: <638709.3248.qm@web43515.mail.sp1.yahoo.com> References: , <366249.72721.qm@web43506.mail.sp1.yahoo.com>, , <962825.58922.qm@web43509.mail.sp1.yahoo.com> <638709.3248.qm@web43515.mail.sp1.yahoo.com> Message-ID: <764384.48126.qm@web43514.mail.sp1.yahoo.com> Also, Might want to start with RelWithDebInfo. That seems to work. You may have found a Release Bug. ________________________________ From: Nicky Perian To: Twisted Laws Cc: SLDEV Sent: Tue, February 1, 2011 3:40:28 PM Subject: Re: [opensource-dev] problems working with autobuild Twisted, Looks like a bad link. Nicky This webpage is not available. The webpage at http://s3-proxy.lindenlab.com/private-builds-secondlife-com/hg/repo/merov_fmod-autobuild/rev/219050/arch/CYGWIN/installer/fmod-3.75-windows-20110113.tar.bz2 might be temporarily down or it may have moved permanently to a new web address. More information on this error ________________________________ From: Twisted Laws To: nickyperian at yahoo.com Cc: SLDEV Sent: Tue, February 1, 2011 3:33:11 PM Subject: RE: [opensource-dev] problems working with autobuild Thanks to Nicky, I've made it further. I didn't have a command prompt menu option in vc2005 express but i was able to find information on the net to help me create one. So now autobuild does run in a vc2005 command prompt window for me but still fails with the following (raw) log: (note at the end of it i did verify i was up-to-date) Setting environment for using Microsoft Visual Studio 2005 x86 tools. C:\Program Files (x86)\Microsoft Visual Studio 8\Common7\IDE>echo %PATH% C:\Program Files (x86)\Microsoft Visual Studio 8\Common7\IDE;C:\Program Files (x 86)\Microsoft Visual Studio 8\VC\BIN;C:\Program Files (x86)\Microsoft Visual Stu dio 8\Common7\Tools;C:\Program Files (x86)\Microsoft Visual Studio 8\SDK\v2.0\bi n;C:\Windows\Microsoft.NET\Framework\v2.0.50727;C:\Program Files (x86)\Microsoft Visual Studio 8\VC\VCPackages;C:\Program Files\Common Files\Microsoft Shared\Wi ndows Live;C:\Program Files (x86)\Common Files\Microsoft Shared\Windows Live;C:\ Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Program Files (x86)\Cybe rLink\Power2Go;C:\Program Files (x86)\ATI Technologies\ATI.ACE\Core-Static;c:\Pr ogram Files (x86)\Microsoft SQL Server\100\Tools\Binn\;c:\Program Files (x86)\Mi crosoft SQL Server\100\DTS\Binn\;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\ Program Files (x86)\QuickTime\QTSystem\;C:\Program Files (x86)\Mercurial\;C:\Pro gram Files (x86)\Windows Live\Shared;C:\Python26;C:\Program Files (x86)\CMake 2. 6\bin;C:\Program Files (x86)\Microsoft Visual Studio 8\VC\bin;C:\dev\hgbuilds\au tobuild\bin C:\Program Files (x86)\Microsoft Visual Studio 8\Common7\IDE>cd c:\dev\hgbuilds\ v-autobuild c:\dev\hgbuilds\v-autobuild>autobuild configure -c Release -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 8/VC/bin/cl.exe -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 8/VC/bin/cl.exe -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studi o 8/VC/bin/cl.exe -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studi o 8/VC/bin/cl.exe -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Using autobuild at: C:/dev/hgbuilds/autobuild/bin/autobuild.cmd unable to download file: Traceback (most recent call last): File "C:\Python26\Lib\site-packages\autobuild\common.py", line 243, in downloa d_package file(cachename, 'wb').write(urllib2.urlopen(package).read()) File "C:\Python26\lib\urllib2.py", line 124, in urlopen return _opener.open(url, data, timeout) File "C:\Python26\lib\urllib2.py", line 383, in open response = self._open(req, data) File "C:\Python26\lib\urllib2.py", line 401, in _open '_open', req) File "C:\Python26\lib\urllib2.py", line 361, in _call_chain result = func(*args) File "C:\Python26\lib\urllib2.py", line 1130, in http_open return self.do_open(httplib.HTTPConnection, req) File "C:\Python26\lib\urllib2.py", line 1105, in do_open raise URLError(err) URLError: ERROR: failed to download http://s3-proxy.lindenlab.com/private-builds-secondlif e-com/hg/repo/merov_fmod-autobuild/rev/219050/arch/CYGWIN/installer/fmod-3.75-wi ndows-20110113.tar.bz2 For more information: try re-running your command with --verbose or --debug CMake Error at cmake/Prebuilt.cmake:51 (message): Failed to download or unpack prebuilt 'fmod'. Process returned 1. Call Stack (most recent call first): cmake/FMOD.cmake:12 (use_prebuilt_binary) llaudio/CMakeLists.txt:8 (include) -- Configuring incomplete, errors occurred! ERROR: default configuration returned 1 For more information: try re-running your command with --verbose or --debug c:\dev\hgbuilds\v-autobuild>hg pull pulling from https://bitbucket.org/mani_linden/viewer-autobuild searching for changes no changes found c:\dev\hgbuilds\v-autobuild>cd ../autobuild c:\dev\hgbuilds\autobuild>hg pull pulling from https://bitbucket.org/lindenlab/autobuild searching for changes no changes found c:\dev\hgbuilds\autobuild> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110201/21d371bc/attachment.htm From wolfpup67 at earthlink.net Tue Feb 1 13:47:32 2011 From: wolfpup67 at earthlink.net (WolfPup Lowenhar) Date: Tue, 1 Feb 2011 16:47:32 -0500 Subject: [opensource-dev] problems working with autobuild In-Reply-To: <638709.3248.qm@web43515.mail.sp1.yahoo.com> References: , <366249.72721.qm@web43506.mail.sp1.yahoo.com>, , <962825.58922.qm@web43509.mail.sp1.yahoo.com> <638709.3248.qm@web43515.mail.sp1.yahoo.com> Message-ID: <001d01cbc259$a17d1c40$e47754c0$@net> Actually this is one of the issues that needs to be addressed as OS devs cannot get things like Fmod. From: opensource-dev-bounces at lists.secondlife.com [mailto:opensource-dev-bounces at lists.secondlife.com] On Behalf Of Nicky Perian Sent: Tuesday, February 01, 2011 4:40 PM To: Twisted Laws Cc: SLDEV Subject: Re: [opensource-dev] problems working with autobuild Twisted, Looks like a bad link. Nicky This webpage is not available. The webpage at http://s3-proxy.lindenlab.com/private-builds-secondlife-com/hg/repo/merov_fm od-autobuild/rev/219050/arch/CYGWIN/installer/fmod-3.75-windows-20110113.tar .bz2 might be temporarily down or it may have moved permanently to a new web address. More information on this error _____ From: Twisted Laws To: nickyperian at yahoo.com Cc: SLDEV Sent: Tue, February 1, 2011 3:33:11 PM Subject: RE: [opensource-dev] problems working with autobuild Thanks to Nicky, I've made it further. I didn't have a command prompt menu option in vc2005 express but i was able to find information on the net to help me create one. So now autobuild does run in a vc2005 command prompt window for me but still fails with the following (raw) log: (note at the end of it i did verify i was up-to-date) Setting environment for using Microsoft Visual Studio 2005 x86 tools. C:\Program Files (x86)\Microsoft Visual Studio 8\Common7\IDE>echo %PATH% C:\Program Files (x86)\Microsoft Visual Studio 8\Common7\IDE;C:\Program Files (x 86)\Microsoft Visual Studio 8\VC\BIN;C:\Program Files (x86)\Microsoft Visual Stu dio 8\Common7\Tools;C:\Program Files (x86)\Microsoft Visual Studio 8\SDK\v2.0\bi n;C:\Windows\Microsoft.NET\Framework\v2.0.50727;C:\Program Files (x86)\Microsoft Visual Studio 8\VC\VCPackages;C:\Program Files\Common Files\Microsoft Shared\Wi ndows Live;C:\Program Files (x86)\Common Files\Microsoft Shared\Windows Live;C:\ Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Program Files (x86)\Cybe rLink\Power2Go;C:\Program Files (x86)\ATI Technologies\ATI.ACE\Core-Static;c:\Pr ogram Files (x86)\Microsoft SQL Server\100\Tools\Binn\;c:\Program Files (x86)\Mi crosoft SQL Server\100\DTS\Binn\;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\ Program Files (x86)\QuickTime\QTSystem\;C:\Program Files (x86)\Mercurial\;C:\Pro gram Files (x86)\Windows Live\Shared;C:\Python26;C:\Program Files (x86)\CMake 2. 6\bin;C:\Program Files (x86)\Microsoft Visual Studio 8\VC\bin;C:\dev\hgbuilds\au tobuild\bin C:\Program Files (x86)\Microsoft Visual Studio 8\Common7\IDE>cd c:\dev\hgbuilds\ v-autobuild c:\dev\hgbuilds\v-autobuild>autobuild configure -c Release -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 8/VC/bin/cl.exe -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 8/VC/bin/cl.exe -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studi o 8/VC/bin/cl.exe -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studi o 8/VC/bin/cl.exe -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Using autobuild at: C:/dev/hgbuilds/autobuild/bin/autobuild.cmd unable to download file: Traceback (most recent call last): File "C:\Python26\Lib\site-packages\autobuild\common.py", line 243, in downloa d_package file(cachename, 'wb').write(urllib2.urlopen(package).read()) File "C:\Python26\lib\urllib2.py", line 124, in urlopen return _opener.open(url, data, timeout) File "C:\Python26\lib\urllib2.py", line 383, in open response = self._open(req, data) File "C:\Python26\lib\urllib2.py", line 401, in _open '_open', req) File "C:\Python26\lib\urllib2.py", line 361, in _call_chain result = func(*args) File "C:\Python26\lib\urllib2.py", line 1130, in http_open return self.do_open(httplib.HTTPConnection, req) File "C:\Python26\lib\urllib2.py", line 1105, in do_open raise URLError(err) URLError: ERROR: failed to download http://s3-proxy.lindenlab.com/private-builds-secondlif e-com/hg/repo/merov_fmod-autobuild/rev/219050/arch/CYGWIN/installer/fmod-3.7 5-wi ndows-20110113.tar.bz2 For more information: try re-running your command with --verbose or --debug CMake Error at cmake/Prebuilt.cmake:51 (message): Failed to download or unpack prebuilt 'fmod'. Process returned 1. Call Stack (most recent call first): cmake/FMOD.cmake:12 (use_prebuilt_binary) llaudio/CMakeLists.txt:8 (include) -- Configuring incomplete, errors occurred! ERROR: default configuration returned 1 For more information: try re-running your command with --verbose or --debug c:\dev\hgbuilds\v-autobuild>hg pull pulling from https://bitbucket.org/mani_linden/viewer-autobuild searching for changes no changes found c:\dev\hgbuilds\v-autobuild>cd ../autobuild c:\dev\hgbuilds\autobuild>hg pull pulling from https://bitbucket.org/lindenlab/autobuild searching for changes no changes found c:\dev\hgbuilds\autobuild> _____ No virus found in this message. Checked by AVG - www.avg.com Version: 10.0.1204 / Virus Database: 1435/3416 - Release Date: 02/01/11 -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110201/8de6508a/attachment-0001.htm From twisted_laws at hotmail.com Tue Feb 1 13:56:50 2011 From: twisted_laws at hotmail.com (Twisted Laws) Date: Tue, 1 Feb 2011 16:56:50 -0500 Subject: [opensource-dev] problems working with autobuild In-Reply-To: <001d01cbc259$a17d1c40$e47754c0$@net> References: , , <366249.72721.qm@web43506.mail.sp1.yahoo.com>, , , , <962825.58922.qm@web43509.mail.sp1.yahoo.com> , <638709.3248.qm@web43515.mail.sp1.yahoo.com>, <001d01cbc259$a17d1c40$e47754c0$@net> Message-ID: Ok, I figured out i made a mistake with -c Release... now i can't find devenv c:\dev\hgbuilds\v-autobuild>autobuild configure -c OpenSourceRelWithDebInfo package libuuid has no installation information configured for platform windows package fontconfig has no installation information configured for platform windo ws -- We seem to have an artwork bundle in the tree - brilliant. -- Version of viewer is 2.6.0.0 -- Configuring done -- Generating done -- Build files have been written to: C:/dev/hgbuilds/v-autobuild/build-vc80 c:\dev\hgbuilds\v-autobuild>autobuild build -c OpenSourceRelWithDebInfo package libuuid has no installation information configured for platform windows package fontconfig has no installation information configured for platform windo ws -- We seem to have an artwork bundle in the tree - brilliant. -- Version of viewer is 2.6.0.0 -- Configuring done -- Generating done -- Build files have been written to: C:/dev/hgbuilds/v-autobuild/build-vc80 'devenv.com' is not recognized as an internal or external command, operable program or batch file. ERROR: building default configuration returned 1 For more information: try re-running your command with --verbose or --debug c:\dev\hgbuilds\v-autobuild> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110201/de7b611e/attachment.htm From nickyperian at yahoo.com Tue Feb 1 14:08:57 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Tue, 1 Feb 2011 14:08:57 -0800 (PST) Subject: [opensource-dev] autobuild @ 442 (ffcfcf7cde2c) Bug? In-Reply-To: <645421.49025.qm@web43506.mail.sp1.yahoo.com> References: <547984.59040.qm@web43511.mail.sp1.yahoo.com> <645421.49025.qm@web43506.mail.sp1.yahoo.com> Message-ID: <203334.93102.qm@web43506.mail.sp1.yahoo.com> nm, it was a bad local repo. ________________________________ From: Nicky Perian To: Nicky Perian ; opensource-dev at lists.secondlife.com Sent: Tue, February 1, 2011 12:04:30 PM Subject: Re: [opensource-dev] autobuild @ 442 (ffcfcf7cde2c) Bug? the file ogg-vorbis-1.1.3-1.2.0-windows-20101001a.tar.bz2 is in autobuild.xml and is in the install.cache.xxxx and does download manually ________________________________ From: Nicky Perian To: opensource-dev at lists.secondlife.com Sent: Tue, February 1, 2011 11:57:53 AM Subject: [opensource-dev] autobuild @ 442 (ffcfcf7cde2c) Bug? C:\lindenhg\viewer-autobuild-vc80>autobuild configure -c OpenSourceRelWithDebInf o CMake Error at cmake/Prebuilt.cmake:51 (message): Failed to download or unpack prebuilt 'ogg-vorbis'. Process returned The system cannot find the file specified. Call Stack (most recent call first): cmake/Audio.cmake:11 (use_prebuilt_binary) llaudio/CMakeLists.txt:6 (include) -- Configuring incomplete, errors occurred! ERROR: default configuration returned 1 For more information: try re-running your command with --verbose or --debug -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110201/39c20344/attachment.htm From nickyperian at yahoo.com Tue Feb 1 15:06:46 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Tue, 1 Feb 2011 15:06:46 -0800 (PST) Subject: [opensource-dev] problems working with autobuild In-Reply-To: References: , , <366249.72721.qm@web43506.mail.sp1.yahoo.com>, , , , <962825.58922.qm@web43509.mail.sp1.yahoo.com> , <638709.3248.qm@web43515.mail.sp1.yahoo.com>, <001d01cbc259$a17d1c40$e47754c0$@net> Message-ID: <895142.34175.qm@web43506.mail.sp1.yahoo.com> The design of autobuild was for VS2005 Pro which is SL's only supported windows compiler. Express doesn't ship with devenv. So, until that is fixed autobuild is little more that a souped up develop.py. You can configure with it, but you will need to build the normal way with the IDE and build solution. ________________________________ From: Twisted Laws To: SLDEV Sent: Tue, February 1, 2011 3:56:50 PM Subject: Re: [opensource-dev] problems working with autobuild Ok, I figured out i made a mistake with -c Release... now i can't find devenv c:\dev\hgbuilds\v-autobuild>autobuild configure -c OpenSourceRelWithDebInfo package libuuid has no installation information configured for platform windows package fontconfig has no installation information configured for platform windo ws -- We seem to have an artwork bundle in the tree - brilliant. -- Version of viewer is 2.6.0.0 -- Configuring done -- Generating done -- Build files have been written to: C:/dev/hgbuilds/v-autobuild/build-vc80 c:\dev\hgbuilds\v-autobuild>autobuild build -c OpenSourceRelWithDebInfo package libuuid has no installation information configured for platform windows package fontconfig has no installation information configured for platform windo ws -- We seem to have an artwork bundle in the tree - brilliant. -- Version of viewer is 2.6.0.0 -- Configuring done -- Generating done -- Build files have been written to: C:/dev/hgbuilds/v-autobuild/build-vc80 'devenv.com' is not recognized as an internal or external command, operable program or batch file. ERROR: building default configuration returned 1 For more information: try re-running your command with --verbose or --debug c:\dev\hgbuilds\v-autobuild> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110201/75bfc2fa/attachment.htm From gez at lindenlab.com Tue Feb 1 16:48:44 2011 From: gez at lindenlab.com (Gez Linden) Date: Tue, 1 Feb 2011 16:48:44 -0800 Subject: [opensource-dev] XMPP group chat questions In-Reply-To: References: Message-ID: Latif, Not a problem. I'm happy to see all of you playing around with the system already. I believe you resolved the conference.chat problem, but just for the sake of pointing it out for the rest of the list, the system is hosted at chat.aditi.lindenlab.com, not conference.chat. I'll bring up the authentication issue internally as well. I'm curious what the root cause may be. Can you be more specific as to how you observed auth taking a long time? I'd like to try myself for comparison. Otherwise, the next step is getting this project viewer together for all of you and starting to test it out :) - Gez On Tue, Feb 1, 2011 at 12:48 PM, Latif Khalifa wrote: > Gez, > > Thank you very much for such a fast response. Just two small > observations. Authentication takes it's sweet time, possible area to > look into... > > And conference.chat.aditi.lindenlab.com doesn't currently resolve to > anything (for those of us too impatient to wait for the project viewer > :) > > Latif > > On Tue, Feb 1, 2011 at 8:30 PM, Gez Linden wrote: > > Latif, > > Thank you for summarizing your questions and jumping in on this so > quickly. > > My team just reviewed your questions and we have the following responses > > for you: > >> > >> > 1) To which xmpp server should we connect. I'm assuming there will be > >> > a new field in the xmlrpc login response specifying it? > > > > Yes. 'xmpp_host' will be on aditi soon, as its the only grid that will > have > > servers available initially. > > > >> > >> > 2) Apart from the login reponse to find out to which xmpp server to > >> > connect to, would there be any other dependency on sims, like getting > >> > a CAP to give you authenticated username? (Similar CAP is used to > >> > obtain Vivox voice server credentials). > > > > Nope > >> > >> > 3) Assuming there are no additional dependencies on sims, will the > >> > same credentials (username/password) be used to authenticate to xmpp > >> > server as those to login to SL? > > > > > > The XMPP JID will be 'slid at chat.$grid.lindenlab.com', and password > > same as SL password. Make sure to use SSL/TLS, as the SASL mechanism > > is PLAIN. > >> > >> > 4) Is group chat implemented based on standard MUC (multi user chat) > >> > specification XP-0045? > > > > Yes. > >> > >> > 5) Assuming MUC is used, how is the client supposed to construct > >> > addresses of the conferees it's supposed to join. > >> > (conference_name at some.xmpps.host.com) > > > > For groups with only letters, numbers, and spaces, convert the spaces to > '-' > > and you are good to go (that's - (dash) not _ (underscore)) > > The muc room jids will be > > 'your-group-name at conference.chat.aditi.lindenlab.com', where > > your-group-name follows the munging convention. > > We'll be posting the project viewer code that shows how we munge more > > complex group names to build the conference names, and we'll document it > on > > the public wiki when we get closer to public release. > >> > >> > 6) Will XMPP server be sending participant list that can be used in SL > >> > clients? We would need to know UUID of the participant in order to > >> > provide the functionality in the viewer, such us opening profiles, > >> > etc. (are we glad we have display names yet? :) > > > > > > The XMPP server will provide a room roster, yes, but will not provide > > UUIDs. For that, you'll need to connect to the People API via its sim > > capabilities to look up the SLID-to-UUID mapping. We are looking into > > how to provide a Display Name in the XMPP user information response, > > but it's not clear yet if we'll do this and which fields will contain > > that data if we do. > >> > >> > 7) Is one of the design goals to allow pure xmpp clients to connect > >> > and participate in the group chat? > > > > Its a side benefit of our implementation rather than a design goal. We > are > > still working on the long term product plan for chat, and how we should > > handle pure xmpp clients, so at the moment, its best to consider their > > support experimental and subject to change. > > > >> > >> > 8) Proposed bridge between two group chat system for the transitional > >> > period, will it be sim <-> xmpp server or xmp server <-> legacy group > >> > chat backend > > > > We have a few different ideas for how we're going to be supporting this. > We > > are performing a few investigative dives after we release the project > viewer > > to you guys, and we'll discuss transition strategy. > > Thanks again for firing up this conversation. The team is excited to > work > > with you all on this and see us move to XMPP. > > - Gez > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110201/fc755841/attachment-0001.htm From merov at lindenlab.com Tue Feb 1 18:26:28 2011 From: merov at lindenlab.com (Philippe (Merov) Bossut) Date: Tue, 1 Feb 2011 18:26:28 -0800 Subject: [opensource-dev] PO Test build (sprint 10 end game) Message-ID: Hi guys, Here are the binaries for the rest of sprint 10 bugs waiting for PO approval (+ 1 sprint 11): http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/220162/index.html Bug list: * STORM-219 : "Folders Always By Name" and "System Folders To Top" options are missing from the Inventory menu. Can't sort folders! * STORM-316 : Debug: Inventory.Folders by Name/Sort by Date/Sort by Name/System Folders to Top Do not apply and settings changes do not persist after relogging. * STORM-397 : Dropping wearables from a notecard to COF should be prohibited * STORM-507 : User that has sent p2p call invitation to other user, is not added to Recent tab * STORM-513 : "Allow media to auto - play" check-box is enable after Media check-box was unchecked * STORM-610 : Changes to Environment Editor: water color change is not saved * STORM-655 : mismatched filter extension in snapshot floater (jpeg vs jpg). Please test and report your finding. Folks with PO power (you know who you are...), add approval to the JIRAs and mark them for integration (click "Merge"). Cheers, - Merov -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110201/c6ba149b/attachment.htm From arrehn at gmail.com Tue Feb 1 19:36:22 2011 From: arrehn at gmail.com (Arrehn Oberlander) Date: Tue, 1 Feb 2011 22:36:22 -0500 Subject: [opensource-dev] Need Clarification on interfacing with web-based UI elements Message-ID: This is an open question I've tried to ask at a few different linden office hours, but haven't yet received a response one way or the other. There's a couple different viewer UI elements now in the pipeline that are effectively full web pages- the search window, and now the profile window. It seems like there is more to come. As a community developer interested in customizing that user interface for particular audiences, can LL clarify a best practice for working with these elements? From akanevsky at productengine.com Wed Feb 2 02:01:16 2011 From: akanevsky at productengine.com (Anya Kanevsky) Date: Wed, 2 Feb 2011 10:01:16 +0000 Subject: [opensource-dev] Daily Scrum Summary - Tuesday, February 1 Message-ID: Tuesday, February 1 General Notes ------------------------------ - Sprint planning today - no standup - MMOTD: Oz Team Status ------------------------------ Merov Linden ------------------------------ *PAST* - Triage JIRA for sprint planning meeting - Code reviews *FUTURE* - Sprint planning - STORM-746 : KDU Improvements: Compress j2c with precincts *IMPEDIMENTS* - none Grumpity ProductEngine ------------------------------ *PAST* - Sprint 11 Theme - Customization - Sprint review - jira wrangling to prep for sprint planning - find victim for inventory issues (STORM-526) - Maestro commented on STORM-379 (Buy copy of floater) *FUTURE* - Sprint planning - continue to prod others to resolve impediments - Product triage *IMPEDIMENTS* - moving Paul ProductEngine ------------------------------ *PAST* - BUG STORM-655 (mismatched filter extension in snapshot floater (jpeg vs jpg).) - Fixed and sent for review. - BUG STORM-680 (Avaline callers are added to the Recent list) - WIP. Estimate ~ 6-8 hours. *FUTURE* - BUG STORM-680 (Avaline callers are added to the Recent list) *IMPEDIMENTS* - none Seth Productengine ------------------------------ *PAST* - BUG (STORM-219) "Folders Always By Name" and "System Folders To Top" options are missing from the Inventory menu. Can't sort folders! - Fixed with patch for STORM-316. - BUG (STORM-433) Friendship offer shifted up and placed over "Second Life" text - Investigating how friendship offers notifications are placed inside IM chat history. *FUTURE* - BUG (STORM-433) Friendship offer shifted up and placed over "Second Life" text *IMPEDIMENTS* - STORM-316 Vadim Productengine ------------------------------ *PAST* - STORM-2 (Customizable viewer layouts): - Implementing saving sidetray state. ETA: 2d. *FUTURE* - Continue with STORM-2. *IMPEDIMENTS* - Bug STORM-465 (Missing Strings from strings.xml): - Waiting for Q to provide code-related feedback. Andrey ProductEngine ------------------------------ *PAST* - picked up 2.5.0 Beta3 r220094 build - smoke tests have been passed on Linux, OSX, and Windows, refer to the spreadsheet - integrity test has been failed by VWR-24681, but I think this is some kind of a server-side issue - 2.5.0 bug-fixes verification almost has been completed, refer to spreadsheet - 87 tickets marked as "Deferred" because TPE has no clue how to verify those - reported 4 tickets - picked up v-d 220024 build - verified 3 issues - proceeded with regression testing of v-d branch *FUTURE* - proceed with regression testing of v-d build *IMPEDIMENTS* - none Wolfpup Lowenhar ------------------------------ *PAST* - Worked @ RL . - STORM-236 : waiting for Oz's suggestions. - Attended Sprint Planning Metting. - Attended Merov?s OH. *FUTURE* - Work @ RL - STORM-941 : Dig into code and then email Oz and Leyla concerning possible fix as this is related to the DN code and there is some place that was missed in llimview that the logs still gets generated using legacy as a fallback instead of converting legacy to user name. *IMPEDIMENTS* - STORM-236 : waiting for Oz's suggestions. - Not enough time to actually work on code. Cummere Mayo ------------------------------ *PAST* - jira work - another blog post *FUTURE* - more jira work - more blogs *IMPEDIMENTS* - many -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110202/7adc7ee3/attachment-0001.htm From tateru at taterunino.net Wed Feb 2 03:11:31 2011 From: tateru at taterunino.net (Tateru Nino) Date: Wed, 02 Feb 2011 22:11:31 +1100 Subject: [opensource-dev] Need Clarification on interfacing with web-based UI elements In-Reply-To: References: Message-ID: <4D493BE3.5070300@taterunino.net> Seems to me that as more of that goes Web-side it needs more comprehensive standardization, documentation and versioning. On 2/02/2011 2:36 PM, Arrehn Oberlander wrote: > This is an open question I've tried to ask at a few different linden > office hours, but haven't yet received a response one way or the other. > > There's a couple different viewer UI elements now in the pipeline that > are effectively full web pages- the search window, and now the profile > window. It seems like there is more to come. > > As a community developer interested in customizing that user interface > for particular audiences, can LL clarify a best practice for working > with these elements? > > From a glance it appears that the presentation info and data model are > commingled, complicating client-side customization of the presentation. > > It may be possible to scrape out data, but unmanaged minor server-side > adjustments to the presentation page may break scraping activity > suddenly without warning. For an example of this, one can look at the > number of times LSL scripts which display profile pictures by scraping > UUID's from web lookups have been broken over the last few years. > > I'm hoping that LL can clarify which interface a community developer > can use to request and retreive this web-based data, particularly for > avatar profile page information, that will not be prone to casual > breakage after a third party viewer has been released. > > Thanks, and my apologies if the answer for this is someplace obvious > I've overlooked. > > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges -- Tateru Nino http://dwellonit.taterunino.net/ -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110202/9784b8e8/attachment.htm From nickyperian at yahoo.com Wed Feb 2 06:35:16 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Wed, 2 Feb 2011 06:35:16 -0800 (PST) Subject: [opensource-dev] autobuild project VCExpress Command Line Build Need Testers Message-ID: <754620.50605.qm@web43510.mail.sp1.yahoo.com> I tested this on my machine and in viewer-autobuild after "autobuild configure -c OpenSourceRelWithDebInfo" but, my machine has both Express and Pro present. From q at lindenlab.com Wed Feb 2 08:56:35 2011 From: q at lindenlab.com (Kent Quirk) Date: Wed, 02 Feb 2011 16:56:35 -0000 Subject: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml In-Reply-To: <20110119163030.25762.55317@domU-12-31-38-00-90-68.compute-1.internal> References: <20110119163030.25762.55317@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110202165635.12726.42047@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review307 ----------------------------------------------------------- So I have a couple of issues with this patch: * I'm worried about the translation impact, how these strings are used and where. Should they be localized? Should they not be localized? I find it hard to believe that we ONLY need to translate Home and End. * The "1" key is duplicated. Are there others? * I think the single-letter keys should be placed in a more useful order so that we can easily find missing items. Keyboard order (especially since keyboards differ) is not good enough. * I'm worried about the naming convention; single-letter names (ahem, yes, I know who's talking here) can be rather ambiguous. It's probably the easiest fix -- anything else may require much more extensive changes -- but I'm worried about this. Is this fix robust under localization? I haven't had time to investigate these issues yet; does someone else have the knowledge to discuss? - Kent On Jan. 19, 2011, 8:30 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/108/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2011, 8:30 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Made all keys localizable. > > > This addresses bug STORM-465. > http://jira.secondlife.com/browse/STORM-465 > > > Diffs > ----- > > indra/newview/skins/default/xui/en/strings.xml 38465c40c060 > > Diff: http://codereview.secondlife.com/r/108/diff > > > Testing > ------- > > Tested on Linux. No keys produce the warning for me. > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110202/1a2e0c34/attachment.htm From nickyperian at yahoo.com Wed Feb 2 09:03:54 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Wed, 2 Feb 2011 09:03:54 -0800 (PST) Subject: [opensource-dev] llpaneloutfitedit.cpp failure to compile with vs2010 and boost 1.45. Message-ID: <889176.46488.qm@web43516.mail.sp1.yahoo.com> std::for_each(item_set.begin(), item_set.end(), boost::bind( &uuid_vec_t::push_back, &uuid_list, _1)); ..\..\newview\llpaneloutfitedit.cpp(1332): error C2780: 'boost::_bi::bind_t<_bi::dm_result::type,boost::_mfi::dm,_bi::list_av_1::type> boost::bind(M T::* ,A1)' : expects 2 arguments - 3 provided C:\lindenhg\vcexpress2010build\libraries\include\boost/bind/bind.hpp(1728) : see declaration of 'boost::bind' I have diffed and boost1-39 and i cant find differences. Need pointers to help solve. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110202/d324a2a5/attachment.htm From vsavchuk at productengine.com Wed Feb 2 09:18:41 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Wed, 02 Feb 2011 17:18:41 -0000 Subject: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml In-Reply-To: <20110202165635.12726.42047@domU-12-31-38-00-90-68.compute-1.internal> References: <20110202165635.12726.42047@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110202171841.24962.57413@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 2, 2011, 8:56 a.m., Kent Quirk wrote: > > So I have a couple of issues with this patch: > > > > * I'm worried about the translation impact, how these strings are used and where. Should they be localized? Should they not be localized? I find it hard to believe that we ONLY need to translate Home and End. > > * The "1" key is duplicated. Are there others? > > * I think the single-letter keys should be placed in a more useful order so that we can easily find missing items. Keyboard order (especially since keyboards differ) is not good enough. > > * I'm worried about the naming convention; single-letter names (ahem, yes, I know who's talking here) can be rather ambiguous. It's probably the easiest fix -- anything else may require much more extensive changes -- but I'm worried about this. Is this fix robust under localization? > > > > I haven't had time to investigate these issues yet; does someone else have the knowledge to discuss? > > 1) AFAIU, only those keys need translation that are currrently used in menu shortcuts (see menu_*.xml). We don't know in advance what keys we're gonna use in future shortcuts, so it makes sense to make them all localizable. 2) Thanks, the "1" is indeed duplicated. Looks like a copy&paste issue. 3) Ok, the order doesn't matter to me. I can change it if you want. 4) I borrowed the naming style from existing code (see llkeyboard.cpp). Moreover, we tried adding "Key_" prefix to key names for the same reasons as you say, but had to roll that change back because it had broken translation of older shortcuts (see comments in STORM-362). - Vadim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review307 ----------------------------------------------------------- On Jan. 19, 2011, 8:30 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/108/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2011, 8:30 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Made all keys localizable. > > > This addresses bug STORM-465. > http://jira.secondlife.com/browse/STORM-465 > > > Diffs > ----- > > indra/newview/skins/default/xui/en/strings.xml 38465c40c060 > > Diff: http://codereview.secondlife.com/r/108/diff > > > Testing > ------- > > Tested on Linux. No keys produce the warning for me. > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110202/52ffbe3c/attachment-0001.htm From akanevsky at productengine.com Wed Feb 2 11:34:17 2011 From: akanevsky at productengine.com (Anya Kanevsky) Date: Wed, 2 Feb 2011 19:34:17 +0000 Subject: [opensource-dev] Daily Scrum Summary - Wednesday, February 2 Message-ID: Wednesday, February 2 General Notes ------------------------------ - Sprint 11 Theme - Customization - Please do not pick up issues tagged with needs-design until the tag has been removed. - MMOTD: Merov - Please remember to move issues to current Sprint when a) starting work on them or b) accepting issues from the community - Groundhog day! Team Status ------------------------------ Merov Linden ------------------------------ *PAST* - Meetings, meetings: sprint 11 planning, VWR triaging and OH all in one day... - PO build: done - Merge Monkeying: cleaned up sprint 10 and previous - Triage SNOW JIRA - Dig into Coverity findings *FUTURE* - MM - STORM-746 : KDU Improvements: Compress j2c with precincts *IMPEDIMENTS* - none Oz Linden ------------------------------ *PAST* - Meetings most of yesterday - Other non-Snowstorm activities *FUTURE* - Try to fix using autobuild with VS Express *IMPEDIMENTS* - snow, ice, snow, ice.... Q Linden ------------------------------ *PAST* - STORM-465 - Coverity stuff - triage - lots of ad hoc meetings - snow *FUTURE* - more snow - ooo doctor / pt - triage bot *IMPEDIMENTS* - none Grumpity ProductEngine ------------------------------ *PAST* - Sprint planning - VWR triage - Jira wrangling - updated needs-design issues - closed dupes of issues in current sprint - moved issues accepted from community into current sprint *FUTURE* - PEQA deferred issues triage with Bambers - continue to prod others to resolve impediments - STORM-379, STORM-465 *IMPEDIMENTS* - moving - sick Paul ProductEngine ------------------------------ *PAST* - BUG STORM-655 (mismatched filter extension in snapshot floater (jpeg vs jpg).) - Fixed and sent for review. - BUG STORM-680 (Avaline callers are added to the Recent list) - WIP. Estimate ~ 6-8 hours. *FUTURE* - BUG STORM-680 (Avaline callers are added to the Recent list) *IMPEDIMENTS* - none Seth Productengine ------------------------------ *PAST* - BUG (STORM-379) Content permissions aren't refreshed in the "Buy copy of" floater. - Investigating possible fix with updating "Buy copy of" floater each time it is shown. *FUTURE* - BUG (STORM-433) Friendship offer shifted up and placed over "Second Life" text *IMPEDIMENTS* - BUG (STORM-379) Content permissions aren't refreshed in the "Buy copy of" floater. - Asked in JIRA whether the bug should be fixed in a way that may increase server load. Vadim Productengine ------------------------------ *PAST* - STORM-2 (Customizable viewer layouts): - Implementing saving sidetray state. ETA: 1d. - Sprint planning meeting. *FUTURE* - Continue with STORM-2. *IMPEDIMENTS* - STORM-465 (Missing Strings from strings.xml): - Waiting for Q to provide code-related feedback. Andrey ProductEngine ------------------------------ *PAST* - picked up 2.5.0 Beta3 r220094 build - smoke tests have been passed on Linux, OSX, and Windows, refer to the spreadsheet - integrity test has been failed by VWR-24681, but I think this is some kind of a server-side issue - 2.5.0 bug-fixes verification almost has been completed, refer to spreadsheet - 87 tickets marked as "Deferred" because TPE has no clue how to verify those - reported 4 tickets - picked up v-d 220024 build - verified 3 issues - proceeded with regression testing of v-d branch *FUTURE* - proceed with regression testing of v-d build *IMPEDIMENTS* - none Wolfpup Lowenhar ------------------------------ *PAST* - Worked @ RL . - STORM-236 : read Oz's comments on JIRA - emailed Oz with comments concerning suggestions and what it could entail to get suggested capability in the context menu for the bottom tray and the other issues in the rest of the comment. - STORM-941 : Began looking in code for possible places where the issue could be happening. - Attended SnowStorm OH which ended up being canceled due to weather in Boston *FUTURE* - Work @ RL - STORM-941 : email Oz and Leyla concerning possible areas that could be causing the problem. *IMPEDIMENTS* - STORM-236 : waiting for new graphics and name to call the panel. - Not enough time to actually work on code. Jonathan Yap ------------------------------ *PAST* - VWR-24628 (Descriptive text missing next to first checkbox in About Land/Access) - This had to be fixed first in order to work on Storm - 953. 4 other people helped with this! This was my proudest moment as a developer. Great team effort. Easy fix but caused by low-level routine change. - STORM-953 (Clarify what happens when you uncheck Allow Public Access) - Needs a very quick design review. See image attached to jira https://jira.secondlife.com/secure/attachment/47772/AboutLandNote.png *FUTURE* *IMPEDIMENTS* - VWR - 24628 needs to be pulled in to Storm-nnnn - Waiting for Oz to Storm-nnnn-ize my bug list. Cummere Mayo ------------------------------ *PAST* - jira work - blog post to lindenwatch *FUTURE* - office hours - jira work - working on sl store *IMPEDIMENTS* - time - -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110202/eeeccb07/attachment-0001.htm From oz at lindenlab.com Wed Feb 2 12:01:30 2011 From: oz at lindenlab.com (Oz Linden) Date: Wed, 02 Feb 2011 20:01:30 -0000 Subject: [opensource-dev] Review Request: VWR-17050 No nearby people when over approxiamately 1000 meters In-Reply-To: <20110131233428.24962.43502@domU-12-31-38-00-90-68.compute-1.internal> References: <20110131233428.24962.43502@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110202200130.25231.61079@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/132/#review309 ----------------------------------------------------------- indra/newview/llworld.cpp I would strongly prefer to see this rearranged as properly nested if/then/else rather than using continue. Similarly, I'd like to have the break replaced by just adding another exit condition to the 'for' loop. - Oz On Jan. 31, 2011, 3:34 p.m., Twisted Laws wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/132/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2011, 3:34 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > This modifies the getAvatars function in llworld to also include any avatars that are found within the range from the LLCharactes list as well (the list of avatars that is in the viewer object list). This should make sure that anyone that you visually see within range shows up in the list. Note that changing it in this function also affects LLFloaterAvatarPicker::populateNearMe, LLLocalSpeakerMgr::updateSpeakerList, as well as the LLPanelPeople::updateNearbyList that was originally mentioned in the Jira. The region avatars lists only contain valid position data when the avatars are below 1024m. The comment that mentions about retrieving uuids is based on the function, not the current uses. No current calls in the code are done with the avatar_ids argument NULL. Duplicates in the returned list need to be suppressed. > > > This addresses bug VWR-17050. > http://jira.secondlife.com/browse/VWR-17050 > > > Diffs > ----- > > indra/newview/llworld.cpp 691e3941d950 > > Diff: http://codereview.secondlife.com/r/132/diff > > > Testing > ------- > > Simple testing in sandboxes of this patch at 20m and 2000m heights with and without avatars nearby. Tested with varying the NearMeRange to insure it does not show avatars beyond the range. Testers need to understand that RenderFarClip has an impact on the avatars that are actually in the viewer object list, so setting NearMeRange to a great distance at high altitude won't necessarily add avatars to the list. Basically if you can see the avatar and its within NearMeRange, the avatar should be in the nearby avatar list in the people panel. > > > Thanks, > > Twisted > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110202/b7e3e665/attachment.htm From oz at lindenlab.com Wed Feb 2 12:06:08 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Wed, 02 Feb 2011 15:06:08 -0500 Subject: [opensource-dev] Help prevent DOS line endings... In-Reply-To: References: <4D47FE0D.6030205@lindenlab.com> Message-ID: <4D49B930.4020005@lindenlab.com> On 2011-02-01 15:33, Discrete Dreamscape wrote: > Possible cover-all solution: use Mercurial's "eol" extension. It's > worked pretty well for me so far, and handily autofixed all the DOS > endings in a particular fork I looked at in one go. It works much like > the autoprops configuration does in Subversion; hopefully with less pain. > > Enable it (should be included by default in all recent versions, dunno > about Tortoise) by adding the following section and options to your > system-wide or repo-local .hgrc file: > > [extensions] > eol = > > Then add a ".hgeol" file to the root of the repository (it can be > versioned and thus easily distributed!), and fill it with whatever > standard Mercurial pattern entries are needed, like so: > > [patterns] > **.py = native > **.txt = native > **.h = native > **.cpp = native > **Makefile = LF > > As soon as this file exists and the extension is active for you, > further hg commands will immediately treat any non-conforming > line-endings as modifications to your current working copy. Hope this > is helpful; if so, it could be added to that page as well. I considered adding that, but didn't know whether some of the windows-specific files might be broken by it (if so, they too could be configured). Does anyone know? Could always put this into a test repo and run a TeamCity build.... From q at lindenlab.com Wed Feb 2 14:19:52 2011 From: q at lindenlab.com (Kent Quirk) Date: Wed, 02 Feb 2011 22:19:52 -0000 Subject: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml In-Reply-To: <20110202165635.12726.42047@domU-12-31-38-00-90-68.compute-1.internal> References: <20110202165635.12726.42047@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110202221952.12800.45879@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 2, 2011, 8:56 a.m., Kent Quirk wrote: > > So I have a couple of issues with this patch: > > > > * I'm worried about the translation impact, how these strings are used and where. Should they be localized? Should they not be localized? I find it hard to believe that we ONLY need to translate Home and End. > > * The "1" key is duplicated. Are there others? > > * I think the single-letter keys should be placed in a more useful order so that we can easily find missing items. Keyboard order (especially since keyboards differ) is not good enough. > > * I'm worried about the naming convention; single-letter names (ahem, yes, I know who's talking here) can be rather ambiguous. It's probably the easiest fix -- anything else may require much more extensive changes -- but I'm worried about this. Is this fix robust under localization? > > > > I haven't had time to investigate these issues yet; does someone else have the knowledge to discuss? > > > > Vadim ProductEngine wrote: > 1) AFAIU, only those keys need translation that are currrently used in menu shortcuts (see menu_*.xml). > We don't know in advance what keys we're gonna use in future shortcuts, so it makes sense to make them all localizable. > 2) Thanks, the "1" is indeed duplicated. Looks like a copy&paste issue. > 3) Ok, the order doesn't matter to me. I can change it if you want. > 4) I borrowed the naming style from existing code (see llkeyboard.cpp). Moreover, we tried adding "Key_" prefix to key names for the same reasons as you say, but had to roll that change back because it had broken translation of older shortcuts (see comments in STORM-362). I would like to see a revised changeset please, reflecting 2 and 3. I'm happy with your responses to 1 and 4. - Kent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review307 ----------------------------------------------------------- On Jan. 19, 2011, 8:30 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/108/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2011, 8:30 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Made all keys localizable. > > > This addresses bug STORM-465. > http://jira.secondlife.com/browse/STORM-465 > > > Diffs > ----- > > indra/newview/skins/default/xui/en/strings.xml 38465c40c060 > > Diff: http://codereview.secondlife.com/r/108/diff > > > Testing > ------- > > Tested on Linux. No keys produce the warning for me. > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110202/9b19843c/attachment.htm From frost0610 at hotmail.de Wed Feb 2 14:31:48 2011 From: frost0610 at hotmail.de (Torben Trautman) Date: Wed, 02 Feb 2011 22:31:48 -0000 Subject: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml In-Reply-To: <20110202165635.12726.42047@domU-12-31-38-00-90-68.compute-1.internal> References: <20110202165635.12726.42047@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110202223148.12728.15255@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 2, 2011, 8:56 a.m., Kent Quirk wrote: > > So I have a couple of issues with this patch: > > > > * I'm worried about the translation impact, how these strings are used and where. Should they be localized? Should they not be localized? I find it hard to believe that we ONLY need to translate Home and End. > > * The "1" key is duplicated. Are there others? > > * I think the single-letter keys should be placed in a more useful order so that we can easily find missing items. Keyboard order (especially since keyboards differ) is not good enough. > > * I'm worried about the naming convention; single-letter names (ahem, yes, I know who's talking here) can be rather ambiguous. It's probably the easiest fix -- anything else may require much more extensive changes -- but I'm worried about this. Is this fix robust under localization? > > > > I haven't had time to investigate these issues yet; does someone else have the knowledge to discuss? > > > > Vadim ProductEngine wrote: > 1) AFAIU, only those keys need translation that are currrently used in menu shortcuts (see menu_*.xml). > We don't know in advance what keys we're gonna use in future shortcuts, so it makes sense to make them all localizable. > 2) Thanks, the "1" is indeed duplicated. Looks like a copy&paste issue. > 3) Ok, the order doesn't matter to me. I can change it if you want. > 4) I borrowed the naming style from existing code (see llkeyboard.cpp). Moreover, we tried adding "Key_" prefix to key names for the same reasons as you say, but had to roll that change back because it had broken translation of older shortcuts (see comments in STORM-362). > > Kent Quirk wrote: > I would like to see a revised changeset please, reflecting 2 and 3. I'm happy with your responses to 1 and 4. There is a few more keys that have been localized or need to be localized. In german we also translated Shift (Umschalt) and Home (Zuhause)[which is a wrong translation by the way]. We still need to localize ` (snapshot to disk and region debug console shortcuts don?t work in german) and \ (Look at last speaker shortcut doesn?t work). I?m pretty sure this is also true at least for french. Hope this helps :) - Torben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review307 ----------------------------------------------------------- On Jan. 19, 2011, 8:30 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/108/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2011, 8:30 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Made all keys localizable. > > > This addresses bug STORM-465. > http://jira.secondlife.com/browse/STORM-465 > > > Diffs > ----- > > indra/newview/skins/default/xui/en/strings.xml 38465c40c060 > > Diff: http://codereview.secondlife.com/r/108/diff > > > Testing > ------- > > Tested on Linux. No keys produce the warning for me. > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110202/5d75334a/attachment.htm From discrete.dreamscape at gmail.com Wed Feb 2 15:33:31 2011 From: discrete.dreamscape at gmail.com (Discrete Dreamscape) Date: Wed, 2 Feb 2011 18:33:31 -0500 Subject: [opensource-dev] Help prevent DOS line endings... In-Reply-To: <4D49B930.4020005@lindenlab.com> References: <4D47FE0D.6030205@lindenlab.com> <4D49B930.4020005@lindenlab.com> Message-ID: This is from the help page on the extension: The optional "[repository]" section specifies the line endings to use for files stored in the repository. It has a single setting, "native", which determines the storage line endings for files declared as "native" in the "[patterns]" section. It can be set to "LF" or "CRLF". The default is "LF". For example, this means that on Windows, files configured as "native" ("CRLF" by default) will be converted to "LF" when stored in the repository. Files declared as "LF", "CRLF", or "BIN" in the "[patterns]" section are always stored as-is in the repository. Example versioned ".hgeol" file: [patterns] **.py = native **.vcproj = CRLF **.txt = native Makefile = LF **.jpg = BIN [repository] native = LF So if a file pattern is specifically declared to have Windows line-endings, it should remain that way for everyone and in the repository.. probably worth some quick testing. Discrete On Wed, Feb 2, 2011 at 3:06 PM, Oz Linden (Scott Lawrence) wrote: > On 2011-02-01 15:33, Discrete Dreamscape wrote: > >> Possible cover-all solution: use Mercurial's "eol" extension. It's worked >> pretty well for me so far, and handily autofixed all the DOS endings in a >> particular fork I looked at in one go. It works much like the autoprops >> configuration does in Subversion; hopefully with less pain. >> >> Enable it (should be included by default in all recent versions, dunno >> about Tortoise) by adding the following section and options to your >> system-wide or repo-local .hgrc file: >> >> [extensions] >> eol = >> >> Then add a ".hgeol" file to the root of the repository (it can be >> versioned and thus easily distributed!), and fill it with whatever standard >> Mercurial pattern entries are needed, like so: >> >> [patterns] >> **.py = native >> **.txt = native >> **.h = native >> **.cpp = native >> **Makefile = LF >> >> As soon as this file exists and the extension is active for you, further >> hg commands will immediately treat any non-conforming line-endings as >> modifications to your current working copy. Hope this is helpful; if so, it >> could be added to that page as well. >> > > I considered adding that, but didn't know whether some of the > windows-specific files might be broken by it (if so, they too could be > configured). Does anyone know? > > Could always put this into a test repo and run a TeamCity build.... > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110202/dcf05a22/attachment.htm From twisted_laws at hotmail.com Wed Feb 2 15:39:26 2011 From: twisted_laws at hotmail.com (Twisted Laws) Date: Wed, 02 Feb 2011 23:39:26 -0000 Subject: [opensource-dev] Review Request: VWR-17050 No nearby people when over approxiamately 1000 meters In-Reply-To: <20110131233428.24962.43502@domU-12-31-38-00-90-68.compute-1.internal> References: <20110131233428.24962.43502@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110202233926.12800.88482@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/132/ ----------------------------------------------------------- (Updated Feb. 2, 2011, 3:39 p.m.) Review request for Viewer. Changes ------- I redid the patch, hopefully making the comments more acceptable and took out the use of continue. I moved retrieval of the character positions before the world positions as I found cases where the information would be incorrect right near 1024 testing with a couple people below 1024, and a couple people above. Note this is a replacement patch. Summary ------- This modifies the getAvatars function in llworld to also include any avatars that are found within the range from the LLCharactes list as well (the list of avatars that is in the viewer object list). This should make sure that anyone that you visually see within range shows up in the list. Note that changing it in this function also affects LLFloaterAvatarPicker::populateNearMe, LLLocalSpeakerMgr::updateSpeakerList, as well as the LLPanelPeople::updateNearbyList that was originally mentioned in the Jira. The region avatars lists only contain valid position data when the avatars are below 1024m. The comment that mentions about retrieving uuids is based on the function, not the current uses. No current calls in the code are done with the avatar_ids argument NULL. Duplicates in the returned list need to be suppressed. This addresses bug VWR-17050. http://jira.secondlife.com/browse/VWR-17050 Diffs (updated) ----- indra/newview/llworld.cpp ebd53632620a Diff: http://codereview.secondlife.com/r/132/diff Testing ------- Simple testing in sandboxes of this patch at 20m and 2000m heights with and without avatars nearby. Tested with varying the NearMeRange to insure it does not show avatars beyond the range. Testers need to understand that RenderFarClip has an impact on the avatars that are actually in the viewer object list, so setting NearMeRange to a great distance at high altitude won't necessarily add avatars to the list. Basically if you can see the avatar and its within NearMeRange, the avatar should be in the nearby avatar list in the people panel. Thanks, Twisted -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110202/f5bb7e4d/attachment-0001.htm From merov at lindenlab.com Wed Feb 2 18:30:52 2011 From: merov at lindenlab.com (Merov Linden) Date: Thu, 03 Feb 2011 02:30:52 -0000 Subject: [opensource-dev] Review Request: STORM-864: As as developer, I would like an object oriented wrapper to make safe use of memory pools easier In-Reply-To: <20110129171032.30499.44865@domU-12-31-38-00-90-68.compute-1.internal> References: <20110129171032.30499.44865@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110203023052.1721.82839@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/99/#review315 ----------------------------------------------------------- indra/llcommon/llaprpool.h I think it's be more clear to use an explicit name like "getAPRPool()" rather than the function operator here. It produces hard to read code in a couple of places and it's just plain unclear what "myPool()" really does. indra/llmessage/llpumpio.cpp An example where the use of operator() is particularly unsightly... - Merov On Jan. 29, 2011, 9:10 a.m., Aleric Inglewood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/99/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2011, 9:10 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Please see http://jira.secondlife.com/browse/STORM-864 > > I made a mercurial repository available for testing here: > > hg clone https://bitbucket.org/aleric/viewer-development-storm-864 > > From the commit message: > > Introduces a LLThreadLocalData class that can be > accessed through the static LLThread::tldata(). > Currently this object contains two (public) thread-local > objects: a LLAPRRootPool and a LLVolatileAPRPool. > > The first is the general memory pool used by this thread > (and this thread alone), while the second is intended > for short lived memory allocations (needed for APR). > The advantages of not mixing those two is that the latter > is used most frequently, and as a result of it's nature > can be destroyed and reconstructed on a "regular" basis. > > This patch adds LLAPRPool (completely replacing the old one), > which is a wrapper around apr_pool_t* and has complete > thread-safity checking. > > Whenever an apr call requires memory for some resource, > a memory pool in the form of an LLAPRPool object can > be created with the same life-time as this resource; > assuring clean up of the memory no sooner, but also > not much later than the life-time of the resource > that needs the memory. > > Many, many function calls and constructors had the > pool parameter simply removed (it is no longer the > concern of the developer, if you don't write code > that actually does an libapr call then you are no > longer bothered with memory pools at all). > > However, I kept the notion of short-lived and > long-lived allocations alive (see my remark in > the jira here: https://jira.secondlife.com/browse/STORM-864?focusedCommentId=235356&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-235356 > which requires that the LLAPRFile API needs > to allow the user to specify how long they > think a file will stay open. By choosing > 'short_lived' as default for the constructor > that immediately opens a file, the number of > instances where this needs to be specified is > drastically reduced however (obviously, any > automatic LLAPRFile is short lived). > > > This addresses bug STORM-864. > http://jira.secondlife.com/browse/STORM-864 > > > Diffs > ----- > > doc/contributions.txt fe7fe04ccc9a > indra/llaudio/llaudioengine_fmod.cpp fe7fe04ccc9a > indra/llaudio/llvorbisencode.cpp fe7fe04ccc9a > indra/llcharacter/llbvhloader.cpp fe7fe04ccc9a > indra/llcharacter/llkeyframemotionparam.cpp fe7fe04ccc9a > indra/llcharacter/llstatemachine.cpp fe7fe04ccc9a > indra/llcommon/CMakeLists.txt fe7fe04ccc9a > indra/llcommon/llapp.cpp fe7fe04ccc9a > indra/llcommon/llapr.h fe7fe04ccc9a > indra/llcommon/llapr.cpp fe7fe04ccc9a > indra/llcommon/llaprpool.h PRE-CREATION > indra/llcommon/llaprpool.cpp PRE-CREATION > indra/llcommon/llcommon.h fe7fe04ccc9a > indra/llcommon/llcommon.cpp fe7fe04ccc9a > indra/llcommon/llerror.h fe7fe04ccc9a > indra/llcommon/llerror.cpp fe7fe04ccc9a > indra/llcommon/llfixedbuffer.cpp fe7fe04ccc9a > indra/llcommon/llscopedvolatileaprpool.h PRE-CREATION > indra/llcommon/llthread.h fe7fe04ccc9a > indra/llcommon/llthread.cpp fe7fe04ccc9a > indra/llcommon/llthreadsafequeue.h fe7fe04ccc9a > indra/llcommon/llthreadsafequeue.cpp fe7fe04ccc9a > indra/llcommon/llworkerthread.h fe7fe04ccc9a > indra/llcommon/llworkerthread.cpp fe7fe04ccc9a > indra/llcrashlogger/llcrashlogger.cpp fe7fe04ccc9a > indra/llimage/llimage.cpp fe7fe04ccc9a > indra/llimage/llimagedimensionsinfo.cpp fe7fe04ccc9a > indra/llimage/llimagej2c.cpp fe7fe04ccc9a > indra/llimage/llimageworker.h fe7fe04ccc9a > indra/llimage/llimageworker.cpp fe7fe04ccc9a > indra/llmath/llvolumemgr.cpp fe7fe04ccc9a > indra/llmessage/llares.cpp fe7fe04ccc9a > indra/llmessage/llcurl.cpp fe7fe04ccc9a > indra/llmessage/lliohttpserver.h fe7fe04ccc9a > indra/llmessage/lliohttpserver.cpp fe7fe04ccc9a > indra/llmessage/lliosocket.h fe7fe04ccc9a > indra/llmessage/lliosocket.cpp fe7fe04ccc9a > indra/llmessage/llmail.h fe7fe04ccc9a > indra/llmessage/llmail.cpp fe7fe04ccc9a > indra/llmessage/llpumpio.h fe7fe04ccc9a > indra/llmessage/llpumpio.cpp fe7fe04ccc9a > indra/llmessage/llurlrequest.cpp fe7fe04ccc9a > indra/llmessage/message.cpp fe7fe04ccc9a > indra/llmessage/tests/networkio.h fe7fe04ccc9a > indra/llplugin/llplugininstance.h fe7fe04ccc9a > indra/llplugin/llplugininstance.cpp fe7fe04ccc9a > indra/llplugin/llpluginmessagepipe.cpp fe7fe04ccc9a > indra/llplugin/llpluginprocesschild.cpp fe7fe04ccc9a > indra/llplugin/llpluginprocessparent.h fe7fe04ccc9a > indra/llplugin/llpluginprocessparent.cpp fe7fe04ccc9a > indra/llplugin/llpluginsharedmemory.h fe7fe04ccc9a > indra/llplugin/llpluginsharedmemory.cpp fe7fe04ccc9a > indra/llplugin/slplugin/slplugin.cpp fe7fe04ccc9a > indra/llvfs/lllfsthread.cpp fe7fe04ccc9a > indra/llvfs/llvfs.cpp fe7fe04ccc9a > indra/media_plugins/gstreamer010/llmediaimplgstreamer.h fe7fe04ccc9a > indra/media_plugins/gstreamer010/llmediaimplgstreamer_syms.cpp fe7fe04ccc9a > indra/media_plugins/webkit/linux_volume_catcher.cpp fe7fe04ccc9a > indra/newview/llappviewer.h fe7fe04ccc9a > indra/newview/llappviewer.cpp fe7fe04ccc9a > indra/newview/llappviewerlinux.cpp fe7fe04ccc9a > indra/newview/llappviewerlinux_api_dbus.cpp fe7fe04ccc9a > indra/newview/llappviewermacosx.cpp fe7fe04ccc9a > indra/newview/llfloateranimpreview.cpp fe7fe04ccc9a > indra/newview/llmainlooprepeater.cpp fe7fe04ccc9a > indra/newview/lltexturecache.h fe7fe04ccc9a > indra/newview/lltexturecache.cpp fe7fe04ccc9a > indra/newview/lltexturefetch.cpp fe7fe04ccc9a > indra/newview/llviewermenufile.cpp fe7fe04ccc9a > indra/newview/llvoavatar.cpp fe7fe04ccc9a > indra/newview/llvocache.h fe7fe04ccc9a > indra/newview/llvocache.cpp fe7fe04ccc9a > indra/newview/llvoicevivox.cpp fe7fe04ccc9a > indra/newview/llwatchdog.cpp fe7fe04ccc9a > indra/newview/tests/llworldmap_test.cpp fe7fe04ccc9a > indra/test/lltemplatemessagebuilder_tut.cpp fe7fe04ccc9a > indra/test/message_tut.cpp fe7fe04ccc9a > indra/test/test.cpp fe7fe04ccc9a > indra/test_apps/llplugintest/llmediaplugintest.cpp fe7fe04ccc9a > indra/viewer_components/updater/llupdateinstaller.cpp fe7fe04ccc9a > > Diff: http://codereview.secondlife.com/r/99/diff > > > Testing > ------- > > Compiles and viewer functions normally. > > The new classes (LLAPRPool, LLThreadLocalData) and the LLAPRFile changes have been tested a lot more extensive, since they have been used as-is for months in imprudence and before that in my own viewer (since April). However, the patch contains changes to code elsewhere (to adapt it to the new API) that is rather new in this source tree. Note that changes with regard to LLAPRFile already have been in Snowglobe since version 1.1 (with some minor changes) including the method used to make thread-local data available. > > > Thanks, > > Aleric > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110203/b3fda525/attachment-0001.htm From nickyperian at yahoo.com Wed Feb 2 22:33:36 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Wed, 2 Feb 2011 22:33:36 -0800 (PST) Subject: [opensource-dev] autobuild vcexpress 2005 Message-ID: <303576.17641.qm@web43505.mail.sp1.yahoo.com> Here are somevery rough hacks to force an Express autobuild. But it did build "Yay" /autobuild/autobuild autobuild_tool_source_environment.py.patch /viewer-autobuild autobuild.xml.patch //Most changes are here. autobconf.bat //configure autobb.bat //build There are likely more changes than needed. ToDo: work to make it work both with deven.com and vcbuild.exe Remove stuff that isn't needed. through shakedown. devenv and vcbuild have opposite parameter structures and vcbuild doesn't use /build Nicky -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110202/8d421219/attachment.htm -------------- next part -------------- A non-text attachment was scrubbed... Name: autobb.bat Type: application/octet-stream Size: 51 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110202/8d421219/attachment.obj -------------- next part -------------- A non-text attachment was scrubbed... Name: autobconf.bat Type: application/octet-stream Size: 90 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110202/8d421219/attachment-0001.obj -------------- next part -------------- A non-text attachment was scrubbed... Name: autobuild.xml.patch Type: application/octet-stream Size: 5183 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110202/8d421219/attachment-0002.obj -------------- next part -------------- A non-text attachment was scrubbed... Name: autobuild_tool_source_environment.py.patch Type: application/octet-stream Size: 941 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110202/8d421219/attachment-0003.obj From akanevsky at productengine.com Thu Feb 3 00:51:16 2011 From: akanevsky at productengine.com (Anya Kanevsky) Date: Thu, 3 Feb 2011 08:51:16 +0000 Subject: [opensource-dev] PO Test build (sprint 10 end game) In-Reply-To: References: Message-ID: Merov, are you sure this build is correct? I tried all issues in the list with this build (220162) and each one failed. a 2011/2/2 Philippe (Merov) Bossut > Hi guys, > > Here are the binaries for the rest of sprint 10 bugs waiting for PO > approval (+ 1 sprint 11): > > http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/220162/index.html > > Bug list: > * STORM-219 : "Folders Always By Name" and "System Folders To Top" options > are missing from the Inventory menu. Can't sort folders! > * STORM-316 : Debug: Inventory.Folders by Name/Sort by Date/Sort by > Name/System Folders to Top Do not apply and settings changes do not persist > after relogging. > * STORM-397 : Dropping wearables from a notecard to COF should be > prohibited > * STORM-507 : User that has sent p2p call invitation to other user, is not > added to Recent tab > * STORM-513 : "Allow media to auto - play" check-box is enable after Media > check-box was unchecked > * STORM-610 : Changes to Environment Editor: water color change is not > saved > * STORM-655 : mismatched filter extension in snapshot floater (jpeg vs > jpg). > > Please test and report your finding. Folks with PO power (you know who you > are...), add approval to the JIRAs and mark them for integration (click > "Merge"). > > Cheers, > - Merov > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110203/d0560527/attachment.htm From oz at lindenlab.com Thu Feb 3 05:06:48 2011 From: oz at lindenlab.com (Oz Linden) Date: Thu, 03 Feb 2011 13:06:48 -0000 Subject: [opensource-dev] Review Request: VWR-17050 No nearby people when over approxiamately 1000 meters In-Reply-To: <20110202233926.12800.88482@domU-12-31-38-00-90-68.compute-1.internal> References: <20110202233926.12800.88482@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110203130648.15713.38161@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/132/#review316 ----------------------------------------------------------- Ship it! - Oz On Feb. 2, 2011, 3:39 p.m., Twisted Laws wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/132/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2011, 3:39 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > This modifies the getAvatars function in llworld to also include any avatars that are found within the range from the LLCharactes list as well (the list of avatars that is in the viewer object list). This should make sure that anyone that you visually see within range shows up in the list. Note that changing it in this function also affects LLFloaterAvatarPicker::populateNearMe, LLLocalSpeakerMgr::updateSpeakerList, as well as the LLPanelPeople::updateNearbyList that was originally mentioned in the Jira. The region avatars lists only contain valid position data when the avatars are below 1024m. The comment that mentions about retrieving uuids is based on the function, not the current uses. No current calls in the code are done with the avatar_ids argument NULL. Duplicates in the returned list need to be suppressed. > > > This addresses bug VWR-17050. > http://jira.secondlife.com/browse/VWR-17050 > > > Diffs > ----- > > indra/newview/llworld.cpp ebd53632620a > > Diff: http://codereview.secondlife.com/r/132/diff > > > Testing > ------- > > Simple testing in sandboxes of this patch at 20m and 2000m heights with and without avatars nearby. Tested with varying the NearMeRange to insure it does not show avatars beyond the range. Testers need to understand that RenderFarClip has an impact on the avatars that are actually in the viewer object list, so setting NearMeRange to a great distance at high altitude won't necessarily add avatars to the list. Basically if you can see the avatar and its within NearMeRange, the avatar should be in the nearby avatar list in the people panel. > > > Thanks, > > Twisted > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110203/d105b7ab/attachment.htm From arrehn at gmail.com Thu Feb 3 08:13:27 2011 From: arrehn at gmail.com (Arrehn Oberlander) Date: Thu, 3 Feb 2011 11:13:27 -0500 Subject: [opensource-dev] Need Clarification on interfacing with web-based UI elements In-Reply-To: References: Message-ID: I'm concerned that I haven't received a response. I've already asked this question a few times at office hours for Lindens involved in development, and now here. Even if the answer is "LL will not support a a stable API to web services" at least it is some kind of answer. "LL will continue to provide existing non-web APIs for this same data for the indefinite future" may be an option as well, but I haven't heard this either. "We're working on this, check back in a month" is also an answer that would be welcomed over silence. As a developer I'm looking for a documentation, examples, and best practice methodology for how to customize the presentation of data LL provides via web pages, such as web-based profiles. Specifically I'm looking for an interface to extract at a minimum: - Profile text - "Real World" text - a user's entered web URL - birthdate info - payment status - partner status & partner - "picks" data - profile picture at its original resolution - "real world" profile picture at its original resolution From vsavchuk at productengine.com Thu Feb 3 08:20:42 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Thu, 03 Feb 2011 16:20:42 -0000 Subject: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml In-Reply-To: <20110119163030.25762.55317@domU-12-31-38-00-90-68.compute-1.internal> References: <20110119163030.25762.55317@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110203162042.12724.40531@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/ ----------------------------------------------------------- (Updated Feb. 3, 2011, 8:20 a.m.) Review request for Viewer. Changes ------- - Reordered strings more logically. - Removed duplicated "1" string. - Using a script, found two more duplicates ("Home", "Esc"), removed them. - Using the same script, found out that the arrow keys names ("Left", "Right", "Up", "Down") were duplicated as well. Fixed that by renaming HUD direction strings and updated the code utilizing them accordingly. Automated the work as much as possible to avoid further errors (I hope that helped :-)). Summary ------- Made all keys localizable. This addresses bug STORM-465. http://jira.secondlife.com/browse/STORM-465 Diffs (updated) ----- indra/newview/llmaniprotate.cpp b542f8134a2b indra/newview/skins/default/xui/da/strings.xml b542f8134a2b indra/newview/skins/default/xui/de/strings.xml b542f8134a2b indra/newview/skins/default/xui/en/strings.xml b542f8134a2b indra/newview/skins/default/xui/es/strings.xml b542f8134a2b indra/newview/skins/default/xui/fr/strings.xml b542f8134a2b indra/newview/skins/default/xui/it/strings.xml b542f8134a2b indra/newview/skins/default/xui/ja/strings.xml b542f8134a2b indra/newview/skins/default/xui/nl/strings.xml b542f8134a2b indra/newview/skins/default/xui/pl/strings.xml b542f8134a2b indra/newview/skins/default/xui/pt/strings.xml b542f8134a2b Diff: http://codereview.secondlife.com/r/108/diff Testing ------- Tested on Linux. No keys produce the warning for me. Thanks, Vadim -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110203/bcbef4ca/attachment.htm From vsavchuk at productengine.com Thu Feb 3 08:27:45 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Thu, 03 Feb 2011 16:27:45 -0000 Subject: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml In-Reply-To: <20110202165635.12726.42047@domU-12-31-38-00-90-68.compute-1.internal> References: <20110202165635.12726.42047@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110203162745.1721.14872@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 2, 2011, 8:56 a.m., Kent Quirk wrote: > > So I have a couple of issues with this patch: > > > > * I'm worried about the translation impact, how these strings are used and where. Should they be localized? Should they not be localized? I find it hard to believe that we ONLY need to translate Home and End. > > * The "1" key is duplicated. Are there others? > > * I think the single-letter keys should be placed in a more useful order so that we can easily find missing items. Keyboard order (especially since keyboards differ) is not good enough. > > * I'm worried about the naming convention; single-letter names (ahem, yes, I know who's talking here) can be rather ambiguous. It's probably the easiest fix -- anything else may require much more extensive changes -- but I'm worried about this. Is this fix robust under localization? > > > > I haven't had time to investigate these issues yet; does someone else have the knowledge to discuss? > > > > Vadim ProductEngine wrote: > 1) AFAIU, only those keys need translation that are currrently used in menu shortcuts (see menu_*.xml). > We don't know in advance what keys we're gonna use in future shortcuts, so it makes sense to make them all localizable. > 2) Thanks, the "1" is indeed duplicated. Looks like a copy&paste issue. > 3) Ok, the order doesn't matter to me. I can change it if you want. > 4) I borrowed the naming style from existing code (see llkeyboard.cpp). Moreover, we tried adding "Key_" prefix to key names for the same reasons as you say, but had to roll that change back because it had broken translation of older shortcuts (see comments in STORM-362). > > Kent Quirk wrote: > I would like to see a revised changeset please, reflecting 2 and 3. I'm happy with your responses to 1 and 4. > > Torben Trautman wrote: > There is a few more keys that have been localized or need to be localized. In german we also translated Shift (Umschalt) and Home (Zuhause)[which is a wrong translation by the way]. We still need to localize ` (snapshot to disk and region debug console shortcuts don?t work in german) and \ (Look at last speaker shortcut doesn?t work). I?m pretty sure this is also true at least for french. > > Hope this helps :) > > Dil Spitz wrote: > just a tiny hint, on my german keyboard they call home (Pos 1) > > Dil Spitz wrote: > indeed the de\strings.xml looks like google translated it. > Now i remember why i always switch SL to english ;) > Due the translation is out of the context in the strings.xml a normal translating person, who do not know SL, couldn't get the job right. > /me guessing the other non-english languages might look like the german too. > I suggest to give the residents a role to tune the translation of the language they speak. https://jira.secondlife.com/browse/VWR-24712 Dil, it's not me who works on the German translation. :-) I think you should file bugs about invalid translations you notice. - Vadim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review307 ----------------------------------------------------------- On Feb. 3, 2011, 8:20 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/108/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2011, 8:20 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Made all keys localizable. > > > This addresses bug STORM-465. > http://jira.secondlife.com/browse/STORM-465 > > > Diffs > ----- > > indra/newview/llmaniprotate.cpp b542f8134a2b > indra/newview/skins/default/xui/da/strings.xml b542f8134a2b > indra/newview/skins/default/xui/de/strings.xml b542f8134a2b > indra/newview/skins/default/xui/en/strings.xml b542f8134a2b > indra/newview/skins/default/xui/es/strings.xml b542f8134a2b > indra/newview/skins/default/xui/fr/strings.xml b542f8134a2b > indra/newview/skins/default/xui/it/strings.xml b542f8134a2b > indra/newview/skins/default/xui/ja/strings.xml b542f8134a2b > indra/newview/skins/default/xui/nl/strings.xml b542f8134a2b > indra/newview/skins/default/xui/pl/strings.xml b542f8134a2b > indra/newview/skins/default/xui/pt/strings.xml b542f8134a2b > > Diff: http://codereview.secondlife.com/r/108/diff > > > Testing > ------- > > Tested on Linux. No keys produce the warning for me. > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110203/874826d9/attachment.htm From q at lindenlab.com Thu Feb 3 08:43:00 2011 From: q at lindenlab.com (Kent Quirk) Date: Thu, 03 Feb 2011 16:43:00 -0000 Subject: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml In-Reply-To: <20110203162042.12724.40531@domU-12-31-38-00-90-68.compute-1.internal> References: <20110203162042.12724.40531@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110203164300.12726.35835@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review318 ----------------------------------------------------------- Ship it! I'm happy now. :) - Kent On Feb. 3, 2011, 8:20 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/108/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2011, 8:20 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Made all keys localizable. > > > This addresses bug STORM-465. > http://jira.secondlife.com/browse/STORM-465 > > > Diffs > ----- > > indra/newview/llmaniprotate.cpp b542f8134a2b > indra/newview/skins/default/xui/da/strings.xml b542f8134a2b > indra/newview/skins/default/xui/de/strings.xml b542f8134a2b > indra/newview/skins/default/xui/en/strings.xml b542f8134a2b > indra/newview/skins/default/xui/es/strings.xml b542f8134a2b > indra/newview/skins/default/xui/fr/strings.xml b542f8134a2b > indra/newview/skins/default/xui/it/strings.xml b542f8134a2b > indra/newview/skins/default/xui/ja/strings.xml b542f8134a2b > indra/newview/skins/default/xui/nl/strings.xml b542f8134a2b > indra/newview/skins/default/xui/pl/strings.xml b542f8134a2b > indra/newview/skins/default/xui/pt/strings.xml b542f8134a2b > > Diff: http://codereview.secondlife.com/r/108/diff > > > Testing > ------- > > Tested on Linux. No keys produce the warning for me. > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110203/80626ea1/attachment-0001.htm From merov at lindenlab.com Thu Feb 3 08:46:36 2011 From: merov at lindenlab.com (Philippe (Merov) Bossut) Date: Thu, 3 Feb 2011 08:46:36 -0800 Subject: [opensource-dev] PO Test build (sprint 10 end game) In-Reply-To: References: Message-ID: On Thu, Feb 3, 2011 at 12:51 AM, Anya Kanevsky wrote: > Merov, are you sure this build is correct? I tried all issues in the list > with this build (220162) and each one failed. > > Strange. I just noticed that TC fired 2 builds in rapid succession, each pointing to the same set of changes. Can you try that build then: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/220166/index.html Let me know if it works or not. If not, I'll clean up that repo and do a new PO build afresh. Cheers, - Merov -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110203/4bc2d5ea/attachment.htm From nickyperian at yahoo.com Thu Feb 3 08:54:07 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Thu, 3 Feb 2011 08:54:07 -0800 (PST) Subject: [opensource-dev] autobuild and vsexpress Message-ID: <252885.32563.qm@web43504.mail.sp1.yahoo.com> If anyone wants to help bring autobuild to vsexpress here are two starter(1commit each) repositories. http://NickyP at bitbucket.org/NickyP/viewer-autobuild-express-wip http://NickyP at bitbucket.org/NickyP/autobuild-vcexpress-wip I was able to make a warts and all build of LindenDeveloper.exe and logged to aditi with it. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110203/42a803b1/attachment.htm From oz at lindenlab.com Thu Feb 3 09:01:30 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Thu, 03 Feb 2011 12:01:30 -0500 Subject: [opensource-dev] Need Clarification on interfacing with web-based UI elements In-Reply-To: References: Message-ID: <4D4ADF6A.1080003@lindenlab.com> On 2011-02-03 11:13, Arrehn Oberlander wrote: > I'm concerned that I haven't received a response. I've already asked > this question a few times at office hours for Lindens involved in > development, and now here. Even if the answer is "LL will not support > a a stable API to web services" at least it is some kind of answer. > "LL will continue to provide existing non-web APIs for this same data > for the indefinite future" may be an option as well, but I haven't > heard this either. "We're working on this, check back in a month" is > also an answer that would be welcomed over silence. Apologies for not at least sending an ACK. I am pursuing this within LL. At the very least, "check back in a month" is something I can say now. I expect to be able to say something significantly better eventually - maybe even sooner than a month :-) From oz at lindenlab.com Thu Feb 3 09:05:12 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Thu, 03 Feb 2011 12:05:12 -0500 Subject: [opensource-dev] autobuild and vsexpress In-Reply-To: <252885.32563.qm@web43504.mail.sp1.yahoo.com> References: <252885.32563.qm@web43504.mail.sp1.yahoo.com> Message-ID: <4D4AE048.60404@lindenlab.com> On 2011-02-03 11:54, Nicky Perian wrote: > If anyone wants to help bring autobuild to vsexpress here are two > starter(1commit each) repositories. > http://NickyP at bitbucket.org/NickyP/viewer-autobuild-express-wip > http://NickyP at bitbucket.org/NickyP/autobuild-vcexpress-wip > I was able to make a warts and all build of LindenDeveloper.exe and > logged to aditi with it. > > would you mind posting the changesets on codereview.secondlife.com so that I can get the autobuild devs to review them? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110203/f8430ce9/attachment.htm From akanevsky at productengine.com Thu Feb 3 09:37:16 2011 From: akanevsky at productengine.com (Anya Kanevsky) Date: Thu, 3 Feb 2011 09:37:16 -0800 Subject: [opensource-dev] PO Test build (sprint 10 end game) In-Reply-To: References: Message-ID: Thank you, Merov! Yes, this build works, issues that were fixed are actually fixed and all is well with the world! 2011/2/3 Philippe (Merov) Bossut > On Thu, Feb 3, 2011 at 12:51 AM, Anya Kanevsky < > akanevsky at productengine.com> wrote: > >> Merov, are you sure this build is correct? I tried all issues in the list >> with this build (220162) and each one failed. >> >> > Strange. I just noticed that TC fired 2 builds in rapid succession, each > pointing to the same set of changes. Can you try that build then: > > http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/220166/index.html > > Let me know if it works or not. If not, I'll clean up that repo and do a > new PO build afresh. > > Cheers, > - Merov > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110203/ac78df57/attachment.htm From nickyperian at yahoo.com Thu Feb 3 10:33:34 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Thu, 3 Feb 2011 10:33:34 -0800 (PST) Subject: [opensource-dev] autobuild and vsexpress In-Reply-To: <4D4AE048.60404@lindenlab.com> References: <252885.32563.qm@web43504.mail.sp1.yahoo.com> <4D4AE048.60404@lindenlab.com> Message-ID: <284119.51907.qm@web43509.mail.sp1.yahoo.com> sure, Be later today or first thing in the morning at -6GMT. ________________________________ From: Oz Linden (Scott Lawrence) To: Nicky Perian Cc: opensource-dev at lists.secondlife.com; robin.cornelius at gmail.com Sent: Thu, February 3, 2011 11:05:12 AM Subject: Re: autobuild and vsexpress On 2011-02-03 11:54, Nicky Perian wrote: If anyone wants to help bring autobuild to vsexpress here are two starter(1commit each) repositories. >http://NickyP at bitbucket.org/NickyP/viewer-autobuild-express-wip >http://NickyP at bitbucket.org/NickyP/autobuild-vcexpress-wip >I was able to make a warts and all build of LindenDeveloper.exe and >logged to aditi with it. > > > would you mind posting the changesets on codereview.secondlife.com so that I can get the autobuild devs to review them? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110203/4741b30f/attachment.htm From kadah.coba at gmail.com Thu Feb 3 11:21:21 2011 From: kadah.coba at gmail.com (Kadah) Date: Thu, 03 Feb 2011 11:21:21 -0800 Subject: [opensource-dev] Need Clarification on interfacing with web-based UI elements In-Reply-To: <4D4ADF6A.1080003@lindenlab.com> References: <4D4ADF6A.1080003@lindenlab.com> Message-ID: <4D4B0031.1050903@gmail.com> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 It would have been nice if web profiles had been done in something like XSLT instead :P Raw profile data can easily be converted or stored into XML and presintation would be taken care of by Webkit's libxslt. On 2/3/2011 9:01 AM, Oz Linden (Scott Lawrence) wrote: > On 2011-02-03 11:13, Arrehn Oberlander wrote: >> I'm concerned that I haven't received a response. I've already asked >> this question a few times at office hours for Lindens involved in >> development, and now here. Even if the answer is "LL will not support >> a a stable API to web services" at least it is some kind of answer. >> "LL will continue to provide existing non-web APIs for this same data >> for the indefinite future" may be an option as well, but I haven't >> heard this either. "We're working on this, check back in a month" is >> also an answer that would be welcomed over silence. > > Apologies for not at least sending an ACK. > > I am pursuing this within LL. At the very least, "check back in a > month" is something I can say now. I expect to be able to say something > significantly better eventually - maybe even sooner than a month :-) > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJNSwAxAAoJEIdLfPRu7qE2EPkIAL8nCxbPJqBOYM4pjM7h3APJ GTzoMgm0CgQybOr2QuJMkK6Y00oy+iMvVoYwRyOOPHUX4bzN3AbFMxIxnuJMg+zv Ko7qSPVarfPkaWuuh3Pkxau3tpeuaDAOYg42IPiQm0Dt/kL28UX+Np5YiQ9WlDoz BAWmxEHrwUDGXC9CYuP7snrOeLjVtVTGsB0H3FeEXEFi+Tl49/3iTPDuNf4Ec+yf Lwxn3fng2jybNiruRKSO4OxWhu2Dgy0B0TZMCk7bLrz/wQLR6Op3e/x9t2zihMES nti9WdGkIpm7OU6/iDyK6aqtbqv/c+cphGMimM6RNj8pvWdL80yE9/FPsXSYESI= =nr1M -----END PGP SIGNATURE----- From twisted_laws at hotmail.com Thu Feb 3 12:43:02 2011 From: twisted_laws at hotmail.com (Twisted Laws) Date: Thu, 03 Feb 2011 20:43:02 -0000 Subject: [opensource-dev] Review Request: STORM-971 'Stop Tracking' menu item is still enabled in Mini-map floater after you stopped tracking in Nearby mini-map Message-ID: <20110203204302.25011.87711@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/133/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Sets "Stop Tracking" enabled based on tracking if true or false instead of only when true. Also made it check for menu pointer validity to remove a remote crash possiblity. This addresses bug STORM-971. http://jira.secondlife.com/browse/STORM-971 Diffs ----- indra/newview/llnetmap.cpp ec4a9fd30688 Diff: http://codereview.secondlife.com/r/133/diff Testing ------- My testing was to open the side panel nearby, and verify that the state of the menu was correct when tracking by the different methods and disabled. Then leaving that open, openned a mini-map instance and repeated testing its state tracking and not. Also tried the reverse. Verified that every possibility I could think of, the state of both menus was always correct. Correct state is Stop Tracking is enabled anytime tracking is on for avatars or landmarks and is not enabled when Tracking has been stopped no matter where you stopped tracking (i.e, clicking on red arrow in view window, and using the various menues). Thanks, Twisted -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110203/23d85036/attachment.htm From wolfpup67 at earthlink.net Thu Feb 3 13:15:32 2011 From: wolfpup67 at earthlink.net (WolfPup Lowenhar) Date: Thu, 3 Feb 2011 16:15:32 -0500 Subject: [opensource-dev] Asstiance needed for STORM-236 Message-ID: <005f01cbc3e7$7e1c80d0$7a558270$@net> After today's scrum meeting I started working on adding an new panel to the code to contain the resize handle for NearByChat and I'm having trouble figuring out how to add the panel to the code, it has been added to the xml, as there is no clear definition in the code for how the panels are read from the xml file so that the panels size information can be processed. I need help figuring out the following things: 1. How the panels are defined in the code. 2. How the code is actually reading the size of said panel. 3. How does the code handle panels being drawn. None of the above is documented in the code at all!!!!!!!!!!!!!!!!! -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110203/789f2591/attachment.htm From jhwelch at gmail.com Thu Feb 3 13:50:04 2011 From: jhwelch at gmail.com (Jonathan Welch) Date: Thu, 3 Feb 2011 16:50:04 -0500 Subject: [opensource-dev] UI Hints - getting them again Message-ID: There is a menu control for UI Hints, but as there are only 10 of them, and you only get each one once, you might want to know how to reset them from their "has already been seen" state if you are debugging or doing development work. These settings are kept in ignorable_dialogs.xml in the same directory where you will find your local copy of settings.xml, etc. -Jonathan From nickyperian at yahoo.com Thu Feb 3 13:51:35 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Thu, 03 Feb 2011 21:51:35 -0000 Subject: [opensource-dev] Review Request: Make autobuild-viewer work under Visual Studio 2005 Express Edition Message-ID: <20110203215135.12725.33396@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/134/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Make viewer-autobuild work under Visual Studio 2005 Express Edition. This modification is a test case and applies to -OpenSourceRelWithDebInfo only. This addresses bugs autobuild, vcexpress and with. http://jira.secondlife.com/browse/autobuild http://jira.secondlife.com/browse/vcexpress http://jira.secondlife.com/browse/with Diffs ----- autobuild.xml 00453191c1b9 Diff: http://codereview.secondlife.com/r/134/diff Testing ------- Configuration batch file content: @echo call c:\VC80\VC\bin\vcvars32.bat C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug configure -c OpenSourceRelWithDebInfo Build batch file content: C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug build -c OpenSourceRelWithDebInfo There is one post build re-configuration error related to devenv versus vcbuild parameter sequence. However,C:\lindenhg\viewer-autobuild-express-wip\build-vc80\newview\RelWithDebInfo\LindenDeveloper.exe was built and log on to aditi successful. Thanks, Nicky -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110203/a90788c2/attachment.htm From nickyperian at yahoo.com Thu Feb 3 13:59:26 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Thu, 03 Feb 2011 21:59:26 -0000 Subject: [opensource-dev] Review Request: Make autobuild-viewer work under Visual Studio 2005 Express Edition In-Reply-To: <20110203215135.12725.33396@domU-12-31-38-00-90-68.compute-1.internal> References: <20110203215135.12725.33396@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110203215926.12726.22692@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/134/#review319 ----------------------------------------------------------- will redo looks like line ending problems. - Nicky On Feb. 3, 2011, 1:51 p.m., Nicky Perian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/134/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2011, 1:51 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Make viewer-autobuild work under Visual Studio 2005 Express Edition. > > This modification is a test case and applies to -OpenSourceRelWithDebInfo only. > > > This addresses bugs autobuild, vcexpress and with. > http://jira.secondlife.com/browse/autobuild > http://jira.secondlife.com/browse/vcexpress > http://jira.secondlife.com/browse/with > > > Diffs > ----- > > autobuild.xml 00453191c1b9 > > Diff: http://codereview.secondlife.com/r/134/diff > > > Testing > ------- > > Configuration batch file content: > @echo > call c:\VC80\VC\bin\vcvars32.bat > C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug configure -c OpenSourceRelWithDebInfo > > Build batch file content: > C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug build -c OpenSourceRelWithDebInfo > > There is one post build re-configuration error related to devenv versus vcbuild parameter sequence. > However,C:\lindenhg\viewer-autobuild-express-wip\build-vc80\newview\RelWithDebInfo\LindenDeveloper.exe was built and > log on to aditi successful. > > > Thanks, > > Nicky > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110203/de58a1c0/attachment.htm From nickyperian at yahoo.com Thu Feb 3 14:35:48 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Thu, 03 Feb 2011 22:35:48 -0000 Subject: [opensource-dev] Review Request: Make autobuild-viewer work under Visual Studio 2005 Express Edition In-Reply-To: <20110203215135.12725.33396@domU-12-31-38-00-90-68.compute-1.internal> References: <20110203215135.12725.33396@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110203223548.12728.83808@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/134/ ----------------------------------------------------------- (Updated Feb. 3, 2011, 2:35 p.m.) Review request for Viewer. Summary ------- Make viewer-autobuild work under Visual Studio 2005 Express Edition. This modification is a test case and applies to -OpenSourceRelWithDebInfo only. This addresses bugs autobuild, vcexpress and with. http://jira.secondlife.com/browse/autobuild http://jira.secondlife.com/browse/vcexpress http://jira.secondlife.com/browse/with Diffs ----- autobuild.xml 00453191c1b9 Diff: http://codereview.secondlife.com/r/134/diff Testing ------- Configuration batch file content: @echo call c:\VC80\VC\bin\vcvars32.bat C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug configure -c OpenSourceRelWithDebInfo Build batch file content: C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug build -c OpenSourceRelWithDebInfo There is one post build re-configuration error related to devenv versus vcbuild parameter sequence. However,C:\lindenhg\viewer-autobuild-express-wip\build-vc80\newview\RelWithDebInfo\LindenDeveloper.exe was built and log on to aditi successful. Thanks, Nicky -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110203/83602aea/attachment-0001.htm From nickyperian at yahoo.com Thu Feb 3 16:11:13 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Fri, 04 Feb 2011 00:11:13 -0000 Subject: [opensource-dev] Review Request: Make autobuild-viewer work under Visual Studio 2005 Express Edition In-Reply-To: <20110203215926.12726.22692@domU-12-31-38-00-90-68.compute-1.internal> References: <20110203215926.12726.22692@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110204001113.25011.13551@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 3, 2011, 1:59 p.m., Nicky Perian wrote: > > will redo looks like line ending problems. Reponed for comment. Don't know if it is line endings or normal operations that cause view diff to display the entire file. - Nicky ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/134/#review319 ----------------------------------------------------------- On Feb. 3, 2011, 2:35 p.m., Nicky Perian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/134/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2011, 2:35 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Make viewer-autobuild work under Visual Studio 2005 Express Edition. > > This modification is a test case and applies to -OpenSourceRelWithDebInfo only. > > > This addresses bugs autobuild, vcexpress and with. > http://jira.secondlife.com/browse/autobuild > http://jira.secondlife.com/browse/vcexpress > http://jira.secondlife.com/browse/with > > > Diffs > ----- > > autobuild.xml 00453191c1b9 > > Diff: http://codereview.secondlife.com/r/134/diff > > > Testing > ------- > > Configuration batch file content: > @echo > call c:\VC80\VC\bin\vcvars32.bat > C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug configure -c OpenSourceRelWithDebInfo > > Build batch file content: > C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug build -c OpenSourceRelWithDebInfo > > There is one post build re-configuration error related to devenv versus vcbuild parameter sequence. > However,C:\lindenhg\viewer-autobuild-express-wip\build-vc80\newview\RelWithDebInfo\LindenDeveloper.exe was built and > log on to aditi successful. > > > Thanks, > > Nicky > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110204/d156f9ba/attachment.htm From Aleric.Inglewood at gmail.com Thu Feb 3 18:35:31 2011 From: Aleric.Inglewood at gmail.com (Aleric Inglewood) Date: Fri, 04 Feb 2011 02:35:31 -0000 Subject: [opensource-dev] Review Request: make PREHASH variables char const* const In-Reply-To: <20110122154056.32180.11384@domU-12-31-38-00-90-68.compute-1.internal> References: <20110122154056.32180.11384@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110204023531.15713.63689@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/#review321 ----------------------------------------------------------- - Aleric On Jan. 22, 2011, 7:40 a.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/100/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2011, 7:40 a.m.) > > > Review request for Viewer and Seth ProductEngine. > > > Summary > ------- > > For the reason for this change, see https://jira.secondlife.com/browse/VWR-24487 and https://jira.secondlife.com/browse/VWR-24522 > > What I did: > In indra/llmessage/message_prehash.(h|cpp), I turned everything into constant pointers to constants by search/replace. Then I tried to compile and added const qualifiers in dependent code as needed to stop the compiler complaining. > > Note that comments in indra/llmessage/message_prehash.(h|cpp) say these files have been generated from the message template. Because this generation might not have been a one-off thing, I changed the generating code, too, so it won't override this change here when the generation happens the next time. However, that part of the code is not called by Viewer, although the relevant function ? dump_prehash_files() ? ends up in the Viewer binary. That function probably gets called by the simulator, when one runs the latter with -prehash. (See https://bitbucket.org/lindenlab/viewer-development/src/fc7e5dcf3059/indra/llmessage/message.cpp#cl-2532 ) > > > This addresses bug VWR-24487. > http://jira.secondlife.com/browse/VWR-24487 > > > Diffs > ----- > > doc/contributions.txt fc7e5dcf3059 > indra/llmessage/message.cpp fc7e5dcf3059 > indra/llmessage/message_prehash.h fc7e5dcf3059 > indra/llmessage/message_prehash.cpp fc7e5dcf3059 > indra/llprimitive/llprimitive.h fc7e5dcf3059 > indra/llprimitive/llprimitive.cpp fc7e5dcf3059 > indra/llprimitive/llvolumemessage.h fc7e5dcf3059 > indra/llprimitive/llvolumemessage.cpp fc7e5dcf3059 > indra/llui/tests/llurlentry_stub.cpp fc7e5dcf3059 > indra/newview/tests/llremoteparcelrequest_test.cpp fc7e5dcf3059 > > Diff: http://codereview.secondlife.com/r/100/diff > > > Testing > ------- > > Compiled (standalone, 64bit Linux) with and without LL_TESTS. > Started the viewer, logged in, walked and flew around a bit. Everything seems to work. > > > Locally set _PREHASH_AgentData and _PREHASH_AgentID to (char const*)0x1 in indra/llui/tests/llurlentry_stub.cpp and indra/newview/tests/llremoteparcelrequest_test.cpp to verify they actually are never dereferenced, even when not NULL, so that using NULL pointers instead of place holder data won't change what code paths gets tested. Both tests binaries executed without crashes and all the contained tests passed. > > Locally invoked start_messaging_system() with b_dump_prehash_file == true instead of FALSE, to see what would be generated after my change to dump_prehash_files(). > The message_prehash.(h|cpp) generated by that had the correct type qualifiers and formatting, but some lines were removed or added compared to the modified files from the source tree. That probably means that the files aren't fully synchronized with the message template file in the source tree. Because the "added" constants are spread all over the file, while the "removed" ones were at the end, I'd wager that message_prehash.(h|cpp) in the viewer source tree are actually more up-to-date than the message template file in the source tree. > > > Thanks, > > Boroondas > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110204/ab946964/attachment.htm From Aleric.Inglewood at gmail.com Thu Feb 3 18:36:27 2011 From: Aleric.Inglewood at gmail.com (Aleric Inglewood) Date: Fri, 04 Feb 2011 02:36:27 -0000 Subject: [opensource-dev] Review Request: make PREHASH variables char const* const In-Reply-To: <20110204023531.15713.63689@domU-12-31-38-00-90-68.compute-1.internal> References: <20110204023531.15713.63689@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110204023627.11564.5227@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 3, 2011, 6:35 p.m., Aleric Inglewood wrote: > > Can this patch please be added to viewer-development? It's getting really annoying that I have to apply patches to the soruce tree before it even can compile cleanly :(. - Aleric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/#review321 ----------------------------------------------------------- On Jan. 22, 2011, 7:40 a.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/100/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2011, 7:40 a.m.) > > > Review request for Viewer and Seth ProductEngine. > > > Summary > ------- > > For the reason for this change, see https://jira.secondlife.com/browse/VWR-24487 and https://jira.secondlife.com/browse/VWR-24522 > > What I did: > In indra/llmessage/message_prehash.(h|cpp), I turned everything into constant pointers to constants by search/replace. Then I tried to compile and added const qualifiers in dependent code as needed to stop the compiler complaining. > > Note that comments in indra/llmessage/message_prehash.(h|cpp) say these files have been generated from the message template. Because this generation might not have been a one-off thing, I changed the generating code, too, so it won't override this change here when the generation happens the next time. However, that part of the code is not called by Viewer, although the relevant function ? dump_prehash_files() ? ends up in the Viewer binary. That function probably gets called by the simulator, when one runs the latter with -prehash. (See https://bitbucket.org/lindenlab/viewer-development/src/fc7e5dcf3059/indra/llmessage/message.cpp#cl-2532 ) > > > This addresses bug VWR-24487. > http://jira.secondlife.com/browse/VWR-24487 > > > Diffs > ----- > > doc/contributions.txt fc7e5dcf3059 > indra/llmessage/message.cpp fc7e5dcf3059 > indra/llmessage/message_prehash.h fc7e5dcf3059 > indra/llmessage/message_prehash.cpp fc7e5dcf3059 > indra/llprimitive/llprimitive.h fc7e5dcf3059 > indra/llprimitive/llprimitive.cpp fc7e5dcf3059 > indra/llprimitive/llvolumemessage.h fc7e5dcf3059 > indra/llprimitive/llvolumemessage.cpp fc7e5dcf3059 > indra/llui/tests/llurlentry_stub.cpp fc7e5dcf3059 > indra/newview/tests/llremoteparcelrequest_test.cpp fc7e5dcf3059 > > Diff: http://codereview.secondlife.com/r/100/diff > > > Testing > ------- > > Compiled (standalone, 64bit Linux) with and without LL_TESTS. > Started the viewer, logged in, walked and flew around a bit. Everything seems to work. > > > Locally set _PREHASH_AgentData and _PREHASH_AgentID to (char const*)0x1 in indra/llui/tests/llurlentry_stub.cpp and indra/newview/tests/llremoteparcelrequest_test.cpp to verify they actually are never dereferenced, even when not NULL, so that using NULL pointers instead of place holder data won't change what code paths gets tested. Both tests binaries executed without crashes and all the contained tests passed. > > Locally invoked start_messaging_system() with b_dump_prehash_file == true instead of FALSE, to see what would be generated after my change to dump_prehash_files(). > The message_prehash.(h|cpp) generated by that had the correct type qualifiers and formatting, but some lines were removed or added compared to the modified files from the source tree. That probably means that the files aren't fully synchronized with the message template file in the source tree. Because the "added" constants are spread all over the file, while the "removed" ones were at the end, I'd wager that message_prehash.(h|cpp) in the viewer source tree are actually more up-to-date than the message template file in the source tree. > > > Thanks, > > Boroondas > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110204/c9ca73d4/attachment-0001.htm From Aleric.Inglewood at gmail.com Thu Feb 3 18:39:11 2011 From: Aleric.Inglewood at gmail.com (Aleric Inglewood) Date: Fri, 04 Feb 2011 02:39:11 -0000 Subject: [opensource-dev] Review Request: VWR-24366: CMAKE_EXE_LINKER_FLAGS not honored when linking the viewer binary if -DLL_TESTS:BOOL=ON In-Reply-To: <20110115012724.17157.10313@domU-12-31-38-00-90-68.compute-1.internal> References: <20110115012724.17157.10313@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110204023911.12722.51200@domU-12-31-38-00-90-68.compute-1.internal> > On Jan. 14, 2011, 5:27 p.m., Merov Linden wrote: > > Makes sense. *bump* Can this patch please be added to viewer-development soon? It's annoying that I can't even compile the viewer without having to apply local patches :/ (I just lost an hour because I didn't realize that this patch still wasn't in v-d and waited and waited and waited and waited an waited for the viewer to link, until I finally just hit control-C.) - Aleric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/95/#review163 ----------------------------------------------------------- On Jan. 14, 2011, 1:15 p.m., Aleric Inglewood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/95/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2011, 1:15 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Setting CMAKE_EXE_LINKER_FLAGS to "" because the tests "need" that is pretty > hard measure. Not only is it not necessary to do so, it also changes how > the viewer is linked depending on a whether or not the tests are compiled > and that is not good. > > The reason that this was needed is that libgmock is underlinked > (see http://wiki.mandriva.com/en/Underlinking), which is not compatible > with -Wl,--as-needed that is being used on linux. libgmock.so.0 needs > a symbol that is defined in libgtest.so.o, but -lgtest was not passed > to the linker when creating libgmock.so.0: > > Underlinked (no libgtest.so.o): > $ objdump -p /usr/lib/libgmock.so.0 | grep NEEDED > NEEDED libstdc++.so.6 > NEEDED libm.so.6 > NEEDED libc.so.6 > NEEDED libgcc_s.so.1 > > The solution is to wrap between -Wl,--no-as-needed -lgtest -Wl,--as-needed > causing it to be added again. This is only needed on linux, since that > the only platform that we use -Wl,--as-needed on. Moreover, we can just > set GOOGLEMOCK_LIBRARIES to "gmock -Wl,--no-as-needed gtest -Wl,--as-needed" > since that is only passed to TARGET_LINK_LIBRARIES which only adds -l > in front of 'things' that don't start with '-', to allow you do pass > special flags like this. > > > This addresses bug VWR-24366. > http://jira.secondlife.com/browse/VWR-24366 > > > Diffs > ----- > > doc/contributions.txt 422f636c3343 > indra/cmake/GoogleMock.cmake 422f636c3343 > indra/cmake/LLAddBuildTest.cmake 422f636c3343 > > Diff: http://codereview.secondlife.com/r/95/diff > > > Testing > ------- > > > Thanks, > > Aleric > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110204/b020736c/attachment.htm From Aleric.Inglewood at gmail.com Thu Feb 3 18:50:44 2011 From: Aleric.Inglewood at gmail.com (Aleric Inglewood) Date: Fri, 04 Feb 2011 02:50:44 -0000 Subject: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2) In-Reply-To: <20110201024417.25316.63507@domU-12-31-38-00-90-68.compute-1.internal> References: <20110201024417.25316.63507@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110204025044.12723.53875@domU-12-31-38-00-90-68.compute-1.internal> > On Jan. 31, 2011, 6:44 p.m., Merov Linden wrote: > > @Aleric: OK, you convinced me on all accounts *except* for the ease of merge which I want to test myself before giving my blessing to this patch. You wouldn't be the first one be to claim that "it merges" and create some issues unwittingly. If you could post the URL of an hg repo with your patch, I'll be happy to give it a spin building on all platforms. > > > > BTW, thanks for the super detailed comment: very interesting stuff. Thanks. I made a repository available here: https://bitbucket.org/aleric/viewer-development-storm-955 Due to technical reasons I had to base it on a recent viewer-development commit, but during the merge I had no collisions except in contributions.txt ;) (while I made the original patch a few hunderd commits ago). [PS I added this TWO DAYS ago... but forgot to click on 'Publish'... this kinda sucks a bit] - Aleric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/81/#review300 ----------------------------------------------------------- On Jan. 16, 2011, 5:53 a.m., Aleric Inglewood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/81/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2011, 5:53 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Turns out that most of my SNOW-800 patch was included in Viewer 2 (albeit without crediting me). > However, not everything was used and some more cleaning up was possible. > > After this patch, and when compiling with optimization, there are no duplicates left > anymore that shouldn't be there in the first place: apart from the debug stream > iostream guard variable, there are several static variables with the same name (r, r1, > r2, etc) but that indeed actually different symbol objects. Then there are a few > constant POD arrays that are duplicated a hand full of times because they are > accessed with a variable index (so optimizing them away is not possible). I left them > like that (although defining those as extern as well would have been more consistent > and not slower; in fact it would be faster theoretically because those arrays could > share the same cache page then). > > > This addresses bug VWR-24312. > http://jira.secondlife.com/browse/VWR-24312 > > > Diffs > ----- > > doc/contributions.txt 422f636c3343 > indra/llcharacter/llanimationstates.cpp 422f636c3343 > indra/llcommon/llavatarconstants.h 422f636c3343 > indra/llcommon/lllslconstants.h 422f636c3343 > indra/llcommon/llmetricperformancetester.h 422f636c3343 > indra/llmath/llcamera.h 422f636c3343 > indra/llmath/llcamera.cpp 422f636c3343 > indra/newview/llviewerobject.cpp 422f636c3343 > indra/newview/llvoavatar.cpp 422f636c3343 > indra/newview/llvosky.h 422f636c3343 > indra/newview/llvosky.cpp 422f636c3343 > > Diff: http://codereview.secondlife.com/r/81/diff > > > Testing > ------- > > Compiled with optimization and then running readelf on the executable to find duplicated symbols. > > > Thanks, > > Aleric > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110204/2bd5921e/attachment.htm From Aleric.Inglewood at gmail.com Thu Feb 3 19:10:27 2011 From: Aleric.Inglewood at gmail.com (Aleric Inglewood) Date: Fri, 04 Feb 2011 03:10:27 -0000 Subject: [opensource-dev] Review Request: STORM-864: As as developer, I would like an object oriented wrapper to make safe use of memory pools easier In-Reply-To: <20110203023052.1721.82839@domU-12-31-38-00-90-68.compute-1.internal> References: <20110203023052.1721.82839@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110204031027.12728.24498@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 2, 2011, 6:30 p.m., Merov Linden wrote: > > indra/llcommon/llaprpool.h, lines 107-116 > > > > > > I think it's be more clear to use an explicit name like "getAPRPool()" rather than the function operator here. It produces hard to read code in a couple of places and it's just plain unclear what "myPool()" really does. That is actually on purpose. Developers should never actually "get" the pool. Like the comment says, it's painful that we have to provide access at all: we want to hide apt_pool_t completely from the user. The user should use LLAPRPool instead. And then, when that has to be passed to the actual libapr function, it's passed like this: apr_whatever_create(foo, mPool()); because that is just a little bit more safe than have it auto convert and allow writing apr_whatever_create(foo, mPool); or so I thought. It's deliberately a bit weird, to make people think twice before they "get" the underlaying apr_pool_t. Also... see comment below... - Aleric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/99/#review315 ----------------------------------------------------------- On Jan. 29, 2011, 9:10 a.m., Aleric Inglewood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/99/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2011, 9:10 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Please see http://jira.secondlife.com/browse/STORM-864 > > I made a mercurial repository available for testing here: > > hg clone https://bitbucket.org/aleric/viewer-development-storm-864 > > From the commit message: > > Introduces a LLThreadLocalData class that can be > accessed through the static LLThread::tldata(). > Currently this object contains two (public) thread-local > objects: a LLAPRRootPool and a LLVolatileAPRPool. > > The first is the general memory pool used by this thread > (and this thread alone), while the second is intended > for short lived memory allocations (needed for APR). > The advantages of not mixing those two is that the latter > is used most frequently, and as a result of it's nature > can be destroyed and reconstructed on a "regular" basis. > > This patch adds LLAPRPool (completely replacing the old one), > which is a wrapper around apr_pool_t* and has complete > thread-safity checking. > > Whenever an apr call requires memory for some resource, > a memory pool in the form of an LLAPRPool object can > be created with the same life-time as this resource; > assuring clean up of the memory no sooner, but also > not much later than the life-time of the resource > that needs the memory. > > Many, many function calls and constructors had the > pool parameter simply removed (it is no longer the > concern of the developer, if you don't write code > that actually does an libapr call then you are no > longer bothered with memory pools at all). > > However, I kept the notion of short-lived and > long-lived allocations alive (see my remark in > the jira here: https://jira.secondlife.com/browse/STORM-864?focusedCommentId=235356&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-235356 > which requires that the LLAPRFile API needs > to allow the user to specify how long they > think a file will stay open. By choosing > 'short_lived' as default for the constructor > that immediately opens a file, the number of > instances where this needs to be specified is > drastically reduced however (obviously, any > automatic LLAPRFile is short lived). > > > This addresses bug STORM-864. > http://jira.secondlife.com/browse/STORM-864 > > > Diffs > ----- > > doc/contributions.txt fe7fe04ccc9a > indra/llaudio/llaudioengine_fmod.cpp fe7fe04ccc9a > indra/llaudio/llvorbisencode.cpp fe7fe04ccc9a > indra/llcharacter/llbvhloader.cpp fe7fe04ccc9a > indra/llcharacter/llkeyframemotionparam.cpp fe7fe04ccc9a > indra/llcharacter/llstatemachine.cpp fe7fe04ccc9a > indra/llcommon/CMakeLists.txt fe7fe04ccc9a > indra/llcommon/llapp.cpp fe7fe04ccc9a > indra/llcommon/llapr.h fe7fe04ccc9a > indra/llcommon/llapr.cpp fe7fe04ccc9a > indra/llcommon/llaprpool.h PRE-CREATION > indra/llcommon/llaprpool.cpp PRE-CREATION > indra/llcommon/llcommon.h fe7fe04ccc9a > indra/llcommon/llcommon.cpp fe7fe04ccc9a > indra/llcommon/llerror.h fe7fe04ccc9a > indra/llcommon/llerror.cpp fe7fe04ccc9a > indra/llcommon/llfixedbuffer.cpp fe7fe04ccc9a > indra/llcommon/llscopedvolatileaprpool.h PRE-CREATION > indra/llcommon/llthread.h fe7fe04ccc9a > indra/llcommon/llthread.cpp fe7fe04ccc9a > indra/llcommon/llthreadsafequeue.h fe7fe04ccc9a > indra/llcommon/llthreadsafequeue.cpp fe7fe04ccc9a > indra/llcommon/llworkerthread.h fe7fe04ccc9a > indra/llcommon/llworkerthread.cpp fe7fe04ccc9a > indra/llcrashlogger/llcrashlogger.cpp fe7fe04ccc9a > indra/llimage/llimage.cpp fe7fe04ccc9a > indra/llimage/llimagedimensionsinfo.cpp fe7fe04ccc9a > indra/llimage/llimagej2c.cpp fe7fe04ccc9a > indra/llimage/llimageworker.h fe7fe04ccc9a > indra/llimage/llimageworker.cpp fe7fe04ccc9a > indra/llmath/llvolumemgr.cpp fe7fe04ccc9a > indra/llmessage/llares.cpp fe7fe04ccc9a > indra/llmessage/llcurl.cpp fe7fe04ccc9a > indra/llmessage/lliohttpserver.h fe7fe04ccc9a > indra/llmessage/lliohttpserver.cpp fe7fe04ccc9a > indra/llmessage/lliosocket.h fe7fe04ccc9a > indra/llmessage/lliosocket.cpp fe7fe04ccc9a > indra/llmessage/llmail.h fe7fe04ccc9a > indra/llmessage/llmail.cpp fe7fe04ccc9a > indra/llmessage/llpumpio.h fe7fe04ccc9a > indra/llmessage/llpumpio.cpp fe7fe04ccc9a > indra/llmessage/llurlrequest.cpp fe7fe04ccc9a > indra/llmessage/message.cpp fe7fe04ccc9a > indra/llmessage/tests/networkio.h fe7fe04ccc9a > indra/llplugin/llplugininstance.h fe7fe04ccc9a > indra/llplugin/llplugininstance.cpp fe7fe04ccc9a > indra/llplugin/llpluginmessagepipe.cpp fe7fe04ccc9a > indra/llplugin/llpluginprocesschild.cpp fe7fe04ccc9a > indra/llplugin/llpluginprocessparent.h fe7fe04ccc9a > indra/llplugin/llpluginprocessparent.cpp fe7fe04ccc9a > indra/llplugin/llpluginsharedmemory.h fe7fe04ccc9a > indra/llplugin/llpluginsharedmemory.cpp fe7fe04ccc9a > indra/llplugin/slplugin/slplugin.cpp fe7fe04ccc9a > indra/llvfs/lllfsthread.cpp fe7fe04ccc9a > indra/llvfs/llvfs.cpp fe7fe04ccc9a > indra/media_plugins/gstreamer010/llmediaimplgstreamer.h fe7fe04ccc9a > indra/media_plugins/gstreamer010/llmediaimplgstreamer_syms.cpp fe7fe04ccc9a > indra/media_plugins/webkit/linux_volume_catcher.cpp fe7fe04ccc9a > indra/newview/llappviewer.h fe7fe04ccc9a > indra/newview/llappviewer.cpp fe7fe04ccc9a > indra/newview/llappviewerlinux.cpp fe7fe04ccc9a > indra/newview/llappviewerlinux_api_dbus.cpp fe7fe04ccc9a > indra/newview/llappviewermacosx.cpp fe7fe04ccc9a > indra/newview/llfloateranimpreview.cpp fe7fe04ccc9a > indra/newview/llmainlooprepeater.cpp fe7fe04ccc9a > indra/newview/lltexturecache.h fe7fe04ccc9a > indra/newview/lltexturecache.cpp fe7fe04ccc9a > indra/newview/lltexturefetch.cpp fe7fe04ccc9a > indra/newview/llviewermenufile.cpp fe7fe04ccc9a > indra/newview/llvoavatar.cpp fe7fe04ccc9a > indra/newview/llvocache.h fe7fe04ccc9a > indra/newview/llvocache.cpp fe7fe04ccc9a > indra/newview/llvoicevivox.cpp fe7fe04ccc9a > indra/newview/llwatchdog.cpp fe7fe04ccc9a > indra/newview/tests/llworldmap_test.cpp fe7fe04ccc9a > indra/test/lltemplatemessagebuilder_tut.cpp fe7fe04ccc9a > indra/test/message_tut.cpp fe7fe04ccc9a > indra/test/test.cpp fe7fe04ccc9a > indra/test_apps/llplugintest/llmediaplugintest.cpp fe7fe04ccc9a > indra/viewer_components/updater/llupdateinstaller.cpp fe7fe04ccc9a > > Diff: http://codereview.secondlife.com/r/99/diff > > > Testing > ------- > > Compiles and viewer functions normally. > > The new classes (LLAPRPool, LLThreadLocalData) and the LLAPRFile changes have been tested a lot more extensive, since they have been used as-is for months in imprudence and before that in my own viewer (since April). However, the patch contains changes to code elsewhere (to adapt it to the new API) that is rather new in this source tree. Note that changes with regard to LLAPRFile already have been in Snowglobe since version 1.1 (with some minor changes) including the method used to make thread-local data available. > > > Thanks, > > Aleric > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110204/464d2bb8/attachment-0001.htm From Aleric.Inglewood at gmail.com Thu Feb 3 19:10:46 2011 From: Aleric.Inglewood at gmail.com (Aleric Inglewood) Date: Fri, 04 Feb 2011 03:10:46 -0000 Subject: [opensource-dev] Review Request: STORM-864: As as developer, I would like an object oriented wrapper to make safe use of memory pools easier In-Reply-To: <20110201035609.12729.79067@domU-12-31-38-00-90-68.compute-1.internal> References: <20110201035609.12729.79067@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110204031046.12727.68395@domU-12-31-38-00-90-68.compute-1.internal> > On Jan. 31, 2011, 7:56 p.m., Merov Linden wrote: > > indra/llcommon/llaprpool.cpp, lines 206-207 > > > > > > K,it's just a paranoid assert. Still, I'm curious how you came up with the (*4) value. Also, not much point using bitshift here (I know: old habits... :) I have no idea :p. This assert wasn't created by me, it comes from the old code. - Aleric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/99/#review303 ----------------------------------------------------------- On Jan. 29, 2011, 9:10 a.m., Aleric Inglewood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/99/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2011, 9:10 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Please see http://jira.secondlife.com/browse/STORM-864 > > I made a mercurial repository available for testing here: > > hg clone https://bitbucket.org/aleric/viewer-development-storm-864 > > From the commit message: > > Introduces a LLThreadLocalData class that can be > accessed through the static LLThread::tldata(). > Currently this object contains two (public) thread-local > objects: a LLAPRRootPool and a LLVolatileAPRPool. > > The first is the general memory pool used by this thread > (and this thread alone), while the second is intended > for short lived memory allocations (needed for APR). > The advantages of not mixing those two is that the latter > is used most frequently, and as a result of it's nature > can be destroyed and reconstructed on a "regular" basis. > > This patch adds LLAPRPool (completely replacing the old one), > which is a wrapper around apr_pool_t* and has complete > thread-safity checking. > > Whenever an apr call requires memory for some resource, > a memory pool in the form of an LLAPRPool object can > be created with the same life-time as this resource; > assuring clean up of the memory no sooner, but also > not much later than the life-time of the resource > that needs the memory. > > Many, many function calls and constructors had the > pool parameter simply removed (it is no longer the > concern of the developer, if you don't write code > that actually does an libapr call then you are no > longer bothered with memory pools at all). > > However, I kept the notion of short-lived and > long-lived allocations alive (see my remark in > the jira here: https://jira.secondlife.com/browse/STORM-864?focusedCommentId=235356&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-235356 > which requires that the LLAPRFile API needs > to allow the user to specify how long they > think a file will stay open. By choosing > 'short_lived' as default for the constructor > that immediately opens a file, the number of > instances where this needs to be specified is > drastically reduced however (obviously, any > automatic LLAPRFile is short lived). > > > This addresses bug STORM-864. > http://jira.secondlife.com/browse/STORM-864 > > > Diffs > ----- > > doc/contributions.txt fe7fe04ccc9a > indra/llaudio/llaudioengine_fmod.cpp fe7fe04ccc9a > indra/llaudio/llvorbisencode.cpp fe7fe04ccc9a > indra/llcharacter/llbvhloader.cpp fe7fe04ccc9a > indra/llcharacter/llkeyframemotionparam.cpp fe7fe04ccc9a > indra/llcharacter/llstatemachine.cpp fe7fe04ccc9a > indra/llcommon/CMakeLists.txt fe7fe04ccc9a > indra/llcommon/llapp.cpp fe7fe04ccc9a > indra/llcommon/llapr.h fe7fe04ccc9a > indra/llcommon/llapr.cpp fe7fe04ccc9a > indra/llcommon/llaprpool.h PRE-CREATION > indra/llcommon/llaprpool.cpp PRE-CREATION > indra/llcommon/llcommon.h fe7fe04ccc9a > indra/llcommon/llcommon.cpp fe7fe04ccc9a > indra/llcommon/llerror.h fe7fe04ccc9a > indra/llcommon/llerror.cpp fe7fe04ccc9a > indra/llcommon/llfixedbuffer.cpp fe7fe04ccc9a > indra/llcommon/llscopedvolatileaprpool.h PRE-CREATION > indra/llcommon/llthread.h fe7fe04ccc9a > indra/llcommon/llthread.cpp fe7fe04ccc9a > indra/llcommon/llthreadsafequeue.h fe7fe04ccc9a > indra/llcommon/llthreadsafequeue.cpp fe7fe04ccc9a > indra/llcommon/llworkerthread.h fe7fe04ccc9a > indra/llcommon/llworkerthread.cpp fe7fe04ccc9a > indra/llcrashlogger/llcrashlogger.cpp fe7fe04ccc9a > indra/llimage/llimage.cpp fe7fe04ccc9a > indra/llimage/llimagedimensionsinfo.cpp fe7fe04ccc9a > indra/llimage/llimagej2c.cpp fe7fe04ccc9a > indra/llimage/llimageworker.h fe7fe04ccc9a > indra/llimage/llimageworker.cpp fe7fe04ccc9a > indra/llmath/llvolumemgr.cpp fe7fe04ccc9a > indra/llmessage/llares.cpp fe7fe04ccc9a > indra/llmessage/llcurl.cpp fe7fe04ccc9a > indra/llmessage/lliohttpserver.h fe7fe04ccc9a > indra/llmessage/lliohttpserver.cpp fe7fe04ccc9a > indra/llmessage/lliosocket.h fe7fe04ccc9a > indra/llmessage/lliosocket.cpp fe7fe04ccc9a > indra/llmessage/llmail.h fe7fe04ccc9a > indra/llmessage/llmail.cpp fe7fe04ccc9a > indra/llmessage/llpumpio.h fe7fe04ccc9a > indra/llmessage/llpumpio.cpp fe7fe04ccc9a > indra/llmessage/llurlrequest.cpp fe7fe04ccc9a > indra/llmessage/message.cpp fe7fe04ccc9a > indra/llmessage/tests/networkio.h fe7fe04ccc9a > indra/llplugin/llplugininstance.h fe7fe04ccc9a > indra/llplugin/llplugininstance.cpp fe7fe04ccc9a > indra/llplugin/llpluginmessagepipe.cpp fe7fe04ccc9a > indra/llplugin/llpluginprocesschild.cpp fe7fe04ccc9a > indra/llplugin/llpluginprocessparent.h fe7fe04ccc9a > indra/llplugin/llpluginprocessparent.cpp fe7fe04ccc9a > indra/llplugin/llpluginsharedmemory.h fe7fe04ccc9a > indra/llplugin/llpluginsharedmemory.cpp fe7fe04ccc9a > indra/llplugin/slplugin/slplugin.cpp fe7fe04ccc9a > indra/llvfs/lllfsthread.cpp fe7fe04ccc9a > indra/llvfs/llvfs.cpp fe7fe04ccc9a > indra/media_plugins/gstreamer010/llmediaimplgstreamer.h fe7fe04ccc9a > indra/media_plugins/gstreamer010/llmediaimplgstreamer_syms.cpp fe7fe04ccc9a > indra/media_plugins/webkit/linux_volume_catcher.cpp fe7fe04ccc9a > indra/newview/llappviewer.h fe7fe04ccc9a > indra/newview/llappviewer.cpp fe7fe04ccc9a > indra/newview/llappviewerlinux.cpp fe7fe04ccc9a > indra/newview/llappviewerlinux_api_dbus.cpp fe7fe04ccc9a > indra/newview/llappviewermacosx.cpp fe7fe04ccc9a > indra/newview/llfloateranimpreview.cpp fe7fe04ccc9a > indra/newview/llmainlooprepeater.cpp fe7fe04ccc9a > indra/newview/lltexturecache.h fe7fe04ccc9a > indra/newview/lltexturecache.cpp fe7fe04ccc9a > indra/newview/lltexturefetch.cpp fe7fe04ccc9a > indra/newview/llviewermenufile.cpp fe7fe04ccc9a > indra/newview/llvoavatar.cpp fe7fe04ccc9a > indra/newview/llvocache.h fe7fe04ccc9a > indra/newview/llvocache.cpp fe7fe04ccc9a > indra/newview/llvoicevivox.cpp fe7fe04ccc9a > indra/newview/llwatchdog.cpp fe7fe04ccc9a > indra/newview/tests/llworldmap_test.cpp fe7fe04ccc9a > indra/test/lltemplatemessagebuilder_tut.cpp fe7fe04ccc9a > indra/test/message_tut.cpp fe7fe04ccc9a > indra/test/test.cpp fe7fe04ccc9a > indra/test_apps/llplugintest/llmediaplugintest.cpp fe7fe04ccc9a > indra/viewer_components/updater/llupdateinstaller.cpp fe7fe04ccc9a > > Diff: http://codereview.secondlife.com/r/99/diff > > > Testing > ------- > > Compiles and viewer functions normally. > > The new classes (LLAPRPool, LLThreadLocalData) and the LLAPRFile changes have been tested a lot more extensive, since they have been used as-is for months in imprudence and before that in my own viewer (since April). However, the patch contains changes to code elsewhere (to adapt it to the new API) that is rather new in this source tree. Note that changes with regard to LLAPRFile already have been in Snowglobe since version 1.1 (with some minor changes) including the method used to make thread-local data available. > > > Thanks, > > Aleric > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110204/581402dc/attachment.htm From Aleric.Inglewood at gmail.com Thu Feb 3 19:26:20 2011 From: Aleric.Inglewood at gmail.com (Aleric Inglewood) Date: Fri, 04 Feb 2011 03:26:20 -0000 Subject: [opensource-dev] Review Request: STORM-864: As as developer, I would like an object oriented wrapper to make safe use of memory pools easier In-Reply-To: <20110203023052.1721.82839@domU-12-31-38-00-90-68.compute-1.internal> References: <20110203023052.1721.82839@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110204032620.15713.20760@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 2, 2011, 6:30 p.m., Merov Linden wrote: > > indra/llmessage/llpumpio.cpp, line 359 > > > > > > An example where the use of operator() is particularly unsightly... And rightfully so! It should be "extremely unpleasant" for the user to get to the underlaying apr_pool_t*. That this code hacks access is exactly that: a hack. One has to be very careful when doing this. The reason I did it here is because 1) I know what I'm doing, so it's ok in this case, 2) for this first introduction of LLAPRPool I tried to make minimal changes to the actual functionality of existing code using apr pools (with the exception of LLAPRFile, the rewrite of its API actually coming from SNOW-103 which already proved itself in snowglobe, imprudence and other TPV's). The fact that this access here is needed actually signifies that this code is not handling pools in a very safe way, but I consider(ed) it better to keep the code "as-is" and hack around the *safity* of LLAPRPool (and as a result not changing anything!) than to rewrite the interface at this point for this particular part of the code; changing things is more risk, in this case, than not using the API of LLAPRPool as intended. It would be harder to find if that rewrite would introduce some kind of bug we made lots of changes at the same time. I propose to leave this as it is now and look at changing it later once everyone feels secure about the stability of the current patch. Okay, that sounded nice -- but the truth is that I have no idea (at this point) if it is even possible to do what that code does without accessing the underlaying apr_pool_t* like that (meaning, not passing it directly to an APR function, but storing it in a structure). I just know that it should feel dangerous to do so, so it seems OK that code that does it doesn't look very nice. - Aleric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/99/#review315 ----------------------------------------------------------- On Jan. 29, 2011, 9:10 a.m., Aleric Inglewood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/99/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2011, 9:10 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Please see http://jira.secondlife.com/browse/STORM-864 > > I made a mercurial repository available for testing here: > > hg clone https://bitbucket.org/aleric/viewer-development-storm-864 > > From the commit message: > > Introduces a LLThreadLocalData class that can be > accessed through the static LLThread::tldata(). > Currently this object contains two (public) thread-local > objects: a LLAPRRootPool and a LLVolatileAPRPool. > > The first is the general memory pool used by this thread > (and this thread alone), while the second is intended > for short lived memory allocations (needed for APR). > The advantages of not mixing those two is that the latter > is used most frequently, and as a result of it's nature > can be destroyed and reconstructed on a "regular" basis. > > This patch adds LLAPRPool (completely replacing the old one), > which is a wrapper around apr_pool_t* and has complete > thread-safity checking. > > Whenever an apr call requires memory for some resource, > a memory pool in the form of an LLAPRPool object can > be created with the same life-time as this resource; > assuring clean up of the memory no sooner, but also > not much later than the life-time of the resource > that needs the memory. > > Many, many function calls and constructors had the > pool parameter simply removed (it is no longer the > concern of the developer, if you don't write code > that actually does an libapr call then you are no > longer bothered with memory pools at all). > > However, I kept the notion of short-lived and > long-lived allocations alive (see my remark in > the jira here: https://jira.secondlife.com/browse/STORM-864?focusedCommentId=235356&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-235356 > which requires that the LLAPRFile API needs > to allow the user to specify how long they > think a file will stay open. By choosing > 'short_lived' as default for the constructor > that immediately opens a file, the number of > instances where this needs to be specified is > drastically reduced however (obviously, any > automatic LLAPRFile is short lived). > > > This addresses bug STORM-864. > http://jira.secondlife.com/browse/STORM-864 > > > Diffs > ----- > > doc/contributions.txt fe7fe04ccc9a > indra/llaudio/llaudioengine_fmod.cpp fe7fe04ccc9a > indra/llaudio/llvorbisencode.cpp fe7fe04ccc9a > indra/llcharacter/llbvhloader.cpp fe7fe04ccc9a > indra/llcharacter/llkeyframemotionparam.cpp fe7fe04ccc9a > indra/llcharacter/llstatemachine.cpp fe7fe04ccc9a > indra/llcommon/CMakeLists.txt fe7fe04ccc9a > indra/llcommon/llapp.cpp fe7fe04ccc9a > indra/llcommon/llapr.h fe7fe04ccc9a > indra/llcommon/llapr.cpp fe7fe04ccc9a > indra/llcommon/llaprpool.h PRE-CREATION > indra/llcommon/llaprpool.cpp PRE-CREATION > indra/llcommon/llcommon.h fe7fe04ccc9a > indra/llcommon/llcommon.cpp fe7fe04ccc9a > indra/llcommon/llerror.h fe7fe04ccc9a > indra/llcommon/llerror.cpp fe7fe04ccc9a > indra/llcommon/llfixedbuffer.cpp fe7fe04ccc9a > indra/llcommon/llscopedvolatileaprpool.h PRE-CREATION > indra/llcommon/llthread.h fe7fe04ccc9a > indra/llcommon/llthread.cpp fe7fe04ccc9a > indra/llcommon/llthreadsafequeue.h fe7fe04ccc9a > indra/llcommon/llthreadsafequeue.cpp fe7fe04ccc9a > indra/llcommon/llworkerthread.h fe7fe04ccc9a > indra/llcommon/llworkerthread.cpp fe7fe04ccc9a > indra/llcrashlogger/llcrashlogger.cpp fe7fe04ccc9a > indra/llimage/llimage.cpp fe7fe04ccc9a > indra/llimage/llimagedimensionsinfo.cpp fe7fe04ccc9a > indra/llimage/llimagej2c.cpp fe7fe04ccc9a > indra/llimage/llimageworker.h fe7fe04ccc9a > indra/llimage/llimageworker.cpp fe7fe04ccc9a > indra/llmath/llvolumemgr.cpp fe7fe04ccc9a > indra/llmessage/llares.cpp fe7fe04ccc9a > indra/llmessage/llcurl.cpp fe7fe04ccc9a > indra/llmessage/lliohttpserver.h fe7fe04ccc9a > indra/llmessage/lliohttpserver.cpp fe7fe04ccc9a > indra/llmessage/lliosocket.h fe7fe04ccc9a > indra/llmessage/lliosocket.cpp fe7fe04ccc9a > indra/llmessage/llmail.h fe7fe04ccc9a > indra/llmessage/llmail.cpp fe7fe04ccc9a > indra/llmessage/llpumpio.h fe7fe04ccc9a > indra/llmessage/llpumpio.cpp fe7fe04ccc9a > indra/llmessage/llurlrequest.cpp fe7fe04ccc9a > indra/llmessage/message.cpp fe7fe04ccc9a > indra/llmessage/tests/networkio.h fe7fe04ccc9a > indra/llplugin/llplugininstance.h fe7fe04ccc9a > indra/llplugin/llplugininstance.cpp fe7fe04ccc9a > indra/llplugin/llpluginmessagepipe.cpp fe7fe04ccc9a > indra/llplugin/llpluginprocesschild.cpp fe7fe04ccc9a > indra/llplugin/llpluginprocessparent.h fe7fe04ccc9a > indra/llplugin/llpluginprocessparent.cpp fe7fe04ccc9a > indra/llplugin/llpluginsharedmemory.h fe7fe04ccc9a > indra/llplugin/llpluginsharedmemory.cpp fe7fe04ccc9a > indra/llplugin/slplugin/slplugin.cpp fe7fe04ccc9a > indra/llvfs/lllfsthread.cpp fe7fe04ccc9a > indra/llvfs/llvfs.cpp fe7fe04ccc9a > indra/media_plugins/gstreamer010/llmediaimplgstreamer.h fe7fe04ccc9a > indra/media_plugins/gstreamer010/llmediaimplgstreamer_syms.cpp fe7fe04ccc9a > indra/media_plugins/webkit/linux_volume_catcher.cpp fe7fe04ccc9a > indra/newview/llappviewer.h fe7fe04ccc9a > indra/newview/llappviewer.cpp fe7fe04ccc9a > indra/newview/llappviewerlinux.cpp fe7fe04ccc9a > indra/newview/llappviewerlinux_api_dbus.cpp fe7fe04ccc9a > indra/newview/llappviewermacosx.cpp fe7fe04ccc9a > indra/newview/llfloateranimpreview.cpp fe7fe04ccc9a > indra/newview/llmainlooprepeater.cpp fe7fe04ccc9a > indra/newview/lltexturecache.h fe7fe04ccc9a > indra/newview/lltexturecache.cpp fe7fe04ccc9a > indra/newview/lltexturefetch.cpp fe7fe04ccc9a > indra/newview/llviewermenufile.cpp fe7fe04ccc9a > indra/newview/llvoavatar.cpp fe7fe04ccc9a > indra/newview/llvocache.h fe7fe04ccc9a > indra/newview/llvocache.cpp fe7fe04ccc9a > indra/newview/llvoicevivox.cpp fe7fe04ccc9a > indra/newview/llwatchdog.cpp fe7fe04ccc9a > indra/newview/tests/llworldmap_test.cpp fe7fe04ccc9a > indra/test/lltemplatemessagebuilder_tut.cpp fe7fe04ccc9a > indra/test/message_tut.cpp fe7fe04ccc9a > indra/test/test.cpp fe7fe04ccc9a > indra/test_apps/llplugintest/llmediaplugintest.cpp fe7fe04ccc9a > indra/viewer_components/updater/llupdateinstaller.cpp fe7fe04ccc9a > > Diff: http://codereview.secondlife.com/r/99/diff > > > Testing > ------- > > Compiles and viewer functions normally. > > The new classes (LLAPRPool, LLThreadLocalData) and the LLAPRFile changes have been tested a lot more extensive, since they have been used as-is for months in imprudence and before that in my own viewer (since April). However, the patch contains changes to code elsewhere (to adapt it to the new API) that is rather new in this source tree. Note that changes with regard to LLAPRFile already have been in Snowglobe since version 1.1 (with some minor changes) including the method used to make thread-local data available. > > > Thanks, > > Aleric > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110204/478358f2/attachment-0001.htm From nickyperian at yahoo.com Thu Feb 3 19:48:10 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Fri, 04 Feb 2011 03:48:10 -0000 Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. Message-ID: <20110204034810.12913.94716@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/136/ ----------------------------------------------------------- Review request for Viewer. Summary ------- This modification is a test case and applies to -OpenSourceRelWithDebInfo only. Configuration batch file content: @echo call c:\VC80\VC\bin\vcvars32.bat C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug configure -c OpenSourceRelWithDebInfo Build batch file content: C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug build -c OpenSourceRelWithDebInfo This is a clean up of a discarded RB This addresses bug viewer-autobuild. http://jira.secondlife.com/browse/viewer-autobuild Diffs ----- autobuild.xml 00453191c1b9 Diff: http://codereview.secondlife.com/r/136/diff Testing ------- There is one post build re-configuration error related to devenv versus vcbuild parameter sequence. However,C:\lindenhg\viewer-autobuild-express-wip\build-vc80\newview\RelWithDebInfo\LindenDeveloper.exe was built and log on to aditi successful. Thanks, Nicky -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110204/7d8f394e/attachment.htm From nickyperian at yahoo.com Thu Feb 3 21:04:19 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Fri, 04 Feb 2011 05:04:19 -0000 Subject: [opensource-dev] Review Request: Debugging autobuild post build re-configuration error. Message-ID: <20110204050419.12723.70255@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/137/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Print out failed build_config from autobuild_tool_build.py This addresses bug autobuild. Diffs ----- autobuild/autobuild_tool_build.py ffcfcf7cde2c Diff: http://codereview.secondlife.com/r/137/diff Testing ------- Just started, trying to determine if the error can be corrected with autobuild.xml entries or by post-build string adjustments. Thanks, Nicky -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110204/d1202e6e/attachment.htm From akanevsky at productengine.com Fri Feb 4 01:22:17 2011 From: akanevsky at productengine.com (Anya Kanevsky) Date: Fri, 4 Feb 2011 01:22:17 -0800 Subject: [opensource-dev] Daily Scrum Summary - Thursday, February 3 Message-ID: Thursday, February 3 General Notes ------------------------------ - Please do not pick up issues tagged with needs-design until the tag has been removed. - MMOTD: Merov - Please remember to move issues to current Sprint when a) starting work on them or b) accepting issues from the community Team Status ------------------------------ Merov Linden ------------------------------ *PAST* - More SNOW triaging: only a dozen left to go... - Merge Monkeying: push fixes in both viewer-beta and viewer-development, PO build - STORM-864 : APR memory pool : finished code review, did a test build, plenty of issues. Rejected review. See JIRA for details. *FUTURE* - MM - STORM-864 : APR memory pool : waiting on Aleric, suspecting some apr bundling issues on Linux and Windows - STORM-955 : Massively duplicated objects : keep an eyes on this - STORM-746 : KDU Improvements: Compress j2c with precincts *IMPEDIMENTS* - none Oz Linden ------------------------------ *PAST* - Created 'Open Development' jira project - Non-Snowstorm activities - Started discussions about open data APIs *FUTURE* - Review autobuild changes from NickyP - Document policies and test new jira project rules - PO Review - Internal Linden training session *IMPEDIMENTS* - none Q Linden ------------------------------ *PAST* - STORM-465 - Triage tooling attempt (which sadly failed, but i have ideas) - OOO / Doctor - beta 3 *FUTURE* - beta 3 - internal training session - OOO late today and all day tomorrow - spend time with wolf but probably not 'til monday *IMPEDIMENTS* - none, other than time Grumpity ProductEngine ------------------------------ *PAST* - prep for product tirage - a bit more jira cleanup - non-snowstorm stuff *FUTURE* - PEQA deferred issues triage with Bambers - continue to prod others to resolve impediments - STORM-379, STORM-465 *IMPEDIMENTS* - we need more vwr triage - bug queue is getting empty Paul ProductEngine ------------------------------ *PAST* - BUG STORM-680 (Avaline callers are added to the Recent list) - WIP. 90%. Estimate 2 hours. Implementing the solution. *FUTURE* - Finish with BUG STORM-680 (Avaline callers are added to the Recent list) *IMPEDIMENTS* - Today's progress is not very good because of headache. Today will go home a little bit earlier, feel bad. Seth Productengine ------------------------------ *PAST* - BUG (STORM-433) Friendship offer shifted up and placed over "Second Life" text - Found that reshaping text editor with a friendship offer fixes its placement. Still looking for more precise reason of the problem *FUTURE* - BUG (STORM-433) Friendship offer shifted up and placed over "Second Life" text - Estimated: 8-10 hours. *IMPEDIMENTS* - BUG (STORM-379) Content permissions aren't refreshed in the "Buy copy of" floater. - Asked in JIRA whether the bug should be fixed in a way that may increase server load. Vadim Productengine ------------------------------ *PAST* - Looked through high impact issues (in code familiar to me) from the recent Coverity report. - Haven't found anything dangerous (and even if I had found something, I don't know the process to handle such issues). - Story STORM-2 (Customizable viewer layouts): - Working on saving sidebar state. Stuck with handling minimization. - I remember Andrew mentioning a bug in LLFloaterReg which may cause it to misbehave. Will try consulting with him tomorrow. *FUTURE* - Will work on STORM-2 at least till the end of week. *IMPEDIMENTS* - none Andrey ProductEngine ------------------------------ *PAST* - picked up Beta3 build#2 (r220251) - executed smoke and integrity tests on Windows, Linux and OSX. See IQA-80 for more details. - smoke on Linux has been failed but it looks like specific environment issue (?) - proceeded with v-d regression testing, see spreadsheet - reported 2 issues: VWR-24714 and VWR-24715 *FUTURE* - investigate VWR-24714 - verify integrated STORM tickets against the latest v-d build *FUTURE* *IMPEDIMENTS* - none Wolfpup Lowenhar ------------------------------ *PAST* - Worked @ RL . - STORM-236 : began debuging issue with button layout resized issues. Also discussed this with Oz in IRC. *FUTURE* - Work @ RL - STORM-941 : email Oz and Leyla concering posible areas that could be causeing the problem. *IMPEDIMENTS* - STORM-236 : waiting for new graphics and name to call the panel. - Not enough time to actually work on code. - Computer repair Client that dose not know what non repairable means and keeps trying to have me fix a unit that is beyond repair. Jonathan Yap ------------------------------ *PAST* - VWR-24628 (Descriptive text missing next to first checkbox in About Land/Access) - This had to be fixed first in order to work on Storm - 953. 4 other people helped with this! This was my proudest moment as a developer. Great team effort. Easy fix but caused by low-level routine change. - STORM-953 (Clarify what happens when you uncheck Allow Public Access) - Needs a very quick design review. See image attached to jira https://jira.secondlife.com/secure/attachment/47772/AboutLandNote.png *FUTURE* *IMPEDIMENTS* - VWR - 24628 needs to be pulled in to Storm-nnnn - Waiting for Oz to Storm-nnnn-ize my bug list. Cummere Mayo ------------------------------ *PAST* - jira stuff - lots of office hours - getting in trouble >< - testing correct po build *FUTURE* - new blog posts - not totally sure *IMPEDIMENTS* - time -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110204/1dfdbb6a/attachment-0001.htm From sllists at boroon.dasgupta.ch Fri Feb 4 03:54:07 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Fri, 04 Feb 2011 11:54:07 -0000 Subject: [opensource-dev] Review Request: STORM-864: As as developer, I would like an object oriented wrapper to make safe use of memory pools easier In-Reply-To: <20110203023052.1721.82839@domU-12-31-38-00-90-68.compute-1.internal> References: <20110203023052.1721.82839@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110204115407.12723.22590@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 2, 2011, 6:30 p.m., Merov Linden wrote: > > indra/llmessage/llpumpio.cpp, line 359 > > > > > > An example where the use of operator() is particularly unsightly... > > Aleric Inglewood wrote: > And rightfully so! It should be "extremely unpleasant" for the user to get to the underlaying apr_pool_t*. > That this code hacks access is exactly that: a hack. One has to be very careful when doing this. > The reason I did it here is because 1) I know what I'm doing, so it's ok in this case, 2) for this > first introduction of LLAPRPool I tried to make minimal changes to the actual functionality of > existing code using apr pools (with the exception of LLAPRFile, the rewrite of its API actually > coming from SNOW-103 which already proved itself in snowglobe, imprudence and other TPV's). > The fact that this access here is needed actually signifies that this code is not handling > pools in a very safe way, but I consider(ed) it better to keep the code "as-is" and hack around the > *safity* of LLAPRPool (and as a result not changing anything!) than to rewrite the interface at this > point for this particular part of the code; changing things is more risk, in this case, than not > using the API of LLAPRPool as intended. It would be harder to find if that rewrite would introduce > some kind of bug we made lots of changes at the same time. I propose to leave this as it is now > and look at changing it later once everyone feels secure about the stability of the current patch. > > Okay, that sounded nice -- but the truth is that I have no idea (at this point) if it is even > possible to do what that code does without accessing the underlaying apr_pool_t* like that (meaning, > not passing it directly to an APR function, but storing it in a structure). I just know that it > should feel dangerous to do so, so it seems OK that code that does it doesn't look very nice. > Then it should maybe be made even more obvious with a super-ugly name like getAPRPool_DO_NOT_CALL_THIS_DIRECTLY_use_LLAPRPool_instead() - Boroondas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/99/#review315 ----------------------------------------------------------- On Jan. 29, 2011, 9:10 a.m., Aleric Inglewood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/99/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2011, 9:10 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Please see http://jira.secondlife.com/browse/STORM-864 > > I made a mercurial repository available for testing here: > > hg clone https://bitbucket.org/aleric/viewer-development-storm-864 > > From the commit message: > > Introduces a LLThreadLocalData class that can be > accessed through the static LLThread::tldata(). > Currently this object contains two (public) thread-local > objects: a LLAPRRootPool and a LLVolatileAPRPool. > > The first is the general memory pool used by this thread > (and this thread alone), while the second is intended > for short lived memory allocations (needed for APR). > The advantages of not mixing those two is that the latter > is used most frequently, and as a result of it's nature > can be destroyed and reconstructed on a "regular" basis. > > This patch adds LLAPRPool (completely replacing the old one), > which is a wrapper around apr_pool_t* and has complete > thread-safity checking. > > Whenever an apr call requires memory for some resource, > a memory pool in the form of an LLAPRPool object can > be created with the same life-time as this resource; > assuring clean up of the memory no sooner, but also > not much later than the life-time of the resource > that needs the memory. > > Many, many function calls and constructors had the > pool parameter simply removed (it is no longer the > concern of the developer, if you don't write code > that actually does an libapr call then you are no > longer bothered with memory pools at all). > > However, I kept the notion of short-lived and > long-lived allocations alive (see my remark in > the jira here: https://jira.secondlife.com/browse/STORM-864?focusedCommentId=235356&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-235356 > which requires that the LLAPRFile API needs > to allow the user to specify how long they > think a file will stay open. By choosing > 'short_lived' as default for the constructor > that immediately opens a file, the number of > instances where this needs to be specified is > drastically reduced however (obviously, any > automatic LLAPRFile is short lived). > > > This addresses bug STORM-864. > http://jira.secondlife.com/browse/STORM-864 > > > Diffs > ----- > > doc/contributions.txt fe7fe04ccc9a > indra/llaudio/llaudioengine_fmod.cpp fe7fe04ccc9a > indra/llaudio/llvorbisencode.cpp fe7fe04ccc9a > indra/llcharacter/llbvhloader.cpp fe7fe04ccc9a > indra/llcharacter/llkeyframemotionparam.cpp fe7fe04ccc9a > indra/llcharacter/llstatemachine.cpp fe7fe04ccc9a > indra/llcommon/CMakeLists.txt fe7fe04ccc9a > indra/llcommon/llapp.cpp fe7fe04ccc9a > indra/llcommon/llapr.h fe7fe04ccc9a > indra/llcommon/llapr.cpp fe7fe04ccc9a > indra/llcommon/llaprpool.h PRE-CREATION > indra/llcommon/llaprpool.cpp PRE-CREATION > indra/llcommon/llcommon.h fe7fe04ccc9a > indra/llcommon/llcommon.cpp fe7fe04ccc9a > indra/llcommon/llerror.h fe7fe04ccc9a > indra/llcommon/llerror.cpp fe7fe04ccc9a > indra/llcommon/llfixedbuffer.cpp fe7fe04ccc9a > indra/llcommon/llscopedvolatileaprpool.h PRE-CREATION > indra/llcommon/llthread.h fe7fe04ccc9a > indra/llcommon/llthread.cpp fe7fe04ccc9a > indra/llcommon/llthreadsafequeue.h fe7fe04ccc9a > indra/llcommon/llthreadsafequeue.cpp fe7fe04ccc9a > indra/llcommon/llworkerthread.h fe7fe04ccc9a > indra/llcommon/llworkerthread.cpp fe7fe04ccc9a > indra/llcrashlogger/llcrashlogger.cpp fe7fe04ccc9a > indra/llimage/llimage.cpp fe7fe04ccc9a > indra/llimage/llimagedimensionsinfo.cpp fe7fe04ccc9a > indra/llimage/llimagej2c.cpp fe7fe04ccc9a > indra/llimage/llimageworker.h fe7fe04ccc9a > indra/llimage/llimageworker.cpp fe7fe04ccc9a > indra/llmath/llvolumemgr.cpp fe7fe04ccc9a > indra/llmessage/llares.cpp fe7fe04ccc9a > indra/llmessage/llcurl.cpp fe7fe04ccc9a > indra/llmessage/lliohttpserver.h fe7fe04ccc9a > indra/llmessage/lliohttpserver.cpp fe7fe04ccc9a > indra/llmessage/lliosocket.h fe7fe04ccc9a > indra/llmessage/lliosocket.cpp fe7fe04ccc9a > indra/llmessage/llmail.h fe7fe04ccc9a > indra/llmessage/llmail.cpp fe7fe04ccc9a > indra/llmessage/llpumpio.h fe7fe04ccc9a > indra/llmessage/llpumpio.cpp fe7fe04ccc9a > indra/llmessage/llurlrequest.cpp fe7fe04ccc9a > indra/llmessage/message.cpp fe7fe04ccc9a > indra/llmessage/tests/networkio.h fe7fe04ccc9a > indra/llplugin/llplugininstance.h fe7fe04ccc9a > indra/llplugin/llplugininstance.cpp fe7fe04ccc9a > indra/llplugin/llpluginmessagepipe.cpp fe7fe04ccc9a > indra/llplugin/llpluginprocesschild.cpp fe7fe04ccc9a > indra/llplugin/llpluginprocessparent.h fe7fe04ccc9a > indra/llplugin/llpluginprocessparent.cpp fe7fe04ccc9a > indra/llplugin/llpluginsharedmemory.h fe7fe04ccc9a > indra/llplugin/llpluginsharedmemory.cpp fe7fe04ccc9a > indra/llplugin/slplugin/slplugin.cpp fe7fe04ccc9a > indra/llvfs/lllfsthread.cpp fe7fe04ccc9a > indra/llvfs/llvfs.cpp fe7fe04ccc9a > indra/media_plugins/gstreamer010/llmediaimplgstreamer.h fe7fe04ccc9a > indra/media_plugins/gstreamer010/llmediaimplgstreamer_syms.cpp fe7fe04ccc9a > indra/media_plugins/webkit/linux_volume_catcher.cpp fe7fe04ccc9a > indra/newview/llappviewer.h fe7fe04ccc9a > indra/newview/llappviewer.cpp fe7fe04ccc9a > indra/newview/llappviewerlinux.cpp fe7fe04ccc9a > indra/newview/llappviewerlinux_api_dbus.cpp fe7fe04ccc9a > indra/newview/llappviewermacosx.cpp fe7fe04ccc9a > indra/newview/llfloateranimpreview.cpp fe7fe04ccc9a > indra/newview/llmainlooprepeater.cpp fe7fe04ccc9a > indra/newview/lltexturecache.h fe7fe04ccc9a > indra/newview/lltexturecache.cpp fe7fe04ccc9a > indra/newview/lltexturefetch.cpp fe7fe04ccc9a > indra/newview/llviewermenufile.cpp fe7fe04ccc9a > indra/newview/llvoavatar.cpp fe7fe04ccc9a > indra/newview/llvocache.h fe7fe04ccc9a > indra/newview/llvocache.cpp fe7fe04ccc9a > indra/newview/llvoicevivox.cpp fe7fe04ccc9a > indra/newview/llwatchdog.cpp fe7fe04ccc9a > indra/newview/tests/llworldmap_test.cpp fe7fe04ccc9a > indra/test/lltemplatemessagebuilder_tut.cpp fe7fe04ccc9a > indra/test/message_tut.cpp fe7fe04ccc9a > indra/test/test.cpp fe7fe04ccc9a > indra/test_apps/llplugintest/llmediaplugintest.cpp fe7fe04ccc9a > indra/viewer_components/updater/llupdateinstaller.cpp fe7fe04ccc9a > > Diff: http://codereview.secondlife.com/r/99/diff > > > Testing > ------- > > Compiles and viewer functions normally. > > The new classes (LLAPRPool, LLThreadLocalData) and the LLAPRFile changes have been tested a lot more extensive, since they have been used as-is for months in imprudence and before that in my own viewer (since April). However, the patch contains changes to code elsewhere (to adapt it to the new API) that is rather new in this source tree. Note that changes with regard to LLAPRFile already have been in Snowglobe since version 1.1 (with some minor changes) including the method used to make thread-local data available. > > > Thanks, > > Aleric > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110204/fb1d36b8/attachment.htm From Aleric.Inglewood at gmail.com Fri Feb 4 06:24:48 2011 From: Aleric.Inglewood at gmail.com (Aleric Inglewood) Date: Fri, 04 Feb 2011 14:24:48 -0000 Subject: [opensource-dev] Review Request: STORM-864: As as developer, I would like an object oriented wrapper to make safe use of memory pools easier In-Reply-To: <20110203023052.1721.82839@domU-12-31-38-00-90-68.compute-1.internal> References: <20110203023052.1721.82839@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110204142448.12728.21069@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 2, 2011, 6:30 p.m., Merov Linden wrote: > > indra/llmessage/llpumpio.cpp, line 359 > > > > > > An example where the use of operator() is particularly unsightly... > > Aleric Inglewood wrote: > And rightfully so! It should be "extremely unpleasant" for the user to get to the underlaying apr_pool_t*. > That this code hacks access is exactly that: a hack. One has to be very careful when doing this. > The reason I did it here is because 1) I know what I'm doing, so it's ok in this case, 2) for this > first introduction of LLAPRPool I tried to make minimal changes to the actual functionality of > existing code using apr pools (with the exception of LLAPRFile, the rewrite of its API actually > coming from SNOW-103 which already proved itself in snowglobe, imprudence and other TPV's). > The fact that this access here is needed actually signifies that this code is not handling > pools in a very safe way, but I consider(ed) it better to keep the code "as-is" and hack around the > *safity* of LLAPRPool (and as a result not changing anything!) than to rewrite the interface at this > point for this particular part of the code; changing things is more risk, in this case, than not > using the API of LLAPRPool as intended. It would be harder to find if that rewrite would introduce > some kind of bug we made lots of changes at the same time. I propose to leave this as it is now > and look at changing it later once everyone feels secure about the stability of the current patch. > > Okay, that sounded nice -- but the truth is that I have no idea (at this point) if it is even > possible to do what that code does without accessing the underlaying apr_pool_t* like that (meaning, > not passing it directly to an APR function, but storing it in a structure). I just know that it > should feel dangerous to do so, so it seems OK that code that does it doesn't look very nice. > > > Boroondas Gupte wrote: > Then it should maybe be made even more obvious with a super-ugly name like getAPRPool_DO_NOT_CALL_THIS_DIRECTLY_use_LLAPRPool_instead() That is not possible, as operator() is definitely part of the normal API (it's just unfortunate that it has to exist). Let me explain more about what is so "dangerous" about allowing access. Also, realize that before this patch everything was completely open (accessible) and spread out through the code, so it's at least 1000 times better this way -- just not 100% bullet proof). Firstly, we can't use getAPRPool_DO_NOT_CALL_THIS_DIRECTLY_use_LLAPRPool_instead() instead of operator()(void), because that would change perfectly legal code like (where mPool is a LLAPRPool): apr_thread_cond_create(&mAPRCondp, mPool()); into apr_thread_cond_create(&mAPRCondp, mPool.getAPRPool_DO_NOT_CALL_THIS_DIRECTLY_use_LLAPRPool_instead()); where mPool() is the same as mPool.operator()(), returning the underlaying apr_pool_t* to pass it to the apr library call using it. The reason that I call it "dangerous" that the user (that is, other developers that use this LLAPRPool interface) can access the underlaying apr_pool_t* is because they might be tempted to do something like: apr_pool_t* pool = mPool(); // Use 'pool'. apr_pool_destroy(pool); Fortunately, this would be easy detectable by grepping the source code for 'apr_pool_t'. Less obvious would be: some_apr_defined_struct.pool = mPool(); // leave some_apr_defined_struct around for OTHER threads to use. That would, obviously, defy the thread-safity checks of LLAPRPool, and we also wouldn't find it by grepping for apr_pool_t because this struct is defined in a header of libapr. I'd almost say that one could call it "far fetched" to assume that anyone would do anything like this-- so the chance that anything wrong ever happening is indeed very small. Nevertheless, to avoid all that, I made the 'rule of thumb' that the operator() only be used WHEN passing the pool directly to an apr_* library call. It would have been better if we could even drop that restriction (by getting rid of the current possibility to corrupt things by getting access to the underlaying apr_pool_t), but that is only possible if the operator() is removed completely and we overload all apr_* functions that we use (making those friend of LLAPRPool, so they can call the real libapr function with apr_pool_t* parameter). I didn't feel that the remaining security risk warranted that though. Nevertheless, if merov wants then I can do this. The only draw back would be that 1) every source file would need to include the apr_pools.h (through linden_common.h I presume), just to stop every source code from possibly including that themselves and using apr pools directly. 2) Every time we want to use a new APR library function that needs a pool to be passed, we'd have to add it to the list of wrappers. Actually, both are pretty minimal changes; I'd have no objection or problem with this change at all (I just thought it would be harder to accept). For the rest of the code this would result in 1) code like, apr_thread_cond_create(&mAPRCondp, mPool); // No more '()' while 2) code like, some_apr_defined_struct.pool = mPool; // or mPool() wouldn't compile anymore. - Aleric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/99/#review315 ----------------------------------------------------------- On Jan. 29, 2011, 9:10 a.m., Aleric Inglewood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/99/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2011, 9:10 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Please see http://jira.secondlife.com/browse/STORM-864 > > I made a mercurial repository available for testing here: > > hg clone https://bitbucket.org/aleric/viewer-development-storm-864 > > From the commit message: > > Introduces a LLThreadLocalData class that can be > accessed through the static LLThread::tldata(). > Currently this object contains two (public) thread-local > objects: a LLAPRRootPool and a LLVolatileAPRPool. > > The first is the general memory pool used by this thread > (and this thread alone), while the second is intended > for short lived memory allocations (needed for APR). > The advantages of not mixing those two is that the latter > is used most frequently, and as a result of it's nature > can be destroyed and reconstructed on a "regular" basis. > > This patch adds LLAPRPool (completely replacing the old one), > which is a wrapper around apr_pool_t* and has complete > thread-safity checking. > > Whenever an apr call requires memory for some resource, > a memory pool in the form of an LLAPRPool object can > be created with the same life-time as this resource; > assuring clean up of the memory no sooner, but also > not much later than the life-time of the resource > that needs the memory. > > Many, many function calls and constructors had the > pool parameter simply removed (it is no longer the > concern of the developer, if you don't write code > that actually does an libapr call then you are no > longer bothered with memory pools at all). > > However, I kept the notion of short-lived and > long-lived allocations alive (see my remark in > the jira here: https://jira.secondlife.com/browse/STORM-864?focusedCommentId=235356&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-235356 > which requires that the LLAPRFile API needs > to allow the user to specify how long they > think a file will stay open. By choosing > 'short_lived' as default for the constructor > that immediately opens a file, the number of > instances where this needs to be specified is > drastically reduced however (obviously, any > automatic LLAPRFile is short lived). > > > This addresses bug STORM-864. > http://jira.secondlife.com/browse/STORM-864 > > > Diffs > ----- > > doc/contributions.txt fe7fe04ccc9a > indra/llaudio/llaudioengine_fmod.cpp fe7fe04ccc9a > indra/llaudio/llvorbisencode.cpp fe7fe04ccc9a > indra/llcharacter/llbvhloader.cpp fe7fe04ccc9a > indra/llcharacter/llkeyframemotionparam.cpp fe7fe04ccc9a > indra/llcharacter/llstatemachine.cpp fe7fe04ccc9a > indra/llcommon/CMakeLists.txt fe7fe04ccc9a > indra/llcommon/llapp.cpp fe7fe04ccc9a > indra/llcommon/llapr.h fe7fe04ccc9a > indra/llcommon/llapr.cpp fe7fe04ccc9a > indra/llcommon/llaprpool.h PRE-CREATION > indra/llcommon/llaprpool.cpp PRE-CREATION > indra/llcommon/llcommon.h fe7fe04ccc9a > indra/llcommon/llcommon.cpp fe7fe04ccc9a > indra/llcommon/llerror.h fe7fe04ccc9a > indra/llcommon/llerror.cpp fe7fe04ccc9a > indra/llcommon/llfixedbuffer.cpp fe7fe04ccc9a > indra/llcommon/llscopedvolatileaprpool.h PRE-CREATION > indra/llcommon/llthread.h fe7fe04ccc9a > indra/llcommon/llthread.cpp fe7fe04ccc9a > indra/llcommon/llthreadsafequeue.h fe7fe04ccc9a > indra/llcommon/llthreadsafequeue.cpp fe7fe04ccc9a > indra/llcommon/llworkerthread.h fe7fe04ccc9a > indra/llcommon/llworkerthread.cpp fe7fe04ccc9a > indra/llcrashlogger/llcrashlogger.cpp fe7fe04ccc9a > indra/llimage/llimage.cpp fe7fe04ccc9a > indra/llimage/llimagedimensionsinfo.cpp fe7fe04ccc9a > indra/llimage/llimagej2c.cpp fe7fe04ccc9a > indra/llimage/llimageworker.h fe7fe04ccc9a > indra/llimage/llimageworker.cpp fe7fe04ccc9a > indra/llmath/llvolumemgr.cpp fe7fe04ccc9a > indra/llmessage/llares.cpp fe7fe04ccc9a > indra/llmessage/llcurl.cpp fe7fe04ccc9a > indra/llmessage/lliohttpserver.h fe7fe04ccc9a > indra/llmessage/lliohttpserver.cpp fe7fe04ccc9a > indra/llmessage/lliosocket.h fe7fe04ccc9a > indra/llmessage/lliosocket.cpp fe7fe04ccc9a > indra/llmessage/llmail.h fe7fe04ccc9a > indra/llmessage/llmail.cpp fe7fe04ccc9a > indra/llmessage/llpumpio.h fe7fe04ccc9a > indra/llmessage/llpumpio.cpp fe7fe04ccc9a > indra/llmessage/llurlrequest.cpp fe7fe04ccc9a > indra/llmessage/message.cpp fe7fe04ccc9a > indra/llmessage/tests/networkio.h fe7fe04ccc9a > indra/llplugin/llplugininstance.h fe7fe04ccc9a > indra/llplugin/llplugininstance.cpp fe7fe04ccc9a > indra/llplugin/llpluginmessagepipe.cpp fe7fe04ccc9a > indra/llplugin/llpluginprocesschild.cpp fe7fe04ccc9a > indra/llplugin/llpluginprocessparent.h fe7fe04ccc9a > indra/llplugin/llpluginprocessparent.cpp fe7fe04ccc9a > indra/llplugin/llpluginsharedmemory.h fe7fe04ccc9a > indra/llplugin/llpluginsharedmemory.cpp fe7fe04ccc9a > indra/llplugin/slplugin/slplugin.cpp fe7fe04ccc9a > indra/llvfs/lllfsthread.cpp fe7fe04ccc9a > indra/llvfs/llvfs.cpp fe7fe04ccc9a > indra/media_plugins/gstreamer010/llmediaimplgstreamer.h fe7fe04ccc9a > indra/media_plugins/gstreamer010/llmediaimplgstreamer_syms.cpp fe7fe04ccc9a > indra/media_plugins/webkit/linux_volume_catcher.cpp fe7fe04ccc9a > indra/newview/llappviewer.h fe7fe04ccc9a > indra/newview/llappviewer.cpp fe7fe04ccc9a > indra/newview/llappviewerlinux.cpp fe7fe04ccc9a > indra/newview/llappviewerlinux_api_dbus.cpp fe7fe04ccc9a > indra/newview/llappviewermacosx.cpp fe7fe04ccc9a > indra/newview/llfloateranimpreview.cpp fe7fe04ccc9a > indra/newview/llmainlooprepeater.cpp fe7fe04ccc9a > indra/newview/lltexturecache.h fe7fe04ccc9a > indra/newview/lltexturecache.cpp fe7fe04ccc9a > indra/newview/lltexturefetch.cpp fe7fe04ccc9a > indra/newview/llviewermenufile.cpp fe7fe04ccc9a > indra/newview/llvoavatar.cpp fe7fe04ccc9a > indra/newview/llvocache.h fe7fe04ccc9a > indra/newview/llvocache.cpp fe7fe04ccc9a > indra/newview/llvoicevivox.cpp fe7fe04ccc9a > indra/newview/llwatchdog.cpp fe7fe04ccc9a > indra/newview/tests/llworldmap_test.cpp fe7fe04ccc9a > indra/test/lltemplatemessagebuilder_tut.cpp fe7fe04ccc9a > indra/test/message_tut.cpp fe7fe04ccc9a > indra/test/test.cpp fe7fe04ccc9a > indra/test_apps/llplugintest/llmediaplugintest.cpp fe7fe04ccc9a > indra/viewer_components/updater/llupdateinstaller.cpp fe7fe04ccc9a > > Diff: http://codereview.secondlife.com/r/99/diff > > > Testing > ------- > > Compiles and viewer functions normally. > > The new classes (LLAPRPool, LLThreadLocalData) and the LLAPRFile changes have been tested a lot more extensive, since they have been used as-is for months in imprudence and before that in my own viewer (since April). However, the patch contains changes to code elsewhere (to adapt it to the new API) that is rather new in this source tree. Note that changes with regard to LLAPRFile already have been in Snowglobe since version 1.1 (with some minor changes) including the method used to make thread-local data available. > > > Thanks, > > Aleric > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110204/593768bb/attachment-0001.htm From cg at lindenlab.com Fri Feb 4 08:17:08 2011 From: cg at lindenlab.com (CG Linden) Date: Fri, 4 Feb 2011 08:17:08 -0800 Subject: [opensource-dev] What is it with these Build Numbers? Message-ID: "Everybody thinks Release Engineering is like a bikeshed, so people go on happily slapping paint onto it, not realizing that there is a nuclear missile silo underneath." Yes, this is one of those things... after all, how hard can it be to list all the changes since the last release, or all the changes pending to go into the current release? To learn more about how we use build numbers, and why the build results occasionally had links to this "codeticket" thing, read: http://wiki.secondlife.com/wiki/Codeticket_Service -- cg -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110204/7a1e30b0/attachment.htm From oz at lindenlab.com Fri Feb 4 09:25:53 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Fri, 04 Feb 2011 12:25:53 -0500 Subject: [opensource-dev] Review Request: make PREHASH variables char const* const In-Reply-To: <20110204023627.11564.5227@domU-12-31-38-00-90-68.compute-1.internal> References: <20110204023531.15713.63689@domU-12-31-38-00-90-68.compute-1.internal> <20110204023627.11564.5227@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <4D4C36A1.4050604@lindenlab.com> On 2011-02-03 21:36, Aleric Inglewood wrote: > > Can this patch please be added to viewer-development? It's getting really annoying that I have to apply patches to the soruce tree before it even can compile cleanly :(. Adding comments merely to complain about progress or lack thereof is not helpful. Please don't do it. From latifer at streamgrid.net Fri Feb 4 09:42:27 2011 From: latifer at streamgrid.net (Latif Khalifa) Date: Fri, 4 Feb 2011 18:42:27 +0100 Subject: [opensource-dev] What is it with these Build Numbers? In-Reply-To: References: Message-ID: Very informative page, thank you very much! On Fri, Feb 4, 2011 at 5:17 PM, CG Linden wrote: > "Everybody thinks Release Engineering is like a bikeshed, so people go on > happily slapping paint onto it, not realizing that there is a nuclear > missile silo underneath." > > Yes, this is one of those things... after all, how hard can it be to list > all the changes since the last release, or all the changes pending to go > into the current release? > > To learn more about how we use build numbers, and why the build results > occasionally had links to this "codeticket" thing, read: > http://wiki.secondlife.com/wiki/Codeticket_Service > -- > cg > > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > From slitovchuk at productengine.com Fri Feb 4 10:49:27 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Fri, 04 Feb 2011 18:49:27 -0000 Subject: [opensource-dev] Review Request: (STORM-433) Friendship offer shifted up and placed over "Second Life" text Message-ID: <20110204184927.12722.76820@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/138/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Fixed reshaping notification panel with friendship offer when it is inserted into IM chat. This addresses bug STORM-433. http://jira.secondlife.com/browse/STORM-433 Diffs ----- indra/newview/llchathistory.cpp 2fe9d48e5881 indra/newview/lltoastnotifypanel.cpp 2fe9d48e5881 Diff: http://codereview.secondlife.com/r/138/diff Testing ------- Thanks, Seth -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110204/fd4e0584/attachment.htm From slitovchuk at productengine.com Fri Feb 4 10:54:04 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Fri, 04 Feb 2011 18:54:04 -0000 Subject: [opensource-dev] Review Request: (STORM-379) Content permissions aren't refreshed in the "Buy copy of" floater In-Reply-To: <20110128000558.30500.33057@domU-12-31-38-00-90-68.compute-1.internal> References: <20110128000558.30500.33057@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110204185404.25553.90520@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/126/#review330 ----------------------------------------------------------- Closing this request for now because it is meant to be fix the other way. See STORM-379. - Seth On Jan. 27, 2011, 4:05 p.m., Seth ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/126/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2011, 4:05 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Changed displaying the permissions of inventory items inside an object to show the permissions which will be granted to the next owner of the item. > > The permissions affected by this issue can be seen in Content tab of Tools floater which is open by selecting Edit in object's context menu. If agent can't perform certain actions on the item a respective suffix will be added to the item's name e.g. (no copy), (no modify) or(no transfer). > > This issue affects viewer 1.23 too. Could it be expected behavior? > > > This addresses bug STORM-379. > http://jira.secondlife.com/browse/STORM-379 > > > Diffs > ----- > > indra/newview/llpanelobjectinventory.cpp b542f8134a2b > > Diff: http://codereview.secondlife.com/r/126/diff > > > Testing > ------- > > > Thanks, > > Seth > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110204/4de8a07a/attachment.htm From akanevsky at productengine.com Fri Feb 4 15:39:38 2011 From: akanevsky at productengine.com (Anya Kanevsky) Date: Fri, 4 Feb 2011 15:39:38 -0800 Subject: [opensource-dev] Daily Scrum Summary - Friday, February 4 Message-ID: Friday, February 4 [edit ]General Notes ------------------------------ - All Merge requests should contain links to jira closed in that merge. Otherwise QA cannot test. - Please do not pick up issues tagged with needs-design until the tag has been removed. - Please remember to move issues to current Sprint when a) starting work on them or b) accepting issues from the community - MMOTD: Merov - QOTD: "dump your shit on the MM" is *not* a workable policy [edit ]Team Status ------------------------------ [edit ]Merov Linden ------------------------------ *PAST* - Merge Monkeying: push stuff to viewer-development - STORM-864 : APR memory pool : The Linux build problem is caused by LL bundling different versions of apr-suite for Mac (1.3.7), Windows (1.3.8) and Linux (1.2.8). We need to rationalize all that. The Windows build issue is different and should be fixable (has been in other places of the code). *FUTURE* - MM - STORM-864 : APR memory pool : Need to discuss with chopper how best to solve the apr_suite lib issue. Fix the Windows build issue. - STORM-955 : Massively duplicated objects : keep an eyes on this - STORM-746 : KDU Improvements: Compress j2c with precincts *IMPEDIMENTS* - none [edit ]Oz Linden ------------------------------ *PAST* - Created 'Open Development' jira project - Non-Snowstorm activities - PO Review - Discussions about open data APIs - Reviewed autobuild changes from NickyP - Following up with Team Chopper - Internal Linden training session *FUTURE* - Continue testing new jira project rules - Get autobuild/vcexpress requirements statement into OPEN-1 - Learn about FMOD packaging for viewer-autobuild *IMPEDIMENTS* - none [edit ]Q Linden ------------------------------ - OOO [edit ]Grumpity ProductEngine ------------------------------ *PAST* - VWR tirage - PO approvals - tons of PEQA deferred issues triage *FUTURE* - crashhunters - jira cleanup *IMPEDIMENTS* - All Merge requests should contain links to jira closed in that merge. Otherwise QA cannot test. - Vaidm is going on vacaiton next week [edit ]Paul ProductEngine ------------------------------ *PAST* - BUG STORM-680 (Avaline callers are added to the Recent list) - WIP. Progress 95%. Finish on Monday. Estimate ~ 2 hours. *FUTURE* - BUG STORM-680 (Avaline callers are added to the Recent list) - BUG STORM-357 (Gestures button is in the pressed state after drag-n-drop but gestures list isn't visible) *IMPEDIMENTS* - none [edit ]Seth Productengine ------------------------------ *PAST* - BUG (STORM-433) Friendship offer shifted up and placed over "Second Life" text - Found the cause of the problem in reshaping friendship offer notification inside IM window. Working on proper fix. *FUTURE* - BUG (STORM-433) Friendship offer shifted up and placed over "Second Life" text - Estimated: 2-4 hours. - BUG (STORM-601) Colour swatches don't receive focus if click on them in Preference -> Colors - Estimated: 4-6 hours. *IMPEDIMENTS* - none [edit ]Vadim Productengine ------------------------------ *PAST* - Story STORM-2 (Customizable viewer layouts): - Working on saving/restoring multiple instances of a floater. - Bug STORM-465 (Missing Strings from strings.xml): - Submitted an updated fix. *FUTURE* - Continue work on STORM-2. *IMPEDIMENTS* - need to leave early, will make up time on saturday - Vacation next week. [edit ]Andrey ProductEngine ------------------------------ *PAST* - picked up Beta3 build#2 (r220251) - executed smoke and integrity tests on Windows, Linux and OSX. See IQA-80 for more details. - smoke on Linux has been failed but it looks like specific environment issue (?) - proceeded with v-d regression testing, see spreadsheet - reported 2 issues: VWR-24714 and VWR-24715 *FUTURE* - investigate VWR-24714 - verify integrated STORM tickets against the latest v-d build *IMPEDIMENTS* - none [edit ]Wolfpup Lowenhar ------------------------------ *PAST* - Worked @ RL . - STORM-236 : - began debugging issue with button layout re-sized issues. Also discussed this with Oz in IRC. *FUTURE* - Work @ RL - STORM-941 : email Oz and Leyla concerning possible areas that could be causing the problem. *IMPEDIMENTS* - STORM-236 : waiting for new graphics and name to call the panel. - Not enough time to actually work on code. - Computer repair Client that dose not know what non repairable means and keeps trying to have me fix a unit that is beyond repair. [edit ]Jonathan Yap ------------------------------ *PAST* - Researching jiras to work on - XMPP testing *FUTURE* *IMPEDIMENTS* - Waiting for Oz to Storm-nnnn-ize my (growing) bug list. [edit ]Cummere Mayo ------------------------------ *PAST* - jira stuff - blog article http://jayrcelasecondlifetechnologist.blogspot.com/2011/02/its-little-things.html (there, included the link for you, grumpity!) - confrimed that far as i can tell all is well with the po build - repoed VWR-23874 and a couple other bugs for people *FUTURE* - new blog posts - not totally sure *IMPEDIMENTS* - weekend -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110204/7c22839f/attachment-0001.htm From merov at lindenlab.com Fri Feb 4 18:37:16 2011 From: merov at lindenlab.com (Merov Linden) Date: Sat, 05 Feb 2011 02:37:16 -0000 Subject: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2) In-Reply-To: <20110116135319.26155.13876@domU-12-31-38-00-90-68.compute-1.internal> References: <20110116135319.26155.13876@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110205023716.12800.51620@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/81/#review331 ----------------------------------------------------------- Ship it! OK, did a merge and complete TC build on all platforms: no merge issue, no build error. Clear to go. - Merov On Jan. 16, 2011, 5:53 a.m., Aleric Inglewood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/81/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2011, 5:53 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Turns out that most of my SNOW-800 patch was included in Viewer 2 (albeit without crediting me). > However, not everything was used and some more cleaning up was possible. > > After this patch, and when compiling with optimization, there are no duplicates left > anymore that shouldn't be there in the first place: apart from the debug stream > iostream guard variable, there are several static variables with the same name (r, r1, > r2, etc) but that indeed actually different symbol objects. Then there are a few > constant POD arrays that are duplicated a hand full of times because they are > accessed with a variable index (so optimizing them away is not possible). I left them > like that (although defining those as extern as well would have been more consistent > and not slower; in fact it would be faster theoretically because those arrays could > share the same cache page then). > > > This addresses bug VWR-24312. > http://jira.secondlife.com/browse/VWR-24312 > > > Diffs > ----- > > doc/contributions.txt 422f636c3343 > indra/llcharacter/llanimationstates.cpp 422f636c3343 > indra/llcommon/llavatarconstants.h 422f636c3343 > indra/llcommon/lllslconstants.h 422f636c3343 > indra/llcommon/llmetricperformancetester.h 422f636c3343 > indra/llmath/llcamera.h 422f636c3343 > indra/llmath/llcamera.cpp 422f636c3343 > indra/newview/llviewerobject.cpp 422f636c3343 > indra/newview/llvoavatar.cpp 422f636c3343 > indra/newview/llvosky.h 422f636c3343 > indra/newview/llvosky.cpp 422f636c3343 > > Diff: http://codereview.secondlife.com/r/81/diff > > > Testing > ------- > > Compiled with optimization and then running readelf on the executable to find duplicated symbols. > > > Thanks, > > Aleric > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110205/e7fc8769/attachment.htm From marc at inworlddesigns.com Fri Feb 4 20:03:12 2011 From: marc at inworlddesigns.com (Marc Adored) Date: Fri, 4 Feb 2011 23:03:12 -0500 Subject: [opensource-dev] streaming media on 64bit? Message-ID: I am on 64bit ubuntu and noticed that media on a prim works now even though I am using a 32bit viewer. I am assuming this is because it is a SLPlugin and not part of the viewer? I was wondering if the streaming audio/video that has not worked for 32bit viewers on 64bit systems could be reworked to work the same way? Is there plans for this? I think that with the refusal to work on a 64bit viewer this would be a good compromise because that is the only reason I require a 64bit built viewer. I just thought I would probe here first before messing with jiras :) From angel_of_crimson at hotmail.com Fri Feb 4 21:05:03 2011 From: angel_of_crimson at hotmail.com (Erin Mallory) Date: Sat, 5 Feb 2011 00:05:03 -0500 Subject: [opensource-dev] Beyond Storm-2 Message-ID: sooo I've been thinking allot, and I do mean allot about what else should be savable besides layout. when saving the layouts I think there should be an option to save certain preferences. here's the ones I was thinking of: All Graphics settings, all movement settings, and the preferences for chat notifications. and here is my reasoning: depending on what you are doing you may either want kick ass all effects graphics or very basic, speed graphics, or somewhere in between. And just moving the slider doesn't always really fit the graphics to whats needed. (for example if i'm on a date in a really great sim or doing photos i like to have local lights on, and much higher detail then i do when i'm say roleplaying, inventory sorting, building, or at a roller derby meet. In fact I have very different settings I like for each activity. likewise if im doing roller derby i like to have the wasd keys default to movement and for most other things i like them to be on typing. Allot of other people I know do the same. also though i don't ever use the chat popups myself some people actually do at least for some things... but several of those people toggle them off for certain things so it might be good to go ahead and include those in too. If we really wanted to get fancy we could also save the rendering types (like volume, particles, etc) I know this would be difficult but it would be worth it. One more thing that should be another option to save is the floater/search states... for example profiles should open to the same people its saved to if that's what the person wants. likewise inventory windows could be saved to the same search (or not) thats entered into the floater. for example when im sorting inventory i tend to have one with "saved," one with "duplicate," one with "not sure I like," and then two or three that i rotate the search field as needed. so I really think this should be an option to save as well... just my $2L worth -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110205/2c1e69ff/attachment.htm From sllists at boroon.dasgupta.ch Sat Feb 5 02:47:03 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Sat, 05 Feb 2011 11:47:03 +0100 Subject: [opensource-dev] streaming media on 64bit? In-Reply-To: References: Message-ID: <4D4D2AA7.9050905@boroon.dasgupta.ch> Hi Marc On 02/05/2011 05:03 AM, Marc Adored wrote: > I am on 64bit ubuntu and noticed that media on a prim works now even > though I am using a 32bit viewer. I am assuming this is because it is > a SLPlugin and not part of the viewer? That's not the reason: The SLPlugin binary, while a separate process than the viewer main binary, is also shipped only compiled for 32bit in the official downloads and thus faces the same problem as the main binary: it can only load 32bit libraries. The reason why it can display web content anyway, is that the library used for rendering html is also included (also in 32bit) in the download. > I was wondering if the > streaming audio/video that has not worked for 32bit viewers on 64bit > systems could be reworked to work the same way? For audio/video stream display, the GStreamer libraries are used, but those aren't included in the download. So SLPlugin tries to load the system-installed version (if any), which (if SLPlugin is compiled for 32bit) can only succeed if those libs are compiled for 32bit, too. So the possibilities would be: * Include 32bit GStreamer libraries in the official download (or in a separate download) o Around 17 MB including common plugins, but still excluding any dependency libraries that might have to be added for this to work, too * Offer SPLugin (and maybe the whole viewer) compiled for 64bit, too o This would mean additional QA work for LL. * Have Linux 64bit users install a 32bit GStreamer o Probably difficult on many distributions (because GStreamer is usually not part of the 32bit compatibility bundles, such as ia32-libs) (I've gone into more detail about the options from the users' point of view in past explanations .) > Is there plans for this? I don't know of any specific one. There's a feature request for offering official 64bit downloads: VWR-13793 . > I think that with the refusal to work on a 64bit viewer this > would be a good compromise because that is the only reason I require a > 64bit built viewer. That would indeed make life much easier for non-technical Linux 64bit users. > I just thought I would probe here first before messing with jiras :) Although this has been discussed in the past, it's good that someone brings it up again. Cheers, Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110205/0f9f69cb/attachment.htm From oz at lindenlab.com Sat Feb 5 03:25:24 2011 From: oz at lindenlab.com (Oz Linden) Date: Sat, 05 Feb 2011 11:25:24 -0000 Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. In-Reply-To: <20110204034810.12913.94716@domU-12-31-38-00-90-68.compute-1.internal> References: <20110204034810.12913.94716@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110205112524.25592.52183@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/136/ ----------------------------------------------------------- (Updated Feb. 5, 2011, 3:25 a.m.) Review request for Viewer. Changes ------- fixing pointer to jira issue Summary ------- This modification is a test case and applies to -OpenSourceRelWithDebInfo only. Configuration batch file content: @echo call c:\VC80\VC\bin\vcvars32.bat C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug configure -c OpenSourceRelWithDebInfo Build batch file content: C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug build -c OpenSourceRelWithDebInfo This is a clean up of a discarded RB This addresses bug open-1. http://jira.secondlife.com/browse/open-1 Diffs ----- autobuild.xml 00453191c1b9 Diff: http://codereview.secondlife.com/r/136/diff Testing ------- There is one post build re-configuration error related to devenv versus vcbuild parameter sequence. However,C:\lindenhg\viewer-autobuild-express-wip\build-vc80\newview\RelWithDebInfo\LindenDeveloper.exe was built and log on to aditi successful. Thanks, Nicky -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110205/dab4d2c5/attachment-0001.htm From wolfpup67 at earthlink.net Sat Feb 5 04:32:21 2011 From: wolfpup67 at earthlink.net (Wolfpup Lowenhar) Date: Sat, 05 Feb 2011 12:32:21 -0000 Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. In-Reply-To: <20110205112524.25592.52183@domU-12-31-38-00-90-68.compute-1.internal> References: <20110205112524.25592.52183@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110205123221.1721.1454@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/136/#review332 ----------------------------------------------------------- autobuild.xml I can understand this is testing for right now but instead of changing an existing element why not create a new one by copy and pasting this one then change the name slightly and make the needed mode it that one so as to not break existing settings for those that they do work for. - Wolfpup On Feb. 5, 2011, 3:25 a.m., Nicky Perian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/136/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2011, 3:25 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > This modification is a test case and applies to -OpenSourceRelWithDebInfo only. > > Configuration batch file content: > @echo > call c:\VC80\VC\bin\vcvars32.bat > C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug configure -c OpenSourceRelWithDebInfo > > Build batch file content: > C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug build -c OpenSourceRelWithDebInfo > > This is a clean up of a discarded RB > > > This addresses bug open-1. > http://jira.secondlife.com/browse/open-1 > > > Diffs > ----- > > autobuild.xml 00453191c1b9 > > Diff: http://codereview.secondlife.com/r/136/diff > > > Testing > ------- > > There is one post build re-configuration error related to devenv versus vcbuild parameter sequence. > However,C:\lindenhg\viewer-autobuild-express-wip\build-vc80\newview\RelWithDebInfo\LindenDeveloper.exe was built and > log on to aditi successful. > > > Thanks, > > Nicky > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110205/801d7265/attachment.htm From marc at inworlddesigns.com Sat Feb 5 06:29:57 2011 From: marc at inworlddesigns.com (Marc Adored) Date: Sat, 5 Feb 2011 09:29:57 -0500 Subject: [opensource-dev] streaming media on 64bit? In-Reply-To: <4D4D2AA7.9050905@boroon.dasgupta.ch> References: <4D4D2AA7.9050905@boroon.dasgupta.ch> Message-ID: So maybe someone should provide a download of the needed 32bit gstreamer libraries :) I think that if linden did this sort of like Pheonix does with the SLVoice where the first launch it downloads any extra libraries and puts them in the libs/bins folder. Is this a practice linden might be interested in? On Sat, Feb 5, 2011 at 5:47 AM, Boroondas Gupte wrote: > Hi Marc > > On 02/05/2011 05:03 AM, Marc Adored wrote: > > I am on 64bit ubuntu and noticed that media on a prim works now even > though I am using a 32bit viewer. I am assuming this is because it is > a SLPlugin and not part of the viewer? > > That's not the reason: The SLPlugin binary, while a separate process than > the viewer main binary, is also shipped only compiled for 32bit in the > official downloads and thus faces the same problem as the main binary: it > can only load 32bit libraries. The reason why it can display web content > anyway, is that the library used for rendering html is also included (also > in 32bit) in the download. > > I was wondering if the > streaming audio/video that has not worked for 32bit viewers on 64bit > systems could be reworked to work the same way? > > For audio/video stream display, the GStreamer libraries are used, but those > aren't included in the download. So SLPlugin tries to load the > system-installed version (if any), which (if SLPlugin is compiled for 32bit) > can only succeed if those libs are compiled for 32bit, too. > > So the possibilities would be: > > Include 32bit GStreamer libraries in the official download (or in a separate > download) > > Around 17 MB including common plugins, but still excluding any dependency > libraries that might have to be added for this to work, too > > Offer SPLugin (and maybe the whole viewer) compiled for 64bit, too > > This would mean additional QA work for LL. > > Have Linux 64bit users install a 32bit GStreamer > > Probably difficult on many distributions (because GStreamer is usually not > part of the 32bit compatibility bundles, such as ia32-libs) > > (I've gone into more detail about the options from the users' point of view > in past explanations.) > > Is there plans for this? > > I don't know of any specific one. There's a feature request for offering > official 64bit downloads: VWR-13793. > > I think that with the refusal to work on a 64bit viewer this > would be a good compromise because that is the only reason I require a > 64bit built viewer. > > That would indeed make life much easier for non-technical Linux 64bit users. > > I just thought I would probe here first before messing with jiras :) > > Although this has been discussed in the past, it's good that someone brings > it up again. > > Cheers, > Boroondas > From sldev at catznip.com Sat Feb 5 06:36:29 2011 From: sldev at catznip.com (Kitty Barnett) Date: Sat, 05 Feb 2011 14:36:29 -0000 Subject: [opensource-dev] Review Request: VWR-17050 No nearby people when over approxiamately 1000 meters In-Reply-To: <20110203130648.15713.38161@domU-12-31-38-00-90-68.compute-1.internal> References: <20110203130648.15713.38161@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110205143629.25011.67783@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 3, 2011, 5:06 a.m., Oz Linden wrote: > > Is there any reason to "fix" this in getAvatars() rather than just "fixing" it when processing the CoarseLocationUpdate legacy region message (and when processing the still unused cap)? The minimap for instance won't call getAvatars() but will rather access the position directly so it would still be broken for nearby avatars when >1000m. Additionally, if the plan is to still enable the http cap at some point in the future then fixing the viewer's handling of that now would ideally mean that the problem is fixed for everyone as soon as it's enabled rather than having to wait another quarter for the next viewer release that contains the fix. - Kitty ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/132/#review316 ----------------------------------------------------------- On Feb. 2, 2011, 3:39 p.m., Twisted Laws wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/132/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2011, 3:39 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > This modifies the getAvatars function in llworld to also include any avatars that are found within the range from the LLCharactes list as well (the list of avatars that is in the viewer object list). This should make sure that anyone that you visually see within range shows up in the list. Note that changing it in this function also affects LLFloaterAvatarPicker::populateNearMe, LLLocalSpeakerMgr::updateSpeakerList, as well as the LLPanelPeople::updateNearbyList that was originally mentioned in the Jira. The region avatars lists only contain valid position data when the avatars are below 1024m. The comment that mentions about retrieving uuids is based on the function, not the current uses. No current calls in the code are done with the avatar_ids argument NULL. Duplicates in the returned list need to be suppressed. > > > This addresses bug VWR-17050. > http://jira.secondlife.com/browse/VWR-17050 > > > Diffs > ----- > > indra/newview/llworld.cpp ebd53632620a > > Diff: http://codereview.secondlife.com/r/132/diff > > > Testing > ------- > > Simple testing in sandboxes of this patch at 20m and 2000m heights with and without avatars nearby. Tested with varying the NearMeRange to insure it does not show avatars beyond the range. Testers need to understand that RenderFarClip has an impact on the avatars that are actually in the viewer object list, so setting NearMeRange to a great distance at high altitude won't necessarily add avatars to the list. Basically if you can see the avatar and its within NearMeRange, the avatar should be in the nearby avatar list in the people panel. > > > Thanks, > > Twisted > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110205/8bfbfca0/attachment-0001.htm From marc at inworlddesigns.com Sat Feb 5 07:15:35 2011 From: marc at inworlddesigns.com (Marc Adored) Date: Sat, 5 Feb 2011 10:15:35 -0500 Subject: [opensource-dev] streaming media on 64bit? In-Reply-To: <4D4D2AA7.9050905@boroon.dasgupta.ch> References: <4D4D2AA7.9050905@boroon.dasgupta.ch> Message-ID: This is the error I get: pid:5205: (media plugin) grab_gst_syms:93: Found DSO: libgstreamer-0.10.so.0 pid:5205: (media plugin) grab_gst_syms:107: Found DSO: libgstvideo-0.10.so.0 (:5205): GStreamer-WARNING **: Failed to load plugin '/usr/lib32/gstreamer-0.10/libgstspc.so': libopenspc.so.0: cannot open shared object file: No such file or directory pid:5205: (media plugin) MediaPluginGStreamer010:170: MediaPluginGStreamer010 constructor - my PID=5205 pid:5205: (media plugin) receiveMessage:1000: GStreamer010 media instance failed to set up 2011-02-05T15:04:29Z INFO: LLPluginProcessParent::receiveMessage: plugin version string: GStreamer010 media plugin, GStreamer version 0.10.30.0 (runtime), 0.10.6.0 (headers) pid:5205: (media plugin) receiveMessage:1216: MediaPluginGStreamer010::receiveMessage: unknown message class: media_browser pid:5205: (media plugin) receiveMessage:1216: MediaPluginGStreamer010::receiveMessage: unknown message class: media_browser pid:5205: (media plugin) receiveMessage:1216: MediaPluginGStreamer010::receiveMessage: unknown message class: media_browser pid:5205: (media plugin) receiveMessage:1216: MediaPluginGStreamer010::receiveMessage: unknown message class: media_browser pid:5205: (media plugin) receiveMessage:1216: MediaPluginGStreamer010::receiveMessage: unknown message class: media_browser pid:5205: (media plugin) receiveMessage:1027: MediaPluginGStreamer010::receiveMessage: shared memory added, name: /LL5174_3, size: 8, address: 0xf732e000 pid:5205: (media plugin) receiveMessage:1107: ---->Got size change instruction from application with shm name: /LL5174_3 - size is 1 x 1 pid:5205: (media plugin) receiveMessage:1123: *** Got size change with matching shm, new size is 1 x 1 pid:5205: (media plugin) receiveMessage:1124: *** Got size change with matching shm, texture size size is 1 x 1 I have copied the gstreamer-0.10 from my wifes 32bit ubuntu to /usr/lib32/gstreamer-0.10 but it still cant find the file /usr/lib32/gstreamer-0.10/libgstspc.so. I have verified it is there so I am not sure why it can't find it. I also put all the gstreamer libs into the lib of sl folder and it still can not find it :/ I know she has all the proper gstreamer plugins installed also because streaming media works for her so theoretically it should work for me. From that message it just looks like its not finding the files... From sllists at boroon.dasgupta.ch Sat Feb 5 07:29:42 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Sat, 05 Feb 2011 16:29:42 +0100 Subject: [opensource-dev] Copying GStreamer from a 32bit system to a 64bit one (was: streaming media on 64bit?) In-Reply-To: References: <4D4D2AA7.9050905@boroon.dasgupta.ch> Message-ID: <4D4D6CE6.60007@boroon.dasgupta.ch> On 02/05/2011 04:15 PM, Marc Adored wrote: > (:5205): GStreamer-WARNING **: Failed to load plugin > '/usr/lib32/gstreamer-0.10/libgstspc.so': libopenspc.so.0: cannot open > shared object file: No such file or directory > > [...] > > I have copied the gstreamer-0.10 from my wifes 32bit ubuntu to > /usr/lib32/gstreamer-0.10 but it still cant find the file > /usr/lib32/gstreamer-0.10/libgstspc.so. GStreamer is not failing to find libgstspc.so ... ratherlibgstspc.so is failing to find libopenspc.so.0 ... GStreamer is not self-contained: It (or its plugins) uses a lot of shared libraries that aren't part of GStreamer itself (and thus not in its directory but somewhere else on the system). Cheers, Boroondas From sythos at gmail.com Sat Feb 5 07:48:17 2011 From: sythos at gmail.com (Altair Sythos Memo) Date: Sat, 5 Feb 2011 16:48:17 +0100 Subject: [opensource-dev] streaming media on 64bit? In-Reply-To: References: <4D4D2AA7.9050905@boroon.dasgupta.ch> Message-ID: <20110205164817.afa49d85.sythos@gmail.com> On Sat, 5 Feb 2011 10:15:35 -0500 Marc Adored wrote: > I have copied the gstreamer-0.10 from my wifes 32bit ubuntu to very bad idea > /usr/lib32/gstreamer-0.10 but it still cant find the file > /usr/lib32/gstreamer-0.10/libgstspc.so. I have verified it is there so > I am not sure why it can't find it. I also put all the gstreamer libs you need to install ia32libs, this bundle a ot of 32bit libraries to handle this kind of problems, install the package "linux32" too, may be nice and usefull run the viewer within it From marc at inworlddesigns.com Sat Feb 5 07:51:40 2011 From: marc at inworlddesigns.com (Marc Adored) Date: Sat, 5 Feb 2011 10:51:40 -0500 Subject: [opensource-dev] streaming media on 64bit? In-Reply-To: <20110205164817.afa49d85.sythos@gmail.com> References: <4D4D2AA7.9050905@boroon.dasgupta.ch> <20110205164817.afa49d85.sythos@gmail.com> Message-ID: On Sat, Feb 5, 2011 at 10:48 AM, Altair Sythos wrote: > On Sat, 5 Feb 2011 10:15:35 -0500 > Marc Adored wrote: > >> I have copied the gstreamer-0.10 from my wifes 32bit ubuntu to > > very bad idea Not really I didn't overwrite my libs in /usr/lib i put them in /usr/lib32 where they belong and its the same version/distro of ubuntu so it should be fine. > >> /usr/lib32/gstreamer-0.10 but it still cant find the file >> /usr/lib32/gstreamer-0.10/libgstspc.so. I have verified it is there so >> I am not sure why it can't find it. I also put all the gstreamer libs > > you need to install ia32libs, this bundle a ot of 32bit libraries to > handle this kind of problems, install the package "linux32" too, may be > nice and usefull run the viewer within it I have ia32libs installed but it doesnt install a 32bit gstreamer sadly. From marc at inworlddesigns.com Sat Feb 5 08:19:47 2011 From: marc at inworlddesigns.com (Marc Adored) Date: Sat, 5 Feb 2011 11:19:47 -0500 Subject: [opensource-dev] Copying GStreamer from a 32bit system to a 64bit one (was: streaming media on 64bit?) In-Reply-To: <4D4D6CE6.60007@boroon.dasgupta.ch> References: <4D4D2AA7.9050905@boroon.dasgupta.ch> <4D4D6CE6.60007@boroon.dasgupta.ch> Message-ID: SUCCESS! Ok so I found this wonderful program called getlibs. I've used it before and I tried to get gstreamer stuff installed but failed but I figured it out this time. I used this command to get a list of all my 64bit gstreamer stuff installed: apt-cache show gstreamer* |grep "Package: gstreamer" With that command I got a list and ran this command: getlibs -p gstreamer-tools gstreamer0.10-alsa gstreamer0.10-doc gstreamer0.10-esd gstreamer0.10-gnonlin gstreamer0.10-gnonlin-dbg gstreamer0.10-gnonlin-doc gstreamer0.10-nice gstreamer0.10-plugins-base gstreamer0.10-plugins-base-apps gstreamer0.10-plugins-base-dbg gstreamer0.10-plugins-base-doc gstreamer0.10-plugins-good gstreamer0.10-plugins-good-dbg gstreamer0.10-plugins-good-doc gstreamer0.10-pulseaudio gstreamer0.10-tools gstreamer0.10-x gstreamer-dbus-media-service gstreamer0.10-buzztard gstreamer0.10-buzztard-doc gstreamer0.10-ffmpeg gstreamer0.10-ffmpeg-dbg gstreamer0.10-fluendo-mp3 gstreamer0.10-gnomevfs gstreamer0.10-packagekit gstreamer0.10-plugins-bad gstreamer0.10-plugins-bad-dbg gstreamer0.10-plugins-bad-doc gstreamer0.10-plugins-cutter gstreamer0.10-plugins-ugly gstreamer0.10-plugins-ugly-dbg gstreamer0.10-plugins-ugly-doc gstreamer0.10-pocketsphinx gstreamer0.10-sdl gstreamer0.10-plugins-bad-multiverse gstreamer0.10-plugins-bad-multiverse-dbg gstreamer0.10-plugins-ugly-multiverse gstreamer0.10-plugins-ugly-multiverse-dbg gstreamer0.10-packagekit gstreamer0.10-fluendo-plugins-mp3-partner Yeah its a long command and it takes awhile to execute. The only package it failed to fetch was gstreamer0.10-fluendo-plugins-mp3-partner_7.0.20100316-3_i386 which I downloaded from http://pkgs.org/download/ubuntu-10.04/canonical-partner-i386/gstreamer0.10-fluendo-plugins-mp3-partner_7.0.20100316-3_i386.deb.html and then installed it like so: getlibs -i gstreamer0.10-fluendo-plugins-mp3-partner_7.0.20100316-3_i386.deb Then started secondlife and I had streaming audio! Now I will say that that list above could be cleaned up to only install what secondlife needs but I just did it all to get it working. I am sure some of those packages are duplicates also. Anyone who cares to clean it up go ahead I just got it working :P Also you probably need to install the 32bit compatibility packages first and of course you'll need to install getlibs. It used to be at http://frozenfox.freehostia.com/cappy/ but that link is broke and I am not sure if its in the default ubuntu repos :/ It shows up in mine but I don't know if that is because the package was installed from that link. I have had it on my machine for a long time. Hope this helps everyone :) On Sat, Feb 5, 2011 at 10:29 AM, Boroondas Gupte wrote: > On 02/05/2011 04:15 PM, Marc Adored wrote: >> (:5205): GStreamer-WARNING **: Failed to load plugin >> '/usr/lib32/gstreamer-0.10/libgstspc.so': libopenspc.so.0: cannot open >> shared object file: No such file or directory >> >> [...] >> >> I have copied the gstreamer-0.10 from my wifes 32bit ubuntu to >> /usr/lib32/gstreamer-0.10 but it still cant find the file >> /usr/lib32/gstreamer-0.10/libgstspc.so. > GStreamer is not failing to find libgstspc.so ... ratherlibgstspc.so is > failing to find libopenspc.so.0 ... > > GStreamer is not self-contained: It (or its plugins) uses a lot of > shared libraries that aren't part of GStreamer itself (and thus not in > its directory but somewhere else on the system). > > Cheers, > Boroondas > From jhwelch at gmail.com Sat Feb 5 09:35:28 2011 From: jhwelch at gmail.com (Jonathan Yap) Date: Sat, 05 Feb 2011 17:35:28 -0000 Subject: [opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well Message-ID: <20110205173528.15713.80341@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/139/ ----------------------------------------------------------- Review request for Viewer. Summary ------- This is a request for help. I am trying to learn more about c++ and how variables in one class are accessed from another. For someone who knows what they are doing this is probably a pretty easy question. I have been able to set the font size on the chat input box when it is created in llbottomtray.cpp. I would like to do the same thing when someone clicks in that box to input text; it is possible they have changed the font setting and I would like to apply the size there as well, but I am stuck on how to do this. I think the right place to do this is in llchatbar.cpp/LLChatBar::onInputEditorGainFocus(). I have tried all kinds of wrong ways but at this point am stymied. Exact steps on how to proceed would be appreciated. This addresses bug vwr-22220. http://jira.secondlife.com/browse/vwr-22220 Diffs ----- indra/llui/lllineeditor.h 3d2e71443c58 indra/llui/lllineeditor.cpp 3d2e71443c58 indra/newview/llbottomtray.cpp 3d2e71443c58 indra/newview/llchatbar.cpp 3d2e71443c58 Diff: http://codereview.secondlife.com/r/139/diff Testing ------- Thanks, Jonathan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110205/55dc547d/attachment.htm From nickyperian at yahoo.com Sat Feb 5 14:12:39 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Sat, 05 Feb 2011 22:12:39 -0000 Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. In-Reply-To: <20110205112524.25592.52183@domU-12-31-38-00-90-68.compute-1.internal> References: <20110205112524.25592.52183@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110205221239.25836.14870@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/136/#review334 ----------------------------------------------------------- WolfPup: I tried the adding a slightly different group to autobuild.xml (OpenSourceRelWithDebInfoE) and python scripts crash. Appears to perform actions based on the section title in addition to the section content. So, i think the LL Devs should work that one out. Python error output: C:\lindenhg\viewer-autobuild-wip>autobconf ECHO is on. C:\lindenhg\viewer-autobuild-wip>call c:\VC80\VC\bin\vcvars32.bat C:\lindenhg\viewer-autobuild-wip>"C:\VC80\Common7\Tools\vsvars32.bat" Setting environment for using Microsoft Visual Studio 2005 x86 tools. C:\lindenhg\viewer-autobuild-wip>C:\lindenhg\autobuild-vcexpress-wip\bin\autobui ld --debug configure -c OpenSourceRelWithDebInfoE no configuration for build configuration 'OpenSourceRelWithDebInfoE' Traceback (most recent call last): File "C:\lindenhg\autobuild-vcexpress-wip\autobuild\autobuild_tool_configure.p y", line 106, in _configure_a_configuration config.get_build_configuration(build_configuration.name, 'common') File "C:\lindenhg\autobuild-vcexpress-wip\autobuild\configfile.py", line 100, in get_build_configuration build_configuration_name) ConfigurationError: no configuration for build configuration 'OpenSourceRelWithD ebInfoE' no common platform found Traceback (most recent call last): File "C:\Python26\lib\logging\__init__.py", line 776, in emit msg = self.format(record) File "C:\Python26\lib\logging\__init__.py", line 654, in format return fmt.format(record) File "C:\Python26\lib\logging\__init__.py", line 436, in format record.message = record.getMessage() File "C:\Python26\lib\logging\__init__.py", line 306, in getMessage msg = msg % self.args File "C:\lindenhg\autobuild-vcexpress-wip\autobuild\executable.py", line 86, i n __str__ return ' '.join(all_arguments) TypeError: sequence item 0: expected string, NoneType found no command specified Traceback (most recent call last): File "C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild", line 47, in sys.exit( Autobuild().main(sys.argv[1:]) ) File "C:\lindenhg\autobuild-vcexpress-wip\autobuild\autobuild_main.py", line 1 35, in main tool_to_run.run(args) File "C:\lindenhg\autobuild-vcexpress-wip\autobuild\autobuild_tool_configure.p y", line 81, in run args.additional_options, args.dry_run) File "C:\lindenhg\autobuild-vcexpress-wip\autobuild\autobuild_tool_configure.p y", line 123, in _configure_a_configuration return configure_executable(extra_arguments) File "C:\lindenhg\autobuild-vcexpress-wip\autobuild\executable.py", line 72, i n __call__ raise ExecutableError('no command specified') ExecutableError: no command specified ERROR: no command specified For more information: try re-running your command with --verbose or --debug - Nicky On Feb. 5, 2011, 3:25 a.m., Nicky Perian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/136/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2011, 3:25 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > This modification is a test case and applies to -OpenSourceRelWithDebInfo only. > > Configuration batch file content: > @echo > call c:\VC80\VC\bin\vcvars32.bat > C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug configure -c OpenSourceRelWithDebInfo > > Build batch file content: > C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug build -c OpenSourceRelWithDebInfo > > This is a clean up of a discarded RB > > > This addresses bug open-1. > http://jira.secondlife.com/browse/open-1 > > > Diffs > ----- > > autobuild.xml 00453191c1b9 > > Diff: http://codereview.secondlife.com/r/136/diff > > > Testing > ------- > > There is one post build re-configuration error related to devenv versus vcbuild parameter sequence. > However,C:\lindenhg\viewer-autobuild-express-wip\build-vc80\newview\RelWithDebInfo\LindenDeveloper.exe was built and > log on to aditi successful. > > > Thanks, > > Nicky > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110205/11b299e2/attachment.htm From jhwelch at gmail.com Sat Feb 5 15:08:54 2011 From: jhwelch at gmail.com (Jonathan Yap) Date: Sat, 05 Feb 2011 23:08:54 -0000 Subject: [opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well In-Reply-To: <20110205173528.15713.80341@domU-12-31-38-00-90-68.compute-1.internal> References: <20110205173528.15713.80341@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110205230854.25918.81986@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/139/ ----------------------------------------------------------- (Updated Feb. 5, 2011, 3:08 p.m.) Review request for Viewer. Changes ------- Pay no attention to anything in llchatbar -- I am told that is dead code. The font is set in bottomtray when the chat box is initially built. I suspect that code can now be deleted as the font is set every time when the chat box is given focus in nearbychatbar. Summary ------- This is a request for help. I am trying to learn more about c++ and how variables in one class are accessed from another. For someone who knows what they are doing this is probably a pretty easy question. I have been able to set the font size on the chat input box when it is created in llbottomtray.cpp. I would like to do the same thing when someone clicks in that box to input text; it is possible they have changed the font setting and I would like to apply the size there as well, but I am stuck on how to do this. I think the right place to do this is in llchatbar.cpp/LLChatBar::onInputEditorGainFocus(). I have tried all kinds of wrong ways but at this point am stymied. Exact steps on how to proceed would be appreciated. This addresses bug vwr-22220. http://jira.secondlife.com/browse/vwr-22220 Diffs (updated) ----- indra/llui/lllineeditor.h 3d2e71443c58 indra/llui/lllineeditor.cpp 3d2e71443c58 indra/newview/llbottomtray.cpp 3d2e71443c58 indra/newview/llchatbar.h 3d2e71443c58 indra/newview/llchatbar.cpp 3d2e71443c58 indra/newview/llnearbychatbar.cpp 3d2e71443c58 Diff: http://codereview.secondlife.com/r/139/diff Testing ------- Thanks, Jonathan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110205/707b0a9b/attachment.htm From nickyperian at yahoo.com Sat Feb 5 20:50:50 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Sun, 06 Feb 2011 04:50:50 -0000 Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. In-Reply-To: <20110205112524.25592.52183@domU-12-31-38-00-90-68.compute-1.internal> References: <20110205112524.25592.52183@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110206045050.28753.91585@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/136/ ----------------------------------------------------------- (Updated Feb. 5, 2011, 8:50 p.m.) Review request for Viewer. Changes ------- Updated per Wolfpup review. Restored OpenSourceRelWithDebInfo to devenv build. Established OpenSourceRelWithDebInfoE for Express edition which uses vcbuild.exe. autobconf.bat content-- @echo call c:\VC80\VC\bin\vcvars32.bat C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug configure -c OpenSourceRelWithDebInfoE autobb.bat content-- C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug build -c OpenSourceRelWithDebInfoE Problem cited in my earlier entry was not considering the dual nature of autobuild.xml. That being sections for configuration and building. Bottom line is this should work for Express without breaking Pro. If both Pro and Express are installed either method may be used. If only Pro is present either method my be used. Summary ------- This modification is a test case and applies to -OpenSourceRelWithDebInfo only. Configuration batch file content: @echo call c:\VC80\VC\bin\vcvars32.bat C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug configure -c OpenSourceRelWithDebInfo Build batch file content: C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug build -c OpenSourceRelWithDebInfo This is a clean up of a discarded RB This addresses bug open-1. http://jira.secondlife.com/browse/open-1 Diffs (updated) ----- autobuild.xml 00453191c1b9 Diff: http://codereview.secondlife.com/r/136/diff Testing ------- There is one post build re-configuration error related to devenv versus vcbuild parameter sequence. However,C:\lindenhg\viewer-autobuild-express-wip\build-vc80\newview\RelWithDebInfo\LindenDeveloper.exe was built and log on to aditi successful. Thanks, Nicky -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110206/85381867/attachment.htm From jhwelch at gmail.com Sun Feb 6 00:54:05 2011 From: jhwelch at gmail.com (Jonathan Yap) Date: Sun, 06 Feb 2011 08:54:05 -0000 Subject: [opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well In-Reply-To: <20110205230854.25918.81986@domU-12-31-38-00-90-68.compute-1.internal> References: <20110205230854.25918.81986@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110206085405.28753.15909@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/139/ ----------------------------------------------------------- (Updated Feb. 6, 2011, 12:54 a.m.) Review request for Viewer. Changes ------- Removed changes to bottomtray.cpp Summary ------- This is a request for help. I am trying to learn more about c++ and how variables in one class are accessed from another. For someone who knows what they are doing this is probably a pretty easy question. I have been able to set the font size on the chat input box when it is created in llbottomtray.cpp. I would like to do the same thing when someone clicks in that box to input text; it is possible they have changed the font setting and I would like to apply the size there as well, but I am stuck on how to do this. I think the right place to do this is in llchatbar.cpp/LLChatBar::onInputEditorGainFocus(). I have tried all kinds of wrong ways but at this point am stymied. Exact steps on how to proceed would be appreciated. This addresses bug vwr-22220. http://jira.secondlife.com/browse/vwr-22220 Diffs (updated) ----- indra/llui/lllineeditor.h 3d2e71443c58 indra/llui/lllineeditor.cpp 3d2e71443c58 indra/newview/llchatbar.h 3d2e71443c58 indra/newview/llchatbar.cpp 3d2e71443c58 indra/newview/llnearbychatbar.cpp 3d2e71443c58 Diff: http://codereview.secondlife.com/r/139/diff Testing ------- Thanks, Jonathan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110206/b009c300/attachment-0001.htm From trilobyte550m at gmail.com Sun Feb 6 05:55:57 2011 From: trilobyte550m at gmail.com (Trilo Byte) Date: Sun, 6 Feb 2011 05:55:57 -0800 Subject: [opensource-dev] Friends Permissions Message-ID: <29C5C7D7-C6E2-4E7E-91FE-B083ED97C0C6@gmail.com> Please forgive the silly question, but I seemed to have missed something in the transition to web profiles. On the Friends sidebar panel I can see the icons that show what permissions the people on my friends list have (see me online, locate me on the map, move my objects, etc), but I can't figure out how to change those settings. It used to be on the Notes & Privacy tab of the Profile, but the web profile doesn't have any such option. Any ideas? TriloByte Zanzibar From sllists at boroon.dasgupta.ch Sun Feb 6 06:06:07 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Sun, 06 Feb 2011 15:06:07 +0100 Subject: [opensource-dev] Friends Permissions In-Reply-To: <29C5C7D7-C6E2-4E7E-91FE-B083ED97C0C6@gmail.com> References: <29C5C7D7-C6E2-4E7E-91FE-B083ED97C0C6@gmail.com> Message-ID: <4D4EAACF.2050908@boroon.dasgupta.ch> On 02/06/2011 02:55 PM, Trilo Byte wrote: > [...] permissions the people on my friends list have (see me online, locate me on the map, move my objects, etc), but I can't figure out how to change those settings. It used to be on the Notes & Privacy tab of the Profile, but the web profile doesn't have any such option. Any ideas? On the web profile, button *Action* > *Set Privacy*. Though, I must say I'd prefer if this was possible directly from the friends list. Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110206/83603d8d/attachment.htm From oz at lindenlab.com Sun Feb 6 06:15:46 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Sun, 06 Feb 2011 09:15:46 -0500 Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. In-Reply-To: <20110206045050.28753.91585@domU-12-31-38-00-90-68.compute-1.internal> References: <20110205112524.25592.52183@domU-12-31-38-00-90-68.compute-1.internal> <20110206045050.28753.91585@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <4D4EAD12.8070801@lindenlab.com> I've created a repo sync'ed up to the latest viewer-development, and with this workaround (I renamed the configuration VCexpressRelWithDebInfo to make it stand out a bit more). If folks with VS Express (2005) could please test it : https://bitbucket.org/oz_linden/viewer-autobuildvs8 I'm running a test in TeamCity now to make sure that it does not bother the production builds. I don't consider this a real fix for the problem (now tracked as OPEN-1, incidentally), but it's a good enough workaround that we could lower the severity below Showstopper and remove this block on merging autobuild into viewer-development. That would leave the only remaining Showstopper OPEN-4 (using Fmod in an autobuild), which shouldn't be too hard to document some workaround for. From oz at lindenlab.com Sun Feb 6 07:40:52 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Sun, 06 Feb 2011 10:40:52 -0500 Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. In-Reply-To: <4D4EAD12.8070801@lindenlab.com> References: <20110205112524.25592.52183@domU-12-31-38-00-90-68.compute-1.internal> <20110206045050.28753.91585@domU-12-31-38-00-90-68.compute-1.internal> <4D4EAD12.8070801@lindenlab.com> Message-ID: <4D4EC104.1030901@lindenlab.com> On 2011-02-06 9:15, Oz Linden (Scott Lawrence) wrote: > I've created a repo sync'ed up to the latest viewer-development, and > with this workaround (I renamed the configuration > VCexpressRelWithDebInfo to make it stand out a bit more). If folks > with VS Express (2005) could please test it : > > https://bitbucket.org/oz_linden/viewer-autobuildvs8 > > I'm running a test in TeamCity now to make sure that it does not > bother the production builds. > > I don't consider this a real fix for the problem (now tracked as > OPEN-1, incidentally), but it's a good enough workaround that we could > lower the severity below Showstopper and remove this block on merging > autobuild into viewer-development. > > That would leave the only remaining Showstopper OPEN-4 (using Fmod in > an autobuild), which shouldn't be too hard to document some workaround > for. > Please test (or retest, as the case may be) using the above repo at changeset 21ef0a07c2cd or later... Thanks to NickyP, JonathanYap, and archer for developing and testing this workaround. From nickyperian at yahoo.com Sun Feb 6 08:55:58 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Sun, 6 Feb 2011 08:55:58 -0800 (PST) Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. In-Reply-To: <4D4EC104.1030901@lindenlab.com> References: <20110205112524.25592.52183@domU-12-31-38-00-90-68.compute-1.internal> <20110206045050.28753.91585@domU-12-31-38-00-90-68.compute-1.internal> <4D4EAD12.8070801@lindenlab.com> <4D4EC104.1030901@lindenlab.com> Message-ID: <418575.66369.qm@web43511.mail.sp1.yahoo.com> 14773 (21ef0a07c2cd) OPEN-1 WORKAROUND correct build arg Build complete: 125 Projects succeeded, 0 Projects failed, 2 Projects skipped C:\lindenhg\viewer-autobuildvs8> ________________________________ From: Oz Linden (Scott Lawrence) To: opensource-dev at lists.secondlife.com Sent: Sun, February 6, 2011 9:40:52 AM Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. On 2011-02-06 9:15, Oz Linden (Scott Lawrence) wrote: > I've created a repo sync'ed up to the latest viewer-development, and > with this workaround (I renamed the configuration > VCexpressRelWithDebInfo to make it stand out a bit more). If folks > with VS Express (2005) could please test it : > > https://bitbucket.org/oz_linden/viewer-autobuildvs8 > > I'm running a test in TeamCity now to make sure that it does not > bother the production builds. > > I don't consider this a real fix for the problem (now tracked as > OPEN-1, incidentally), but it's a good enough workaround that we could > lower the severity below Showstopper and remove this block on merging > autobuild into viewer-development. > > That would leave the only remaining Showstopper OPEN-4 (using Fmod in > an autobuild), which shouldn't be too hard to document some workaround > for. > Please test (or retest, as the case may be) using the above repo at changeset 21ef0a07c2cd or later... Thanks to NickyP, JonathanYap, and archer for developing and testing this workaround. _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110206/c2ac19d0/attachment.htm From ima.mechanique at blueyonder.co.uk Sun Feb 6 09:11:37 2011 From: ima.mechanique at blueyonder.co.uk (Ima Mechanique) Date: Sun, 06 Feb 2011 17:11:37 GMT Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. In-Reply-To: <4D4EC104.1030901@lindenlab.com> References: <4D4EAD12.8070801@lindenlab.com> <4D4EC104.1030901@lindenlab.com> Message-ID: <20110206170522.E0C9.5FD3A259@blueyonder.co.uk> I'm getting dozens of these errors fatal error C1083: Cannot open include file: 'winsock2.h': No such file or directory and fatal error C1083: Cannot open include file: 'windows.h': No such file or directory Seems that it is not using the Include directories list. -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk From twisted_laws at hotmail.com Sun Feb 6 09:27:05 2011 From: twisted_laws at hotmail.com (Twisted Laws) Date: Sun, 6 Feb 2011 12:27:05 -0500 Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. In-Reply-To: <4D4EC104.1030901@lindenlab.com> References: <20110205112524.25592.52183@domU-12-31-38-00-90-68.compute-1.internal>, <20110206045050.28753.91585@domU-12-31-38-00-90-68.compute-1.internal>, <4D4EAD12.8070801@lindenlab.com>, <4D4EC104.1030901@lindenlab.com> Message-ID: The autobuild configure -c OpenSourceRelWithDebInfo worked fine if I run it from a Visual C++ command prompt but not in a cygwin window. But the build fails with an expected (??) error with fmod. c:\dev\hgbuilds\viewer-autobuildvs8>autobuild build unable to download file: Traceback (most recent call last): File "C:\Python26\Lib\site-packages\autobuild\common.py", line 243, in downloa d_package file(cachename, 'wb').write(urllib2.urlopen(package).read()) File "C:\Python26\lib\urllib2.py", line 124, in urlopen return _opener.open(url, data, timeout) File "C:\Python26\lib\urllib2.py", line 383, in open response = self._open(req, data) File "C:\Python26\lib\urllib2.py", line 401, in _open '_open', req) File "C:\Python26\lib\urllib2.py", line 361, in _call_chain result = func(*args) File "C:\Python26\lib\urllib2.py", line 1130, in http_open return self.do_open(httplib.HTTPConnection, req) File "C:\Python26\lib\urllib2.py", line 1105, in do_open raise URLError(err) URLError: ERROR: failed to download http://s3-proxy.lindenlab.com/private-builds-secondlif e-com/hg/repo/merov_fmod-autobuild/rev/219050/arch/CYGWIN/installer/fmod-3.75-wi ndows-20110113.tar.bz2 For more information: try re-running your command with --verbose or --debug CMake Error at cmake/Prebuilt.cmake:51 (message): Failed to download or unpack prebuilt 'fmod'. Process returned 1. Call Stack (most recent call first): cmake/FMOD.cmake:12 (use_prebuilt_binary) llaudio/CMakeLists.txt:8 (include) -- Configuring incomplete, errors occurred! ERROR: configuring default configuration returned 1 For more information: try re-running your command with --verbose or --debug c:\dev\hgbuilds\viewer-autobuildvs8> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110206/c6b7e92a/attachment.htm From twisted_laws at hotmail.com Sun Feb 6 09:38:11 2011 From: twisted_laws at hotmail.com (Twisted Laws) Date: Sun, 6 Feb 2011 12:38:11 -0500 Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. In-Reply-To: References: <20110205112524.25592.52183@domU-12-31-38-00-90-68.compute-1.internal>, , <20110206045050.28753.91585@domU-12-31-38-00-90-68.compute-1.internal>, , <4D4EAD12.8070801@lindenlab.com>, <4D4EC104.1030901@lindenlab.com>, Message-ID: Since I wasn't sure of the exact command to run I also tried: c:\dev\hgbuilds\viewer-autobuildvs8>autobuild build -c OpenSourceRelWithDebInfo --verbose executing configure command cmake -DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo -DUNA TTENDED:BOOL=OFF -DWORD_SIZE:STRING=32 -DROOT_PROJECT_NAME:STRING=SecondLife -G "Visual Studio 8 2005" -DSTANDALONE:BOOL=FALSE -DINSTALL_PROPRIETARY=FALSE -DFMO D=FALSE ../indra package libuuid has no installation information configured for platform windows package fontconfig has no installation information configured for platform windo ws -- We seem to have an artwork bundle in the tree - brilliant. -- Version of viewer is 2.6.0.0 -- Configuring done -- Generating done -- Build files have been written to: C:/dev/hgbuilds/viewer-autobuildvs8/build-v c80 executing build command devenv.com /build RelWithDebInfo SecondLife.sln 'devenv.com' is not recognized as an internal or external command, operable program or batch file. ERROR: building default configuration returned 1 For more information: try re-running your command with --verbose or --debug c:\dev\hgbuilds\viewer-autobuildvs8> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110206/103bcc23/attachment-0001.htm From nickyperian at yahoo.com Sun Feb 6 09:51:16 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Sun, 6 Feb 2011 09:51:16 -0800 (PST) Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. In-Reply-To: References: <20110205112524.25592.52183@domU-12-31-38-00-90-68.compute-1.internal>, , <20110206045050.28753.91585@domU-12-31-38-00-90-68.compute-1.internal>, , <4D4EAD12.8070801@lindenlab.com>, <4D4EC104.1030901@lindenlab.com>, Message-ID: <40103.56249.qm@web43509.mail.sp1.yahoo.com> try autobuild --debug build -c VCexpressRelWithDebInfo ________________________________ From: Twisted Laws To: Oz Linden ; SLDEV Sent: Sun, February 6, 2011 11:38:11 AM Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. c:\dev\hgbuilds\viewer-autobuildvs8>autobuild build -c OpenSourceRelWithDebInfo Since I wasn't sure of the exact command to run I also tried: c:\dev\hgbuilds\viewer-autobuildvs8>autobuild build -c OpenSourceRelWithDebInfo --verbose executing configure command cmake -DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo -DUNA TTENDED:BOOL=OFF -DWORD_SIZE:STRING=32 -DROOT_PROJECT_NAME:STRING=SecondLife -G "Visual Studio 8 2005" -DSTANDALONE:BOOL=FALSE -DINSTALL_PROPRIETARY=FALSE -DFMO D=FALSE ../indra package libuuid has no installation information configured for platform windows package fontconfig has no installation information configured for platform windo ws -- We seem to have an artwork bundle in the tree - brilliant. -- Version of viewer is 2.6.0.0 -- Configuring done -- Generating done -- Build files have been written to: C:/dev/hgbuilds/viewer-autobuildvs8/build-v c80 executing build command devenv.com /build RelWithDebInfo SecondLife.sln 'devenv.com' is not recognized as an internal or external command, operable program or batch file. ERROR: building default configuration returned 1 For more information: try re-running your command with --verbose or --debug c:\dev\hgbuilds\viewer-autobuildvs8> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110206/bf8fcae9/attachment.htm From twisted_laws at hotmail.com Sun Feb 6 09:56:55 2011 From: twisted_laws at hotmail.com (Twisted Laws) Date: Sun, 6 Feb 2011 12:56:55 -0500 Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. In-Reply-To: References: <20110205112524.25592.52183@domU-12-31-38-00-90-68.compute-1.internal>, , , <20110206045050.28753.91585@domU-12-31-38-00-90-68.compute-1.internal>, , , <4D4EAD12.8070801@lindenlab.com>, , <4D4EC104.1030901@lindenlab.com>, , , Message-ID: Ok, i'm an idiot and can't follow instructions.... So i reread Oz's msg and found i was using the wrong config and redid it with autobuild configure -c VCexpressRelWithDebInfo Then that part worked ok. If i then just used "autobuild build" it had the same fmod error as before. So i tried autobuild build -c VCexpressRelWithDebInfo --verbose and things went further but as someone else reported then i got 100's of errors about winsock2.h not being found. Why does it continue to try to build everything after it gets so many errors? Build complete: 12 Projects succeeded, 113 Projects failed, 2 Projects skipped -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110206/9f1a0a84/attachment.htm From twisted_laws at hotmail.com Sun Feb 6 11:07:27 2011 From: twisted_laws at hotmail.com (Twisted Laws) Date: Sun, 6 Feb 2011 14:07:27 -0500 Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. In-Reply-To: References: <20110205112524.25592.52183@domU-12-31-38-00-90-68.compute-1.internal>, , , , , <20110206045050.28753.91585@domU-12-31-38-00-90-68.compute-1.internal>, , , , , <4D4EAD12.8070801@lindenlab.com>, , <4D4EC104.1030901@lindenlab.com>, , , , , , Message-ID: Ok, i found i can get much further compiling in the IDE and this is all i end up with now. Note that the issue with winres.h is one i always have had with and easy change of defining IDC_STATIC and including winresrc.h instead. Twisted Warning 1 warning LNK4099: PDB 'vc80.pdb' was not found with '..\packages\lib\release\exception_handler.lib' or at 'C:\dev\hgbuilds\viewer-autobuildvs8\build-vc80\sharedlibs\RelWithDebInfo\vc80.pdb'; linking object as if no debug info exception_handler.lib Warning 2 warning LNK4099: PDB 'vc80.pdb' was not found with '..\packages\lib\release\crash_generation_client.lib' or at 'C:\dev\hgbuilds\viewer-autobuildvs8\build-vc80\sharedlibs\RelWithDebInfo\vc80.pdb'; linking object as if no debug info crash_generation_client.lib Warning 3 warning LNK4099: PDB 'vc80.pdb' was not found with '..\packages\lib\release\common.lib' or at 'C:\dev\hgbuilds\viewer-autobuildvs8\build-vc80\sharedlibs\RelWithDebInfo\vc80.pdb'; linking object as if no debug info common.lib Error 4 error PRJ0019: A tool returned an error code from "Generating PROJECT_llmessage_TEST_lltemplatemessagedispatcher_ok.txt" llmessage_tests Error 5 error PRJ0019: A tool returned an error code from "Generating PROJECT_llupdaterservice_TEST_llupdaterservice_ok.txt" llupdaterservice_tests Error 6 error PRJ0019: A tool returned an error code from "Performing viewer_manifest copy" copy_w_viewer_manifest Warning 7 warning LNK4221: no public symbols found; archive member will be inaccessible llfunctorregistry.obj Error 8 fatal error RC1015: cannot open include file 'winres.h'. c:\dev\hgbuilds\viewer-autobuildvs8\indra\newview\res\viewerRes.rc 10 Error 9 error PRJ0019: A tool returned an error code from "Generating RelWithDebInfo/touched.bat" package From: twisted_laws at hotmail.com To: oz at lindenlab.com; opensource-dev at lists.secondlife.com Date: Sun, 6 Feb 2011 12:56:55 -0500 Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. Ok, i'm an idiot and can't follow instructions.... So i reread Oz's msg and found i was using the wrong config and redid it with autobuild configure -c VCexpressRelWithDebInfo Then that part worked ok. If i then just used "autobuild build" it had the same fmod error as before. So i tried autobuild build -c VCexpressRelWithDebInfo --verbose and things went further but as someone else reported then i got 100's of errors about winsock2.h not being found. Why does it continue to try to build everything after it gets so many errors? Build complete: 12 Projects succeeded, 113 Projects failed, 2 Projects skipped _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110206/2151d667/attachment.htm From ima.mechanique at blueyonder.co.uk Sun Feb 6 11:15:31 2011 From: ima.mechanique at blueyonder.co.uk (Ima Mechanique) Date: Sun, 06 Feb 2011 19:15:31 GMT Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. In-Reply-To: <20110206170522.E0C9.5FD3A259@blueyonder.co.uk> References: <4D4EC104.1030901@lindenlab.com> <20110206170522.E0C9.5FD3A259@blueyonder.co.uk> Message-ID: <20110206190745.E0CB.5FD3A259@blueyonder.co.uk> > I'm getting dozens of these errors > > fatal error C1083: Cannot open include file: 'winsock2.h': No such file or directory > > and > > fatal error C1083: Cannot open include file: 'windows.h': No such file or directory > > Seems that it is not using the Include directories list. Just to clarify. These errors are only generated when using "autobuild build -c VCexpressRelWithDebInfo" If using the MSVC Express gui it builds with only the usual niggles (like failing on x64 because it can't find a directory) -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk From nickyperian at yahoo.com Sun Feb 6 11:17:14 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Sun, 6 Feb 2011 11:17:14 -0800 (PST) Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. In-Reply-To: References: <20110205112524.25592.52183@domU-12-31-38-00-90-68.compute-1.internal>, , , , , <20110206045050.28753.91585@domU-12-31-38-00-90-68.compute-1.internal>, , , , , <4D4EAD12.8070801@lindenlab.com>, , <4D4EC104.1030901@lindenlab.com>, , , , , , Message-ID: <690887.33874.qm@web43506.mail.sp1.yahoo.com> Later today Ill bring up in IDE and see it the same errors arise. idk what is happening but if 2 that we know have them of then we need to try and correct. ________________________________ From: Twisted Laws To: Oz Linden ; SLDEV Sent: Sun, February 6, 2011 1:07:27 PM Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. Ok, i found i can get much further compiling in the IDE and this is all i end up with now. Note that the issue with winres.h is one i always have had with and easy change of defining IDC_STATIC and including winresrc.h instead. Twisted Warning 1 warning LNK4099: PDB 'vc80.pdb' was not found with '..\packages\lib\release\exception_handler.lib' or at 'C:\dev\hgbuilds\viewer-autobuildvs8\build-vc80\sharedlibs\RelWithDebInfo\vc80.pdb'; linking object as if no debug info exception_handler.lib Warning 2 warning LNK4099: PDB 'vc80.pdb' was not found with '..\packages\lib\release\crash_generation_client.lib' or at 'C:\dev\hgbuilds\viewer-autobuildvs8\build-vc80\sharedlibs\RelWithDebInfo\vc80.pdb'; linking object as if no debug info crash_generation_client.lib Warning 3 warning LNK4099: PDB 'vc80.pdb' was not found with '..\packages\lib\release\common.lib' or at 'C:\dev\hgbuilds\viewer-autobuildvs8\build-vc80\sharedlibs\RelWithDebInfo\vc80.pdb'; linking object as if no debug info common.lib Error 4 error PRJ0019: A tool returned an error code from "Generating PROJECT_llmessage_TEST_lltemplatemessagedispatcher_ok.txt" llmessage_tests Error 5 error PRJ0019: A tool returned an error code from "Generating PROJECT_llupdaterservice_TEST_llupdaterservice_ok.txt" llupdaterservice_tests Error 6 error PRJ0019: A tool returned an error code from "Performing viewer_manifest copy" copy_w_viewer_manifest Warning 7 warning LNK4221: no public symbols found; archive member will be inaccessible llfunctorregistry.obj Error 8 fatal error RC1015: cannot open include file 'winres.h'. c:\dev\hgbuilds\viewer-autobuildvs8\indra\newview\res\viewerRes.rc 10 Error 9 error PRJ0019: A tool returned an error code from "Generating RelWithDebInfo/touched.bat" package ________________________________ From: twisted_laws at hotmail.com To: oz at lindenlab.com; opensource-dev at lists.secondlife.com Date: Sun, 6 Feb 2011 12:56:55 -0500 Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. Ok, i'm an idiot and can't follow instructions.... So i reread Oz's msg and found i was using the wrong config and redid it with autobuild configure -c VCexpressRelWithDebInfo Then that part worked ok. If i then just used "autobuild build" it had the same fmod error as before. So i tried autobuild build -c VCexpressRelWithDebInfo --verbose and things went further but as someone else reported then i got 100's of errors about winsock2.h not being found. Why does it continue to try to build everything after it gets so many errors? Build complete: 12 Projects succeeded, 113 Projects failed, 2 Projects skipped _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110206/3d52c002/attachment-0001.htm From oz at lindenlab.com Sun Feb 6 11:29:46 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Sun, 06 Feb 2011 14:29:46 -0500 Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. In-Reply-To: <4D4EC104.1030901@lindenlab.com> References: <20110205112524.25592.52183@domU-12-31-38-00-90-68.compute-1.internal> <20110206045050.28753.91585@domU-12-31-38-00-90-68.compute-1.internal> <4D4EAD12.8070801@lindenlab.com> <4D4EC104.1030901@lindenlab.com> Message-ID: <4D4EF6AA.3090908@lindenlab.com> On 2011-02-06 10:40, Oz Linden (Scott Lawrence) wrote: > On 2011-02-06 9:15, Oz Linden (Scott Lawrence) wrote: >> I've created a repo sync'ed up to the latest viewer-development, and >> with this workaround (I renamed the configuration >> VCexpressRelWithDebInfo to make it stand out a bit more). If folks >> with VS Express (2005) could please test it : >> >> https://bitbucket.org/oz_linden/viewer-autobuildvs8 >> >> I'm running a test in TeamCity now to make sure that it does not >> bother the production builds. That test appears to be a pass.... > Please test (or retest, as the case may be) using the above repo at > changeset 21ef0a07c2cd or later... To recap, our goal is to make it possible to build (albeit without FMOD - that's a separate issue) with just two commands in a command (not cygwin) shell: autobuild configure -c VCexpressRelWithDebInfo autobuild build -c VCexpressRelWithDebInfo you _do_ need to respecify the configuration argument for the build command (this is the way autobuild is expected to work, at least for now). -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110206/8610d25b/attachment.htm From nickyperian at yahoo.com Sun Feb 6 11:53:17 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Sun, 6 Feb 2011 11:53:17 -0800 (PST) Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. In-Reply-To: <20110206190745.E0CB.5FD3A259@blueyonder.co.uk> References: <4D4EC104.1030901@lindenlab.com> <20110206170522.E0C9.5FD3A259@blueyonder.co.uk> <20110206190745.E0CB.5FD3A259@blueyonder.co.uk> Message-ID: <775132.63187.qm@web43505.mail.sp1.yahoo.com> What is your windows OS? I may be able to Vbox/VM it to test. ________________________________ From: Ima Mechanique To: opensource-dev at lists.secondlife.com Sent: Sun, February 6, 2011 1:15:31 PM Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. > I'm getting dozens of these errors > > fatal error C1083: Cannot open include file: 'winsock2.h': No such file or >directory > > and > > fatal error C1083: Cannot open include file: 'windows.h': No such file or >directory > > Seems that it is not using the Include directories list. Just to clarify. These errors are only generated when using "autobuild build -c VCexpressRelWithDebInfo" If using the MSVC Express gui it builds with only the usual niggles (like failing on x64 because it can't find a directory) -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110206/1f985abf/attachment.htm From ima.mechanique at blueyonder.co.uk Sun Feb 6 12:23:41 2011 From: ima.mechanique at blueyonder.co.uk (Ima Mechanique) Date: Sun, 06 Feb 2011 20:23:41 GMT Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. In-Reply-To: <775132.63187.qm@web43505.mail.sp1.yahoo.com> References: <20110206190745.E0CB.5FD3A259@blueyonder.co.uk> <775132.63187.qm@web43505.mail.sp1.yahoo.com> Message-ID: <20110206201528.E0CF.5FD3A259@blueyonder.co.uk> > What is your windows OS? I may be able to Vbox/VM it to test. WinXP 64 bit. The following altered function from indra\lib\python\indra\util\test_win32_manifest.py fixes the issues for me. def find_vc_dir(): supported_versions = (r'8.0', r'9.0') supported_products = (r'VisualStudio', r'VCExpress') value_str = (r'ProductDir') for product in supported_products: for version in supported_versions: key_str = (r'SOFTWARE\Microsoft\%s\%s\Setup\VC' % (product, version)) try: return get_HKLM_registry_value(key_str, value_str) except WindowsError, err: if product == "VisualStudio": reg_key = "VS" elif product == "VCExpress": reg_key = "VC" else: raise Exception("Unknown package!") x64_key_str = (r'SOFTWARE\Wow6432Node\Microsoft\%s\%s\Setup\%s' % (product, version, reg_key)) try: return get_HKLM_registry_value(x64_key_str, value_str) except: print >> sys.stderr, "Didn't find MS %s version %s " % (product,version) raise > ________________________________ > From: Ima Mechanique > To: opensource-dev at lists.secondlife.com > Sent: Sun, February 6, 2011 1:15:31 PM > Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under > Visual Studio 2005 Express Edition. > > > I'm getting dozens of these errors > > > > fatal error C1083: Cannot open include file: 'winsock2.h': No such file or > >directory > > > > and > > > > fatal error C1083: Cannot open include file: 'windows.h': No such file or > >directory > > > > Seems that it is not using the Include directories list. > > Just to clarify. These errors are only generated when using "autobuild > build -c VCexpressRelWithDebInfo" If using the MSVC Express gui it > builds with only the usual niggles (like failing on x64 because it can't > find a directory) > > > -- > Ima Mechanique > ima.mechanique(at)blueyonder.co.uk > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges > > > > -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk From oz at lindenlab.com Sun Feb 6 12:58:25 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Sun, 06 Feb 2011 15:58:25 -0500 Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. In-Reply-To: <20110206190745.E0CB.5FD3A259@blueyonder.co.uk> References: <4D4EC104.1030901@lindenlab.com> <20110206170522.E0C9.5FD3A259@blueyonder.co.uk> <20110206190745.E0CB.5FD3A259@blueyonder.co.uk> Message-ID: <4D4F0B71.6000305@lindenlab.com> On 2011-02-06 14:15, Ima Mechanique wrote: > Just to clarify. These errors are only generated when using "autobuild > build -c VCexpressRelWithDebInfo" If using the MSVC Express gui it > builds with only the usual niggles (like failing on x64 because it can't > find a directory) Can you tell what is being done differently? Perhaps from the gui it's not building the same set of targets? From twisted_laws at hotmail.com Sun Feb 6 13:05:25 2011 From: twisted_laws at hotmail.com (Twisted Laws) Date: Sun, 6 Feb 2011 16:05:25 -0500 Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. In-Reply-To: <20110206201528.E0CF.5FD3A259@blueyonder.co.uk> References: <20110206190745.E0CB.5FD3A259@blueyonder.co.uk>, <775132.63187.qm@web43505.mail.sp1.yahoo.com>, <20110206201528.E0CF.5FD3A259@blueyonder.co.uk> Message-ID: I tried making these changes... it did not do anything different or help me in my situation of not finding the windows.h and winsock2.h. I'd start over and rebuild the dev environment but its not a good option for me at this time. > Date: Sun, 6 Feb 2011 20:23:41 +0000 > From: ima.mechanique at blueyonder.co.uk > To: opensource-dev at lists.secondlife.com > Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. > > > What is your windows OS? I may be able to Vbox/VM it to test. > > WinXP 64 bit. > > The following altered function from indra\lib\python\indra\util\test_win32_manifest.py > fixes the issues for me. > > def find_vc_dir(): > supported_versions = (r'8.0', r'9.0') > supported_products = (r'VisualStudio', r'VCExpress') > value_str = (r'ProductDir') > > for product in supported_products: > for version in supported_versions: > key_str = (r'SOFTWARE\Microsoft\%s\%s\Setup\VC' % > (product, version)) > try: > return get_HKLM_registry_value(key_str, value_str) > except WindowsError, err: > if product == "VisualStudio": > reg_key = "VS" > elif product == "VCExpress": > reg_key = "VC" > else: > raise Exception("Unknown package!") > > x64_key_str = (r'SOFTWARE\Wow6432Node\Microsoft\%s\%s\Setup\%s' % > (product, version, reg_key)) > > try: > return get_HKLM_registry_value(x64_key_str, value_str) > except: > print >> sys.stderr, "Didn't find MS %s version %s " % (product,version) > > raise > > > > ________________________________ > > From: Ima Mechanique > > To: opensource-dev at lists.secondlife.com > > Sent: Sun, February 6, 2011 1:15:31 PM > > Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under > > Visual Studio 2005 Express Edition. > > > > > I'm getting dozens of these errors > > > > > > fatal error C1083: Cannot open include file: 'winsock2.h': No such file or > > >directory > > > > > > and > > > > > > fatal error C1083: Cannot open include file: 'windows.h': No such file or > > >directory > > > > > > Seems that it is not using the Include directories list. > > > > Just to clarify. These errors are only generated when using "autobuild > > build -c VCexpressRelWithDebInfo" If using the MSVC Express gui it > > builds with only the usual niggles (like failing on x64 because it can't > > find a directory) > > > > > > -- > > Ima Mechanique > > ima.mechanique(at)blueyonder.co.uk > > > > > > _______________________________________________ > > Policies and (un)subscribe information available here: > > http://wiki.secondlife.com/wiki/OpenSource-Dev > > Please read the policies before posting to keep unmoderated posting privileges > > > > > > > > > > -- > Ima Mechanique > ima.mechanique(at)blueyonder.co.uk > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110206/9ff83aaf/attachment.htm From ima.mechanique at blueyonder.co.uk Sun Feb 6 13:26:42 2011 From: ima.mechanique at blueyonder.co.uk (Ima Mechanique) Date: Sun, 06 Feb 2011 21:26:42 GMT Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. In-Reply-To: References: <20110206201528.E0CF.5FD3A259@blueyonder.co.uk> Message-ID: <20110206212355.E0D3.5FD3A259@blueyonder.co.uk> > > I tried making these changes... it did not do anything different or help me in my situation of not finding the windows.h and winsock2.h. That change is only for Win XP x64 environment, to allow the build process to identify the VC Express install directory. Otherwise build fails. It has nothing to do with the winsock2.h and windows.h problem, which I'm looking into now in response to Oz's mail. > I'd start over and rebuild the dev environment but its not a good option for me at this time. > > > Date: Sun, 6 Feb 2011 20:23:41 +0000 > > From: ima.mechanique at blueyonder.co.uk > > To: opensource-dev at lists.secondlife.com > > Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. > > > > > What is your windows OS? I may be able to Vbox/VM it to test. > > > > WinXP 64 bit. > > > > The following altered function from indra\lib\python\indra\util\test_win32_manifest.py > > fixes the issues for me. > > > > def find_vc_dir(): > > supported_versions = (r'8.0', r'9.0') > > supported_products = (r'VisualStudio', r'VCExpress') > > value_str = (r'ProductDir') > > > > for product in supported_products: > > for version in supported_versions: > > key_str = (r'SOFTWARE\Microsoft\%s\%s\Setup\VC' % > > (product, version)) > > try: > > return get_HKLM_registry_value(key_str, value_str) > > except WindowsError, err: > > if product == "VisualStudio": > > reg_key = "VS" > > elif product == "VCExpress": > > reg_key = "VC" > > else: > > raise Exception("Unknown package!") > > > > x64_key_str = (r'SOFTWARE\Wow6432Node\Microsoft\%s\%s\Setup\%s' % > > (product, version, reg_key)) > > > > try: > > return get_HKLM_registry_value(x64_key_str, value_str) > > except: > > print >> sys.stderr, "Didn't find MS %s version %s " % (product,version) > > > > raise > > > > > > > ________________________________ > > > From: Ima Mechanique > > > To: opensource-dev at lists.secondlife.com > > > Sent: Sun, February 6, 2011 1:15:31 PM > > > Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under > > > Visual Studio 2005 Express Edition. > > > > > > > I'm getting dozens of these errors > > > > > > > > fatal error C1083: Cannot open include file: 'winsock2.h': No such file or > > > >directory > > > > > > > > and > > > > > > > > fatal error C1083: Cannot open include file: 'windows.h': No such file or > > > >directory > > > > > > > > Seems that it is not using the Include directories list. > > > > > > Just to clarify. These errors are only generated when using "autobuild > > > build -c VCexpressRelWithDebInfo" If using the MSVC Express gui it > > > builds with only the usual niggles (like failing on x64 because it can't > > > find a directory) > > > > > > > > > -- > > > Ima Mechanique > > > ima.mechanique(at)blueyonder.co.uk > > > > > > > > > _______________________________________________ > > > Policies and (un)subscribe information available here: > > > http://wiki.secondlife.com/wiki/OpenSource-Dev > > > Please read the policies before posting to keep unmoderated posting privileges > > > > > > > > > > > > > > > > -- > > Ima Mechanique > > ima.mechanique(at)blueyonder.co.uk > > > > > > _______________________________________________ > > Policies and (un)subscribe information available here: > > http://wiki.secondlife.com/wiki/OpenSource-Dev > > Please read the policies before posting to keep unmoderated posting privileges > -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk From ima.mechanique at blueyonder.co.uk Sun Feb 6 13:34:41 2011 From: ima.mechanique at blueyonder.co.uk (Ima Mechanique) Date: Sun, 06 Feb 2011 21:34:41 GMT Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. In-Reply-To: <4D4F0B71.6000305@lindenlab.com> References: <20110206190745.E0CB.5FD3A259@blueyonder.co.uk> <4D4F0B71.6000305@lindenlab.com> Message-ID: <20110206210528.E0D1.5FD3A259@blueyonder.co.uk> > On 2011-02-06 14:15, Ima Mechanique wrote: > > Just to clarify. These errors are only generated when using "autobuild > > build -c VCexpressRelWithDebInfo" If using the MSVC Express gui it > > builds with only the usual niggles (like failing on x64 because it can't > > find a directory) > > Can you tell what is being done differently? Not really. Looking at the build logs, apart from the lack of cmake command and some packages missing (like fmod), they look pretty much the same. > Perhaps from the gui it's not building the same set of targets? My suspicion, is that the GUI is using its Include files directory list and the command line is not. The INCLUDE env variable only contains "C:\Program Files (x86)\Microsoft\Visual Studio\8\VC\INCLUDE;" instead of the dozen or more in the GUI list. However manually adding the two SDK include directories where the files exist doesn't help (and the lack doesn't harm the standard v-d build). > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk From nickyperian at yahoo.com Sun Feb 6 14:03:19 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Sun, 6 Feb 2011 14:03:19 -0800 (PST) Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. In-Reply-To: <20110206210528.E0D1.5FD3A259@blueyonder.co.uk> References: <20110206190745.E0CB.5FD3A259@blueyonder.co.uk> <4D4F0B71.6000305@lindenlab.com> <20110206210528.E0D1.5FD3A259@blueyonder.co.uk> Message-ID: <449715.46052.qm@web43505.mail.sp1.yahoo.com> I remembered reading about some issues (don't ask me to expand) of not having the latest SDK's when using win64. I have both express and pro on my machine and my include settings for Pro reflect newer SDK's. Maybe you can try these includes. http://picpaste.com/vs2005proIncludes-2Fa11vp6.PNG ________________________________ From: Ima Mechanique To: opensource-dev at lists.secondlife.com Sent: Sun, February 6, 2011 3:34:41 PM Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. > On 2011-02-06 14:15, Ima Mechanique wrote: > > Just to clarify. These errors are only generated when using "autobuild > > build -c VCexpressRelWithDebInfo" If using the MSVC Express gui it > > builds with only the usual niggles (like failing on x64 because it can't > > find a directory) > > Can you tell what is being done differently? Not really. Looking at the build logs, apart from the lack of cmake command and some packages missing (like fmod), they look pretty much the same. > Perhaps from the gui it's not building the same set of targets? My suspicion, is that the GUI is using its Include files directory list and the command line is not. The INCLUDE env variable only contains "C:\Program Files (x86)\Microsoft\Visual Studio\8\VC\INCLUDE;" instead of the dozen or more in the GUI list. However manually adding the two SDK include directories where the files exist doesn't help (and the lack doesn't harm the standard v-d build). > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110206/99f104c4/attachment-0001.htm From ima.mechanique at blueyonder.co.uk Sun Feb 6 14:14:41 2011 From: ima.mechanique at blueyonder.co.uk (Ima Mechanique) Date: Sun, 06 Feb 2011 22:14:41 GMT Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. In-Reply-To: <449715.46052.qm@web43505.mail.sp1.yahoo.com> References: <20110206210528.E0D1.5FD3A259@blueyonder.co.uk> <449715.46052.qm@web43505.mail.sp1.yahoo.com> Message-ID: <20110206220751.E0D5.5FD3A259@blueyonder.co.uk> > I remembered reading about some issues (don't ask me to expand) of not having > the latest SDK's when using win64. I have both express and pro on my machine and > my include settings for Pro reflect newer SDK's. > Maybe you can try these includes. > > http://picpaste.com/vs2005proIncludes-2Fa11vp6.PNG I have all those directories (and more, see https://wiki.secondlife.com/wiki/Viewer_2_Microsoft_Windows_Builds for complete list). I don't think the contents here are the issue. After all, those includes work for the GUI, for some reason the CLI is not getting them would seem more likely to me. > ________________________________ > From: Ima Mechanique > To: opensource-dev at lists.secondlife.com > Sent: Sun, February 6, 2011 3:34:41 PM > Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under > Visual Studio 2005 Express Edition. > > > On 2011-02-06 14:15, Ima Mechanique wrote: > > > Just to clarify. These errors are only generated when using "autobuild > > > build -c VCexpressRelWithDebInfo" If using the MSVC Express gui it > > > builds with only the usual niggles (like failing on x64 because it can't > > > find a directory) > > > > Can you tell what is being done differently? > > Not really. Looking at the build logs, apart from the lack of cmake > command and some packages missing (like fmod), they look pretty much the > same. > > > Perhaps from the gui it's not building the same set of targets? > > My suspicion, is that the GUI is using its Include files directory list > and the command line is not. The INCLUDE env variable only contains > "C:\Program Files (x86)\Microsoft\Visual Studio\8\VC\INCLUDE;" instead > of the dozen or more in the GUI list. However manually adding the two > SDK include directories where the files exist doesn't help (and the lack > doesn't harm the standard v-d build). > > > _______________________________________________ > > Policies and (un)subscribe information available here: > > http://wiki.secondlife.com/wiki/OpenSource-Dev > > Please read the policies before posting to keep unmoderated posting privileges > > -- > Ima Mechanique > ima.mechanique(at)blueyonder.co.uk > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges > > > > -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk From oz at lindenlab.com Sun Feb 6 17:39:22 2011 From: oz at lindenlab.com (Oz Linden) Date: Mon, 07 Feb 2011 01:39:22 -0000 Subject: [opensource-dev] Review Request: OPEN-7: allow specification of the config-file with env var AUTOBUILD_CONFIG_FILE Message-ID: <20110207013922.29474.12564@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/140/ ----------------------------------------------------------- Review request for Viewer. Summary ------- This change allows the environment variable AUTOBUILD_CONFIG_FILE to specify a default config-file, so that the precedence becomes: 1. the --config-file command line option 2. the environment variable AUTOBUILD_CONFIG_FILE 3. "autobuild.xml" It also adds an info-level (--verbose) display of the config file name that is being loaded, and a warning level display if the config file does not exist. This addresses bug open-7. Diffs ----- autobuild/autobuild_tool_build.py 9ee2db08d677 autobuild/autobuild_tool_configure.py 9ee2db08d677 autobuild/autobuild_tool_edit.py 9ee2db08d677 autobuild/autobuild_tool_install.py 9ee2db08d677 autobuild/autobuild_tool_installables.py 9ee2db08d677 autobuild/autobuild_tool_manifest.py 9ee2db08d677 autobuild/autobuild_tool_package.py 9ee2db08d677 autobuild/autobuild_tool_print.py 9ee2db08d677 autobuild/autobuild_tool_uninstall.py 9ee2db08d677 autobuild/configfile.py 9ee2db08d677 Diff: http://codereview.secondlife.com/r/140/diff Testing ------- Manually tested with and without the command line option, and with and without the environment variable set: confirmed that the correct file name is used per the precedence above. Confirmed that the new logging works correctly. Thanks, Oz -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110207/7f27e862/attachment.htm From nickyperian at yahoo.com Sun Feb 6 18:55:34 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Sun, 6 Feb 2011 18:55:34 -0800 (PST) Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. In-Reply-To: References: <20110206190745.E0CB.5FD3A259@blueyonder.co.uk>, <775132.63187.qm@web43505.mail.sp1.yahoo.com>, <20110206201528.E0CF.5FD3A259@blueyonder.co.uk> Message-ID: <494842.6223.qm@web43506.mail.sp1.yahoo.com> Help->About VC++2005 Express Edition->Copy Info-->Paste from Clipboard yeilds-->>>> Microsoft Visual Studio 2005 Version 8.0.50727.867 (vsvista.050727-8600) Microsoft .NET Framework Version 2.0.50727 SP2 Installed Edition: VC Express Microsoft Visual C++ 2005 76542-000-0000011-00125 Microsoft Visual C++ 2005 ********************************************************************** Invoke Terminal and execute->> "C:\Program Files\Microsoft Visual Studio 8\Common7\Tools\vsvars32.bat" Yeilds>>>> Setting environment for using Microsoft Visual Studio 2005 x86 tools. C:\> Early on I had a problem where vcvars32.bat did not execute properly when invoked from within Express. I had to drill down through All Programs and invoke from within Visual Studio Tools. You should have "Setting environment for using Microsoft Visual Studio 2005 x86 tools." without any errors before using the terminal. Anyway a couple things to check. I have tried unsucessfully to force a repo of failed includes. ________________________________ From: Twisted Laws To: SLDEV Sent: Sun, February 6, 2011 3:05:25 PM Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. I tried making these changes... it did not do anything different or help me in my situation of not finding the windows.h and winsock2.h. I'd start over and rebuild the dev environment but its not a good option for me at this time. > Date: Sun, 6 Feb 2011 20:23:41 +0000 > From: ima.mechanique at blueyonder.co.uk > To: opensource-dev at lists.secondlife.com > Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under >Visual Studio 2005 Express Edition. > > > What is your windows OS? I may be able to Vbox/VM it to test. > > WinXP 64 bit. > > The following altered function from >indra\lib\python\indra\util\test_win32_manifest.py > fixes the issues for me. > > def find_vc_dir(): > supported_versions = (r'8.0', r'9.0') > supported_products = (r'VisualStudio', r'VCExpress') > value_str = (r'ProductDir') > > for product in supported_products: > for version in supported_versions: > key_str = (r'SOFTWARE\Microsoft\%s\%s\Setup\VC' % > (product, version)) > try: > return get_HKLM_registry_value(key_str, value_str) > except WindowsError, err: > if product == "VisualStudio": > reg_key = "VS" > elif product == "VCExpress": > reg_key = "VC" > else: > raise Exception("Unknown package!") > > x64_key_str = (r'SOFTWARE\Wow6432Node\Microsoft\%s\%s\Setup\%s' % > (product, version, reg_key)) > > try: > return get_HKLM_registry_value(x64_key_str, value_str) > except: > print >> sys.stderr, "Didn't find MS %s version %s " % (product,version) > > raise > > > > ________________________________ > > From: Ima Mechanique > > To: opensource-dev at lists.secondlife.com > > Sent: Sun, February 6, 2011 1:15:31 PM > > Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work >under > > > Visual Studio 2005 Express Edition. > > > > > I'm getting dozens of these errors > > > > > > fatal error C1083: Cannot open include file: 'winsock2.h': No such file or > > >directory > > > > > > and > > > > > > fatal error C1083: Cannot open include file: 'windows.h': No such file or > > >directory > > > > > > Seems that it is not using the Include directories list. > > > > Just to clarify. These errors are only generated when using "autobuild > > build -c VCexpressRelWithDebInfo" If using the MSVC Express gui it > > builds with only the usual niggles (like failing on x64 because it can't > > find a directory) > > > > > > -- > > Ima Mechanique > > ima.mechanique(at)blueyonder.co.uk > > > > > > _______________________________________________ > > Policies and (un)subscribe information available here: > > http://wiki.secondlife.com/wiki/OpenSource-Dev > > Please read the policies before posting to keep unmoderated posting >privileges > > > > > > > > > > -- > Ima Mechanique > ima.mechanique(at)blueyonder.co.uk > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110206/60c8afa2/attachment.htm From twisted_laws at hotmail.com Sun Feb 6 19:16:39 2011 From: twisted_laws at hotmail.com (Twisted Laws) Date: Sun, 6 Feb 2011 22:16:39 -0500 Subject: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. In-Reply-To: <494842.6223.qm@web43506.mail.sp1.yahoo.com> References: <20110206190745.E0CB.5FD3A259@blueyonder.co.uk>, <775132.63187.qm@web43505.mail.sp1.yahoo.com>, <20110206201528.E0CF.5FD3A259@blueyonder.co.uk> , <494842.6223.qm@web43506.mail.sp1.yahoo.com> Message-ID: I'm sort of lost here, sorry :( I did try a lot of different things (except i didn't look in the python files as i'm not sure what i'd be looking at). our versions seem to match exactly Microsoft Visual Studio 2005 Version 8.0.50727.867 (vsvista.050727-8600) Microsoft .NET Framework Version 2.0.50727 SP2 Installed Edition: VC Express Microsoft Visual C++ 2005 76542-000-0000011-00125 Microsoft Visual C++ 2005 all my tests after you pointed out running from a vc2005 cmd window have that Setting environment for using Microsoft Visual Studio 2005 x86 tools. C:\Program Files (x86)\Microsoft Visual Studio 8\Common7\IDE> i also modified my vcvars32.bat file to include @set INCLUDE=C:\Program Files (x86)\Microsoft Visual Studio 8\VC\INCLUDE;%INCLUDE% @set INCLUDE=C:\Program Files\Microsoft SDKs\Windows\v6.1\Include;%INCLUDE% @set INCLUDE=C:\Program Files\Microsoft SDKs\Windows\v6.1\Include\gl;%INCLUDE% @set INCLUDE=C:\Program Files (x86)\Microsoft DirectX SDK (August 2008)\Include;%INCLUDE% didn't change anything for me :( Date: Sun, 6 Feb 2011 18:55:34 -0800 From: nickyperian at yahoo.com Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. To: twisted_laws at hotmail.com; opensource-dev at lists.secondlife.com; ima.mechanique at blueyonder.co.uk Help->About VC++2005 Express Edition->Copy Info-->Paste from Clipboard yeilds-->>>> Microsoft Visual Studio 2005 Version 8.0.50727.867 (vsvista.050727-8600) Microsoft .NET Framework Version 2.0.50727 SP2 Installed Edition: VC Express Microsoft Visual C++ 2005 76542-000-0000011-00125 Microsoft Visual C++ 2005 ********************************************************************** Invoke Terminal and execute->> "C:\Program Files\Microsoft Visual Studio 8\Common7\Tools\vsvars32.bat" Yeilds>>>> Setting environment for using Microsoft Visual Studio 2005 x86 tools. C:\> Early on I had a problem where vcvars32.bat did not execute properly when invoked from within Express. I had to drill down through All Programs and invoke from within Visual Studio Tools. You should have "Setting environment for using Microsoft Visual Studio 2005 x86 tools." without any errors before using the terminal. Anyway a couple things to check. I have tried unsucessfully to force a repo of failed includes. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110206/dace2bfc/attachment-0001.htm From oz at lindenlab.com Sun Feb 6 20:01:57 2011 From: oz at lindenlab.com (Oz Linden) Date: Mon, 07 Feb 2011 04:01:57 -0000 Subject: [opensource-dev] Review Request: OPEN-8: allow specification of the configuration with env var AUTOBUILD_CONFIGURATION Message-ID: <20110207040157.29444.20926@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/141/ ----------------------------------------------------------- Review request for Viewer. Summary ------- This patch adds support for specifying the configurations using the AUTOBUILD_CONFIGURATION environment variable (multiple configurations can be specified using commas to separate the values). This addresses bug open-8. Diffs ----- autobuild/autobuild_base.py 9ee2db08d677 autobuild/autobuild_tool_build.py 9ee2db08d677 autobuild/autobuild_tool_configure.py 9ee2db08d677 Diff: http://codereview.secondlife.com/r/141/diff Testing ------- Tested manually with and without the command line argument, and with and without the environment variable set; the appropriate configuration values were used. Thanks, Oz -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110207/df39d79a/attachment.htm From jhwelch at gmail.com Mon Feb 7 11:33:27 2011 From: jhwelch at gmail.com (Jonathan Welch) Date: Mon, 7 Feb 2011 14:33:27 -0500 Subject: [opensource-dev] Need help reproducing bug report Message-ID: Hi, If you are using a 2.5 or a nightly build viewer could you try to reproduce this for me? https://jira.secondlife.com/browse/STORM-470 Context menu of the arrow on profiles/landmarks goes far away when clicked. I am doing a bunch of UI cleanup but can't get this to happen (and even if I could, have no idea how to fix it). Thank you, -Jonathan From jhwelch at gmail.com Mon Feb 7 12:04:18 2011 From: jhwelch at gmail.com (Jonathan Yap) Date: Mon, 07 Feb 2011 20:04:18 -0000 Subject: [opensource-dev] Review Request: STORM-974 UI button alignment issues in Landmark panel, About Land window, and Hardware Settings window Message-ID: <20110207200418.28828.89266@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/142/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Please see the jira for the referenced pictures. In picture #1, in the preferences > graphics > hardware settings, the line of "gamma" setting is a little too up and it collides with the "antialiasing" line. In picture #2 in the "places" tab under "my landmarks" tab the "profile" button gets cut off at the end from the rest of the sidebar's UI. There are a number of other buttons with alignment issues with no screenshot. In picture #3 in the Access tab in the About Land window, the remove buttons are off to the right a few millimetres. Changes made were to align the Hardware Settings and About Land buttons and to completely go over the buttons in the Landmarks panel. The small down-arrow at the bottom right corner was using an imbedded UTF-8 so I fixed that and also made it point up while the menu is open (there is a separate jira for reversing the direction it points in these two states). This patch really needs a test viewer built to make sure all works and that nothing was missed in the Landmarks panel. There are 3 other related jiras that I hope are taken in; a test viewer could be made incorporating all 4 jiras at that point. This addresses bug STORM-974. http://jira.secondlife.com/browse/STORM-974 Diffs ----- indra/newview/skins/default/xui/en/floater_about_land.xml b0bceb572090 indra/newview/skins/default/xui/en/floater_hardware_settings.xml b0bceb572090 indra/newview/skins/default/xui/en/panel_edit_pick.xml b0bceb572090 indra/newview/skins/default/xui/en/panel_places.xml b0bceb572090 Diff: http://codereview.secondlife.com/r/142/diff Testing ------- Thanks, Jonathan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110207/fe135eee/attachment.htm From sllists at boroon.dasgupta.ch Mon Feb 7 12:39:22 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Mon, 07 Feb 2011 20:39:22 -0000 Subject: [opensource-dev] Review Request: VWR-24520: Don't use pkg_check_modules( ... QUIET ) on CMake < 2.8.2 In-Reply-To: <20110121073348.26108.35604@domU-12-31-38-00-90-68.compute-1.internal> References: <20110121073348.26108.35604@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110207203922.28754.3023@domU-12-31-38-00-90-68.compute-1.internal> > On Jan. 20, 2011, 11:33 p.m., Merov Linden wrote: > > I'm advising the MM to merge in a test repo and do a full TC cycle on all platforms before merging though... > > Boroondas Gupte wrote: > As far as I can see indra/cmake/FindLLQtWebkit.cmake only gets called by indra/cmake/WebKitLibPlugin.cmake (through find_package(LLQtWebkit REQUIRED QUIET)), and there the call only happens for STANDALONE. So I would be very surprised if this affects TC builds. Any results from that TC cycle? - Boroondas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/97/#review227 ----------------------------------------------------------- On Jan. 17, 2011, 10:03 a.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/97/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2011, 10:03 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Only use QUIET in pkg_check_modules() on CMake >=2.8.2 (where it's supported) rather than already on CMake >=2.8. > > > This addresses bug VWR-24520. > http://jira.secondlife.com/browse/VWR-24520 > > > Diffs > ----- > > doc/contributions.txt 9e99b2c8fb28 > indra/cmake/FindLLQtWebkit.cmake 9e99b2c8fb28 > > Diff: http://codereview.secondlife.com/r/97/diff > > > Testing > ------- > > Configured (standalone) without a .pgk file for libllqtwebkit on Linux with CMake 2.8.1 and CMake 2.8.3. Output as expected. > > Not tested: > * CMake 2.8.2 > * system with a .pgk file for libllqtwebkit > * non-standalone > * Mac, Win > > > Thanks, > > Boroondas > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110207/7c147886/attachment.htm From merov at lindenlab.com Mon Feb 7 13:49:29 2011 From: merov at lindenlab.com (Philippe (Merov) Bossut) Date: Mon, 7 Feb 2011 13:49:29 -0800 Subject: [opensource-dev] Mesh Import Project Viewer In-Reply-To: <772926FA276744C5927599AB12B53344@MINIRECHNER> References: <772926FA276744C5927599AB12B53344@MINIRECHNER> Message-ID: Hi Diabolus, The dialog only says that "The Application cannot be launched" which is not much to draw any conclusion. Also, I need to confess I haven't tried the mesh viewer yet but I know that other opensource-dev folks have so I'm forwarding there hoping that someone will have experienced the problem and already found a work around. Can someone help out Diabolus? Cheers, - Merov On Sat, Feb 5, 2011 at 11:01 AM, wrote: > Hello Merov! > > First, sorry for my bad english ... I am german ;-) > > I am sculpter and work about long time with Blender and other Programms > have built in sl lot sculpts und like to test the Import auf Collada Object > in the Beta Grid. I have installed today again the Mesh Import Project > Viewer but like in the past I can?t start that viewer ( see the screenshot > please) > > Maybe I make something wrong. I will by happy if you can help me and also I > like to help you if needed :) > > herzliche Gr??e > > Diabolus Svenska > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110207/be7a80fc/attachment.htm From jhwelch at gmail.com Mon Feb 7 13:58:32 2011 From: jhwelch at gmail.com (Jonathan Welch) Date: Mon, 7 Feb 2011 16:58:32 -0500 Subject: [opensource-dev] Mesh Import Project Viewer In-Reply-To: References: <772926FA276744C5927599AB12B53344@MINIRECHNER> Message-ID: This sounds like a classic example of not having the msvc*.dll files (Windows) installed. I am surprized that an official viewer would have this issue though. Can you search where you installed the viewer to see if they are there? Maybe someone else will give some advice about this, too. -Jonathan From sllists at boroon.dasgupta.ch Mon Feb 7 14:45:59 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Mon, 07 Feb 2011 23:45:59 +0100 Subject: [opensource-dev] autobuild on Linux 64-bit standalone: setup & configuring issues (was: Using 'autobuild' to build the viewer) In-Reply-To: <4D4202BF.6080401@lindenlab.com> References: <4D4202BF.6080401@lindenlab.com> Message-ID: <4D507627.4010502@boroon.dasgupta.ch> Ok, I've finally taken some time to test autobuild, too. On 01/28/2011 12:41 AM, Oz Linden (Scott Lawrence) wrote: > > To begin experimenting with this new way of doing things, you'll need > to check out autobuild itself (it's written in python, and is open > source) from: > > https://bitbucket.org/lindenlab/autobuild > > You can either run it directly from the checkout, or install it as a > normal python package using the command: > > setup.py install > With the current (9ee2db08d677 ) autobuild, this command won't work on UNIX-like systems for two reasons (see OPEN-10 ). Workaround is to prepend python, i.e. call python setup.py install or, because this tries to write into system directories sudo python setup.py install > A "standalone" non-Linden developer build: > > autobuild configure -c OpenSourceStandaloneRelWithDebInfo > This won't work with the current (00453191c1b9 ) viewer-autobuild code: "standalone" has to be CamelCased, too: autobuild configure -c OpenSourceStand*A*loneRelWithDebInfo Then, I had to merge in my VWR-24520 fix or I'd hit that bug, just as I would in unmodified viewer-development. After that, configuring yields: $ autobuild configure -c OpenSourceStandAloneRelWithDebInfo -- The C compiler identification is GNU -- The CXX compiler identification is GNU -- Check for working C compiler: /usr/bin/gcc -- Check for working C compiler: /usr/bin/gcc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /usr/bin/c++ -- Check for working CXX compiler: /usr/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Using autobuild at: /usr/bin/autobuild -- checking for module 'ogg' -- found ogg, version 1.2.0 -- checking for module 'vorbis' -- found vorbis, version 1.3.1 -- checking for module 'vorbisenc' -- found vorbisenc, version 1.3.1 -- checking for module 'vorbisfile' -- found vorbisfile, version 1.3.1 -- checking for module 'openal' -- found openal, version 1.11.753 -- checking for module 'freealut' -- found freealut, version 1.1.0 -- Building with OpenAL audio support -- Found Google BreakPad: /usr/lib64/libbreakpad_client.so *CMake Error at cmake/Copy3rdPartyLibs.cmake:263 (copy_if_different): COPY_IF_DIFFERENT Macro invoked with incorrect arguments for macro named: COPY_IF_DIFFERENT Call Stack (most recent call first): llcommon/CMakeLists.txt:14 (include)* -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so - found -- Looking for gethostbyname -- Looking for gethostbyname - found -- Looking for connect -- Looking for connect - found -- Looking for remove -- Looking for remove - found -- Looking for shmat -- Looking for shmat - found -- Looking for IceConnectionNumber in ICE -- Looking for IceConnectionNumber in ICE - found -- Found X11: /usr/lib64/libX11.so -- checking for module 'freetype2' -- found freetype2, version 12.1.6 -- Looking for include files CMAKE_HAVE_PTHREAD_H -- Looking for include files CMAKE_HAVE_PTHREAD_H - found -- Looking for pthread_create in pthreads -- Looking for pthread_create in pthreads - not found -- Looking for pthread_create in pthread -- Looking for pthread_create in pthread - found -- Found Threads: TRUE -- checking for module 'atk' -- found atk, version 1.30.0 -- checking for module 'cairo' -- found cairo, version 1.8.10 -- checking for module 'gdk-2.0' -- found gdk-2.0, version 2.20.1 -- checking for module 'gdk-pixbuf-2.0' -- found gdk-pixbuf-2.0, version 2.20.1 -- checking for module 'glib-2.0' -- found glib-2.0, version 2.24.2 -- checking for module 'gmodule-2.0' -- found gmodule-2.0, version 2.24.2 -- checking for module 'gtk+-2.0' -- found gtk+-2.0, version 2.20.1 -- checking for module 'gthread-2.0' -- found gthread-2.0, version 2.24.2 -- checking for module 'libpng' -- found libpng, version 1.4.5 -- checking for module 'pango' -- found pango, version 1.28.3 -- checking for module 'pangoft2' -- found pangoft2, version 1.28.3 -- checking for module 'pangox' -- found pangox, version 1.28.3 -- checking for module 'pangoxft' -- found pangoxft, version 1.28.3 -- checking for module 'sdl' -- found sdl, version 1.2.13 -- Looking for Q_WS_X11 -- Looking for Q_WS_X11 - found -- Looking for Q_WS_WIN -- Looking for Q_WS_WIN - not found. -- Looking for Q_WS_QWS -- Looking for Q_WS_QWS - not found. -- Looking for Q_WS_MAC -- Looking for Q_WS_MAC - not found. -- Found Qt-Version 4.6.3 (using /usr/bin/qmake) -- Looking for _POSIX_TIMERS -- Looking for _POSIX_TIMERS - found -- checking for module 'libllqtwebkit' -- package 'libllqtwebkit' not found -- Found LLQTWEBKIT: /usr/lib64/libllqtwebkit.a -- checking for module 'gstreamer-0.10' -- found gstreamer-0.10, version 0.10.29 -- checking for module 'gstreamer-plugins-base-0.10' -- found gstreamer-plugins-base-0.10, version 0.10.29 -- Found PythonInterp: /usr/bin/python -- checking for module 'dbus-glib-1' -- found dbus-glib-1, version 0.88 -- Building with OpenAL audio support -- Found NDOF: Library in '/usr/lib64/libndofdev.a' and header in '/usr/include' -- Version of viewer is 2.6.0.0 -- Configuring incomplete, errors occurred! *ERROR: default configuration returned 1 For more information: try re-running your command with --verbose or --debug* (*Emphasis* by me.) Changing line 264 by placing double quotes around ${debug_src_dir} gets rid of this, but I have to wonder whether the other similar calls in that file would need the same treatment. I'll cover building in a separate mail (maybe tomorrow). Cheers, Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110207/10f2e81c/attachment-0001.htm From sllists at boroon.dasgupta.ch Mon Feb 7 15:38:32 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Mon, 07 Feb 2011 23:38:32 -0000 Subject: [opensource-dev] Review Request: make PREHASH variables char const* const In-Reply-To: <20110204023531.15713.63689@domU-12-31-38-00-90-68.compute-1.internal> References: <20110204023531.15713.63689@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110207233832.29549.89339@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 3, 2011, 6:35 p.m., Aleric Inglewood wrote: > > > > Aleric Inglewood wrote: > Can this patch please be added to viewer-development? It's getting really annoying that I have to apply patches to the soruce tree before it even can compile cleanly :(. Maybe the hack from https://bitbucket.org/mani_linden/viewer-autobuild/changeset/57d9f93978a7 could be cherry-picked into viewer-development to give some relief for the time until a decision on this more invasive fix can be made? - Boroondas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/#review321 ----------------------------------------------------------- On Jan. 22, 2011, 7:40 a.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/100/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2011, 7:40 a.m.) > > > Review request for Viewer and Seth ProductEngine. > > > Summary > ------- > > For the reason for this change, see https://jira.secondlife.com/browse/VWR-24487 and https://jira.secondlife.com/browse/VWR-24522 > > What I did: > In indra/llmessage/message_prehash.(h|cpp), I turned everything into constant pointers to constants by search/replace. Then I tried to compile and added const qualifiers in dependent code as needed to stop the compiler complaining. > > Note that comments in indra/llmessage/message_prehash.(h|cpp) say these files have been generated from the message template. Because this generation might not have been a one-off thing, I changed the generating code, too, so it won't override this change here when the generation happens the next time. However, that part of the code is not called by Viewer, although the relevant function ? dump_prehash_files() ? ends up in the Viewer binary. That function probably gets called by the simulator, when one runs the latter with -prehash. (See https://bitbucket.org/lindenlab/viewer-development/src/fc7e5dcf3059/indra/llmessage/message.cpp#cl-2532 ) > > > This addresses bug VWR-24487. > http://jira.secondlife.com/browse/VWR-24487 > > > Diffs > ----- > > doc/contributions.txt fc7e5dcf3059 > indra/llmessage/message.cpp fc7e5dcf3059 > indra/llmessage/message_prehash.h fc7e5dcf3059 > indra/llmessage/message_prehash.cpp fc7e5dcf3059 > indra/llprimitive/llprimitive.h fc7e5dcf3059 > indra/llprimitive/llprimitive.cpp fc7e5dcf3059 > indra/llprimitive/llvolumemessage.h fc7e5dcf3059 > indra/llprimitive/llvolumemessage.cpp fc7e5dcf3059 > indra/llui/tests/llurlentry_stub.cpp fc7e5dcf3059 > indra/newview/tests/llremoteparcelrequest_test.cpp fc7e5dcf3059 > > Diff: http://codereview.secondlife.com/r/100/diff > > > Testing > ------- > > Compiled (standalone, 64bit Linux) with and without LL_TESTS. > Started the viewer, logged in, walked and flew around a bit. Everything seems to work. > > > Locally set _PREHASH_AgentData and _PREHASH_AgentID to (char const*)0x1 in indra/llui/tests/llurlentry_stub.cpp and indra/newview/tests/llremoteparcelrequest_test.cpp to verify they actually are never dereferenced, even when not NULL, so that using NULL pointers instead of place holder data won't change what code paths gets tested. Both tests binaries executed without crashes and all the contained tests passed. > > Locally invoked start_messaging_system() with b_dump_prehash_file == true instead of FALSE, to see what would be generated after my change to dump_prehash_files(). > The message_prehash.(h|cpp) generated by that had the correct type qualifiers and formatting, but some lines were removed or added compared to the modified files from the source tree. That probably means that the files aren't fully synchronized with the message template file in the source tree. Because the "added" constants are spread all over the file, while the "removed" ones were at the end, I'd wager that message_prehash.(h|cpp) in the viewer source tree are actually more up-to-date than the message template file in the source tree. > > > Thanks, > > Boroondas > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110207/ab8c7980/attachment.htm From laurent.bechir at madonie.org Mon Feb 7 17:22:03 2011 From: laurent.bechir at madonie.org (Laurent Bechir) Date: Tue, 08 Feb 2011 02:22:03 +0100 Subject: [opensource-dev] Disable the Home button JIRA submitted Message-ID: <4D509ABB.2030003@madonie.org> Hello, I've opened a JIRA to have the Home button disabled when a resident has no home set. I've had the idea after testing the button disabled when voice is inactive in 2.6 viewer. https://jira.secondlife.com/browse/VWR-24755 From merov at lindenlab.com Mon Feb 7 22:12:55 2011 From: merov at lindenlab.com (Merov Linden) Date: Tue, 08 Feb 2011 06:12:55 -0000 Subject: [opensource-dev] Review Request: STORM-971 'Stop Tracking' menu item is still enabled in Mini-map floater after you stopped tracking in Nearby mini-map In-Reply-To: <20110203204302.25011.87711@domU-12-31-38-00-90-68.compute-1.internal> References: <20110203204302.25011.87711@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110208061255.29364.25809@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/133/#review337 ----------------------------------------------------------- Ship it! Seems good. - Merov On Feb. 3, 2011, 12:43 p.m., Twisted Laws wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/133/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2011, 12:43 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Sets "Stop Tracking" enabled based on tracking if true or false instead of only when true. Also made it check for menu pointer validity to remove a remote crash possiblity. > > > This addresses bug STORM-971. > http://jira.secondlife.com/browse/STORM-971 > > > Diffs > ----- > > indra/newview/llnetmap.cpp ec4a9fd30688 > > Diff: http://codereview.secondlife.com/r/133/diff > > > Testing > ------- > > My testing was to open the side panel nearby, and verify that the state of the menu was correct when tracking by the different methods and disabled. Then leaving that open, openned a mini-map instance and repeated testing its state tracking and not. Also tried the reverse. Verified that every possibility I could think of, the state of both menus was always correct. > > Correct state is Stop Tracking is enabled anytime tracking is on for avatars or landmarks and is not enabled when Tracking has been stopped no matter where you stopped tracking (i.e, clicking on red arrow in view window, and using the various menues). > > > Thanks, > > Twisted > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110208/02ea4cb0/attachment.htm From merov at lindenlab.com Mon Feb 7 22:23:13 2011 From: merov at lindenlab.com (Merov Linden) Date: Tue, 08 Feb 2011 06:23:13 -0000 Subject: [opensource-dev] Review Request: (STORM-433) Friendship offer shifted up and placed over "Second Life" text In-Reply-To: <20110204184927.12722.76820@domU-12-31-38-00-90-68.compute-1.internal> References: <20110204184927.12722.76820@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110208062313.28780.18976@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/138/#review338 ----------------------------------------------------------- Ship it! Seems plausible. - Merov On Feb. 4, 2011, 10:49 a.m., Seth ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/138/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2011, 10:49 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Fixed reshaping notification panel with friendship offer when it is inserted into IM chat. > > > This addresses bug STORM-433. > http://jira.secondlife.com/browse/STORM-433 > > > Diffs > ----- > > indra/newview/llchathistory.cpp 2fe9d48e5881 > indra/newview/lltoastnotifypanel.cpp 2fe9d48e5881 > > Diff: http://codereview.secondlife.com/r/138/diff > > > Testing > ------- > > > Thanks, > > Seth > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110208/ddaef2f7/attachment.htm From akanevsky at productengine.com Tue Feb 8 01:16:48 2011 From: akanevsky at productengine.com (Anya Kanevsky) Date: Tue, 8 Feb 2011 01:16:48 -0800 Subject: [opensource-dev] Daily Scrum Summary - Monday, February 7 Message-ID: Monday, February 7 [edit ]General Notes ------------------------------ - MMOTD: Merov [edit ]Team Status ------------------------------ [edit ]Merov Linden ------------------------------ *PAST* - STORM-864 : APR memory pool : Fixed the Windows build issues. Got Aleric's Linux fix (prevents upgrade of apr-suite). Push on test repo and TC builds. Builds succeeded. - STORM-955 : Massively duplicated objects : Merge and test build on TC. Approved. Moved back to Aleric. - MM: integrated 2, rejected 1 (STORM-610, see JIRA) *FUTURE* - MM - STORM-864 : APR memory pool : Need to discuss with chopper how best to solve the apr_suite lib issue. Fix the Windows build issue. - STORM-955 : Massively duplicated objects : keep an eyes on this - STORM-746 : KDU Improvements: Compress j2c with precincts *IMPEDIMENTS* - none [edit ]Oz Linden ------------------------------ *PAST* - Worked on open-1: autobuild vs. VS Express with help from open devs - Created open-7 and open-8, and wrote patches to address them - Worked on User Groups calendar - coordinated with various communtity meeting announcement bots *FUTURE* - More work on open-1 - Continue testing new jira project rules - Work on open-4: FMOD packaging for viewer-autobuild *IMPEDIMENTS* - none [edit ]Q Linden ------------------------------ *PAST* - ooo for personal day and doctor's appts - catching up on email *FUTURE* - finish catching up - internal meetings - whatever I learn in this meeting *IMPEDIMENTS* - none [edit ]Wolf Linden ------------------------------ *PAST* Reviewed process with Anya *FUTURE* Working on Storm-236 (speak button, handle issue) Reviewing "needs design" tasks with Rhett *IMPEDIMENTS* - none [edit ]Grumpity ProductEngine ------------------------------ *PAST* - crashhunters - chat with Wolf about process and tasks - Wolf will be checking needs-design filter. Please use label, when approved feature requires XD. - import jira VWR issues for Jonathan *FUTURE* - crashhunters - jira cleanup - calendar updates *IMPEDIMENTS* - none [edit ]Seth Productengine ------------------------------ *PAST* - BUG (STORM-433) Friendship offer shifted up and placed over "Second Life" text - Fixed. Put fix on review board. - BUG (STORM-601) Colour swatches don't receive focus if click on them in Preference -> Colors - Fixed, posted fix for review. *FUTURE* - BUG (STORM-833) "i" button is overlaid with Group Members name - Estimated: 4-6 hours. *IMPEDIMENTS* - none [edit ]Vadim Productengine ------------------------------ - OOO - vacation *IMPEDIMENTS* - Who's gonna work on STORM-865 (add libboost_system to the build) ? It's blocking STORM-477 (re-implement directory iterator). - A: there?s a plan internally to work on build tools in a hackathon. Will move issues out of sprint. - Bug STORM-526 (Loss of pending offers): - Cannot reproduce, but the bug seems to exist (lots of reporters). Need help to find the repro steps. - Who's gonna create out-of-the-box viewer layouts for STORM-2? - Need design for story STORM-888 (Reorganize display name prefs). - A: Wolf is working on both of these. However, I don?t think we?re going to have out-of-the-box layouts for STORM-2 in this pass. [edit ]Andrey ProductEngine ------------------------------ *PAST* - tried to repro VWR-24714, closed as non-reproducible - continued with v-d regression testing, see spreadsheet - verified 14 issues - updated Nearby Panel test plan with STORM-643 *FUTURE* - update Chat test plan with STORM-829 - proceed with v-d testing until new Beta/Release build *IMPEDIMENTS* - none [edit ]Wolfpup Lowenhar ------------------------------ *PAST* - STORM-236 : Sent email to Richard over the weekend. - Attended Oz?s OH. - tested updated autobuild system , created OPEN-4 and OPEN-9 *FUTURE* - Work @ RL - STORM-236 : wait for Richard?s reply and new graphic. - help get autobuild system working better for OpenSource Devs(this includes helping with writing and wiki documentation needed. - STORM-941 : email Oz and Leyla concerning possible areas that could be causing the problem.(still need to do this) *IMPEDIMENTS* - STORM-236 : waiting for new graphics and email from Richard. - Not enough time to actually work on code. [edit ]Jonathan Yap ------------------------------ *PAST* - Helped test some OPEN-1 changes. - VWR-22220 (Chat preferences > font size should increase size of input text as well) - Finished. I was doing this as a learning experience. Maybe it will be taken in some day. - STORM-974 (UI button alignment issues in Landmark panel, About Land window, and Hardware Settings window) - Finished, will put on review board -- a test build might be in order. - STORM-975 (Duplicated menu entry Develop/Ui/Region Debug Console) - Finished *FUTURE* - More testing of OPEN - 1 issues. - STORM-976 (Object muted by name still displays notification message when clicked) - STORM-977 (llmediaplugintest shows up even though -DLL_TESTS:BOOL=OFF has been used) *IMPEDIMENTS* - none [edit ]Cummere Mayo ------------------------------ *PAST* - jira work - suspended from RL job over SL groups *FUTURE* - working on getting scanner to work for signing CA - not sure *IMPEDIMENTS* - need to do stuff for keeping rl job - need to work on SL store -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110208/051ec032/attachment-0001.htm From jhwelch at gmail.com Tue Feb 8 05:22:45 2011 From: jhwelch at gmail.com (Jonathan Yap) Date: Tue, 08 Feb 2011 13:22:45 -0000 Subject: [opensource-dev] Review Request: STORM-974 UI button alignment issues in Landmark panel, About Land window, and Hardware Settings window In-Reply-To: <20110207200418.28828.89266@domU-12-31-38-00-90-68.compute-1.internal> References: <20110207200418.28828.89266@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110208132245.28780.94605@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/142/ ----------------------------------------------------------- (Updated Feb. 8, 2011, 5:22 a.m.) Review request for Viewer. Changes ------- Took out the changes to flip the down-arrow in the bottom right of the Landmark panel to an up-arrow when it is pushed as that change is not within the scope of this jira. Summary ------- Please see the jira for the referenced pictures. In picture #1, in the preferences > graphics > hardware settings, the line of "gamma" setting is a little too up and it collides with the "antialiasing" line. In picture #2 in the "places" tab under "my landmarks" tab the "profile" button gets cut off at the end from the rest of the sidebar's UI. There are a number of other buttons with alignment issues with no screenshot. In picture #3 in the Access tab in the About Land window, the remove buttons are off to the right a few millimetres. Changes made were to align the Hardware Settings and About Land buttons and to completely go over the buttons in the Landmarks panel. The small down-arrow at the bottom right corner was using an imbedded UTF-8 so I fixed that and also made it point up while the menu is open (there is a separate jira for reversing the direction it points in these two states). This patch really needs a test viewer built to make sure all works and that nothing was missed in the Landmarks panel. There are 3 other related jiras that I hope are taken in; a test viewer could be made incorporating all 4 jiras at that point. This addresses bug STORM-974. http://jira.secondlife.com/browse/STORM-974 Diffs (updated) ----- indra/newview/skins/default/xui/en/panel_places.xml b0bceb572090 Diff: http://codereview.secondlife.com/r/142/diff Testing ------- Thanks, Jonathan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110208/9a984461/attachment.htm From pguslisty at productengine.com Tue Feb 8 08:42:27 2011 From: pguslisty at productengine.com (Paul ProductEngine) Date: Tue, 08 Feb 2011 16:42:27 -0000 Subject: [opensource-dev] Review Request: (STORM-433) Friendship offer shifted up and placed over "Second Life" text In-Reply-To: <20110204184927.12722.76820@domU-12-31-38-00-90-68.compute-1.internal> References: <20110204184927.12722.76820@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110208164227.29074.63648@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/138/#review339 ----------------------------------------------------------- - Paul On Feb. 4, 2011, 10:49 a.m., Seth ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/138/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2011, 10:49 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Fixed reshaping notification panel with friendship offer when it is inserted into IM chat. > > > This addresses bug STORM-433. > http://jira.secondlife.com/browse/STORM-433 > > > Diffs > ----- > > indra/newview/llchathistory.cpp 2fe9d48e5881 > indra/newview/lltoastnotifypanel.cpp 2fe9d48e5881 > > Diff: http://codereview.secondlife.com/r/138/diff > > > Testing > ------- > > > Thanks, > > Seth > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110208/3207d945/attachment.htm From pguslisty at productengine.com Tue Feb 8 08:43:26 2011 From: pguslisty at productengine.com (Paul ProductEngine) Date: Tue, 08 Feb 2011 16:43:26 -0000 Subject: [opensource-dev] Review Request: (STORM-433) Friendship offer shifted up and placed over "Second Life" text In-Reply-To: <20110208164227.29074.63648@domU-12-31-38-00-90-68.compute-1.internal> References: <20110208164227.29074.63648@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110208164326.29549.95175@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 8, 2011, 8:42 a.m., Paul ProductEngine wrote: > > Looks good. Ship it! - Paul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/138/#review339 ----------------------------------------------------------- On Feb. 4, 2011, 10:49 a.m., Seth ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/138/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2011, 10:49 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Fixed reshaping notification panel with friendship offer when it is inserted into IM chat. > > > This addresses bug STORM-433. > http://jira.secondlife.com/browse/STORM-433 > > > Diffs > ----- > > indra/newview/llchathistory.cpp 2fe9d48e5881 > indra/newview/lltoastnotifypanel.cpp 2fe9d48e5881 > > Diff: http://codereview.secondlife.com/r/138/diff > > > Testing > ------- > > > Thanks, > > Seth > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110208/c01bb963/attachment.htm From pguslisty at productengine.com Tue Feb 8 08:43:57 2011 From: pguslisty at productengine.com (Paul ProductEngine) Date: Tue, 08 Feb 2011 16:43:57 -0000 Subject: [opensource-dev] Review Request: (STORM-433) Friendship offer shifted up and placed over "Second Life" text In-Reply-To: <20110204184927.12722.76820@domU-12-31-38-00-90-68.compute-1.internal> References: <20110204184927.12722.76820@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110208164357.28964.66207@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/138/#review341 ----------------------------------------------------------- Ship it! - Paul On Feb. 4, 2011, 10:49 a.m., Seth ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/138/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2011, 10:49 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Fixed reshaping notification panel with friendship offer when it is inserted into IM chat. > > > This addresses bug STORM-433. > http://jira.secondlife.com/browse/STORM-433 > > > Diffs > ----- > > indra/newview/llchathistory.cpp 2fe9d48e5881 > indra/newview/lltoastnotifypanel.cpp 2fe9d48e5881 > > Diff: http://codereview.secondlife.com/r/138/diff > > > Testing > ------- > > > Thanks, > > Seth > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110208/a4ee06be/attachment.htm From jhwelch at gmail.com Tue Feb 8 08:46:21 2011 From: jhwelch at gmail.com (Jonathan Yap) Date: Tue, 08 Feb 2011 16:46:21 -0000 Subject: [opensource-dev] Review Request: STORM-977 llmediaplugintest shows up even though -DLL_TESTS:BOOL=OFF has been used Message-ID: <20110208164621.29141.49689@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/144/ ----------------------------------------------------------- Review request for Viewer. Summary ------- llmediaplugintest shows up to be compiled even though -DLL_TESTS:BOOL=OFF has been used on the command line. This cmake file does not use the call to LL_ADD_PROJECT_UNIT_TESTS that other cmake files do. LL_ADD_PROJECT_UNIT_TESTS is usually wrapped with if(LL_TESTS) I could not figure out which lines suppress the inclusion of copy_plugintest_libs and llmediaplugintest into the list of what is to be built so wrapped the entire file around if(LL_TESTS). If there is some better way to more exactly target these two items please point it out. This addresses bug STORM-977. http://jira.secondlife.com/browse/STORM-977 Diffs ----- indra/test_apps/llplugintest/CMakeLists.txt b0bceb572090 Diff: http://codereview.secondlife.com/r/144/diff Testing ------- Thanks, Jonathan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110208/22a1b83a/attachment-0001.htm From lenglish5 at cox.net Tue Feb 8 09:03:41 2011 From: lenglish5 at cox.net (Lawson English) Date: Tue, 08 Feb 2011 10:03:41 -0700 Subject: [opensource-dev] AW Groupies meeting today 9:30 AM SLT Message-ID: <4D51776D.8010309@cox.net> AW Groupies meeting today, 9:30 AM Pacific Coast Time. Maccus McCullough, Science and Technology Manager Virtual World Strategic Applications US Army Simulation & Training Technology Center, will be our speaker today From alain at lindenlab.com Tue Feb 8 09:37:09 2011 From: alain at lindenlab.com (Alain Linden) Date: Tue, 08 Feb 2011 17:37:09 -0000 Subject: [opensource-dev] Review Request: OPEN-8: allow specification of the configuration with env var AUTOBUILD_CONFIGURATION In-Reply-To: <20110207040157.29444.20926@domU-12-31-38-00-90-68.compute-1.internal> References: <20110207040157.29444.20926@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110208173709.29081.87977@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/141/#review342 ----------------------------------------------------------- I'm not sure AUTOBUILD_CONFIGURATION is a good name for this environment variable. I know this is long, but AUTOUBUILD_DEFAULT_BUILD_CONFIGURATIONS is more accurate and descriptive (and one could probably drop the AUTOBUILD if we aren't too worried about conflicts with other env variable names) - Alain On Feb. 6, 2011, 8:01 p.m., Oz Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/141/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2011, 8:01 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > This patch adds support for specifying the configurations using the AUTOBUILD_CONFIGURATION environment variable (multiple configurations can be specified using commas to separate the values). > > > This addresses bug open-8. > > > Diffs > ----- > > autobuild/autobuild_base.py 9ee2db08d677 > autobuild/autobuild_tool_build.py 9ee2db08d677 > autobuild/autobuild_tool_configure.py 9ee2db08d677 > > Diff: http://codereview.secondlife.com/r/141/diff > > > Testing > ------- > > Tested manually with and without the command line argument, and with and without the environment variable set; the appropriate configuration values were used. > > > Thanks, > > Oz > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110208/40de964a/attachment.htm From alain at lindenlab.com Tue Feb 8 09:48:13 2011 From: alain at lindenlab.com (Alain Linden) Date: Tue, 08 Feb 2011 17:48:13 -0000 Subject: [opensource-dev] Review Request: OPEN-7: allow specification of the config-file with env var AUTOBUILD_CONFIG_FILE In-Reply-To: <20110207013922.29474.12564@domU-12-31-38-00-90-68.compute-1.internal> References: <20110207013922.29474.12564@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110208174813.28780.56632@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/140/#review343 ----------------------------------------------------------- Should AUTOBUILD_CONFIG_FILE be renamed to AUTOBUILD_CONFIG_FILENAME to clarify this is a name and not a full file path? Not sure what would happen if someone set AUTOBUILD_CONFIG_FILE=foo/bar/baz/MyAutobuildConfig.xml, but probably not what the user expects. autobuild/configfile.py This gets called once on package load. I guess that's fine as long as you just use autobuild through the autobuild script, but you might get unexpected results if you are calling autobuild functions in your own interactive python session. Admittedly that's a corner case... autobuild/configfile.py This isn't a warning. It is perfectly OK to run autobuild with no script file, like, for example when you call autobuild edit to begin configuring an autobuild package. - Alain On Feb. 6, 2011, 5:39 p.m., Oz Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/140/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2011, 5:39 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > This change allows the environment variable AUTOBUILD_CONFIG_FILE to specify a default config-file, so that the precedence becomes: > > 1. the --config-file command line option > 2. the environment variable AUTOBUILD_CONFIG_FILE > 3. "autobuild.xml" > > It also adds an info-level (--verbose) display of the config file name that is being loaded, and a warning level display if the config file does not exist. > > > This addresses bug open-7. > > > Diffs > ----- > > autobuild/autobuild_tool_build.py 9ee2db08d677 > autobuild/autobuild_tool_configure.py 9ee2db08d677 > autobuild/autobuild_tool_edit.py 9ee2db08d677 > autobuild/autobuild_tool_install.py 9ee2db08d677 > autobuild/autobuild_tool_installables.py 9ee2db08d677 > autobuild/autobuild_tool_manifest.py 9ee2db08d677 > autobuild/autobuild_tool_package.py 9ee2db08d677 > autobuild/autobuild_tool_print.py 9ee2db08d677 > autobuild/autobuild_tool_uninstall.py 9ee2db08d677 > autobuild/configfile.py 9ee2db08d677 > > Diff: http://codereview.secondlife.com/r/140/diff > > > Testing > ------- > > Manually tested with and without the command line option, and with and without the environment variable set: confirmed that the correct file name is used per the precedence above. > > Confirmed that the new logging works correctly. > > > Thanks, > > Oz > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110208/d68a5d72/attachment.htm From oz at lindenlab.com Tue Feb 8 10:39:58 2011 From: oz at lindenlab.com (Oz Linden) Date: Tue, 08 Feb 2011 18:39:58 -0000 Subject: [opensource-dev] Review Request: OPEN-8: allow specification of the configuration with env var AUTOBUILD_CONFIGURATION In-Reply-To: <20110208173709.29081.87977@domU-12-31-38-00-90-68.compute-1.internal> References: <20110208173709.29081.87977@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110208183958.28779.64202@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 8, 2011, 9:37 a.m., Alain Linden wrote: > > I'm not sure AUTOBUILD_CONFIGURATION is a good name for this environment variable. I know this is long, but AUTOUBUILD_DEFAULT_BUILD_CONFIGURATIONS is more accurate and descriptive (and one could probably drop the AUTOBUILD if we aren't too worried about conflicts with other env variable names) The name was chosen to match that of the long-form option that it provides the default value for. Using the AUTOBUILD_ prefix is just good practice, because collisions are a serious issue not to be ignored. - Oz ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/141/#review342 ----------------------------------------------------------- On Feb. 6, 2011, 8:01 p.m., Oz Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/141/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2011, 8:01 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > This patch adds support for specifying the configurations using the AUTOBUILD_CONFIGURATION environment variable (multiple configurations can be specified using commas to separate the values). > > > This addresses bug open-8. > > > Diffs > ----- > > autobuild/autobuild_base.py 9ee2db08d677 > autobuild/autobuild_tool_build.py 9ee2db08d677 > autobuild/autobuild_tool_configure.py 9ee2db08d677 > > Diff: http://codereview.secondlife.com/r/141/diff > > > Testing > ------- > > Tested manually with and without the command line argument, and with and without the environment variable set; the appropriate configuration values were used. > > > Thanks, > > Oz > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110208/fa41d4d6/attachment-0001.htm From sllists at boroon.dasgupta.ch Tue Feb 8 10:41:45 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Tue, 08 Feb 2011 18:41:45 -0000 Subject: [opensource-dev] Review Request: STORM-977 llmediaplugintest shows up even though -DLL_TESTS:BOOL=OFF has been used In-Reply-To: <20110208164621.29141.49689@domU-12-31-38-00-90-68.compute-1.internal> References: <20110208164621.29141.49689@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110208184145.29444.77319@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/144/#review347 ----------------------------------------------------------- > If there is some better way to more exactly target these two items please point it out. You should be able to get the same effect when wrapping the only place where this file is referenced in a LL_TESTS condition, i.e., change https://bitbucket.org/lindenlab/viewer-development/src/b0bceb572090/indra/CMakeLists.txt#cl-74 from if (NOT LINUX) to if (LL_TESTS AND NOT LINUX) (and the same for the endif, of course) Whether that's a better place, I don't know. Though, I think LL_TESTS is the wrong conditional here, anyway. LL_TESTS is for enabling unit and integration tests. llplugintest however, I have learned on IRC today, seems to be a fully separate program based on and similar to uBrowser that could be used to load and test individual llmediaplugins, would it communicate with them in the same way the viewer does. (Which, according to MichelleZ, it doesn't, thus potentially misleading developers of new plugins.) It should probably not be built unless explicitly requested, thus a new variable, defaulting to OFF and different from LL_TESTS would suit this much better. Or, just delete the referencing at https://bitbucket.org/lindenlab/viewer-development/src/b0bceb572090/indra/CMakeLists.txt#cl-75 completely, thus unconditionally removing it from the dependencies of the viewer itself, and have those that want to build it explicitly state it as a build target. - Boroondas On Feb. 8, 2011, 8:46 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/144/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2011, 8:46 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > llmediaplugintest shows up to be compiled even though -DLL_TESTS:BOOL=OFF has been used on the command line. > > This cmake file does not use the call to LL_ADD_PROJECT_UNIT_TESTS that other cmake files do. > > LL_ADD_PROJECT_UNIT_TESTS is usually wrapped with if(LL_TESTS) > > I could not figure out which lines suppress the inclusion of copy_plugintest_libs and llmediaplugintest into the list of what is to be built so wrapped the entire file around if(LL_TESTS). > > If there is some better way to more exactly target these two items please point it out. > > > This addresses bug STORM-977. > http://jira.secondlife.com/browse/STORM-977 > > > Diffs > ----- > > indra/test_apps/llplugintest/CMakeLists.txt b0bceb572090 > > Diff: http://codereview.secondlife.com/r/144/diff > > > Testing > ------- > > > Thanks, > > Jonathan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110208/f341d4b5/attachment.htm From oz at lindenlab.com Tue Feb 8 11:00:31 2011 From: oz at lindenlab.com (Oz Linden) Date: Tue, 08 Feb 2011 19:00:31 -0000 Subject: [opensource-dev] Review Request: OPEN-7: allow specification of the config-file with env var AUTOBUILD_CONFIG_FILE In-Reply-To: <20110208174813.28780.56632@domU-12-31-38-00-90-68.compute-1.internal> References: <20110208174813.28780.56632@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110208190031.28973.80001@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 8, 2011, 9:48 a.m., Alain Linden wrote: > > Should AUTOBUILD_CONFIG_FILE be renamed to AUTOBUILD_CONFIG_FILENAME to clarify this is a name and not a full file path? Not sure what would happen if someone set AUTOBUILD_CONFIG_FILE=foo/bar/baz/MyAutobuildConfig.xml, but probably not what the user expects. The option name was chosen to match the name of the long form option that it supplies a default value for. I just tested what would happen, and it's identical to what happens if you use the command autobuild configure --config-file foo/bar/baz/MyAutobuildConfig.xml which is to say that the autobuild command reads the configuration file just fine, but cmake fails because the relative paths are incorrect. If this is a problem, I think that it's a separate issue; the environment variable is bug-for-bug compatible with the command line switch. > On Feb. 8, 2011, 9:48 a.m., Alain Linden wrote: > > autobuild/configfile.py, line 44 > > > > > > This gets called once on package load. I guess that's fine as long as you just use autobuild through the autobuild script, but you might get unexpected results if you are calling autobuild functions in your own interactive python session. Admittedly that's a corner case... According to its documentation, the os.environ.get is always going to return the same value that it did on the first call regardless. > On Feb. 8, 2011, 9:48 a.m., Alain Linden wrote: > > autobuild/configfile.py, line 214 > > > > > > This isn't a warning. It is perfectly OK to run autobuild with no script file, like, for example when you call autobuild edit to begin configuring an autobuild package. That depends on what you think that 'warning' means... in this case, I think it means that if I specified a file that I think exists but it does not, then without this warning that fact is not at all obvious - I get an error about some package not being defined, not a message that gives me any clue that the configuration file is not read. I don't think that anyone who is trying to create a new file would be bothered by a message that says that it does not already exist at the beginning, but in fact I tested it and that's a different code path - you don't get the warning when creating the file. - Oz ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/140/#review343 ----------------------------------------------------------- On Feb. 6, 2011, 5:39 p.m., Oz Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/140/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2011, 5:39 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > This change allows the environment variable AUTOBUILD_CONFIG_FILE to specify a default config-file, so that the precedence becomes: > > 1. the --config-file command line option > 2. the environment variable AUTOBUILD_CONFIG_FILE > 3. "autobuild.xml" > > It also adds an info-level (--verbose) display of the config file name that is being loaded, and a warning level display if the config file does not exist. > > > This addresses bug open-7. > > > Diffs > ----- > > autobuild/autobuild_tool_build.py 9ee2db08d677 > autobuild/autobuild_tool_configure.py 9ee2db08d677 > autobuild/autobuild_tool_edit.py 9ee2db08d677 > autobuild/autobuild_tool_install.py 9ee2db08d677 > autobuild/autobuild_tool_installables.py 9ee2db08d677 > autobuild/autobuild_tool_manifest.py 9ee2db08d677 > autobuild/autobuild_tool_package.py 9ee2db08d677 > autobuild/autobuild_tool_print.py 9ee2db08d677 > autobuild/autobuild_tool_uninstall.py 9ee2db08d677 > autobuild/configfile.py 9ee2db08d677 > > Diff: http://codereview.secondlife.com/r/140/diff > > > Testing > ------- > > Manually tested with and without the command line option, and with and without the environment variable set: confirmed that the correct file name is used per the precedence above. > > Confirmed that the new logging works correctly. > > > Thanks, > > Oz > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110208/9edb7383/attachment.htm From nickyperian at yahoo.com Tue Feb 8 11:25:54 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Tue, 08 Feb 2011 19:25:54 -0000 Subject: [opensource-dev] Review Request: Debugging autobuild post build re-configuration error. In-Reply-To: <20110204050419.12723.70255@domU-12-31-38-00-90-68.compute-1.internal> References: <20110204050419.12723.70255@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110208192554.29364.23941@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/137/ ----------------------------------------------------------- (Updated Feb. 8, 2011, 11:25 a.m.) Review request for Viewer. Changes ------- Link jira OPEN-13 Summary ------- Print out failed build_config from autobuild_tool_build.py This addresses bug OPEN-13. Diffs ----- autobuild/autobuild_tool_build.py ffcfcf7cde2c Diff: http://codereview.secondlife.com/r/137/diff Testing ------- Just started, trying to determine if the error can be corrected with autobuild.xml entries or by post-build string adjustments. Thanks, Nicky -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110208/ccd93623/attachment-0001.htm From pguslisty at productengine.com Tue Feb 8 11:26:04 2011 From: pguslisty at productengine.com (Paul ProductEngine) Date: Tue, 08 Feb 2011 19:26:04 -0000 Subject: [opensource-dev] Review Request: STORM-680 (Avaline callers are added to the Recent list) Message-ID: <20110208192604.29549.35037@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/146/ ----------------------------------------------------------- Review request for Viewer. Summary ------- - When accepting an avaline call, add a caller to the recent list as AvalineListItem - When adding item to the LLRecentPeople, check whether item with the same phone number exists and delete it if exists. This is need to avoid duplication in the Recent list of the panel People. This addresses bug STORM-680. http://jira.secondlife.com/browse/STORM-680 Diffs ----- indra/newview/llavatarlist.h 33fc9ed99d29 indra/newview/llavatarlist.cpp 33fc9ed99d29 indra/newview/llrecentpeople.h 33fc9ed99d29 indra/newview/llrecentpeople.cpp 33fc9ed99d29 indra/newview/llvoicechannel.h 33fc9ed99d29 indra/newview/llvoicechannel.cpp 33fc9ed99d29 Diff: http://codereview.secondlife.com/r/146/diff Testing ------- Thanks, Paul -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110208/d60fdba8/attachment.htm From merov at lindenlab.com Tue Feb 8 12:15:00 2011 From: merov at lindenlab.com (Philippe (Merov) Bossut) Date: Tue, 8 Feb 2011 12:15:00 -0800 Subject: [opensource-dev] Test build Message-ID: Hi, I created a test build for a handful of JIRAs waiting for PO reviews. The binaries can be found here: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/220558/index.html The fixes this includes are: - STORM-433 : Friendship offer shifted up and placed over "Second Life" text - STORM-601 : Colour swatches don't receive focus if click on them in Preference -> Colors - STORM-953 : Clarify what happens when you uncheck Allow Public Access - STORM-955 : Massively duplicated objects - STORM-960 : Descriptive text missing next to first checkbox in About Land/Access Cheers, - Merov -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110208/4d023a8f/attachment.htm From angel_of_crimson at hotmail.com Tue Feb 8 13:59:16 2011 From: angel_of_crimson at hotmail.com (Erin Mallory) Date: Tue, 8 Feb 2011 16:59:16 -0500 Subject: [opensource-dev] Test build In-Reply-To: References: Message-ID: downloaded it... will install it after your office hours. From: merov at lindenlab.com Date: Tue, 8 Feb 2011 12:15:00 -0800 To: opensource-dev at lists.secondlife.com Subject: [opensource-dev] Test build Hi, I created a test build for a handful of JIRAs waiting for PO reviews. The binaries can be found here: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/220558/index.html The fixes this includes are: - STORM-433 : Friendship offer shifted up and placed over "Second Life" text - STORM-601 : Colour swatches don't receive focus if click on them in Preference -> Colors - STORM-953 : Clarify what happens when you uncheck Allow Public Access - STORM-955 : Massively duplicated objects - STORM-960 : Descriptive text missing next to first checkbox in About Land/Access Cheers, - Merov _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110208/8d2cb2cc/attachment.htm From lenglish5 at cox.net Tue Feb 8 16:35:58 2011 From: lenglish5 at cox.net (Lawson English) Date: Tue, 08 Feb 2011 17:35:58 -0700 Subject: [opensource-dev] Transcript of Tuesday's AWG meeting (very interesting and informative) Message-ID: <4D51E16E.1090700@cox.net> Today's meeting was with Maccus McCullough, Science and Technology Manager Virtual World Strategic Applications US Army Simulation & Training Technology Center Transcript of meeting: http://wiki.secondlife.com/wiki/AW_Groupies/Chat_Logs/AWGroupies-2011-02-08 From angel_of_crimson at hotmail.com Tue Feb 8 20:06:15 2011 From: angel_of_crimson at hotmail.com (Erin Mallory) Date: Tue, 8 Feb 2011 23:06:15 -0500 Subject: [opensource-dev] Test build In-Reply-To: References: Message-ID: okay here are my results so far: 433: seems fixed 601: still testing... 953: fixed and looks good imho 955: I cant test for that 960: fixed From: merov at lindenlab.com Date: Tue, 8 Feb 2011 12:15:00 -0800 To: opensource-dev at lists.secondlife.com Subject: [opensource-dev] Test build Hi, I created a test build for a handful of JIRAs waiting for PO reviews. The binaries can be found here: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/220558/index.html The fixes this includes are: - STORM-433 : Friendship offer shifted up and placed over "Second Life" text - STORM-601 : Colour swatches don't receive focus if click on them in Preference -> Colors - STORM-953 : Clarify what happens when you uncheck Allow Public Access - STORM-955 : Massively duplicated objects - STORM-960 : Descriptive text missing next to first checkbox in About Land/Access Cheers, - Merov _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110208/42059305/attachment.htm From merov at lindenlab.com Tue Feb 8 23:16:21 2011 From: merov at lindenlab.com (Philippe (Merov) Bossut) Date: Tue, 8 Feb 2011 23:16:21 -0800 Subject: [opensource-dev] Test build In-Reply-To: References: Message-ID: Hi again, Has anyone tested that Mac build? I'm experiencing freeze on login with that version. Nothing clear in the log. Seems to happen just after launching SLVoice and before rendering the world (so could be related to rendering, GPU, etc...). All other versions of 2.6 do work fine. Only *that* build. Scary... I'm holding off merging those patches in case one of them is triggering the problem. Feedback from others testing on Mac appreciated. Cheers, - Merov On Tue, Feb 8, 2011 at 12:15 PM, Philippe (Merov) Bossut < merov at lindenlab.com> wrote: > Hi, > > I created a test build for a handful of JIRAs waiting for PO reviews. The > binaries can be found here: > > http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/220558/index.html > > The fixes this includes are: > - STORM-433 : Friendship offer shifted up and placed over "Second Life" > text > - STORM-601 : Colour swatches don't receive focus if click on them in > Preference -> Colors > - STORM-953 : Clarify what happens when you uncheck Allow Public Access > - STORM-955 : Massively duplicated objects > - STORM-960 : Descriptive text missing next to first checkbox in About > Land/Access > > Cheers, > - Merov > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110208/eb968583/attachment.htm From angel_of_crimson at hotmail.com Tue Feb 8 23:24:09 2011 From: angel_of_crimson at hotmail.com (Erin Mallory) Date: Wed, 9 Feb 2011 02:24:09 -0500 Subject: [opensource-dev] Test build In-Reply-To: References: , Message-ID: Merov, I always have freezes on login (though 99% of the time only right before and during the downloading clothing bit). I'm running it on my windows xp machine. haven't downloaded it to my 7 machine yet, but I'm not noticing anything worse then normal on here. So I suspect it might be mac specific. I wish I had a mac to help test on there for you. Sorry I can't be more help. From: merov at lindenlab.com Date: Tue, 8 Feb 2011 23:16:21 -0800 To: opensource-dev at lists.secondlife.com Subject: Re: [opensource-dev] Test build Hi again, Has anyone tested that Mac build? I'm experiencing freeze on login with that version. Nothing clear in the log. Seems to happen just after launching SLVoice and before rendering the world (so could be related to rendering, GPU, etc...). All other versions of 2.6 do work fine. Only *that* build. Scary... I'm holding off merging those patches in case one of them is triggering the problem. Feedback from others testing on Mac appreciated. Cheers, - Merov On Tue, Feb 8, 2011 at 12:15 PM, Philippe (Merov) Bossut wrote: Hi, I created a test build for a handful of JIRAs waiting for PO reviews. The binaries can be found here: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/220558/index.html The fixes this includes are: - STORM-433 : Friendship offer shifted up and placed over "Second Life" text - STORM-601 : Colour swatches don't receive focus if click on them in Preference -> Colors - STORM-953 : Clarify what happens when you uncheck Allow Public Access - STORM-955 : Massively duplicated objects - STORM-960 : Descriptive text missing next to first checkbox in About Land/Access Cheers, - Merov _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110209/6f22f37b/attachment.htm From akanevsky at productengine.com Wed Feb 9 01:27:42 2011 From: akanevsky at productengine.com (Anya Kanevsky) Date: Wed, 9 Feb 2011 01:27:42 -0800 Subject: [opensource-dev] Daily Scrum Summary - Tuesday, February 8 Message-ID: Tuesday, February 8 [edit ]General Notes ------------------------------ - MMOTD: Merov [edit ]Team Status ------------------------------ [edit ]Merov Linden ------------------------------ *PAST* - STORM-955 : Massively duplicated objects : Tested that it merges fine and builds on all platforms. Moved to review. - STORM-864 : APR memory pool : Proposed a new simpler fix for the Windows build issue. No more issue with Linux and does not require rebuilding apr_suite. - STORM-746 : KDU Improvements: Compress j2c with precincts: Thinking that we need an independent test app so to get really reproducible data here. Discussed with QA folks about creating an llimage_libtest under indra/integration_tests. Putting together a short spec for this. *FUTURE* - MM - STORM-746 : KDU Improvements: Compress j2c with precincts: Try to write a first version of llimage_libtest. *IMPEDIMENTS* - Lots of JIRA in review lane missing PO acceptance. Need test build? [edit ]Oz Linden ------------------------------ *PAST* - More work on open-1 - Lots of work User Groups *FUTURE* - Continue testing new jira project rules - Work on open-4: FMOD packaging for viewer-autobuild *IMPEDIMENTS* - none [edit ]Q Linden ------------------------------ *PAST* - beta -> release - internal meetings - user group stuff - STORM-969 / ER-493 -- changes for land owner categories *FUTURE* - release - writing some documents - triage - internal meetings *IMPEDIMENTS* - none [edit ]Wolf Linden ------------------------------ *PAST* - Reviewed process with Anya *FUTURE* - Working on Storm-236 (speak button, handle issue) - Reviewing "needs design" tasks with Rhett *IMPEDIMENTS* - none [edit ]Grumpity ProductEngine ------------------------------ *PAST* - crashhunters - imported issues for Jonathan, except the needs-design one - release readiness discussions - talked to Search team *FUTURE* - jira cleanup - calendar updates - product triage - consider STORM triage in addition to VWR *IMPEDIMENTS* - none [edit ]Paul Productengine ------------------------------ *PAST* - BUG STORM-680 (Avaline callers are added to the Recent list) - Fixed. Tomorrow will test and send for review. *FUTURE* - BUG STORM-357 (Gestures button is in the pressed state after drag-n-drop but gestures list isn't visible) *IMPEDIMENTS* - For STORM-888 (As a resident I want to access all the display name prefs in the same place so that I'm not hunting for the different options) there should be a design. It's not clear for now how exacly this should be done. - A: please wait for Wolf to complete design. [edit ]Seth Productengine ------------------------------ *PAST* - BUG (STORM-833) "i" button is overlaid with Group Members name - Investigated, found the cause of the problem. Working on fix. *FUTURE* - BUG (STORM-833) "i" button is overlaid with Group Members name - Estimated: 2-3 hours. - BUG (STORM-939) Opening multiple inventory floaters causes viewer to lag or even crash - Estimated: 10-12 hours. *IMPEDIMENTS* - Bug STORM-526 (Log out failure during Login causes loss of pending offers, including inventory): - Cannot reproduce, seems to be account specific. Need help to find the repro steps. - Story STORM-873 (Keyboard shortcut or text interface command to Accept Friends request): Asked for more details and clarifications. - A: please wait for Wolf to complete design [edit ]Vadim Productengine ------------------------------ - OOO - vacation [edit ]Andrey ProductEngine ------------------------------ *PAST* - continued v-d regression testing. See spreadsheet. - reported 1 issue: VWR-24747 - verified: none - revised Chat and Nearby Panel test plans *FUTURE* - pickup next Beta build? - revise Build tools test plan *IMPEDIMENTS* - none [edit ]Wolfpup Lowenhar ------------------------------ *PAST* - STORM-236 : Waiting for email form Richard. - OPEN-9 : Tested Nicky's sugestion and did not get the same output still getting same information. *FUTURE* - Be At Hospital roommate having surgery. - STORM-941 : email Oz and Leyla concerning possible areas that could be causing the problem.(still need to do this) *IMPEDIMENTS* - STORM-236 : waiting for new graphics and email from Richard. - Not enough time to actually work on code. - Roommate in hospital. [edit ]Jonathan Yap ------------------------------ *PAST* - STORM-977 (llmediaplugintest shows up even though -DLL_TESTS:BOOL=OFF has been used) Finished. Put on Review Board. *FUTURE* - STORM-976 (Object muted by name still displays notification message when clicked) *IMPEDIMENTS* - none [edit ]Cummere Mayo ------------------------------ *PAST* - jira work - blog post on http://jayrcelasecondlifetechnologist.blogspot.com/ - sent ca to oz (needs forwarded on to wherever it goes) - sl store stuff - sl group stuff - researching media privacy stuff *FUTURE* - office hours - jira stuff - more research on privacy especially related to parcel_media_comand_agent - SL rollar derby practice! *IMPEDIMENTS* - none -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110209/6a8558f6/attachment-0001.htm From slitovchuk at productengine.com Wed Feb 9 06:03:31 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Wed, 09 Feb 2011 14:03:31 -0000 Subject: [opensource-dev] Review Request: STORM-680 (Avaline callers are added to the Recent list) In-Reply-To: <20110208192604.29549.35037@domU-12-31-38-00-90-68.compute-1.internal> References: <20110208192604.29549.35037@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110209140331.29474.31935@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/146/#review349 ----------------------------------------------------------- Ship it! - Seth On Feb. 8, 2011, 11:26 a.m., Paul ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/146/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2011, 11:26 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > - When accepting an avaline call, add a caller to the recent list as AvalineListItem > > - When adding item to the LLRecentPeople, check whether item with the same phone number exists and delete it if exists. This is need to avoid duplication in the Recent list of the panel People. > > > This addresses bug STORM-680. > http://jira.secondlife.com/browse/STORM-680 > > > Diffs > ----- > > indra/newview/llavatarlist.h 33fc9ed99d29 > indra/newview/llavatarlist.cpp 33fc9ed99d29 > indra/newview/llrecentpeople.h 33fc9ed99d29 > indra/newview/llrecentpeople.cpp 33fc9ed99d29 > indra/newview/llvoicechannel.h 33fc9ed99d29 > indra/newview/llvoicechannel.cpp 33fc9ed99d29 > > Diff: http://codereview.secondlife.com/r/146/diff > > > Testing > ------- > > > Thanks, > > Paul > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110209/8518ff63/attachment.htm From sllists at boroon.dasgupta.ch Wed Feb 9 06:32:08 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Wed, 09 Feb 2011 15:32:08 +0100 Subject: [opensource-dev] Test build In-Reply-To: References: Message-ID: <4D52A568.60004@boroon.dasgupta.ch> Downloaded the Linux build. On 02/08/2011 09:15 PM, Philippe (Merov) Bossut wrote: > - STORM-955 : Massively duplicated objects Tested that with the long command line Aleric gave on RB. Much less multiple occurrences than in build 219680. Remaining multiple ones are: 2 COLLAPSED_BY_USER 2 FTM_CREATE_OBJECT 2 FTM_CULL_REBOUND 2 FTM_GEO_SKY 2 FTM_PROCESS_OBJECTS 2 FTM_REBUILD_VBO 2 FTM_UPDATE_WLPARAM 2 LSCRIPTDataSize 2 LSCRIPTStateBitField 2 LSCRIPTTypeNames 2 MANIPULATOR_IDS 2 NEW_LINE 2 PANEL_PICKS 2 PANEL_PROFILE 2 PREVIEW_HPAD 2 PREVIEW_TEXTURE_HEIGHT 2 WEARABLE_NAME_COMPARATOR 2 simd_w97_rem 2 simd_w97_preoff 2 initialize_transition_table()::C.36 2 aanscalefactor.106 2 aanscales.105 2 deferred_render 2 extend_offset 2 extend_test 2 icon_m 2 icon_pg 2 icon_r 2 sTesterName 2 shader 2 t_panel_group_general 2 t_places 3 empty_string 3 gDirOpposite 3 t2 3 t_inventory 4 r3 5 t1 8 OGL_TO_CFR_ROTATION 8 r2 8 rcsid 10 boost::tuples::ignore 12 r1 52 r 804 std::__ioinit Except for rcsid and boost::tuples::ignore, all the ones with a count of 3 or above also show in the list of remaining duplicate names /after/ the patch in Aleric's comment on RB , so I guess they are OK. I don't know if something should be done about rcsid and boost::tuples::ignore. Cheers, Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110209/cbf95c75/attachment.htm From akanevsky at productengine.com Wed Feb 9 09:46:42 2011 From: akanevsky at productengine.com (Anya Kanevsky) Date: Wed, 9 Feb 2011 09:46:42 -0800 Subject: [opensource-dev] Test build In-Reply-To: References: Message-ID: Merov, I was running the mac build during yesterday's meeting, and just tried it again - I don't freeze. 2011/2/8 Philippe (Merov) Bossut > Hi again, > > Has anyone tested that Mac build? I'm experiencing freeze on login with > that version. Nothing clear in the log. Seems to happen just after launching > SLVoice and before rendering the world (so could be related to rendering, > GPU, etc...). All other versions of 2.6 do work fine. Only *that* build. > Scary... > > I'm holding off merging those patches in case one of them is triggering the > problem. Feedback from others testing on Mac appreciated. > > Cheers, > - Merov > > > On Tue, Feb 8, 2011 at 12:15 PM, Philippe (Merov) Bossut < > merov at lindenlab.com> wrote: > >> Hi, >> >> I created a test build for a handful of JIRAs waiting for PO reviews. The >> binaries can be found here: >> >> http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/220558/index.html >> >> The fixes this includes are: >> - STORM-433 : Friendship offer shifted up and placed over "Second Life" >> text >> - STORM-601 : Colour swatches don't receive focus if click on them in >> Preference -> Colors >> - STORM-953 : Clarify what happens when you uncheck Allow Public Access >> - STORM-955 : Massively duplicated objects >> - STORM-960 : Descriptive text missing next to first checkbox in About >> Land/Access >> >> Cheers, >> - Merov >> > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110209/6300d2a8/attachment.htm From oz at lindenlab.com Wed Feb 9 09:50:44 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Wed, 09 Feb 2011 12:50:44 -0500 Subject: [opensource-dev] Test build In-Reply-To: References: Message-ID: <4D52D3F4.5000203@lindenlab.com> On 2011-02-09 12:46, Anya Kanevsky wrote: > Merov, I was running the mac build during yesterday's meeting, and > just tried it again - I don't freeze. Me too. From akanevsky at productengine.com Wed Feb 9 12:23:11 2011 From: akanevsky at productengine.com (Anya Kanevsky) Date: Wed, 9 Feb 2011 12:23:11 -0800 Subject: [opensource-dev] Daily Scrum Summary - Wednesday, February 9 Message-ID: [edit ]Wednesday, February 9 [edit ]General Notes ------------------------------ - QOTD: there's no present like time - please remember to write Acceptance Criteria / Test Plans when submitting an issue! - MM - please remember to make sure issue you merge is in current sprint. - MMOTD: Merov [edit ]Team Status ------------------------------ [edit ]Merov Linden ------------------------------ *PAST* - MM: Created test build, merge locally 6 pending requests, rejected STORM-986. Potential freeze on Mac so waiting for feedback from community. - VWR-24429 : KDU Error : investigated, couldn't repro, closed. - STORM-937 : Path to python in /scripts/*.py file inconsistent : updated wiki - OH: triaged rest of SNOW bugs - Meetings *FUTURE* - MM : unblock on the Mac freeze issue - STORM-937 : Finish that one - STORM-746 : KDU Improvements: Compress j2c with precincts: Try to write a first version of llimage_libtest. *IMPEDIMENTS* - none [edit ]Oz Linden ------------------------------ *PAST* - More work on open-1 - Lots of work User Groups - finished OPEN jira project rules (I think) - Started work on open-4: FMOD packaging for viewer-autobuild - Assorted issue review *FUTURE* - Continus work on open-4: FMOD packaging for viewer-autobuild - Create wiki page on building viewer w/ autobuild - Associated environment setup pages *IMPEDIMENTS* - none [edit ]Q Linden ------------------------------ *PAST* - documentation - internal meetings - release - triage - user group meeting *FUTURE* - release - internal meetings - backlog - documentation *IMPEDIMENTS* - none [edit ]Wolf Linden ------------------------------ *PAST* - STORM-236 *FUTURE* - VWR-24752 *IMPEDIMENTS* - none [edit ]Grumpity ProductEngine ------------------------------ *PAST* - STORM jira cleanup - unscheduled issues - design priorities - VWR triage and PO approval - remember to write acceptance criteria! *FUTURE* - STORM cleanup in jira - OOO a few hours in afternoon. *IMPEDIMENTS* - none [edit ]Paul Productengine ------------------------------ *PAST* - BUG STORM-680 (Avaline callers are added to the Recent list) - Found the problem while testing but solved it and sent fix for review. - BUG STORM-951 (Accidental Self-Muting/Self-Blocking) - WIP. Investigating. Hard for now to give estimates. Almost all time spent on STORM-680. Will wait for design to continue. - BUG STORM-357 (Gestures button is in the pressed state after drag-n-drop but gestures list isn't visible ) - WIP. Investigating. Estimates ~8 hours *FUTURE* - BUG STORM-357 (Gestures button is in the pressed state after drag-n-drop but gestures list isn't visible ) *IMPEDIMENTS* - waiting for issues that need design. [edit ]Seth Productengine ------------------------------ *PAST* - BUG (STORM-833) "i" button is overlaid with Group Members name - Working on the fix. Investigating tooltips and mouse hover event handling by LLNameListCtrl. *FUTURE* - BUG (STORM-833) "i" button is overlaid with Group Members name - Estimated: 4-6 hours. - BUG (STORM-939) Opening multiple inventory floaters causes viewer to lag or even crash - Estimated: 10-12 hours. *IMPEDIMENTS* - Bug STORM-526 (Log out failure during Login causes loss of pending offers, including inventory): - Cannot reproduce, seems to be account specific. Need help to find the repro steps. [edit ]Vadim Productengine ------------------------------ - OOO - vacation [edit ]Andrey ProductEngine ------------------------------ *PAST* - picked up 2.5.0 Release build (r220251) - smoke & integrity have been passed, please refer to the IQA-82 for more details - switched to the latest v-d build and proceeded with regression testing - reported 2 issues: VWR-24759 and VWR-24761 *FUTURE* - verify integrated tickets - update build tools test plan - continue with regression testing against v-d *IMPEDIMENTS* - none [edit ]Jonathan Yap ------------------------------ *PAST* - OPEN-1 (autobuild does not support use with Visual Studio Express) - Helped test. Found and reported some issues. - STORM-956 (Ability to mute dialogs by muting object (or object owner)) - Was in contact with Andrew on the details of a server change. I am not working on this issue; it came up in context with one I will be. *FUTURE* - STORM-976 (Object muted by name still displays notification message when clicked) *IMPEDIMENTS* - none [edit ]Cummere Mayo ------------------------------ *PAST* - finished off snow sorting project - made a couple of jiras including VWR-24764 - helped modify a few more - worked on sl store - rollar derby practice! *FUTURE* - more sl store wrok - refining some jiras - writing some more jiras *IMPEDIMENTS* - none -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110209/eb48ba44/attachment-0001.htm From merov at lindenlab.com Wed Feb 9 15:21:03 2011 From: merov at lindenlab.com (Philippe (Merov) Bossut) Date: Wed, 9 Feb 2011 15:21:03 -0800 Subject: [opensource-dev] Test build In-Reply-To: <4D52D3F4.5000203@lindenlab.com> References: <4D52D3F4.5000203@lindenlab.com> Message-ID: Hi, On Wed, Feb 9, 2011 at 9:50 AM, Oz Linden (Scott Lawrence) wrote: > On 2011-02-09 12:46, Anya Kanevsky wrote: > > Merov, I was running the mac build during yesterday's meeting, and > > just tried it again - I don't freeze. > > Me too. > > Thanks for the tests. It's still freezing my machine though with perfect regularity. Local RelWithDebInfo and Release builds though do *not* freeze so I'm thinking this has nothing to do with the code but with some settings being used in one case and not the other. I'm going to push the 6 changes then but will keep an eye on that. In the meantime, if anyone is experience hard freeze on Mac (one that requires a hard boot), please let us know here asap. Cheers, - Merov -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110209/a02dc110/attachment.htm From merov at lindenlab.com Wed Feb 9 15:33:47 2011 From: merov at lindenlab.com (Merov Linden) Date: Wed, 09 Feb 2011 23:33:47 -0000 Subject: [opensource-dev] Review Request: Use consistent path for all *.py scripts In-Reply-To: <20110129015615.30228.14123@domU-12-31-38-00-90-68.compute-1.internal> References: <20110129015615.30228.14123@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110209233347.5226.38891@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/129/ ----------------------------------------------------------- (Updated Feb. 9, 2011, 3:33 p.m.) Review request for Viewer. Changes ------- Took comments into account: - Changed to use the #!/usr/bin/env python shebang line - Add license info to python files that were missing one - Reformatted some license header for consistency - Updated wiki http://wiki.secondlife.com/wiki/Coding_standard#Python to make those aspects (shebang and licensing) clear Summary ------- Simple consistency change, using "#!/usr/bin/python" in all python script. This addresses bug STORM-937. http://jira.secondlife.com/browse/STORM-937 Diffs (updated) ----- indra/cmake/run_build_test.py 0ca239e469b3 indra/copy_win_scripts/start-client.py 0ca239e469b3 indra/develop.py 0ca239e469b3 indra/lib/python/indra/util/llperformance.py 0ca239e469b3 indra/lib/python/indra/util/simperf_proc_interface.py 0ca239e469b3 indra/lib/python/indra/util/test_win32_manifest.py 0ca239e469b3 indra/llmessage/tests/test_llsdmessage_peer.py 0ca239e469b3 indra/llmessage/tests/testrunner.py 0ca239e469b3 indra/newview/generate_breakpad_symbols.py 0ca239e469b3 indra/newview/tests/test_llxmlrpc_peer.py 0ca239e469b3 indra/newview/viewer_manifest.py 0ca239e469b3 indra/test/test_llmanifest.py 0ca239e469b3 scripts/build_version.py 0ca239e469b3 scripts/md5check.py 0ca239e469b3 scripts/setup-path.py 0ca239e469b3 scripts/template_verifier.py 0ca239e469b3 scripts/update_version_files.py 0ca239e469b3 Diff: http://codereview.secondlife.com/r/129/diff Testing ------- Pulled into a test repo and build successfully on all platforms on TC so I guess no bad surprise here. Thanks, Merov -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110209/706a3ade/attachment.htm From hitomi.tiponi at yahoo.co.uk Wed Feb 9 19:37:07 2011 From: hitomi.tiponi at yahoo.co.uk (Hitomi Tiponi) Date: Thu, 10 Feb 2011 03:37:07 +0000 (GMT) Subject: [opensource-dev] Prduct/Business Lead for Snowstorm In-Reply-To: References: Message-ID: <478932.95415.qm@web23906.mail.ird.yahoo.com> Is there any news on when Snowstorm will be getting a new Product/Business Lead (it is still listed as Esbee on the wiki) or who is dealing with such matters in the interim? Hitomi -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110210/5629b264/attachment.htm From q at lindenlab.com Wed Feb 9 20:45:10 2011 From: q at lindenlab.com (Kent Quirk (Q Linden)) Date: Wed, 9 Feb 2011 23:45:10 -0500 Subject: [opensource-dev] Prduct/Business Lead for Snowstorm In-Reply-To: <478932.95415.qm@web23906.mail.ird.yahoo.com> References: <478932.95415.qm@web23906.mail.ird.yahoo.com> Message-ID: <3C878C24-60FE-4759-B968-86F90E71A86F@lindenlab.com> On Feb 9, 2011, at 10:37 PM, Hitomi Tiponi wrote: > Is there any news on when Snowstorm will be getting a new Product/Business Lead (it is still listed as Esbee on the wiki) or who is dealing with such matters in the interim? > For the time being, it's me. We'll let you know when that changes. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110209/36d23542/attachment.htm From merov at lindenlab.com Wed Feb 9 22:20:43 2011 From: merov at lindenlab.com (Merov Linden) Date: Thu, 10 Feb 2011 06:20:43 -0000 Subject: [opensource-dev] Review Request: CMAKE_EXE_LINKER_FLAGS not honored when linking the viewer binary if -DLL_TESTS:BOOL=ON Message-ID: <20110210062043.28782.113@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/147/ ----------------------------------------------------------- Review request for Viewer. Summary ------- >From Aleric's patch: Setting CMAKE_EXE_LINKER_FLAGS to "" because the tests "need" that is pretty hard measure. Not only is it not necessary to do so, it also changes how the viewer is linked depending on a whether or not the tests are compiled and that is not good. The reason that this was needed is that libgmock is underlinked (see http://wiki.mandriva.com/en/Underlinking), which is not compatible with -Wl,--as-needed that is being used on linux. libgmock.so.0 needs a symbol that is defined in libgtest.so.o, but -lgtest was not passed to the linker when creating libgmock.so.0: Underlinked (no libgtest.so.o): $ objdump -p /usr/lib/libgmock.so.0 | grep NEEDED NEEDED libstdc++.so.6 NEEDED libm.so.6 NEEDED libc.so.6 NEEDED libgcc_s.so.1 The solution is to wrap between -Wl,--no-as-needed -lgtest -Wl,--as-needed causing it to be added again. This is only needed on linux, since that the only platform that we use -Wl,--as-needed on. Moreover, we can just set GOOGLEMOCK_LIBRARIES to "gmock -Wl,--no-as-needed gtest -Wl,--as-needed" since that is only passed to TARGET_LINK_LIBRARIES which only adds -l in front of 'things' that don't start with '-', to allow you do pass special flags like this. This addresses bug STORM-981. http://jira.secondlife.com/browse/STORM-981 Diffs ----- doc/contributions.txt 27dae7b01a81 indra/cmake/GoogleMock.cmake 27dae7b01a81 indra/cmake/LLAddBuildTest.cmake 27dae7b01a81 Diff: http://codereview.secondlife.com/r/147/diff Testing ------- Thanks, Merov -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110210/a0049d2a/attachment.htm From sllists at boroon.dasgupta.ch Thu Feb 10 02:02:38 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Thu, 10 Feb 2011 10:02:38 -0000 Subject: [opensource-dev] Review Request: CMAKE_EXE_LINKER_FLAGS not honored when linking the viewer binary if -DLL_TESTS:BOOL=ON In-Reply-To: <20110210062043.28782.113@domU-12-31-38-00-90-68.compute-1.internal> References: <20110210062043.28782.113@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110210100238.5226.92616@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/147/#review350 ----------------------------------------------------------- A good change to avoid heisenbugs. indra/cmake/GoogleMock.cmake Don't mix spaces and tabs. (Use spaces here, like in the rest of the file.) indra/cmake/GoogleMock.cmake I'd put the -Wl,--no-as-needed down on gtest's line, so that the "wrapping" is more obvious. Or maybe even use some creative indentation like: # ... if (LINUX) set(GOOGLEMOCK_LIBRARIES gmock -Wl,--no-as-needed # VWR-24366: gmock is underlinked, it needs gtest. gtest -Wl,--as-needed) # continue to use "as-needed" for other libs elseif(WINDOWS) # ... - Boroondas On Feb. 9, 2011, 10:20 p.m., Merov Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/147/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2011, 10:20 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > From Aleric's patch: > > Setting CMAKE_EXE_LINKER_FLAGS to "" because the tests "need" that is pretty hard measure. Not only is it not necessary to do so, it also changes how the viewer is linked depending on a whether or not the tests are compiled and that is not good. > > The reason that this was needed is that libgmock is underlinked (see http://wiki.mandriva.com/en/Underlinking), which is not compatible with -Wl,--as-needed that is being used on linux. libgmock.so.0 needs a symbol that is defined in libgtest.so.o, but -lgtest was not passed to the linker when creating libgmock.so.0: > > Underlinked (no libgtest.so.o): > $ objdump -p /usr/lib/libgmock.so.0 | grep NEEDED > NEEDED libstdc++.so.6 > NEEDED libm.so.6 > NEEDED libc.so.6 > NEEDED libgcc_s.so.1 > > The solution is to wrap between -Wl,--no-as-needed -lgtest -Wl,--as-needed causing it to be added again. This is only needed on linux, since that the only platform that we use -Wl,--as-needed on. Moreover, we can just set GOOGLEMOCK_LIBRARIES to "gmock -Wl,--no-as-needed gtest -Wl,--as-needed" since that is only passed to TARGET_LINK_LIBRARIES which only adds -l in front of 'things' that don't start with '-', to allow you do pass special flags like this. > > > This addresses bug STORM-981. > http://jira.secondlife.com/browse/STORM-981 > > > Diffs > ----- > > doc/contributions.txt 27dae7b01a81 > indra/cmake/GoogleMock.cmake 27dae7b01a81 > indra/cmake/LLAddBuildTest.cmake 27dae7b01a81 > > Diff: http://codereview.secondlife.com/r/147/diff > > > Testing > ------- > > > Thanks, > > Merov > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110210/521082c6/attachment-0001.htm From Aleric.Inglewood at gmail.com Thu Feb 10 05:15:42 2011 From: Aleric.Inglewood at gmail.com (Aleric Inglewood) Date: Thu, 10 Feb 2011 13:15:42 -0000 Subject: [opensource-dev] Review Request: CMAKE_EXE_LINKER_FLAGS not honored when linking the viewer binary if -DLL_TESTS:BOOL=ON In-Reply-To: <20110210100238.5226.92616@domU-12-31-38-00-90-68.compute-1.internal> References: <20110210100238.5226.92616@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110210131542.28782.59140@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 10, 2011, 2:02 a.m., Boroondas Gupte wrote: > > indra/cmake/GoogleMock.cmake, lines 13-14 > > > > > > I'd put the > > -Wl,--no-as-needed > > down on gtest's line, so that the "wrapping" is more obvious. Or maybe even use some creative indentation like: > > # ... > > if (LINUX) > > set(GOOGLEMOCK_LIBRARIES > > gmock > > -Wl,--no-as-needed # VWR-24366: gmock is underlinked, it needs gtest. > > gtest > > -Wl,--as-needed) # continue to use "as-needed" for other libs > > elseif(WINDOWS) > > # ... I don't think you can add comments like that in the middle of a SET( ... # ... ) ? Never tried it though. If GOOGLEMOCK_LIBRARIES would end up like "gmock -Wl,--no-as-needed # VWR-24366: gmock is underlinked, it needs gtest. gtest -Wl,--as-needed" then that definitely will break things ;) @merov: https://codereview.secondlife.com/r/95/ is still open and present on this reviewboard. It's about this same patch? - Aleric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/147/#review350 ----------------------------------------------------------- On Feb. 9, 2011, 10:20 p.m., Merov Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/147/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2011, 10:20 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > From Aleric's patch: > > Setting CMAKE_EXE_LINKER_FLAGS to "" because the tests "need" that is pretty hard measure. Not only is it not necessary to do so, it also changes how the viewer is linked depending on a whether or not the tests are compiled and that is not good. > > The reason that this was needed is that libgmock is underlinked (see http://wiki.mandriva.com/en/Underlinking), which is not compatible with -Wl,--as-needed that is being used on linux. libgmock.so.0 needs a symbol that is defined in libgtest.so.o, but -lgtest was not passed to the linker when creating libgmock.so.0: > > Underlinked (no libgtest.so.o): > $ objdump -p /usr/lib/libgmock.so.0 | grep NEEDED > NEEDED libstdc++.so.6 > NEEDED libm.so.6 > NEEDED libc.so.6 > NEEDED libgcc_s.so.1 > > The solution is to wrap between -Wl,--no-as-needed -lgtest -Wl,--as-needed causing it to be added again. This is only needed on linux, since that the only platform that we use -Wl,--as-needed on. Moreover, we can just set GOOGLEMOCK_LIBRARIES to "gmock -Wl,--no-as-needed gtest -Wl,--as-needed" since that is only passed to TARGET_LINK_LIBRARIES which only adds -l in front of 'things' that don't start with '-', to allow you do pass special flags like this. > > > This addresses bug STORM-981. > http://jira.secondlife.com/browse/STORM-981 > > > Diffs > ----- > > doc/contributions.txt 27dae7b01a81 > indra/cmake/GoogleMock.cmake 27dae7b01a81 > indra/cmake/LLAddBuildTest.cmake 27dae7b01a81 > > Diff: http://codereview.secondlife.com/r/147/diff > > > Testing > ------- > > > Thanks, > > Merov > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110210/c184b385/attachment.htm From Aleric.Inglewood at gmail.com Thu Feb 10 05:42:07 2011 From: Aleric.Inglewood at gmail.com (Aleric Inglewood) Date: Thu, 10 Feb 2011 13:42:07 -0000 Subject: [opensource-dev] Review Request: CMAKE_EXE_LINKER_FLAGS not honored when linking the viewer binary if -DLL_TESTS:BOOL=ON In-Reply-To: <20110210100238.5226.92616@domU-12-31-38-00-90-68.compute-1.internal> References: <20110210100238.5226.92616@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110210134207.28779.37812@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 10, 2011, 2:02 a.m., Boroondas Gupte wrote: > > indra/cmake/GoogleMock.cmake, lines 13-14 > > > > > > I'd put the > > -Wl,--no-as-needed > > down on gtest's line, so that the "wrapping" is more obvious. Or maybe even use some creative indentation like: > > # ... > > if (LINUX) > > set(GOOGLEMOCK_LIBRARIES > > gmock > > -Wl,--no-as-needed # VWR-24366: gmock is underlinked, it needs gtest. > > gtest > > -Wl,--as-needed) # continue to use "as-needed" for other libs > > elseif(WINDOWS) > > # ... > > Aleric Inglewood wrote: > I don't think you can add comments like that in the middle of a SET( ... # ... ) ? Never tried it though. > If GOOGLEMOCK_LIBRARIES would end up like "gmock -Wl,--no-as-needed # VWR-24366: gmock is underlinked, it needs gtest. gtest -Wl,--as-needed" then that definitely will break things ;) > > @merov: https://codereview.secondlife.com/r/95/ is still open and present on this reviewboard. It's about this same patch? > Also, I think that what merov is looking for is someone who builds on linux (standalone or not) to actually test this patch... since building is the only thing that is influenced. Since a TC build doesn't set CMAKE_EXE_LINKER_FLAGS, you probably should be someone who builds standalone and sets CMAKE_EXE_LINKER_FLAGS. Alternatively, you can fake setting it (just add "-Lhello_world" for example) and confirm that survives with patch. A positive test of the patch would need you to install any needed libs in a non-default path that actually need that -Lpath and check that the viewer doesn't link anymore without the patch, but does with. In all cases makes sure you have LL_TESTS on. I'll add a full test plan to http://jira.secondlife.com/browse/STORM-981 - Aleric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/147/#review350 ----------------------------------------------------------- On Feb. 9, 2011, 10:20 p.m., Merov Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/147/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2011, 10:20 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > From Aleric's patch: > > Setting CMAKE_EXE_LINKER_FLAGS to "" because the tests "need" that is pretty hard measure. Not only is it not necessary to do so, it also changes how the viewer is linked depending on a whether or not the tests are compiled and that is not good. > > The reason that this was needed is that libgmock is underlinked (see http://wiki.mandriva.com/en/Underlinking), which is not compatible with -Wl,--as-needed that is being used on linux. libgmock.so.0 needs a symbol that is defined in libgtest.so.o, but -lgtest was not passed to the linker when creating libgmock.so.0: > > Underlinked (no libgtest.so.o): > $ objdump -p /usr/lib/libgmock.so.0 | grep NEEDED > NEEDED libstdc++.so.6 > NEEDED libm.so.6 > NEEDED libc.so.6 > NEEDED libgcc_s.so.1 > > The solution is to wrap between -Wl,--no-as-needed -lgtest -Wl,--as-needed causing it to be added again. This is only needed on linux, since that the only platform that we use -Wl,--as-needed on. Moreover, we can just set GOOGLEMOCK_LIBRARIES to "gmock -Wl,--no-as-needed gtest -Wl,--as-needed" since that is only passed to TARGET_LINK_LIBRARIES which only adds -l in front of 'things' that don't start with '-', to allow you do pass special flags like this. > > > This addresses bug STORM-981. > http://jira.secondlife.com/browse/STORM-981 > > > Diffs > ----- > > doc/contributions.txt 27dae7b01a81 > indra/cmake/GoogleMock.cmake 27dae7b01a81 > indra/cmake/LLAddBuildTest.cmake 27dae7b01a81 > > Diff: http://codereview.secondlife.com/r/147/diff > > > Testing > ------- > > > Thanks, > > Merov > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110210/dc34e5ea/attachment.htm From akanevsky at productengine.com Thu Feb 10 14:21:47 2011 From: akanevsky at productengine.com (Anya Kanevsky) Date: Thu, 10 Feb 2011 14:21:47 -0800 Subject: [opensource-dev] Daily Scrum Summary - Thursday, February 10 Message-ID: Thursday, February 10 [edit ]General Notes ------------------------------ - MMOTD: Merov - SNOW project is archived. Thank you to all who made it happen! [edit ]Team Status ------------------------------ [edit ]Merov Linden ------------------------------ *PAST* - MM: Pushed 6 pending JIRAs + STORM-986. Mac freeze issue didn't repro. Seemed to be related to cache issues. - STORM-937 : Path to python in /scripts/*.py file inconsistent : updated wiki again, post new RB, tested build on TC but fails on Windows (build.sh issue) - STORM-981: Linux link issue if -DLL_TESTS:BOOL=ON : Posted patch and RB, builds on TC, moved to review. - STORM-987 : llimage_libtest : created that task that needs to happen before STORM-746. Created first skeleton for those (cmake, etc...). - Attended "Open Development User Group": triaged OPEN issues *FUTURE* - MM - STORM-937 : Fix the build.sh issue - STORM-987 : llimage_libtest: Post first implementation *IMPEDIMENTS* - None [edit ]Oz Linden ------------------------------ *PAST* - Open Development User Group meeting - Great triage of build issues - Much work on rolling out User Groups - Some not very successful work on open-4 *FUTURE* - VWR issue triage - Create wiki page on building viewer w/ autobuild - Associated environment setup pages *IMPEDIMENTS* - none [edit ]Q Linden ------------------------------ *PAST* - documentation / blog - internal meetings *FUTURE* - release - triage *IMPEDIMENTS* - none [edit ]Wolf Linden ------------------------------ *PAST* - went through all jira in needs-design queue and commented *FUTURE* - STORM-951 *IMPEDIMENTS* - none [edit ]Grumpity ProductEngine ------------------------------ *PAST* - jira - ooo *FUTURE* - STORM cleanup in jira - QA updates - triage - request jira modifications - look through wolf?s comments *IMPEDIMENTS* - none [edit ]Paul Productengine ------------------------------ *PAST* - BUG STORM-357 (Gestures button is in the pressed state after drag-n-drop but gestures list isn't visible) - Fixed and sent for review *FUTURE* - BUG STORM-533 (User is unable to save snapshot after pressing "More" and "Less" (without any changes) *IMPEDIMENTS* - none [edit ]Seth Productengine ------------------------------ *PAST* - BUG (STORM-833) "i" button is overlaid with Group Members name - Fixed. Posted fix for review. - Code review *FUTURE* - BUG (STORM-939) Opening multiple inventory floaters causes viewer to lag or even crash - Estimated: 10-12 hours. *IMPEDIMENTS* - none [edit ]Vadim Productengine ------------------------------ - OOO - vacation [edit ]Andrey ProductEngine ------------------------------ *PAST* - verified 18 issues - continued regression testing of v-d branch: - My Landmarks Panel (100%) - Teleport History Panel (100%) - Alerts & Notifications (~50%) - Busy mode (100%) - SideBar Basics (100%) - Chiclets and Chiclet Windows basics - 100% - Alerts & Notifications - 40% - Home Panel - 100% - Nearby People Panel 100% - Groups Panel 100% - Group Profile Panel 100% - Recent People Panel 100% *FUTURE* - continue regression testing - update Build tools TP *IMPEDIMENTS* - none [edit ]Jonathan Yap ------------------------------ *PAST* - STORM-976 (Object muted by name still displays notification message when clicked) - Depending on how STORM-951 is fixed nothing may need to be done to close this jira. - STORM-979 (selection outline from inventory bottom panel buttons is cut at the left side when clicked.) *FUTURE* - STORM - 979 *IMPEDIMENTS* - none [edit ]Cummere Mayo ------------------------------ *PAST* - jira stuff - working on a cookies jira - snow is ready for archival!!!! *FUTURE* - finsihing that jira - working on one on the remergance of the bug where you take off a bunch of items, then wear a piece of clothing and it puts back on what you just took off - working on blog regarding need for accesibility features like being able to have a chatbar on bottom of undocked local chat window *IMPEDIMENTS* - frustrated -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110210/b15fd45e/attachment-0001.htm From oz at lindenlab.com Thu Feb 10 18:03:23 2011 From: oz at lindenlab.com (Oz Linden) Date: Fri, 11 Feb 2011 02:03:23 -0000 Subject: [opensource-dev] Review Request: Use consistent path for all *.py scripts In-Reply-To: <20110209233347.5226.38891@domU-12-31-38-00-90-68.compute-1.internal> References: <20110209233347.5226.38891@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110211020323.29364.72835@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/129/#review353 ----------------------------------------------------------- Ship it! Those changes look good. For future reference, there's no reason to add date ranges in Copyright headers - the only year needed is the year of first publication. Adding additional years is not needed and serves no purpose. - Oz On Feb. 9, 2011, 3:33 p.m., Merov Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/129/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2011, 3:33 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Simple consistency change, using "#!/usr/bin/python" in all python script. > > > This addresses bug STORM-937. > http://jira.secondlife.com/browse/STORM-937 > > > Diffs > ----- > > indra/cmake/run_build_test.py 0ca239e469b3 > indra/copy_win_scripts/start-client.py 0ca239e469b3 > indra/develop.py 0ca239e469b3 > indra/lib/python/indra/util/llperformance.py 0ca239e469b3 > indra/lib/python/indra/util/simperf_proc_interface.py 0ca239e469b3 > indra/lib/python/indra/util/test_win32_manifest.py 0ca239e469b3 > indra/llmessage/tests/test_llsdmessage_peer.py 0ca239e469b3 > indra/llmessage/tests/testrunner.py 0ca239e469b3 > indra/newview/generate_breakpad_symbols.py 0ca239e469b3 > indra/newview/tests/test_llxmlrpc_peer.py 0ca239e469b3 > indra/newview/viewer_manifest.py 0ca239e469b3 > indra/test/test_llmanifest.py 0ca239e469b3 > scripts/build_version.py 0ca239e469b3 > scripts/md5check.py 0ca239e469b3 > scripts/setup-path.py 0ca239e469b3 > scripts/template_verifier.py 0ca239e469b3 > scripts/update_version_files.py 0ca239e469b3 > > Diff: http://codereview.secondlife.com/r/129/diff > > > Testing > ------- > > Pulled into a test repo and build successfully on all platforms on TC so I guess no bad surprise here. > > > Thanks, > > Merov > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110211/91339b48/attachment.htm From jhwelch at gmail.com Fri Feb 11 01:41:22 2011 From: jhwelch at gmail.com (Jonathan Welch) Date: Fri, 11 Feb 2011 04:41:22 -0500 Subject: [opensource-dev] autobuild-built viewer - LL_RELEASE_FOR_DOWNLOAD is not set to TRUE Message-ID: I would like some other people who are helping test autobuild to verify if the compile-time setting LL_RELEASE_FOR_DOWNLOAD is not set to TRUE, especially if you are building on a different os/platform than I am. This seems to be the case for me in Win XP + VS2005 Express. I added my own conditional test to the code to print out it's value after troubleshooting why I was getting a debug console window popping up as soon as I started the viewer. Please comment in https://jira.secondlife.com/browse/OPEN-30 Thank you, -jonathan From sllists at boroon.dasgupta.ch Fri Feb 11 06:04:55 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Fri, 11 Feb 2011 14:04:55 -0000 Subject: [opensource-dev] Review Request: OPEN-29: Error out if lldir_.h is included when building for a different platform. Message-ID: <20110211140455.29549.72532@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/148/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Rather than relying on (probably anyway accidental) on syntax incompatibilities, added explicit #error to the indra/llvfs/lldir_*.h headers. In separate commits, but also in the diff for review here, removed one such syntax incompatibility (https://bitbucket.org/boroondas/open-29/changeset/19ab94811717) and did some cleanup (superfluous "public:"s, trailing whitespace). This addresses bug OPEN-29. http://jira.secondlife.com/browse/OPEN-29 Diffs ----- doc/contributions.txt ec4ad7e3ecca indra/llvfs/lldir_linux.h ec4ad7e3ecca indra/llvfs/lldir_mac.h ec4ad7e3ecca indra/llvfs/lldir_solaris.h ec4ad7e3ecca indra/llvfs/lldir_win32.h ec4ad7e3ecca Diff: http://codereview.secondlife.com/r/148/diff Testing ------- Built on Linux before pulling https://bitbucket.org/lindenlab/viewer-development/changeset/7a1440277911 * Errors out as wanted. Build on Linux after pulling 7a1440277911 * Builds like normal. Note: These tests were done with other build fixes present * for VWR-24520 https://codereview.secondlife.com/r/97/ * for VWR-24487 https://codereview.secondlife.com/r/100/ not on a pristine source tree. Thanks, Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110211/d28dec54/attachment.htm From sllists at boroon.dasgupta.ch Fri Feb 11 06:07:06 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Fri, 11 Feb 2011 14:07:06 -0000 Subject: [opensource-dev] Review Request: OPEN-29: Error out if lldir_.h is included when building for a different platform. In-Reply-To: <20110211140455.29549.72532@domU-12-31-38-00-90-68.compute-1.internal> References: <20110211140455.29549.72532@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110211140706.29081.72898@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/148/ ----------------------------------------------------------- (Updated Feb. 11, 2011, 6:07 a.m.) Review request for Viewer. Changes ------- (just edited description, so that the link there works) Summary (updated) ------- Rather than relying on (probably anyway accidental) on syntax incompatibilities, added explicit #error to the indra/llvfs/lldir_*.h headers. In separate commits, but also in the diff for review here, removed one such syntax incompatibility (https://bitbucket.org/boroondas/open-29/changeset/19ab94811717 ) and did some cleanup (superfluous "public:"s, trailing whitespace). This addresses bug OPEN-29. http://jira.secondlife.com/browse/OPEN-29 Diffs ----- doc/contributions.txt ec4ad7e3ecca indra/llvfs/lldir_linux.h ec4ad7e3ecca indra/llvfs/lldir_mac.h ec4ad7e3ecca indra/llvfs/lldir_solaris.h ec4ad7e3ecca indra/llvfs/lldir_win32.h ec4ad7e3ecca Diff: http://codereview.secondlife.com/r/148/diff Testing ------- Built on Linux before pulling https://bitbucket.org/lindenlab/viewer-development/changeset/7a1440277911 * Errors out as wanted. Build on Linux after pulling 7a1440277911 * Builds like normal. Note: These tests were done with other build fixes present * for VWR-24520 https://codereview.secondlife.com/r/97/ * for VWR-24487 https://codereview.secondlife.com/r/100/ not on a pristine source tree. Thanks, Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110211/d68b4d19/attachment.htm From akanevsky at productengine.com Fri Feb 11 14:06:15 2011 From: akanevsky at productengine.com (Anya Kanevsky) Date: Fri, 11 Feb 2011 14:06:15 -0800 Subject: [opensource-dev] Daily Scrum Summary - Friday, February 11 Message-ID: Friday, February 11 [edit ]General Notes ------------------------------ - MMOTD: Merov -> Oz [edit ]Team Status ------------------------------ [edit ]Merov Linden ------------------------------ *PAST* - STORM-987 : llimage_libtest : Image loading done, need to add image saving. Noted quite a few issues in llimage related code while doing that. Quite a few JIRAs to log now. - MM : STORM-986 integration broke build on Linux. Fixed. Made PO build. - VWR triage *FUTURE* - MM - STORM-937 : Path to python in /scripts/*.py file inconsistent : Fix the build.sh issue (I've a Windows machine today) - STORM-987 : llimage_libtest: Post first implementation *IMPEDIMENTS* - None [edit ]Oz Linden ------------------------------ *PAST* - VWR issue triage - Much work on rolling out User Groups - Published my tools repo on http://bitbucket.org/oz_linden/tools - Handed off OPEN-4 to Merov *FUTURE* - Merge Monkey? - Integrate pending VS Express changes - Create wiki page on building viewer w/ autobuild - Associated environment setup pages *IMPEDIMENTS* - none [edit ]Q Linden ------------------------------ - OOO - sick [edit ]Wolf Linden ------------------------------ *PAST* - Snowstorm VWR tirage *FUTURE* - VWR-24752 - New Jira items needing design *IMPEDIMENTS* - need to meet with Q re keyboard shortcuts [edit ]Grumpity ProductEngine ------------------------------ *PAST* - QA updates - VWR triage - jira modifications *FUTURE* - STORM cleanup in jira - look through wolf?s comments - crashhunters - test PO build *IMPEDIMENTS* - none [edit ]Paul Productengine ------------------------------ *PAST* - BUG STORM-951 (Accidental Self-Muting/Self-Blocking) - WIP. Investigating & working on implementation according to Jonathan Yap comments. His suggestions are reasonable. Estimate ~8h. *FUTURE* - BUG STORM-951 (Accidental Self-Muting/Self-Blocking) *IMPEDIMENTS* - none [edit ]Seth Productengine ------------------------------ *PAST* - BUG (VWR-22620) Error not handled gracefully in landmark creation - Could not reproduce the issue and didn't figure out why it had been reopened. Moved to unassigned. - Created: BUG (STORM-988) The "i" button disappears when a name list is scrolled down with the mouse wheel - BUG (STORM-939) Opening multiple inventory floaters causes viewer to lag or even crash - Investigating opening multiple inventory floaters with storm-2 functionality. Opening 10 floaters at once caused a slight freeze for about 2-3 seconds and no crash. Looking for some points to optimize in code. *FUTURE* - BUG (STORM-939) Opening multiple inventory floaters causes viewer to lag or even crash - Estimated: 8-10 hours. *IMPEDIMENTS* - none [edit ]Vadim Productengine ------------------------------ - OOO - vacation [edit ]Andrey ProductEngine ------------------------------ *PAST* - verified 10 integrated issues - revised Build Tools test plan - reported issues VWR-24797 and VWR-24798 - continued v-d regression testing https://spreadsheets.google.com/a/productengine.com/ccc?key=0AsjYANl9JgoKdHlnSUJ1cndMd0lWdERXN2YzVzdOY1E&hl=en#gid=4 *FUTURE* - complete regression pass against v-d *IMPEDIMENTS* - none [edit ]Wolfpup Lowenhar ------------------------------ *PAST* - RL work - Be at Hospital while roommate was in surgery. - STORM-236 : Tested patch from Richard on local repository and received new graphic from Wolf Linden. Also sent Richard email about how to get panel to actually show as it is still not doing this. *FUTURE* - RL work - STORM-941 : email Oz and Leyla concerning possible areas that could be causing the problem.(still need to do this) *IMPEDIMENTS* - STORM-236 : waiting reply from Richard. - Not enough time to actually work on code. - Roommate in hospital(should be getting out soon though). - Temporary loss of Internet(unable to connect for two day but back now) [edit ]Jonathan Yap ------------------------------ *PAST* - STORM-979 (selection outline from inventory bottom panel buttons is cut at the left side when clicked.) - Done - STORM-980 (Appearance panel / Wear button is too wide) - Done - autobuild testing, fixing, bug reporting (OPEN-30) - STORM-956 (Ability to mute dialogs by muting object (or object owner)) - As this is related to two other jiras in work right now I thought I'd look into it. *FUTURE* - STORM - 956 *IMPEDIMENTS* - none - Observation: - I think "needs design" can now be cleared on STORM-951 - Wolf, if you comment on that vwr- issue and say "go ahead" can it be brought into STORM- ? [edit ]Cummere Mayo ------------------------------ *PAST* - attempting to get a ca for the patch given for VWR-24633 - filed VWR-24807, VWR-24805, VWR-24804 - tested "fix" for web-3600 *FUTURE* - blog - test new v-d build *IMPEDIMENTS* - connectivity issues with SL - wolf are we still on for today? - -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110211/f2a686c7/attachment-0001.htm From angel_of_crimson at hotmail.com Fri Feb 11 16:04:39 2011 From: angel_of_crimson at hotmail.com (Erin Mallory) Date: Fri, 11 Feb 2011 19:04:39 -0500 Subject: [opensource-dev] [viewer-development-builds] Successful Build Nr. 220951 for snowstorm_viewer-development (a2773f1fdfcf) on CYGWIN In-Reply-To: <20110211180437.19B12E2CE1A@viognier.lindenlab.com> References: <20110211180437.19B12E2CE1A@viognier.lindenlab.com> Message-ID: Failing the windows build. it refuses to stay connected and I'm not having this issue with any other build. I can't even tell from the logs whats disconnecting it... > To: viewer-development-builds at lists.secondlife.com > Date: Fri, 11 Feb 2011 10:04:37 -0800 > From: viewer-development-builds at lists.secondlife.com > Subject: [viewer-development-builds] Successful Build Nr. 220951 for snowstorm_viewer-development (a2773f1fdfcf) on CYGWIN > > > > urls: > installer_CYGWIN: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/snowstorm_viewer-development/rev/220951/arch/CYGWIN/installer/Second_Life_2-6-0-220951_Development_Setup.exe > quicklink_CYGWIN: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/snowstorm_viewer-development/arch/CYGWIN/quicklink.html > log_CYGWIN: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/snowstorm_viewer-development/rev/220951/arch/CYGWIN/log/build_log.345.txt > buildparams_CYGWIN: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/snowstorm_viewer-development/rev/220951/arch/CYGWIN/buildparams/BuildScript.sh > > urls: > installer_Linux: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/snowstorm_viewer-development/rev/220951/arch/Linux/installer/SecondLife-i686-2.6.0.220951.tar.bz2 > quicklink_Linux: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/snowstorm_viewer-development/arch/Linux/quicklink.html > log_Linux: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/snowstorm_viewer-development/rev/220951/arch/Linux/log/build_log.291.txt > buildparams_Linux: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/snowstorm_viewer-development/rev/220951/arch/Linux/buildparams/BuildScript.sh > > urls: > installer_Darwin: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/snowstorm_viewer-development/rev/220951/arch/Darwin/installer/SecondLife_2_6_0_220951_DEVELOPMENT.dmg > quicklink_Darwin: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/snowstorm_viewer-development/arch/Darwin/quicklink.html > log_Darwin: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/snowstorm_viewer-development/rev/220951/arch/Darwin/log/build_log.292.txt > buildparams_Darwin: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/snowstorm_viewer-development/rev/220951/arch/Darwin/buildparams/BuildScript.sh > > > All Build Products: > S3: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/snowstorm_viewer-development/rev/220951/index.html > _______________________________________________ > Click here to unsubscribe or manage your list subscription: > https://lists.secondlife.com/cgi-bin/mailman/listinfo/viewer-development-builds -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110211/c46df6b4/attachment.htm From bryon at slearth.com Fri Feb 11 16:26:52 2011 From: bryon at slearth.com (Bryon Ruxton) Date: Fri, 11 Feb 2011 16:26:52 -0800 Subject: [opensource-dev] llRegionSay() vs. HTTP-In Message-ID: Slightly off topic, but I have a region performance question: From jenn at lindenlab.com Fri Feb 11 17:52:26 2011 From: jenn at lindenlab.com (Jenn) Date: Sat, 12 Feb 2011 01:52:26 -0000 Subject: [opensource-dev] Review Request: OPEN-8: allow specification of the configuration with env var AUTOBUILD_CONFIGURATION In-Reply-To: <20110208173709.29081.87977@domU-12-31-38-00-90-68.compute-1.internal> References: <20110208173709.29081.87977@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110212015226.29081.68428@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 8, 2011, 9:37 a.m., Alain Linden wrote: > > I'm not sure AUTOBUILD_CONFIGURATION is a good name for this environment variable. I know this is long, but AUTOUBUILD_DEFAULT_BUILD_CONFIGURATIONS is more accurate and descriptive (and one could probably drop the AUTOBUILD if we aren't too worried about conflicts with other env variable names) > > Oz Linden wrote: > The name was chosen to match that of the long-form option that it provides the default value for. Using the AUTOBUILD_ prefix is just good practice, because collisions are a serious issue not to be ignored. > I note that 'default' is generally the name of one of the configurations in the config file (i.e. autobuild.xml). Given that and oz's pattern of naming environment variables after the option names, I'd go with the AUTOBUILD_CONFIGURATION nomenclature. I'd want to be a bit careful about populating the env var space much further than this, but what you've done here so far seems fine to me. - Jenn ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/141/#review342 ----------------------------------------------------------- On Feb. 6, 2011, 8:01 p.m., Oz Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/141/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2011, 8:01 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > This patch adds support for specifying the configurations using the AUTOBUILD_CONFIGURATION environment variable (multiple configurations can be specified using commas to separate the values). > > > This addresses bug open-8. > > > Diffs > ----- > > autobuild/autobuild_base.py 9ee2db08d677 > autobuild/autobuild_tool_build.py 9ee2db08d677 > autobuild/autobuild_tool_configure.py 9ee2db08d677 > > Diff: http://codereview.secondlife.com/r/141/diff > > > Testing > ------- > > Tested manually with and without the command line argument, and with and without the environment variable set; the appropriate configuration values were used. > > > Thanks, > > Oz > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110212/51139a4c/attachment.htm From jenn at lindenlab.com Fri Feb 11 17:52:42 2011 From: jenn at lindenlab.com (Jenn) Date: Sat, 12 Feb 2011 01:52:42 -0000 Subject: [opensource-dev] Review Request: OPEN-8: allow specification of the configuration with env var AUTOBUILD_CONFIGURATION In-Reply-To: <20110207040157.29444.20926@domU-12-31-38-00-90-68.compute-1.internal> References: <20110207040157.29444.20926@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110212015242.28779.28969@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/141/#review355 ----------------------------------------------------------- Ship it! - Jenn On Feb. 6, 2011, 8:01 p.m., Oz Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/141/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2011, 8:01 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > This patch adds support for specifying the configurations using the AUTOBUILD_CONFIGURATION environment variable (multiple configurations can be specified using commas to separate the values). > > > This addresses bug open-8. > > > Diffs > ----- > > autobuild/autobuild_base.py 9ee2db08d677 > autobuild/autobuild_tool_build.py 9ee2db08d677 > autobuild/autobuild_tool_configure.py 9ee2db08d677 > > Diff: http://codereview.secondlife.com/r/141/diff > > > Testing > ------- > > Tested manually with and without the command line argument, and with and without the environment variable set; the appropriate configuration values were used. > > > Thanks, > > Oz > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110212/00afd38c/attachment.htm From jenn at lindenlab.com Fri Feb 11 17:52:51 2011 From: jenn at lindenlab.com (Jenn) Date: Sat, 12 Feb 2011 01:52:51 -0000 Subject: [opensource-dev] Review Request: OPEN-7: allow specification of the config-file with env var AUTOBUILD_CONFIG_FILE In-Reply-To: <20110207013922.29474.12564@domU-12-31-38-00-90-68.compute-1.internal> References: <20110207013922.29474.12564@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110212015251.28828.93782@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/140/#review356 ----------------------------------------------------------- Ship it! - Jenn On Feb. 6, 2011, 5:39 p.m., Oz Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/140/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2011, 5:39 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > This change allows the environment variable AUTOBUILD_CONFIG_FILE to specify a default config-file, so that the precedence becomes: > > 1. the --config-file command line option > 2. the environment variable AUTOBUILD_CONFIG_FILE > 3. "autobuild.xml" > > It also adds an info-level (--verbose) display of the config file name that is being loaded, and a warning level display if the config file does not exist. > > > This addresses bug open-7. > > > Diffs > ----- > > autobuild/autobuild_tool_build.py 9ee2db08d677 > autobuild/autobuild_tool_configure.py 9ee2db08d677 > autobuild/autobuild_tool_edit.py 9ee2db08d677 > autobuild/autobuild_tool_install.py 9ee2db08d677 > autobuild/autobuild_tool_installables.py 9ee2db08d677 > autobuild/autobuild_tool_manifest.py 9ee2db08d677 > autobuild/autobuild_tool_package.py 9ee2db08d677 > autobuild/autobuild_tool_print.py 9ee2db08d677 > autobuild/autobuild_tool_uninstall.py 9ee2db08d677 > autobuild/configfile.py 9ee2db08d677 > > Diff: http://codereview.secondlife.com/r/140/diff > > > Testing > ------- > > Manually tested with and without the command line option, and with and without the environment variable set: confirmed that the correct file name is used per the precedence above. > > Confirmed that the new logging works correctly. > > > Thanks, > > Oz > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110212/ea8a5bc5/attachment-0001.htm From merov at lindenlab.com Fri Feb 11 18:23:32 2011 From: merov at lindenlab.com (Merov Linden) Date: Sat, 12 Feb 2011 02:23:32 -0000 Subject: [opensource-dev] Review Request: Use consistent path for all *.py scripts In-Reply-To: <20110209233347.5226.38891@domU-12-31-38-00-90-68.compute-1.internal> References: <20110209233347.5226.38891@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110212022332.29081.37697@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/129/ ----------------------------------------------------------- (Updated Feb. 11, 2011, 6:23 p.m.) Review request for Viewer. Changes ------- The previous change revealed issues on Windows, namely, the use of the commands module on Windows in llversion.py. I changed that to use subprocess instead and cleaned up old svn functions rather than "fixing" them. Summary ------- Simple consistency change, using "#!/usr/bin/python" in all python script. This addresses bug STORM-937. http://jira.secondlife.com/browse/STORM-937 Diffs (updated) ----- indra/cmake/run_build_test.py 92e58e51776a indra/copy_win_scripts/start-client.py 92e58e51776a indra/develop.py 92e58e51776a indra/lib/python/indra/util/llperformance.py 92e58e51776a indra/lib/python/indra/util/llversion.py 92e58e51776a indra/lib/python/indra/util/simperf_proc_interface.py 92e58e51776a indra/lib/python/indra/util/test_win32_manifest.py 92e58e51776a indra/llmessage/tests/test_llsdmessage_peer.py 92e58e51776a indra/llmessage/tests/testrunner.py 92e58e51776a indra/newview/generate_breakpad_symbols.py 92e58e51776a indra/newview/tests/test_llxmlrpc_peer.py 92e58e51776a indra/newview/viewer_manifest.py 92e58e51776a indra/test/test_llmanifest.py 92e58e51776a scripts/build_version.py 92e58e51776a scripts/md5check.py 92e58e51776a scripts/setup-path.py 92e58e51776a scripts/template_verifier.py 92e58e51776a scripts/update_version_files.py 92e58e51776a Diff: http://codereview.secondlife.com/r/129/diff Testing ------- Pulled into a test repo and build successfully on all platforms on TC so I guess no bad surprise here. Thanks, Merov -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110212/567501f0/attachment.htm From opensourceobscure at gmail.com Sat Feb 12 05:10:20 2011 From: opensourceobscure at gmail.com (Opensource Obscure) Date: Sat, 12 Feb 2011 14:10:20 +0100 Subject: [opensource-dev] Slowdowns with Viewer 2.5.x for Linux (getting too many data?) Message-ID: It seems that Viewer 2.5.x for Linux (both development builds and the official one that got released yesterday) don't run smoothly on my system the same way Viewer 2.4 did. Same setup, same settings, still very noticeable performances differences. Looking at Statistics bar (and the way things render in-world), it looks like feel that I'm getting too many data when entering new locations, this clogs / slows down the viewer for a few dozens of seconds. My Network/Bandwidth and Draw distance settings are default, or even less aggressive. My system is quite powerful and I usually don't get this sort of slowdowns. I still have to get more details about this. In the meantime, it would help me a lot if I could get some pointers to known existing PJIRA issues that may relate to this. Opensource Obscure http://twitter.com/oobscure - http://opensourceobscure.com/lol From jhwelch at gmail.com Sat Feb 12 05:16:50 2011 From: jhwelch at gmail.com (Jonathan Welch) Date: Sat, 12 Feb 2011 08:16:50 -0500 Subject: [opensource-dev] Slowdowns with Viewer 2.5.x for Linux (getting too many data?) In-Reply-To: References: Message-ID: Could this be related to recent server changes in the interest list, or does this not happen to you on an older viewer? http://wiki.secondlife.com/wiki/Release_Notes/Second_Life_Server/11#11.02.01.220158 From leliel.mirihi at gmail.com Sat Feb 12 05:46:45 2011 From: leliel.mirihi at gmail.com (leliel) Date: Sat, 12 Feb 2011 05:46:45 -0800 Subject: [opensource-dev] Slowdowns with Viewer 2.5.x for Linux (getting too many data?) In-Reply-To: References: Message-ID: If the viewer freezes for a few seconds ever time it loads a texture then it's probably STORM-809. From merov at lindenlab.com Sat Feb 12 08:36:05 2011 From: merov at lindenlab.com (Philippe (Merov) Bossut) Date: Sat, 12 Feb 2011 08:36:05 -0800 Subject: [opensource-dev] PO Test build Message-ID: Hi, Here's is a test build: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/221041/index.html Containing merges of the following: * STORM-357 : Gestures button is in the pressed state after drag-n-drop but gestures list isn't visible * STORM-680 : Avaline callers are added to the Recent list * STORM-939 : Opening multiple inventory floaters causes viewer to lag or even crash * STORM-974 : UI button alignment issues in Landmark panel, About Land window, and Hardware Settings window * STORM-979 : selection outline from inventory bottom panel buttons is cut at the left side when clicked. * STORM-980 : Appearance panel / Wear button is too wide * STORM-981 : CMAKE_EXE_LINKER_FLAGS not honored when linking the viewer binary if -DLL_TESTS:BOOL=ON Please report issues in the JIRA if any. Thanks for testing. Cheers, - Merov -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110212/dfbd74bf/attachment.htm From oz at lindenlab.com Sat Feb 12 13:13:29 2011 From: oz at lindenlab.com (Oz Linden) Date: Sat, 12 Feb 2011 21:13:29 -0000 Subject: [opensource-dev] Review Request: open-2 (improved progress messages during dependency checks) and open-31 (more standardized short form option switches) Message-ID: <20110212211329.5227.11074@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/150/ ----------------------------------------------------------- Review request for Viewer. Summary ------- I combined open-31 into this because that change is so small and simple that it didn't seem worth a separate commit (besides, while testing the rest of this, I really wanted the short form of --verbose). open-31 changes the short form of --version to -V, so that the short form of the more commonly used --verbose can be the lower case -v, and adds -n as a short form for --dry-run (as it is used in many versions of make, and in other commands like scp and rsync). open-2 corrects the problem that (at least in the viewer build) there is a long delay during which there are no progress messages. The delay is the configure step while packages are checked, including possibly downloading, extracting, and installing them. Increasing the logging level with the --verbose or --debug switches did not increase the amount of logging during this phase. The fundamental problem proved to be that the package checks were done in recursively invoked instances of autobuild (I am guessing that the process hierarchy is autobuild->cmake->autobuild, but it could have just been autobuild calling itself directly; this fix should work regardless of the depth of the process tree). The verbosity control options were not passed through to the child processes, and since there could be some other process in between (as cmake above), it seemed more robust (and relies less on correct configuration) to pass the verbosity control to the children through the environment. The default verbosity is now read from the AUTOBUILD_LOGGING environment variable, whose contents can be --debug, --verbose, --quiet, or the one letter forms of any of those options (if the environment variable is not set, then the default value is to log warnings and worse, as before). Any of the options used on the command line override any value from the environment. Regardless of how the verbosity level is established, the environment variable AUTOBUILD_LOGGING is set for all child processes, so that if any of those (directly or indirectly) are another invocation of autobuild, then that recursive child will use the same verbosity level as the parent (unless, of course the recursive invocation uses an explicit option). It is true that this also allows the user to set a default verbosity in the shell environment, and that works, but it wasn't really the motivation for the change and I did not add anything to the documentation about it. With that change made, the options correctly controlled whether or not logging is visible during the package checking phase. However, the resulting messages had an inconsistent level of detail - some operations (such as uninstall) were very verbose, while others (some of which might take significant time) were logged only at high verbosity levels. This led to the addition of a few short log messages at the default 'warning' level (which really has the dual meaning "something that might be a problem" and "something that should be seen at the default logging level") in order to make sure that some message is printed before any potentially long operation (downloads, extracts, installs, and uninstalls). Some other very detailed messages were changed from info to debug levels, as the information they display is really only useful when debugging either a new autobuild configuration or autobuild itself. I think that the combination of these changes makes the default verbosity reasonably informative (no long silences) without being overwhelming. (there is a failure displaying the diff for autobuild.configfile.py because it is a one word change of the logging level for a log message added by one of my other changes that has not yet been applied to the trunk) This addresses bugs open-2 and open-31. Diffs ----- autobuild/autobuild_main.py UNKNOWN autobuild/autobuild_tool_install.py UNKNOWN autobuild/common.py UNKNOWN autobuild/configfile.py UNKNOWN Diff: http://codereview.secondlife.com/r/150/diff Testing ------- Manually verified using configuring and building in viewer-autobuild Thanks, Oz -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110212/6c3b603b/attachment.htm From nickyperian at yahoo.com Sat Feb 12 16:54:59 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Sun, 13 Feb 2011 00:54:59 -0000 Subject: [opensource-dev] Review Request: open-2 (improved progress messages during dependency checks) and open-31 (more standardized short form option switches) In-Reply-To: <20110212211329.5227.11074@domU-12-31-38-00-90-68.compute-1.internal> References: <20110212211329.5227.11074@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110213005459.28753.4282@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/150/#review357 ----------------------------------------------------------- Ship it! Can this be placed as an hg changeset? I'll say Ship It in hopes a test method is forthcoming. - Nicky On Feb. 12, 2011, 1:13 p.m., Oz Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/150/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2011, 1:13 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > I combined open-31 into this because that change is so small and simple that it didn't seem worth a separate commit (besides, while testing the rest of this, I really wanted the short form of --verbose). > > open-31 changes the short form of --version to -V, so that the short form of the more commonly used --verbose can be the lower case -v, and adds -n as a short form for --dry-run (as it is used in many versions of make, and in other commands like scp and rsync). > > open-2 corrects the problem that (at least in the viewer build) there is a long delay during which there are no progress messages. The delay is the configure step while packages are checked, including possibly downloading, extracting, and installing them. Increasing the logging level with the --verbose or --debug switches did not increase the amount of logging during this phase. > > The fundamental problem proved to be that the package checks were done in recursively invoked instances of autobuild (I am guessing that the process hierarchy is autobuild->cmake->autobuild, but it could have just been autobuild calling itself directly; this fix should work regardless of the depth of the process tree). The verbosity control options were not passed through to the child processes, and since there could be some other process in between (as cmake above), it seemed more robust (and relies less on correct configuration) to pass the verbosity control to the children through the environment. > > The default verbosity is now read from the AUTOBUILD_LOGGING environment variable, whose contents can be --debug, --verbose, --quiet, or the one letter forms of any of those options (if the environment variable is not set, then the default value is to log warnings and worse, as before). Any of the options used on the command line override any value from the environment. Regardless of how the verbosity level is established, the environment variable AUTOBUILD_LOGGING is set for all child processes, so that if any of those (directly or indirectly) are another invocation of autobuild, then that recursive child will use the same verbosity level as the parent (unless, of course the recursive invocation uses an explicit option). It is true that this also allows the user to set a default verbosity in the shell environment, and that works, but it wasn't really the motivation for the change and I did not add anything to the documentation about it. > > With that change made, the options correctly controlled whether or not logging is visible during the package checking phase. However, the resulting messages had an inconsistent level of detail - some operations (such as uninstall) were very verbose, while others (some of which might take significant time) were logged only at high verbosity levels. This led to the addition of a few short log messages at the default 'warning' level (which really has the dual meaning "something that might be a problem" and "something that should be seen at the default logging level") in order to make sure that some message is printed before any potentially long operation (downloads, extracts, installs, and uninstalls). Some other very detailed messages were changed from info to debug levels, as the information they display is really only useful when debugging either a new autobuild configuration or autobuild itself. > > I think that the combination of these changes makes the default verbosity reasonably informative (no long silences) without being overwhelming. > > (there is a failure displaying the diff for autobuild.configfile.py because it is a one word change of the logging level for a log message added by one of my other changes that has not yet been applied to the trunk) > > > This addresses bugs open-2 and open-31. > > > Diffs > ----- > > autobuild/autobuild_main.py UNKNOWN > autobuild/autobuild_tool_install.py UNKNOWN > autobuild/common.py UNKNOWN > autobuild/configfile.py UNKNOWN > > Diff: http://codereview.secondlife.com/r/150/diff > > > Testing > ------- > > Manually verified using configuring and building in viewer-autobuild > > > Thanks, > > Oz > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110213/a40c85ca/attachment.htm From laurent.bechir at madonie.org Sat Feb 12 17:56:49 2011 From: laurent.bechir at madonie.org (Laurent Bechir) Date: Sun, 13 Feb 2011 02:56:49 +0100 Subject: [opensource-dev] Forum for ATI, Apple and FBO problem Message-ID: <4D573A61.8070304@madonie.org> Hello, Some time ago, I've opened a bug report on Apple website concerning the problem of ATI cards with FBO which stops Mac users to use dynamic shadows. I know they are not officials, but they work quite well with Nvidia cards :). I've received an answer recently asking me for the full System Profiler Report of my machine. I was wondering if accumulating the experiences on that subject would help make the things move faster. So I've set up a forum where mac users wanting to do it could tell their experience with ATI card and join their full System Profiler Report with their experience. I would then put the link to the forum in my bug report. Do you think this could be a good idea ? Bug report : https://bugreport.apple.com/cgi-bin/WebObjects/RadarWeb.woa/24/wo/KGyze933oURhrNytyxPfAw/5.83.28.0.9 Forum : http://macati.madonie.org/ From sllists at boroon.dasgupta.ch Sun Feb 13 03:21:23 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Sun, 13 Feb 2011 12:21:23 +0100 Subject: [opensource-dev] Review Request: open-2 (improved progress messages during dependency checks) and open-31 (more standardized short form option switches) In-Reply-To: <20110212211329.5227.11074@domU-12-31-38-00-90-68.compute-1.internal> References: <20110212211329.5227.11074@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <4D57BEB3.1060400@boroon.dasgupta.ch> On 02/12/2011 10:13 PM, Oz Linden wrote: > (there is a failure displaying the diff for autobuild.configfile.py because it is a one word change of the logging level for a log message added by one of my other changes that has not yet been applied to the trunk) You should be able use the 'Parent Diff' feature to let RB know about your other changes that have "not yet been applied to the trunk", without having it mix them into the diff to review. Here's how I think the procedure will work in detail: 1. Identify a revision that is in the repo you chose when creating the review request^[1] <#footnote1> *and* present in your local repository. I will call that revision 'common_base' from here on. * If in doubt, pull from the chosen remote repository, so you'll have the tip in common and can use that as common_base. (I don't think common_base actually has to be a common ancestor of the remote's tip and the revision you want reviewed.) 2. Identify the revision that the change to be reviewed is based on. Let's call it 'begin'. 3. Save the diff from common_base to begin as parent.diff: hg diff -r common_base -r begin > parent.diff * Of course, substitute the revisions identified above for common_base and begin, respectively. 4. I'll assume you still have the diff you uploaded when creating the review. I not, get it from https://codereview.secondlife.com/r/150/diff/raw/ (or click the *Download Diff* button) * This diff should apply cleanly on the begin revision 5. On https://codereview.secondlife.com/r/150/, click *Update Diff* 6. In the *Diff* field, choose the diff you already uploaded when creating the review 7. In the *Parent Diff* field, choose the new parent.diff file 8. Click *Upload* ------------------------------------------------------------------------ ^[1] <#footnote1_back> In your case, the one referenced by '03_autobuild', so probably https://bitbucket.org/mani_linden/viewer-autobuild Cheers, Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110213/7f9ad72b/attachment-0001.htm From trilobyte550m at gmail.com Sun Feb 13 03:47:32 2011 From: trilobyte550m at gmail.com (Trilo Byte) Date: Sun, 13 Feb 2011 03:47:32 -0800 Subject: [opensource-dev] Forum for ATI, Apple and FBO problem In-Reply-To: <4D573A61.8070304@madonie.org> References: <4D573A61.8070304@madonie.org> Message-ID: As I understand the issue, the problem is on the ATI side (possibly their implementation of OpenGL), and is not specific to Apple. On Feb 12, 2011, at 5:56 PM, Laurent Bechir wrote: > > Hello, > > Some time ago, I've opened a bug report on Apple website concerning the > problem of ATI cards with FBO which stops Mac users to use dynamic > shadows. I know they are not officials, but they work quite well with > Nvidia cards :). I've received an answer recently asking me for the full > System Profiler Report of my machine. I was wondering if accumulating > the experiences on that subject would help make the things move faster. > So I've set up a forum where mac users wanting to do it could tell their > experience with ATI card and join their full System Profiler Report with > their experience. I would then put the link to the forum in my bug > report. Do you think this could be a good idea ? > > Bug report : > > https://bugreport.apple.com/cgi-bin/WebObjects/RadarWeb.woa/24/wo/KGyze933oURhrNytyxPfAw/5.83.28.0.9 > > Forum : > > http://macati.madonie.org/ > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges From oz at lindenlab.com Sun Feb 13 04:43:44 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Sun, 13 Feb 2011 07:43:44 -0500 Subject: [opensource-dev] Review Request: open-2 (improved progress messages during dependency checks) and open-31 (more standardized short form option switches) In-Reply-To: <4D57BEB3.1060400@boroon.dasgupta.ch> References: <20110212211329.5227.11074@domU-12-31-38-00-90-68.compute-1.internal> <4D57BEB3.1060400@boroon.dasgupta.ch> Message-ID: <4D57D200.9040207@lindenlab.com> On 2011-02-13 6:21, Boroondas Gupte wrote: > On 02/12/2011 10:13 PM, Oz Linden wrote: >> (there is a failure displaying the diff for autobuild.configfile.py because it is a one word change of the logging level for a log message added by one of my other changes that has not yet been applied to the trunk) > You should be able use the 'Parent Diff' feature to let RB know about > your other changes that have "not yet been applied to the trunk", > without having it mix them into the diff to review. I think that you're correct, and suspect that your procedure is at least pretty close (I may clone it to the wiki, in fact), but I'd already spent enough of my weekend doing the fix - I didn't have the time available to experiment with a ReviewBoard feature I wasn't sure of yet. Nicky Perian said: > Can this be placed as an hg changeset? I'll say Ship It in hopes a test method is forthcoming. This repo has all my pending changes (some of which have been approved and will be merged to the official repo on Monday morning): https://bitbucket.org/oz_linden/autobuild-review -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110213/b8f296b8/attachment.htm From oz at lindenlab.com Sun Feb 13 05:21:46 2011 From: oz at lindenlab.com (Oz Linden) Date: Sun, 13 Feb 2011 13:21:46 -0000 Subject: [opensource-dev] Review Request: open-2 (improved progress messages during dependency checks) and open-31 (more standardized short form option switches) In-Reply-To: <20110212211329.5227.11074@domU-12-31-38-00-90-68.compute-1.internal> References: <20110212211329.5227.11074@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110213132146.13389.93119@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/150/ ----------------------------------------------------------- (Updated Feb. 13, 2011, 5:21 a.m.) Review request for Viewer. Changes ------- updated diff to include correct parent for better display fixed the use of the -V short form for --version in the source_environment subcommand (which defined it separately for some reason) Summary ------- I combined open-31 into this because that change is so small and simple that it didn't seem worth a separate commit (besides, while testing the rest of this, I really wanted the short form of --verbose). open-31 changes the short form of --version to -V, so that the short form of the more commonly used --verbose can be the lower case -v, and adds -n as a short form for --dry-run (as it is used in many versions of make, and in other commands like scp and rsync). open-2 corrects the problem that (at least in the viewer build) there is a long delay during which there are no progress messages. The delay is the configure step while packages are checked, including possibly downloading, extracting, and installing them. Increasing the logging level with the --verbose or --debug switches did not increase the amount of logging during this phase. The fundamental problem proved to be that the package checks were done in recursively invoked instances of autobuild (I am guessing that the process hierarchy is autobuild->cmake->autobuild, but it could have just been autobuild calling itself directly; this fix should work regardless of the depth of the process tree). The verbosity control options were not passed through to the child processes, and since there could be some other process in between (as cmake above), it seemed more robust (and relies less on correct configuration) to pass the verbosity control to the children through the environment. The default verbosity is now read from the AUTOBUILD_LOGGING environment variable, whose contents can be --debug, --verbose, --quiet, or the one letter forms of any of those options (if the environment variable is not set, then the default value is to log warnings and worse, as before). Any of the options used on the command line override any value from the environment. Regardless of how the verbosity level is established, the environment variable AUTOBUILD_LOGGING is set for all child processes, so that if any of those (directly or indirectly) are another invocation of autobuild, then that recursive child will use the same verbosity level as the parent (unless, of course the recursive invocation uses an explicit option). It is true that this also allows the user to set a default verbosity in the shell environment, and that works, but it wasn't really the motivation for the change and I did not add anything to the documentation about it. With that change made, the options correctly controlled whether or not logging is visible during the package checking phase. However, the resulting messages had an inconsistent level of detail - some operations (such as uninstall) were very verbose, while others (some of which might take significant time) were logged only at high verbosity levels. This led to the addition of a few short log messages at the default 'warning' level (which really has the dual meaning "something that might be a problem" and "something that should be seen at the default logging level") in order to make sure that some message is printed before any potentially long operation (downloads, extracts, installs, and uninstalls). Some other very detailed messages were changed from info to debug levels, as the information they display is really only useful when debugging either a new autobuild configuration or autobuild itself. I think that the combination of these changes makes the default verbosity reasonably informative (no long silences) without being overwhelming. (there is a failure displaying the diff for autobuild.configfile.py because it is a one word change of the logging level for a log message added by one of my other changes that has not yet been applied to the trunk) This addresses bugs open-2 and open-31. Diffs (updated) ----- autobuild/autobuild_main.py 9ee2db08d677 autobuild/autobuild_tool_install.py 9ee2db08d677 autobuild/autobuild_tool_source_environment.py 9ee2db08d677 autobuild/common.py 9ee2db08d677 autobuild/configfile.py 9ee2db08d677 Diff: http://codereview.secondlife.com/r/150/diff Testing ------- Manually verified using configuring and building in viewer-autobuild Thanks, Oz -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110213/b5097575/attachment.htm From wolfpup67 at earthlink.net Sun Feb 13 05:37:27 2011 From: wolfpup67 at earthlink.net (Wolfpup Lowenhar) Date: Sun, 13 Feb 2011 13:37:27 -0000 Subject: [opensource-dev] Review Request: open-2 (improved progress messages during dependency checks) and open-31 (more standardized short form option switches) In-Reply-To: <20110213132146.13389.93119@domU-12-31-38-00-90-68.compute-1.internal> References: <20110213132146.13389.93119@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110213133727.13392.69212@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/150/#review358 ----------------------------------------------------------- Ship it! This looks good to me. - Wolfpup On Feb. 13, 2011, 5:21 a.m., Oz Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/150/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2011, 5:21 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > I combined open-31 into this because that change is so small and simple that it didn't seem worth a separate commit (besides, while testing the rest of this, I really wanted the short form of --verbose). > > open-31 changes the short form of --version to -V, so that the short form of the more commonly used --verbose can be the lower case -v, and adds -n as a short form for --dry-run (as it is used in many versions of make, and in other commands like scp and rsync). > > open-2 corrects the problem that (at least in the viewer build) there is a long delay during which there are no progress messages. The delay is the configure step while packages are checked, including possibly downloading, extracting, and installing them. Increasing the logging level with the --verbose or --debug switches did not increase the amount of logging during this phase. > > The fundamental problem proved to be that the package checks were done in recursively invoked instances of autobuild (I am guessing that the process hierarchy is autobuild->cmake->autobuild, but it could have just been autobuild calling itself directly; this fix should work regardless of the depth of the process tree). The verbosity control options were not passed through to the child processes, and since there could be some other process in between (as cmake above), it seemed more robust (and relies less on correct configuration) to pass the verbosity control to the children through the environment. > > The default verbosity is now read from the AUTOBUILD_LOGGING environment variable, whose contents can be --debug, --verbose, --quiet, or the one letter forms of any of those options (if the environment variable is not set, then the default value is to log warnings and worse, as before). Any of the options used on the command line override any value from the environment. Regardless of how the verbosity level is established, the environment variable AUTOBUILD_LOGGING is set for all child processes, so that if any of those (directly or indirectly) are another invocation of autobuild, then that recursive child will use the same verbosity level as the parent (unless, of course the recursive invocation uses an explicit option). It is true that this also allows the user to set a default verbosity in the shell environment, and that works, but it wasn't really the motivation for the change and I did not add anything to the documentation about it. > > With that change made, the options correctly controlled whether or not logging is visible during the package checking phase. However, the resulting messages had an inconsistent level of detail - some operations (such as uninstall) were very verbose, while others (some of which might take significant time) were logged only at high verbosity levels. This led to the addition of a few short log messages at the default 'warning' level (which really has the dual meaning "something that might be a problem" and "something that should be seen at the default logging level") in order to make sure that some message is printed before any potentially long operation (downloads, extracts, installs, and uninstalls). Some other very detailed messages were changed from info to debug levels, as the information they display is really only useful when debugging either a new autobuild configuration or autobuild itself. > > I think that the combination of these changes makes the default verbosity reasonably informative (no long silences) without being overwhelming. > > (there is a failure displaying the diff for autobuild.configfile.py because it is a one word change of the logging level for a log message added by one of my other changes that has not yet been applied to the trunk) > > > This addresses bugs open-2 and open-31. > > > Diffs > ----- > > autobuild/autobuild_main.py 9ee2db08d677 > autobuild/autobuild_tool_install.py 9ee2db08d677 > autobuild/autobuild_tool_source_environment.py 9ee2db08d677 > autobuild/common.py 9ee2db08d677 > autobuild/configfile.py 9ee2db08d677 > > Diff: http://codereview.secondlife.com/r/150/diff > > > Testing > ------- > > Manually verified using configuring and building in viewer-autobuild > > > Thanks, > > Oz > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110213/30d09081/attachment-0001.htm From opensourceobscure at gmail.com Sun Feb 13 10:56:33 2011 From: opensourceobscure at gmail.com (Opensource Obscure) Date: Sun, 13 Feb 2011 19:56:33 +0100 Subject: [opensource-dev] Slowdowns with Viewer 2.5.x for Linux (getting too many data?) In-Reply-To: References: Message-ID: On Sat, Feb 12, 2011 at 14:46, leliel wrote: > If the viewer freezes for a few seconds ever time it loads a texture > then it's probably STORM-809. Thank you very much Leliel, I think it's STORM-809. Other Linux users confirmed this problem in Linux Client Users group chat. Another user created VWR-24835 that I think relates to the same problem. While I'm always on the last viewer available, I'm currently sticking with Viewer 2.4, as the impact on performances is huge. I think I had seen this in a development build I had tried, but I omitted to further investigate it...my fault. Opensource Obscure From makosoft at gmail.com Mon Feb 14 02:36:25 2011 From: makosoft at gmail.com (Aidan Thornton) Date: Mon, 14 Feb 2011 10:36:25 +0000 Subject: [opensource-dev] Linux64 "boost 1.39" is still actually boost 1.34.1 Message-ID: Hi, It looks like the packaged linux64 version of boost, http://s3.amazonaws.com/viewer-source-downloads/install_pkgs/boost-1.39.0-linux64-20100119.tar.bz2, is still actually the mislabelled boost 1.34.1. Is there a newer build available? Thanks, Aidan From alain at lindenlab.com Mon Feb 14 12:57:12 2011 From: alain at lindenlab.com (Alain Linden) Date: Mon, 14 Feb 2011 20:57:12 -0000 Subject: [opensource-dev] Review Request: open-2 (improved progress messages during dependency checks) and open-31 (more standardized short form option switches) In-Reply-To: <20110213132146.13389.93119@domU-12-31-38-00-90-68.compute-1.internal> References: <20110213132146.13389.93119@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110214205712.13390.73193@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/150/#review359 ----------------------------------------------------------- "(which really has the dual meaning "something that might be a problem" and "something that should be seen at the default logging level")" . As I mention in the comments, I think only the first kind of message should be shown at WARNING level because I don't like chat. Others may disagree. autobuild/autobuild_main.py I'd would be a little cleaner to use: os.environ.get(AUTOBUILD_LOGLEVEL) which returns None if the key does not exist in the map. I prefer None to '' for an unset value myself. Or, you can use: os.environ.get(AUTOBUILD_LOGLEVEL, '') if you prefer an empty string. autobuild/autobuild_tool_install.py I disagree with upping this to warning. IMHO, the default mode for autobuild shouldn't be chatty. If you want it to talk to you, set your warning level to INFO. I prefer that it just run quietly with no messages if everything is going fine. If we have other messages that are WARNING level but not true warnings, I'd prefer they be made info instead. - Alain On Feb. 13, 2011, 5:21 a.m., Oz Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/150/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2011, 5:21 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > I combined open-31 into this because that change is so small and simple that it didn't seem worth a separate commit (besides, while testing the rest of this, I really wanted the short form of --verbose). > > open-31 changes the short form of --version to -V, so that the short form of the more commonly used --verbose can be the lower case -v, and adds -n as a short form for --dry-run (as it is used in many versions of make, and in other commands like scp and rsync). > > open-2 corrects the problem that (at least in the viewer build) there is a long delay during which there are no progress messages. The delay is the configure step while packages are checked, including possibly downloading, extracting, and installing them. Increasing the logging level with the --verbose or --debug switches did not increase the amount of logging during this phase. > > The fundamental problem proved to be that the package checks were done in recursively invoked instances of autobuild (I am guessing that the process hierarchy is autobuild->cmake->autobuild, but it could have just been autobuild calling itself directly; this fix should work regardless of the depth of the process tree). The verbosity control options were not passed through to the child processes, and since there could be some other process in between (as cmake above), it seemed more robust (and relies less on correct configuration) to pass the verbosity control to the children through the environment. > > The default verbosity is now read from the AUTOBUILD_LOGGING environment variable, whose contents can be --debug, --verbose, --quiet, or the one letter forms of any of those options (if the environment variable is not set, then the default value is to log warnings and worse, as before). Any of the options used on the command line override any value from the environment. Regardless of how the verbosity level is established, the environment variable AUTOBUILD_LOGGING is set for all child processes, so that if any of those (directly or indirectly) are another invocation of autobuild, then that recursive child will use the same verbosity level as the parent (unless, of course the recursive invocation uses an explicit option). It is true that this also allows the user to set a default verbosity in the shell environment, and that works, but it wasn't really the motivation for the change and I did not add anything to the documentation about it. > > With that change made, the options correctly controlled whether or not logging is visible during the package checking phase. However, the resulting messages had an inconsistent level of detail - some operations (such as uninstall) were very verbose, while others (some of which might take significant time) were logged only at high verbosity levels. This led to the addition of a few short log messages at the default 'warning' level (which really has the dual meaning "something that might be a problem" and "something that should be seen at the default logging level") in order to make sure that some message is printed before any potentially long operation (downloads, extracts, installs, and uninstalls). Some other very detailed messages were changed from info to debug levels, as the information they display is really only useful when debugging either a new autobuild configuration or autobuild itself. > > I think that the combination of these changes makes the default verbosity reasonably informative (no long silences) without being overwhelming. > > (there is a failure displaying the diff for autobuild.configfile.py because it is a one word change of the logging level for a log message added by one of my other changes that has not yet been applied to the trunk) > > > This addresses bugs open-2 and open-31. > > > Diffs > ----- > > autobuild/autobuild_main.py 9ee2db08d677 > autobuild/autobuild_tool_install.py 9ee2db08d677 > autobuild/autobuild_tool_source_environment.py 9ee2db08d677 > autobuild/common.py 9ee2db08d677 > autobuild/configfile.py 9ee2db08d677 > > Diff: http://codereview.secondlife.com/r/150/diff > > > Testing > ------- > > Manually verified using configuring and building in viewer-autobuild > > > Thanks, > > Oz > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110214/d8f11b96/attachment.htm From oz at lindenlab.com Mon Feb 14 14:45:08 2011 From: oz at lindenlab.com (Oz Linden) Date: Mon, 14 Feb 2011 22:45:08 -0000 Subject: [opensource-dev] Review Request: open-2 (improved progress messages during dependency checks) and open-31 (more standardized short form option switches) In-Reply-To: <20110214205712.13390.73193@domU-12-31-38-00-90-68.compute-1.internal> References: <20110214205712.13390.73193@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110214224508.13395.44394@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 14, 2011, 12:57 p.m., Alain Linden wrote: > > "(which really has the dual meaning "something that might be a problem" and "something that should be seen at the default logging level")" . As I mention in the comments, I think only the first kind of message should be shown at WARNING level because I don't like chat. Others may disagree. > > If we had a level that meant "this should normally be shown but is not any kind of error indicator", I'd have used that. It didn't seem worth adding a custom level just to get that, and existing usage meant that to get it you have to use warning. > On Feb. 14, 2011, 12:57 p.m., Alain Linden wrote: > > autobuild/autobuild_main.py, line 103 > > > > > > I'd would be a little cleaner to use: > > os.environ.get(AUTOBUILD_LOGLEVEL) > > which returns None if the key does not exist in the map. I prefer None to '' for an unset value myself. Or, you can use: > > os.environ.get(AUTOBUILD_LOGLEVEL, '') > > if you prefer an empty string. > > I found that to get the right effect, I needed to set the environment variable using the direct [] form, so I thought that using that form would be better when reading too. According to the documentation, they are functionally equivalent. > On Feb. 14, 2011, 12:57 p.m., Alain Linden wrote: > > autobuild/autobuild_tool_install.py, line 265 > > > > > > I disagree with upping this to warning. IMHO, the default mode for autobuild shouldn't be chatty. If you want it to talk to you, set your warning level to INFO. I prefer that it just run quietly with no messages if everything is going fine. If we have other messages that are WARNING level but not true warnings, I'd prefer they be made info instead. The whole point of this is that on many systems, new configurations just sit for as much as a few minutes with no indication that anything is going on at all. This issue got opened because multiple users complained about it. The info level doesn't show unless you set the logging to --verbose, and is much chattier. I could just as easily suggest that if you want it to be quiet, tell it to be --quiet. These things are a balance, and a minute and half of silence at the default level is a bit to far down the silent side. Besides, in that particular case, if I thought I was updating because I gave a command to update, it might be important to remind me that nothing is being changed. - Oz ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/150/#review359 ----------------------------------------------------------- On Feb. 13, 2011, 5:21 a.m., Oz Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/150/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2011, 5:21 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > I combined open-31 into this because that change is so small and simple that it didn't seem worth a separate commit (besides, while testing the rest of this, I really wanted the short form of --verbose). > > open-31 changes the short form of --version to -V, so that the short form of the more commonly used --verbose can be the lower case -v, and adds -n as a short form for --dry-run (as it is used in many versions of make, and in other commands like scp and rsync). > > open-2 corrects the problem that (at least in the viewer build) there is a long delay during which there are no progress messages. The delay is the configure step while packages are checked, including possibly downloading, extracting, and installing them. Increasing the logging level with the --verbose or --debug switches did not increase the amount of logging during this phase. > > The fundamental problem proved to be that the package checks were done in recursively invoked instances of autobuild (I am guessing that the process hierarchy is autobuild->cmake->autobuild, but it could have just been autobuild calling itself directly; this fix should work regardless of the depth of the process tree). The verbosity control options were not passed through to the child processes, and since there could be some other process in between (as cmake above), it seemed more robust (and relies less on correct configuration) to pass the verbosity control to the children through the environment. > > The default verbosity is now read from the AUTOBUILD_LOGGING environment variable, whose contents can be --debug, --verbose, --quiet, or the one letter forms of any of those options (if the environment variable is not set, then the default value is to log warnings and worse, as before). Any of the options used on the command line override any value from the environment. Regardless of how the verbosity level is established, the environment variable AUTOBUILD_LOGGING is set for all child processes, so that if any of those (directly or indirectly) are another invocation of autobuild, then that recursive child will use the same verbosity level as the parent (unless, of course the recursive invocation uses an explicit option). It is true that this also allows the user to set a default verbosity in the shell environment, and that works, but it wasn't really the motivation for the change and I did not add anything to the documentation about it. > > With that change made, the options correctly controlled whether or not logging is visible during the package checking phase. However, the resulting messages had an inconsistent level of detail - some operations (such as uninstall) were very verbose, while others (some of which might take significant time) were logged only at high verbosity levels. This led to the addition of a few short log messages at the default 'warning' level (which really has the dual meaning "something that might be a problem" and "something that should be seen at the default logging level") in order to make sure that some message is printed before any potentially long operation (downloads, extracts, installs, and uninstalls). Some other very detailed messages were changed from info to debug levels, as the information they display is really only useful when debugging either a new autobuild configuration or autobuild itself. > > I think that the combination of these changes makes the default verbosity reasonably informative (no long silences) without being overwhelming. > > (there is a failure displaying the diff for autobuild.configfile.py because it is a one word change of the logging level for a log message added by one of my other changes that has not yet been applied to the trunk) > > > This addresses bugs open-2 and open-31. > > > Diffs > ----- > > autobuild/autobuild_main.py 9ee2db08d677 > autobuild/autobuild_tool_install.py 9ee2db08d677 > autobuild/autobuild_tool_source_environment.py 9ee2db08d677 > autobuild/common.py 9ee2db08d677 > autobuild/configfile.py 9ee2db08d677 > > Diff: http://codereview.secondlife.com/r/150/diff > > > Testing > ------- > > Manually verified using configuring and building in viewer-autobuild > > > Thanks, > > Oz > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110214/6f397658/attachment-0001.htm From akanevsky at productengine.com Mon Feb 14 15:26:05 2011 From: akanevsky at productengine.com (Anya Kanevsky) Date: Mon, 14 Feb 2011 15:26:05 -0800 Subject: [opensource-dev] PO Test build In-Reply-To: References: Message-ID: Thank you, Merov! 2011/2/12 Philippe (Merov) Bossut > Hi, > > Here's is a test build: > > http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/221041/index.html > > Containing merges of the following: > * STORM-357 : Gestures button is in the pressed state after drag-n-drop but > gestures list isn't visible > Rejected. Original bug described incorrect expected behavior. > * STORM-974 : UI button alignment issues in Landmark panel, About Land > window, and Hardware Settings window > All of the fixes look fine, however we need to verify that this will not break layouts in other locales before merging. > * STORM-979 : selection outline from inventory bottom panel buttons is cut > at the left side when clicked. > No objections > * STORM-980 : Appearance panel / Wear button is too wide > Same concern as with STORM-974. Need to verify other locales. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110214/a9f8889e/attachment.htm From angel_of_crimson at hotmail.com Mon Feb 14 16:48:36 2011 From: angel_of_crimson at hotmail.com (Erin Mallory) Date: Mon, 14 Feb 2011 19:48:36 -0500 Subject: [opensource-dev] PO Test build In-Reply-To: References: , Message-ID: errm Anya? Im wondering why it would be expected behavior? all other buttons when pressed down except voice keep active when dragged and moved. wouldn't/shouldn't the gestures button do the same for consistancy? the mini map, map, build, search, snapshot, etc all stay open... From: akanevsky at productengine.com Date: Mon, 14 Feb 2011 15:26:05 -0800 To: merov at lindenlab.com CC: opensource-dev at lists.secondlife.com Subject: Re: [opensource-dev] PO Test build Thank you, Merov! 2011/2/12 Philippe (Merov) Bossut Hi, Here's is a test build: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/221041/index.html Containing merges of the following: * STORM-357 : Gestures button is in the pressed state after drag-n-drop but gestures list isn't visible Rejected. Original bug described incorrect expected behavior. * STORM-974 : UI button alignment issues in Landmark panel, About Land window, and Hardware Settings window All of the fixes look fine, however we need to verify that this will not break layouts in other locales before merging. * STORM-979 : selection outline from inventory bottom panel buttons is cut at the left side when clicked. No objections * STORM-980 : Appearance panel / Wear button is too wide Same concern as with STORM-974. Need to verify other locales. _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110214/38173b8b/attachment.htm From angel_of_crimson at hotmail.com Mon Feb 14 16:51:02 2011 From: angel_of_crimson at hotmail.com (Erin Mallory) Date: Mon, 14 Feb 2011 19:51:02 -0500 Subject: [opensource-dev] PO Test build In-Reply-To: References: , , , Message-ID: Never mind i was reading off the old jira description... From: angel_of_crimson at hotmail.com To: akanevsky at productengine.com; merov at lindenlab.com Date: Mon, 14 Feb 2011 19:48:36 -0500 CC: opensource-dev at lists.secondlife.com Subject: Re: [opensource-dev] PO Test build errm Anya? Im wondering why it would be expected behavior? all other buttons when pressed down except voice keep active when dragged and moved. wouldn't/shouldn't the gestures button do the same for consistancy? the mini map, map, build, search, snapshot, etc all stay open... From: akanevsky at productengine.com Date: Mon, 14 Feb 2011 15:26:05 -0800 To: merov at lindenlab.com CC: opensource-dev at lists.secondlife.com Subject: Re: [opensource-dev] PO Test build Thank you, Merov! 2011/2/12 Philippe (Merov) Bossut Hi, Here's is a test build: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/221041/index.html Containing merges of the following: * STORM-357 : Gestures button is in the pressed state after drag-n-drop but gestures list isn't visible Rejected. Original bug described incorrect expected behavior. * STORM-974 : UI button alignment issues in Landmark panel, About Land window, and Hardware Settings window All of the fixes look fine, however we need to verify that this will not break layouts in other locales before merging. * STORM-979 : selection outline from inventory bottom panel buttons is cut at the left side when clicked. No objections * STORM-980 : Appearance panel / Wear button is too wide Same concern as with STORM-974. Need to verify other locales. _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110214/b4cc01d9/attachment.htm From rusyasoft at gmail.com Mon Feb 14 16:53:38 2011 From: rusyasoft at gmail.com (Rustam Rakhimov) Date: Tue, 15 Feb 2011 09:53:38 +0900 Subject: [opensource-dev] Where is security part ??? Message-ID: Hi everybody This question is kind of little common, I'm wondering about security part of all these virtual world related things, i couldn't find any security architecture or some framework. is there anybody who can give me any tip ? any topic is ok, especially security in messaging part. Any application is ok: Second Life, Open SIM, Naali ... thanks in advance ! -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110215/f248885f/attachment.htm From trilobyte550m at gmail.com Mon Feb 14 18:13:27 2011 From: trilobyte550m at gmail.com (Trilo Byte) Date: Mon, 14 Feb 2011 18:13:27 -0800 Subject: [opensource-dev] Hard crash/System Freeze on exit in Mac Client Message-ID: <17C9845C-62EF-4B8E-8252-2EE11C50677B@gmail.com> Merov, you'd asked us to let you know if we were experiencing crashes on exit in the mac client... I started experiencing problems with system freezes upon Viewer exit in builds over the last 7-10 days. Initially just several seconds where other applications and the desktop became unresponsive as the SL application shut itself down, but over the last three builds sent out via automated build notifications (including the most recent, 221087), they have been causing hard freezes that result in a system crash with loss of data in other applications. This is happening on a couple different machines, all running OSX 10.6, and only happening in recent builds. TriloByte Zanzibar From akanevsky at productengine.com Mon Feb 14 23:59:02 2011 From: akanevsky at productengine.com (Anya Kanevsky) Date: Mon, 14 Feb 2011 23:59:02 -0800 Subject: [opensource-dev] Daily Scrum Summary - Monday, February 14 Message-ID: Sprint 11, ends 02.21.11 [edit ]Monday, February 14 [edit ]General Notes ------------------------------ - MMOTD: Merov [edit ]Team Status ------------------------------ [edit ]Merov Linden ------------------------------ *PAST* - MM : Pushed 2 fixes. Made PO build for 7 others. - STORM-937 : Path to python in /scripts/*.py file inconsistent : Fixed the Windows issue (was a problem in llversion.py, not with build.sh). Builds on all platforms. Moved to review. - STORM-987 : llimage_libtest: Some work on that but not ready for a push yet *FUTURE* - STORM-987 : llimage_libtest: Post first implementation *IMPEDIMENTS* - None - VWR triage [edit ]Oz Linden ------------------------------ *PAST* - New communications blog thread responses... - Created autobuild command reference pages on the wiki - Published a script to convert standard python help output to a wiki page - OPEN-2: Fixed logging in autobuild during the configure phase (in review) - Handed off OPEN-4 to Merov - Open Development User Group meeting *FUTURE* - Merge Monkey - push approved changes to autobuild - Integrate pending VS Express changes into viewer-autobuild - Create wiki page on building viewer w/ autobuild - Associated environment setup pages - Prep for upcoming VS 2010 Hackathon - Create any open repos needed on bitbucket - Start thread on opensource-dev *IMPEDIMENTS* - stinking pile of excrement blog software (glad to see that go soon) [edit ]Q Linden ------------------------------ *PAST* - release - OOO sick *FUTURE* - lots of email - crashhunters / 2.5 - review PO build - arrange meeting with wolf on keyboard specs *IMPEDIMENTS* - none [edit ]Wolf Linden ------------------------------ *PAST* - Snowstorm VWR tirage *FUTURE* - VWR-24752 - New Jira items needing design *IMPEDIMENTS* - need to meet with Q [edit ]Grumpity ProductEngine ------------------------------ *PAST* - crashhunters - tested PO build - approved STORM-975, STORM-833 - long discussion of STORM-28 with wolf - Storm-2 needs design for custom layouts. - calendar updates *FUTURE* - STORM cleanup in jira - crashhunters *IMPEDIMENTS* - STORM-2: needs decision on what state of readiness we expect for the feature - Keyboard shortcuts need design. Perhaps splitting up into sections is best attack. - Should Story type tickets have a Test Plan field? they currently have Acceptance criteria only. [edit ]Paul Productengine ------------------------------ *PAST* - BUG STORM-951 (Accidental Self-Muting/Self-Blocking) - WIP. Fixed self-blocking/self-muting. Though blocked object is added to the muted list, messages from blocked objects still arrive. Tomorrow solve this problem and send for review. Estimate ~ 3-4 hours. *FUTURE* - BUG STORM-951 (Accidental Self-Muting/Self-Blocking) - Other tickets by priority *IMPEDIMENTS* - none [edit ]Seth Productengine ------------------------------ *PAST* - BUG (STORM-939) Opening multiple inventory floaters causes viewer to lag or even crash - Found that the main lags are caused by widget construction when opening multiple inventory floaters, not by inventory related operations. - Made a small fix for the related bug. *FUTURE* - BUG (STORM-949) please remove actual usernames from XUI files - Estimated: 1-2 hours. - Pick some other tasks from sprint 11. *IMPEDIMENTS* - none [edit ]Vadim Productengine ------------------------------ *PAST* - Reading emails after vacation, discussing misc ticket-related issues. - Leaving a bit earlier today (guess why :-)), will compensate this week. *FUTURE* - Story STORM-2 (Customizable viewer layouts). *IMPEDIMENTS* - Bug STORM-610 (Changes to Environment Editor: water color change is not saved): - Can't work on a possible Mac-specific regression introduced by the fix: we've got no Macs. [edit ]Andrey ProductEngine ------------------------------ *PAST* - continued regression testing of v-d branch - Voice Chat - Group Chat - Chat Logging - Preferences - reported 2 issues^ VWR-24798, VWR-24814 *FUTURE* - continue eliminating gaps in the test coverage (Place Profile Panel, Buy Land, About Land, Region/Estate) - verify v-d integrated tickets *IMPEDIMENTS* - none [edit ]Wolfpup Lowenhar ------------------------------ *PAST* - RL work. - STORM-236 : Tested patch from Richard on local repository and received new graphic from Wolf Linden. Also sent Richard email about how to get panel to actually show as it is still not doing this. - OPEN-9 : Did some reconfiguring of dev environment to get proper output now have odd error that is not related to source code but to python will see if this also is affecting non autobuild repository. *FUTURE* - RL work. - STORM-236 : Working on getting new panel to be visible once I receive reply from Richard. - OPEN-9 : Attach images and special instructions needed for Vista/7 configurations and see if currnt environment configuration of python has affected non autobuild repository. - STORM-941 : email Oz and Leyla concerning possible areas that could be causing the problem.(still need to do this) *IMPEDIMENTS* - STORM-236 : waiting for reply from Richard. - STORM-941 : need to remember to send email - Not enough time to actually work on code. - Roommate out of hospital but still not up to par. [edit ]Jonathan Yap ------------------------------ *PAST* - STORM-956 (Ability to mute dialogs by muting object (or object owner)) - STORM-990 (The arrow in the bottom right of the Landmark panel points down) *FUTURE* *FUTURE* - STORM - 956 1) Can this be brought into Sprint 11. Storm-951 depends on it and Storm-976 depends on Storm - 951. 2) File message_template.msg needs to be pushed into viewer code tree from server code tree. 3) Jira needs Test Plan field. - STORM - 990 Needs approval of minor change in jira Description field from Wolf. [edit ]Cummere Mayo ------------------------------ *PAST* - discussion with wolf - lots of jira cleanup in vwr this weekend - new products on the store - was unable to get v-d to stay connected so switched to po build - working on a collaberative blog article with other residents about the desperate need for an in browser backup for web based stuff *FUTURE* - blog *IMPEDIMENTS* - only time and that pesky 1st life -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110214/662bffdb/attachment-0001.htm From vsavchuk at productengine.com Tue Feb 15 06:40:14 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 15 Feb 2011 14:40:14 -0000 Subject: [opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well In-Reply-To: <20110206085405.28753.15909@domU-12-31-38-00-90-68.compute-1.internal> References: <20110206085405.28753.15909@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110215144014.13389.62759@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/139/#review362 ----------------------------------------------------------- indra/newview/llchatbar.h Use tabs for indentation, not spaces. This note seems to apply to all modified lines in this patch. indra/newview/llchatbar.cpp Do you only update font size on focus changes? Why? That doesn't look right to me. indra/newview/llnearbychatbar.cpp Same here. - Vadim On Feb. 6, 2011, 12:54 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/139/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2011, 12:54 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > This is a request for help. I am trying to learn more about c++ and how variables in one class are accessed from another. For someone who knows what they are doing this is probably a pretty easy question. > > I have been able to set the font size on the chat input box when it is created in llbottomtray.cpp. I would like to do the same thing when someone clicks in that box to input text; it is possible they have changed the font setting and I would like to apply the size there as well, but I am stuck on how to do this. I think the right place to do this is in llchatbar.cpp/LLChatBar::onInputEditorGainFocus(). > > I have tried all kinds of wrong ways but at this point am stymied. > > Exact steps on how to proceed would be appreciated. > > > This addresses bug vwr-22220. > http://jira.secondlife.com/browse/vwr-22220 > > > Diffs > ----- > > indra/llui/lllineeditor.h 3d2e71443c58 > indra/llui/lllineeditor.cpp 3d2e71443c58 > indra/newview/llchatbar.h 3d2e71443c58 > indra/newview/llchatbar.cpp 3d2e71443c58 > indra/newview/llnearbychatbar.cpp 3d2e71443c58 > > Diff: http://codereview.secondlife.com/r/139/diff > > > Testing > ------- > > > Thanks, > > Jonathan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110215/6c318859/attachment.htm From vsavchuk at productengine.com Tue Feb 15 06:45:51 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 15 Feb 2011 14:45:51 -0000 Subject: [opensource-dev] Review Request: OPEN-29: Error out if lldir_.h is included when building for a different platform. In-Reply-To: <20110211140706.29081.72898@domU-12-31-38-00-90-68.compute-1.internal> References: <20110211140706.29081.72898@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110215144551.13395.84295@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/148/#review363 ----------------------------------------------------------- Ship it! The changes look reasonable, and cleanups are always appreciated. :-) Thanks! - Vadim On Feb. 11, 2011, 6:07 a.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/148/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2011, 6:07 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Rather than relying on (probably anyway accidental) on syntax incompatibilities, added explicit #error to the indra/llvfs/lldir_*.h headers. > > In separate commits, but also in the diff for review here, removed one such syntax incompatibility (https://bitbucket.org/boroondas/open-29/changeset/19ab94811717 ) and did some cleanup (superfluous "public:"s, trailing whitespace). > > > This addresses bug OPEN-29. > http://jira.secondlife.com/browse/OPEN-29 > > > Diffs > ----- > > doc/contributions.txt ec4ad7e3ecca > indra/llvfs/lldir_linux.h ec4ad7e3ecca > indra/llvfs/lldir_mac.h ec4ad7e3ecca > indra/llvfs/lldir_solaris.h ec4ad7e3ecca > indra/llvfs/lldir_win32.h ec4ad7e3ecca > > Diff: http://codereview.secondlife.com/r/148/diff > > > Testing > ------- > > Built on Linux before pulling https://bitbucket.org/lindenlab/viewer-development/changeset/7a1440277911 > * Errors out as wanted. > > Build on Linux after pulling 7a1440277911 > * Builds like normal. > > Note: These tests were done with other build fixes present > * for VWR-24520 https://codereview.secondlife.com/r/97/ > * for VWR-24487 https://codereview.secondlife.com/r/100/ > not on a pristine source tree. > > > Thanks, > > Boroondas > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110215/447c4b62/attachment-0001.htm From pguslisty at productengine.com Tue Feb 15 09:54:00 2011 From: pguslisty at productengine.com (Paul ProductEngine) Date: Tue, 15 Feb 2011 17:54:00 -0000 Subject: [opensource-dev] Review Request: STORM-974 UI button alignment issues in Landmark panel, About Land window, and Hardware Settings window In-Reply-To: <20110208132245.28780.94605@domU-12-31-38-00-90-68.compute-1.internal> References: <20110208132245.28780.94605@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110215175400.13389.99520@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/142/#review365 ----------------------------------------------------------- Ship it! - Paul On Feb. 8, 2011, 5:22 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/142/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2011, 5:22 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Please see the jira for the referenced pictures. > > In picture #1, in the preferences > graphics > hardware settings, the line of "gamma" setting is a little too up and it collides with the "antialiasing" line. > > In picture #2 in the "places" tab under "my landmarks" tab the "profile" button gets cut off at the end from the rest of the sidebar's UI. > There are a number of other buttons with alignment issues with no screenshot. > > In picture #3 in the Access tab in the About Land window, the remove buttons are off to the right a few millimetres. > > Changes made were to align the Hardware Settings and About Land buttons and to completely go over the buttons in the Landmarks panel. The small down-arrow at the bottom right corner was using an imbedded UTF-8 so I fixed that and also made it point up while the menu is open (there is a separate jira for reversing the direction it points in these two states). > > This patch really needs a test viewer built to make sure all works and that nothing was missed in the Landmarks panel. There are 3 other related jiras that I hope are taken in; a test viewer could be made incorporating all 4 jiras at that point. > > > This addresses bug STORM-974. > http://jira.secondlife.com/browse/STORM-974 > > > Diffs > ----- > > indra/newview/skins/default/xui/en/panel_places.xml b0bceb572090 > > Diff: http://codereview.secondlife.com/r/142/diff > > > Testing > ------- > > > Thanks, > > Jonathan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110215/c451ce50/attachment.htm From jhwelch at gmail.com Tue Feb 15 09:56:28 2011 From: jhwelch at gmail.com (Jonathan Yap) Date: Tue, 15 Feb 2011 17:56:28 -0000 Subject: [opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well In-Reply-To: <20110215144014.13389.62759@domU-12-31-38-00-90-68.compute-1.internal> References: <20110215144014.13389.62759@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110215175628.13395.63752@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 15, 2011, 6:40 a.m., Vadim ProductEngine wrote: > > indra/newview/llchatbar.h, line 83 > > > > > > Use tabs for indentation, not spaces. > > > > This note seems to apply to all modified lines in this patch. Using spaces is specified in the coding standard: http://wiki.secondlife.com/wiki/Coding_standard#Indentation This preference was made explicit on Feb 3. > On Feb. 15, 2011, 6:40 a.m., Vadim ProductEngine wrote: > > indra/newview/llchatbar.cpp, lines 543-549 > > > > > > Do you only update font size on focus changes? > > Why? > > That doesn't look right to me. It might not look/feel right, but the only downside to doing it this way is the message "Click here to chat" is not immediately updated. If you are in the middle of typing in the chat input box and change the size preference you will have to click back on the box to continue typing, at which point the new font size is updated in the box. The upside to doing it this way is a test for a font change is not being performed every frame or every keystroke. Oz is happy with it working this way. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/139/#review362 ----------------------------------------------------------- On Feb. 6, 2011, 12:54 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/139/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2011, 12:54 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > This is a request for help. I am trying to learn more about c++ and how variables in one class are accessed from another. For someone who knows what they are doing this is probably a pretty easy question. > > I have been able to set the font size on the chat input box when it is created in llbottomtray.cpp. I would like to do the same thing when someone clicks in that box to input text; it is possible they have changed the font setting and I would like to apply the size there as well, but I am stuck on how to do this. I think the right place to do this is in llchatbar.cpp/LLChatBar::onInputEditorGainFocus(). > > I have tried all kinds of wrong ways but at this point am stymied. > > Exact steps on how to proceed would be appreciated. > > > This addresses bug vwr-22220. > http://jira.secondlife.com/browse/vwr-22220 > > > Diffs > ----- > > indra/llui/lllineeditor.h 3d2e71443c58 > indra/llui/lllineeditor.cpp 3d2e71443c58 > indra/newview/llchatbar.h 3d2e71443c58 > indra/newview/llchatbar.cpp 3d2e71443c58 > indra/newview/llnearbychatbar.cpp 3d2e71443c58 > > Diff: http://codereview.secondlife.com/r/139/diff > > > Testing > ------- > > > Thanks, > > Jonathan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110215/004c6739/attachment.htm From jhwelch at gmail.com Tue Feb 15 10:04:53 2011 From: jhwelch at gmail.com (Jonathan Yap) Date: Tue, 15 Feb 2011 18:04:53 -0000 Subject: [opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well In-Reply-To: <20110206085405.28753.15909@domU-12-31-38-00-90-68.compute-1.internal> References: <20110206085405.28753.15909@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110215180453.13492.55919@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/139/ ----------------------------------------------------------- (Updated Feb. 15, 2011, 10:04 a.m.) Review request for Viewer. Changes ------- During testing found that when the viewer is started the font size in the chat input box is not being set, so changed llbottomtray to set it. Summary ------- This is a request for help. I am trying to learn more about c++ and how variables in one class are accessed from another. For someone who knows what they are doing this is probably a pretty easy question. I have been able to set the font size on the chat input box when it is created in llbottomtray.cpp. I would like to do the same thing when someone clicks in that box to input text; it is possible they have changed the font setting and I would like to apply the size there as well, but I am stuck on how to do this. I think the right place to do this is in llchatbar.cpp/LLChatBar::onInputEditorGainFocus(). I have tried all kinds of wrong ways but at this point am stymied. Exact steps on how to proceed would be appreciated. This addresses bug vwr-22220. http://jira.secondlife.com/browse/vwr-22220 Diffs (updated) ----- indra/newview/llbottomtray.h 3d2e71443c58 indra/newview/llbottomtray.cpp 3d2e71443c58 Diff: http://codereview.secondlife.com/r/139/diff Testing ------- Thanks, Jonathan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110215/074b681d/attachment-0001.htm From slitovchuk at productengine.com Tue Feb 15 14:48:59 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Tue, 15 Feb 2011 22:48:59 -0000 Subject: [opensource-dev] Review Request: (STORM-949) please remove actual usernames from XUI files Message-ID: <20110215224859.13396.96684@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/151/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Actual usernames are replaced with "TestString PleaseIgnore" in EN locale with setting translate="false" flag for affected widgets. Translated phrases with actual usernames are removed from XUI files in other locales. This addresses bug STORM-949. http://jira.secondlife.com/browse/STORM-949 Diffs ----- indra/newview/skins/default/xui/da/floater_about_land.xml 58fdb5218596 indra/newview/skins/default/xui/da/floater_inventory_item_properties.xml 58fdb5218596 indra/newview/skins/default/xui/da/floater_tools.xml 58fdb5218596 indra/newview/skins/default/xui/da/inspect_avatar.xml 58fdb5218596 indra/newview/skins/default/xui/da/panel_edit_profile.xml 58fdb5218596 indra/newview/skins/default/xui/da/panel_profile_view.xml 58fdb5218596 indra/newview/skins/default/xui/da/sidepanel_task_info.xml 58fdb5218596 indra/newview/skins/default/xui/de/floater_about_land.xml 58fdb5218596 indra/newview/skins/default/xui/de/floater_inventory_item_properties.xml 58fdb5218596 indra/newview/skins/default/xui/de/floater_tools.xml 58fdb5218596 indra/newview/skins/default/xui/de/inspect_avatar.xml 58fdb5218596 indra/newview/skins/default/xui/de/inspect_group.xml 58fdb5218596 indra/newview/skins/default/xui/de/panel_activeim_row.xml 58fdb5218596 indra/newview/skins/default/xui/de/panel_chat_header.xml 58fdb5218596 indra/newview/skins/default/xui/de/panel_edit_profile.xml 58fdb5218596 indra/newview/skins/default/xui/de/panel_instant_message.xml 58fdb5218596 indra/newview/skins/default/xui/de/panel_profile_view.xml 58fdb5218596 indra/newview/skins/default/xui/de/sidepanel_task_info.xml 58fdb5218596 indra/newview/skins/default/xui/en/floater_about_land.xml 58fdb5218596 indra/newview/skins/default/xui/en/floater_inventory_item_properties.xml 58fdb5218596 indra/newview/skins/default/xui/en/floater_tools.xml 58fdb5218596 indra/newview/skins/default/xui/en/inspect_avatar.xml 58fdb5218596 indra/newview/skins/default/xui/en/inspect_group.xml 58fdb5218596 indra/newview/skins/default/xui/en/panel_activeim_row.xml 58fdb5218596 indra/newview/skins/default/xui/en/panel_chat_header.xml 58fdb5218596 indra/newview/skins/default/xui/en/panel_edit_profile.xml 58fdb5218596 indra/newview/skins/default/xui/en/panel_instant_message.xml 58fdb5218596 indra/newview/skins/default/xui/en/panel_profile_view.xml 58fdb5218596 indra/newview/skins/default/xui/en/sidepanel_task_info.xml 58fdb5218596 indra/newview/skins/default/xui/es/floater_about_land.xml 58fdb5218596 indra/newview/skins/default/xui/es/floater_inventory_item_properties.xml 58fdb5218596 indra/newview/skins/default/xui/es/floater_tools.xml 58fdb5218596 indra/newview/skins/default/xui/es/inspect_avatar.xml 58fdb5218596 indra/newview/skins/default/xui/es/panel_edit_profile.xml 58fdb5218596 indra/newview/skins/default/xui/es/panel_profile_view.xml 58fdb5218596 indra/newview/skins/default/xui/es/sidepanel_task_info.xml 58fdb5218596 indra/newview/skins/default/xui/fr/floater_about_land.xml 58fdb5218596 indra/newview/skins/default/xui/fr/floater_inventory_item_properties.xml 58fdb5218596 indra/newview/skins/default/xui/fr/floater_tools.xml 58fdb5218596 indra/newview/skins/default/xui/fr/inspect_avatar.xml 58fdb5218596 indra/newview/skins/default/xui/fr/inspect_group.xml 58fdb5218596 indra/newview/skins/default/xui/fr/panel_activeim_row.xml 58fdb5218596 indra/newview/skins/default/xui/fr/panel_chat_header.xml 58fdb5218596 indra/newview/skins/default/xui/fr/panel_edit_profile.xml 58fdb5218596 indra/newview/skins/default/xui/fr/panel_instant_message.xml 58fdb5218596 indra/newview/skins/default/xui/fr/panel_profile_view.xml 58fdb5218596 indra/newview/skins/default/xui/fr/sidepanel_task_info.xml 58fdb5218596 indra/newview/skins/default/xui/it/floater_about_land.xml 58fdb5218596 indra/newview/skins/default/xui/it/floater_inventory_item_properties.xml 58fdb5218596 indra/newview/skins/default/xui/it/floater_tools.xml 58fdb5218596 indra/newview/skins/default/xui/it/panel_profile_view.xml 58fdb5218596 indra/newview/skins/default/xui/it/sidepanel_task_info.xml 58fdb5218596 indra/newview/skins/default/xui/ja/floater_about_land.xml 58fdb5218596 indra/newview/skins/default/xui/ja/floater_inventory_item_properties.xml 58fdb5218596 indra/newview/skins/default/xui/ja/floater_tools.xml 58fdb5218596 indra/newview/skins/default/xui/ja/inspect_avatar.xml 58fdb5218596 indra/newview/skins/default/xui/ja/inspect_group.xml 58fdb5218596 indra/newview/skins/default/xui/ja/panel_activeim_row.xml 58fdb5218596 indra/newview/skins/default/xui/ja/panel_chat_header.xml 58fdb5218596 indra/newview/skins/default/xui/ja/panel_instant_message.xml 58fdb5218596 indra/newview/skins/default/xui/ja/panel_profile_view.xml 58fdb5218596 indra/newview/skins/default/xui/ja/sidepanel_task_info.xml 58fdb5218596 indra/newview/skins/default/xui/nl/floater_about_land.xml 58fdb5218596 indra/newview/skins/default/xui/nl/floater_inventory_item_properties.xml 58fdb5218596 indra/newview/skins/default/xui/nl/floater_tools.xml 58fdb5218596 indra/newview/skins/default/xui/pl/floater_about_land.xml 58fdb5218596 indra/newview/skins/default/xui/pl/floater_inventory_item_properties.xml 58fdb5218596 indra/newview/skins/default/xui/pl/floater_tools.xml 58fdb5218596 indra/newview/skins/default/xui/pl/inspect_avatar.xml 58fdb5218596 indra/newview/skins/default/xui/pl/panel_edit_profile.xml 58fdb5218596 indra/newview/skins/default/xui/pl/panel_profile_view.xml 58fdb5218596 indra/newview/skins/default/xui/pl/sidepanel_task_info.xml 58fdb5218596 indra/newview/skins/default/xui/pt/floater_about_land.xml 58fdb5218596 indra/newview/skins/default/xui/pt/floater_inventory_item_properties.xml 58fdb5218596 indra/newview/skins/default/xui/pt/floater_tools.xml 58fdb5218596 indra/newview/skins/default/xui/pt/inspect_avatar.xml 58fdb5218596 indra/newview/skins/default/xui/pt/panel_edit_profile.xml 58fdb5218596 indra/newview/skins/default/xui/pt/panel_profile_view.xml 58fdb5218596 indra/newview/skins/default/xui/pt/sidepanel_task_info.xml 58fdb5218596 Diff: http://codereview.secondlife.com/r/151/diff Testing ------- Thanks, Seth -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110215/63ed5416/attachment.htm From akanevsky at productengine.com Tue Feb 15 16:21:22 2011 From: akanevsky at productengine.com (Anya Kanevsky) Date: Tue, 15 Feb 2011 16:21:22 -0800 Subject: [opensource-dev] Daily Scrum Summary - Tuesday, February 15 Message-ID: Sprint 11, ends 02.21.11 [edit ]Tuesday, February 15 [edit ]General Notes ------------------------------ - MMOTD: Merov [edit ]Team Status ------------------------------ [edit ]Merov Linden ------------------------------ *PAST* - STORM-987 : llimage_libtest: Load and save of image files working. Need to fix the Mac packaging at least before pushing first implementation. - LL meetings *FUTURE* - STORM-987 : llimage_libtest: Fix Mac build, build on Windows, push first implementation *IMPEDIMENTS* - None [edit ]Oz Linden ------------------------------ *PAST* - Integrated pending VS Express changes into viewer-autobuild - also synced to more recent viewer-development - Prep for upcoming VS 2010 Hackathon - Created many open repos needed on bitbucket - Merge Monkey *FUTURE* - Merge Monkey - push approved changes to autobuild - Create wiki page on building viewer w/ autobuild - Associated environment setup pages - Prep for upcoming VS 2010 Hackathon - Check questions on viewer dependencies - Start thread on opensource-dev *IMPEDIMENTS* - none [edit ]Q Linden ------------------------------ *PAST* - unexpected need to spend last night on personal business - unexpected need for lots of email this morning - arrange meeting with wolf on keyboard specs - planning for hackathon *FUTURE* - PO build - lots of meetings - triage *IMPEDIMENTS* - none [edit ]Wolf Linden ------------------------------ *PAST* - Looked into Storm-2 *FUTURE* - ??? *IMPEDIMENTS* - Meeting w/ Q tomorrow - Outstanding (Storm 323 and Storm 2) need to meet with a developer to review [edit ]Bao Linden ------------------------------ *PAST* - STORM-336 - Memory leak *FUTURE* - STORM-336 *IMPEDIMENTS* - none [edit ]Grumpity ProductEngine ------------------------------ *PAST* - crashhunters - thu-fri meetings cancelled due to hackathon - Story issues have Test Plan field - test PO build - procedural change suggestions - STORM-949 (remove actual usernames from UI) discussion - STORM-956 is in sprint *FUTURE* - STORM cleanup in jira - Triage *IMPEDIMENTS* - STORM-954: SL-viewer 2.0 No nearby people when over approxiamately 1000 meters - community request - please incorporate patch into hg repo off bitbucket [edit ]Paul Productengine ------------------------------ *PAST* - BUG STORM-951 (Accidental Self-Muting/Self-Blocking) - WIP. Working on peoblem when messages from blocked objects still arrive. Hard to give estimates i don't know with which problems i'll face. Hope to finish tomorrow. - Reviewed STORM-974 - Updated PE wiki about build differences in Linux and Windows *FUTURE* - BUG STORM-951 (Accidental Self-Muting/Self-Blocking) - Other tickets by priority *IMPEDIMENTS* - none [edit ]Seth Productengine ------------------------------ *PAST* - BUG (STORM-939) Opening multiple inventory floaters causes viewer to lag or even crash - Moved to unassigned so it can be picked by someone who is more familiar with widget construction and initialization code. - BUG (STORM-949) please remove actual usernames from XUI files - Removed Grumpity ProductEngine from en locale xml files. Asked Eli whether replacement strings need translation. - BUG (STORM-984) [VWR-24765] Some Favorites missing from list on login screen - Investigated, found a possible reason for the issue. Waiting for confirmation from Dessie if my assumption was right. *FUTURE* - Pick some other tasks from sprint 11. *IMPEDIMENTS* - BUG (STORM-949) please remove actual usernames from XUI files - Waiting for Eli's reply about translation. - Should Linden actual user names be also removed from XUI files? - BUG (STORM-984) [VWR-24765] Some Favorites missing from list on login screen - Waiting for Dessie's reply. [edit ]Andrey ProductEngine ------------------------------ *PAST* - verified 3 integrated issues - reported 2 issues - started design of following test plans: - region/estate - about land - nearby media - sell/buy land *FUTURE* - pickup next beta build? - continue with test plans design *IMPEDIMENTS* - none [edit ]Wolfpup Lowenhar ------------------------------ *PAST* - RL work. - STORM-236 : Tried suggestions from Richard on local repository and resent him reply and now waiting on his. - OPEN-9 : have this kind of working but needs simplification, also add images and instructions for getting this working so they can be added to the autobuild wiki. - OPEN-33 : Created issue a and discussed it with Oz in IRC *FUTURE* - RL work. - STORM-941 : email Oz and Leyla concerning possible areas that could be causing the problem.(still need to do this) *IMPEDIMENTS* - STORM-236 : waiting for reply from Richard. - Not enough time to actually work on code. [edit ]Jonathan Yap ------------------------------ *PAST* - Preparing system for hackathon -- installing VS2010 is taking about what I thought: 1/2+ day of work. - VWR-22220 (Chat preferences > font size should increase size of input text as well) - Responded to RB entry. Tested patch. Found and fixed font size bug on startup. *FUTURE* - STORM-956 (Ability to mute dialogs by muting object (or object owner)) - Write test plan. *IMPEDIMENTS* - none [edit ]Cummere Mayo ------------------------------ *PAST* - new collaboration post on http://lindenw.blogspot.com - jira work - testing po build (mostly liking it) *FUTURE* - jira stuff - some work on SL-ccnaf project - putting together some jiras regarding need for backups for web page based functions *IMPEDIMENTS* - time - trying to reaplly for jira move permissions -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110215/b438806d/attachment-0001.htm From nickyperian at yahoo.com Tue Feb 15 22:17:07 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Tue, 15 Feb 2011 22:17:07 -0800 (PST) Subject: [opensource-dev] Autobuild with Visual Studio 2010 Express Edition Message-ID: <98010.40573.qm@web43516.mail.sp1.yahoo.com> Autobuild with Visual Studio 2010 Express Edition The autobuild repository is here: http://bitbucket.org/NickyP/autobuild-vcexpress-wip The viewer-autobuild repository is here: http://bitbucket.org/NickyP/viewer-autobuild-vc10-express-wip Self built libraies boost 1_45, json and llqtwebkit are in the downloads section. This doesn't seems a reliable server area so if the auto downloads fail you can work around by downloading each separately and coping to install.cache. directory. You need to setup you command prompt as was done before in vs2005 autobuild. My batch file commands to setup the build environment are: call "C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\bin\vcvars32.bat" set INCLUDE=C:\Program Files\Microsoft SDKs\Windows\v7.1\Include;C:\Program Files\Microsoft SDKs\Windows\v7.1\Include\gl;C:\Program Files (x86)\Microsoft DirectX SDK (June 2010)\Include;%INCLUDE% set LIB=C:\Program Files\Microsoft SDKs\Windows\v7.1\Lib;C:\Program Files\Microsoft SDKs\Windows\v7.1\Lib\x64;C:\Program Files (x86)\Microsoft DirectX SDK (June 2010)\Lib;%LIB% My config batch file commands are: @echo C:\Users\Bill\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug configure -c VC10msbuildRelWithDebInfo -- -DLL_TESTS:BOOL=OFF My build batch file commands is: C:\users\bill\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug build -c VC10msbuildRelWithDebInfo 2>&1 |c:\cygwin\bin\tee Build.log Quirks: A Visual Studio 10 solution.sln is produced but, the solutions and the build tree are in the build-vc80 directory. This is a known issue with an *TODO marking. Using these repositories and libraries I just finished a build with 3 warnings and 3 errors. That is down from 40 warnings and 30 errors earlier today. But -DLL_TESTS:BOOL=OFF so that skews it a little. I think is can be a starting point for Opensource activity in conjunction with hackfest. I would liked to have had a more complete solution but knowledge and time both expired. Hopefully, if more folks will tweak and fix bugs we can have something to run in parallel with the activities Thursday and Friday. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110215/ac9f4766/attachment.htm From merov at lindenlab.com Tue Feb 15 23:13:36 2011 From: merov at lindenlab.com (Philippe (Merov) Bossut) Date: Tue, 15 Feb 2011 23:13:36 -0800 Subject: [opensource-dev] STORM-987 : llimage_libtest Message-ID: Hi, As you know (see Scrum reports), I've been working on this lately: https://jira.secondlife.com/browse/STORM-987 I'm pleased to say that a first version is available off: https://bitbucket.org/merov_linden/viewer-development-storm-987 It doesn't do much for the moment. Just load image files and output them back in other image files. It supports all formats though (bmp, jpg, tga, png and, of course, j2c) which is neat and, as is, can already be used to exercise almost all of the texture compression/decompression code (and all of llimage actually). As a tool, it's not impressive but the point is that it exercises the viewer code itself without having to launch the viewer. It'll make tweaking texture loading/saving algorithmic easier and based on more reproducible data (i.e. a set of known defined image files). I'm planning to add more to this before I move forward in deep Kakadu territories (crucially: add perf stats gathering) but, if you're curious and/or have ideas for this tool, now is the time to speak. I'll also gladly welcome help on Linux build (haven't even tried that yet). Cheers, - Merov -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110215/66fd1f87/attachment.htm From missannotoole at yahoo.com Wed Feb 16 01:39:11 2011 From: missannotoole at yahoo.com (Ann Otoole) Date: Wed, 16 Feb 2011 01:39:11 -0800 (PST) Subject: [opensource-dev] UI - Picks - no delete button In-Reply-To: References: Message-ID: <507027.34606.qm@web120519.mail.ne1.yahoo.com> So exactly how do I delete a pick? Oh never mind. I have to get a third party viewer to do it. Great. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110216/8cc16b45/attachment.htm From geenz at geenzo.com Wed Feb 16 01:42:11 2011 From: geenz at geenzo.com (Geenz) Date: Wed, 16 Feb 2011 03:42:11 -0600 Subject: [opensource-dev] UI - Picks - no delete button In-Reply-To: <507027.34606.qm@web120519.mail.ne1.yahoo.com> References: <507027.34606.qm@web120519.mail.ne1.yahoo.com> Message-ID: It's totally not Right click on the pick -> Delete. It's totally not click on the pick in question, then click on the trash can icon at the bottom of "My Picks". On Wednesday, February 16, 2011 at 3:39 AM, Ann Otoole wrote: > So exactly how do I delete a pick? Oh never mind. I have to get a third party viewer to do it. Great. > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110216/bd4f39bc/attachment.htm From oz at lindenlab.com Wed Feb 16 04:30:01 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Wed, 16 Feb 2011 07:30:01 -0500 Subject: [opensource-dev] Review build Message-ID: <4D5BC349.4020007@lindenlab.com> The next review build is: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_project-3/rev/221226/index.html and includes: STORM-680 Avaline callers are added to the Recent list STORM-974 UI button alignment issues in Landmark panel, About Land window, and Hardware Settings window STORM-979 selection outline from inventory bottom panel buttons is cut at the left side when clicked. STORM-980 Appearance panel / Wear button is too wide these are not yet in viewer-development, but are candidates for integration. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110216/48d39a48/attachment.htm From missannotoole at yahoo.com Wed Feb 16 07:33:39 2011 From: missannotoole at yahoo.com (Ann Otoole) Date: Wed, 16 Feb 2011 07:33:39 -0800 (PST) Subject: [opensource-dev] UI - Picks - no delete button In-Reply-To: References: <507027.34606.qm@web120519.mail.ne1.yahoo.com> Message-ID: <326964.49848.qm@web120513.mail.ne1.yahoo.com> I don't see any trashcan. Expected. Looked. Not there. v2.5. No way to delete picks. ________________________________ From: Geenz To: Ann Otoole Cc: opensource-dev at lists.secondlife.com Sent: Wed, February 16, 2011 4:42:11 AM Subject: Re: [opensource-dev] UI - Picks - no delete button It's totally not Right click on the pick -> Delete. It's totally not click on the pick in question, then click on the trash can icon at the bottom of "My Picks". On Wednesday, February 16, 2011 at 3:39 AM, Ann Otoole wrote: So exactly how do I delete a pick? Oh never mind. I have to get a third party viewer to do it. Great. > > >_______________________________________________ >Policies and (un)subscribe information available here: >http://wiki.secondlife.com/wiki/OpenSource-Dev >Please read the policies before posting to keep unmoderated posting privileges > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110216/5794a71d/attachment-0001.htm From tiggs at lindenlab.com Wed Feb 16 08:18:18 2011 From: tiggs at lindenlab.com (Tiggs Linden) Date: Wed, 16 Feb 2011 11:18:18 -0500 Subject: [opensource-dev] UI - Picks - no delete button In-Reply-To: <326964.49848.qm@web120513.mail.ne1.yahoo.com> References: <507027.34606.qm@web120519.mail.ne1.yahoo.com> <326964.49848.qm@web120513.mail.ne1.yahoo.com> Message-ID: The trashcan is not in the web profile, it's in the viewer sidebar. Same place as it was before. Tiggs On Wed, Feb 16, 2011 at 10:33 AM, Ann Otoole wrote: > > I don't see any trashcan. Expected. Looked. Not there. v2.5. No way to > delete picks. > > ________________________________ > From: Geenz > To: Ann Otoole > Cc: opensource-dev at lists.secondlife.com > Sent: Wed, February 16, 2011 4:42:11 AM > Subject: Re: [opensource-dev] UI - Picks - no delete button > > It's totally not Right click on the pick -> Delete. ?It's totally not click > on the pick in question, then click on the trash can icon at the bottom of > "My Picks". > > On Wednesday, February 16, 2011 at 3:39 AM, Ann Otoole wrote: > > So exactly how do I delete a pick? Oh never mind. I have to get a third > party viewer to do it. Great. > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > From trilobyte550m at gmail.com Wed Feb 16 09:09:13 2011 From: trilobyte550m at gmail.com (Trilo Byte) Date: Wed, 16 Feb 2011 09:09:13 -0800 Subject: [opensource-dev] UI - Picks - no delete button In-Reply-To: <507027.34606.qm@web120519.mail.ne1.yahoo.com> References: <507027.34606.qm@web120519.mail.ne1.yahoo.com> Message-ID: <30C23233-9A0B-49F4-8AC4-798239545F90@gmail.com> On the sidebar, "My Profile" and then click on the "My Picks" tab. Right click on and choose delete, or select and then click that trashcan-looking icon at the bottom right. Same way it's been for more than 6 months. Perhaps the web profile team can add that functionality to what they're doing, but I believe that to be a different group. On Feb 16, 2011, at 1:39 AM, Ann Otoole wrote: > So exactly how do I delete a pick? Oh never mind. I have to get a third party viewer to do it. Great. > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110216/7f828cc9/attachment.htm From danielravennest at gmail.com Wed Feb 16 09:20:08 2011 From: danielravennest at gmail.com (Daniel) Date: Wed, 16 Feb 2011 11:20:08 -0600 Subject: [opensource-dev] UI - Picks - no delete button In-Reply-To: References: Message-ID: <4D5C0748.4050104@gmail.com> What I see on 2.7.0(221148) was: * At first, trashcan not visible in MyProfile > MyPicks. * After using right arrow pick info button and then Edit button, trashcan appears and works * Right click on avatar, and MyProfile from list opens a window, but does not bring up my web profile the first time, it does the second time, but does not show my Picks even though I am the owner of the profile. Having both kinds of profiles and neither of them working right is confusing to users. > From: Ann Otoole > > I don't see any trashcan. Expected. Looked. Not there. v2.5. No way to delete > picks. > > > From merov at lindenlab.com Wed Feb 16 10:09:16 2011 From: merov at lindenlab.com (Merov Linden) Date: Wed, 16 Feb 2011 18:09:16 -0000 Subject: [opensource-dev] Review Request: STORM-977 llmediaplugintest shows up even though -DLL_TESTS:BOOL=OFF has been used In-Reply-To: <20110208164621.29141.49689@domU-12-31-38-00-90-68.compute-1.internal> References: <20110208164621.29141.49689@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110216180916.13394.90800@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/144/#review366 ----------------------------------------------------------- If you want to bypass the entire make file for llplugintest, it seems to me better to do it at the indra/CMakeLists.txt level. There's only one line in there that's relevant to llplugintest. Could you try that out? - Merov On Feb. 8, 2011, 8:46 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/144/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2011, 8:46 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > llmediaplugintest shows up to be compiled even though -DLL_TESTS:BOOL=OFF has been used on the command line. > > This cmake file does not use the call to LL_ADD_PROJECT_UNIT_TESTS that other cmake files do. > > LL_ADD_PROJECT_UNIT_TESTS is usually wrapped with if(LL_TESTS) > > I could not figure out which lines suppress the inclusion of copy_plugintest_libs and llmediaplugintest into the list of what is to be built so wrapped the entire file around if(LL_TESTS). > > If there is some better way to more exactly target these two items please point it out. > > > This addresses bug STORM-977. > http://jira.secondlife.com/browse/STORM-977 > > > Diffs > ----- > > indra/test_apps/llplugintest/CMakeLists.txt b0bceb572090 > > Diff: http://codereview.secondlife.com/r/144/diff > > > Testing > ------- > > > Thanks, > > Jonathan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110216/5b84bd2b/attachment.htm From merov at lindenlab.com Wed Feb 16 10:15:10 2011 From: merov at lindenlab.com (Merov Linden) Date: Wed, 16 Feb 2011 18:15:10 -0000 Subject: [opensource-dev] Review Request: STORM-977 llmediaplugintest shows up even though -DLL_TESTS:BOOL=OFF has been used In-Reply-To: <20110208184145.29444.77319@domU-12-31-38-00-90-68.compute-1.internal> References: <20110208184145.29444.77319@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110216181510.13390.83004@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 8, 2011, 10:41 a.m., Boroondas Gupte wrote: > > > If there is some better way to more exactly target these two items please point it out. > > > > You should be able to get the same effect when wrapping the only place where this file is referenced in a LL_TESTS condition, i.e., change https://bitbucket.org/lindenlab/viewer-development/src/b0bceb572090/indra/CMakeLists.txt#cl-74 from > > if (NOT LINUX) > > to > > if (LL_TESTS AND NOT LINUX) > > (and the same for the endif, of course) > > > > Whether that's a better place, I don't know. > > > > Though, I think LL_TESTS is the wrong conditional here, anyway. LL_TESTS is for enabling unit and integration tests. llplugintest however, I have learned on IRC today, seems to be a fully separate program based on and similar to uBrowser that could be used to load and test individual llmediaplugins, would it communicate with them in the same way the viewer does. (Which, according to MichelleZ, it doesn't, thus potentially misleading developers of new plugins.) > > > > It should probably not be built unless explicitly requested, thus a new variable, defaulting to OFF and different from LL_TESTS would suit this much better. Or, just delete the referencing at https://bitbucket.org/lindenlab/viewer-development/src/b0bceb572090/indra/CMakeLists.txt#cl-75 completely, thus unconditionally removing it from the dependencies of the viewer itself, and have those that want to build it explicitly state it as a build target. I'm afraid that, if that app is not built by default, it will rapidly rot and become unmaintainable. There is value having it built (even if not used) by LL devs and TC at least (who all build with LL_TESTS on): make sure we don't add viewer dependencies where we don't need any and maintain a clean separation of concerns between plugins and hosts. - Merov ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/144/#review347 ----------------------------------------------------------- On Feb. 8, 2011, 8:46 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/144/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2011, 8:46 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > llmediaplugintest shows up to be compiled even though -DLL_TESTS:BOOL=OFF has been used on the command line. > > This cmake file does not use the call to LL_ADD_PROJECT_UNIT_TESTS that other cmake files do. > > LL_ADD_PROJECT_UNIT_TESTS is usually wrapped with if(LL_TESTS) > > I could not figure out which lines suppress the inclusion of copy_plugintest_libs and llmediaplugintest into the list of what is to be built so wrapped the entire file around if(LL_TESTS). > > If there is some better way to more exactly target these two items please point it out. > > > This addresses bug STORM-977. > http://jira.secondlife.com/browse/STORM-977 > > > Diffs > ----- > > indra/test_apps/llplugintest/CMakeLists.txt b0bceb572090 > > Diff: http://codereview.secondlife.com/r/144/diff > > > Testing > ------- > > > Thanks, > > Jonathan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110216/e7cd457f/attachment.htm From jhwelch at gmail.com Wed Feb 16 11:32:19 2011 From: jhwelch at gmail.com (Jonathan Yap) Date: Wed, 16 Feb 2011 19:32:19 -0000 Subject: [opensource-dev] Review Request: STORM-977 llmediaplugintest shows up even though -DLL_TESTS:BOOL=OFF has been used In-Reply-To: <20110208164621.29141.49689@domU-12-31-38-00-90-68.compute-1.internal> References: <20110208164621.29141.49689@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110216193219.13418.64104@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/144/ ----------------------------------------------------------- (Updated Feb. 16, 2011, 11:32 a.m.) Review request for Viewer. Changes ------- Updated code per Merov's request and Boroondas' suggestion. Summary ------- llmediaplugintest shows up to be compiled even though -DLL_TESTS:BOOL=OFF has been used on the command line. This cmake file does not use the call to LL_ADD_PROJECT_UNIT_TESTS that other cmake files do. LL_ADD_PROJECT_UNIT_TESTS is usually wrapped with if(LL_TESTS) I could not figure out which lines suppress the inclusion of copy_plugintest_libs and llmediaplugintest into the list of what is to be built so wrapped the entire file around if(LL_TESTS). If there is some better way to more exactly target these two items please point it out. This addresses bug STORM-977. http://jira.secondlife.com/browse/STORM-977 Diffs (updated) ----- indra/CMakeLists.txt b0bceb572090 indra/test_apps/llplugintest/CMakeLists.txt b0bceb572090 Diff: http://codereview.secondlife.com/r/144/diff Testing ------- Thanks, Jonathan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110216/ce64511f/attachment-0001.htm From merov at lindenlab.com Wed Feb 16 12:07:10 2011 From: merov at lindenlab.com (Merov Linden) Date: Wed, 16 Feb 2011 20:07:10 -0000 Subject: [opensource-dev] Review Request: STORM-977 llmediaplugintest shows up even though -DLL_TESTS:BOOL=OFF has been used In-Reply-To: <20110216193219.13418.64104@domU-12-31-38-00-90-68.compute-1.internal> References: <20110216193219.13418.64104@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110216200710.13492.13808@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/144/#review368 ----------------------------------------------------------- Ship it! Cleaner! :) I'm assuming you built on Windows and it doesn't create weird errors down the road. - Merov On Feb. 16, 2011, 11:32 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/144/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2011, 11:32 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > llmediaplugintest shows up to be compiled even though -DLL_TESTS:BOOL=OFF has been used on the command line. > > This cmake file does not use the call to LL_ADD_PROJECT_UNIT_TESTS that other cmake files do. > > LL_ADD_PROJECT_UNIT_TESTS is usually wrapped with if(LL_TESTS) > > I could not figure out which lines suppress the inclusion of copy_plugintest_libs and llmediaplugintest into the list of what is to be built so wrapped the entire file around if(LL_TESTS). > > If there is some better way to more exactly target these two items please point it out. > > > This addresses bug STORM-977. > http://jira.secondlife.com/browse/STORM-977 > > > Diffs > ----- > > indra/CMakeLists.txt b0bceb572090 > indra/test_apps/llplugintest/CMakeLists.txt b0bceb572090 > > Diff: http://codereview.secondlife.com/r/144/diff > > > Testing > ------- > > > Thanks, > > Jonathan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110216/fbb2e705/attachment.htm From sllists at boroon.dasgupta.ch Wed Feb 16 12:36:24 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Wed, 16 Feb 2011 20:36:24 -0000 Subject: [opensource-dev] Review Request: STORM-977 llmediaplugintest shows up even though -DLL_TESTS:BOOL=OFF has been used In-Reply-To: <20110208184145.29444.77319@domU-12-31-38-00-90-68.compute-1.internal> References: <20110208184145.29444.77319@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110216203624.15549.56285@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 8, 2011, 10:41 a.m., Boroondas Gupte wrote: > > > If there is some better way to more exactly target these two items please point it out. > > > > You should be able to get the same effect when wrapping the only place where this file is referenced in a LL_TESTS condition, i.e., change https://bitbucket.org/lindenlab/viewer-development/src/b0bceb572090/indra/CMakeLists.txt#cl-74 from > > if (NOT LINUX) > > to > > if (LL_TESTS AND NOT LINUX) > > (and the same for the endif, of course) > > > > Whether that's a better place, I don't know. > > > > Though, I think LL_TESTS is the wrong conditional here, anyway. LL_TESTS is for enabling unit and integration tests. llplugintest however, I have learned on IRC today, seems to be a fully separate program based on and similar to uBrowser that could be used to load and test individual llmediaplugins, would it communicate with them in the same way the viewer does. (Which, according to MichelleZ, it doesn't, thus potentially misleading developers of new plugins.) > > > > It should probably not be built unless explicitly requested, thus a new variable, defaulting to OFF and different from LL_TESTS would suit this much better. Or, just delete the referencing at https://bitbucket.org/lindenlab/viewer-development/src/b0bceb572090/indra/CMakeLists.txt#cl-75 completely, thus unconditionally removing it from the dependencies of the viewer itself, and have those that want to build it explicitly state it as a build target. > > Merov Linden wrote: > I'm afraid that, if that app is not built by default, it will rapidly rot and become unmaintainable. There is value having it built (even if not used) by LL devs and TC at least (who all build with LL_TESTS on): make sure we don't add viewer dependencies where we don't need any and maintain a clean separation of concerns between plugins and hosts. I can see that point. Though, I'd still like a separate variable, if alone to avoid people from mistaking llplugintest for a unit or integration test, like I initially did. Just have that (new) variable default on ON, then, rather than OFF. - Boroondas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/144/#review347 ----------------------------------------------------------- On Feb. 16, 2011, 11:32 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/144/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2011, 11:32 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > llmediaplugintest shows up to be compiled even though -DLL_TESTS:BOOL=OFF has been used on the command line. > > This cmake file does not use the call to LL_ADD_PROJECT_UNIT_TESTS that other cmake files do. > > LL_ADD_PROJECT_UNIT_TESTS is usually wrapped with if(LL_TESTS) > > I could not figure out which lines suppress the inclusion of copy_plugintest_libs and llmediaplugintest into the list of what is to be built so wrapped the entire file around if(LL_TESTS). > > If there is some better way to more exactly target these two items please point it out. > > > This addresses bug STORM-977. > http://jira.secondlife.com/browse/STORM-977 > > > Diffs > ----- > > indra/CMakeLists.txt b0bceb572090 > indra/test_apps/llplugintest/CMakeLists.txt b0bceb572090 > > Diff: http://codereview.secondlife.com/r/144/diff > > > Testing > ------- > > > Thanks, > > Jonathan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110216/2643994c/attachment.htm From jhwelch at gmail.com Wed Feb 16 12:44:02 2011 From: jhwelch at gmail.com (Jonathan Yap) Date: Wed, 16 Feb 2011 20:44:02 -0000 Subject: [opensource-dev] Review Request: STORM-977 llmediaplugintest shows up even though -DLL_TESTS:BOOL=OFF has been used In-Reply-To: <20110208184145.29444.77319@domU-12-31-38-00-90-68.compute-1.internal> References: <20110208184145.29444.77319@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110216204402.13470.91262@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 8, 2011, 10:41 a.m., Boroondas Gupte wrote: > > > If there is some better way to more exactly target these two items please point it out. > > > > You should be able to get the same effect when wrapping the only place where this file is referenced in a LL_TESTS condition, i.e., change https://bitbucket.org/lindenlab/viewer-development/src/b0bceb572090/indra/CMakeLists.txt#cl-74 from > > if (NOT LINUX) > > to > > if (LL_TESTS AND NOT LINUX) > > (and the same for the endif, of course) > > > > Whether that's a better place, I don't know. > > > > Though, I think LL_TESTS is the wrong conditional here, anyway. LL_TESTS is for enabling unit and integration tests. llplugintest however, I have learned on IRC today, seems to be a fully separate program based on and similar to uBrowser that could be used to load and test individual llmediaplugins, would it communicate with them in the same way the viewer does. (Which, according to MichelleZ, it doesn't, thus potentially misleading developers of new plugins.) > > > > It should probably not be built unless explicitly requested, thus a new variable, defaulting to OFF and different from LL_TESTS would suit this much better. Or, just delete the referencing at https://bitbucket.org/lindenlab/viewer-development/src/b0bceb572090/indra/CMakeLists.txt#cl-75 completely, thus unconditionally removing it from the dependencies of the viewer itself, and have those that want to build it explicitly state it as a build target. > > Merov Linden wrote: > I'm afraid that, if that app is not built by default, it will rapidly rot and become unmaintainable. There is value having it built (even if not used) by LL devs and TC at least (who all build with LL_TESTS on): make sure we don't add viewer dependencies where we don't need any and maintain a clean separation of concerns between plugins and hosts. > > Boroondas Gupte wrote: > I can see that point. Though, I'd still like a separate variable, if alone to avoid people from mistaking llplugintest for a unit or integration test, like I initially did. Just have that (new) variable default on ON, then, rather than OFF. New variable name aside, would it make it clearer what this module does if it were renamed to something more obvious? One person pointed out to me that lltestplugin might be a better choice. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/144/#review347 ----------------------------------------------------------- On Feb. 16, 2011, 11:32 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/144/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2011, 11:32 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > llmediaplugintest shows up to be compiled even though -DLL_TESTS:BOOL=OFF has been used on the command line. > > This cmake file does not use the call to LL_ADD_PROJECT_UNIT_TESTS that other cmake files do. > > LL_ADD_PROJECT_UNIT_TESTS is usually wrapped with if(LL_TESTS) > > I could not figure out which lines suppress the inclusion of copy_plugintest_libs and llmediaplugintest into the list of what is to be built so wrapped the entire file around if(LL_TESTS). > > If there is some better way to more exactly target these two items please point it out. > > > This addresses bug STORM-977. > http://jira.secondlife.com/browse/STORM-977 > > > Diffs > ----- > > indra/CMakeLists.txt b0bceb572090 > indra/test_apps/llplugintest/CMakeLists.txt b0bceb572090 > > Diff: http://codereview.secondlife.com/r/144/diff > > > Testing > ------- > > > Thanks, > > Jonathan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110216/b1d277d0/attachment-0001.htm From oz at lindenlab.com Wed Feb 16 13:01:51 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Wed, 16 Feb 2011 16:01:51 -0500 Subject: [opensource-dev] Hacking up to Visual Studio 2010 ... Message-ID: <4D5C3B3F.5090603@lindenlab.com> Tomorrow and Friday (Feb 17 & 18), Linden Lab is going to be holding an in-house Hackathon (stopping work on many other things, getting many developers together all at once, and focusing on getting a lot done in short time) to upgrade our builds of all our libraries and the viewer to a new toolchain, including our new package management tool (autobuild ) and Visual Studio 2010 for Windows (yes... about time... whatever... we're doing it). Our goals are simply stated: 1. Get all open source components into repositories under hg.secondlife.com (eg bitbucket.org/lindenlab/). All the third party components (things not created by LL) that we incorporate will be in repositories named with the prefix "3p-". Most of these repositories exist now, but not all have sources in them yet. 2. Get each component packaged with an autobuild configuration for whatever platforms it is needed on. 3. Get each component needed on Windows building under autobuild with VS 2010. 4. Get a TeamCity-automated build configured for each component repository with the resulting prebuilds of open components uploaded to public directories. 5. Get the viewer built using the resulting prebuilt libraries, also under autobuild with VS 2010. We also expect to integrate some automated viewer testing into our automated viewer builds, but none of that will be externally visible. If you make a chart with a row for each component, and a column for each of 1 through 4 above, it's a lot of boxes to fill in... many have already been done: there are some complete rows, but it's still a big job. I will be providing public updates on the wiki (form and location TBD... watch this thread) and on the #opensl IRC channel of how we're doing and the status of each public repository. A non-goal for the Lindens is building the components with Visual Studio Express. There is currently a limitation (see OPEN-1 in jira) that makes using Express cumbersome (it requires separate configuration). We do recognize that Express is important to open developers, and want it to be supported, but there's only so much we can do ourselves in two days. There is an autobuild configuration checked in for building the viewer under autobuild including VS Express: http://bitbucket.org/oz_linden/viewer-autobuild I'm going to try to get some supporting documentation up on the wiki today or early tomorrow. It should be possible for open developers to help us test whether or not the component builds can be used in Express as we go along. If people want to do that and feed me changes, I'll try to get them incorporated in real time as much as possible. Once all this is done (and it probably will not be merged to viewer-development immediately after the hackathon), this new toolchain will be the "supported" way to build the viewer and its dependencies, which means that if you really need to build with other tools, you'll have to work out how to do so - we'll consider accepting changes to support them so long as they're reasonably clean and don't break the standard way of doing it. Maintaining support for building with older versions of Visual Studio will _not_ be a goal, and getting review time for them will probably be hard. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110216/8f98fc99/attachment.htm From jhwelch at gmail.com Wed Feb 16 14:10:26 2011 From: jhwelch at gmail.com (Jonathan Yap) Date: Wed, 16 Feb 2011 22:10:26 -0000 Subject: [opensource-dev] Review Request: STORM-977 llmediaplugintest shows up even though -DLL_TESTS:BOOL=OFF has been used In-Reply-To: <20110216200710.13492.13808@domU-12-31-38-00-90-68.compute-1.internal> References: <20110216200710.13492.13808@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110216221026.13393.74511@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 16, 2011, 12:07 p.m., Merov Linden wrote: > > Cleaner! :) I'm assuming you built on Windows and it doesn't create weird errors down the road. I have built it on windows, started the viewer up, walked/flew around a bit. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/144/#review368 ----------------------------------------------------------- On Feb. 16, 2011, 11:32 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/144/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2011, 11:32 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > llmediaplugintest shows up to be compiled even though -DLL_TESTS:BOOL=OFF has been used on the command line. > > This cmake file does not use the call to LL_ADD_PROJECT_UNIT_TESTS that other cmake files do. > > LL_ADD_PROJECT_UNIT_TESTS is usually wrapped with if(LL_TESTS) > > I could not figure out which lines suppress the inclusion of copy_plugintest_libs and llmediaplugintest into the list of what is to be built so wrapped the entire file around if(LL_TESTS). > > If there is some better way to more exactly target these two items please point it out. > > > This addresses bug STORM-977. > http://jira.secondlife.com/browse/STORM-977 > > > Diffs > ----- > > indra/CMakeLists.txt b0bceb572090 > indra/test_apps/llplugintest/CMakeLists.txt b0bceb572090 > > Diff: http://codereview.secondlife.com/r/144/diff > > > Testing > ------- > > > Thanks, > > Jonathan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110216/8c0068a8/attachment.htm From sllists at boroon.dasgupta.ch Wed Feb 16 16:02:46 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Thu, 17 Feb 2011 00:02:46 -0000 Subject: [opensource-dev] Review Request: STORM-977 llmediaplugintest shows up even though -DLL_TESTS:BOOL=OFF has been used In-Reply-To: <20110208184145.29444.77319@domU-12-31-38-00-90-68.compute-1.internal> References: <20110208184145.29444.77319@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110217000246.13401.67090@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 8, 2011, 10:41 a.m., Boroondas Gupte wrote: > > > If there is some better way to more exactly target these two items please point it out. > > > > You should be able to get the same effect when wrapping the only place where this file is referenced in a LL_TESTS condition, i.e., change https://bitbucket.org/lindenlab/viewer-development/src/b0bceb572090/indra/CMakeLists.txt#cl-74 from > > if (NOT LINUX) > > to > > if (LL_TESTS AND NOT LINUX) > > (and the same for the endif, of course) > > > > Whether that's a better place, I don't know. > > > > Though, I think LL_TESTS is the wrong conditional here, anyway. LL_TESTS is for enabling unit and integration tests. llplugintest however, I have learned on IRC today, seems to be a fully separate program based on and similar to uBrowser that could be used to load and test individual llmediaplugins, would it communicate with them in the same way the viewer does. (Which, according to MichelleZ, it doesn't, thus potentially misleading developers of new plugins.) > > > > It should probably not be built unless explicitly requested, thus a new variable, defaulting to OFF and different from LL_TESTS would suit this much better. Or, just delete the referencing at https://bitbucket.org/lindenlab/viewer-development/src/b0bceb572090/indra/CMakeLists.txt#cl-75 completely, thus unconditionally removing it from the dependencies of the viewer itself, and have those that want to build it explicitly state it as a build target. > > Merov Linden wrote: > I'm afraid that, if that app is not built by default, it will rapidly rot and become unmaintainable. There is value having it built (even if not used) by LL devs and TC at least (who all build with LL_TESTS on): make sure we don't add viewer dependencies where we don't need any and maintain a clean separation of concerns between plugins and hosts. > > Boroondas Gupte wrote: > I can see that point. Though, I'd still like a separate variable, if alone to avoid people from mistaking llplugintest for a unit or integration test, like I initially did. Just have that (new) variable default on ON, then, rather than OFF. > > Jonathan Yap wrote: > New variable name aside, would it make it clearer what this module does if it were renamed to something more obvious? One person pointed out to me that lltestplugin might be a better choice. > New variable name aside, would it make it clearer what this module does if it were renamed to something more obvious? Yes! Though to what? > One person pointed out to me that lltestplugin might be a better choice. That might have been me, back when I thought it was a test plugin, which it apparently isn't, either. - Boroondas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/144/#review347 ----------------------------------------------------------- On Feb. 16, 2011, 11:32 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/144/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2011, 11:32 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > llmediaplugintest shows up to be compiled even though -DLL_TESTS:BOOL=OFF has been used on the command line. > > This cmake file does not use the call to LL_ADD_PROJECT_UNIT_TESTS that other cmake files do. > > LL_ADD_PROJECT_UNIT_TESTS is usually wrapped with if(LL_TESTS) > > I could not figure out which lines suppress the inclusion of copy_plugintest_libs and llmediaplugintest into the list of what is to be built so wrapped the entire file around if(LL_TESTS). > > If there is some better way to more exactly target these two items please point it out. > > > This addresses bug STORM-977. > http://jira.secondlife.com/browse/STORM-977 > > > Diffs > ----- > > indra/CMakeLists.txt b0bceb572090 > indra/test_apps/llplugintest/CMakeLists.txt b0bceb572090 > > Diff: http://codereview.secondlife.com/r/144/diff > > > Testing > ------- > > > Thanks, > > Jonathan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110217/f92e4da5/attachment-0001.htm From akanevsky at productengine.com Wed Feb 16 17:11:54 2011 From: akanevsky at productengine.com (Anya Kanevsky) Date: Wed, 16 Feb 2011 17:11:54 -0800 Subject: [opensource-dev] Daily Scrum Summary - Wednesday, February 16 Message-ID: Sprint 11, ends 02.21.11 Wednesday, February 16 General Notes ------------------------------ - Daily Scrum meetings cancelled Thu & Fri due to hackathon. Please send your report by email. - Monday is a holiday. - MMOTD: Oz Team Status ------------------------------ Merov Linden ------------------------------ *PAST* - STORM-987 : llimage_libtest: First implementation pushed to hg dev repo. Emailed opensource-dev about it. - "Viewer Design and Coding" meeting - VWR Triage - Did code reviews and moved some stalled JIRAs for sprint 11 through the swim lanes *FUTURE* - STORM-987 : llimage_libtest: Output image data and compression/decompression perf, document this tool on the wiki somewhere *IMPEDIMENTS* - None Oz Linden ------------------------------ *PAST* - Push changes to autobuild: - [OPEN-2] better progress messages in autobuild configure - [OPEN-7] autobuild: add selection of the config-file using an environment variable - [OPEN-8] autobuild: add selection of the configuration using an environment variable - [OPEN-10] fix autobuild's setup.py - [OPEN-31] use conventional short form arguments in autobuild - Prep for upcoming VS 2010 Hackathon - Created status columns in tracking spreadsheet - Sent queries on questions re: viewer dependencies - Merge Monkey - Posted review build - Viewer 2 Evolution meeting *FUTURE* - Merge Monkey - 3 issues in queue - Create wiki page on building viewer w/ autobuild - Associated environment setup pages - Prep for upcoming VS 2010 Hackathon - Start thread on opensource-dev - Open Development meeting - Hackathon *IMPEDIMENTS* - none Q Linden ------------------------------ *PAST* - lots of meetings - triage - User group - planning for hackathon *FUTURE* - meeting with wolf on keyboard specs - internal training - PO build *IMPEDIMENTS* - none Wolf Linden ------------------------------ *PAST* - Busy with other projects *FUTURE* - Storm-2 - Storm-323 - Meeting with Q re: Keyboard Shortcuts *IMPEDIMENTS* - Need developer input on Storm-2, Storm-323 (hopefully cover with Q) Bao Linden ------------------------------ *PAST* - STORM-336 - Memory leak - Partial fix ready for vertex buffer leak - there?s more there, but need time to investigate - merging v-d into project *FUTURE* - STORM-336 *IMPEDIMENTS* - none Grumpity ProductEngine ------------------------------ *PAST* - VWR triage - Scrum & procedural discussions - followup on bulk editing issues *FUTURE* - STORM cleanup in jira - Triage *IMPEDIMENTS* - none Seth Productengine ------------------------------ *PAST* - BUG (STORM-949) please remove actual usernames from XUI files - Fixed, posted patch to the review board: https://codereview.secondlife.com/r/151/ - BUG (STORM-984) [VWR-24765] Some Favorites missing from list on login screen - Searching for other possible reasons for the problem except for invalid landmarks locations. Need steps to reproduce. *FUTURE* - BUG (STORM-984) [VWR-24765] Some Favorites missing from list on login screen - Estimated: 3-4 hours. - Task (STORM-34) As a User, I want a list of my favorite locations available on the login screen so i can log in to SL right where I want to be - Investigate related problems. *IMPEDIMENTS* - none Vadim ProductEngine ------------------------------ *PAST* - Story STORM-2 (Customizable viewer layouts): - Handling multiple instances of a floater (tested on inventory floaters): Done. - Handling web profiles: WIP. - Code review. *FUTURE* - Continue working on STORM-2. *IMPEDIMENTS* - Who's gonna create out-of-the-box viewer layouts for STORM-2? Andrey ProductEngine ------------------------------ *PAST* - passed smoke & integrity tests against 2.6.0 Beta1 r221037, see IQA-83 for more details - continued test plans design: About Land, Region/Estate, Nearby Media, Sell/Buy Land *FUTURE* - review and publish test plans in TPEQA Test plans folder *IMPEDIMENTS* - none Wolfpup Lowenhar ------------------------------ *PAST* - RL work. - STORM-941 : emailed Oz and Leyla concerning possible areas that could be causing the problem.(waiting on reply which might come after the Hackathon) *FUTURE* - RL work. - Hackathon (maybe) *IMPEDIMENTS* - STORM-236 : waiting for reply from Richard. - Not enough time to actually work on code. Jonathan Yap ------------------------------ *PAST* - STORM-956 (Ability to mute dialogs by muting object (or object owner)) - Wrote test plan. - STORM-990 (The arrow in the bottom right of the Landmark panel points down) - Rejected by Oz due to merge issue. Merged with current version of v-d and repushed to bitbucket. - STORM-954 (SL-viewer 2.0 No nearby people when over approxiamately 1000 meters) - Converted .diff file to hg repo on bitbucket. - STORM-974 (UI button alignment issues in Landmark panel, About Land window, and Hardware Settings window) - STORM-979 (selection outline from inventory bottom panel buttons is cut at the left side when clicked) - STORM-980 (Appearance panel / Wear button is too wide) - Tested changes with all language options and wrote jira comments. - Found some unrelated internationalization errors which I will write up. - STORM-1002 (Cannot delete broken links) - Updated jira with instructions on how to create a broken link. - VWR-24874 (Unblocking/blocking name sometimes deletes identically named entry, but of different TYPE) - Wrote this jira as a result of testing STORM - 956. *FUTURE* *IMPEDIMENTS* - STORM - 956 - File message_template.msg needs to be pushed into viewer code tree from server code tree. Cummere Mayo ------------------------------ *PAST* - created a few jiras - testing on po, v-d, and test build - all three seem good to ship - working on visual aid project for ccnaf *FUTURE* - unknown *IMPEDIMENTS* - none -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110216/017a46d1/attachment-0001.htm From akanevsky at productengine.com Thu Feb 17 02:03:12 2011 From: akanevsky at productengine.com (Anya Kanevsky) Date: Thu, 17 Feb 2011 02:03:12 -0800 Subject: [opensource-dev] UI - Picks - no delete button In-Reply-To: <4D5C0748.4050104@gmail.com> References: <4D5C0748.4050104@gmail.com> Message-ID: Daniel, please file a jira for the Picks problem, preferably with screenshots. Please file any jiras related to Web profiles as separate issues. Thanks! 2011/2/16 Daniel > What I see on 2.7.0(221148) was: > > * At first, trashcan not visible in MyProfile > MyPicks. > * After using right arrow pick info button and then Edit button, > trashcan appears and works > * Right click on avatar, and MyProfile from list opens a window, but > does not bring up my web profile the first time, > it does the second time, but does not show my Picks even though I am > the owner of the profile. > > Having both kinds of profiles and neither of them working right is > confusing to users. > > > From: Ann Otoole > > > > I don't see any trashcan. Expected. Looked. Not there. v2.5. No way to > delete > > picks. > > > > > > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110217/397d9857/attachment.htm From vsavchuk at productengine.com Thu Feb 17 07:37:48 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Thu, 17 Feb 2011 15:37:48 -0000 Subject: [opensource-dev] Review Request: (STORM-949) please remove actual usernames from XUI files In-Reply-To: <20110215224859.13396.96684@domU-12-31-38-00-90-68.compute-1.internal> References: <20110215224859.13396.96684@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110217153748.13395.94717@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/151/#review373 ----------------------------------------------------------- Ship it! Looks fine. :-) - Vadim On Feb. 15, 2011, 2:48 p.m., Seth ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/151/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2011, 2:48 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Actual usernames are replaced with "TestString PleaseIgnore" in EN locale with setting translate="false" flag for affected widgets. > Translated phrases with actual usernames are removed from XUI files in other locales. > > > This addresses bug STORM-949. > http://jira.secondlife.com/browse/STORM-949 > > > Diffs > ----- > > indra/newview/skins/default/xui/da/floater_about_land.xml 58fdb5218596 > indra/newview/skins/default/xui/da/floater_inventory_item_properties.xml 58fdb5218596 > indra/newview/skins/default/xui/da/floater_tools.xml 58fdb5218596 > indra/newview/skins/default/xui/da/inspect_avatar.xml 58fdb5218596 > indra/newview/skins/default/xui/da/panel_edit_profile.xml 58fdb5218596 > indra/newview/skins/default/xui/da/panel_profile_view.xml 58fdb5218596 > indra/newview/skins/default/xui/da/sidepanel_task_info.xml 58fdb5218596 > indra/newview/skins/default/xui/de/floater_about_land.xml 58fdb5218596 > indra/newview/skins/default/xui/de/floater_inventory_item_properties.xml 58fdb5218596 > indra/newview/skins/default/xui/de/floater_tools.xml 58fdb5218596 > indra/newview/skins/default/xui/de/inspect_avatar.xml 58fdb5218596 > indra/newview/skins/default/xui/de/inspect_group.xml 58fdb5218596 > indra/newview/skins/default/xui/de/panel_activeim_row.xml 58fdb5218596 > indra/newview/skins/default/xui/de/panel_chat_header.xml 58fdb5218596 > indra/newview/skins/default/xui/de/panel_edit_profile.xml 58fdb5218596 > indra/newview/skins/default/xui/de/panel_instant_message.xml 58fdb5218596 > indra/newview/skins/default/xui/de/panel_profile_view.xml 58fdb5218596 > indra/newview/skins/default/xui/de/sidepanel_task_info.xml 58fdb5218596 > indra/newview/skins/default/xui/en/floater_about_land.xml 58fdb5218596 > indra/newview/skins/default/xui/en/floater_inventory_item_properties.xml 58fdb5218596 > indra/newview/skins/default/xui/en/floater_tools.xml 58fdb5218596 > indra/newview/skins/default/xui/en/inspect_avatar.xml 58fdb5218596 > indra/newview/skins/default/xui/en/inspect_group.xml 58fdb5218596 > indra/newview/skins/default/xui/en/panel_activeim_row.xml 58fdb5218596 > indra/newview/skins/default/xui/en/panel_chat_header.xml 58fdb5218596 > indra/newview/skins/default/xui/en/panel_edit_profile.xml 58fdb5218596 > indra/newview/skins/default/xui/en/panel_instant_message.xml 58fdb5218596 > indra/newview/skins/default/xui/en/panel_profile_view.xml 58fdb5218596 > indra/newview/skins/default/xui/en/sidepanel_task_info.xml 58fdb5218596 > indra/newview/skins/default/xui/es/floater_about_land.xml 58fdb5218596 > indra/newview/skins/default/xui/es/floater_inventory_item_properties.xml 58fdb5218596 > indra/newview/skins/default/xui/es/floater_tools.xml 58fdb5218596 > indra/newview/skins/default/xui/es/inspect_avatar.xml 58fdb5218596 > indra/newview/skins/default/xui/es/panel_edit_profile.xml 58fdb5218596 > indra/newview/skins/default/xui/es/panel_profile_view.xml 58fdb5218596 > indra/newview/skins/default/xui/es/sidepanel_task_info.xml 58fdb5218596 > indra/newview/skins/default/xui/fr/floater_about_land.xml 58fdb5218596 > indra/newview/skins/default/xui/fr/floater_inventory_item_properties.xml 58fdb5218596 > indra/newview/skins/default/xui/fr/floater_tools.xml 58fdb5218596 > indra/newview/skins/default/xui/fr/inspect_avatar.xml 58fdb5218596 > indra/newview/skins/default/xui/fr/inspect_group.xml 58fdb5218596 > indra/newview/skins/default/xui/fr/panel_activeim_row.xml 58fdb5218596 > indra/newview/skins/default/xui/fr/panel_chat_header.xml 58fdb5218596 > indra/newview/skins/default/xui/fr/panel_edit_profile.xml 58fdb5218596 > indra/newview/skins/default/xui/fr/panel_instant_message.xml 58fdb5218596 > indra/newview/skins/default/xui/fr/panel_profile_view.xml 58fdb5218596 > indra/newview/skins/default/xui/fr/sidepanel_task_info.xml 58fdb5218596 > indra/newview/skins/default/xui/it/floater_about_land.xml 58fdb5218596 > indra/newview/skins/default/xui/it/floater_inventory_item_properties.xml 58fdb5218596 > indra/newview/skins/default/xui/it/floater_tools.xml 58fdb5218596 > indra/newview/skins/default/xui/it/panel_profile_view.xml 58fdb5218596 > indra/newview/skins/default/xui/it/sidepanel_task_info.xml 58fdb5218596 > indra/newview/skins/default/xui/ja/floater_about_land.xml 58fdb5218596 > indra/newview/skins/default/xui/ja/floater_inventory_item_properties.xml 58fdb5218596 > indra/newview/skins/default/xui/ja/floater_tools.xml 58fdb5218596 > indra/newview/skins/default/xui/ja/inspect_avatar.xml 58fdb5218596 > indra/newview/skins/default/xui/ja/inspect_group.xml 58fdb5218596 > indra/newview/skins/default/xui/ja/panel_activeim_row.xml 58fdb5218596 > indra/newview/skins/default/xui/ja/panel_chat_header.xml 58fdb5218596 > indra/newview/skins/default/xui/ja/panel_instant_message.xml 58fdb5218596 > indra/newview/skins/default/xui/ja/panel_profile_view.xml 58fdb5218596 > indra/newview/skins/default/xui/ja/sidepanel_task_info.xml 58fdb5218596 > indra/newview/skins/default/xui/nl/floater_about_land.xml 58fdb5218596 > indra/newview/skins/default/xui/nl/floater_inventory_item_properties.xml 58fdb5218596 > indra/newview/skins/default/xui/nl/floater_tools.xml 58fdb5218596 > indra/newview/skins/default/xui/pl/floater_about_land.xml 58fdb5218596 > indra/newview/skins/default/xui/pl/floater_inventory_item_properties.xml 58fdb5218596 > indra/newview/skins/default/xui/pl/floater_tools.xml 58fdb5218596 > indra/newview/skins/default/xui/pl/inspect_avatar.xml 58fdb5218596 > indra/newview/skins/default/xui/pl/panel_edit_profile.xml 58fdb5218596 > indra/newview/skins/default/xui/pl/panel_profile_view.xml 58fdb5218596 > indra/newview/skins/default/xui/pl/sidepanel_task_info.xml 58fdb5218596 > indra/newview/skins/default/xui/pt/floater_about_land.xml 58fdb5218596 > indra/newview/skins/default/xui/pt/floater_inventory_item_properties.xml 58fdb5218596 > indra/newview/skins/default/xui/pt/floater_tools.xml 58fdb5218596 > indra/newview/skins/default/xui/pt/inspect_avatar.xml 58fdb5218596 > indra/newview/skins/default/xui/pt/panel_edit_profile.xml 58fdb5218596 > indra/newview/skins/default/xui/pt/panel_profile_view.xml 58fdb5218596 > indra/newview/skins/default/xui/pt/sidepanel_task_info.xml 58fdb5218596 > > Diff: http://codereview.secondlife.com/r/151/diff > > > Testing > ------- > > > Thanks, > > Seth > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110217/5fb32abc/attachment.htm From thickbrick.sleaford at gmail.com Thu Feb 17 09:00:41 2011 From: thickbrick.sleaford at gmail.com (Thickbrick Sleaford) Date: Thu, 17 Feb 2011 17:00:41 -0000 Subject: [opensource-dev] Review Request: When a bake texture upload fails, retry instead of giving up. Message-ID: <20110217170041.13983.62075@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/152/ ----------------------------------------------------------- Review request for Viewer. Summary ------- When a bake upload fails, the viewer doesn't retry it, and subsequently doesn't send a AgentSetAppearance message. This can happen without the user being aware, leaving the avatar looking good on their screen, but not updated to the same outfit on other people's screens. The avatar will remain in that state until the user does something that causes a rebake (manually rebake or change outfit.) The solution here is to retry the upload after a small delay. What this diff changes: when a full-res upload fails, retry to upload it after a 5s delay, up to 5 times (in case the cap is available, last attempt is via the old asset store.) Also, some clearer log messages. This implements an old *FIX: comment: // *FIX: retry upload after n seconds, asset server could be busy This isn't needed for low res uploads, because they don't block subsequent full-res uploads (mNeedsUpload isn't set to FALSE in LLTexLayerSetBuffer::doUpload in low-res uploads.) This addresses bug VWR-24889. http://jira.secondlife.com/browse/VWR-24889 Diffs ----- indra/newview/llassetuploadresponders.h 379da6bd50a5 indra/newview/llassetuploadresponders.cpp 379da6bd50a5 indra/newview/lltexlayer.h 379da6bd50a5 indra/newview/lltexlayer.cpp 379da6bd50a5 Diff: http://codereview.secondlife.com/r/152/diff Testing ------- Attempted outfit changes using a problematic connection (not recently used outfits to avoid using cached bakes). Looked for "Baked full res texture upload for failed" log messages, observed the subsequent retries and successful upload for that region. Observed that eventually the fully-baked avatar is visible to other users. Thanks, Thickbrick -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110217/aab8489e/attachment-0001.htm From vsavchuk at productengine.com Thu Feb 17 10:03:34 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Thu, 17 Feb 2011 18:03:34 -0000 Subject: [opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well In-Reply-To: <20110215144014.13389.62759@domU-12-31-38-00-90-68.compute-1.internal> References: <20110215144014.13389.62759@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110217180334.13394.64416@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 15, 2011, 6:40 a.m., Vadim ProductEngine wrote: > > indra/newview/llchatbar.h, line 83 > > > > > > Use tabs for indentation, not spaces. > > > > This note seems to apply to all modified lines in this patch. > > Jonathan Yap wrote: > Using spaces is specified in the coding standard: > http://wiki.secondlife.com/wiki/Coding_standard#Indentation > This preference was made explicit on Feb 3. Hmmm. This is news to me. Ok, please use tabs anyway to be consistent with surrounding code. > On Feb. 15, 2011, 6:40 a.m., Vadim ProductEngine wrote: > > indra/newview/llchatbar.cpp, lines 543-549 > > > > > > Do you only update font size on focus changes? > > Why? > > That doesn't look right to me. > > Jonathan Yap wrote: > It might not look/feel right, but the only downside to doing it this way is the message "Click here to chat" is not immediately updated. > > If you are in the middle of typing in the chat input box and change the size preference you will have to click back on the box to continue typing, at which point the new font size is updated in the box. > > The upside to doing it this way is a test for a font change is not being performed every frame or every keystroke. Oz is happy with it working this way. It's not the only (and not the best) way to avoid excessive updates. For example, you can subscribe to a setting change. Anyway, this should be implemented with some kind of callback, so that updates happen in time. - Vadim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/139/#review362 ----------------------------------------------------------- On Feb. 15, 2011, 10:04 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/139/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2011, 10:04 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > This is a request for help. I am trying to learn more about c++ and how variables in one class are accessed from another. For someone who knows what they are doing this is probably a pretty easy question. > > I have been able to set the font size on the chat input box when it is created in llbottomtray.cpp. I would like to do the same thing when someone clicks in that box to input text; it is possible they have changed the font setting and I would like to apply the size there as well, but I am stuck on how to do this. I think the right place to do this is in llchatbar.cpp/LLChatBar::onInputEditorGainFocus(). > > I have tried all kinds of wrong ways but at this point am stymied. > > Exact steps on how to proceed would be appreciated. > > > This addresses bug vwr-22220. > http://jira.secondlife.com/browse/vwr-22220 > > > Diffs > ----- > > indra/newview/llbottomtray.h 3d2e71443c58 > indra/newview/llbottomtray.cpp 3d2e71443c58 > > Diff: http://codereview.secondlife.com/r/139/diff > > > Testing > ------- > > > Thanks, > > Jonathan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110217/9c3a5641/attachment.htm From sllists at boroon.dasgupta.ch Thu Feb 17 13:59:52 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Thu, 17 Feb 2011 21:59:52 -0000 Subject: [opensource-dev] Review Request: When a bake texture upload fails, retry instead of giving up. In-Reply-To: <20110217170041.13983.62075@domU-12-31-38-00-90-68.compute-1.internal> References: <20110217170041.13983.62075@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110217215952.13392.25544@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/152/#review375 ----------------------------------------------------------- indra/newview/lltexlayer.h Is there any reason why you use BOOL instead of bool for this new data member? If not, prefer bool. (See https://wiki.secondlife.com/wiki/Coding_standard#Linden_Variable_Types ) indra/newview/lltexlayer.cpp Is "res" for "resolution" or "result"? - Boroondas On Feb. 17, 2011, 9 a.m., Thickbrick Sleaford wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/152/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2011, 9 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > When a bake upload fails, the viewer doesn't retry it, and subsequently doesn't send a AgentSetAppearance message. This can happen without the user being aware, leaving the avatar looking good on their screen, but not updated to the same outfit on other people's screens. The avatar will remain in that state until the user does something that causes a rebake (manually rebake or change outfit.) The solution here is to retry the upload after a small delay. > > What this diff changes: when a full-res upload fails, retry to upload it after a 5s delay, up to 5 times (in case the cap is available, last attempt is via the old asset store.) Also, some clearer log messages. This implements an old *FIX: comment: > // *FIX: retry upload after n seconds, asset server could be busy > > This isn't needed for low res uploads, because they don't block subsequent full-res uploads (mNeedsUpload isn't set to FALSE in LLTexLayerSetBuffer::doUpload in low-res uploads.) > > > This addresses bug VWR-24889. > http://jira.secondlife.com/browse/VWR-24889 > > > Diffs > ----- > > indra/newview/llassetuploadresponders.h 379da6bd50a5 > indra/newview/llassetuploadresponders.cpp 379da6bd50a5 > indra/newview/lltexlayer.h 379da6bd50a5 > indra/newview/lltexlayer.cpp 379da6bd50a5 > > Diff: http://codereview.secondlife.com/r/152/diff > > > Testing > ------- > > Attempted outfit changes using a problematic connection (not recently used outfits to avoid using cached bakes). Looked for "Baked full res texture upload for failed" log messages, observed the subsequent retries and successful upload for that region. Observed that eventually the fully-baked avatar is visible to other users. > > > Thanks, > > Thickbrick > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110217/96af4a83/attachment.htm From oz at lindenlab.com Thu Feb 17 16:56:05 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Thu, 17 Feb 2011 19:56:05 -0500 Subject: [opensource-dev] Hacking up to Visual Studio 2010 ... In-Reply-To: <4D5C3B3F.5090603@lindenlab.com> References: <4D5C3B3F.5090603@lindenlab.com> Message-ID: <4D5DC3A5.9010600@lindenlab.com> On 2011-02-16 16:01, Oz Linden (Scott Lawrence) wrote: > > Tomorrow and Friday (Feb 17 & 18), Linden Lab is going to be holding > an in-house Hackathon (stopping work on many other things, getting > many developers together all at once, and focusing on getting a lot > done in short time) to upgrade our builds of all our libraries and the > viewer to a new toolchain, including our new package management tool > (autobuild ) and Visual > Studio 2010 for Windows (yes... about time... whatever... we're doing it). I could use some help with a linux build problem... if you have a chance, please check out a copy of https://bitbucket.org/lindenlab/autobuild and arrange for the bin/autobuild command from that repository to be in your $PATH Then check out: https://bitbucket.org/oz_linden/viewer-autobuild2010 cd into the top level of that directory, and run: autobuild configure -c OpenSourceRelWithDebInfo autobuild configure -c OpenSourceRelWithDebInfo and let me know if it works (and if not, see if you can figure out why not). On our build farm, I'm getting an error: _[19:13:30]:_ //LogScan//_(1s)_ _[19:13:30]:_ /[LogScan] / from /usr/include/c++/4.1.3/cmath:53, _[19:13:30]:_ /[LogScan] / from /var/opt/teamcity/checkout/L-oz_viewer-autobuild2010/latest/indra/llcommon/linden_common.h:48, _[19:13:30]:_ /[LogScan] / from /var/opt/teamcity/checkout/L-oz_viewer-autobuild2010/latest/indra/newview/tests/lldateutil_test.cpp:26: _[19:13:30]:_ /[LogScan] //usr/include/bits/huge_val.h:28:18: error: missing binary operator before token "(" _[19:13:30]:_ /[LogScan] //usr/include/bits/huge_val.h:30:20: error: missing binary operator before token "(" -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110217/c4f94b6c/attachment.htm From sllists at boroon.dasgupta.ch Fri Feb 18 04:31:14 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Fri, 18 Feb 2011 13:31:14 +0100 Subject: [opensource-dev] Hacking up to Visual Studio 2010 ... In-Reply-To: <4D5DC3A5.9010600@lindenlab.com> References: <4D5C3B3F.5090603@lindenlab.com> <4D5DC3A5.9010600@lindenlab.com> Message-ID: <4D5E6692.9050108@boroon.dasgupta.ch> On 02/18/2011 01:56 AM, Oz Linden (Scott Lawrence) wrote: > [...] > Then check out: > > https://bitbucket.org/oz_linden/viewer-autobuild2010 > > cd into the top level of that directory, and run: > > autobuild configure -c OpenSourceRelWithDebInfo > > autobuild configure -c OpenSourceRelWithDebInfo > Shouldn't the second command be autobuild *build* -c OpenSourceRelWithDebInfo ? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110218/a03d7474/attachment.htm From oz at lindenlab.com Fri Feb 18 05:38:38 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Fri, 18 Feb 2011 08:38:38 -0500 Subject: [opensource-dev] Hacking up to Visual Studio 2010 ... In-Reply-To: <4D5E6692.9050108@boroon.dasgupta.ch> References: <4D5C3B3F.5090603@lindenlab.com> <4D5DC3A5.9010600@lindenlab.com> <4D5E6692.9050108@boroon.dasgupta.ch> Message-ID: <4D5E765E.9030307@lindenlab.com> On 2011-02-18 7:31, Boroondas Gupte wrote: > On 02/18/2011 01:56 AM, Oz Linden (Scott Lawrence) wrote: >> [...] >> Then check out: >> >> https://bitbucket.org/oz_linden/viewer-autobuild2010 >> >> cd into the top level of that directory, and run: >> >> autobuild configure -c OpenSourceRelWithDebInfo >> >> autobuild configure -c OpenSourceRelWithDebInfo >> > Shouldn't the second command be > > autobuild *build* -c OpenSourceRelWithDebInfo > > ? yes, it should -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110218/029bdce1/attachment.htm From sllists at boroon.dasgupta.ch Fri Feb 18 05:45:05 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Fri, 18 Feb 2011 14:45:05 +0100 Subject: [opensource-dev] Linux build error: missing binary operator before token "(" (was: Hacking up to Visual Studio 2010 ...) In-Reply-To: <4D5DC3A5.9010600@lindenlab.com> References: <4D5C3B3F.5090603@lindenlab.com> <4D5DC3A5.9010600@lindenlab.com> Message-ID: <4D5E77E1.1080703@boroon.dasgupta.ch> On 02/18/2011 01:56 AM, Oz Linden (Scott Lawrence) wrote: > [...] > > Then check out: > > https://bitbucket.org/oz_linden/viewer-autobuild2010 > > cd into the top level of that directory, and run: > > autobuild configure -c OpenSourceRelWithDebInfo > > autobuild configure -c OpenSourceRelWithDebInfo > > and let me know if it works (and if not, see if you can figure out why > not). On our build farm, I'm getting an error: > > _[19:13:30]:_ //LogScan//_(1s)_ > _[19:13:30]:_ /[LogScan] / from /usr/include/c++/4.1.3/cmath:53, > _[19:13:30]:_ /[LogScan] / from > /var/opt/teamcity/checkout/L-oz_viewer-autobuild2010/latest/indra/llcommon/linden_common.h:48, > _[19:13:30]:_ /[LogScan] / from > /var/opt/teamcity/checkout/L-oz_viewer-autobuild2010/latest/indra/newview/tests/lldateutil_test.cpp:26: > _[19:13:30]:_ /[LogScan] //usr/include/bits/huge_val.h:28:18: error: > missing binary operator before token "(" > _[19:13:30]:_ /[LogScan] //usr/include/bits/huge_val.h:30:20: error: > missing binary operator before token "(" With "build" in the second command instead of "configure", I'm getting the same error, though not just for /usr/include/bits/huge_val.h but many more system headers, too. Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110218/f3abab59/attachment-0001.htm From twisted_laws at hotmail.com Fri Feb 18 05:50:11 2011 From: twisted_laws at hotmail.com (Twisted Laws) Date: Fri, 18 Feb 2011 08:50:11 -0500 Subject: [opensource-dev] Hacking up to Visual Studio 2010 ... In-Reply-To: <4D5DC3A5.9010600@lindenlab.com> References: <4D5C3B3F.5090603@lindenlab.com>,<4D5DC3A5.9010600@lindenlab.com> Message-ID: When I try running autobuild on Linux (Ubuntu) using this autobuild and viewer-autobuild2010, it immediately fails with a pathcheck error looking for boto. Looking at common.py (in /usr/local/lib/python2.6/dist-packages/autobuild/common.py) I see that the pathcheck lines in there contain "lib/python2.5/...". So I'm assuming that this doesn't work with Python 2.6 ?? On Windows 7 with Visual Studio 2010 (not express), I run into an issue with not finding SCP, so I installed PuTTY and linked pscp.exe to scp.exe and then it still fails to download the googlebreakpad. (This IS using OpenSourceRelWithDebInfo) Date: Thu, 17 Feb 2011 19:56:05 -0500 From: oz at lindenlab.com To: opensource-dev at lists.secondlife.com Subject: Re: [opensource-dev] Hacking up to Visual Studio 2010 ... On 2011-02-16 16:01, Oz Linden (Scott Lawrence) wrote: Tomorrow and Friday (Feb 17 & 18), Linden Lab is going to be holding an in-house Hackathon (stopping work on many other things, getting many developers together all at once, and focusing on getting a lot done in short time) to upgrade our builds of all our libraries and the viewer to a new toolchain, including our new package management tool (autobuild) and Visual Studio 2010 for Windows (yes... about time... whatever... we're doing it). I could use some help with a linux build problem... if you have a chance, please check out a copy of https://bitbucket.org/lindenlab/autobuild and arrange for the bin/autobuild command from that repository to be in your $PATH Then check out: https://bitbucket.org/oz_linden/viewer-autobuild2010 cd into the top level of that directory, and run: autobuild configure -c OpenSourceRelWithDebInfo autobuild configure -c OpenSourceRelWithDebInfo and let me know if it works (and if not, see if you can figure out why not). On our build farm, I'm getting an error: [19:13:30]: LogScan (1s) [19:13:30]: [LogScan] from /usr/include/c++/4.1.3/cmath:53, [19:13:30]: [LogScan] from /var/opt/teamcity/checkout/L-oz_viewer-autobuild2010/latest/indra/llcommon/linden_common.h:48, [19:13:30]: [LogScan] from /var/opt/teamcity/checkout/L-oz_viewer-autobuild2010/latest/indra/newview/tests/lldateutil_test.cpp:26: [19:13:30]: [LogScan] /usr/include/bits/huge_val.h:28:18: error: missing binary operator before token "(" [19:13:30]: [LogScan] /usr/include/bits/huge_val.h:30:20: error: missing binary operator before token "(" _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110218/27c64763/attachment.htm From twisted_laws at hotmail.com Fri Feb 18 06:16:27 2011 From: twisted_laws at hotmail.com (Twisted Laws) Date: Fri, 18 Feb 2011 09:16:27 -0500 Subject: [opensource-dev] Hacking up to Visual Studio 2010 ... In-Reply-To: References: <4D5C3B3F.5090603@lindenlab.com>, <4D5DC3A5.9010600@lindenlab.com>, Message-ID: exact error on linux is: autobuild.common.AutobuildError: invalid 'pathcheck' setting for 'boto' From: twisted_laws at hotmail.com To: oz at lindenlab.com; opensource-dev at lists.secondlife.com Date: Fri, 18 Feb 2011 08:50:11 -0500 Subject: Re: [opensource-dev] Hacking up to Visual Studio 2010 ... When I try running autobuild on Linux (Ubuntu) using this autobuild and viewer-autobuild2010, it immediately fails with a pathcheck error looking for boto. Looking at common.py (in /usr/local/lib/python2.6/dist-packages/autobuild/common.py) I see that the pathcheck lines in there contain "lib/python2.5/...". So I'm assuming that this doesn't work with Python 2.6 ?? On Windows 7 with Visual Studio 2010 (not express), I run into an issue with not finding SCP, so I installed PuTTY and linked pscp.exe to scp.exe and then it still fails to download the googlebreakpad. (This IS using OpenSourceRelWithDebInfo) Date: Thu, 17 Feb 2011 19:56:05 -0500 From: oz at lindenlab.com To: opensource-dev at lists.secondlife.com Subject: Re: [opensource-dev] Hacking up to Visual Studio 2010 ... On 2011-02-16 16:01, Oz Linden (Scott Lawrence) wrote: Tomorrow and Friday (Feb 17 & 18), Linden Lab is going to be holding an in-house Hackathon (stopping work on many other things, getting many developers together all at once, and focusing on getting a lot done in short time) to upgrade our builds of all our libraries and the viewer to a new toolchain, including our new package management tool (autobuild) and Visual Studio 2010 for Windows (yes... about time... whatever... we're doing it). I could use some help with a linux build problem... if you have a chance, please check out a copy of https://bitbucket.org/lindenlab/autobuild and arrange for the bin/autobuild command from that repository to be in your $PATH Then check out: https://bitbucket.org/oz_linden/viewer-autobuild2010 cd into the top level of that directory, and run: autobuild configure -c OpenSourceRelWithDebInfo autobuild configure -c OpenSourceRelWithDebInfo and let me know if it works (and if not, see if you can figure out why not). On our build farm, I'm getting an error: [19:13:30]: LogScan (1s) [19:13:30]: [LogScan] from /usr/include/c++/4.1.3/cmath:53, [19:13:30]: [LogScan] from /var/opt/teamcity/checkout/L-oz_viewer-autobuild2010/latest/indra/llcommon/linden_common.h:48, [19:13:30]: [LogScan] from /var/opt/teamcity/checkout/L-oz_viewer-autobuild2010/latest/indra/newview/tests/lldateutil_test.cpp:26: [19:13:30]: [LogScan] /usr/include/bits/huge_val.h:28:18: error: missing binary operator before token "(" [19:13:30]: [LogScan] /usr/include/bits/huge_val.h:30:20: error: missing binary operator before token "(" _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110218/e7905541/attachment.htm From thickbrick.sleaford at gmail.com Fri Feb 18 06:45:00 2011 From: thickbrick.sleaford at gmail.com (Thickbrick Sleaford) Date: Fri, 18 Feb 2011 16:45:00 +0200 Subject: [opensource-dev] Hacking up to Visual Studio 2010 ... In-Reply-To: References: <4D5C3B3F.5090603@lindenlab.com> <4D5DC3A5.9010600@lindenlab.com> Message-ID: <201102181645.00980.thickbrick.sleaford@gmail.com> On Friday 18 February 2011 15:50:11 Twisted Laws wrote: > When I try running autobuild on Linux (Ubuntu) using this autobuild and > viewer-autobuild2010, it immediately fails with a pathcheck error looking > for boto. Looking at common.py (in > /usr/local/lib/python2.6/dist-packages/autobuild/common.py) I see that the > pathcheck lines in there contain "lib/python2.5/...". So I'm assuming > that this doesn't work with Python 2.6 ?? > I had a similar problem after I installed the autobuild package system-wide with the setup.py that came with it (./setup.py build && sudo ./setup.py install). It turns out it does not work when installed system wide. As far as I could tell, the python version in the pre-packaged files' path don't matter. Also, it seems prone to leaving bad files /var/tmp/$USER/install.cache/ when bailing due to exceptions, and barfing when encountering those files on subsequent runs. -- Thickbrick From twisted_laws at hotmail.com Fri Feb 18 06:55:06 2011 From: twisted_laws at hotmail.com (Twisted Laws) Date: Fri, 18 Feb 2011 09:55:06 -0500 Subject: [opensource-dev] Hacking up to Visual Studio 2010 ... In-Reply-To: <201102181645.00980.thickbrick.sleaford@gmail.com> References: <4D5C3B3F.5090603@lindenlab.com> <4D5DC3A5.9010600@lindenlab.com> , <201102181645.00980.thickbrick.sleaford@gmail.com> Message-ID: Thanks.... i'm unclear of what i should do next then. (I primarily work in windows) Can i just delete the files in /usr/local/lib/python2.6/dist-packages/autobuild ? > From: thickbrick.sleaford at gmail.com > To: opensource-dev at lists.secondlife.com > Subject: Re: [opensource-dev] Hacking up to Visual Studio 2010 ... > Date: Fri, 18 Feb 2011 16:45:00 +0200 > CC: twisted_laws at hotmail.com > > On Friday 18 February 2011 15:50:11 Twisted Laws wrote: > > When I try running autobuild on Linux (Ubuntu) using this autobuild and > > viewer-autobuild2010, it immediately fails with a pathcheck error looking > > for boto. Looking at common.py (in > > /usr/local/lib/python2.6/dist-packages/autobuild/common.py) I see that the > > pathcheck lines in there contain "lib/python2.5/...". So I'm assuming > > that this doesn't work with Python 2.6 ?? > > > > I had a similar problem after I installed the autobuild package system-wide > with the setup.py that came with it (./setup.py build && sudo ./setup.py > install). It turns out it does not work when installed system wide. As far as > I could tell, the python version in the pre-packaged files' path don't matter. > > Also, it seems prone to leaving bad files /var/tmp/$USER/install.cache/ when > bailing due to exceptions, and barfing when encountering those files on > subsequent runs. > > -- > Thickbrick -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110218/57cb042b/attachment.htm From thickbrick.sleaford at gmail.com Fri Feb 18 07:03:05 2011 From: thickbrick.sleaford at gmail.com (Thickbrick Sleaford) Date: Fri, 18 Feb 2011 17:03:05 +0200 Subject: [opensource-dev] Hacking up to Visual Studio 2010 ... In-Reply-To: References: <4D5C3B3F.5090603@lindenlab.com> <201102181645.00980.thickbrick.sleaford@gmail.com> Message-ID: <201102181703.05551.thickbrick.sleaford@gmail.com> On Friday 18 February 2011 16:55:06 Twisted Laws wrote: > Thanks.... i'm unclear of what i should do next then. (I primarily work > in windows) Can i just delete the files in > /usr/local/lib/python2.6/dist-packages/autobuild ? > That's what I did (together with /usr/local/bin/autobuild). Maybe there's a proper way of removing packages installed with easy_install, but I couldn't figure it out... -- Thickbrick From jhwelch at gmail.com Fri Feb 18 07:11:45 2011 From: jhwelch at gmail.com (Jonathan Yap) Date: Fri, 18 Feb 2011 15:11:45 -0000 Subject: [opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well In-Reply-To: <20110215180453.13492.55919@domU-12-31-38-00-90-68.compute-1.internal> References: <20110215180453.13492.55919@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110218151145.13392.15810@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/139/ ----------------------------------------------------------- (Updated Feb. 18, 2011, 7:11 a.m.) Review request for Viewer. Changes ------- Changed indentation from spaces to tabs per request. Summary ------- This is a request for help. I am trying to learn more about c++ and how variables in one class are accessed from another. For someone who knows what they are doing this is probably a pretty easy question. I have been able to set the font size on the chat input box when it is created in llbottomtray.cpp. I would like to do the same thing when someone clicks in that box to input text; it is possible they have changed the font setting and I would like to apply the size there as well, but I am stuck on how to do this. I think the right place to do this is in llchatbar.cpp/LLChatBar::onInputEditorGainFocus(). I have tried all kinds of wrong ways but at this point am stymied. Exact steps on how to proceed would be appreciated. This addresses bug vwr-22220. http://jira.secondlife.com/browse/vwr-22220 Diffs (updated) ----- indra/newview/llbottomtray.h 3d2e71443c58 indra/newview/llbottomtray.cpp 3d2e71443c58 indra/newview/llchatbar.h 3d2e71443c58 indra/newview/llchatbar.cpp 3d2e71443c58 Diff: http://codereview.secondlife.com/r/139/diff Testing ------- Thanks, Jonathan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110218/b55bef32/attachment.htm From jhwelch at gmail.com Fri Feb 18 07:15:59 2011 From: jhwelch at gmail.com (Jonathan Yap) Date: Fri, 18 Feb 2011 15:15:59 -0000 Subject: [opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well In-Reply-To: <20110218151145.13392.15810@domU-12-31-38-00-90-68.compute-1.internal> References: <20110218151145.13392.15810@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110218151559.13492.10383@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/139/#review376 ----------------------------------------------------------- My internet connection went dead while in the middle of updating the diffs. They are corrupted and I don't know how to fix them. - Jonathan On Feb. 18, 2011, 7:11 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/139/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2011, 7:11 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > This is a request for help. I am trying to learn more about c++ and how variables in one class are accessed from another. For someone who knows what they are doing this is probably a pretty easy question. > > I have been able to set the font size on the chat input box when it is created in llbottomtray.cpp. I would like to do the same thing when someone clicks in that box to input text; it is possible they have changed the font setting and I would like to apply the size there as well, but I am stuck on how to do this. I think the right place to do this is in llchatbar.cpp/LLChatBar::onInputEditorGainFocus(). > > I have tried all kinds of wrong ways but at this point am stymied. > > Exact steps on how to proceed would be appreciated. > > > This addresses bug vwr-22220. > http://jira.secondlife.com/browse/vwr-22220 > > > Diffs > ----- > > indra/newview/llbottomtray.h 3d2e71443c58 > indra/newview/llbottomtray.cpp 3d2e71443c58 > indra/newview/llchatbar.h 3d2e71443c58 > indra/newview/llchatbar.cpp 3d2e71443c58 > > Diff: http://codereview.secondlife.com/r/139/diff > > > Testing > ------- > > > Thanks, > > Jonathan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110218/8ad9633d/attachment.htm From sllists at boroon.dasgupta.ch Fri Feb 18 07:22:10 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Fri, 18 Feb 2011 15:22:10 -0000 Subject: [opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well In-Reply-To: <20110218151559.13492.10383@domU-12-31-38-00-90-68.compute-1.internal> References: <20110218151559.13492.10383@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110218152210.13389.22973@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 18, 2011, 7:16 a.m., Jonathan Yap wrote: > > My internet connection went dead while in the middle of updating the diffs. They are corrupted and I don't know how to fix them. Have you tried uploading them again? That won't remove the bogus intermediary revision, but if we know about that, we can easily ignore it. Btw., after uploading, you can review the new diff before publishing it, I think: While on the page where you can describe the update, click the "View Diff" button. - Boroondas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/139/#review376 ----------------------------------------------------------- On Feb. 18, 2011, 7:11 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/139/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2011, 7:11 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > This is a request for help. I am trying to learn more about c++ and how variables in one class are accessed from another. For someone who knows what they are doing this is probably a pretty easy question. > > I have been able to set the font size on the chat input box when it is created in llbottomtray.cpp. I would like to do the same thing when someone clicks in that box to input text; it is possible they have changed the font setting and I would like to apply the size there as well, but I am stuck on how to do this. I think the right place to do this is in llchatbar.cpp/LLChatBar::onInputEditorGainFocus(). > > I have tried all kinds of wrong ways but at this point am stymied. > > Exact steps on how to proceed would be appreciated. > > > This addresses bug vwr-22220. > http://jira.secondlife.com/browse/vwr-22220 > > > Diffs > ----- > > indra/newview/llbottomtray.h 3d2e71443c58 > indra/newview/llbottomtray.cpp 3d2e71443c58 > indra/newview/llchatbar.h 3d2e71443c58 > indra/newview/llchatbar.cpp 3d2e71443c58 > > Diff: http://codereview.secondlife.com/r/139/diff > > > Testing > ------- > > > Thanks, > > Jonathan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110218/bc6b2cee/attachment.htm From twisted_laws at hotmail.com Fri Feb 18 07:28:06 2011 From: twisted_laws at hotmail.com (Twisted Laws) Date: Fri, 18 Feb 2011 10:28:06 -0500 Subject: [opensource-dev] Hacking up to Visual Studio 2010 ... In-Reply-To: <201102181703.05551.thickbrick.sleaford@gmail.com> References: <4D5C3B3F.5090603@lindenlab.com> <201102181645.00980.thickbrick.sleaford@gmail.com> , <201102181703.05551.thickbrick.sleaford@gmail.com> Message-ID: hmmm... ok, so i removed them... './setup.py build' works ok and i added autobuild/bin to path and I still get the same error from running $ autobuild configure -c OpenSourceRelWithDebInfo autobuild.common.AutobuildError: invalid 'pathcheck' setting for 'boto' looking at it, the file still contains 'pathcheck' : "lib/python2.5/boto" what is "boto" btw? did i miss installing something? there are no boto packages that i can find > From: thickbrick.sleaford at gmail.com > To: opensource-dev at lists.secondlife.com > Subject: Re: [opensource-dev] Hacking up to Visual Studio 2010 ... > Date: Fri, 18 Feb 2011 17:03:05 +0200 > CC: twisted_laws at hotmail.com > > That's what I did (together with /usr/local/bin/autobuild). Maybe there's a > proper way of removing packages installed with easy_install, but I couldn't > figure it out... > > > -- > Thickbrick -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110218/fbdee7e3/attachment.htm From xotmid at gmail.com Fri Feb 18 07:52:43 2011 From: xotmid at gmail.com (Brandon Husbands) Date: Fri, 18 Feb 2011 09:52:43 -0600 Subject: [opensource-dev] Hacking up to Visual Studio 2010 ... In-Reply-To: References: <4D5C3B3F.5090603@lindenlab.com> <201102181645.00980.thickbrick.sleaford@gmail.com> <201102181703.05551.thickbrick.sleaford@gmail.com> Message-ID: An integrated interface to current and future infrastructural services offered by Amazon Web Services. Currently, this includes: - Simple Storage Service (S3) - SimpleQueue Service (SQS) - Elastic Compute Cloud (EC2) - Mechanical Turk - SimpleDB - CloudFront - CloudWatch - AutoScale - Elastic Load Balancer (ELB) - Virtual Private Cloud (VPC) - Elastic Map Reduce (EMR) - Relational Data Service (RDS) - Simple Notification Server (SNS) - Google Storage - Identity and Access Management (IAM) - Route53 DNS Service (route53) I dont think its really needed. For pythons uninstall with easy_install Uninstalling Packages If you have replaced a package with another version, then you can just delete the package(s) you don't need by deleting the PackageName-versioninfo.egg file or directory (found in the installation directory). If you want to delete the currently installed version of a package (or all versions of a package), you should first run: easy_install -mxN PackageName This will ensure that Python doesn't continue to search for a package you're planning to remove. After you've done this, you can safely delete the .egg files or directories, along with any scripts you wish to remove. On Fri, Feb 18, 2011 at 9:28 AM, Twisted Laws wrote: > hmmm... ok, so i removed them... './setup.py build' works ok and i > added autobuild/bin to path and I still get the same error from running > > $ autobuild configure -c OpenSourceRelWithDebInfo > > autobuild.common.AutobuildError: invalid 'pathcheck' setting for 'boto' > > looking at it, the file still contains 'pathcheck' : "lib/python2.5/boto" > > what is "boto" btw? did i miss installing something? there are no boto > packages that i can find > > > > > From: thickbrick.sleaford at gmail.com > > To: opensource-dev at lists.secondlife.com > > Subject: Re: [opensource-dev] Hacking up to Visual Studio 2010 ... > > Date: Fri, 18 Feb 2011 17:03:05 +0200 > > > CC: twisted_laws at hotmail.com > > > > That's what I did (together with /usr/local/bin/autobuild). Maybe there's > a > > proper way of removing packages installed with easy_install, but I > couldn't > > figure it out... > > > > > > -- > > Thickbrick > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > -- ------------------------------------------------------------------------------------------------------------------------------- This email is a private and confidential communication. Any use of email may be subject to the laws and regulations of the United States. You may not Repost, Distribute nor reproduce any content of this message. ------------------------------------------------------------------------------------------------------------------------------- ------------------------------------------------------------------------------------------------------------------------------- -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110218/db695e3e/attachment-0001.htm From vsavchuk at productengine.com Fri Feb 18 08:35:11 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Fri, 18 Feb 2011 16:35:11 -0000 Subject: [opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well In-Reply-To: <20110215144014.13389.62759@domU-12-31-38-00-90-68.compute-1.internal> References: <20110215144014.13389.62759@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110218163511.13390.75688@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 15, 2011, 6:40 a.m., Vadim ProductEngine wrote: > > indra/newview/llchatbar.h, line 83 > > > > > > Use tabs for indentation, not spaces. > > > > This note seems to apply to all modified lines in this patch. > > Jonathan Yap wrote: > Using spaces is specified in the coding standard: > http://wiki.secondlife.com/wiki/Coding_standard#Indentation > This preference was made explicit on Feb 3. > > Vadim ProductEngine wrote: > Hmmm. This is news to me. Ok, please use tabs anyway to be consistent with surrounding code. BTW, the recent change to the coding standard has been rolled back, so tabs are mandatory again. - Vadim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/139/#review362 ----------------------------------------------------------- On Feb. 18, 2011, 7:11 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/139/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2011, 7:11 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > This is a request for help. I am trying to learn more about c++ and how variables in one class are accessed from another. For someone who knows what they are doing this is probably a pretty easy question. > > I have been able to set the font size on the chat input box when it is created in llbottomtray.cpp. I would like to do the same thing when someone clicks in that box to input text; it is possible they have changed the font setting and I would like to apply the size there as well, but I am stuck on how to do this. I think the right place to do this is in llchatbar.cpp/LLChatBar::onInputEditorGainFocus(). > > I have tried all kinds of wrong ways but at this point am stymied. > > Exact steps on how to proceed would be appreciated. > > > This addresses bug vwr-22220. > http://jira.secondlife.com/browse/vwr-22220 > > > Diffs > ----- > > indra/newview/llbottomtray.h 3d2e71443c58 > indra/newview/llbottomtray.cpp 3d2e71443c58 > indra/newview/llchatbar.h 3d2e71443c58 > indra/newview/llchatbar.cpp 3d2e71443c58 > > Diff: http://codereview.secondlife.com/r/139/diff > > > Testing > ------- > > > Thanks, > > Jonathan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110218/8df5233d/attachment.htm From xotmid at gmail.com Fri Feb 18 08:51:24 2011 From: xotmid at gmail.com (Brandon Husbands) Date: Fri, 18 Feb 2011 10:51:24 -0600 Subject: [opensource-dev] Hacking up to Visual Studio 2010 ... In-Reply-To: <4D5C3B3F.5090603@lindenlab.com> References: <4D5C3B3F.5090603@lindenlab.com> Message-ID: Trying to build with vs2k10 pro D:\Other\vd\viewer-autobuild>autobuild configure -c OpenSourceRelWithDebInfo --d ebug Configuration file 'D:\Other\vd\viewer-autobuild\autobuild.xml' configuring in D:\Other\vd\viewer-autobuild\build-vc80 configuring for configuration(s) [{'default': False, 'configure': {'command': No ne, 'options': ['-G', '"Visual Studio 8 2005"', '-DSTANDALONE:BOOL=FALSE', '-DIN STALL_PROPRIETARY=FALSE', '-DFMOD=FALSE'], 'arguments': None}, 'name': 'OpenSour ceRelWithDebInfo', 'build': {'command': 'devenv.com', 'options': ['/build', 'Rel WithDebInfo'], 'arguments': ['SecondLife.sln']}}] executing configure command cmake -DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo -DUNA TTENDED:BOOL=OFF -DWORD_SIZE:STRING=32 -DROOT_PROJECT_NAME:STRING=SecondLife -G "Visual Studio 8 2005" -DSTANDALONE:BOOL=FALSE -DINSTALL_PROPRIETARY=FALSE -DFMO D=FALSE ../indra CMake Error: CMake was unable to find a build program corresponding to "Visual S tudio 8 2005". CMAKE_MAKE_PROGRAM is not set. You probably need to select a di fferent build tool. CMake Error: Could not find cmake module file:D:/Other/vd/viewer-autobuild/build -vc80/CMakeFiles/CMakeCCompiler.cmake CMake Error: Could not find cmake module file:D:/Other/vd/viewer-autobuild/build -vc80/CMakeFiles/CMakeCXXCompiler.cmake -- Configuring incomplete, errors occurred! default configuration returned 1 Traceback (most recent call last): File "D:\Python26\Scripts\autobuild", line 47, in sys.exit( Autobuild().main(sys.argv[1:]) ) File "D:\Python26\lib\site-packages\autobuild\autobuild_main.py", line 188, in main tool_to_run.run(args) File "D:\Python26\lib\site-packages\autobuild\autobuild_tool_configure.py", li ne 88, in run raise ConfigurationError("default configuration returned %d" % (result)) ConfigurationError: default configuration returned 1 ERROR: default configuration returned 1 For more information: try re-running your command with --verbose or --debug D:\Other\vd\viewer-autobuild> On Wed, Feb 16, 2011 at 3:01 PM, Oz Linden (Scott Lawrence) < oz at lindenlab.com> wrote: > > Tomorrow and Friday (Feb 17 & 18), Linden Lab is going to be holding an > in-house Hackathon (stopping work on many other things, getting many > developers together all at once, and focusing on getting a lot done in short > time) to upgrade our builds of all our libraries and the viewer to a new > toolchain, including our new package management tool (autobuild) > and Visual Studio 2010 for Windows (yes... about time... whatever... we're > doing it). > > Our goals are simply stated: > > 1. Get all open source components into repositories under > hg.secondlife.com (eg bitbucket.org/lindenlab/). All the third party > components (things not created by LL) that we incorporate will be in > repositories named with the prefix "3p-". Most of these repositories exist > now, but not all have sources in them yet. > 2. Get each component packaged with an autobuild configuration for > whatever platforms it is needed on. > 3. Get each component needed on Windows building under autobuild with > VS 2010. > 4. Get a TeamCity-automated build configured for each component > repository with the resulting prebuilds of open components uploaded to > public directories. > 5. Get the viewer built using the resulting prebuilt libraries, also > under autobuild with VS 2010. > > We also expect to integrate some automated viewer testing into our > automated viewer builds, but none of that will be externally visible. > > If you make a chart with a row for each component, and a column for each of > 1 through 4 above, it's a lot of boxes to fill in... many have already been > done: there are some complete rows, but it's still a big job. > > I will be providing public updates on the wiki (form and location TBD... > watch this thread) and on the #opensl IRC channel of how we're doing and the > status of each public repository. > > A non-goal for the Lindens is building the components with Visual Studio > Express. There is currently a limitation (see OPEN-1 in jira) that makes > using Express cumbersome (it requires separate configuration). We do > recognize that Express is important to open developers, and want it to be > supported, but there's only so much we can do ourselves in two days. There > is an autobuild configuration checked in for building the viewer under > autobuild including VS Express: > http://bitbucket.org/oz_linden/viewer-autobuild > > > I'm going to try to get some supporting documentation up on the wiki today > or early tomorrow. It should be possible for open developers to help us > test whether or not the component builds can be used in Express as we go > along. If people want to do that and feed me changes, I'll try to get them > incorporated in real time as much as possible. > > Once all this is done (and it probably will not be merged to > viewer-development immediately after the hackathon), this new toolchain will > be the "supported" way to build the viewer and its dependencies, which means > that if you really need to build with other tools, you'll have to work out > how to do so - we'll consider accepting changes to support them so long as > they're reasonably clean and don't break the standard way of doing it. > Maintaining support for building with older versions of Visual Studio will > _not_ be a goal, and getting review time for them will probably be hard. > > > > > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > -- ------------------------------------------------------------------------------------------------------------------------------- This email is a private and confidential communication. Any use of email may be subject to the laws and regulations of the United States. You may not Repost, Distribute nor reproduce any content of this message. ------------------------------------------------------------------------------------------------------------------------------- ------------------------------------------------------------------------------------------------------------------------------- -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110218/e83abbf1/attachment.htm From twisted_laws at hotmail.com Fri Feb 18 09:29:44 2011 From: twisted_laws at hotmail.com (Twisted Laws) Date: Fri, 18 Feb 2011 12:29:44 -0500 Subject: [opensource-dev] Hacking up to Visual Studio 2010 ... In-Reply-To: References: <4D5C3B3F.5090603@lindenlab.com>, Message-ID: in my case, i copied autobuild.xml to altered.xml and changed all occurrances of '"Visual Studio 8 2005" to "Visual Studio 10" and then specified it on the autobuild command line with --config_file altered.xml then it works but I have problems getting googlebreakpad, but thats a different issue Date: Fri, 18 Feb 2011 10:51:24 -0600 From: xotmid at gmail.com To: oz at lindenlab.com CC: opensource-dev at lists.secondlife.com Subject: Re: [opensource-dev] Hacking up to Visual Studio 2010 ... Trying to build with vs2k10 pro D:\Other\vd\viewer-autobuild>autobuild configure -c OpenSourceRelWithDebInfo --d ebug Configuration file 'D:\Other\vd\viewer-autobuild\autobuild.xml' configuring in D:\Other\vd\viewer-autobuild\build-vc80 configuring for configuration(s) [{'default': False, 'configure': {'command': No ne, 'options': ['-G', '"Visual Studio 8 2005"', '-DSTANDALONE:BOOL=FALSE', '-DIN STALL_PROPRIETARY=FALSE', '-DFMOD=FALSE'], 'arguments': None}, 'name': 'OpenSour ceRelWithDebInfo', 'build': {'command': 'devenv.com', 'options': ['/build', 'Rel WithDebInfo'], 'arguments': ['SecondLife.sln']}}] executing configure command cmake -DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo -DUNA TTENDED:BOOL=OFF -DWORD_SIZE:STRING=32 -DROOT_PROJECT_NAME:STRING=SecondLife -G "Visual Studio 8 2005" -DSTANDALONE:BOOL=FALSE -DINSTALL_PROPRIETARY=FALSE -DFMO D=FALSE ../indra CMake Error: CMake was unable to find a build program corresponding to "Visual S tudio 8 2005". CMAKE_MAKE_PROGRAM is not set. You probably need to select a di fferent build tool. CMake Error: Could not find cmake module file:D:/Other/vd/viewer-autobuild/build -vc80/CMakeFiles/CMakeCCompiler.cmake CMake Error: Could not find cmake module file:D:/Other/vd/viewer-autobuild/build -vc80/CMakeFiles/CMakeCXXCompiler.cmake -- Configuring incomplete, errors occurred! default configuration returned 1 Traceback (most recent call last): File "D:\Python26\Scripts\autobuild", line 47, in sys.exit( Autobuild().main(sys.argv[1:]) ) File "D:\Python26\lib\site-packages\autobuild\autobuild_main.py", line 188, in main tool_to_run.run(args) File "D:\Python26\lib\site-packages\autobuild\autobuild_tool_configure.py", li ne 88, in run raise ConfigurationError("default configuration returned %d" % (result)) ConfigurationError: default configuration returned 1 ERROR: default configuration returned 1 For more information: try re-running your command with --verbose or --debug D:\Other\vd\viewer-autobuild> On Wed, Feb 16, 2011 at 3:01 PM, Oz Linden (Scott Lawrence) wrote: Tomorrow and Friday (Feb 17 & 18), Linden Lab is going to be holding an in-house Hackathon (stopping work on many other things, getting many developers together all at once, and focusing on getting a lot done in short time) to upgrade our builds of all our libraries and the viewer to a new toolchain, including our new package management tool (autobuild) and Visual Studio 2010 for Windows (yes... about time... whatever... we're doing it). Our goals are simply stated: Get all open source components into repositories under hg.secondlife.com (eg bitbucket.org/lindenlab/). All the third party components (things not created by LL) that we incorporate will be in repositories named with the prefix "3p-". Most of these repositories exist now, but not all have sources in them yet. Get each component packaged with an autobuild configuration for whatever platforms it is needed on. Get each component needed on Windows building under autobuild with VS 2010. Get a TeamCity-automated build configured for each component repository with the resulting prebuilds of open components uploaded to public directories. Get the viewer built using the resulting prebuilt libraries, also under autobuild with VS 2010.We also expect to integrate some automated viewer testing into our automated viewer builds, but none of that will be externally visible. If you make a chart with a row for each component, and a column for each of 1 through 4 above, it's a lot of boxes to fill in... many have already been done: there are some complete rows, but it's still a big job. I will be providing public updates on the wiki (form and location TBD... watch this thread) and on the #opensl IRC channel of how we're doing and the status of each public repository. A non-goal for the Lindens is building the components with Visual Studio Express. There is currently a limitation (see OPEN-1 in jira) that makes using Express cumbersome (it requires separate configuration). We do recognize that Express is important to open developers, and want it to be supported, but there's only so much we can do ourselves in two days. There is an autobuild configuration checked in for building the viewer under autobuild including VS Express: http://bitbucket.org/oz_linden/viewer-autobuild I'm going to try to get some supporting documentation up on the wiki today or early tomorrow. It should be possible for open developers to help us test whether or not the component builds can be used in Express as we go along. If people want to do that and feed me changes, I'll try to get them incorporated in real time as much as possible. Once all this is done (and it probably will not be merged to viewer-development immediately after the hackathon), this new toolchain will be the "supported" way to build the viewer and its dependencies, which means that if you really need to build with other tools, you'll have to work out how to do so - we'll consider accepting changes to support them so long as they're reasonably clean and don't break the standard way of doing it. Maintaining support for building with older versions of Visual Studio will _not_ be a goal, and getting review time for them will probably be hard. _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -- ------------------------------------------------------------------------------------------------------------------------------- This email is a private and confidential communication. Any use of email may be subject to the laws and regulations of the United States. You may not Repost, Distribute nor reproduce any content of this message. ------------------------------------------------------------------------------------------------------------------------------- ------------------------------------------------------------------------------------------------------------------------------- _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110218/19932717/attachment-0001.htm From xotmid at gmail.com Fri Feb 18 11:46:11 2011 From: xotmid at gmail.com (Brandon Husbands) Date: Fri, 18 Feb 2011 13:46:11 -0600 Subject: [opensource-dev] Hacking up to Visual Studio 2010 ... In-Reply-To: References: <4D5C3B3F.5090603@lindenlab.com> Message-ID: Heheh ty for the tip.. Though as this is testing for it.. i figured they aughta know that its not selecting whats installed. =) On Fri, Feb 18, 2011 at 11:29 AM, Twisted Laws wrote: > in my case, i copied autobuild.xml to altered.xml and changed all > occurrances of '"Visual Studio 8 2005" to "Visual Studio 10" and then > specified it on the autobuild command line with --config_file altered.xml > > then it works but I have problems getting googlebreakpad, but thats a > different issue > > ------------------------------ > Date: Fri, 18 Feb 2011 10:51:24 -0600 > From: xotmid at gmail.com > To: oz at lindenlab.com > CC: opensource-dev at lists.secondlife.com > > Subject: Re: [opensource-dev] Hacking up to Visual Studio 2010 ... > > Trying to build with vs2k10 pro > > > D:\Other\vd\viewer-autobuild>autobuild configure -c > OpenSourceRelWithDebInfo --d > ebug > Configuration file 'D:\Other\vd\viewer-autobuild\autobuild.xml' > configuring in D:\Other\vd\viewer-autobuild\build-vc80 > configuring for configuration(s) [{'default': False, 'configure': > {'command': No > ne, 'options': ['-G', '"Visual Studio 8 2005"', '-DSTANDALONE:BOOL=FALSE', > '-DIN > STALL_PROPRIETARY=FALSE', '-DFMOD=FALSE'], 'arguments': None}, 'name': > 'OpenSour > ceRelWithDebInfo', 'build': {'command': 'devenv.com', 'options': > ['/build', 'Rel > WithDebInfo'], 'arguments': ['SecondLife.sln']}}] > executing configure command cmake -DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo > -DUNA > TTENDED:BOOL=OFF -DWORD_SIZE:STRING=32 > -DROOT_PROJECT_NAME:STRING=SecondLife -G > "Visual Studio 8 2005" -DSTANDALONE:BOOL=FALSE -DINSTALL_PROPRIETARY=FALSE > -DFMO > D=FALSE ../indra > CMake Error: CMake was unable to find a build program corresponding to > "Visual S > tudio 8 2005". CMAKE_MAKE_PROGRAM is not set. You probably need to select > a di > fferent build tool. > CMake Error: Could not find cmake module > file:D:/Other/vd/viewer-autobuild/build > -vc80/CMakeFiles/CMakeCCompiler.cmake > CMake Error: Could not find cmake module > file:D:/Other/vd/viewer-autobuild/build > -vc80/CMakeFiles/CMakeCXXCompiler.cmake > -- Configuring incomplete, errors occurred! > default configuration returned 1 > Traceback (most recent call last): > File "D:\Python26\Scripts\autobuild", line 47, in > sys.exit( Autobuild().main(sys.argv[1:]) ) > File "D:\Python26\lib\site-packages\autobuild\autobuild_main.py", line > 188, in > main > tool_to_run.run(args) > File > "D:\Python26\lib\site-packages\autobuild\autobuild_tool_configure.py", li > ne 88, in run > raise ConfigurationError("default configuration returned %d" % > (result)) > ConfigurationError: default configuration returned 1 > ERROR: default configuration returned 1 > For more information: try re-running your command with --verbose or --debug > > D:\Other\vd\viewer-autobuild> > > On Wed, Feb 16, 2011 at 3:01 PM, Oz Linden (Scott Lawrence) < > oz at lindenlab.com> wrote: > > > Tomorrow and Friday (Feb 17 & 18), Linden Lab is going to be holding an > in-house Hackathon (stopping work on many other things, getting many > developers together all at once, and focusing on getting a lot done in short > time) to upgrade our builds of all our libraries and the viewer to a new > toolchain, including our new package management tool (autobuild) > and Visual Studio 2010 for Windows (yes... about time... whatever... we're > doing it). > > Our goals are simply stated: > > 1. Get all open source components into repositories under > hg.secondlife.com (eg bitbucket.org/lindenlab/). All the third party > components (things not created by LL) that we incorporate will be in > repositories named with the prefix "3p-". Most of these repositories exist > now, but not all have sources in them yet. > 2. Get each component packaged with an autobuild configuration for > whatever platforms it is needed on. > 3. Get each component needed on Windows building under autobuild with > VS 2010. > 4. Get a TeamCity-automated build configured for each component > repository with the resulting prebuilds of open components uploaded to > public directories. > 5. Get the viewer built using the resulting prebuilt libraries, also > under autobuild with VS 2010. > > We also expect to integrate some automated viewer testing into our > automated viewer builds, but none of that will be externally visible. > > If you make a chart with a row for each component, and a column for each of > 1 through 4 above, it's a lot of boxes to fill in... many have already been > done: there are some complete rows, but it's still a big job. > > I will be providing public updates on the wiki (form and location TBD... > watch this thread) and on the #opensl IRC channel of how we're doing and the > status of each public repository. > > A non-goal for the Lindens is building the components with Visual Studio > Express. There is currently a limitation (see OPEN-1 in jira) that makes > using Express cumbersome (it requires separate configuration). We do > recognize that Express is important to open developers, and want it to be > supported, but there's only so much we can do ourselves in two days. There > is an autobuild configuration checked in for building the viewer under > autobuild including VS Express: > http://bitbucket.org/oz_linden/viewer-autobuild > > > I'm going to try to get some supporting documentation up on the wiki today > or early tomorrow. It should be possible for open developers to help us > test whether or not the component builds can be used in Express as we go > along. If people want to do that and feed me changes, I'll try to get them > incorporated in real time as much as possible. > > Once all this is done (and it probably will not be merged to > viewer-development immediately after the hackathon), this new toolchain will > be the "supported" way to build the viewer and its dependencies, which means > that if you really need to build with other tools, you'll have to work out > how to do so - we'll consider accepting changes to support them so long as > they're reasonably clean and don't break the standard way of doing it. > Maintaining support for building with older versions of Visual Studio will > _not_ be a goal, and getting review time for them will probably be hard. > > > > > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > > > > > -- > > ------------------------------------------------------------------------------------------------------------------------------- > This email is a private and confidential communication. Any use of email > may be subject to the laws and regulations of the United States. You may not > Repost, Distribute nor reproduce any content of this message. > > ------------------------------------------------------------------------------------------------------------------------------- > > ------------------------------------------------------------------------------------------------------------------------------- > > _______________________________________________ Policies and (un)subscribe > information available here: http://wiki.secondlife.com/wiki/OpenSource-DevPlease read the policies before posting to keep unmoderated posting > privileges > -- ------------------------------------------------------------------------------------------------------------------------------- This email is a private and confidential communication. Any use of email may be subject to the laws and regulations of the United States. You may not Repost, Distribute nor reproduce any content of this message. ------------------------------------------------------------------------------------------------------------------------------- ------------------------------------------------------------------------------------------------------------------------------- -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110218/cb9d9860/attachment.htm From twisted_laws at hotmail.com Sat Feb 19 06:47:16 2011 From: twisted_laws at hotmail.com (Twisted Laws) Date: Sat, 19 Feb 2011 09:47:16 -0500 Subject: [opensource-dev] autobuild on linux Message-ID: on Ubuntu ... i've installed python-boto (sudo apt-get install python-boto) [also tried getting boto source direct and installing with 'sudo python setup.py install' after pulling with 'svn checkout http://boto.googlecode.com/svn/trunk'] i've installed llbase (hg clone https://bitbucket.org/lindenlab/llbase) and installed with 'sudo python setup.py install' i've re-installed autobuild (hg clone https://bitbucket.org/lindenlab/autobuild) and installed with 'sudo python setup.py install' when i run autobuild configure -c OpenSourceRelWithDebInfo I still get 'autobuild.common.AutobuildError: invalid 'pathcheck' setting for 'boto' .... looking in common.py, the pathcheck for boto is 'lib/python2.5/boto' Anyone have any hints to help me get further? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110219/da5da185/attachment.htm From thickbrick.sleaford at gmail.com Sat Feb 19 09:08:34 2011 From: thickbrick.sleaford at gmail.com (Thickbrick Sleaford) Date: Sat, 19 Feb 2011 17:08:34 -0000 Subject: [opensource-dev] Review Request: VWR-24889: When a bake texture upload fails, retry instead of giving up. In-Reply-To: <20110217170041.13983.62075@domU-12-31-38-00-90-68.compute-1.internal> References: <20110217170041.13983.62075@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110219170834.13391.8802@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/152/ ----------------------------------------------------------- (Updated Feb. 19, 2011, 9:08 a.m.) Review request for Viewer. Summary (updated) ------- When a bake upload fails, the viewer doesn't retry it, and subsequently doesn't send a AgentSetAppearance message. This can happen without the user being aware, leaving the avatar looking good on their screen, but not updated to the same outfit on other people's screens. The avatar will remain in that state until the user does something that causes a rebake (manually rebake or change outfit.) The solution here is to retry the upload after a small delay. What this diff changes: when a full-res upload fails, retry to upload it after a 5s delay, up to 5 times (in case the cap is available, last attempt is via the old asset store.) Also, some clearer log messages. This implements an old *FIX: comment: // *FIX: retry upload after n seconds, asset server could be busy This isn't needed for low res uploads, because they don't block subsequent full-res uploads (mNeedsUpload isn't set to FALSE in LLTexLayerSetBuffer::doUpload in low-res uploads.) This addresses bug VWR-24889. http://jira.secondlife.com/browse/VWR-24889 Diffs (updated) ----- indra/newview/llassetuploadresponders.h 379da6bd50a5 indra/newview/llassetuploadresponders.cpp 379da6bd50a5 indra/newview/lltexlayer.h 379da6bd50a5 indra/newview/lltexlayer.cpp 379da6bd50a5 Diff: http://codereview.secondlife.com/r/152/diff Testing ------- Attempted outfit changes using a problematic connection (not recently used outfits to avoid using cached bakes). Looked for "Baked full res texture upload for failed" log messages, observed the subsequent retries and successful upload for that region. Observed that eventually the fully-baked avatar is visible to other users. Thanks, Thickbrick -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110219/c7710df5/attachment.htm From thickbrick.sleaford at gmail.com Sat Feb 19 09:13:23 2011 From: thickbrick.sleaford at gmail.com (Thickbrick Sleaford) Date: Sat, 19 Feb 2011 17:13:23 -0000 Subject: [opensource-dev] Review Request: VWR-24889: When a bake texture upload fails, retry instead of giving up. In-Reply-To: <20110217215952.13392.25544@domU-12-31-38-00-90-68.compute-1.internal> References: <20110217215952.13392.25544@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110219171323.13418.41842@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 17, 2011, 1:59 p.m., Boroondas Gupte wrote: > > Both comments are addressed in the new diff. - Thickbrick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/152/#review375 ----------------------------------------------------------- On Feb. 19, 2011, 9:08 a.m., Thickbrick Sleaford wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/152/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2011, 9:08 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > When a bake upload fails, the viewer doesn't retry it, and subsequently doesn't send a AgentSetAppearance message. This can happen without the user being aware, leaving the avatar looking good on their screen, but not updated to the same outfit on other people's screens. The avatar will remain in that state until the user does something that causes a rebake (manually rebake or change outfit.) The solution here is to retry the upload after a small delay. > > What this diff changes: when a full-res upload fails, retry to upload it after a 5s delay, up to 5 times (in case the cap is available, last attempt is via the old asset store.) Also, some clearer log messages. This implements an old *FIX: comment: > // *FIX: retry upload after n seconds, asset server could be busy > > This isn't needed for low res uploads, because they don't block subsequent full-res uploads (mNeedsUpload isn't set to FALSE in LLTexLayerSetBuffer::doUpload in low-res uploads.) > > > This addresses bug VWR-24889. > http://jira.secondlife.com/browse/VWR-24889 > > > Diffs > ----- > > indra/newview/llassetuploadresponders.h 379da6bd50a5 > indra/newview/llassetuploadresponders.cpp 379da6bd50a5 > indra/newview/lltexlayer.h 379da6bd50a5 > indra/newview/lltexlayer.cpp 379da6bd50a5 > > Diff: http://codereview.secondlife.com/r/152/diff > > > Testing > ------- > > Attempted outfit changes using a problematic connection (not recently used outfits to avoid using cached bakes). Looked for "Baked full res texture upload for failed" log messages, observed the subsequent retries and successful upload for that region. Observed that eventually the fully-baked avatar is visible to other users. > > > Thanks, > > Thickbrick > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110219/15febb36/attachment.htm From ardylay at gmail.com Sat Feb 19 09:32:40 2011 From: ardylay at gmail.com (ardylay at gmail.com) Date: Sat, 19 Feb 2011 17:32:40 -0000 Subject: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default. Message-ID: <20110219173240.15549.74221@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/153/ ----------------------------------------------------------- Review request for Viewer. Summary ------- https://jira.secondlife.com/browse/VWR-24917 I have been finding the redundent display of functionally equivalent names in nearby chat history and IM history quite tiresome. Simple proposal: If the resident's Display Name is at the default then do not display their user.name. https://bitbucket.org/ArdyLay/viewer-development-vwr-24917 Change is to: LLAvatarName::getCompleteName I find the following Callers: LLAvatarActions::requestFriendshipDialog LLAvatarActions::startIM LLAvatarActions::startCall LLIMModel::LLIMSession LLIMModel::logToFile LLPostponedNotification::onAvatarNameCache LLUrlEntryAgent::onAvatarNameCache LLUrlEntryAgent::getLabel LLUrlEntryAgentCompleteName::getName // Callback for name resolution of a god/estate message llviewermessage.cpp(2149): args["NAME"] = av_name.getCompleteName(); llviewermessage.cpp(2154): chat.mText = av_name.getCompleteName() + ": " + message; static void on_avatar_name_cache_toast ... llimview.cpp(108): args["FROM"] = av_name.getCompleteName(); Some of these make me wonder if this change will cause some defects and should be implimented as a seperate function. This addresses bug VWR-24917. http://jira.secondlife.com/browse/VWR-24917 Diffs ----- doc/contributions.txt c10d5e37db1e indra/llcommon/llavatarname.cpp c10d5e37db1e Diff: http://codereview.secondlife.com/r/153/diff Testing ------- I have been using this trivial change and have shared it with a friend, via bitbucket. We have both built the viewer on Windows 7 and find the resulting reduction in redundent text in chat and IM history on screen to be very helpful. Thanks, ardy.lay -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110219/202f44c7/attachment.htm From sl.nicky.ml at googlemail.com Sat Feb 19 10:06:11 2011 From: sl.nicky.ml at googlemail.com (Nicky D.) Date: Sat, 19 Feb 2011 19:06:11 +0100 Subject: [opensource-dev] autobuild on linux In-Reply-To: References: Message-ID: > > when i run autobuild configure -c OpenSourceRelWithDebInfo I still get > 'autobuild.common.AutobuildError: invalid 'pathcheck' setting for 'boto' > ....? looking in common.py, the pathcheck for boto is 'lib/python2.5/boto' > > Anyone have any hints to help me get further? > As normal user try the following ( cd "/var/tmp/`whoami`/install.cache" && wget http://s3.amazonaws.com/viewer-source-downloads/install_pkgs/boto-1.9b-common-20100414.tar.bz2 ) Then try again. Looks like boto is a prereg that needs to be downloaded, but for downloading you need boto. Or something like this :) autobuild should really be happy if there is a system wide boto and use this. For now you need to populate install.cache with the package, than autobuild will unpack it for you and continue from there. Cheers, Nicky From sl.nicky.ml at googlemail.com Sat Feb 19 11:30:25 2011 From: sl.nicky.ml at googlemail.com (Nicky D.) Date: Sat, 19 Feb 2011 20:30:25 +0100 Subject: [opensource-dev] Linux build error: missing binary operator before token "(" (was: Hacking up to Visual Studio 2010 ...) In-Reply-To: <4D5E77E1.1080703@boroon.dasgupta.ch> References: <4D5C3B3F.5090603@lindenlab.com> <4D5DC3A5.9010600@lindenlab.com> <4D5E77E1.1080703@boroon.dasgupta.ch> Message-ID: > [19:13:30]: LogScan (1s) > [19:13:30]: [LogScan] from /usr/include/c++/4.1.3/cmath:53, > [19:13:30]: [LogScan] from > /var/opt/teamcity/checkout/L-oz_viewer-autobuild2010/latest/indra/llcommon/linden_common.h:48, > [19:13:30]: [LogScan] from > /var/opt/teamcity/checkout/L-oz_viewer-autobuild2010/latest/indra/newview/tests/lldateutil_test.cpp:26: > [19:13:30]: [LogScan] /usr/include/bits/huge_val.h:28:18: error: missing > binary operator before token "(" > [19:13:30]: [LogScan] /usr/include/bits/huge_val.h:30:20: error: missing > binary operator before token "(" > > With "build" in the second command instead of "configure", I'm getting the > same error, though not just for /usr/include/bits/huge_val.h but many more > system headers, too. > Tried it today, getting that too. Huge slew of errors. Even though this looks intimidating, the reason is really simple. In OZ's version of json there is a file features.h in ../include/json/. Metaphorical speaking there he laid the bomb. It is then trigged in cmake/JsonCpp.cmake and newview/CMakeList.txt JsonCpp.cmake sets JSONCPP_INCLUDE_DIRS to ${LIBS_PREBUILD_DIR)/include/json. newview/CMakeList.txt adds JSONCPP_INCLUDE_DIRS to the system include dirs. Now the the problem with gcc is, that adding include dirs with -I makes them be searched before the system include dirs. And there our little bomb goes off. Because now the compiler findes the features.h file first in ../include/json. When it fact it needs the system one from /usr/include/features.h. One solution might be to use the -I- switch or -iquote for new gcc versions. But lucky enough there is a trivially simple fix, just use ${LIBS_PREBUILD_DIR)/include for JSONCPP_INCLUDE_DIRS. I attached a patch that does just this. Standalone builds might need some extra hackery, I did not try one of those yet. Cheers, Nicky -------------- next part -------------- A non-text attachment was scrubbed... Name: 14877.patch Type: text/x-patch Size: 1323 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110219/f64027f7/attachment.bin From xotmid at gmail.com Sat Feb 19 11:34:53 2011 From: xotmid at gmail.com (Brandon Husbands) Date: Sat, 19 Feb 2011 13:34:53 -0600 Subject: [opensource-dev] Autobuild still requires cmake? Message-ID: If the goal is to have a building tool why does it still require cmake? -- ------------------------------------------------------------------------------------------------------------------------------- This email is a private and confidential communication. Any use of email may be subject to the laws and regulations of the United States. You may not Repost, Distribute nor reproduce any content of this message. ------------------------------------------------------------------------------------------------------------------------------- ------------------------------------------------------------------------------------------------------------------------------- -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110219/a08f1ab4/attachment.htm From ima.mechanique at blueyonder.co.uk Sat Feb 19 11:51:58 2011 From: ima.mechanique at blueyonder.co.uk (Ima Mechanique) Date: Sat, 19 Feb 2011 19:51:58 GMT Subject: [opensource-dev] Autobuild still requires cmake? In-Reply-To: References: Message-ID: <20110219194859.C627.5FD3A259@blueyonder.co.uk> > If the goal is to have a building tool why does it still require cmake? See Oz's original post. Short version "Autobuild is a framework for maintaining and building libraries and other programs. It acts as director providing a common interface to build and package libraries and programs, but it is not a build system like make or cmake (it uses them "under the covers")." > -- > ------------------------------------------------------------------------------------------------------------------------------- > This email is a private and confidential communication. Any use of email may > be subject to the laws and regulations of the United States. You may not > Repost, Distribute nor reproduce any content of this message. > ------------------------------------------------------------------------------------------------------------------------------- > ------------------------------------------------------------------------------------------------------------------------------- -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk From robertltux at gmail.com Sat Feb 19 12:47:25 2011 From: robertltux at gmail.com (Robert Martin) Date: Sat, 19 Feb 2011 15:47:25 -0500 Subject: [opensource-dev] Wild idea on building an install platform Message-ID: As a sidebar to the whole autobuild system it would be cool if somebody could download a program and then verify that they have a Valid install platform (bonus points if it could also download the missing parts (i suppose that you could only pop the webpage for MS VStudio). -- Robert L Martin From sllists at boroon.dasgupta.ch Sat Feb 19 15:33:13 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Sun, 20 Feb 2011 00:33:13 +0100 Subject: [opensource-dev] Linux build error: missing binary operator before token "(" In-Reply-To: References: <4D5C3B3F.5090603@lindenlab.com> <4D5DC3A5.9010600@lindenlab.com> <4D5E77E1.1080703@boroon.dasgupta.ch> Message-ID: <4D605339.8000607@boroon.dasgupta.ch> On 02/19/2011 08:30 PM, Nicky D. wrote: >> [...] >> [19:13:30]: [LogScan] /usr/include/bits/huge_val.h:30:20: error: missing >> binary operator before token "(" >> [...] > Tried it today, getting that too. Huge slew of errors. > > Even though this looks intimidating, the reason is really simple. > > In OZ's version of json there is a file features.h in > ../include/json/. Metaphorical > speaking there he laid the bomb. > It is then trigged in cmake/JsonCpp.cmake and newview/CMakeList.txt > > JsonCpp.cmake sets JSONCPP_INCLUDE_DIRS to ${LIBS_PREBUILD_DIR)/include/json. > newview/CMakeList.txt adds JSONCPP_INCLUDE_DIRS to the system include dirs. > > Now the the problem with gcc is, that adding include dirs with -I > makes them be searched > before the system include dirs. > And there our little bomb goes off. Because now the compiler findes > the features.h file > first in ../include/json. When it fact it needs the system one from > /usr/include/features.h. That analysis looks correct, so go ask Oz about that Eternal Glory he offered on IRC. :-) > One solution might be to use the -I- switch or -iquote for new gcc > versions. But lucky > enough there is a trivially simple fix, just use > ${LIBS_PREBUILD_DIR)/include for > JSONCPP_INCLUDE_DIRS. > > I attached a patch that does just this. I just tested, and reverting eeb812d81330 (the changeset that switched to the new json download) works as a workaround, too. Though, I guess your change is the preferred way to fix this issue, because 1. there probably was a reason for updating jsoncpp 2. the other jsoncpp headers in the package also have very generic names, so using the containing dir as a way of namespacing will probably avoid further conflicts in the future > Standalone builds might need > some extra hackery, > I did not try one of those yet. Since 7690f4cb5e81 , the jsoncpp include was probably broken for standalone anyway. (Can't test, as standalone fails due to other (unrelated) errors.) Cheers, Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110220/0003d694/attachment.htm From nickyperian at yahoo.com Sat Feb 19 16:41:35 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Sat, 19 Feb 2011 16:41:35 -0800 (PST) Subject: [opensource-dev] unresolved external media_plugin_webkit.obj viewer-development and viewer-autobuild w/ Visual Studio 10 Message-ID: <288463.96133.qm@web43511.mail.sp1.yahoo.com> I have used a self compiled Visual Studio 10 llqtwebkit.lib and successfully built Imprudence 1.4.0, logged in to SL, and used search and the internal web browser. No errors at all. Using viewer-development and viewer-autobuild I get the following link error. "c:\users\bill\lindenhg\viewer-autobuild-vc100\build-vc80\media_plugins\webkit\media_plugin_webkit.vcxproj" (default target) (23) -> (Link target) -> media_plugin_webkit.obj : error LNK2019: unresolved external symbol "public: bool __thiscall LLQtWebKit::keyboardEvent(int,enum LLQtWebKit::e_key_event,unsigned int,char const *,enum LLQtWebKit::e_keyboard_modifier,unsigned int,unsigned int,unsigned int)" (?keyboardEvent at LLQtWebKit@@QAE_NHW4e_key_event at 1@IPBDW4e_keyboard_modifier at 1@III at Z) referenced in function "private: void __thiscall MediaPluginWebKit::keyEvent(enum LLQtWebKit::e_key_event,int,enum LLQtWebKit::e_keyboard_modifier,class LLSD)" (?keyEvent at MediaPluginWebKit@@AAEXW4e_key_event at LLQtWebKit@@HW4e_keyboard_modifier at 3@VLLSD@@@Z) [c:\users\bill\lindenhg\viewer-autobuild-vc100\build-vc80\media_plugins\webkit\media_plugin_webkit.vcxproj] ] C:\Users\Bill\lindenhg\viewer-autobuild-vc100\build-vc80\media_plugins\webkit\RelWithDebInfo\media_plugin_webkit.dll : fatal error LNK1120: 1 unresolved externals [c:\users\bill\lindenhg\viewer-autobuild-vc100\build-vc80\media_plugins\webkit\media_plugin_webkit.vcxproj] Anyone have ideas of where to start looking. I guess v-d and v-a could be using a method that is expected to be in the llqtwebkit.lib that Imprudence never used. Or, maybe the method it isn't properly declared within the viewer code. I would like some help on this one. Thanks, NickyP -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110219/9f27aab3/attachment.htm From jhwelch at gmail.com Sun Feb 20 14:59:17 2011 From: jhwelch at gmail.com (Jonathan Welch) Date: Sun, 20 Feb 2011 17:59:17 -0500 Subject: [opensource-dev] Testers needed to repo storm-1002 Message-ID: I started to work on Storm-1002 (Cannot delete broken links) today and _could_ delete a broken link. I tried reproducing the non-deleting issue on viewer 2.1.2 (it was reported as affecting v2.1.1) and did not have trouble there, either. If you have a few minutes could you follow the steps in https://jira.secondlife.com/browse/STORM-1002 and see if you can or cannot delete a broken link? At this point I can only surmise that a server change has fixed this issue somehow. Thank you, -jonathan From trilobyte550m at gmail.com Sun Feb 20 15:51:47 2011 From: trilobyte550m at gmail.com (Trilo Byte) Date: Sun, 20 Feb 2011 15:51:47 -0800 Subject: [opensource-dev] Extended Groups broken? Message-ID: <4855272F-0DD0-451F-BD55-9FD49289CF12@gmail.com> I'm not sure if this broke in a previous build, but extended groups functionality is broken in build 221543 (Mac client). I can see and access the 29 groups I currently belong to, but the Viewer will not let me join any new groups or accept a group invitation from another resident. The only workaround I could find was to relog using the Viewer 2.5 release. I tried searching the JIRA, but there are so many groups-related entries I've had no luck trying to find an existing issue. Is anybody else having trouble adding groups beyond 25? TriloByte Zanzibar From cinder at cinderblocks.biz Sun Feb 20 16:00:24 2011 From: cinder at cinderblocks.biz (Cinder Roxley) Date: Sun, 20 Feb 2011 17:00:24 -0700 Subject: [opensource-dev] Testers needed to repo storm-1002 In-Reply-To: References: Message-ID: <000001cbd15a$571978a0$054c69e0$@biz> I CAN delete broken links in Viewer 2.5.0. I could not reproduce the issue. -- Cindy -----Original Message----- From: opensource-dev-bounces at lists.secondlife.com [mailto:opensource-dev-bounces at lists.secondlife.com] On Behalf Of Jonathan Welch Sent: Sunday, February 20, 2011 3:59 PM To: OpenSource Mailing List Subject: [opensource-dev] Testers needed to repo storm-1002 I started to work on Storm-1002 (Cannot delete broken links) today and _could_ delete a broken link. I tried reproducing the non-deleting issue on viewer 2.1.2 (it was reported as affecting v2.1.1) and did not have trouble there, either. If you have a few minutes could you follow the steps in https://jira.secondlife.com/browse/STORM-1002 and see if you can or cannot delete a broken link? At this point I can only surmise that a server change has fixed this issue somehow. Thank you, -jonathan From jhwelch at gmail.com Sun Feb 20 16:04:45 2011 From: jhwelch at gmail.com (Jonathan Welch) Date: Sun, 20 Feb 2011 19:04:45 -0500 Subject: [opensource-dev] Extended Groups broken? In-Reply-To: <4855272F-0DD0-451F-BD55-9FD49289CF12@gmail.com> References: <4855272F-0DD0-451F-BD55-9FD49289CF12@gmail.com> Message-ID: I was working on one of these group bugs and was joining and leaving group 42 over and over. This is on a recently compiled Windows viewer. -jonathan From trilobyte550m at gmail.com Sun Feb 20 17:52:09 2011 From: trilobyte550m at gmail.com (Trilo Byte) Date: Sun, 20 Feb 2011 17:52:09 -0800 Subject: [opensource-dev] Extended Groups broken? In-Reply-To: References: <4855272F-0DD0-451F-BD55-9FD49289CF12@gmail.com> Message-ID: Both the region I was on and the region I'd logged onto were non-RC servers, running server version 11.02.08 220555. Being that it worked fine when relogging using Viewer 2.5, it seems the bug is viewer-side rather than server-side. On Feb 20, 2011, at 4:02 PM, Keith Jaeger wrote: > Try logging into a non RC sim. This seems to help that issue. > > > From: trilobyte550m at gmail.com > > Date: Sun, 20 Feb 2011 15:51:47 -0800 > > To: opensource-dev at lists.secondlife.com > > Subject: [opensource-dev] Extended Groups broken? > > > > I'm not sure if this broke in a previous build, but extended groups functionality is broken in build 221543 (Mac client). I can see and access the 29 groups I currently belong to, but the Viewer will not let me join any new groups or accept a group invitation from another resident. The only workaround I could find was to relog using the Viewer 2.5 release. > > > > I tried searching the JIRA, but there are so many groups-related entries I've had no luck trying to find an existing issue. Is anybody else having trouble adding groups beyond 25? > > > > TriloByte Zanzibar > > _______________________________________________ > > Policies and (un)subscribe information available here: > > http://wiki.secondlife.com/wiki/OpenSource-Dev > > Please read the policies before posting to keep unmoderated posting privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110220/19bcc185/attachment.htm From soft at lindenlab.com Sun Feb 20 18:57:20 2011 From: soft at lindenlab.com (Brian McGroarty) Date: Sun, 20 Feb 2011 18:57:20 -0800 Subject: [opensource-dev] Extended Groups broken? In-Reply-To: References: <4855272F-0DD0-451F-BD55-9FD49289CF12@gmail.com> Message-ID: It might not be a viewer problem. The group allowance is controlled by a config file on the login hosts and the sims. The supporting sim code has been around for some time, so the sim version shouldn't factor into it. It's more likely a config problem. With a current viewer, search SecondLife.log for a line containing "gMaxAgentGroups" and report what you see. Here's mine: process_login_success_response: gMaxAgentGroups read from login.cgi: 42 Next, check what sim host you're on via Help->About... If you provide the log line and the sim host, several Lindens on this list can check for a config problem. Also, some SL proxies don't pass new login fields properly. If you're using an inspector or similar, have a try without it. On Sun, Feb 20, 2011 at 5:52 PM, Trilo Byte wrote: > Both the region I was on and the region I'd logged onto were non-RC > servers, running server version 11.02.08 220555. Being that it worked fine > when relogging using Viewer 2.5, it seems the bug is viewer-side rather than > server-side. > > On Feb 20, 2011, at 4:02 PM, Keith Jaeger wrote: > > Try logging into a non RC sim. This seems to help that issue. > > > From: trilobyte550m at gmail.com > > Date: Sun, 20 Feb 2011 15:51:47 -0800 > > To: opensource-dev at lists.secondlife.com > > Subject: [opensource-dev] Extended Groups broken? > > > > > I'm not sure if this broke in a previous build, but extended groups > functionality is broken in build 221543 (Mac client). I can see and access > the 29 groups I currently belong to, but the Viewer will not let me join any > new groups or accept a group invitation from another resident. The only > workaround I could find was to relog using the Viewer 2.5 release. > > > > I tried searching the JIRA, but there are so many groups-related entries > I've had no luck trying to find an existing issue. Is anybody else having > trouble adding groups beyond 25? > > > > TriloByte Zanzibar > > _______________________________________________ > > Policies and (un)subscribe information available here: > > http://wiki.secondlife.com/wiki/OpenSource-Dev > > Please read the policies before posting to keep unmoderated posting > privileges > > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > -- Brian McGroarty | Linden Lab Sent from my Newton MP2100 via acoustic coupler -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110220/02d64999/attachment.htm From soft at lindenlab.com Sun Feb 20 19:25:48 2011 From: soft at lindenlab.com (Brian McGroarty) Date: Sun, 20 Feb 2011 19:25:48 -0800 Subject: [opensource-dev] Extended Groups broken? In-Reply-To: References: <4855272F-0DD0-451F-BD55-9FD49289CF12@gmail.com> Message-ID: I found at least one login host with the wrong number set. I'll push this to ops. On Sun, Feb 20, 2011 at 6:57 PM, Brian McGroarty wrote: > It might not be a viewer problem. > > The group allowance is controlled by a config file on the login hosts and > the sims. The supporting sim code has been around for some time, so the sim > version shouldn't factor into it. It's more likely a config problem. With a > current viewer, search SecondLife.log for a line containing > "gMaxAgentGroups" and report what you see. Here's mine: > > process_login_success_response: gMaxAgentGroups read from login.cgi: 42 > > Next, check what sim host you're on via Help->About... If you provide the > log line and the sim host, several Lindens on this list can check for a > config problem. > > Also, some SL proxies don't pass new login fields properly. If you're using > an inspector or similar, have a try without it. > > > On Sun, Feb 20, 2011 at 5:52 PM, Trilo Byte wrote: > >> Both the region I was on and the region I'd logged onto were non-RC >> servers, running server version 11.02.08 220555. Being that it worked fine >> when relogging using Viewer 2.5, it seems the bug is viewer-side rather than >> server-side. >> >> On Feb 20, 2011, at 4:02 PM, Keith Jaeger wrote: >> >> Try logging into a non RC sim. This seems to help that issue. >> >> > From: trilobyte550m at gmail.com >> > Date: Sun, 20 Feb 2011 15:51:47 -0800 >> > To: opensource-dev at lists.secondlife.com >> > Subject: [opensource-dev] Extended Groups broken? >> >> > >> > I'm not sure if this broke in a previous build, but extended groups >> functionality is broken in build 221543 (Mac client). I can see and access >> the 29 groups I currently belong to, but the Viewer will not let me join any >> new groups or accept a group invitation from another resident. The only >> workaround I could find was to relog using the Viewer 2.5 release. >> > >> > I tried searching the JIRA, but there are so many groups-related entries >> I've had no luck trying to find an existing issue. Is anybody else having >> trouble adding groups beyond 25? >> > >> > TriloByte Zanzibar >> > _______________________________________________ >> > Policies and (un)subscribe information available here: >> > http://wiki.secondlife.com/wiki/OpenSource-Dev >> > Please read the policies before posting to keep unmoderated posting >> privileges >> >> >> >> _______________________________________________ >> Policies and (un)subscribe information available here: >> http://wiki.secondlife.com/wiki/OpenSource-Dev >> Please read the policies before posting to keep unmoderated posting >> privileges >> > > > > -- > Brian McGroarty | Linden Lab > Sent from my Newton MP2100 via acoustic coupler > -- Brian McGroarty | Linden Lab Sent from my Newton MP2100 via acoustic coupler -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110220/8187b4ff/attachment-0001.htm From soft at lindenlab.com Sun Feb 20 19:36:18 2011 From: soft at lindenlab.com (Brian McGroarty) Date: Sun, 20 Feb 2011 19:36:18 -0800 Subject: [opensource-dev] Extended Groups broken? In-Reply-To: References: <4855272F-0DD0-451F-BD55-9FD49289CF12@gmail.com> Message-ID: Well, that was quick. One login server had been previously disabled after having problems. It was repaired and brought back into rotation without a config update. If you see the problem again and you logged in after 8pm today (Sunday), please post the gMaxAgentGroups line below as well as the sim host you're on. On Sun, Feb 20, 2011 at 7:25 PM, Brian McGroarty wrote: > I found at least one login host with the wrong number set. I'll push this > to ops. > > > On Sun, Feb 20, 2011 at 6:57 PM, Brian McGroarty wrote: > >> It might not be a viewer problem. >> >> The group allowance is controlled by a config file on the login hosts and >> the sims. The supporting sim code has been around for some time, so the sim >> version shouldn't factor into it. It's more likely a config problem. With a >> current viewer, search SecondLife.log for a line containing >> "gMaxAgentGroups" and report what you see. Here's mine: >> >> process_login_success_response: gMaxAgentGroups read from login.cgi: 42 >> >> Next, check what sim host you're on via Help->About... If you provide the >> log line and the sim host, several Lindens on this list can check for a >> config problem. >> >> Also, some SL proxies don't pass new login fields properly. If you're >> using an inspector or similar, have a try without it. >> >> >> On Sun, Feb 20, 2011 at 5:52 PM, Trilo Byte wrote: >> >>> Both the region I was on and the region I'd logged onto were non-RC >>> servers, running server version 11.02.08 220555. Being that it worked fine >>> when relogging using Viewer 2.5, it seems the bug is viewer-side rather than >>> server-side. >>> >>> On Feb 20, 2011, at 4:02 PM, Keith Jaeger wrote: >>> >>> Try logging into a non RC sim. This seems to help that issue. >>> >>> > From: trilobyte550m at gmail.com >>> > Date: Sun, 20 Feb 2011 15:51:47 -0800 >>> > To: opensource-dev at lists.secondlife.com >>> > Subject: [opensource-dev] Extended Groups broken? >>> >>> > >>> > I'm not sure if this broke in a previous build, but extended groups >>> functionality is broken in build 221543 (Mac client). I can see and access >>> the 29 groups I currently belong to, but the Viewer will not let me join any >>> new groups or accept a group invitation from another resident. The only >>> workaround I could find was to relog using the Viewer 2.5 release. >>> > >>> > I tried searching the JIRA, but there are so many groups-related >>> entries I've had no luck trying to find an existing issue. Is anybody else >>> having trouble adding groups beyond 25? >>> > >>> > TriloByte Zanzibar >>> > _______________________________________________ >>> > Policies and (un)subscribe information available here: >>> > http://wiki.secondlife.com/wiki/OpenSource-Dev >>> > Please read the policies before posting to keep unmoderated posting >>> privileges >>> >>> >>> >>> _______________________________________________ >>> Policies and (un)subscribe information available here: >>> http://wiki.secondlife.com/wiki/OpenSource-Dev >>> Please read the policies before posting to keep unmoderated posting >>> privileges >>> >> >> >> >> -- >> Brian McGroarty | Linden Lab >> Sent from my Newton MP2100 via acoustic coupler >> > > > > -- > Brian McGroarty | Linden Lab > Sent from my Newton MP2100 via acoustic coupler > -- Brian McGroarty | Linden Lab Sent from my Newton MP2100 via acoustic coupler -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110220/2935ce30/attachment.htm From kadah.coba at gmail.com Sun Feb 20 23:38:46 2011 From: kadah.coba at gmail.com (Kadah Coba) Date: Sun, 20 Feb 2011 23:38:46 -0800 Subject: [opensource-dev] Extended Groups broken? In-Reply-To: References: <4855272F-0DD0-451F-BD55-9FD49289CF12@gmail.com> Message-ID: <4D621686.20704@gmail.com> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Thanks Soft, I was just noticing this issue this morning. Could it have any relation to a problem I've been getting for over a week with attachments on group notices never getting to my inventory when I try to open then? I'm trying to test it but I cannot get it to repro on purpose so I can file a jira on it. On 2/20/2011 7:36 PM, Brian McGroarty wrote: > Well, that was quick. > > One login server had been previously disabled after having problems. It > was repaired and brought back into rotation without a config update. If > you see the problem again and you logged in after 8pm today (Sunday), > please post the gMaxAgentGroups line below as well as the sim host > you're on. > > On Sun, Feb 20, 2011 at 7:25 PM, Brian McGroarty > wrote: > > I found at least one login host with the wrong number set. I'll push > this to ops. > > > On Sun, Feb 20, 2011 at 6:57 PM, Brian McGroarty > wrote: > > It might not be a viewer problem. > > The group allowance is controlled by a config file on the login > hosts and the sims. The supporting sim code has been around for > some time, so the sim version shouldn't factor into it. It's > more likely a config problem. With a current viewer, search > SecondLife.log for a line containing "gMaxAgentGroups" and > report what you see. Here's mine: > > process_login_success_response: gMaxAgentGroups read from > login.cgi: 42 > > Next, check what sim host you're on via Help->About... If you > provide the log line and the sim host, several Lindens on this > list can check for a config problem. > > Also, some SL proxies don't pass new login fields properly. If > you're using an inspector or similar, have a try without it. > > > On Sun, Feb 20, 2011 at 5:52 PM, Trilo Byte > > wrote: > > Both the region I was on and the region I'd logged onto > were non-RC servers, running server version 11.02.08 > 220555. Being that it worked fine when relogging using > Viewer 2.5, it seems the bug is viewer-side rather than > server-side. > > On Feb 20, 2011, at 4:02 PM, Keith Jaeger wrote: > >> Try logging into a non RC sim. This seems to help that issue. >> >> > From: trilobyte550m at gmail.com >> >> > Date: Sun, 20 Feb 2011 15:51:47 -0800 >> > To: opensource-dev at lists.secondlife.com >> >> > Subject: [opensource-dev] Extended Groups broken? >> >> > >> > I'm not sure if this broke in a previous build, but >> extended groups functionality is broken in build 221543 >> (Mac client). I can see and access the 29 groups I >> currently belong to, but the Viewer will not let me join >> any new groups or accept a group invitation from another >> resident. The only workaround I could find was to relog >> using the Viewer 2.5 release. >> > >> > I tried searching the JIRA, but there are so many >> groups-related entries I've had no luck trying to find an >> existing issue. Is anybody else having trouble adding >> groups beyond 25? >> > >> > TriloByte Zanzibar >> > _______________________________________________ >> > Policies and (un)subscribe information available here: >> > http://wiki.secondlife.com/wiki/OpenSource-Dev >> > Please read the policies before posting to keep >> unmoderated posting privileges > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated > posting privileges > > > > > -- > Brian McGroarty | Linden Lab > Sent from my Newton MP2100 via acoustic coupler > > > > > -- > Brian McGroarty | Linden Lab > Sent from my Newton MP2100 via acoustic coupler > > > > > -- > Brian McGroarty | Linden Lab > Sent from my Newton MP2100 via acoustic coupler > > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJNYhaGAAoJEGUNvxojA31t9+kH/3oAhPh0nlsZxMjM5ut1N4yz rsXeCYvGISCJiUw4c/b82WK6RgjZ0+LljvhHFNmBg4uFI3uCA4wkPwBiQDQgqd1r PFa+OdVwdyiTvn7V182wLeJWQTlczxaFOaY6AyOAQGHQAf80pPWcfRCTwUKEv9Tm CopGgZPZDy1CjouQyLa+uHAG/QDjPd0gc6lzGJmIc9pkznmYnUCZmZCCk18pyXe0 If0Bd1UtxO0PHSKHCWc8GcmdMVR8I59s/QU7ZHq0NKUgOPLr+0ty1yNdTBEMoBwq MLZRIf4It5jvv29Cq2x6wo1M58r3t0qFJ5h2RIZm2DFTDNZ9KMA+nsHjj/8hsUM= =qCLG -----END PGP SIGNATURE----- From soft at lindenlab.com Sun Feb 20 23:51:07 2011 From: soft at lindenlab.com (Brian McGroarty) Date: Sun, 20 Feb 2011 23:51:07 -0800 Subject: [opensource-dev] Extended Groups broken? In-Reply-To: <4D621686.20704@gmail.com> References: <4855272F-0DD0-451F-BD55-9FD49289CF12@gmail.com> <4D621686.20704@gmail.com> Message-ID: It shouldn't be related. The only places I've see the cap referenced in sim code are in the group joining and creation logic. Have you tried it with group notice attachment delivery and receipt on the different simulator versions? On Sun, Feb 20, 2011 at 11:38 PM, Kadah Coba wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Thanks Soft, I was just noticing this issue this morning. > > Could it have any relation to a problem I've been getting for over a > week with attachments on group notices never getting to my inventory > when I try to open then? I'm trying to test it but I cannot get it to > repro on purpose so I can file a jira on it. > > > On 2/20/2011 7:36 PM, Brian McGroarty wrote: > > Well, that was quick. > > > > One login server had been previously disabled after having problems. It > > was repaired and brought back into rotation without a config update. If > > you see the problem again and you logged in after 8pm today (Sunday), > > please post the gMaxAgentGroups line below as well as the sim host > > you're on. > > > > On Sun, Feb 20, 2011 at 7:25 PM, Brian McGroarty > > wrote: > > > > I found at least one login host with the wrong number set. I'll push > > this to ops. > > > > > > On Sun, Feb 20, 2011 at 6:57 PM, Brian McGroarty > > wrote: > > > > It might not be a viewer problem. > > > > The group allowance is controlled by a config file on the login > > hosts and the sims. The supporting sim code has been around for > > some time, so the sim version shouldn't factor into it. It's > > more likely a config problem. With a current viewer, search > > SecondLife.log for a line containing "gMaxAgentGroups" and > > report what you see. Here's mine: > > > > process_login_success_response: gMaxAgentGroups read from > > login.cgi: 42 > > > > Next, check what sim host you're on via Help->About... If you > > provide the log line and the sim host, several Lindens on this > > list can check for a config problem. > > > > Also, some SL proxies don't pass new login fields properly. If > > you're using an inspector or similar, have a try without it. > > > > > > On Sun, Feb 20, 2011 at 5:52 PM, Trilo Byte > > > > wrote: > > > > Both the region I was on and the region I'd logged onto > > were non-RC servers, running server version 11.02.08 > > 220555. Being that it worked fine when relogging using > > Viewer 2.5, it seems the bug is viewer-side rather than > > server-side. > > > > On Feb 20, 2011, at 4:02 PM, Keith Jaeger wrote: > > > >> Try logging into a non RC sim. This seems to help that > issue. > >> > >> > From: trilobyte550m at gmail.com > >> > >> > Date: Sun, 20 Feb 2011 15:51:47 -0800 > >> > To: opensource-dev at lists.secondlife.com > >> > >> > Subject: [opensource-dev] Extended Groups broken? > >> > >> > > >> > I'm not sure if this broke in a previous build, but > >> extended groups functionality is broken in build 221543 > >> (Mac client). I can see and access the 29 groups I > >> currently belong to, but the Viewer will not let me join > >> any new groups or accept a group invitation from another > >> resident. The only workaround I could find was to relog > >> using the Viewer 2.5 release. > >> > > >> > I tried searching the JIRA, but there are so many > >> groups-related entries I've had no luck trying to find an > >> existing issue. Is anybody else having trouble adding > >> groups beyond 25? > >> > > >> > TriloByte Zanzibar > >> > _______________________________________________ > >> > Policies and (un)subscribe information available here: > >> > http://wiki.secondlife.com/wiki/OpenSource-Dev > >> > Please read the policies before posting to keep > >> unmoderated posting privileges > > > > > > _______________________________________________ > > Policies and (un)subscribe information available here: > > http://wiki.secondlife.com/wiki/OpenSource-Dev > > Please read the policies before posting to keep unmoderated > > posting privileges > > > > > > > > > > -- > > Brian McGroarty | Linden Lab > > Sent from my Newton MP2100 via acoustic coupler > > > > > > > > > > -- > > Brian McGroarty | Linden Lab > > Sent from my Newton MP2100 via acoustic coupler > > > > > > > > > > -- > > Brian McGroarty | Linden Lab > > Sent from my Newton MP2100 via acoustic coupler > > > > > > > > _______________________________________________ > > Policies and (un)subscribe information available here: > > http://wiki.secondlife.com/wiki/OpenSource-Dev > > Please read the policies before posting to keep unmoderated posting > privileges > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.9 (MingW32) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ > > iQEcBAEBAgAGBQJNYhaGAAoJEGUNvxojA31t9+kH/3oAhPh0nlsZxMjM5ut1N4yz > rsXeCYvGISCJiUw4c/b82WK6RgjZ0+LljvhHFNmBg4uFI3uCA4wkPwBiQDQgqd1r > PFa+OdVwdyiTvn7V182wLeJWQTlczxaFOaY6AyOAQGHQAf80pPWcfRCTwUKEv9Tm > CopGgZPZDy1CjouQyLa+uHAG/QDjPd0gc6lzGJmIc9pkznmYnUCZmZCCk18pyXe0 > If0Bd1UtxO0PHSKHCWc8GcmdMVR8I59s/QU7ZHq0NKUgOPLr+0ty1yNdTBEMoBwq > MLZRIf4It5jvv29Cq2x6wo1M58r3t0qFJ5h2RIZm2DFTDNZ9KMA+nsHjj/8hsUM= > =qCLG > -----END PGP SIGNATURE----- > -- Brian McGroarty | Linden Lab Sent from my Newton MP2100 via acoustic coupler -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110220/b492a0de/attachment-0001.htm From akanevsky at productengine.com Mon Feb 21 00:36:17 2011 From: akanevsky at productengine.com (Anya Kanevsky) Date: Mon, 21 Feb 2011 00:36:17 -0800 Subject: [opensource-dev] Daily Scrum Summary - Friday, February 18 Message-ID: Sprint 11, ends 02.28.11 Thursday, February 17th - Friday, Frebruary 18th General Notes ------------------------------ - Sprint 11 extended until 02.28.11 - Daily Scrum meetings cancelled Thu & Fri due to hackathon. - Kudos to those who sent their reports! - Today?s summary both for Thu & Fri. - Monday, February 21st is a LL holiday. - MMOTD: Oz Team Status ------------------------------ Bao Linden ------------------------------ *PAST* - worked on VBO improvements and testing, - attended some hackathon sessions: - VS2010 installation and some other stuff. *FUTURE* - more tests on VBO improvements *IMPEDIMENTS* - none Grumpity ProductEngine ------------------------------ *PAST* - PO approval: STORM-980, STORM-680, STORM-974, STORM-979 - Sprint 11 has been extended. - Due to hackathon and holiday on monday, we aren?t ready to wrap up yet. - Sprint Retrospective is friday 2/25. Spring Planning is monday 2/28 *FUTURE* - STORM cleanup in jira - meet with Geo to figure out better scrum process with our constraints - update Team status summaries - prep for sprint wrapup and planning *IMPEDIMENTS* - none Seth Productengine ------------------------------ *PAST* - STORM-357 (Gestures button is in the pressed state after drag-n-drop but gestures list isn't visible) - Fixed. - STORM-1004 (Unblocking/blocking name sometimes deletes identically named entry, but of different TYPE) - Fixed and sent for review. - STORM-533 (User is unable to save snapshot after pressing "More" and "Less" (without any changes)) - Resolved as cannot reproduce *FUTURE* - STORY STORM-889 (Put Link/Unlink in Edit Panel) *IMPEDIMENTS* - none Vadim ProductEngine ------------------------------ *PAST* - Story STORM-2 (Customizable viewer layouts): - Implemented multiple web profiles handling. - Suspending the work until further notice - Bug STORM-594 (Crash in LLView::handleVisibilityChange): - Found out it only happens after you get disconnected for being idle. - Decreased priority to Minor. - Story STORM-326 (Create and Save your Windlight Skies/Water as a persistent, new Default setting): - WIP. *FUTURE* - Story STORM-326 (Create and Save your Windlight Skies/Water as a persistent, new Default setting). *IMPEDIMENTS* - Who's gonna create out-of-the-box viewer layouts for STORM-2? Andrey ProductEngine ------------------------------ *PAST* - ran Landmarks Login Screen test plan against various platforms - tried to re-create STORM-984, found an issue with new-style resident names, see the ticket comments - reported VWR-24883 - uploaded Nearby Media test plan, About Land Test plan - Region/Estate TP in progress - started next regression cycle against v-d, see spreadsheet - reported 1 issue VWR-24903 - Object profile, World Map - Mini-Map - reported 2 issues - added Place Profile test plan - published Sell & Buy Land Test Plan - Region/Estate TP is almost done (Estate & Covenant tabs are left) *FUTURE* - continue v-d regression testing - verify integrated STORM tickets - complete Region/Estate TP *IMPEDIMENTS* - none Jonathan Yap ------------------------------ *PAST* - VWR-24895 (It is sometimes necessary to press ALT+CTRL+D twice to get the Debug menu on the login screen) - - Fixed this annoying little bug. Can it be brought into Storm? - VWR-24460 (Group invite fails to let you join groups when groups maxed even when you leave group) *FUTURE* - VWR-24460 *IMPEDIMENTS* - STORM - 956 - File message_template.msg needs to be pushed into viewer code tree from server code tree. - -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110221/122e24c8/attachment-0001.htm From kadah.coba at gmail.com Mon Feb 21 00:37:26 2011 From: kadah.coba at gmail.com (Kadah Coba) Date: Mon, 21 Feb 2011 00:37:26 -0800 Subject: [opensource-dev] Extended Groups broken? In-Reply-To: References: <4855272F-0DD0-451F-BD55-9FD49289CF12@gmail.com> <4D621686.20704@gmail.com> Message-ID: <4D622446.9090409@gmail.com> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Yes, I was getting repro while I was on the fallowing, Second Life Server 11.02.08.220555 Second Life RC Magnum 11.02.15.221184 and the previous one As well as the previous LeTigre (my home region was apparently moved to release channel in the last rollout) I've typically get it when I log in and have one or more notices from offline; I almost never change regions before handling group notices, so the failure is occuring with in the same region as which I log in. I've had at least a dozen failures like that this week a lone. In the tests we attempted today, the notices were sent from Second Life Server 11.02.08.220555 and received in the above current versions for both online and offline. Repro wasn't successful. Is it possible that this could be a additional effect of SVC-6766? On 2/20/2011 11:51 PM, Brian McGroarty wrote: > It shouldn't be related. The only places I've see the cap referenced in > sim code are in the group joining and creation logic. > > Have you tried it with group notice attachment delivery and receipt on > the different simulator versions? > > On Sun, Feb 20, 2011 at 11:38 PM, Kadah Coba > wrote: > > Thanks Soft, I was just noticing this issue this morning. > > Could it have any relation to a problem I've been getting for over a > week with attachments on group notices never getting to my inventory > when I try to open then? I'm trying to test it but I cannot get it to > repro on purpose so I can file a jira on it. > > > On 2/20/2011 7:36 PM, Brian McGroarty wrote: >> Well, that was quick. > >> One login server had been previously disabled after having > problems. It >> was repaired and brought back into rotation without a config > update. If >> you see the problem again and you logged in after 8pm today (Sunday), >> please post the gMaxAgentGroups line below as well as the sim host >> you're on. > >> On Sun, Feb 20, 2011 at 7:25 PM, Brian McGroarty > >> >> wrote: > >> I found at least one login host with the wrong number set. > I'll push >> this to ops. > > >> On Sun, Feb 20, 2011 at 6:57 PM, Brian McGroarty > >> >> wrote: > >> It might not be a viewer problem. > >> The group allowance is controlled by a config file on the > login >> hosts and the sims. The supporting sim code has been > around for >> some time, so the sim version shouldn't factor into it. It's >> more likely a config problem. With a current viewer, search >> SecondLife.log for a line containing "gMaxAgentGroups" and >> report what you see. Here's mine: > >> process_login_success_response: gMaxAgentGroups read from >> login.cgi: 42 > >> Next, check what sim host you're on via Help->About... If you >> provide the log line and the sim host, several Lindens on this >> list can check for a config problem. > >> Also, some SL proxies don't pass new login fields properly. If >> you're using an inspector or similar, have a try without it. > > >> On Sun, Feb 20, 2011 at 5:52 PM, Trilo Byte >> > >> > wrote: > >> Both the region I was on and the region I'd logged onto >> were non-RC servers, running server version 11.02.08 >> 220555. Being that it worked fine when relogging using >> Viewer 2.5, it seems the bug is viewer-side rather than >> server-side. > >> On Feb 20, 2011, at 4:02 PM, Keith Jaeger wrote: > >>> Try logging into a non RC sim. This seems to help > that issue. >>> >>> > From: trilobyte550m at gmail.com > >>> > >>> > Date: Sun, 20 Feb 2011 15:51:47 -0800 >>> > To: opensource-dev at lists.secondlife.com > >>> > >>> > Subject: [opensource-dev] Extended Groups broken? >>> >>> > >>> > I'm not sure if this broke in a previous build, but >>> extended groups functionality is broken in build 221543 >>> (Mac client). I can see and access the 29 groups I >>> currently belong to, but the Viewer will not let me join >>> any new groups or accept a group invitation from another >>> resident. The only workaround I could find was to relog >>> using the Viewer 2.5 release. >>> > >>> > I tried searching the JIRA, but there are so many >>> groups-related entries I've had no luck trying to find an >>> existing issue. Is anybody else having trouble adding >>> groups beyond 25? >>> > >>> > TriloByte Zanzibar >>> > _______________________________________________ >>> > Policies and (un)subscribe information available here: >>> > http://wiki.secondlife.com/wiki/OpenSource-Dev >>> > Please read the policies before posting to keep >>> unmoderated posting privileges > > >> _______________________________________________ >> Policies and (un)subscribe information available here: >> http://wiki.secondlife.com/wiki/OpenSource-Dev >> Please read the policies before posting to keep > unmoderated >> posting privileges > > > > >> -- >> Brian McGroarty | Linden Lab >> Sent from my Newton MP2100 via acoustic coupler > > > > >> -- >> Brian McGroarty | Linden Lab >> Sent from my Newton MP2100 via acoustic coupler > > > > >> -- >> Brian McGroarty | Linden Lab >> Sent from my Newton MP2100 via acoustic coupler > > > >> _______________________________________________ >> Policies and (un)subscribe information available here: >> http://wiki.secondlife.com/wiki/OpenSource-Dev >> Please read the policies before posting to keep unmoderated > posting privileges > > -- > Brian McGroarty | Linden Lab > Sent from my Newton MP2100 via acoustic coupler -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJNYiRGAAoJEGUNvxojA31tLNIH/3Qk++GRsBYNwRbTZotMyNBr L6GjPmPBAp8DDj91dB0iF9tt3swQva7Yjle/w6LLtiUtPauVdO0gOKAAXB/9tB9t aaCpUVjgcxuD9R4Ic1BQa/mY6Z4Vgyh2vLsYoUCdm6UPwQEHnRDwzBA0dGsEAuCQ WtH9GqAshMShoVr1d5JsbYqIDH6o9pJN+RRrAItunAu+p9KtGEEUs49pgnvCclGC DOJRw/KZpm/wbR/QBcU0tOxO8RIDA4Dn6+ZJVOdyAY3mY3RCSluNMsRmAXgGKhwU MUcVj57B0hCGlil3ecaHV8s/8FMwrLpySxUkYEdyVVcOHCP5EG0a3seubFSVu5c= =rPoj -----END PGP SIGNATURE----- From akanevsky at productengine.com Mon Feb 21 00:47:05 2011 From: akanevsky at productengine.com (Anya Kanevsky) Date: Mon, 21 Feb 2011 00:47:05 -0800 Subject: [opensource-dev] Daily Scrum Summary - Friday, February 18 - correction Message-ID: That was weird. I robbed from Paul to give to Seth. The wikiis corrected, and below the correct status for both. Sorry about that! Paul ProductEngine ------------------------------ *PAST* - STORM-357 (Gestures button is in the pressed state after drag-n-drop but gestures list isn't visible) - Fixed. - STORM-1004 (Unblocking/blocking name sometimes deletes identically named entry, but of different TYPE) - Fixed and sent for review. - STORM-533 (User is unable to save snapshot after pressing "More" and "Less" (without any changes)) - Resolved as cannot reproduce *FUTURE* - STORY STORM-889 (Put Link/Unlink in Edit Panel) *IMPEDIMENTS* - none Seth ProductEngine ------------------------------ *PAST* - BUG (STORM-984) [VWR-24765] Some Favorites missing from list on login screen - Cannot reproduce. - BUG (STORM-842) "Start at" list isn't populated with favorites if user name is typed in fashion "firstname.lastname" - Fixed. - STORY (STORM-28) As a User, I want the ability to send my calling card to others. - Added own calling card created in Calling Cards/Friends/All folder. - Working on friends list in People panel synchronization issues with calling cards list. *FUTURE* - STORY (STORM-28) As a User, I want the ability to send my calling card to others. - Estimated: 6-8 hours. *IMPEDIMENTS* - none -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110221/e10d6857/attachment.htm From opensourceobscure at gmail.com Mon Feb 21 01:03:48 2011 From: opensourceobscure at gmail.com (Opensource Obscure) Date: Mon, 21 Feb 2011 10:03:48 +0100 Subject: [opensource-dev] Extended Groups broken? In-Reply-To: <4D621686.20704@gmail.com> References: <4855272F-0DD0-451F-BD55-9FD49289CF12@gmail.com> <4D621686.20704@gmail.com> Message-ID: This happened to me multiple times yesterday while I was on a TPV (Kirstens last release). Please tell the list if you find or file an appropriate JIRA issue about this so that I can add my feedback. Opensource Obscure On Mon, Feb 21, 2011 at 08:38, Kadah Coba wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Thanks Soft, I was just noticing this issue this morning. > > Could it have any relation to a problem I've been getting for over a > week with attachments on group notices never getting to my inventory > when I try to open then? I'm trying to test it but I cannot get it to > repro on purpose so I can file a jira on it. From opensourceobscure at gmail.com Mon Feb 21 04:48:20 2011 From: opensourceobscure at gmail.com (Opensource Obscure) Date: Mon, 21 Feb 2011 13:48:20 +0100 Subject: [opensource-dev] Daily Scrum Summary - Friday, February 18 In-Reply-To: References: Message-ID: On Mon, Feb 21, 2011 at 09:36, Anya Kanevsky wrote: > Bao Linden > PAST > worked on VBO improvements and testing, Is it possible to have some more details or links to JIRA about this? > Vadim ProductEngine > IMPEDIMENTS > Who's gonna create out-of-the-box viewer layouts for STORM-2? Would user contributions about this be possible / appropriate? Opensource Obscure From oz at lindenlab.com Mon Feb 21 06:28:48 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Mon, 21 Feb 2011 09:28:48 -0500 Subject: [opensource-dev] Is 'STANDALONE' confusing? Message-ID: <4D6276A0.4040708@lindenlab.com> We have a suggestion that the term 'STANDALONE' in the build processes is misleading and should be changed to something that is more accurately descriptive of what it really does. https://jira.secondlife.com/browse/OPEN-11 We discussed this briefly last week: https://wiki.secondlife.com/wiki/Open_Development_User_Group/Archive/2011-02-16#13:22 So... should this be changed? and if so, to what? If we are going to change it, the replacement term should, in addition to being more accurately descriptive of what it does, be an affirmative term - don't suggest any 'NO_*" replacements. In the interest of not cycling endlessly on this, unless we appear to be well on the way to agreeing that it should be replaced and agreeing on a replacement by the end of the day on Friday Feb 25th, the issue will be closed and out of bounds for discussion for a period of at least one year. From sllists at boroon.dasgupta.ch Mon Feb 21 06:38:01 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Mon, 21 Feb 2011 15:38:01 +0100 Subject: [opensource-dev] Is 'STANDALONE' confusing? In-Reply-To: <4D6276A0.4040708@lindenlab.com> References: <4D6276A0.4040708@lindenlab.com> Message-ID: <4D6278C9.7080609@boroon.dasgupta.ch> On 02/21/2011 03:28 PM, Oz Linden (Scott Lawrence) wrote: > If we are going to change it, the replacement term should, in addition > to being more accurately descriptive of what it does, be an affirmative > term - don't suggest any 'NO_*" replacements. Would it be acceptable to invert the setting's semantic in order to avoid a negation? I.e., STANDALONE=OFF would become NEW_SETTING=ON and vice versa. That'd allow for easy-to-understand names like USE_PREBUILD_LIBS or DOWNLOAD_NEEDED_DEPENDENCIES. Off course, the default value should be inverted together with the setting's semantic, such that the default behavior does not change. Cheers, Boroondas From thickbrick.sleaford at gmail.com Mon Feb 21 07:00:38 2011 From: thickbrick.sleaford at gmail.com (Thickbrick Sleaford) Date: Mon, 21 Feb 2011 17:00:38 +0200 Subject: [opensource-dev] Is 'STANDALONE' confusing? In-Reply-To: <4D6278C9.7080609@boroon.dasgupta.ch> References: <4D6276A0.4040708@lindenlab.com> <4D6278C9.7080609@boroon.dasgupta.ch> Message-ID: <201102211700.38754.thickbrick.sleaford@gmail.com> On Monday 21 February 2011 16:38:01 Boroondas Gupte wrote: > On 02/21/2011 03:28 PM, Oz Linden (Scott Lawrence) wrote: > > If we are going to change it, the replacement term should, in addition > > to being more accurately descriptive of what it does, be an affirmative > > term - don't suggest any 'NO_*" replacements. > > Would it be acceptable to invert the setting's semantic in order to > avoid a negation? I.e., STANDALONE=OFF would become NEW_SETTING=ON and > vice versa. That'd allow for easy-to-understand names like > USE_PREBUILD_LIBS or DOWNLOAD_NEEDED_DEPENDENCIES. > > Off course, the default value should be inverted together with the > setting's semantic, such that the default behavior does not change. > I agree with Boroondas. I think it *should* be changed, and my vote goes to USE_PREBUILT_LIBS (which should default to on.) -- Thickbrick From discrete.dreamscape at gmail.com Mon Feb 21 07:19:03 2011 From: discrete.dreamscape at gmail.com (Discrete Dreamscape) Date: Mon, 21 Feb 2011 10:19:03 -0500 Subject: [opensource-dev] Is 'STANDALONE' confusing? In-Reply-To: <201102211700.38754.thickbrick.sleaford@gmail.com> References: <4D6276A0.4040708@lindenlab.com> <4D6278C9.7080609@boroon.dasgupta.ch> <201102211700.38754.thickbrick.sleaford@gmail.com> Message-ID: USE_PREBUILT_LIBS doesn't make absolute sense either if you consider the fact that your system's libraries are "prebuilt". This would imply that the inverse of the setting would cause supporting libraries to be built from source or some such. I would make it something like "USE_LINDEN_LIBS". Discrete On Mon, Feb 21, 2011 at 10:00 AM, Thickbrick Sleaford < thickbrick.sleaford at gmail.com> wrote: > On Monday 21 February 2011 16:38:01 Boroondas Gupte wrote: > > On 02/21/2011 03:28 PM, Oz Linden (Scott Lawrence) wrote: > > > If we are going to change it, the replacement term should, in addition > > > to being more accurately descriptive of what it does, be an affirmative > > > term - don't suggest any 'NO_*" replacements. > > > > Would it be acceptable to invert the setting's semantic in order to > > avoid a negation? I.e., STANDALONE=OFF would become NEW_SETTING=ON and > > vice versa. That'd allow for easy-to-understand names like > > USE_PREBUILD_LIBS or DOWNLOAD_NEEDED_DEPENDENCIES. > > > > Off course, the default value should be inverted together with the > > setting's semantic, such that the default behavior does not change. > > > > I agree with Boroondas. I think it *should* be changed, and my vote goes to > USE_PREBUILT_LIBS (which should default to on.) > > > -- > Thickbrick > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110221/c800c54b/attachment.htm From aleric.inglewood at gmail.com Mon Feb 21 07:41:17 2011 From: aleric.inglewood at gmail.com (Aleric Inglewood) Date: Mon, 21 Feb 2011 16:41:17 +0100 Subject: [opensource-dev] Is 'STANDALONE' confusing? In-Reply-To: References: <4D6276A0.4040708@lindenlab.com> <4D6278C9.7080609@boroon.dasgupta.ch> <201102211700.38754.thickbrick.sleaford@gmail.com> Message-ID: I agree too. I have found 'standalone' to be confusing all along, and inverting it (ON <--> OFF) is a very logical thing to do. If inverting is acceptable then USE_PREBUILT_LIBS sounds good. Or perhaps, USE_LL_PREBUILT_LIBS which would be more clear, but wouldn't work for the TPV's :(. If inverting is not acceptable then maybe change '--standalone' into --no-prebuilt-libs. A LOT worse, but still better than 'standalone' would be USE_SYSTEM_LIBS. On Mon, Feb 21, 2011 at 4:19 PM, Discrete Dreamscape wrote: > USE_PREBUILT_LIBS doesn't make absolute sense either if you consider the > fact that your system's libraries are "prebuilt". This would imply that the > inverse of the setting would cause supporting libraries to be built from > source or some such. > I would make it something like "USE_LINDEN_LIBS". > > Discrete > > On Mon, Feb 21, 2011 at 10:00 AM, Thickbrick Sleaford > wrote: >> >> On Monday 21 February 2011 16:38:01 Boroondas Gupte wrote: >> > On 02/21/2011 03:28 PM, Oz Linden (Scott Lawrence) wrote: >> > > If we are going to change it, the replacement term should, in addition >> > > to being more accurately descriptive of what it does, be an >> > > affirmative >> > > term - don't suggest any 'NO_*" replacements. >> > >> > Would it be acceptable to invert the setting's semantic in order to >> > avoid a negation? I.e., STANDALONE=OFF would become NEW_SETTING=ON and >> > vice versa. That'd allow for easy-to-understand names like >> > USE_PREBUILD_LIBS or DOWNLOAD_NEEDED_DEPENDENCIES. >> > >> > Off course, the default value should be inverted together with the >> > setting's semantic, such that the default behavior does not change. >> > >> >> I agree with Boroondas. I think it *should* be changed, and my vote goes >> to >> USE_PREBUILT_LIBS (which should default to on.) >> >> >> -- >> Thickbrick >> _______________________________________________ >> Policies and (un)subscribe information available here: >> http://wiki.secondlife.com/wiki/OpenSource-Dev >> Please read the policies before posting to keep unmoderated posting >> privileges > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > From sheet.spotter at gmail.com Mon Feb 21 07:41:39 2011 From: sheet.spotter at gmail.com (Sheet Spotter) Date: Mon, 21 Feb 2011 09:41:39 -0600 Subject: [opensource-dev] Attachments from stale group notices do not open In-Reply-To: References: <4855272F-0DD0-451F-BD55-9FD49289CF12@gmail.com><4D621686.20704@gmail.com> Message-ID: <0FFB238880B34AC7AC668246E5296ECD@kenb> Opening attachments from a stale group notice has been failing for a year or more. https://jira.secondlife.com/browse/VWR-18240 There are many related issues and duplicates. The problem reliably occurs with the production viewer when trying to open a group notice that was received hours ago. The workaround is to open the group info. The attachment can then be opened from the list of group notices. Sheet Spotter -----Original Message----- From: opensource-dev-bounces at lists.secondlife.com [mailto:opensource-dev-bounces at lists.secondlife.com] On Behalf Of Opensource Obscure Sent: February 21, 2011 3:04 AM To: Kadah Coba Cc: opensource-dev at lists.secondlife.com Subject: Re: [opensource-dev] Extended Groups broken? This happened to me multiple times yesterday while I was on a TPV (Kirstens last release). Please tell the list if you find or file an appropriate JIRA issue about this so that I can add my feedback. Opensource Obscure On Mon, Feb 21, 2011 at 08:38, Kadah Coba wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Thanks Soft, I was just noticing this issue this morning. > > Could it have any relation to a problem I've been getting for over a > week with attachments on group notices never getting to my inventory > when I try to open then? I'm trying to test it but I cannot get it to > repro on purpose so I can file a jira on it. _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges From sllists at boroon.dasgupta.ch Mon Feb 21 07:46:05 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Mon, 21 Feb 2011 16:46:05 +0100 Subject: [opensource-dev] Is 'STANDALONE' confusing? In-Reply-To: References: <4D6276A0.4040708@lindenlab.com> <4D6278C9.7080609@boroon.dasgupta.ch> <201102211700.38754.thickbrick.sleaford@gmail.com> Message-ID: <4D6288BD.3070100@boroon.dasgupta.ch> On 02/21/2011 04:41 PM, Aleric Inglewood wrote: > A LOT worse, but still better than 'standalone' would be USE_SYSTEM_LIBS. Why would you consider USE_SYSTEM_LIBS worse than other suggestions? Cheers, Boroondas From ima.mechanique at blueyonder.co.uk Mon Feb 21 08:38:11 2011 From: ima.mechanique at blueyonder.co.uk (Ima Mechanique) Date: Mon, 21 Feb 2011 16:38:11 GMT Subject: [opensource-dev] Is 'STANDALONE' confusing? In-Reply-To: <4D6278C9.7080609@boroon.dasgupta.ch> References: <4D6276A0.4040708@lindenlab.com> <4D6278C9.7080609@boroon.dasgupta.ch> Message-ID: <20110221163255.B0D1.5FD3A259@blueyonder.co.uk> > On 02/21/2011 03:28 PM, Oz Linden (Scott Lawrence) wrote: > > If we are going to change it, the replacement term should, in addition > > to being more accurately descriptive of what it does, be an affirmative > > term - don't suggest any 'NO_*" replacements. > > Would it be acceptable to invert the setting's semantic in order to > avoid a negation? I.e., STANDALONE=OFF would become NEW_SETTING=ON and > vice versa. That'd allow for easy-to-understand names like > USE_PREBUILD_LIBS or DOWNLOAD_NEEDED_DEPENDENCIES. > > Off course, the default value should be inverted together with the > setting's semantic, such that the default behavior does not change. Agree with changing the semantics. I'd prefer something shorter and somewhat more consistent with existing settings, like "LL_LIBS_DOWNLOAD" or "LL_LIBS_FETCH" However, it's not a strong preference. > Cheers, > Boroondas > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk From nickyperian at yahoo.com Mon Feb 21 08:47:25 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Mon, 21 Feb 2011 08:47:25 -0800 (PST) Subject: [opensource-dev] VS2010 Express Start To Finish -- Request testing and feedback Message-ID: <279669.4998.qm@web43511.mail.sp1.yahoo.com> https://bitbucket.org/NickyP/viewer-autobuild2010-wip This is set to call self built google breakpad from: https://bitbucket.org/NickyP/viewer-autobuild2010-wip/downloads/google_breakpad-0.0.0-revNickyP-windows-20110215.tar.bz2 autobuild config: C:\Users\Bill\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug configure -c VC10msbuildRelWithDebInfo -- -DLL_TESTS:BOOL=OFF -DMSVC_REDIST_PATH:PATH=C:\Users\Bill\lindenhg\WorkaroundFiles\vcredist_vc100_30319_x86 -DPACKAGE:BOOL=ON autobuild build: C:\users\bill\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug build -c VC10msbuildRelWithDebInfo 2>&1 |c:\cygwin\bin\tee Build.log set environment: call "C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\bin\vcvars32.bat" set INCLUDE=C:\Program Files\Microsoft SDKs\Windows\v7.1\Include;C:\Program Files\Microsoft SDKs\Windows\v7.1\Include\gl;C:\Program Files (x86)\Microsoft DirectX SDK (June 2010)\Include;%INCLUDE% set LIB=C:\Program Files\Microsoft SDKs\Windows\v7.1\Lib;C:\Program Files\Microsoft SDKs\Windows\v7.1\Lib\x64;C:\Program Files (x86)\Microsoft DirectX SDK (June 2010)\Lib;%LIB% -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110221/5e32e7ca/attachment-0001.htm From kf6kjg at gmail.com Mon Feb 21 09:12:21 2011 From: kf6kjg at gmail.com (Ricky) Date: Mon, 21 Feb 2011 09:12:21 -0800 Subject: [opensource-dev] Is 'STANDALONE' confusing? In-Reply-To: <4D6288BD.3070100@boroon.dasgupta.ch> References: <4D6276A0.4040708@lindenlab.com> <4D6278C9.7080609@boroon.dasgupta.ch> <201102211700.38754.thickbrick.sleaford@gmail.com> <4D6288BD.3070100@boroon.dasgupta.ch> Message-ID: My vote is for USE_SYSTEM_LIBS. It needs no semantic inversion, only a simple name replace. The only issue I can think of is that system wide user libs are considered "system" by this, but I consider that to be a trivial complaint. That said, the above inverting suggetion is still better than what we have now! :P Ricky Cron Stardust On Monday, February 21, 2011, Boroondas Gupte wrote: > On 02/21/2011 04:41 PM, Aleric Inglewood wrote: >> A LOT worse, but still better than 'standalone' would be USE_SYSTEM_LIBS. > Why would you consider USE_SYSTEM_LIBS worse than other suggestions? > > Cheers, > Boroondas > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges > From angel_of_crimson at hotmail.com Mon Feb 21 10:25:24 2011 From: angel_of_crimson at hotmail.com (Erin Mallory) Date: Mon, 21 Feb 2011 13:25:24 -0500 Subject: [opensource-dev] Is 'STANDALONE' confusing? In-Reply-To: <201102211700.38754.thickbrick.sleaford@gmail.com> References: <4D6276A0.4040708@lindenlab.com>, <4D6278C9.7080609@boroon.dasgupta.ch>, <201102211700.38754.thickbrick.sleaford@gmail.com> Message-ID: As a tester I gotta say Boroondas's suggestion to me, is far and away the least confusing... so it gets my vote too... ~Cummere > From: thickbrick.sleaford at gmail.com > To: opensource-dev at lists.secondlife.com > Date: Mon, 21 Feb 2011 17:00:38 +0200 > Subject: Re: [opensource-dev] Is 'STANDALONE' confusing? > > On Monday 21 February 2011 16:38:01 Boroondas Gupte wrote: > > On 02/21/2011 03:28 PM, Oz Linden (Scott Lawrence) wrote: > > > If we are going to change it, the replacement term should, in addition > > > to being more accurately descriptive of what it does, be an affirmative > > > term - don't suggest any 'NO_*" replacements. > > > > Would it be acceptable to invert the setting's semantic in order to > > avoid a negation? I.e., STANDALONE=OFF would become NEW_SETTING=ON and > > vice versa. That'd allow for easy-to-understand names like > > USE_PREBUILD_LIBS or DOWNLOAD_NEEDED_DEPENDENCIES. > > > > Off course, the default value should be inverted together with the > > setting's semantic, such that the default behavior does not change. > > > > I agree with Boroondas. I think it *should* be changed, and my vote goes to > USE_PREBUILT_LIBS (which should default to on.) > > > -- > Thickbrick > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110221/6a984b09/attachment.htm From aleric.inglewood at gmail.com Mon Feb 21 12:48:03 2011 From: aleric.inglewood at gmail.com (Aleric Inglewood) Date: Mon, 21 Feb 2011 21:48:03 +0100 Subject: [opensource-dev] Is 'STANDALONE' confusing? In-Reply-To: <4D6288BD.3070100@boroon.dasgupta.ch> References: <4D6276A0.4040708@lindenlab.com> <4D6278C9.7080609@boroon.dasgupta.ch> <201102211700.38754.thickbrick.sleaford@gmail.com> <4D6288BD.3070100@boroon.dasgupta.ch> Message-ID: Regarding libraries and the second life viewer we have the following issues: The version of a library (source code + headers) at the moment it is compiled into a binary. In all cases we should only use THOSE headers whenever we compile anything that will link with that binary. This is not always the case, but that is a bug then, so lets leave that out of our consideration. Hence, for this analysis we condense the header and library versions into one: the version of the library (and it's headers) that is being compiled, and are being used when compiling. This version is not necessarily the same as the runtime version of a library (where headers do not come into play at all). Furthermore we may assume that internally Linden Lab uses the same versions (that is, they compile a viewer and possibly other libraries, against the same version as that they ship as prebuilt with that viewer). However, there is an interdependency between libraries: some libraries are compiled against other libraries (and both need to be shipped). Again theoretically it would be possible that a TPV releases prebuilt libraries for some libraries but not for all: using the LL prebuilt for some. Also here I will assume that if a TPV replaces some libraries, then they will at least replace also all libraries that depend on that library or use that library, so that we can ignore library interdependencies mostly. Mostly, because we cannot ignore those dependencies for libraries that are never shipped as prebuilt: it is possible that LL compiles it's prebuilt libs against libc 2.9, some TPV compiles some prebuilts against libc 2.10 and the user that compiles her own compiler uses libc 2.11. Theoretically this can lead to problems, but that is unlikely when it concerns C libraries. Thus, as long as every C++ library is a prebuilt then we can probably ignore this anyway. Plus we probably should ignore the existance of TPV's anyway here :p Having simplified things thus, we end up with: LL prebuilt version (assumed to be shipped WITH headers) System library version (with headers in it's -dev package), or User compiled version (libraries not provided by the standard distribution). If we built 'standalone' then it's simple: we compile everything using the same version of any particular library (all libraries are compiled against eachother: the same version was used even when compiling the system libs (and should have been used while compiling the user compiled libraries). Also here an exception: if you do not compile your own libraries, but use for example Michelle's debian repository for those libraries that are not distributed with the stock debian, then those libraries might be compiled against different versions. We also ignore this since we trust that Michelle makes sure can ignore that. If we DO use the prebuilt libraries it is possible that we compile against headers that are newer than what LL used, and link with same, newer versions, at runtime. This usually shouldn't be a problem, and when it is it should be detected by one of the developers and fixed in the viewer code (ie, developers using a newer version of boost asked for viewer code fixes that are backwards compatible and cause things to work in such a case). Now to answer your question: the above is complex, even with a lot of simplification and ignoring stuff. Calling everything that is not a "Linden Lab prebuilt" a "system library" doesn't cut it. The only really clear constant in all of the above is what "prebuilt" means, especially "Linden Lab prebuilt". Therefore I think it's better to use PREBUILT as keyword than SYSTEM_LIBS. On Mon, Feb 21, 2011 at 4:46 PM, Boroondas Gupte wrote: > On 02/21/2011 04:41 PM, Aleric Inglewood wrote: >> A LOT worse, but still better than 'standalone' would be USE_SYSTEM_LIBS. > Why would you consider USE_SYSTEM_LIBS worse than other suggestions? > > Cheers, > Boroondas > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges > From ibrew.meads at gmail.com Mon Feb 21 13:28:34 2011 From: ibrew.meads at gmail.com (Ibrew Meads) Date: Mon, 21 Feb 2011 13:28:34 -0800 Subject: [opensource-dev] Is 'STANDALONE' confusing? Message-ID: I too would like to see something less confusing. My vote is for USE_LL_SYSTEM_LIBS or USE_LOCAL_SYSTEM_LIBS. I think just USE_SYSTEM_LIBS is too vague. On Feb 21, 2011 9:12 AM, "Ricky" wrote: -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110221/b818afcc/attachment.htm From sl.nicky.ml at googlemail.com Mon Feb 21 13:33:28 2011 From: sl.nicky.ml at googlemail.com (Nicky D.) Date: Mon, 21 Feb 2011 21:33:28 +0000 Subject: [opensource-dev] Is 'STANDALONE' confusing? In-Reply-To: <4D6276A0.4040708@lindenlab.com> References: <4D6276A0.4040708@lindenlab.com> Message-ID: > We have a suggestion that the term 'STANDALONE' in the build processes > is misleading and should be changed to something that is more accurately > descriptive of what it really does. > > > So... should this be changed? ?and if so, to what? > I am fine with changing it to whatever gets the most votes. Even though personally I would not touch it. In my eyes it is a minor thing, easy to get used to and only relevant for a small group of people. Can be read up in the wiki too. So yeah, a candidate to change. It just does not strive me as something worth to put much energy in it (changing source, testing, removing potential bugs, merge problems, wiki, build scripts; just to name a few pitfalls and places for change). Cheers, Nicky From slitovchuk at productengine.com Mon Feb 21 16:57:29 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Tue, 22 Feb 2011 00:57:29 -0000 Subject: [opensource-dev] Review Request: (STORM-28) As a User, I want the ability to send my calling card to others Message-ID: <20110222005729.30633.2153@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/159/ ----------------------------------------------------------- Review request for Viewer. Summary ------- - Added creating own calling card for the user to be able to share it with other residents. - Moved calling cards synchronization with friends list to the viewer start up. Previously synchronized upon opening the Friends tab in People side panel. - Calling cards for non-friends are not removed upon calling cards synchronization with friends list. - Enabled "Share" menu item for calling cards in inventory. This addresses bug STORM-28. http://jira.secondlife.com/browse/STORM-28 Diffs ----- indra/newview/llfriendcard.h c10d5e37db1e indra/newview/llfriendcard.cpp c10d5e37db1e indra/newview/llinventoryfunctions.cpp c10d5e37db1e indra/newview/llpanelpeople.cpp c10d5e37db1e Diff: http://codereview.secondlife.com/r/159/diff Testing ------- Thanks, Seth -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110222/4c290262/attachment.htm From nickyperian at yahoo.com Mon Feb 21 17:34:46 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Tue, 22 Feb 2011 01:34:46 -0000 Subject: [opensource-dev] Review Request: (STORM-28) As a User, I want the ability to send my calling card to others In-Reply-To: <20110222005729.30633.2153@domU-12-31-38-00-90-68.compute-1.internal> References: <20110222005729.30633.2153@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110222013446.30627.17331@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/159/#review381 ----------------------------------------------------------- Ship it! Reduces code and a great feature. I remember going in world multiple, making friends with my alt coping cards and sending calling cards back across inventory to get copies. So, in that respect it saves bandwidth. - Nicky On Feb. 21, 2011, 4:57 p.m., Seth ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/159/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2011, 4:57 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > - Added creating own calling card for the user to be able to share it with other residents. > - Moved calling cards synchronization with friends list to the viewer start up. Previously synchronized upon opening the Friends tab in People side panel. > - Calling cards for non-friends are not removed upon calling cards synchronization with friends list. > - Enabled "Share" menu item for calling cards in inventory. > > > This addresses bug STORM-28. > http://jira.secondlife.com/browse/STORM-28 > > > Diffs > ----- > > indra/newview/llfriendcard.h c10d5e37db1e > indra/newview/llfriendcard.cpp c10d5e37db1e > indra/newview/llinventoryfunctions.cpp c10d5e37db1e > indra/newview/llpanelpeople.cpp c10d5e37db1e > > Diff: http://codereview.secondlife.com/r/159/diff > > > Testing > ------- > > > Thanks, > > Seth > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110222/80c741e1/attachment.htm From sldev at catznip.com Tue Feb 22 04:49:22 2011 From: sldev at catznip.com (Kitty Barnett) Date: Tue, 22 Feb 2011 12:49:22 -0000 Subject: [opensource-dev] Review Request: VWR-24957: Attachments may loose their associated inventory item UUID Message-ID: <20110222124922.31178.48193@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/161/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Current flow: 1) object->extractAttachmentItemID() 2) "same object reattached" condition evaluates true => removeObject calls object->setAttachmentItemID(LLUUID::null) 3) the remainder of addObject() executes but the object's mAttachmentItemID is now "LLUUID::null" Reversing the order of (1) and (2) should prevent mAttachmentItemID from being - in this specific case accidentally - cleared This addresses bug VWR-24957. http://jira.secondlife.com/browse/VWR-24957 Diffs ----- indra/newview/llviewerjointattachment.cpp UNKNOWN Diff: http://codereview.secondlife.com/r/161/diff Testing ------- I can't trigger that block for my avie's attachments "on demand" but I actually made this change a while back (before SVC-6766) in response to reports from users and this was the only possibility I could find in the viewer where an attachment may suddenly "forget" its associated inventory item. Thanks, Kitty -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110222/63e05df7/attachment-0001.htm From qieniangao at gmail.com Tue Feb 22 05:44:19 2011 From: qieniangao at gmail.com (Qie Niangao) Date: Tue, 22 Feb 2011 08:44:19 -0500 Subject: [opensource-dev] Media Strategy? Message-ID: (I'm not entirely comfortable raising this topic here, but it very much does affect Snowstorm viability, so, with apologies in advance...) Certain alt-matching systems have attained enough grid saturation that there is widespread hesitancy to enable Media at all. (https://jira.secondlife.com/browse/VWR-24746) One part of the problem is that _AGENT-specific parcel media commands force a viewer connection regardless of the "Allow Media to auto-play" setting. Even with that changed (presumably, "corrected"), heuristic matching based on regular Parcel Media and Audio streams is easily done. To date, it is unclear what (if any) plans LL has for addressing this matter, and that rather ties the hands of developers, to know what (if any) technical response is appropriate. The developer of one such system has publicly claimed that he is privy to LL's plans about this issue; if opensource developers have been similarly informed, it would be news to me. In lieu of LL guidance, a patch has been developed for one 1.x-based TPV that would at least reduce the threat from the Media vector, by inserting a user-selectable white- / black-list before enabling stream connection. This approach does not conveniently apply to 2.x-based viewers with Shared Media.? Regardless of interface, it is unclear that any user-controlled filtering can be effective for Shared Media, given the potential number of simultaneously proffered sources. A possible approach to addressing these threats is for LL to interpose an IP anonymizing service at its network periphery through which all connections including streaming media would pass.? This would have significant bandwidth implications, and may also interfere with certain third-party content as long as studios and publishers persist with geo-specific licensing. At this point, I think developers really need to know LL's plans to address these this matter.? Personally, I'm especially interested in the fate of Shared Media, which seems gravely jeopardized. From vsavchuk at productengine.com Tue Feb 22 07:16:34 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 22 Feb 2011 15:16:34 -0000 Subject: [opensource-dev] Review Request: (STORM-28) As a User, I want the ability to send my calling card to others In-Reply-To: <20110222005729.30633.2153@domU-12-31-38-00-90-68.compute-1.internal> References: <20110222005729.30633.2153@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110222151634.30627.97482@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/159/#review382 ----------------------------------------------------------- Looks good, except for a seemingly redundant code piece. indra/newview/llpanelpeople.cpp What do you need the buddies_uuids for? It seems redundant to me. - Vadim On Feb. 21, 2011, 4:57 p.m., Seth ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/159/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2011, 4:57 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > - Added creating own calling card for the user to be able to share it with other residents. > - Moved calling cards synchronization with friends list to the viewer start up. Previously synchronized upon opening the Friends tab in People side panel. > - Calling cards for non-friends are not removed upon calling cards synchronization with friends list. > - Enabled "Share" menu item for calling cards in inventory. > > > This addresses bug STORM-28. > http://jira.secondlife.com/browse/STORM-28 > > > Diffs > ----- > > indra/newview/llfriendcard.h c10d5e37db1e > indra/newview/llfriendcard.cpp c10d5e37db1e > indra/newview/llinventoryfunctions.cpp c10d5e37db1e > indra/newview/llpanelpeople.cpp c10d5e37db1e > > Diff: http://codereview.secondlife.com/r/159/diff > > > Testing > ------- > > > Thanks, > > Seth > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110222/77565d7e/attachment.htm From vsavchuk at productengine.com Tue Feb 22 08:22:30 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 22 Feb 2011 16:22:30 -0000 Subject: [opensource-dev] Review Request: (STORM-28) As a User, I want the ability to send my calling card to others In-Reply-To: <20110222005729.30633.2153@domU-12-31-38-00-90-68.compute-1.internal> References: <20110222005729.30633.2153@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110222162230.30628.84582@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/159/#review383 ----------------------------------------------------------- Ship it! Never mind, now I see that the buddies_uuids vector is actually used. - Vadim On Feb. 21, 2011, 4:57 p.m., Seth ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/159/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2011, 4:57 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > - Added creating own calling card for the user to be able to share it with other residents. > - Moved calling cards synchronization with friends list to the viewer start up. Previously synchronized upon opening the Friends tab in People side panel. > - Calling cards for non-friends are not removed upon calling cards synchronization with friends list. > - Enabled "Share" menu item for calling cards in inventory. > > > This addresses bug STORM-28. > http://jira.secondlife.com/browse/STORM-28 > > > Diffs > ----- > > indra/newview/llfriendcard.h c10d5e37db1e > indra/newview/llfriendcard.cpp c10d5e37db1e > indra/newview/llinventoryfunctions.cpp c10d5e37db1e > indra/newview/llpanelpeople.cpp c10d5e37db1e > > Diff: http://codereview.secondlife.com/r/159/diff > > > Testing > ------- > > > Thanks, > > Seth > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110222/9cfc8203/attachment.htm From sldev at catznip.com Tue Feb 22 11:12:04 2011 From: sldev at catznip.com (Kitty Barnett) Date: Tue, 22 Feb 2011 19:12:04 -0000 Subject: [opensource-dev] Review Request: STORM-1001: Viewer needlessly hits the "ObjectMedia" cap with thousands of requests Message-ID: <20110222191204.30628.31251@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/162/ ----------------------------------------------------------- Review request for Viewer. Summary ------- S32 LLTextureEntry::setMediaTexGen(U8 media) would appear to be the root cause of the bug: The header file suggests that: // The Media Tex Gen values are bits in a bit field: // +----------+ // | .....TTM | M = Media Flags (web page), T = LLTextureEntry::eTexGen, . = unused // | 76543210 | // +----------+ const S32 TEM_MEDIA_MASK = 0x01; const S32 TEM_TEX_GEN_MASK = 0x06; and while LLTextureEntry::setTexGen() and LLTextureEntry::setMediaFlags() each properly mask off the supplied parameter with their respective bit mask, setMediaTexGen() will always return TEM_CHANGE_MEDIA even if only texgen has changed while the media flag hasn't (causing LLVOVolume::processUpdateMessage() to queue a request to the cap when it shouldn't). Changing it to: S32 LLTextureEntry::setMediaTexGen(U8 media) { S32 result = setTexGen(media & TEM_TEX_GEN_MASK); result |= setMediaFlags(media & TEM_MEDIA_MASK); return result; } appears to resolve the issue completely (the cap isn't hit unless an object nearby has media on it, or changes its URL) This addresses bug STORM-1001. http://jira.secondlife.com/browse/STORM-1001 Diffs ----- indra/llprimitive/lltextureentry.cpp UNKNOWN Diff: http://codereview.secondlife.com/r/162/diff Testing ------- Thanks, Kitty -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110222/604b5b7c/attachment.htm From oz at lindenlab.com Tue Feb 22 18:56:23 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Tue, 22 Feb 2011 21:56:23 -0500 Subject: [opensource-dev] Is 'STANDALONE' confusing? In-Reply-To: <4D6278C9.7080609@boroon.dasgupta.ch> References: <4D6276A0.4040708@lindenlab.com> <4D6278C9.7080609@boroon.dasgupta.ch> Message-ID: <4D647757.7060008@lindenlab.com> On 2011-02-21 9:38, Boroondas Gupte wrote: > On 02/21/2011 03:28 PM, Oz Linden (Scott Lawrence) wrote: >> > If we are going to change it, the replacement term should, in addition >> > to being more accurately descriptive of what it does, be an affirmative >> > term - don't suggest any 'NO_*" replacements. > Would it be acceptable to invert the setting's semantic in order to > avoid a negation? I.e., STANDALONE=OFF would become NEW_SETTING=ON and > vice versa. That'd allow for easy-to-understand names like > USE_PREBUILD_LIBS or DOWNLOAD_NEEDED_DEPENDENCIES. > > Off course, the default value should be inverted together with the > setting's semantic, such that the default behavior does not change. Yes, I think that's best (assuming that we're going to change anything). A couple of comments on the interesting discussion.... I'm not sure that any variation on 'USE_PREBUILD' quite captures the correct semantics, because in the new autobuild framework one way to work is going to be to download the project for a library you want to compile locally (perhaps to try a new version, or to make some patch) and then modify your viewer builds to use the output of that compilation. When you do that, you'll still be using exactly the same sort of prebuilt package that you would, in the default case, download from LL. The real distinction, I think, is whether or not you are using _installed_ libraries. Normally, the viewer build has only minimal reliance on the libs that are installed on the system itself - it puts the packaged libraries (which are now by default all loaded in a 'build-*/packages directory rather than being mixed in with the sources). That might suggest something like USE_PACKAGED_LIBS with a default value of NO/FALSE. From angel_of_crimson at hotmail.com Tue Feb 22 20:04:51 2011 From: angel_of_crimson at hotmail.com (Erin Mallory) Date: Tue, 22 Feb 2011 23:04:51 -0500 Subject: [opensource-dev] Is 'STANDALONE' confusing? In-Reply-To: <4D647757.7060008@lindenlab.com> References: <4D6276A0.4040708@lindenlab.com>, <4D6278C9.7080609@boroon.dasgupta.ch>, <4D647757.7060008@lindenlab.com> Message-ID: "> The real distinction, I think, is whether or not you are using > _installed_ libraries. " how about USE_INSTALLED_LIBS then? or possibly USE_LOCAL_LIBS > Date: Tue, 22 Feb 2011 21:56:23 -0500 > From: oz at lindenlab.com > To: opensource-dev at lists.secondlife.com > Subject: Re: [opensource-dev] Is 'STANDALONE' confusing? > > On 2011-02-21 9:38, Boroondas Gupte wrote: > > On 02/21/2011 03:28 PM, Oz Linden (Scott Lawrence) wrote: > >> > If we are going to change it, the replacement term should, in addition > >> > to being more accurately descriptive of what it does, be an affirmative > >> > term - don't suggest any 'NO_*" replacements. > > Would it be acceptable to invert the setting's semantic in order to > > avoid a negation? I.e., STANDALONE=OFF would become NEW_SETTING=ON and > > vice versa. That'd allow for easy-to-understand names like > > USE_PREBUILD_LIBS or DOWNLOAD_NEEDED_DEPENDENCIES. > > > > Off course, the default value should be inverted together with the > > setting's semantic, such that the default behavior does not change. > > Yes, I think that's best (assuming that we're going to change anything). > > A couple of comments on the interesting discussion.... > > I'm not sure that any variation on 'USE_PREBUILD' quite captures the > correct semantics, because in the new autobuild framework one way to > work is going to be to download the project for a library you want to > compile locally (perhaps to try a new version, or to make some patch) > and then modify your viewer builds to use the output of that > compilation. When you do that, you'll still be using exactly the same > sort of prebuilt package that you would, in the default case, download > from LL. > > The real distinction, I think, is whether or not you are using > _installed_ libraries. Normally, the viewer build has only minimal > reliance on the libs that are installed on the system itself - it puts > the packaged libraries (which are now by default all loaded in a > 'build-*/packages directory rather than being mixed in with the sources). > > That might suggest something like USE_PACKAGED_LIBS with a default value > of NO/FALSE. > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110222/ecb9de6d/attachment.htm From tateru at taterunino.net Tue Feb 22 21:05:04 2011 From: tateru at taterunino.net (Tateru Nino) Date: Wed, 23 Feb 2011 16:05:04 +1100 Subject: [opensource-dev] Is 'STANDALONE' confusing? In-Reply-To: References: <4D6276A0.4040708@lindenlab.com>, <4D6278C9.7080609@boroon.dasgupta.ch>, <4D647757.7060008@lindenlab.com> Message-ID: <4D649580.9010903@taterunino.net> Or USE_LOCALLY_INSTALLED_LIBS even. On 23/02/2011 3:04 PM, Erin Mallory wrote: > "> The real distinction, I think, is whether or not you are using > > _installed_ libraries. " > > how about USE_INSTALLED_LIBS then? or possibly USE_LOCAL_LIBS > > > Date: Tue, 22 Feb 2011 21:56:23 -0500 > > From: oz at lindenlab.com > > To: opensource-dev at lists.secondlife.com > > Subject: Re: [opensource-dev] Is 'STANDALONE' confusing? > > > > On 2011-02-21 9:38, Boroondas Gupte wrote: > > > On 02/21/2011 03:28 PM, Oz Linden (Scott Lawrence) wrote: > > >> > If we are going to change it, the replacement term should, in > addition > > >> > to being more accurately descriptive of what it does, be an > affirmative > > >> > term - don't suggest any 'NO_*" replacements. > > > Would it be acceptable to invert the setting's semantic in order to > > > avoid a negation? I.e., STANDALONE=OFF would become NEW_SETTING=ON and > > > vice versa. That'd allow for easy-to-understand names like > > > USE_PREBUILD_LIBS or DOWNLOAD_NEEDED_DEPENDENCIES. > > > > > > Off course, the default value should be inverted together with the > > > setting's semantic, such that the default behavior does not change. > > > > Yes, I think that's best (assuming that we're going to change anything). > > > > A couple of comments on the interesting discussion.... > > > > I'm not sure that any variation on 'USE_PREBUILD' quite captures the > > correct semantics, because in the new autobuild framework one way to > > work is going to be to download the project for a library you want to > > compile locally (perhaps to try a new version, or to make some patch) > > and then modify your viewer builds to use the output of that > > compilation. When you do that, you'll still be using exactly the same > > sort of prebuilt package that you would, in the default case, download > > from LL. > > > > The real distinction, I think, is whether or not you are using > > _installed_ libraries. Normally, the viewer build has only minimal > > reliance on the libs that are installed on the system itself - it puts > > the packaged libraries (which are now by default all loaded in a > > 'build-*/packages directory rather than being mixed in with the > sources). > > > > That might suggest something like USE_PACKAGED_LIBS with a default > value > > of NO/FALSE. > > > > _______________________________________________ > > Policies and (un)subscribe information available here: > > http://wiki.secondlife.com/wiki/OpenSource-Dev > > Please read the policies before posting to keep unmoderated posting > privileges > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges -- Tateru Nino http://dwellonit.taterunino.net/ -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110223/e052ed8c/attachment.htm From leliel.mirihi at gmail.com Wed Feb 23 01:57:53 2011 From: leliel.mirihi at gmail.com (leliel) Date: Wed, 23 Feb 2011 01:57:53 -0800 Subject: [opensource-dev] Is 'STANDALONE' confusing? In-Reply-To: <4D647757.7060008@lindenlab.com> References: <4D6276A0.4040708@lindenlab.com> <4D6278C9.7080609@boroon.dasgupta.ch> <4D647757.7060008@lindenlab.com> Message-ID: On Tue, Feb 22, 2011 at 6:56 PM, Oz Linden (Scott Lawrence) wrote: > The real distinction, I think, is whether or not you are using > _installed_ libraries. ?Normally, the viewer build has only minimal > reliance on the libs that are installed on the system itself In other words the viewer is normally built as a standalone application, i.e. the STANDALONE option does the exact opposite of what you'd expect given the definition of the word. So why not just invert the meaning of STANDALONE? From oz at lindenlab.com Wed Feb 23 03:29:57 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Wed, 23 Feb 2011 06:29:57 -0500 Subject: [opensource-dev] Is 'STANDALONE' confusing? In-Reply-To: References: <4D6276A0.4040708@lindenlab.com> <4D6278C9.7080609@boroon.dasgupta.ch> <4D647757.7060008@lindenlab.com> Message-ID: <4D64EFB5.4040102@lindenlab.com> On 2011-02-23 4:57, leliel wrote: > On Tue, Feb 22, 2011 at 6:56 PM, Oz Linden (Scott Lawrence) > wrote: >> The real distinction, I think, is whether or not you are using >> _installed_ libraries. Normally, the viewer build has only minimal >> reliance on the libs that are installed on the system itself > In other words the viewer is normally built as a standalone > application, i.e. the STANDALONE option does the exact opposite of > what you'd expect given the definition of the word. So why not just > invert the meaning of STANDALONE? No, I certainly don't want to do that (however much sense it might have made to do it that way in the first place), because the transition would be too confusing. Besides, we're talking about what happens when you're building, not about what happens when the viewer is run by a user. From oz at lindenlab.com Wed Feb 23 03:40:50 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Wed, 23 Feb 2011 06:40:50 -0500 Subject: [opensource-dev] Wild idea on building an install platform In-Reply-To: References: Message-ID: <4D64F242.1090003@lindenlab.com> On 2011-02-19 15:47, Robert Martin wrote: > As a sidebar to the whole autobuild system it would be cool if > somebody could download a program and then verify that they have a > Valid install platform (bonus points if it could also download the > missing parts (i suppose that you could only pop the webpage for MS > VStudio) By 'install platform' do you mean "a platform on which I should be able to build and install a viewer" ? I think that the way to approach the difficulties of setting up a proper development environment is: * Make the environment as simple as possible... unfortunately, ours already isn't simple. Suggestions for how to remove the dependency on one or more tools are welcome so long as the result works at least as well at present. * Document it very cleanly - can always use improvement, but ours is not bad (our new CEO was able to follow the setup instructions and build a viewer on Windows) * Build in checks as early as practical in the build process that produce an error message that tells you what part of the environment you're missing. That last could, in theory, be built as a separate tool as you suggest, but then we've got one more thing that can get out of sync. Instead, I think we should try to find and correct all the places where something obscure happens and add hints. In short, next time some new dev asks for help here on the list or in IRC because they could not understand a failure, let's try to: 1. Check to make sure the setup documentation included the thing they missed 2. Modify the build process so that when that step fails, a message comes out that says "check to make sure that you have xxx installed" -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110223/caca985e/attachment-0001.htm From oz at lindenlab.com Wed Feb 23 03:54:05 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Wed, 23 Feb 2011 06:54:05 -0500 Subject: [opensource-dev] Daily Scrum Summary - Friday, February 18 In-Reply-To: References: Message-ID: <4D64F55D.30605@lindenlab.com> On 2011-02-21 7:48, Opensource Obscure wrote: > On Mon, Feb 21, 2011 at 09:36, Anya Kanevsky > wrote: > >> Bao Linden >> PAST >> worked on VBO improvements and testing, > Is it possible to have some more details or links to JIRA about this? > > >> Vadim ProductEngine >> IMPEDIMENTS >> Who's gonna create out-of-the-box viewer layouts for STORM-2? > Would user contributions about this be possible / appropriate? Yes. There are some discussions going on within the Lab about how to proceed with viewer customizing, and when that has sorted itself out I'll get some information out on the results and how contributors can begin this process. From sllists at boroon.dasgupta.ch Wed Feb 23 07:10:11 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Wed, 23 Feb 2011 16:10:11 +0100 Subject: [opensource-dev] Is 'STANDALONE' confusing? In-Reply-To: References: <4D6276A0.4040708@lindenlab.com> <4D6278C9.7080609@boroon.dasgupta.ch> <4D647757.7060008@lindenlab.com> Message-ID: <4D652353.60207@boroon.dasgupta.ch> On 02/23/2011 10:57 AM, leliel wrote: > On Tue, Feb 22, 2011 at 6:56 PM, Oz Linden (Scott Lawrence) > wrote: >> The real distinction, I think, is whether or not you are using >> _installed_ libraries. Normally, the viewer build has only minimal >> reliance on the libs that are installed on the system itself > In other words the viewer is normally built as a standalone > application, i.e. the STANDALONE option does the exact opposite of > what you'd expect given the definition of the word. So why not just > invert the meaning of STANDALONE? I guess (and that's really just a guess) today's "STANDALONE" refers to not relying on network connectivity at /build/ time. Whether the shipped application package is self-contained (i.e. has minimal reliance on libraries installed on the end user's system) depends mainly on what libraries get packaged with it (or linked statically, so that they're included anyway). Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110223/fce4a003/attachment.htm From lee.ponzu at gmail.com Wed Feb 23 07:56:25 2011 From: lee.ponzu at gmail.com (Ponzu) Date: Wed, 23 Feb 2011 10:56:25 -0500 Subject: [opensource-dev] Media Strategy? In-Reply-To: References: Message-ID: On Tue, Feb 22, 2011 at 8:44 AM, Qie Niangao wrote: > (I'm not entirely comfortable raising this topic here, but it very > much does affect Snowstorm viability, so, with apologies in > advance...) > > Certain alt-matching systems have attained enough grid saturation that > there is widespread hesitancy to enable Media at all. Can LL measure this? What percentage of viewers have Media disabled? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110223/3b3f667f/attachment.htm From akanevsky at productengine.com Wed Feb 23 10:10:28 2011 From: akanevsky at productengine.com (Anya Kanevsky) Date: Wed, 23 Feb 2011 10:10:28 -0800 Subject: [opensource-dev] Daily Scrum Summary - Tuesday, February 22 Message-ID: Sprint 11, ends 02.28.11 Tuesday, February 22 General Notes ------------------------------ - 2.6 is delayed as we rework some processes - MMOTD: Oz Team Status ------------------------------ Merov Linden ------------------------------ *PAST* - STORM-987 : llimage_libtest: Output image data and compression/decompression perf, document this tool on the wiki somewhere - Autobuild Hackathon : - Fixed autobuild viewer Mac build - kdu: Builds on Mac and Windows. Still fails on Linux which is really odd since that's the one platform where nothing changed with autobuild... - Worked on some mapserver fixes (internal) *FUTURE* - OPEN-4: fmod - STORM-987 : llimage_libtest: Add image stats output *IMPEDIMENTS* - none Oz Linden ------------------------------ *PAST* - Visual Studio 2010 Hackathon *FUTURE* - Merge Monkey - 4 issues in queue - Figure out where we are after Hackathon *IMPEDIMENTS* - none Q Linden ------------------------------ *PAST* - long weekend - planning - documentation - hackathon *FUTURE* - planning - documentation - hackathon wrapup *IMPEDIMENTS* - none Bao Linden ------------------------------ *PAST* - finished memory leaking fix and refinement for VBO. *FUTURE* - wrap up STORM-336 (memory leak) - work on the merge issues for the memory management project, - create a QAR for it if possible. *IMPEDIMENTS* - none Wolf *PAST* - Starting investigation for Storm-323 (redundant popups) *FUTURE* - Continue work on Storm-323; No impediments *IMPEDIMENTS* - none Grumpity ProductEngine ------------------------------ *PAST* - Sprint 11 has been extended. - Due to hackathon and holiday on monday, we aren?t ready to wrap up yet. - Sprint Retrospective is friday 2/25. Spring Planning is monday 2/28 *FUTURE* - STORM cleanup in jira - meet with Geo to figure out better scrum process with our constraints - update Team status summaries - prep for sprint wrapup and planning *IMPEDIMENTS* - none Paul ProductEngine ------------------------------ *PAST* - STORY STORM-889 (Put Link/Unlink in Edit Panel) - Fixed and sent for review. - BUG STORM-952 (No upload from filepath including national characters like ?, ? and ?) - WIP. Trying to reproduce. Can't give estimate for now as i can't reproduce it. *FUTURE* - BUG STORM-952 (No upload from filepath including national characters like ?, ? and ?) *IMPEDIMENTS* - none Seth ProductEngine ------------------------------ *PAST* - STORY (STORM-28) As a User, I want the ability to send my calling card to others. - Fixed. Posted patch for review. *FUTURE* - BUG (STORM-594) [crashhunters] crash in LLView::handleVisibilityChange(int) [second life unknown] - Estimated: 6-8 hours. *IMPEDIMENTS* - none Vadim ProductEngine ------------------------------ *PAST* - Story STORM-326 (Create and Save your Windlight Skies/Water as a persistent, new Default setting): - WIP. ETA: 2d. *FUTURE* - Continue with STORM-326. *IMPEDIMENTS* - none Andrey ProductEngine ------------------------------ *PAST* - completed design of Region/Estate TP - continued with regression testing of the latest v-d build - Viewer Messages - Build Tools - Group Profile - Groups SP - Recent People SP - Friends SP - Nearby People SP - Inspectors *FUTURE* - continue with regression testing *IMPEDIMENTS* - none Jonathan Yap ------------------------------ *PAST* - VWR-24460 (Group invite fails to let you join groups when groups maxed even when you leave group) - Non-trivial issue here. Siana was looking into it too. - VWR-24877 (Add ability to display beacons for Media on a Prim objects) - Finished. Will see if this wants to be brought in at an appropriate meeting. *FUTURE* *IMPEDIMENTS* - STORM - 956 - File message_template.msg needs to be pushed into viewer code tree from server code tree. Wolfpup Lowenhar ------------------------------ *PAST* - RL work. - STORM-941 : emailed Oz and Leyla concerning possible areas that could be causing the problem. - STORM - 236 : replied to Grumpity's email and also fowarded conversations with richard to Vadim. pused local canges to online repository so that Vadim would have access to them. - Hackathon : did some local testing and have a bug concerning autobuild system in an Opensource build environment. spent weekend tracking it down as was orginlay though to be cmake related but it actualy is not. *FUTURE* - RL work. *IMPEDIMENTS* - STORM-236 : time needed for responces from people on west coast. - Autobuild fails to work for VS2010 on my local system. - Not enough time to actually work on code. Cummere Mayo ------------------------------ *PAST* - jira cleanup - testing v-d build - catching up on rl and sl job related stuff *FUTURE* - jira cleanup - ccnaf stuff *IMPEDIMENTS* - none -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110223/14589491/attachment-0001.htm From hitomi.tiponi at yahoo.co.uk Wed Feb 23 17:34:49 2011 From: hitomi.tiponi at yahoo.co.uk (Hitomi Tiponi) Date: Thu, 24 Feb 2011 01:34:49 +0000 (GMT) Subject: [opensource-dev] Changes on Snowstorm builds no longer showing up In-Reply-To: References: Message-ID: <785871.27970.qm@web23901.mail.ird.yahoo.com> The last couple of Snowstorm test builds (e.g. http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/snowstorm_viewer-development/rev/221902/index.html) no longer have the 'Changes since last good build' being shown - instead it is showing 'Unknown'. Is this a bug or will it be like this from now on? Hitomi -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110224/eda01ffc/attachment.htm From cg at lindenlab.com Wed Feb 23 17:42:18 2011 From: cg at lindenlab.com (CG Linden) Date: Wed, 23 Feb 2011 17:42:18 -0800 Subject: [opensource-dev] Changes on Snowstorm builds no longer showing up In-Reply-To: <785871.27970.qm@web23901.mail.ird.yahoo.com> References: <785871.27970.qm@web23901.mail.ird.yahoo.com> Message-ID: You can download the changes.html file from the build results. I know why the problem exists, and I'll be working on redoing the build results pages. Meanwhile, please use the changes.html file to look up the changes included in the current build. On Wed, Feb 23, 2011 at 5:34 PM, Hitomi Tiponi wrote: > The last couple of Snowstorm test builds (e.g. > http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/snowstorm_viewer-development/rev/221902/index.html) > no longer have the 'Changes since last good build' being shown - instead it > is showing 'Unknown'. Is this a bug or will it be like this from now on? > > Hitomi > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110223/5897a460/attachment.htm From akanevsky at productengine.com Thu Feb 24 01:10:28 2011 From: akanevsky at productengine.com (Anya Kanevsky) Date: Thu, 24 Feb 2011 01:10:28 -0800 Subject: [opensource-dev] Daily Scrum Summary - Wedensday decembre Message-ID: Sprint 11, ends 02.28.11 Wednesday, February 23 General Notes ------------------------------ - 2.6 is delayed as we rework some processes - MMOTD: Oz Team Status ------------------------------ Merov Linden ------------------------------ *PAST* - Attended Viewer triage - Attended Viewer Design and Coding IW meeting: thanks to folks who helped me build STORM-987 on various platforms. Nice! - OPEN-4 : Moved fmod to autobuild. Now need to fix the fmod issue for external non standalone users. *FUTURE* - OPEN-4: fixing fmod for non-standalone open source users (i.e. use FmodFind.cmake in that case) - STORM-987 : llimage_libtest: Add image stats output *IMPEDIMENTS* - none Oz Linden ------------------------------ Q Linden ------------------------------ *PAST* - planning - documentation - hackathon wrapup - process work - user group meeting: Got through http://wiki.secondlife.com/wiki/Viewer_2_Evolution_User_Group *FUTURE* - process work Bao Linden ------------------------------ *PAST* - wrapped up STORM-1011, also improved the vbo performance by separating vertex buffer and index buffer when map/unmap VBO. - solved merge issues for the memory project. *FUTURE* - test the memory project, put it into teamcity and file a QAR. *IMPEDIMENTS* - none Wolf Linden ------------------------------ *PAST* - more Storm-323 investigation (redundant popups) *FUTURE* - Continue work on Storm-323 - vwr-24118 *IMPEDIMENTS* - none Grumpity ProductEngine ------------------------------ *PAST* - next sprint will focus on keyboard shortcuts, design & prep for build tools - no sprint review meeting this time. - some future strategy - VWR triage - OOO this afternoon and friday afternoon *FUTURE* - STORM cleanup in jira - meet with Geo to figure out better scrum process with our constraints - update Team status summaries - prep for sprint wrapup and planning *IMPEDIMENTS* - none Paul ProductEngine ------------------------------ *PAST* - STORM-525 (Runtime Error message from the Microsoft Visual C++ Runtime Library eventually leads to Crash) - Tried to reproduce, but had no luck. Resolved as a cannot reproduce. - STORM-738 ([crashhunters] Crash in LLWindowWin32::interruptLanguageTextInput()) - Cannot reproduce too. Resolved as cannot reproduce. *FUTURE* - STORM-738 (No upload from filepath including national characters like ?, ? and ?) *IMPEDIMENTS* - none Seth ProductEngine ------------------------------ *PAST* - BUG (STORM-594) [crashhunters] crash in LLView::handleVisibilityChange(int) [second life unknown] - Could not reproduce. Moved to unassigned. - BUG (STORM-983) no-transfer textures not searchable via texture picker - Investigated. Looks like it needs just a product owner decision whether to allow No Copy and No Transfer textures to be shown in texture picker. *FUTURE* - BUG (STORM-1015) Unable to select right Login Landmark when it's name is not unique - Estimated: 6-8 hours. *IMPEDIMENTS* - BUG (STORM-526) Log out failure during Login causes loss of pending offers, including inventory - Cannot reproduce without being able to use the specific account of a resident who has this issue on log in. - BUG (STORM-983) no-transfer textures not searchable via texture picker - Some residents are concerned about their texture being transfered without permission with a prim it is applied to, others complain about the texture they own being useless without the ability to apply it. - Waiting for the product owner decision whether to allow No Copy and/or No Transfer textures to be shown in texture picker. Vadim ProductEngine ------------------------------ *PAST* - Story STORM-326 (Create and Save your Windlight Skies/Water as a persistent, new Default setting): - WIP. ETA: 1d. *FUTURE* - Continue with STORM-326. *IMPEDIMENTS* - none Andrey ProductEngine ------------------------------ *PAST* - completed design of Region/Estate TP - continued with regression testing of the latest v-d build - Viewer Messages - Build Tools - Group Profile - Groups SP - Recent People SP - Friends SP - Nearby People SP - Inspectors *FUTURE* - continue with regression testing *IMPEDIMENTS* - none Jonathan Yap ------------------------------ *PAST* - VWR-24460 (Group invite fails to let you join groups when groups maxed even when you leave group) - Non-trivial issue here. Siana was looking into it too. - VWR-24877 (Add ability to display beacons for Media on a Prim objects) - Finished. Will see if this wants to be brought in at an appropriate meeting. *FUTURE* *IMPEDIMENTS* - STORM - 956 - File message_template.msg needs to be pushed into viewer code tree from server code tree. Cummere Mayo ------------------------------ *PAST* - jira stuff - twiste4d hunt stuff - followed up with mairead to get the following - https://jira.secondlife.com/browse/VWR-24972 No IM/Notices at Log In - https://jira.secondlife.com/browse/VWR-24973 Viewer Crashes at Events - https://jira.secondlife.com/browse/VWR-24975 Show Map Button Not Responding On Landmark Sidebar *FUTURE* - twisted prep - hunting for keybaord, and content creation jiras *IMPEDIMENTS* - none Team Status -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110224/b6114555/attachment-0001.htm From nickyperian at yahoo.com Thu Feb 24 09:52:01 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Thu, 24 Feb 2011 09:52:01 -0800 (PST) Subject: [opensource-dev] draft wiki Visual Studio 10 Information Message-ID: <582324.81463.qm@web43512.mail.sp1.yahoo.com> https://wiki.secondlife.com/wiki/User:Nicky_Perian/Visual_Studio_10_Autobuild -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110224/af4b63ef/attachment.htm From nickyperian at yahoo.com Thu Feb 24 13:47:28 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Thu, 24 Feb 2011 13:47:28 -0800 (PST) Subject: [opensource-dev] draft wiki Visual Studio 10 Information In-Reply-To: <582324.81463.qm@web43512.mail.sp1.yahoo.com> References: <582324.81463.qm@web43512.mail.sp1.yahoo.com> Message-ID: <343992.42527.qm@web43511.mail.sp1.yahoo.com> Edited per input from Twisted Laws. Thank You, Twisted. ________________________________ From: Nicky Perian To: opensource-dev at lists.secondlife.com Sent: Thu, February 24, 2011 11:52:01 AM Subject: [opensource-dev] draft wiki Visual Studio 10 Information https://wiki.secondlife.com/wiki/User:Nicky_Perian/Visual_Studio_10_Autobuild -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110224/5df2e03b/attachment.htm From yoz at lindenlab.com Thu Feb 24 14:29:37 2011 From: yoz at lindenlab.com (Yoz Grahame) Date: Thu, 24 Feb 2011 14:29:37 -0800 Subject: [opensource-dev] draft wiki Visual Studio 10 Information In-Reply-To: <343992.42527.qm@web43511.mail.sp1.yahoo.com> References: <582324.81463.qm@web43512.mail.sp1.yahoo.com> <343992.42527.qm@web43511.mail.sp1.yahoo.com> Message-ID: That looks fantastic. Thanks so much for your work on this! (I can't comment on the content of the page as I've not been involved in any of the autobuild work, I'm just very appreciative) On 24 February 2011 13:47, Nicky Perian wrote: > Edited per input from Twisted Laws. > > Thank You, Twisted. > > ------------------------------ > *From:* Nicky Perian > *To:* opensource-dev at lists.secondlife.com > *Sent:* Thu, February 24, 2011 11:52:01 AM > *Subject:* [opensource-dev] draft wiki Visual Studio 10 Information > > > https://wiki.secondlife.com/wiki/User:Nicky_Perian/Visual_Studio_10_Autobuild > > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110224/ca9ec92a/attachment.htm From merov at lindenlab.com Thu Feb 24 22:03:46 2011 From: merov at lindenlab.com (Philippe (Merov) Bossut) Date: Thu, 24 Feb 2011 22:03:46 -0800 Subject: [opensource-dev] STORM-1023 (was OPEN-4) : fmod Message-ID: Hi, I worked on this and submitted what I think should solve the problem on a dev repo forked from oz_linden/viewer-autobuild: https://bitbucket.org/merov_linden/viewer-autobuild-open-4/changeset/e439abf2be8e If autobuild interested people building from home STANDALONE and NOT STANDALONE could review that proposal and test the changeset, that would help tremendously. Cheers, - Merov -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110224/f998a5fb/attachment.htm From akanevsky at productengine.com Thu Feb 24 23:48:40 2011 From: akanevsky at productengine.com (Anya Kanevsky) Date: Thu, 24 Feb 2011 23:48:40 -0800 Subject: [opensource-dev] Daily Scrum Summary - Thursday, February 24 Message-ID: Sprint 11, ends 02.28.11 Thursday, February 24 General Notes ------------------------------ - MMOTD: Oz -> Merov Team Status ------------------------------ Merov Linden ------------------------------ *PAST* - OPEN-4, OPEN-6 and OPEN-24 : fmod : tested new package on VS2010. Works. Took over those 2 other related tasks and hacked together a solution. Branched from oz-linden/viewer-autobuild. Need to test and tweak the solution. *FUTURE* - OPEN-4, OPEN-6 and OPEN-24: fmod : finish the cmake fixes and provide an RB for review - STORM-987 : llimage_libtest: Add image stats output *IMPEDIMENTS* - none Oz Linden ------------------------------ *PAST* - Debugging autobuild integration problems - Handed off Merge Monkey to Merov because I'm swamped *FUTURE* - Debugging autobuild integration problems *IMPEDIMENTS* - Way too many internal meetings - unavoidable Q Linden ------------------------------ *PAST* - process work - lots of writing - meetings *FUTURE* - process work - meetings - more writing *IMPEDIMENTS* - none Bao Linden ------------------------------ *PAST* - done all the merge from viewer-development and STORM-864 to the memory project, and fully test it; - extend the memory project to cover the memory allocations in the texture pipeline and VBO - create tasks for the memory project in teamcity *FUTURE* - write test plans and create a QAR for the memory project - work on the merge issues from viewer-development to mesh-development - possible some crash hunting *IMPEDIMENTS* - none Wolf Linden ------------------------------ *PAST* - Busy with other projects *FUTURE* - Storm-1019 - VWR-23944 - VWR-23946 - VWR-24876 - VWR-24118 - Storm-323 *IMPEDIMENTS* - none Paul ProductEngine ------------------------------ *PAST* - BUG STORM- 665 (User is not able to view full name of Group's founder in the Group Profile) - Fixed and sent for review - BUG STORM- 879 (Last name resident shown in first entry in conference IM log for users with view display names off when conference initiated by user with last name resident) - Resolved as cannot reproduce - BUG STORM- 952 (No upload from filepath including national characters like ?, ? and ?) - See impediments *FUTURE* - Other tickets by priority *IMPEDIMENTS* - STORM- 952 - There are two problems with this issue: Crash Not able to upload file which path contains ?, ? and ? I tried to reproduce it and my results (see more details about machines on which i tried to reproduce this in my comment in jira) are: Windows 7 (32 bit) -- No crash and it is possible to upload the file from filepath including national characters like ?, ? and ?. But these characters are replaced with ?? WindowsXP (32 bit) -- No crash and it is NOT possible to upload the file from filepath including national characters like ?, ? and ? In second comment for this ticket Q says that: "Well, we shouldn't crash, but it may be (I haven't researched this yet) that our server-side systems don't support unicode in these names. So it might be that the solution is that we don't let you do that". So my question is: whether it should be possible to upload such files or not? Seth ProductEngine ------------------------------ *PAST* - BUG (STORM-731) Crash in LLRemoteParcelInfoProcessor::addObserver - Closed as duplicate. - BUG (STORM-1015) Unable to select right Login Landmark when it's name is not unique - Working on the problem with selecting an entry in start location combobox when it contains several identical strings in a list. *FUTURE* - BUG (STORM-1015) Unable to select right Login Landmark when it's name is not unique - Estimated: 4-6 hours. *IMPEDIMENTS* - BUG (STORM-526) Log out failure during Login causes loss of pending offers, including inventory - Cannot reproduce without being able to use the specific account of a resident who has this issue on log in. - BUG (STORM-983) no-transfer textures not searchable via texture picker - Some residents are concerned about their texture being transfered without permission with a prim it is applied to, others complain about the texture they own being useless without the ability to apply it. - Waiting for the product owner decision whether to allow No Copy and/or No Transfer textures to be shown in texture picker. Vadim ProductEngine ------------------------------ *PAST* - Story STORM-326 (Create and Save your Windlight Skies/Water as a persistent, new Default setting): - Finally found out why a saved sky preset wasn't applied at startup (had been investigating this problem for days due to spaghettiness of the code). I can submit my fix, but not sure about it: see IMPEDIMENTS below. *FUTURE* - Prettify my fix of STORM-326 for publishing. - Help WolfPup with STORM-236 (Allow the "Speak" button to be removed, like other buttons). *IMPEDIMENTS* - STORM-326. - It turns out that the only way to properly apply a sky preset is to stop the day cycle (so-called animator). So if you want to have a persistent sky preset, say good-bye to sunsets. I doubt this is what people expect. A more acceptable solution would be adding a "use estate time for sun/moon positioning" checkbox to each preset. Thus you would be able to choose whether you want fixed sun or not. How should we handle this issue? - - Note that I'm not completely sure that adding the checkbox is possible (i.e. Windlight supports that), nor that it won't take too much time. *FUTURE* - Continue with STORM-326. *IMPEDIMENTS* - none Andrey ProductEngine ------------------------------ *PAST* - smoke & integrity tests against Viewer VS2010 build, see IQA-84 for more details - continued regression testing of the latest v-d build - URLs - Voice chat - SLApps - Instant Messaging - Preferences - Move and View - Login Landmarks - Movement controls - Preferences - Sound / Device Settings *FUTURE* - continue with regression testing *IMPEDIMENTS* - none Jonathan Yap ------------------------------ *PAST* - STORM-1019 (Add ability to display beacons for Media on a Prim objects) - Done except for design feedback from Wolf. - STORM-1020 (It is sometimes necessary to press ALT+CTRL+D twice to get the Debug menu on the login screen) - Done. *FUTURE* - STORM - 1019 - Write test plan. *IMPEDIMENTS* - STORM - 956 - File message_template.msg needs to be pushed into viewer code tree from server code tree. - Should I ask for help from Andrew on this as the Snowstorm people have been swamped for a week? Wolfpup Lowenhar ------------------------------ *PAST* - RL work. - autobuild : Finaly got it working on my local system with Nicky's help in IRC. *FUTURE* - autobuild : testing viewer when build is finished. - RL work. *IMPEDIMENTS* - STORM-236 : waiting for responces from people on west coast. - STORM-941 : Waiting on reply from Oz and Leyla - Not enough time to actually work on code. Cummere Mayo ------------------------------ *PAST* - jira stuff - twiste4d hunt stuff - started first run of keyboard and content creation jiras - created VWR-24986 out of sheer frustration (which is not on the list i passed around yet) *FUTURE* - twisted prep - more hunting for keybaord, and content creation jiras *IMPEDIMENTS* - chaotic rl, twisted hunt, and roller derby eating too much time - cant do some of the things in jira that would make my life easier -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110224/2a51037b/attachment-0001.htm From nickyperian at yahoo.com Fri Feb 25 07:26:28 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Fri, 25 Feb 2011 07:26:28 -0800 (PST) Subject: [opensource-dev] STORM-1023 (was OPEN-4) : fmod In-Reply-To: References: Message-ID: <335654.30922.qm@web43513.mail.sp1.yahoo.com> tried with -DFMOD:BOOL=ON it did not override -DFMOD=FALSE in autobuild.xml ________________________________ From: Philippe (Merov) Bossut To: opensource-dev at lists.secondlife.com Sent: Fri, February 25, 2011 12:03:46 AM Subject: [opensource-dev] STORM-1023 (was OPEN-4) : fmod Hi, I worked on this and submitted what I think should solve the problem on a dev repo forked from oz_linden/viewer-autobuild: https://bitbucket.org/merov_linden/viewer-autobuild-open-4/changeset/e439abf2be8e If autobuild interested people building from home STANDALONE and NOT STANDALONE could review that proposal and test the changeset, that would help tremendously. Cheers, - Merov -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110225/cc54b2bf/attachment.htm From merov at lindenlab.com Fri Feb 25 07:36:33 2011 From: merov at lindenlab.com (Philippe (Merov) Bossut) Date: Fri, 25 Feb 2011 07:36:33 -0800 Subject: [opensource-dev] STORM-1023 (was OPEN-4) : fmod In-Reply-To: <335654.30922.qm@web43513.mail.sp1.yahoo.com> References: <335654.30922.qm@web43513.mail.sp1.yahoo.com> Message-ID: Hi Nicky, Thanks for testing this. On Fri, Feb 25, 2011 at 7:26 AM, Nicky Perian wrote: > tried with -DFMOD:BOOL=ON it did not override -DFMOD=FALSE in autobuild.xml > Right, but the problem Wolfpup was reporting was that even changing FMOD to TRUE in autobuild.xml didn't work because FindFMOD was invoked only in STANDALONE. My question should have been: If you change FMOD to TRUE in the configuration of autobuild.xml you use, does it work? Cheers, - Merov -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110225/1925bb9e/attachment.htm From nickyperian at yahoo.com Fri Feb 25 08:03:46 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Fri, 25 Feb 2011 08:03:46 -0800 (PST) Subject: [opensource-dev] STORM-1023 (was OPEN-4) : fmod In-Reply-To: References: <335654.30922.qm@web43513.mail.sp1.yahoo.com> Message-ID: <14890.24849.qm@web43515.mail.sp1.yahoo.com> I have -DFMOD:BOOL=ON on configure cl and DFMOD=TRUE in autobuild.xml Attempt is made to build with fmod but, the headers and libraries still need to be manually copied. Was that the intent? Nicky ________________________________ From: Philippe (Merov) Bossut To: Nicky Perian Cc: opensource-dev at lists.secondlife.com Sent: Fri, February 25, 2011 9:36:33 AM Subject: Re: [opensource-dev] STORM-1023 (was OPEN-4) : fmod Hi Nicky, Thanks for testing this. On Fri, Feb 25, 2011 at 7:26 AM, Nicky Perian wrote: tried with -DFMOD:BOOL=ON it did not override -DFMOD=FALSE in autobuild.xml Right, but the problem Wolfpup was reporting was that even changing FMOD to TRUE in autobuild.xml didn't work because FindFMOD was invoked only in STANDALONE. My question should have been: If you change FMOD to TRUE in the configuration of autobuild.xml you use, does it work? Cheers, - Merov -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110225/0da4763c/attachment.htm From merov at lindenlab.com Fri Feb 25 10:33:27 2011 From: merov at lindenlab.com (Philippe (Merov) Bossut) Date: Fri, 25 Feb 2011 10:33:27 -0800 Subject: [opensource-dev] STORM-1023 (was OPEN-4) : fmod In-Reply-To: <14890.24849.qm@web43515.mail.sp1.yahoo.com> References: <335654.30922.qm@web43513.mail.sp1.yahoo.com> <14890.24849.qm@web43515.mail.sp1.yahoo.com> Message-ID: Hi Nicky, On Fri, Feb 25, 2011 at 8:03 AM, Nicky Perian wrote: > I have -DFMOD:BOOL=ON on configure cl > and > DFMOD=TRUE in autobuild.xml > Attempt is made to build with fmod but, the headers and libraries still > need to be manually copied. > Was that the intent? > Nope. Looks like either FindFMOD couldn't locate the files or it wasn't invoked at all. Could you tell me which autobuild configure arguments you use? Again, thanks for the test. Looks like I've more coding to do. Cheers, - Merov -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110225/3c249d41/attachment.htm From nickyperian at yahoo.com Fri Feb 25 13:01:19 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Fri, 25 Feb 2011 13:01:19 -0800 (PST) Subject: [opensource-dev] STORM-1023 (was OPEN-4) : fmod In-Reply-To: References: <335654.30922.qm@web43513.mail.sp1.yahoo.com> <14890.24849.qm@web43515.mail.sp1.yahoo.com> Message-ID: <994964.41013.qm@web43513.mail.sp1.yahoo.com> I am using oz's viewer-autobuild2010 with my mod's for VS2010 and your changes at the tip. https://bitbucket.org/NickyP/viewer-autobuild2010-wip this plus your changes at tip. I would not be able to test otherwise. Nicky ________________________________ From: Philippe (Merov) Bossut To: Nicky Perian Cc: opensource-dev at lists.secondlife.com Sent: Fri, February 25, 2011 12:33:27 PM Subject: Re: [opensource-dev] STORM-1023 (was OPEN-4) : fmod Hi Nicky, On Fri, Feb 25, 2011 at 8:03 AM, Nicky Perian wrote: I have -DFMOD:BOOL=ON on configure cl >and >DFMOD=TRUE in autobuild.xml >Attempt is made to build with fmod but, the headers and libraries still need to >be manually copied. >Was that the intent? Nope. Looks like either FindFMOD couldn't locate the files or it wasn't invoked at all. Could you tell me which autobuild configure arguments you use? Again, thanks for the test. Looks like I've more coding to do. Cheers, - Merov -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110225/bc9c5644/attachment.htm From slitovchuk at productengine.com Fri Feb 25 13:19:10 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Fri, 25 Feb 2011 21:19:10 -0000 Subject: [opensource-dev] Review Request: (STORM-1015) Unable to select right Login Landmark when it's name is not unique Message-ID: <20110225211910.3033.61222@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/165/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Fixed the ability to select an item from combo list if its name is not unique. Updating combo box label upon list item selection does not search the item by label but takes the label of currently selected item instead. This addresses bug STORM-1015. http://jira.secondlife.com/browse/STORM-1015 Diffs ----- indra/llui/llcombobox.h 1bc100746447 indra/llui/llcombobox.cpp 1bc100746447 Diff: http://codereview.secondlife.com/r/165/diff Testing ------- Thanks, Seth -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110225/3c1913fc/attachment.htm From merov at lindenlab.com Fri Feb 25 16:38:47 2011 From: merov at lindenlab.com (Merov Linden) Date: Sat, 26 Feb 2011 00:38:47 -0000 Subject: [opensource-dev] Review Request: (STORM-1015) Unable to select right Login Landmark when it's name is not unique In-Reply-To: <20110225211910.3033.61222@domU-12-31-38-00-90-68.compute-1.internal> References: <20110225211910.3033.61222@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110226003847.3809.89061@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/165/#review384 ----------------------------------------------------------- Ship it! Seems to make sense. - Merov On Feb. 25, 2011, 1:19 p.m., Seth ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/165/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2011, 1:19 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Fixed the ability to select an item from combo list if its name is not unique. > Updating combo box label upon list item selection does not search the item by label but takes the label of currently selected item instead. > > > This addresses bug STORM-1015. > http://jira.secondlife.com/browse/STORM-1015 > > > Diffs > ----- > > indra/llui/llcombobox.h 1bc100746447 > indra/llui/llcombobox.cpp 1bc100746447 > > Diff: http://codereview.secondlife.com/r/165/diff > > > Testing > ------- > > > Thanks, > > Seth > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110226/bc861025/attachment.htm From merov at lindenlab.com Fri Feb 25 19:56:34 2011 From: merov at lindenlab.com (Merov Linden) Date: Sat, 26 Feb 2011 03:56:34 -0000 Subject: [opensource-dev] Review Request: VWR-24889: When a bake texture upload fails, retry instead of giving up. In-Reply-To: <20110219170834.13391.8802@domU-12-31-38-00-90-68.compute-1.internal> References: <20110219170834.13391.8802@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110226035634.3809.84356@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/152/#review385 ----------------------------------------------------------- Apart from what Thickbrick already pointed out and the typo here under, I don't have anything against that patch. We should test live though and make sure that 5 times 5 sec is not too much for a retry loop (seems a bit long to me). indra/newview/lltexlayer.h typos in comment: "whether it is a final bake or intermediary low res" - Merov On Feb. 19, 2011, 9:08 a.m., Thickbrick Sleaford wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/152/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2011, 9:08 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > When a bake upload fails, the viewer doesn't retry it, and subsequently doesn't send a AgentSetAppearance message. This can happen without the user being aware, leaving the avatar looking good on their screen, but not updated to the same outfit on other people's screens. The avatar will remain in that state until the user does something that causes a rebake (manually rebake or change outfit.) The solution here is to retry the upload after a small delay. > > What this diff changes: when a full-res upload fails, retry to upload it after a 5s delay, up to 5 times (in case the cap is available, last attempt is via the old asset store.) Also, some clearer log messages. This implements an old *FIX: comment: > // *FIX: retry upload after n seconds, asset server could be busy > > This isn't needed for low res uploads, because they don't block subsequent full-res uploads (mNeedsUpload isn't set to FALSE in LLTexLayerSetBuffer::doUpload in low-res uploads.) > > > This addresses bug VWR-24889. > http://jira.secondlife.com/browse/VWR-24889 > > > Diffs > ----- > > indra/newview/llassetuploadresponders.h 379da6bd50a5 > indra/newview/llassetuploadresponders.cpp 379da6bd50a5 > indra/newview/lltexlayer.h 379da6bd50a5 > indra/newview/lltexlayer.cpp 379da6bd50a5 > > Diff: http://codereview.secondlife.com/r/152/diff > > > Testing > ------- > > Attempted outfit changes using a problematic connection (not recently used outfits to avoid using cached bakes). Looked for "Baked full res texture upload for failed" log messages, observed the subsequent retries and successful upload for that region. Observed that eventually the fully-baked avatar is visible to other users. > > > Thanks, > > Thickbrick > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110226/1c3faae4/attachment.htm From merov at lindenlab.com Fri Feb 25 20:33:40 2011 From: merov at lindenlab.com (Philippe (Merov) Bossut) Date: Fri, 25 Feb 2011 20:33:40 -0800 Subject: [opensource-dev] Test build available Message-ID: Hi, I created a "PO Build" to test a bunch of JIRAs in the Review state that just need testing and PO Approval. The binaries are here: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/222147/index.html The JIRAs pulled in for testing are: * STORM-357 : Gestures button is in the pressed state after drag-n-drop but gestures list isn't visible * STORM-665 : User is not able to view full name of Group's founder in the Group Profile * STORM-842 : "Start at" list isn't populated with favorites if user name is typed in fashion "firstname.lastname" * STORM-889 : Put Link/Unlink in Edit Panel * STORM-949 : please remove actual usernames from XUI files <-- Trivial and not really testable * STORM-954 : SL-viewer 2.0 No nearby people when over approximately 1000 meters <-- Long time dangling issue! Please test... * STORM-971 : 'Stop Tracking' menu item is still enabled in Mini-map floater after you stopped tracking in Nearby mini-map * STORM-991 : Parser warning on Inventory floater construction * STORM-1004 : Unblocking/blocking name sometimes deletes identically named entry, but of different TYPE Cheers, - Merov -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110225/d00ba429/attachment-0001.htm From akanevsky at productengine.com Fri Feb 25 22:28:50 2011 From: akanevsky at productengine.com (Anya Kanevsky) Date: Fri, 25 Feb 2011 22:28:50 -0800 Subject: [opensource-dev] Daily Scrum Summary - Friday, February 25 Message-ID: Sprint 11, ends 02.28.11 Friday, February 25 General Notes ------------------------------ - MMOTD: Oz -> Merov Team Status ------------------------------ Merov Linden ------------------------------ *PAST* - STORM-1023 (was OPEN-4) : fmod : Completed and pushed on dev repo. Need test from FLOSS devs. Ready for review. - STORM-1022 (was OPEN-24) : add fmodex : one liner added to STORM-1023 changeset. Ready for review. - OPEN-6 : install local archives : tested and closed as it actually works fine. - CHOP-487 : submitted my Windows VS2010 hackathon results to team chopper *FUTURE* - MM: focus on moving stalled bugs through the swim lane before sprint 11 expires... - STORM-987 : llimage_libtest: Add image stats output *IMPEDIMENTS* - Can't make RB for viewer-autobuild patches although my repo is a fork of oz_linden/viewer-autobuild - No power this morning so off line. Should be back by 11am according to PG&E Oz Linden ------------------------------ *PAST* - Debugging autobuild integration problems - Built a couple more autobuild packages *FUTURE* - Build some more autobuild packages *IMPEDIMENTS* - none Q Linden ------------------------------ *PAST* - process work - lots of writing - meetings *FUTURE* - process work - planning - meetings - more writing *IMPEDIMENTS* - none Bao Linden ------------------------------ *PAST* - finished all merge issues from viewer-development to mesh development - fixed all teamcity issues for the memory project *FUTURE* - wrap up the memory project and release it to QA - finish the Q4 review *IMPEDIMENTS* - none Wolf Linden ------------------------------ *PAST* - Reviewed Storm 1019, VWR 23944, 23946, 24876, 24118 with XD *FUTURE* - Will post comments on all *IMPEDIMENTS* - Storm 323 need to discuss with Grumpity re: timing Seth ProductEngine ------------------------------ *PAST* - BUG (STORM-1015) Unable to select right Login Landmark when it's name is not unique - Working on selecting combo-list entries by index. Seems that the selection in combobox strongly depends on the items' labels. Looking for a fix or a workaround for this problem. *FUTURE* - BUG (STORM-1015) Unable to select right Login Landmark when it's name is not unique - Estimated: 4-6 hours. - BUG (STORM-361) Teleport offer message is shown with scroll bar in the IM history - Estimated: 4-6 hours. *IMPEDIMENTS* - none Vadim ProductEngine ------------------------------ *PAST* - Trying to help Wolfpup with story STORM-236 (Allow the "Speak" button to be removed, like other buttons): - Examined the ticket and the changes Wolfpup has made to find out what the problem currently is. - Started investigating bottom tray code. *FUTURE* - Continue with STORM-236. *IMPEDIMENTS* - Need a PO decision for STORM-326 (Persistent water/sky presets). Andrey ProductEngine ------------------------------ *PAST* - continued regression pass against v-d branch, see the spreadsheet for more details - Preferences - Setup - Preferences - Advanced - Preferences - Sound & Media - Busy mode - Preferences- Graphics (found a linux-specific, but it requires more investigation) - Preferences - Privacy - Preferences - Colors - Alerts&Notifications 70% - Display Names Appearance *FUTURE* - proceed with regression testing *IMPEDIMENTS* - none Jonathan Yap ------------------------------ *PAST* - STORM-1019 (Add ability to display beacons for Media on a Prim objects) - Wrote test plan. *FUTURE* *IMPEDIMENTS* - STORM - 956 - File message_template.msg needs to be pushed into viewer code tree from server code tree. - Long term solution expected late March. - STORM - 1019 Needs design feedback from Wolf. Cummere Mayo ------------------------------ *PAST* - twisted stuff - very little jira work *FUTURE* - twisted - jira work *IMPEDIMENTS* - twisted - not at home for a few days - -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110225/6c727a1e/attachment-0001.htm From wolfpup67 at earthlink.net Sat Feb 26 05:57:35 2011 From: wolfpup67 at earthlink.net (WolfPup Lowenhar) Date: Sat, 26 Feb 2011 08:57:35 -0500 Subject: [opensource-dev] STORM-1023 (was OPEN-4) : fmod In-Reply-To: <994964.41013.qm@web43513.mail.sp1.yahoo.com> References: <335654.30922.qm@web43513.mail.sp1.yahoo.com> <14890.24849.qm@web43515.mail.sp1.yahoo.com> <994964.41013.qm@web43513.mail.sp1.yahoo.com> Message-ID: <001201cbd5bd$1f360400$5da20c00$@net> See my comment here: https://jira.secondlife.com/browse/STORM-1023?focusedCommentId=244786 &page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comme nt-244786 This might be a better solution as then the files could also be renamed to properly match what cmake is looking for plus when autobuild sets up the build tree the needed files would be placed automatically with no problems during the configuration process as they would be resident in the OS developers install.cache directory with the rest of the needed packaged for developers that DL libs form LL. And as I do not realy know the how to set up one of these lib systems assistance would be greatly welcomed. From: opensource-dev-bounces at lists.secondlife.com [mailto:opensource-dev-bounces at lists.secondlife.com] On Behalf Of Nicky Perian Sent: Friday, February 25, 2011 4:01 PM To: Philippe (Merov) Bossut Cc: opensource-dev at lists.secondlife.com Subject: Re: [opensource-dev] STORM-1023 (was OPEN-4) : fmod I am using oz's viewer-autobuild2010 with my mod's for VS2010 and your changes at the tip. https://bitbucket.org/NickyP/viewer-autobuild2010-wip this plus your changes at tip. I would not be able to test otherwise. Nicky _____ From: Philippe (Merov) Bossut To: Nicky Perian Cc: opensource-dev at lists.secondlife.com Sent: Fri, February 25, 2011 12:33:27 PM Subject: Re: [opensource-dev] STORM-1023 (was OPEN-4) : fmod Hi Nicky, On Fri, Feb 25, 2011 at 8:03 AM, Nicky Perian wrote: I have -DFMOD:BOOL=ON on configure cl and DFMOD=TRUE in autobuild.xml Attempt is made to build with fmod but, the headers and libraries still need to be manually copied. Was that the intent? Nope. Looks like either FindFMOD couldn't locate the files or it wasn't invoked at all. Could you tell me which autobuild configure arguments you use? Again, thanks for the test. Looks like I've more coding to do. Cheers, - Merov _____ No virus found in this message. Checked by AVG - www.avg.com Version: 10.0.1204 / Virus Database: 1435/3468 - Release Date: 02/25/11 -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110226/134644a2/attachment.htm From Aleric.Inglewood at gmail.com Sat Feb 26 06:56:34 2011 From: Aleric.Inglewood at gmail.com (Aleric Inglewood) Date: Sat, 26 Feb 2011 14:56:34 -0000 Subject: [opensource-dev] Review Request: OPEN-38: autobuild support for StandAlone Message-ID: <20110226145634.3033.92319@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/167/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Oz: please merge into your repository. This addresses bug OPEN-38. Diffs ----- indra/cmake/FindGLH.cmake PRE-CREATION indra/cmake/GLH.cmake PRE-CREATION indra/cmake/LLRender.cmake 5f0ab9443ece indra/cmake/LLSharedLibs.cmake 5f0ab9443ece indra/cmake/Linking.cmake 5f0ab9443ece indra/linux_crash_logger/CMakeLists.txt 5f0ab9443ece Diff: http://codereview.secondlife.com/r/167/diff Testing ------- configures, compiles, runs. Thanks, Aleric -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110226/f28c34bd/attachment.htm From wolfpup67 at earthlink.net Sat Feb 26 07:30:53 2011 From: wolfpup67 at earthlink.net (WolfPup Lowenhar) Date: Sat, 26 Feb 2011 10:30:53 -0500 Subject: [opensource-dev] STORM-1023 (was OPEN-4) : fmod In-Reply-To: <001201cbd5bd$1f360400$5da20c00$@net> References: <335654.30922.qm@web43513.mail.sp1.yahoo.com> <14890.24849.qm@web43515.mail.sp1.yahoo.com> <994964.41013.qm@web43513.mail.sp1.yahoo.com> <001201cbd5bd$1f360400$5da20c00$@net> Message-ID: <002601cbd5ca$281891c0$7849b540$@net> After creating a local repository like the one Nicky has and running autobuild configure -c VC10msbuildRelWithDebInfo I get an error in FindFMOD stating cannot find FMOD and the configure fails. From: opensource-dev-bounces at lists.secondlife.com [mailto:opensource-dev-bounces at lists.secondlife.com] On Behalf Of WolfPup Lowenhar Sent: Saturday, February 26, 2011 8:58 AM To: OpenSource Mailing List Subject: Re: [opensource-dev] STORM-1023 (was OPEN-4) : fmod See my comment here: https://jira.secondlife.com/browse/STORM-1023?focusedCommentId=244786 &page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comme nt-244786 This might be a better solution as then the files could also be renamed to properly match what cmake is looking for plus when autobuild sets up the build tree the needed files would be placed automatically with no problems during the configuration process as they would be resident in the OS developers install.cache directory with the rest of the needed packaged for developers that DL libs form LL. And as I do not realy know the how to set up one of these lib systems assistance would be greatly welcomed. From: opensource-dev-bounces at lists.secondlife.com [mailto:opensource-dev-bounces at lists.secondlife.com] On Behalf Of Nicky Perian Sent: Friday, February 25, 2011 4:01 PM To: Philippe (Merov) Bossut Cc: opensource-dev at lists.secondlife.com Subject: Re: [opensource-dev] STORM-1023 (was OPEN-4) : fmod I am using oz's viewer-autobuild2010 with my mod's for VS2010 and your changes at the tip. https://bitbucket.org/NickyP/viewer-autobuild2010-wip this plus your changes at tip. I would not be able to test otherwise. Nicky _____ From: Philippe (Merov) Bossut To: Nicky Perian Cc: opensource-dev at lists.secondlife.com Sent: Fri, February 25, 2011 12:33:27 PM Subject: Re: [opensource-dev] STORM-1023 (was OPEN-4) : fmod Hi Nicky, On Fri, Feb 25, 2011 at 8:03 AM, Nicky Perian wrote: I have -DFMOD:BOOL=ON on configure cl and DFMOD=TRUE in autobuild.xml Attempt is made to build with fmod but, the headers and libraries still need to be manually copied. Was that the intent? Nope. Looks like either FindFMOD couldn't locate the files or it wasn't invoked at all. Could you tell me which autobuild configure arguments you use? Again, thanks for the test. Looks like I've more coding to do. Cheers, - Merov _____ No virus found in this message. Checked by AVG - www.avg.com Version: 10.0.1204 / Virus Database: 1435/3468 - Release Date: 02/25/11 _____ No virus found in this message. Checked by AVG - www.avg.com Version: 10.0.1204 / Virus Database: 1435/3469 - Release Date: 02/26/11 -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110226/aecd68ec/attachment-0001.htm From sllists at boroon.dasgupta.ch Sat Feb 26 07:35:57 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Sat, 26 Feb 2011 15:35:57 -0000 Subject: [opensource-dev] Review Request: VWR-24333: Hardening against use of getLindenUserDir() before logging in. In-Reply-To: <20110114210504.17156.62298@domU-12-31-38-00-90-68.compute-1.internal> References: <20110114210504.17156.62298@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110226153557.30628.26672@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/91/#review386 ----------------------------------------------------------- indra/llvfs/lldir.cpp I know we already have a lot of methods taking boolean arguments, but it's probably worth mentioning http://doc.qt.nokia.com/qq/qq13-apis.html#thebooleanparametertrap here. (I.e., boolean arguments make the calls of the method harder to read, when the method name doesn't already imply the semantics of the argument. You can give the reader a hint towards the semantics by using nicely named enums instead.) indra/newview/llappviewer.cpp E.g. here, it's impossible to guess what the "true" indicates. Either you already know, or you have to look it up. - Boroondas On Jan. 14, 2011, 1:05 p.m., Aleric Inglewood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/91/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2011, 1:05 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Without this patch, getLindenUserDir() is sometimes used without > checking if it returns an empty value, resulting in trying to open > an empty file and then gracefully recovering from that. So, this > patch doesn't really fix a bug. However it might prevent one in the > future. Note that this DID lead to a bug in Viewer 1 code, so it's > possible. The main threat is that some singleton class that uses > getLindenUserDir (indirectly) is instantiated before logging in: > A singleton is only created once and when it is initialized with > an empty getLindenUserDir() then that can remain. > > This patch aborts when the viewer is compiled in debug mode (not > in release mode, when it will do what it did before this patch) > and when getLindenUserDir() is called before it was initialized, > unless the developer explicitely passes 'true' (empty_ok) to > getLindenUserDir, signaling that they considered the possibility > that the function is being called before the user logged in. > > > This addresses bug VWR-24333. > http://jira.secondlife.com/browse/VWR-24333 > > > Diffs > ----- > > indra/llvfs/lldir.h 422f636c3343 > indra/llvfs/lldir.cpp 422f636c3343 > indra/newview/llappviewer.cpp 422f636c3343 > indra/newview/llbottomtray.cpp 422f636c3343 > indra/newview/llfilepicker.cpp 422f636c3343 > indra/newview/llnavigationbar.cpp 422f636c3343 > indra/newview/llsearchhistory.h 422f636c3343 > indra/newview/llurlhistory.cpp 422f636c3343 > indra/newview/llviewerinventory.cpp 422f636c3343 > indra/newview/llviewermedia.cpp 422f636c3343 > indra/newview/llvoiceclient.cpp 422f636c3343 > > Diff: http://codereview.secondlife.com/r/91/diff > > > Testing > ------- > > > Thanks, > > Aleric > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110226/5d09f2f7/attachment.htm From twisted_laws at hotmail.com Sat Feb 26 08:54:14 2011 From: twisted_laws at hotmail.com (Twisted Laws) Date: Sat, 26 Feb 2011 11:54:14 -0500 Subject: [opensource-dev] STORM-1023 (was OPEN-4) : fmod In-Reply-To: References: , Message-ID: to get fmod working i used this changeset and used autobuild --debug configure -c VC10msbuildRelWithDebInfo -- -DLL_TESTS:BOOL=OFF -DFMOD:BOOL=ON -DFMOD_INCLUDE_DIR=C:\Dev\fmod -DFMOD_LIBRARY=C:\Dev\fmod successfully compiles, runs and has sound (not standalone) From: merov at lindenlab.com Date: Thu, 24 Feb 2011 22:03:46 -0800 To: opensource-dev at lists.secondlife.com Subject: [opensource-dev] STORM-1023 (was OPEN-4) : fmod Hi, I worked on this and submitted what I think should solve the problem on a dev repo forked from oz_linden/viewer-autobuild: https://bitbucket.org/merov_linden/viewer-autobuild-open-4/changeset/e439abf2be8e If autobuild interested people building from home STANDALONE and NOT STANDALONE could review that proposal and test the changeset, that would help tremendously. Cheers, - Merov _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110226/a2c40145/attachment.htm From sllists at boroon.dasgupta.ch Sat Feb 26 13:38:14 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Sat, 26 Feb 2011 21:38:14 -0000 Subject: [opensource-dev] Review Request: on-line fix for OPEN-39: (standalone) bitpack_test.o: No such file or directory Message-ID: <20110226213814.25028.28135@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/168/ ----------------------------------------------------------- Review request for Viewer and Aleric Inglewood. Summary ------- On standalone, -I"${TUT_INCLUDE_DIR}" was added to the compile flags for integration tests of llcommon when TUT_INCLUDE_DIR might not have been set yet. This lead to a flag -I"", which would confuse g++ and lead to the tests' object files not being found. This change makes sure that TUT_INCLUDE_DIR is set by including Tut.cmake, which is responsible for setting it. This addresses bug OPEN-39. http://jira.secondlife.com/browse/OPEN-39 Diffs ----- doc/contributions.txt 1013caf84c2e indra/cmake/LLAddBuildTest.cmake 1013caf84c2e Diff: http://codereview.secondlife.com/r/168/diff Testing ------- Clean rebuild with LL_TESTS ON (see also repro instructions on jira) Thanks, Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110226/e3df4c15/attachment.htm From sllists at boroon.dasgupta.ch Sat Feb 26 14:12:05 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Sat, 26 Feb 2011 22:12:05 -0000 Subject: [opensource-dev] Review Request: STORM-1001: Viewer needlessly hits the "ObjectMedia" cap with thousands of requests In-Reply-To: <20110222191204.30628.31251@domU-12-31-38-00-90-68.compute-1.internal> References: <20110222191204.30628.31251@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110226221205.24957.78275@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/162/#review387 ----------------------------------------------------------- indra/llprimitive/lltextureentry.cpp Is this creation/destruction of mMediaEntry taken care off elsewhere already? - Boroondas On Feb. 22, 2011, 11:12 a.m., Kitty Barnett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/162/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2011, 11:12 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > S32 LLTextureEntry::setMediaTexGen(U8 media) would appear to be the root cause of the bug: > > The header file suggests that: > > // The Media Tex Gen values are bits in a bit field: > // +----------+ > // | .....TTM | M = Media Flags (web page), T = LLTextureEntry::eTexGen, . = unused > // | 76543210 | > // +----------+ > const S32 TEM_MEDIA_MASK = 0x01; > const S32 TEM_TEX_GEN_MASK = 0x06; > > and while LLTextureEntry::setTexGen() and LLTextureEntry::setMediaFlags() each properly mask off the supplied parameter with their respective bit mask, setMediaTexGen() will always return TEM_CHANGE_MEDIA even if only texgen has changed while the media flag hasn't (causing LLVOVolume::processUpdateMessage() to queue a request to the cap when it shouldn't). > > Changing it to: > > S32 LLTextureEntry::setMediaTexGen(U8 media) > { > S32 result = setTexGen(media & TEM_TEX_GEN_MASK); > result |= setMediaFlags(media & TEM_MEDIA_MASK); > return result; > } > > appears to resolve the issue completely (the cap isn't hit unless an object nearby has media on it, or changes its URL) > > > This addresses bug STORM-1001. > http://jira.secondlife.com/browse/STORM-1001 > > > Diffs > ----- > > indra/llprimitive/lltextureentry.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/162/diff > > > Testing > ------- > > > Thanks, > > Kitty > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110226/27db07c0/attachment.htm From sllists at boroon.dasgupta.ch Sat Feb 26 14:44:07 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Sat, 26 Feb 2011 22:44:07 -0000 Subject: [opensource-dev] Review Request: OPEN-38: autobuild support for StandAlone In-Reply-To: <20110226145634.3033.92319@domU-12-31-38-00-90-68.compute-1.internal> References: <20110226145634.3033.92319@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110226224407.24877.17159@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/167/#review388 ----------------------------------------------------------- Can you give some instructions on how to do a standalone build with these changes? I tried the following: patch -p1 < /home/das-g/slsrc/patches/autobuild-standalone.diff autobuild install glh_linear autobuild configure -c OpenSourceStandAloneRelWithDebInfo but this fails with: CMake Error at cmake/FindGLH.cmake:26 (message): Could not find GLH Thanks - Boroondas On Feb. 26, 2011, 6:56 a.m., Aleric Inglewood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/167/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2011, 6:56 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Oz: please merge into your repository. > > > This addresses bug OPEN-38. > > > Diffs > ----- > > indra/cmake/FindGLH.cmake PRE-CREATION > indra/cmake/GLH.cmake PRE-CREATION > indra/cmake/LLRender.cmake 5f0ab9443ece > indra/cmake/LLSharedLibs.cmake 5f0ab9443ece > indra/cmake/Linking.cmake 5f0ab9443ece > indra/linux_crash_logger/CMakeLists.txt 5f0ab9443ece > > Diff: http://codereview.secondlife.com/r/167/diff > > > Testing > ------- > > configures, compiles, runs. > > > Thanks, > > Aleric > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110226/5a8e26f7/attachment.htm From laurent.bechir at madonie.org Sat Feb 26 15:31:33 2011 From: laurent.bechir at madonie.org (Laurent Bechir) Date: Sun, 27 Feb 2011 00:31:33 +0100 Subject: [opensource-dev] Forum for ATI, Apple and FBO problem In-Reply-To: References: <4D573A61.8070304@madonie.org> Message-ID: <260436B1-DA62-4D5E-9E82-4093775B5096@madonie.org> I've written to AMD support and got this answer which reject the responsibility to Apple : "If your PC is an Apple system, we recommend you contact to Apple for the suppport for OpenGL for Mac. If you purchased one of our graphics cards designed for Mac sytem, for example the Radeon HD 3870 Mac, then the first driver version is developed by us and the following ones by Apple. This is the reason why we recommend you to contact Apple for more informations regarding your application." Le 13 f?vr. 2011 ? 12:47, Trilo Byte a ?crit : > As I understand the issue, the problem is on the ATI side (possibly their implementation of OpenGL), and is not specific to Apple. > > On Feb 12, 2011, at 5:56 PM, Laurent Bechir wrote: > >> >> Hello, >> >> Some time ago, I've opened a bug report on Apple website concerning the >> problem of ATI cards with FBO which stops Mac users to use dynamic >> shadows. I know they are not officials, but they work quite well with >> Nvidia cards :). I've received an answer recently asking me for the full >> System Profiler Report of my machine. I was wondering if accumulating >> the experiences on that subject would help make the things move faster. >> So I've set up a forum where mac users wanting to do it could tell their >> experience with ATI card and join their full System Profiler Report with >> their experience. I would then put the link to the forum in my bug >> report. Do you think this could be a good idea ? >> >> Bug report : >> >> https://bugreport.apple.com/cgi-bin/WebObjects/RadarWeb.woa/24/wo/KGyze933oURhrNytyxPfAw/5.83.28.0.9 >> >> Forum : >> >> http://macati.madonie.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110227/16bb8da9/attachment-0001.htm From Aleric.Inglewood at gmail.com Sat Feb 26 17:33:16 2011 From: Aleric.Inglewood at gmail.com (Aleric Inglewood) Date: Sun, 27 Feb 2011 01:33:16 -0000 Subject: [opensource-dev] Review Request: OPEN-38: autobuild support for StandAlone In-Reply-To: <20110226224407.24877.17159@domU-12-31-38-00-90-68.compute-1.internal> References: <20110226224407.24877.17159@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110227013316.24895.21796@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 26, 2011, 2:44 p.m., Boroondas Gupte wrote: > > Can you give some instructions on how to do a standalone build with these changes? I tried the following: > > > > patch -p1 < /home/das-g/slsrc/patches/autobuild-standalone.diff > > autobuild install glh_linear > > autobuild configure -c OpenSourceStandAloneRelWithDebInfo > > > > but this fails with: > > > > CMake Error at cmake/FindGLH.cmake:26 (message): > > Could not find GLH > > > > > > Thanks The usual way, you have to include the path where you installed your library to CMAKE_INCLUDE_PATH and CMAKE_LIBRARY_PATH. For GLH just CMAKE_INCLUDE_PATH is enough since it only exists of headers. hikaru:/usr/src/secondlife/viewers/snowstorm/viewer-autobuild>echo $CMAKE_INCLUDE_PATH /usr/src/secondlife/llqtwebkit/install-imprudence/include:/usr/src/secondlife/viewers/snowstorm/viewer-autobuild/include:/sl/usr/include hikaru:/usr/src/secondlife/viewers/snowstorm/viewer-autobuild>ls -l /usr/src/secondlife/viewers/snowstorm/viewer-autobuild/include total 0 lrwxrwxrwx 1 aleric src 48 Feb 25 20:33 GL -> ../linden/build-linux-x86_64/packages/include/GL/ lrwxrwxrwx 1 aleric src 49 Feb 25 20:33 glh -> ../linden/build-linux-x86_64/packages/include/glh/ lrwxrwxrwx 1 aleric src 49 Feb 25 20:33 tut -> ../linden/build-linux-x86_64/packages/include/tut/ As you see, I created symbolic links in some random directory (that I then added to CMAKE_INCLUDE_PATH) to whereever the respective packages are installed by an 'autobuild install'. I did that because if you add */packages/include to CMAKE_INCLUDE_PATH it finds ALL packages that you installed, which might not be what you want if you use the same source tree for standlone and non-standalone testing. - Aleric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/167/#review388 ----------------------------------------------------------- On Feb. 26, 2011, 6:56 a.m., Aleric Inglewood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/167/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2011, 6:56 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Oz: please merge into your repository. > > > This addresses bug OPEN-38. > > > Diffs > ----- > > indra/cmake/FindGLH.cmake PRE-CREATION > indra/cmake/GLH.cmake PRE-CREATION > indra/cmake/LLRender.cmake 5f0ab9443ece > indra/cmake/LLSharedLibs.cmake 5f0ab9443ece > indra/cmake/Linking.cmake 5f0ab9443ece > indra/linux_crash_logger/CMakeLists.txt 5f0ab9443ece > > Diff: http://codereview.secondlife.com/r/167/diff > > > Testing > ------- > > configures, compiles, runs. > > > Thanks, > > Aleric > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110227/0a44935b/attachment.htm From sllists at boroon.dasgupta.ch Sun Feb 27 03:47:50 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Sun, 27 Feb 2011 11:47:50 -0000 Subject: [opensource-dev] Review Request: OPEN-38: autobuild support for StandAlone In-Reply-To: <20110226145634.3033.92319@domU-12-31-38-00-90-68.compute-1.internal> References: <20110226145634.3033.92319@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110227114750.15227.98330@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/167/#review391 ----------------------------------------------------------- Ship it! Ah, with that, configuration succeeds and GLH_INCLUDE_DIR gets correctly set to the dir with the symlinks. Could the need for that symlink dir be avoided by having the user directly set the GLH_INCLUDE_DIR CMake variable? indra/cmake/Linking.cmake I thought the removal of the NOT STANDALONE condition here would give standalone the same (repository-local) include directories that non-standalone has, so that it'd find autobuild-installed dependencies. But it seems those are just for the library binaries? Or is this just about the creation of those directories, not their addition to the search path? Building still fails for me, with Linking CXX shared library libllcommon.so /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../libbreakpad_client.so when searching for -lbreakpad_client /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../libbreakpad_client.a when searching for -lbreakpad_client /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible /usr/lib/libbreakpad_client.so when searching for -lbreakpad_client /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible /usr/lib/libbreakpad_client.a when searching for -lbreakpad_client /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -lbreakpad_client collect2: ld returned 1 exit status make[2]: *** [llcommon/libllcommon.so] Error 1 make[1]: *** [llcommon/CMakeFiles/llcommon.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs.... and In file included from /usr/include/curl/curl.h:36, from [...]/indra/llmessage/llcurl.h:39, from [...]/indra/llmessage/llurlrequest.h:42, from [...]/indra/llmessage/llhttpclient.h:38, from [...]/indra/llmessage/message.h:53, from [...]/indra/llinventory/llcategory.cpp:30: /usr/include/curl/curlrules.h:144: error: size of array ?__curl_rule_01__? is negative /usr/include/curl/curlrules.h:154: error: size of array ?__curl_rule_02__? is negative but I guess those are both 32bit/64bit issues and not related to your changes here, so "Ship it!". - Boroondas On Feb. 26, 2011, 6:56 a.m., Aleric Inglewood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/167/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2011, 6:56 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Oz: please merge into your repository. > > > This addresses bug OPEN-38. > > > Diffs > ----- > > indra/cmake/FindGLH.cmake PRE-CREATION > indra/cmake/GLH.cmake PRE-CREATION > indra/cmake/LLRender.cmake 5f0ab9443ece > indra/cmake/LLSharedLibs.cmake 5f0ab9443ece > indra/cmake/Linking.cmake 5f0ab9443ece > indra/linux_crash_logger/CMakeLists.txt 5f0ab9443ece > > Diff: http://codereview.secondlife.com/r/167/diff > > > Testing > ------- > > configures, compiles, runs. > > > Thanks, > > Aleric > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110227/17166a4c/attachment-0001.htm From sllists at boroon.dasgupta.ch Sun Feb 27 05:56:59 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Sun, 27 Feb 2011 13:56:59 -0000 Subject: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default. In-Reply-To: <20110219173240.15549.74221@domU-12-31-38-00-90-68.compute-1.internal> References: <20110219173240.15549.74221@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110227135659.15227.8355@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/153/#review392 ----------------------------------------------------------- Ship it! indra/llcommon/llavatarname.cpp This could be shortened to if (!mUsername.empty() && !mIsDisplayNameDefault) { name = mDisplayName + " (" + mUsername + ")"; } else { // Display names are off, so legacy name is in mDisplayName, // or Display Name is not changed from (user name based) // default, so also showing the user name would be redundant. name = mDisplayName; } but I guess the nested ifs make the intention more clear, so go for it. - Boroondas On Feb. 19, 2011, 9:32 a.m., ardy.lay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/153/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2011, 9:32 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > https://jira.secondlife.com/browse/VWR-24917 > I have been finding the redundent display of functionally equivalent names in nearby chat history and IM history quite tiresome. > Simple proposal: If the resident's Display Name is at the default then do not display their user.name. > https://bitbucket.org/ArdyLay/viewer-development-vwr-24917 > > Change is to: LLAvatarName::getCompleteName > > I find the following Callers: > LLAvatarActions::requestFriendshipDialog > LLAvatarActions::startIM > LLAvatarActions::startCall > LLIMModel::LLIMSession > LLIMModel::logToFile > LLPostponedNotification::onAvatarNameCache > LLUrlEntryAgent::onAvatarNameCache > LLUrlEntryAgent::getLabel > LLUrlEntryAgentCompleteName::getName > > // Callback for name resolution of a god/estate message > llviewermessage.cpp(2149): args["NAME"] = av_name.getCompleteName(); > llviewermessage.cpp(2154): chat.mText = av_name.getCompleteName() + ": " + message; > > static void on_avatar_name_cache_toast ... > llimview.cpp(108): args["FROM"] = av_name.getCompleteName(); > > Some of these make me wonder if this change will cause some defects and should be implimented as a seperate function. > > > This addresses bug VWR-24917. > http://jira.secondlife.com/browse/VWR-24917 > > > Diffs > ----- > > doc/contributions.txt c10d5e37db1e > indra/llcommon/llavatarname.cpp c10d5e37db1e > > Diff: http://codereview.secondlife.com/r/153/diff > > > Testing > ------- > > I have been using this trivial change and have shared it with a friend, via bitbucket. We have both built the viewer on Windows 7 and find the resulting reduction in redundent text in chat and IM history on screen to be very helpful. > > > Thanks, > > ardy.lay > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110227/624da696/attachment.htm From Aleric.Inglewood at gmail.com Sun Feb 27 08:58:07 2011 From: Aleric.Inglewood at gmail.com (Aleric Inglewood) Date: Sun, 27 Feb 2011 16:58:07 -0000 Subject: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default. In-Reply-To: <20110227135659.15227.8355@domU-12-31-38-00-90-68.compute-1.internal> References: <20110227135659.15227.8355@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110227165807.15227.20408@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 27, 2011, 5:57 a.m., Boroondas Gupte wrote: > > indra/llcommon/llavatarname.cpp, lines 93-108 > > > > > > This could be shortened to > > > > if (!mUsername.empty() && !mIsDisplayNameDefault) > > { > > name = mDisplayName + " (" + mUsername + ")"; > > } > > else > > { > > // Display names are off, so legacy name is in mDisplayName, > > // or Display Name is not changed from (user name based) > > // default, so also showing the user name would be redundant. > > name = mDisplayName; > > } > > > > but I guess the nested ifs make the intention more clear, so go for it. Or even more readable(?): if (mIsDisplayNameDefault || mUsername.empty()) { // Showing the user name when Display Names are off // is redundant, since in that case it's the same string. name = mDisplayName; } else { name = mDisplayName + " (" + mUsername + ")"; } - Aleric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/153/#review392 ----------------------------------------------------------- On Feb. 19, 2011, 9:32 a.m., ardy.lay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/153/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2011, 9:32 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > https://jira.secondlife.com/browse/VWR-24917 > I have been finding the redundent display of functionally equivalent names in nearby chat history and IM history quite tiresome. > Simple proposal: If the resident's Display Name is at the default then do not display their user.name. > https://bitbucket.org/ArdyLay/viewer-development-vwr-24917 > > Change is to: LLAvatarName::getCompleteName > > I find the following Callers: > LLAvatarActions::requestFriendshipDialog > LLAvatarActions::startIM > LLAvatarActions::startCall > LLIMModel::LLIMSession > LLIMModel::logToFile > LLPostponedNotification::onAvatarNameCache > LLUrlEntryAgent::onAvatarNameCache > LLUrlEntryAgent::getLabel > LLUrlEntryAgentCompleteName::getName > > // Callback for name resolution of a god/estate message > llviewermessage.cpp(2149): args["NAME"] = av_name.getCompleteName(); > llviewermessage.cpp(2154): chat.mText = av_name.getCompleteName() + ": " + message; > > static void on_avatar_name_cache_toast ... > llimview.cpp(108): args["FROM"] = av_name.getCompleteName(); > > Some of these make me wonder if this change will cause some defects and should be implimented as a seperate function. > > > This addresses bug VWR-24917. > http://jira.secondlife.com/browse/VWR-24917 > > > Diffs > ----- > > doc/contributions.txt c10d5e37db1e > indra/llcommon/llavatarname.cpp c10d5e37db1e > > Diff: http://codereview.secondlife.com/r/153/diff > > > Testing > ------- > > I have been using this trivial change and have shared it with a friend, via bitbucket. We have both built the viewer on Windows 7 and find the resulting reduction in redundent text in chat and IM history on screen to be very helpful. > > > Thanks, > > ardy.lay > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110227/a636a287/attachment-0001.htm From Aleric.Inglewood at gmail.com Sun Feb 27 09:12:45 2011 From: Aleric.Inglewood at gmail.com (Aleric Inglewood) Date: Sun, 27 Feb 2011 17:12:45 -0000 Subject: [opensource-dev] Review Request: OPEN-38: autobuild support for StandAlone In-Reply-To: <20110227114750.15227.98330@domU-12-31-38-00-90-68.compute-1.internal> References: <20110227114750.15227.98330@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110227171245.14319.85973@domU-12-31-38-00-90-68.compute-1.internal> On Feb. 27, 2011, 3:47 a.m., Aleric Inglewood wrote: > > Building still fails for me, with > > > > Linking CXX shared library libllcommon.so > > /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../libbreakpad_client.so when searching for -lbreakpad_client > > /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../libbreakpad_client.a when searching for -lbreakpad_client > > /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible /usr/lib/libbreakpad_client.so when searching for -lbreakpad_client > > /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible /usr/lib/libbreakpad_client.a when searching for -lbreakpad_client > > /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -lbreakpad_client > > collect2: ld returned 1 exit status > > make[2]: *** [llcommon/libllcommon.so] Error 1 > > make[1]: *** [llcommon/CMakeFiles/llcommon.dir/all] Error 2 > > make[1]: *** Waiting for unfinished jobs.... > > > > and > > > > In file included from /usr/include/curl/curl.h:36, > > from [...]/indra/llmessage/llcurl.h:39, > > from [...]/indra/llmessage/llurlrequest.h:42, > > from [...]/indra/llmessage/llhttpclient.h:38, > > from [...]/indra/llmessage/message.h:53, > > from [...]/indra/llinventory/llcategory.cpp:30: > > /usr/include/curl/curlrules.h:144: error: size of array ?__curl_rule_01__? is negative > > /usr/include/curl/curlrules.h:154: error: size of array ?__curl_rule_02__? is negative > > > > but I guess those are both 32bit/64bit issues and not related to your changes here, so "Ship it!". The curl error means you have a wrongly configured curl; you seem to be including a 32-bit version while now compiling for 64-bit (or visa versa). This definitely doesn't have anything to do with my changes ;). The fact that it can't find -lbreakpad_client seems to be the same problem: it is skipping /usr/lib/libbreakpad_client.a because that is incompatible (was compiled for 32-bit while now you are compiling 64-bit, or visa versa). - Aleric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/167/#review391 ----------------------------------------------------------- On Feb. 26, 2011, 6:56 a.m., Aleric Inglewood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/167/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2011, 6:56 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Oz: please merge into your repository. > > > This addresses bug OPEN-38. > > > Diffs > ----- > > indra/cmake/FindGLH.cmake PRE-CREATION > indra/cmake/GLH.cmake PRE-CREATION > indra/cmake/LLRender.cmake 5f0ab9443ece > indra/cmake/LLSharedLibs.cmake 5f0ab9443ece > indra/cmake/Linking.cmake 5f0ab9443ece > indra/linux_crash_logger/CMakeLists.txt 5f0ab9443ece > > Diff: http://codereview.secondlife.com/r/167/diff > > > Testing > ------- > > configures, compiles, runs. > > > Thanks, > > Aleric > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110227/7ea6d295/attachment.htm From Aleric.Inglewood at gmail.com Sun Feb 27 09:18:25 2011 From: Aleric.Inglewood at gmail.com (Aleric Inglewood) Date: Sun, 27 Feb 2011 17:18:25 -0000 Subject: [opensource-dev] Review Request: OPEN-38: autobuild support for StandAlone In-Reply-To: <20110227114750.15227.98330@domU-12-31-38-00-90-68.compute-1.internal> References: <20110227114750.15227.98330@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110227171825.15189.96105@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 27, 2011, 3:47 a.m., Boroondas Gupte wrote: > > Ah, with that, configuration succeeds and GLH_INCLUDE_DIR gets correctly set to the dir with the symlinks. Could the need for that symlink dir be avoided by having the user directly set the GLH_INCLUDE_DIR CMake variable? There is long standing issue (from the days of Rob Linden) that I wanted to address once things finally get running smoothly... I don't think that now is the time to address this. What needs to be done for tut and glh_linear is to install them in an architecture independent directory and then use them for standalone and non-standalone. The same goes for the slvoice stuff. Some packages ARE needed even on standalone, but the current setup doesn't support it well enough because LL never tests standalone is therefore unaware of the difference between packages that are only needed for non-standalone and packages that are needed for both. - Aleric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/167/#review391 ----------------------------------------------------------- On Feb. 26, 2011, 6:56 a.m., Aleric Inglewood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/167/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2011, 6:56 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Oz: please merge into your repository. > > > This addresses bug OPEN-38. > > > Diffs > ----- > > indra/cmake/FindGLH.cmake PRE-CREATION > indra/cmake/GLH.cmake PRE-CREATION > indra/cmake/LLRender.cmake 5f0ab9443ece > indra/cmake/LLSharedLibs.cmake 5f0ab9443ece > indra/cmake/Linking.cmake 5f0ab9443ece > indra/linux_crash_logger/CMakeLists.txt 5f0ab9443ece > > Diff: http://codereview.secondlife.com/r/167/diff > > > Testing > ------- > > configures, compiles, runs. > > > Thanks, > > Aleric > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110227/bc5bc72b/attachment.htm From Aleric.Inglewood at gmail.com Sun Feb 27 09:23:36 2011 From: Aleric.Inglewood at gmail.com (Aleric Inglewood) Date: Sun, 27 Feb 2011 17:23:36 -0000 Subject: [opensource-dev] Review Request: OPEN-38: autobuild support for StandAlone In-Reply-To: <20110227114750.15227.98330@domU-12-31-38-00-90-68.compute-1.internal> References: <20110227114750.15227.98330@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110227172336.15524.27042@domU-12-31-38-00-90-68.compute-1.internal> > On Feb. 27, 2011, 3:47 a.m., Boroondas Gupte wrote: > > indra/cmake/Linking.cmake, lines 6-20 > > > > > > I thought the removal of the NOT STANDALONE condition here would give standalone the same (repository-local) include directories that non-standalone has, so that it'd find autobuild-installed dependencies. But it seems those are just for the library binaries? Or is this just about the creation of those directories, not their addition to the search path? No, this just sets variables to certain (path) values. No test should ever test if they are set (that would be a wrong design), so they might as well be set. In fact, they ARE being used (at least some of them) on standalone (the staging directories), which is why I removed the if. Also, it's a Good Thing(tm) that the auto-build installed packages (and header files!) are completely invisible on standalone. This should not change. What we need, as I remarked in my other comment, is that we need to create a separate directory where packages can be installed that ARE needed on standalone and then use that, so that we ONLY get packages that we really want/need, and not left-overs from a non-standalone build as well). - Aleric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/167/#review391 ----------------------------------------------------------- On Feb. 26, 2011, 6:56 a.m., Aleric Inglewood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/167/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2011, 6:56 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Oz: please merge into your repository. > > > This addresses bug OPEN-38. > > > Diffs > ----- > > indra/cmake/FindGLH.cmake PRE-CREATION > indra/cmake/GLH.cmake PRE-CREATION > indra/cmake/LLRender.cmake 5f0ab9443ece > indra/cmake/LLSharedLibs.cmake 5f0ab9443ece > indra/cmake/Linking.cmake 5f0ab9443ece > indra/linux_crash_logger/CMakeLists.txt 5f0ab9443ece > > Diff: http://codereview.secondlife.com/r/167/diff > > > Testing > ------- > > configures, compiles, runs. > > > Thanks, > > Aleric > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110227/e986e783/attachment-0001.htm From jhwelch at gmail.com Mon Feb 28 05:48:04 2011 From: jhwelch at gmail.com (Jonathan Welch) Date: Mon, 28 Feb 2011 08:48:04 -0500 Subject: [opensource-dev] VS2010 Express fails basic test Message-ID: I have been trying, with the help of NickyP and archer to get my VS2010 environment set up properly. After two days of work I am still getting a basic error when I try to autobuild configure. I have been able to compile the failing test.c file manually using cl.exe, so it seems there is some problem in my environment. I'm including the build failure, my environment settings, the two .bat files I use to get set up and start the configure step, and and default file VS2010 uses. -------------------------------------------------------- E:\project\viewer-autobuild2010-wip>ab0 E:\project\viewer-autobuild2010-wip>rem call "e:/Microsoft Visual Studio 10.0/VC /bin/vcvars32" E:\project\viewer-autobuild2010-wip>call "e:/Microsoft Visual Studio 10.0/VC/vcv arsall" x86 Setting environment for using Microsoft Visual Studio 2010 x86 tools. E:\project\viewer-autobuild2010-wip>ab1 E:\project\viewer-autobuild2010-wip>autobuild configure -c VC10msbuildRelWithDeb Info -- -DPACKAGE:BOOL=OFF -DLL_TESTS:BOOL=OFF -DMSVC_REDIST_PATH:PATH=C:/WINDO WS/system32 -DLL_RELEASE_FOR_DOWNLOAD:BOOL=TRUE -DFMOD_INCLUDE_DIR:PATH=e:/fmoda pi375win/api/inc -DFMOD_LIBRARY:PATH=e:/fmodapi375win/api/lib -- Check for working C compiler using: Visual Studio 10 -- Check for working C compiler using: Visual Studio 10 -- broken CMake Error at e:/CMake 2.8/share/cmake-2.8/Modules/CMakeTestCCompiler.cmake:52 (MESSAGE): The C compiler "E:/Microsoft Visual Studio 10.0/VC/bin/cl.exe" is not able to compile a simple test program. It fails with the following output: Change Dir: E:/project/viewer-autobuild2010-wip/build-vc100/CMakeFiles/CMakeT mp Run Build Command:C:\WINDOWS\Microsoft.NET\Framework\v4.0.30319\MSBuild.exe cmTryCompileExec.vcxproj /p:Configuration=Debug Microsoft (R) Build Engine Version 4.0.30319.1 [Microsoft .NET Framework, Version 4.0.30319.1] Copyright (C) Microsoft Corporation 2007. All rights reserved. Build started 2/28/2011 8:39:11 AM. Project "E:\project\viewer-autobuild2010-wip\build-vc100\CMakeFiles\CMakeTmp\cmTryComp ileExec.vcxproj" on node 1 (default targets). InitializeBuildStatus: Creating "cmTryCompileExec.dir\Debug\cmTryCompileExec.unsuccessfulbuild" bec ause "AlwaysCreate" was specified. ClCompile: E:\Microsoft Visual Studio 10.0\VC\bin\CL.exe /c /Zi /nologo /W3 /WX- /Od /O b0 /Oy- /D WIN32 /D _WINDOWS /D _DEBUG /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Fo"cmTryCompileExec.dir\Debug\\" /Fd"E:/project/viewer-autobuild2010-wip/build-vc100/CMakeFiles/CMakeTmp/Debug/c mTryCompileExec.pdb" /Gd /TC /analyze- /errorReport:queue testCCompiler.c /Zm10 00 /GZ C:\Program Files\MSBuild\Microsoft.Cpp\v4.0\Platforms\Win32\Microsoft.Cpp.Win32.Targets(1 47,5): error : Required file "" is missing. [E:\project\viewer-autobuild2010-wip\build-vc100\CMakeFiles\CMakeTmp\cmTryComp ileExec.vcxproj] Done Building Project "E:\project\viewer-autobuild2010-wip\build-vc100\CMakeFiles\CMakeTmp\cmTryComp ileExec.vcxproj" (default targets) -- FAILED. Build FAILED. "E:\project\viewer-autobuild2010-wip\build-vc100\CMakeFiles\CMakeTmp\cmTryComp ileExec.vcxproj" (default target) (1) -> (ClCompile target) -> C:\Program Files\MSBuild\Microsoft.Cpp\v4.0\Platforms\Win32\Microsoft.Cpp.Wi n32.Targets(147,5): error : Required file "" is missing. [E:\project\viewer-auto build2010-wip\build-vc100\CMakeFiles\CMakeTmp\cmTryCompileExec.vcxproj] 0 Warning(s) 1 Error(s) Time Elapsed 00:00:00.18 CMake will not be able to correctly generate this project. Call Stack (most recent call first): CMakeLists.txt:18 (project) -- Configuring incomplete, errors occurred! ERROR: default configuration returned 1 For more information: try re-running your command with --verbose or --debug ------------------------------------------------- E:\project\viewer-autobuild2010-wip>set ALLUSERSPROFILE=C:\Documents and Settings\All Users APPDATA=C:\Documents and Settings\jhwelch\Application Data AUTOBUILD_VSVER=100 CLASSPATH=.;C:\Program Files\Java\jre1.5.0_06\lib\ext\QTJava.zip CLIENTNAME=Console CommonProgramFiles=C:\Program Files\Common Files COMPUTERNAME=VEGA ComSpec=C:\WINDOWS\system32\cmd.exe DEFLOGDIR=C:\Documents and Settings\All Users\Application Data\McAfee\DesktopPro tection DevEnvDir=E:\Microsoft Visual Studio 10.0\Common7\IDE\ DXSDK_DIR=e:\Microsoft DirectX SDK (June 2010)\ FP_NO_HOST_CHECK=NO Framework35Version=v3.5 FrameworkDir=C:\WINDOWS\Microsoft.NET\Framework\ FrameworkDIR32=C:\WINDOWS\Microsoft.NET\Framework\ FrameworkVersion=v4.0.30319 FrameworkVersion32=v4.0.30319 HOMEDRIVE=C: HOMEPATH=\Documents and Settings\jhwelch INCLUDE=E:\Microsoft Visual Studio 10.0\VC\INCLUDE;E:\Microsoft SDKs\Windows\v7. 1\Include;E:\Microsoft SDKs\Windows\v7.1\Include\gl;E:\Microsoft DirectX SDK (Ju ne 2010)\Include LIB=E:\Microsoft Visual Studio 10.0\VC\LIB;E:\Microsoft Visual Studio 10.0\SDK\v 3.5\lib;E:\Microsoft SDKs\Windows\v7.1\Lib;E:\Microsoft DirectX SDK (June 2010)\ Lib LIBPATH=C:\WINDOWS\Microsoft.NET\Framework\v4.0.30319;C:\WINDOWS\Microsoft.NET\F ramework\v3.5;E:\Microsoft Visual Studio 10.0\VC\LIB; LOGONSERVER=\\VEGA NUMBER_OF_PROCESSORS=2 OS=Windows_NT Path=E:\Microsoft Visual Studio 10.0\Common7\IDE\;E:\Microsoft Visual Studio 10. 0\VC\BIN;E:\Microsoft Visual Studio 10.0\Common7\Tools;C:\WINDOWS\Microsoft.NET\ Framework\v4.0.30319;C:\WINDOWS\Microsoft.NET\Framework\v3.5;E:\Microsoft Visual Studio 10.0\VC\VCPackages;C:\Program Files\ThinkPad\Utilities;C:\WINDOWS\system 32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\Program Files\ThinkPad\ConnectUtilitie s;C:\Program Files\Common Files\Lenovo;C:\Program Files\Lenovo\Client Security S olution;c:\7zip;c:\GIMP\gtk\bin;C:\QuickTime\QTSystem\;E:\TortoiseSVN\bin;E:\Tor toiseHg;c:\7zip;e:\python25;e:\CMake 2.8\bin;e:\SSFiles;e:\autobuild\bin;e:\cygw in;e:\cygwin\bin PATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.py;.pyw PROCESSOR_ARCHITECTURE=x86 PROCESSOR_IDENTIFIER=x86 Family 6 Model 15 Stepping 6, GenuineIntel PROCESSOR_LEVEL=6 PROCESSOR_REVISION=0f06 ProgramFiles=C:\Program Files PROMPT=$P$G QTJAVA=C:\Program Files\Java\jre1.5.0_06\lib\ext\QTJava.zip RR=C:\Program Files\Lenovo\Rescue and Recovery SESSIONNAME=Console SMA=C:\Program Files\ThinkVantage\SMA\ SonicCentral=C:\Program Files\Common Files\Sonic Shared\Sonic Central\ SWSHARE=C:\SWSHARE SystemDrive=C: SystemRoot=C:\WINDOWS TEMP=C:\DOCUME~1\jhwelch\LOCALS~1\Temp TMP=C:\DOCUME~1\jhwelch\LOCALS~1\Temp TVT=C:\Program Files\Lenovo TVTCOMMON=C:\Program Files\Common Files\Lenovo TVTPYDIR=C:\Program Files\Common Files\Lenovo\Python24 USERDOMAIN=VEGA USERNAME=jhwelch USERPROFILE=C:\Documents and Settings\jhwelch VCINSTALLDIR=E:\Microsoft Visual Studio 10.0\VC\ VS100COMNTOOLS=E:\Microsoft Visual Studio 10.0\Common7\Tools\ VS80COMNTOOLS=E:\Microsoft Visual Studio 8\Common7\Tools\ VSEDEFLOGDIR=C:\Documents and Settings\All Users\Application Data\McAfee\Desktop Protection VSINSTALLDIR=E:\Microsoft Visual Studio 10.0\ windir=C:\WINDOWS WindowsSdkDir=E:\Microsoft Visual Studio 10.0\SDK\ __COMPAT_LAYER=EnableNXShowUI -------------- next part -------------- A non-text attachment was scrubbed... Name: Microsoft.Cpp.Win32.user.props Type: application/octet-stream Size: 704 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110228/b0abc6ca/attachment.obj -------------- next part -------------- A non-text attachment was scrubbed... Name: ab0.batchfile Type: application/octet-stream Size: 1748 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110228/b0abc6ca/attachment-0001.obj -------------- next part -------------- A non-text attachment was scrubbed... Name: ab1.batchfile Type: application/octet-stream Size: 265 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110228/b0abc6ca/attachment-0002.obj From monty at lindenlab.com Mon Feb 28 12:58:58 2011 From: monty at lindenlab.com (Monty Brandenberg) Date: Mon, 28 Feb 2011 15:58:58 -0500 Subject: [opensource-dev] VS2010 Express fails basic test In-Reply-To: References: Message-ID: <4D6C0C92.9030000@lindenlab.com> On 2/28/2011 8:48 AM, Jonathan Welch wrote: > I have been trying, with the help of NickyP and archer to get my > VS2010 environment set up properly. > > CMake Error at e:/CMake 2.8/share/cmake-2.8/Modules/CMakeTestCCompiler.cmake:52 > (MESSAGE): > The C compiler "E:/Microsoft Visual Studio 10.0/VC/bin/cl.exe" is not able > to compile a simple test program. > > It fails with the following output: > > Change Dir: E:/project/viewer-autobuild2010-wip/build-vc100/CMakeFiles/CMakeT > mp I had a similar problem getting Win7-64bit setup with vs2010. The following may or may not solve your problem, however: 1. Reboot. After the VS SP1 upgrade and the special vista/w7 VS upgrade, it turned out a simple reboot fixed the problem. Which is fortunate because the error code I was getting was only documented on a site in Mandarin. 2. Finding the error code involved using the --debug-trycompile option to cmake. This leaves all temporaries in place including log/htm output with better diagnostics. Start with that if 1. doesn't do it. -- Monty Brandenberg 617.401.2384 monty at lindenlab.com From jhwelch at gmail.com Mon Feb 28 14:09:33 2011 From: jhwelch at gmail.com (Jonathan Welch) Date: Mon, 28 Feb 2011 17:09:33 -0500 Subject: [opensource-dev] VS2010 Express fails basic test In-Reply-To: <4D6C0C92.9030000@lindenlab.com> References: <4D6C0C92.9030000@lindenlab.com> Message-ID: Someone suggested I call up a dos prompt from the V7.1 SDK menu and that got me past this problem. I've adjusted my setup.bat file to have all the env vars that that dos window had that were missing from my normal dos window. Once I have the time I may experiment to see which of those env vars are crucial. From monty at lindenlab.com Mon Feb 28 14:45:50 2011 From: monty at lindenlab.com (Monty Brandenberg) Date: Mon, 28 Feb 2011 17:45:50 -0500 Subject: [opensource-dev] VS2010 Express fails basic test In-Reply-To: <4D6C0C92.9030000@lindenlab.com> References: <4D6C0C92.9030000@lindenlab.com> Message-ID: <4D6C259E.7070204@lindenlab.com> On 2/28/2011 3:58 PM, Monty Brandenberg wrote: > I had a similar problem getting Win7-64bit setup with vs2010. > The following may or may not solve your problem, however: Bleh.... I've been doing win7-64bit/vs2005 and xp/vs2010 and mixed up the two. My problem was the former, not the latter. Beware of Lindens offering free advice... -- Monty Brandenberg 617.401.2384 monty at lindenlab.com From wolfpup67 at earthlink.net Mon Feb 28 20:34:50 2011 From: wolfpup67 at earthlink.net (WolfPup Lowenhar) Date: Mon, 28 Feb 2011 23:34:50 -0500 Subject: [opensource-dev] STORM-1023 (was OPEN-4) : fmod In-Reply-To: References: , Message-ID: <000001cbd7ca$00c09da0$0241d8e0$@net> I keep trying to do this and im only getting an error near the end of the configuration process that says : WARNING: Target "secondlife-bin" requests linking to directory "D:/fmodapi375win". Targets may link only to libraries. CMake is dropping the item. If you could explain how your fmod directory it set up it would be welcomed. As you can see I am using the upacked zip file. My suggestion still stand about making a packaging system in autobuild that would generate a package like the one LL uses for fmod that could then be placed somewhere that the autobuild system could find it and the extract it to the build tree. From: opensource-dev-bounces at lists.secondlife.com [mailto:opensource-dev-bounces at lists.secondlife.com] On Behalf Of Twisted Laws Sent: Saturday, February 26, 2011 11:54 AM To: SLDEV Subject: Re: [opensource-dev] STORM-1023 (was OPEN-4) : fmod to get fmod working i used this changeset and used autobuild --debug configure -c VC10msbuildRelWithDebInfo -- -DLL_TESTS:BOOL=OFF -DFMOD:BOOL=ON -DFMOD_INCLUDE_DIR=C:\Dev\fmod -DFMOD_LIBRARY=C:\Dev\fmod successfully compiles, runs and has sound (not standalone) _____ From: merov at lindenlab.com Date: Thu, 24 Feb 2011 22:03:46 -0800 To: opensource-dev at lists.secondlife.com Subject: [opensource-dev] STORM-1023 (was OPEN-4) : fmod Hi, I worked on this and submitted what I think should solve the problem on a dev repo forked from oz_linden/viewer-autobuild: https://bitbucket.org/merov_linden/viewer-autobuild-open-4/changeset/e439abf 2be8e If autobuild interested people building from home STANDALONE and NOT STANDALONE could review that proposal and test the changeset, that would help tremendously. Cheers, - Merov _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges _____ No virus found in this message. Checked by AVG - www.avg.com Version: 10.0.1204 / Virus Database: 1435/3469 - Release Date: 02/26/11 -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110228/78b55b0d/attachment.htm From akanevsky at productengine.com Mon Feb 28 23:05:43 2011 From: akanevsky at productengine.com (Anya Kanevsky) Date: Mon, 28 Feb 2011 23:05:43 -0800 Subject: [opensource-dev] Test build available In-Reply-To: References: Message-ID: Thank you Merov! > > * STORM-357 : Gestures button is in the pressed state after drag-n-drop but > gestures list isn't visible > Rejected > * STORM-665 : User is not able to view full name of Group's founder in the > Group Profile > approved > * STORM-842 : "Start at" list isn't populated with favorites if user name > is typed in fashion "firstname.lastname" > approved > * STORM-889 : Put Link/Unlink in Edit Panel > looks fine to me. any objections? > * STORM-949 : please remove actual usernames from XUI files <-- Trivial and > not really testable > approved! > * STORM-954 : SL-viewer 2.0 No nearby people when over approximately 1000 > meters <-- Long time dangling issue! Please test... > approved > * STORM-971 : 'Stop Tracking' menu item is still enabled in Mini-map > floater after you stopped tracking in Nearby mini-map * STORM-991 : Parser warning on Inventory floater construction > * STORM-1004 : Unblocking/blocking name sometimes deletes identically named > entry, but of different TYPE > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110228/e19bc006/attachment.htm