[opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml

Kent Quirk q at lindenlab.com
Wed Feb 2 08:56:35 PST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/108/#review307
-----------------------------------------------------------


So I have a couple of issues with this patch:

* I'm worried about the translation impact, how these strings are used and where. Should they be localized? Should they not be localized? I find it hard to believe that we ONLY need to translate Home and End. 
* The "1" key is duplicated. Are there others? 
* I think the single-letter keys should be placed in a more useful order so that we can easily find missing items. Keyboard order (especially since keyboards differ) is not good enough.
* I'm worried about the naming convention; single-letter names (ahem, yes, I know who's talking here) can be rather ambiguous. It's probably the easiest fix -- anything else may require much more extensive changes -- but I'm worried about this. Is this fix robust under localization?

I haven't had time to investigate these issues yet; does someone else have the knowledge to discuss?


- Kent


On Jan. 19, 2011, 8:30 a.m., Vadim ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/108/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2011, 8:30 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Made all keys localizable.
> 
> 
> This addresses bug STORM-465.
>     http://jira.secondlife.com/browse/STORM-465
> 
> 
> Diffs
> -----
> 
>   indra/newview/skins/default/xui/en/strings.xml 38465c40c060 
> 
> Diff: http://codereview.secondlife.com/r/108/diff
> 
> 
> Testing
> -------
> 
> Tested on Linux. No keys produce the warning for me.
> 
> 
> Thanks,
> 
> Vadim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110202/1a2e0c34/attachment.htm 


More information about the opensource-dev mailing list