[opensource-dev] Review Request: VWR-17050 No nearby people when over approxiamately 1000 meters

Oz Linden oz at lindenlab.com
Wed Feb 2 12:01:30 PST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/132/#review309
-----------------------------------------------------------



indra/newview/llworld.cpp
<http://codereview.secondlife.com/r/132/#comment235>

    I would strongly prefer to see this rearranged as properly nested if/then/else rather than using continue.
    
    Similarly, I'd like to have the break replaced by just adding another exit condition to the 'for' loop.
    


- Oz


On Jan. 31, 2011, 3:34 p.m., Twisted Laws wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/132/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2011, 3:34 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> This modifies the getAvatars function in llworld to also include any avatars that are found within the range from the LLCharactes list as well (the list of avatars that is in the viewer object list).  This should make sure that anyone that you visually see within range shows up in the list.  Note that changing it in this function also affects LLFloaterAvatarPicker::populateNearMe, LLLocalSpeakerMgr::updateSpeakerList, as well as the LLPanelPeople::updateNearbyList that was originally mentioned in the Jira.  The region avatars lists only contain valid position data when the avatars are below 1024m.  The comment that mentions about retrieving uuids is based on the function, not the current uses.  No current calls in the code are done with the avatar_ids argument NULL.  Duplicates in the returned list need to be suppressed.
> 
> 
> This addresses bug VWR-17050.
>     http://jira.secondlife.com/browse/VWR-17050
> 
> 
> Diffs
> -----
> 
>   indra/newview/llworld.cpp 691e3941d950 
> 
> Diff: http://codereview.secondlife.com/r/132/diff
> 
> 
> Testing
> -------
> 
> Simple testing in sandboxes of this patch at 20m and 2000m heights with and without avatars nearby.  Tested with varying the NearMeRange to insure it does not show avatars beyond the range.  Testers need to understand that RenderFarClip has an impact on the avatars that are actually in the viewer object list, so setting NearMeRange to a great distance at high altitude won't necessarily add avatars to the list.  Basically if you can see the avatar and its within NearMeRange, the avatar should be in the nearby avatar list in the people panel.
> 
> 
> Thanks,
> 
> Twisted
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110202/b7e3e665/attachment.htm 


More information about the opensource-dev mailing list