[opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml

Vadim ProductEngine vsavchuk at productengine.com
Thu Feb 3 08:20:42 PST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/108/
-----------------------------------------------------------

(Updated Feb. 3, 2011, 8:20 a.m.)


Review request for Viewer.


Changes
-------

- Reordered strings more logically.
- Removed duplicated "1" string.
- Using a script, found two more duplicates ("Home", "Esc"), removed them.
- Using the same script, found out that the arrow keys names ("Left", "Right", "Up", "Down") were duplicated as well.
  Fixed that by renaming HUD direction strings and updated the code utilizing them accordingly.

Automated the work as much as possible to avoid further errors (I hope that helped :-)).


Summary
-------

Made all keys localizable.


This addresses bug STORM-465.
    http://jira.secondlife.com/browse/STORM-465


Diffs (updated)
-----

  indra/newview/llmaniprotate.cpp b542f8134a2b 
  indra/newview/skins/default/xui/da/strings.xml b542f8134a2b 
  indra/newview/skins/default/xui/de/strings.xml b542f8134a2b 
  indra/newview/skins/default/xui/en/strings.xml b542f8134a2b 
  indra/newview/skins/default/xui/es/strings.xml b542f8134a2b 
  indra/newview/skins/default/xui/fr/strings.xml b542f8134a2b 
  indra/newview/skins/default/xui/it/strings.xml b542f8134a2b 
  indra/newview/skins/default/xui/ja/strings.xml b542f8134a2b 
  indra/newview/skins/default/xui/nl/strings.xml b542f8134a2b 
  indra/newview/skins/default/xui/pl/strings.xml b542f8134a2b 
  indra/newview/skins/default/xui/pt/strings.xml b542f8134a2b 

Diff: http://codereview.secondlife.com/r/108/diff


Testing
-------

Tested on Linux. No keys produce the warning for me.


Thanks,

Vadim

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110203/bcbef4ca/attachment.htm 


More information about the opensource-dev mailing list