[opensource-dev] Review Request: OPEN-7: allow specification of the config-file with env var AUTOBUILD_CONFIG_FILE

Oz Linden oz at lindenlab.com
Sun Feb 6 17:39:22 PST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/140/
-----------------------------------------------------------

Review request for Viewer.


Summary
-------

This change allows the environment variable AUTOBUILD_CONFIG_FILE to specify a default config-file, so that the precedence becomes:

   1. the --config-file command line option
   2. the environment variable AUTOBUILD_CONFIG_FILE
   3. "autobuild.xml"

It also adds an info-level (--verbose) display of the config file name that is being loaded, and a warning level display if the config file does not exist.


This addresses bug open-7.


Diffs
-----

  autobuild/autobuild_tool_build.py 9ee2db08d677 
  autobuild/autobuild_tool_configure.py 9ee2db08d677 
  autobuild/autobuild_tool_edit.py 9ee2db08d677 
  autobuild/autobuild_tool_install.py 9ee2db08d677 
  autobuild/autobuild_tool_installables.py 9ee2db08d677 
  autobuild/autobuild_tool_manifest.py 9ee2db08d677 
  autobuild/autobuild_tool_package.py 9ee2db08d677 
  autobuild/autobuild_tool_print.py 9ee2db08d677 
  autobuild/autobuild_tool_uninstall.py 9ee2db08d677 
  autobuild/configfile.py 9ee2db08d677 

Diff: http://codereview.secondlife.com/r/140/diff


Testing
-------

Manually tested with and without the command line option, and with and without the environment variable set: confirmed that the correct file name is used per the precedence above.

Confirmed that the new logging works correctly.


Thanks,

Oz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110207/7f27e862/attachment.htm 


More information about the opensource-dev mailing list