[opensource-dev] Review Request: OPEN-8: allow specification of the configuration with env var AUTOBUILD_CONFIGURATION
Alain Linden
alain at lindenlab.com
Tue Feb 8 09:37:09 PST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/141/#review342
-----------------------------------------------------------
I'm not sure AUTOBUILD_CONFIGURATION is a good name for this environment variable. I know this is long, but AUTOUBUILD_DEFAULT_BUILD_CONFIGURATIONS is more accurate and descriptive (and one could probably drop the AUTOBUILD if we aren't too worried about conflicts with other env variable names)
- Alain
On Feb. 6, 2011, 8:01 p.m., Oz Linden wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/141/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2011, 8:01 p.m.)
>
>
> Review request for Viewer.
>
>
> Summary
> -------
>
> This patch adds support for specifying the configurations using the AUTOBUILD_CONFIGURATION environment variable (multiple configurations can be specified using commas to separate the values).
>
>
> This addresses bug open-8.
>
>
> Diffs
> -----
>
> autobuild/autobuild_base.py 9ee2db08d677
> autobuild/autobuild_tool_build.py 9ee2db08d677
> autobuild/autobuild_tool_configure.py 9ee2db08d677
>
> Diff: http://codereview.secondlife.com/r/141/diff
>
>
> Testing
> -------
>
> Tested manually with and without the command line argument, and with and without the environment variable set; the appropriate configuration values were used.
>
>
> Thanks,
>
> Oz
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110208/40de964a/attachment.htm
More information about the opensource-dev
mailing list