[opensource-dev] Review Request: OPEN-29: Error out if lldir_<platform>.h is included when building for a different platform.

Boroondas Gupte sllists at boroon.dasgupta.ch
Fri Feb 11 06:07:06 PST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/148/
-----------------------------------------------------------

(Updated Feb. 11, 2011, 6:07 a.m.)


Review request for Viewer.


Changes
-------

(just edited description, so that the link there works)


Summary (updated)
-------

Rather than relying on (probably anyway accidental) on syntax incompatibilities, added explicit #error to the indra/llvfs/lldir_*.h headers.

In separate commits, but also in the diff for review here, removed one such syntax incompatibility (https://bitbucket.org/boroondas/open-29/changeset/19ab94811717 ) and did some cleanup (superfluous "public:"s, trailing whitespace).


This addresses bug OPEN-29.
    http://jira.secondlife.com/browse/OPEN-29


Diffs
-----

  doc/contributions.txt ec4ad7e3ecca 
  indra/llvfs/lldir_linux.h ec4ad7e3ecca 
  indra/llvfs/lldir_mac.h ec4ad7e3ecca 
  indra/llvfs/lldir_solaris.h ec4ad7e3ecca 
  indra/llvfs/lldir_win32.h ec4ad7e3ecca 

Diff: http://codereview.secondlife.com/r/148/diff


Testing
-------

Built on Linux before pulling https://bitbucket.org/lindenlab/viewer-development/changeset/7a1440277911
* Errors out as wanted.

Build on Linux after pulling 7a1440277911
* Builds like normal.

Note: These tests were done with other build fixes present
* for VWR-24520 https://codereview.secondlife.com/r/97/
* for VWR-24487 https://codereview.secondlife.com/r/100/
not on a pristine source tree.


Thanks,

Boroondas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110211/d68b4d19/attachment.htm 


More information about the opensource-dev mailing list