[opensource-dev] Review Request: OPEN-8: allow specification of the configuration with env var AUTOBUILD_CONFIGURATION

Jenn jenn at lindenlab.com
Fri Feb 11 17:52:26 PST 2011



> On Feb. 8, 2011, 9:37 a.m., Alain Linden wrote:
> > I'm not sure AUTOBUILD_CONFIGURATION is a good name for this environment variable.  I know this is long, but AUTOUBUILD_DEFAULT_BUILD_CONFIGURATIONS is more accurate and descriptive (and one could probably drop the AUTOBUILD if we aren't too worried about conflicts with other env variable names)
> 
> Oz Linden wrote:
>     The name was chosen to match that of the long-form option that it provides the default value for.  Using the AUTOBUILD_ prefix is just good practice, because collisions are a serious issue not to be ignored.
>

I note that 'default' is generally the name of one of the configurations in the config file (i.e. autobuild.xml). Given that and oz's pattern of naming environment variables after the option names, I'd go with the AUTOBUILD_CONFIGURATION nomenclature.

I'd want to be a bit careful about populating the env var space much further than this, but what you've done here so far seems fine to me.


- Jenn


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/141/#review342
-----------------------------------------------------------


On Feb. 6, 2011, 8:01 p.m., Oz Linden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/141/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2011, 8:01 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> This patch adds support for specifying the configurations using the AUTOBUILD_CONFIGURATION environment variable (multiple configurations can be specified using commas to separate the values).
> 
> 
> This addresses bug open-8.
> 
> 
> Diffs
> -----
> 
>   autobuild/autobuild_base.py 9ee2db08d677 
>   autobuild/autobuild_tool_build.py 9ee2db08d677 
>   autobuild/autobuild_tool_configure.py 9ee2db08d677 
> 
> Diff: http://codereview.secondlife.com/r/141/diff
> 
> 
> Testing
> -------
> 
> Tested manually with and without the command line argument, and with and without the environment variable set; the appropriate configuration values were used.
> 
> 
> Thanks,
> 
> Oz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110212/51139a4c/attachment.htm 


More information about the opensource-dev mailing list