[opensource-dev] Review Request: STORM-977 llmediaplugintest shows up even though -DLL_TESTS:BOOL=OFF has been used

Merov Linden merov at lindenlab.com
Wed Feb 16 10:09:16 PST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/144/#review366
-----------------------------------------------------------


If you want to bypass the entire make file for llplugintest, it seems to me better to do it at the indra/CMakeLists.txt level. There's only one line in there that's relevant to llplugintest. Could you try that out?

- Merov


On Feb. 8, 2011, 8:46 a.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/144/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2011, 8:46 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> llmediaplugintest shows up to be compiled even though -DLL_TESTS:BOOL=OFF has been used on the command line.
> 
> This cmake file does not use the call to LL_ADD_PROJECT_UNIT_TESTS that other cmake files do.  
> 
> LL_ADD_PROJECT_UNIT_TESTS is usually wrapped with if(LL_TESTS)
> 
> I could not figure out which lines suppress the inclusion of copy_plugintest_libs and llmediaplugintest into the list of what is to be built so wrapped the entire file around if(LL_TESTS).  
> 
> If there is some better way to more exactly target these two items please point it out.
> 
> 
> This addresses bug STORM-977.
>     http://jira.secondlife.com/browse/STORM-977
> 
> 
> Diffs
> -----
> 
>   indra/test_apps/llplugintest/CMakeLists.txt b0bceb572090 
> 
> Diff: http://codereview.secondlife.com/r/144/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110216/5b84bd2b/attachment.htm 


More information about the opensource-dev mailing list