[opensource-dev] Review Request: VWR-24889: When a bake texture upload fails, retry instead of giving up.

Merov Linden merov at lindenlab.com
Fri Feb 25 19:56:34 PST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/152/#review385
-----------------------------------------------------------


Apart from what Thickbrick already pointed out and the typo here under, I don't have anything against that patch. We should test live though and make sure that 5 times 5 sec is not too much for a retry loop (seems a bit long to me).


indra/newview/lltexlayer.h
<http://codereview.secondlife.com/r/152/#comment271>

    typos in comment: "whether it is a final bake or intermediary low res"


- Merov


On Feb. 19, 2011, 9:08 a.m., Thickbrick Sleaford wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/152/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2011, 9:08 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> When a bake upload fails, the viewer doesn't retry it, and subsequently doesn't send a AgentSetAppearance message. This can happen without the user being aware, leaving the avatar looking good on their screen, but not updated to the same outfit on other people's screens. The avatar will remain in that state until the user does something that causes a rebake (manually rebake or change outfit.) The solution here is to retry the upload after a small delay.
> 
> What this diff changes: when a full-res upload fails, retry to upload it after a 5s delay, up to 5 times (in case the cap is available, last attempt is via the old asset store.) Also, some clearer log messages. This implements an old *FIX: comment:
>     // *FIX: retry upload after n seconds, asset server could be busy
> 
> This isn't needed for low res uploads, because they don't block subsequent full-res uploads (mNeedsUpload isn't set to FALSE in LLTexLayerSetBuffer::doUpload in low-res uploads.)
> 
> 
> This addresses bug VWR-24889.
>     http://jira.secondlife.com/browse/VWR-24889
> 
> 
> Diffs
> -----
> 
>   indra/newview/llassetuploadresponders.h 379da6bd50a5 
>   indra/newview/llassetuploadresponders.cpp 379da6bd50a5 
>   indra/newview/lltexlayer.h 379da6bd50a5 
>   indra/newview/lltexlayer.cpp 379da6bd50a5 
> 
> Diff: http://codereview.secondlife.com/r/152/diff
> 
> 
> Testing
> -------
> 
> Attempted outfit changes using a problematic connection (not recently used outfits to avoid using cached bakes). Looked for "Baked full res texture upload for <region name> failed" log messages, observed the subsequent retries and successful upload for that region. Observed that eventually the fully-baked avatar is visible to other users.
> 
> 
> Thanks,
> 
> Thickbrick
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110226/1c3faae4/attachment.htm 


More information about the opensource-dev mailing list