[opensource-dev] Review Request: VWR-24347 Reversion in Copy3rdPartyLibs.cmake -- cannot find msvc* files using VS 2005 Express

[Merov Linden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/68/#review111
-----------------------------------------------------------


Those lines have been missing since a long time: the first version in hg is already missing them:
https://bitbucket.org/lindenlab/viewer-development/changeset/07304583316d

- Merov


On Dec. 29, 2010, 3:42 p.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/68/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2010, 3:42 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Environment: Windows, VS 2005 Express
> 
> Back in the days of v2.1 I was able to supply the following option to develop.py, which would allow me to specify the location of
> msvcr80.dll
> msvcp80.dll
> Microsoft.VC80.CRT.manifest
> 
> -DMSVC_REDIST_PATH:PATH=E:/some/path
> 
> There was a similar code path for the debug files
> -DMSVC_DEBUG_REDIST_PATH=E:/some/path
> 
> This files cannot be found by the Express compiler so without a way of telling the compiler where to find them they have to be dropped into the build tree manually.
> 
> At some point Copy3rdPartyLibs.cmake was rewritten and this option was dropped.
> 
> 
> This addresses bug vwr-24347.
>     http://jira.secondlife.com/browse/vwr-24347
> 
> 
> Diffs
> -----
> 
>   indra/cmake/Copy3rdPartyLibs.cmake 27dae7b01a81 
> 
> Diff: http://codereview.secondlife.com/r/68/diff
> 
> 
> Testing
> -------
> 
> I tried using -DMSVC_REDIST_PATH:PATH=E:/some/path with my VS 2005 Express compiler and obtained the desired result. 
> 
> I don't have the debug files to test -DMSVC_DEBUG_REDIST_PATH=E:/some/path
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110105/cd7c331a/attachment.htm