[opensource-dev] Review Request: STORM-826 (partial): fix line endings in files that use a mix of CRLF and LF

[Boroondas Gupte]

> On Jan. 6, 2011, 4:01 a.m., Boroondas Gupte wrote:
> > "View Diff" doesn't display anything and with "Download Diff", I get a patch file that doesn't change anything: It removes some lines and adds back the exact same lines, with the same line endings (just LF). The surrounding lines (in the diff context) seem also to be LF-ended, even though one of the actual original files (indra/newview/llfloaterwebcontent.h) has CRLF endings, except for the line touched by the patch.
> > 
> > I don't know how much of these are review-board and/or diffing issues. Please point us to a hg changeset so we can review the actual change.

Hmm ... on the jira, I saw the link to https://bitbucket.org/oz_linden/storm-826/changeset/8037fad5dee4 but that changes many more files than the diff downloadable here even mentions.


- Boroondas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/70/#review115
-----------------------------------------------------------


On Jan. 5, 2011, 7:19 a.m., Oz Linden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/70/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2011, 7:19 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> This is a simple change to correct existing line endings - I scanned all of viewer-development to identify files that had a mixture of CRLF and LF endings and converted them to just LF.
> 
> What to do about preventing future such will be dealt with separately...
> 
> 
> This addresses bug storm-826.
>     http://jira.secondlife.com/browse/storm-826
> 
> 
> Diffs
> -----
> 
>   indra/newview/llfloaterwebcontent.h 845cab866155 
>   indra/newview/llimview.h 845cab866155 
>   indra/newview/llimview.cpp 845cab866155 
>   indra/newview/lllogchat.cpp 845cab866155 
> 
> Diff: http://codereview.secondlife.com/r/70/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Oz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110106/b7836fb1/attachment.htm