[opensource-dev] Review Request: STORM-830 Volume slider isn't properly remembered if set to zero

[Jonathan Yap]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/72/
-----------------------------------------------------------

Review request for Viewer.


Summary
-------

There is an edge case in setMasterGain during startup which prevents setInternalGain from being called if the master volume setting and mInternalGain both equal 0.

Setting mInternalGain to a very low but non-zero value fixes this issue.


This addresses bug STORM-830.
    http://jira.secondlife.com/browse/STORM-830


Diffs
-----

  indra/llaudio/llaudioengine.cpp 6d44f0d85a80 

Diff: http://codereview.secondlife.com/r/72/diff


Testing
-------

In Preferences / Sound & Media tested:
Buttons
Ambient
Sound Effects
Stream Music
Media
Voice Chat


Thanks,

Jonathan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110106/7ad11136/attachment-0001.htm