[opensource-dev] Review Request: STORM-829 Viewer 2 does not parse /me in object Instant Messages

[Jonathan Yap]

> On Jan. 7, 2011, 9:36 a.m., Joshua Linden wrote:
> > I believe Aleric's comment is accurate. Logic testing for a prefix should be removed from the patch, and the flag should simply always be specified in this case. 
> > 
> > It is notable that the flag does trigger exactly the same test that is present in the patch (i.e. it's not case sensitive, it replicates prefix testing in several other places in the code base, etc). A more general fix might be to refactor all of the places that do prefix testing, but that wouldn't affect this specific issue. Again, the patch should be reduced to one line that simply adds the desired flag.

Joshua, if the check for "/me " and "/me'" were not present and CHAT_STYLE_IRC was always passed in then all llInstantMessages from objects would be treated as if /me had been sent.  I don't think this is what is desired.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/71/#review132
-----------------------------------------------------------


On Jan. 5, 2011, 6:14 p.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/71/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2011, 6:14 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> The "/me" in the lsl code below would be displayed rather than being translated to a name:
> llInstantMessage(llGetOwner(),"/me Hello, Avatar!");
> 
> 
> This addresses bug STORM-829.
>     http://jira.secondlife.com/browse/STORM-829
> 
> 
> Diffs
> -----
> 
>   indra/newview/llviewermessage.cpp 845cab866155 
> 
> Diff: http://codereview.secondlife.com/r/71/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110107/e324b7ac/attachment.htm