[opensource-dev] Review Request: STORM-829 Viewer 2 does not parse /me in object Instant Messages

[Jamey Fletcher]

Joshua Linden wrote:

> I believe Aleric's comment is accurate. Logic testing for a prefix
> should be removed from the patch, and the flag should simply always
> be specified in this case.

> It is notable that the flag does trigger exactly the same test that
> is present in the patch (i.e. it's not case sensitive, it replicates
> prefix testing in several other places in the code base, etc). A more
> general fix might be to refactor all of the places that do prefix
> testing, but that wouldn't affect this specific issue. Again, the
> patch should be reduced to one line that simply adds the desired
> flag.

I'm... wondering why not test *ONCE* when the input is accepted, do the 
appropriate replacement and set the flag so it gets sent as an action 
instead of a statement, and be done with it?  The IM input, chatbar 
inputs, and local history tab inputs all need pretty much the same 
validation, don't they?