[opensource-dev] Review Request: Update returnability of objects based on new encroachment rules

[Merov Linden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/56/#review140
-----------------------------------------------------------

Ship it!


Good! Only minor typos and code style issues (see review details). About lines commented out, please prefer deletion unless there's a good reason for it which then should be mentioned in comments.


indra/llmath/llbbox.cpp
<http://codereview.secondlife.com/r/56/#comment81>

    Typo : change "rotiation" to "rotation"



indra/llmessage/llregionflags.h
<http://codereview.secondlife.com/r/56/#comment82>

    Suppress legacy code, don't leave it commented out



indra/llmessage/llregionflags.h
<http://codereview.secondlife.com/r/56/#comment83>

    Suppress old code, don't leave it commented out



indra/llmessage/llregionflags.h
<http://codereview.secondlife.com/r/56/#comment84>

    Please suppress (though it was already commented out...)



indra/llmessage/llregionflags.h
<http://codereview.secondlife.com/r/56/#comment85>

    Suppress etc...



indra/llmessage/llregionflags.h
<http://codereview.secondlife.com/r/56/#comment86>

    Suppress etc...



indra/newview/llviewerobject.h
<http://codereview.secondlife.com/r/56/#comment87>

    Typo: one "it" too many



indra/newview/llviewerparceloverlay.cpp
<http://codereview.secondlife.com/r/56/#comment88>

    Code style:
    - use "{ }" for each for nested loop and each if statement
    - use "()" in "||" statement


- Merov


On Jan. 10, 2011, 3:36 p.m., Merov Linden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/56/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2011, 3:36 p.m.)
> 
> 
> Review request for Viewer and Andrew Meadows.
> 
> 
> Summary
> -------
> 
> The object-vs-parcel overlap test is done by building axis-aligned bounding boxes (AABB) about each prim of the selected objects and then checking for overlap between those boxes and self- and group-owned parcels. 
> 
> 
> This addresses bug STORM-807.
>     http://jira.secondlife.com/browse/STORM-807
> 
> 
> Diffs
> -----
> 
>   indra/llmath/llbbox.h bceb13778d1d 
>   indra/llmath/llbbox.cpp bceb13778d1d 
>   indra/llmessage/llregionflags.h bceb13778d1d 
>   indra/newview/llviewermenu.cpp bceb13778d1d 
>   indra/newview/llviewerobject.h bceb13778d1d 
>   indra/newview/llviewerobject.cpp bceb13778d1d 
>   indra/newview/llviewerparceloverlay.h bceb13778d1d 
>   indra/newview/llviewerparceloverlay.cpp bceb13778d1d 
>   indra/newview/llviewerregion.h bceb13778d1d 
>   indra/newview/llviewerregion.cpp bceb13778d1d 
>   indra/newview/llvoavatar.cpp bceb13778d1d 
>   indra/newview/skins/default/xui/en/menu_viewer.xml bceb13778d1d 
> 
> Diff: http://codereview.secondlife.com/r/56/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Merov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110110/891ad58a/attachment-0001.htm