[opensource-dev] Review Request: (STORM-550) LLDir::getNextFileInDir fails for some complex wildcard combinations

Kent Quirk q at lindenlab.com
Tue Jan 11 08:57:48 PST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/32/#review141
-----------------------------------------------------------

Ship it!


I haven't built it, but I'm presuming that since you wrote test code that it passes the tests. I love this; and it's even documented. The code looks good, and I'm really happy to have it. Thank you.

- Kent


On Jan. 11, 2011, 8:27 a.m., Seth ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/32/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2011, 8:27 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> - Re-implemented LLDir::getNextFileInDir() as an iterator object.
> - Added a class implementing directory entries iteration with pattern matching which is used in unit tests instead of LLDir::getNextFileInDir.
> - Fixed LLDir unit test which failed for some complex wildcard combinations.
> - Replaced all existing usages of LLDir::getNextFileInDir() with the new directory iterator object.
> - Removed platform specific LLDir::getNextFileInDir() implementation.
> 
> 
> This addresses bug STORM-477.
>     http://jira.secondlife.com/browse/STORM-477
> 
> 
> Diffs
> -----
> 
>   indra/cmake/Boost.cmake bceb13778d1d 
>   indra/integration_tests/llui_libtest/llui_libtest.cpp bceb13778d1d 
>   indra/linux_updater/linux_updater.cpp bceb13778d1d 
>   indra/llvfs/CMakeLists.txt bceb13778d1d 
>   indra/llvfs/lldir.h bceb13778d1d 
>   indra/llvfs/lldir.cpp bceb13778d1d 
>   indra/llvfs/lldir_linux.h bceb13778d1d 
>   indra/llvfs/lldir_linux.cpp bceb13778d1d 
>   indra/llvfs/lldir_mac.h bceb13778d1d 
>   indra/llvfs/lldir_mac.cpp bceb13778d1d 
>   indra/llvfs/lldir_solaris.h bceb13778d1d 
>   indra/llvfs/lldir_solaris.cpp bceb13778d1d 
>   indra/llvfs/lldir_win32.h bceb13778d1d 
>   indra/llvfs/lldir_win32.cpp bceb13778d1d 
>   indra/llvfs/lldiriterator.h PRE-CREATION 
>   indra/llvfs/lldiriterator.cpp PRE-CREATION 
>   indra/llvfs/tests/lldir_test.cpp bceb13778d1d 
>   indra/newview/llappviewer.cpp bceb13778d1d 
>   indra/newview/llappviewerlinux.cpp bceb13778d1d 
>   indra/newview/llfloateruipreview.cpp bceb13778d1d 
>   indra/newview/lllogchat.cpp bceb13778d1d 
>   indra/newview/llviewermedia.cpp bceb13778d1d 
>   indra/newview/llwaterparammanager.cpp bceb13778d1d 
>   indra/newview/llwlparammanager.cpp bceb13778d1d 
>   indra/viewer_components/updater/tests/llupdaterservice_test.cpp bceb13778d1d 
> 
> Diff: http://codereview.secondlife.com/r/32/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Seth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110111/a2a882d7/attachment-0001.htm 


More information about the opensource-dev mailing list