[opensource-dev] Review Request: Show TOS (and other login dialogs) if --login is specified

[Oz Linden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/76/#review142
-----------------------------------------------------------

Ship it!


Looks good to me.

- Oz


On Jan. 10, 2011, 10:28 a.m., Joshua Linden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/76/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2011, 10:28 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> This simply removes the mUserInteraction logic from LLLoginInstance, which is not used other than in this behavior. Internal discussion indicates that the current behavior is undesirable and is not being relied upon by test automation, and in fact interferes with test automation.
> 
> Prior to this change, if the viewer is launched with:
> 
> SecondLife.exe --login FIRST LAST PASSWORD
> 
> ... and if the login response is that a TOS, Critical Message, or Update must be acknowledged, the viewer simply returns to the credentials screen (login panel) but does not indicate why. 
> 
> After this change, the viewer will display the appropriate follow-on UI even if --login is used. If necessary, an additional option could be specified to inhibit showing these UI elements for test automation scenarios (e.g. auto-accepting or exiting the viewer, as appropriate).
> 
> (the bulk of the raw diff is whitespace changes due to re-indentation)
> 
> 
> This addresses bug VWR-24401.
>     http://jira.secondlife.com/browse/VWR-24401
> 
> 
> Diffs
> -----
> 
>   indra/newview/lllogininstance.h 78fae8ca1b36 
>   indra/newview/lllogininstance.cpp 78fae8ca1b36 
>   indra/newview/llstartup.cpp 78fae8ca1b36 
> 
> Diff: http://codereview.secondlife.com/r/76/diff
> 
> 
> Testing
> -------
> 
> Launched viewer normally (with "normal" account), entered credentials, logged in successfully.
> Launched viewer via --login (with "normal" account), logged in successfully.
> Launched viewer via --login with account needing to accept TOS update; viewer displayed TOS dialog; accepted and logged in successfully.
> 
> 
> Thanks,
> 
> Joshua
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110112/d5e81a48/attachment.htm