[opensource-dev] Review Request: Storm-844 "More" should be "Less" when Media Control is open

[Oz Linden]

> On Jan. 12, 2011, 6:16 a.m., Boroondas Gupte wrote:
> > doc/contributions.txt, lines 369-371
> > <http://codereview.secondlife.com/r/78/diff/1/?file=383#file383line369>
> >
> >     Sorting issue numbers in doc/contributions.txt is a Good Thing(TM), but unrelated to the issue at hand, thus should happen in a separate commit.

Actually, because I use changes to this file to generate some of our metrics for open source contributions, I'd prefer that any existing order be preserved: that is, add lines as needed (and adding them in order is nice), but do not reorder existing lines please.


- Oz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/78/#review143
-----------------------------------------------------------


On Jan. 12, 2011, 6:02 a.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/78/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2011, 6:02 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> "More" should be "Less" when Media Control is open
> 
> This is a trivial text change in an xml file.  The reason I am posting this here is due to some confusion using label_selected.  In this case having it set to a different value than when label is set to seems to have no effect, so I have made them identical.
> 
> I scanned all the xml files and there are only about 5 places where label_selected is different from the preceding label= value.
> 
> Is there any reason to revert back to having them set to different values?
> i.e. label="More" and label_selected="Less"
> 
> 
> This addresses bug storm-844.
>     http://jira.secondlife.com/browse/storm-844
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 179e0754a27d 
>   indra/newview/skins/default/xui/en/panel_nearby_media.xml 179e0754a27d 
> 
> Diff: http://codereview.secondlife.com/r/78/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110112/4e0834aa/attachment-0001.htm