[opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

[Aleric Inglewood]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/81/
-----------------------------------------------------------

Review request for Viewer.


Summary
-------

Turns out that most of my SNOW-800 patch was included in Viewer 2 (albeit without crediting me).
However, not everything was used and some more cleaning up was possible.

After this patch, and when compiling with optimization, there are no duplicates left
anymore that shouldn't be there in the first place: apart from the debug stream
iostream guard variable, there are several static variables with the same name (r, r1,
r2, etc) but that indeed actually different symbol objects. Then there are a few
constant POD arrays that are duplicated a hand full of times because they are
accessed with a variable index (so optimizing them away is not possible). I left them
like that (although defining those as extern as well would have been more consistent
and not slower; in fact it would be faster theoretically because those arrays could
share the same cache page then). 


This addresses bug VWR-24312.
    http://jira.secondlife.com/browse/VWR-24312


Diffs
-----

  doc/contributions.txt b0bd26c5638a 
  indra/llcharacter/llanimationstates.cpp b0bd26c5638a 
  indra/llcommon/llavatarconstants.h b0bd26c5638a 
  indra/llcommon/lllslconstants.h b0bd26c5638a 
  indra/llcommon/llmetricperformancetester.h b0bd26c5638a 
  indra/llmath/llcamera.h b0bd26c5638a 
  indra/llmath/llcamera.cpp b0bd26c5638a 
  indra/newview/llviewerobject.cpp b0bd26c5638a 
  indra/newview/llvoavatar.cpp b0bd26c5638a 
  indra/newview/llvosky.h b0bd26c5638a 
  indra/newview/llvosky.cpp b0bd26c5638a 

Diff: http://codereview.secondlife.com/r/81/diff


Testing
-------

Compiled with optimization and then running readelf on the executable to find duplicated symbols.


Thanks,

Aleric

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110114/13ba6a54/attachment.htm