[opensource-dev] Review Request: VWR-24317: Incorrect start up warnings: WARNING: ll_apr_warn_status: APR: No such file or directory

Boroondas Gupte sllists at boroon.dasgupta.ch
Fri Jan 14 13:47:50 PST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/83/#review154
-----------------------------------------------------------

Ship it!


Looks good. Files should only be removed when they actually exists, which this change accomplishes.


Just wondering:


indra/newview/llappviewer.cpp
<http://codereview.secondlife.com/r/83/#comment97>

    



indra/newview/llappviewer.cpp
<http://codereview.secondlife.com/r/83/#comment98>

    



indra/newview/llappviewer.cpp
<http://codereview.secondlife.com/r/83/#comment99>

    what's the reason for moving the LL_INFOS around?


- Boroondas


On Jan. 14, 2011, 12:48 p.m., Aleric Inglewood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/83/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2011, 12:48 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> At start up one can get the following “warnings”:
> 
> 2010-10-23T12:22:44Z WARNING: ll_apr_warn_status: APR: No such file or directory
> 2010-10-23T12:22:44Z WARNING: remove: Attempting to remove filename: /home/aleric/.imprudence/logs/Imprudence.logout_marker
> 2010-10-23T12:22:44Z WARNING: ll_apr_warn_status: APR: No such file or directory
> 2010-10-23T12:22:44Z WARNING: remove: Attempting to remove filename: /home/aleric/.imprudence/logs/Imprudence.llerror_marker
> 2010-10-23T12:22:44Z WARNING: ll_apr_warn_status: APR: No such file or directory
> 2010-10-23T12:22:44Z WARNING: remove: Attempting to remove filename: /home/aleric/.imprudence/logs/Imprudence.error_marker
> 
> This is nonsense since it is perfectly ok when those files don’t exist. 
> 
> 
> This addresses bug VWR-24317.
>     http://jira.secondlife.com/browse/VWR-24317
> 
> 
> Diffs
> -----
> 
>   indra/newview/llappviewer.cpp b0bd26c5638a 
> 
> Diff: http://codereview.secondlife.com/r/83/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleric
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110114/f6b213a1/attachment.htm 


More information about the opensource-dev mailing list