[opensource-dev] Review Request: VWR-13040: LLObjectSelection::valid_root_begin() is really the same as LLObjectSelection::root_begin()

Merov Linden merov at lindenlab.com
Fri Jan 14 14:00:21 PST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/79/#review156
-----------------------------------------------------------


The patch is correct but, grepping the code, I can't see one instance of is_valid_root being used so, that fix is moot. Better maybe to suppress that struct altogether or may be start to use it where adequate (haven't looked at that aspect I need to confess).

- Merov


On Jan. 14, 2011, 12:21 p.m., Aleric Inglewood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/79/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2011, 12:21 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> See https://jira.secondlife.com/browse/VWR-13040
> 
> 
> This addresses bug VWR-13040.
>     http://jira.secondlife.com/browse/VWR-13040
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt b0bd26c5638a 
>   indra/newview/llselectmgr.h b0bd26c5638a 
> 
> Diff: http://codereview.secondlife.com/r/79/diff
> 
> 
> Testing
> -------
> 
> Been using this ever since that jira/patch was created.
> 
> 
> Thanks,
> 
> Aleric
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110114/bba6a7ab/attachment.htm 


More information about the opensource-dev mailing list