[opensource-dev] Review Request: VWR-24315: SNOW-796: Clicking 'Reset to default' in the Debug Settings floater doesn't update cached control values.

[Merov Linden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/82/#review158
-----------------------------------------------------------

Ship it!


Yes, we should fire a signal so the change takes effect immediately.

- Merov


On Jan. 14, 2011, 12:40 p.m., Aleric Inglewood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/82/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2011, 12:40 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> See https://jira.secondlife.com/browse/VWR-24315
> 
> 
> This addresses bug VWR-24315.
>     http://jira.secondlife.com/browse/VWR-24315
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt b0bd26c5638a 
>   indra/newview/llfloatersettingsdebug.cpp b0bd26c5638a 
> 
> Diff: http://codereview.secondlife.com/r/82/diff
> 
> 
> Testing
> -------
> 
> I have some other patch that allows me to move my avatar up and down vertically (by faking it has a different height).
> When I open the Debug Settings floater and change the value with the up/down arrows, the avatar is immediately updated (changes height),
> but resetting the value (to zero) had no effect. With this patch, resetting caused the avatar to immediately change it's height to an Z-offset of zero again, as it should.
> 
> 
> Thanks,
> 
> Aleric
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110114/e5881dfd/attachment.htm