[opensource-dev] Review Request: VWR-24317: Incorrect start up warnings: WARNING: isFeatureAvailable: Feature RenderCubeMap not on feature list!

[Merov Linden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/86/#review160
-----------------------------------------------------------

Ship it!


I'm assuming that this global is indeed not used before the new initialization point.

- Merov


On Jan. 14, 2011, 12:53 p.m., Aleric Inglewood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/86/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2011, 12:53 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Fixes this warning. Note that LLCubeMap::sUseCubeMaps is set to true by
> default, so this patch only has effect when the feature is actually NOT
> available.
> 
> I tested that LLCubeMap::sUseCubeMaps is NOT used before the point where
> it is initialized now.
> 
> 
> This addresses bug VWR-24317.
>     http://jira.secondlife.com/browse/VWR-24317
> 
> 
> Diffs
> -----
> 
>   indra/newview/llappviewer.cpp b0bd26c5638a 
> 
> Diff: http://codereview.secondlife.com/r/86/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleric
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110114/a7369a48/attachment.htm