[opensource-dev] Review Request: VWR-24311: Uninstall packages that are renewed.

[Aleric Inglewood]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/80/
-----------------------------------------------------------

(Updated Jan. 16, 2011, 5:35 a.m.)


Review request for Viewer.


Changes
-------

This new diff addresses Boroondas' list/tuple remark.

I also added a fix to remove empty directories. Before this patch, install.py would only delete (empty) directories that were a part of the path of a deleted file. The problem with that is that if a tar ball contains an empty directory, it is never removed. I ran into this while running new tests. Fully tested (on linux). Thanks to Boroondas for assistance with the python syntax.


Summary
-------

See https://jira.secondlife.com/browse/VWR-24311

Basically, this fixes the TODO comment in install.py but with the difference that we really want to uninstall any old package with the same name, different md5 or not.


This addresses bug VWR-24311.
    http://jira.secondlife.com/browse/VWR-24311


Diffs (updated)
-----

  doc/contributions.txt 422f636c3343 
  scripts/install.py 422f636c3343 

Diff: http://codereview.secondlife.com/r/80/diff


Testing
-------

Loads of testing on linux... Installing new packages now cleanly removes the old one first.


Thanks,

Aleric

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110116/d1300588/attachment.htm