[opensource-dev] Review Request: VWR-24317: Incorrect start up warnings: WARNING: remove: Attempting to remove filename: /ramdisk/imprudence/cache/textures/*/*.texture

[Aleric Inglewood]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/84/
-----------------------------------------------------------

(Updated Jan. 16, 2011, 6:12 a.m.)


Review request for Viewer.


Changes
-------

Renamed the variable to 'file_maybe_exists', which should cover its meaning more accurately, thanks!

Changed the warning into

LL_WARNS("TextureCache") << "Entry has body size of zero but file " << filename << " exists. Deleting this file, too." << LL_ENDL;

The second part is the 'resolution' of the problem. Your proposal sounded a bit too much as if the warning was about the fact that the file was being removed...


Summary
-------

This turned out to be a simple matter of trying to remove non-existant files:
A texture with a 'body size' of 0 doesn't have a texture body file.


This addresses bug VWR-24317.
    http://jira.secondlife.com/browse/VWR-24317


Diffs (updated)
-----

  indra/newview/lltexturecache.cpp b0bd26c5638a 

Diff: http://codereview.secondlife.com/r/84/diff


Testing
-------


Thanks,

Aleric

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110116/559164a5/attachment.htm