[opensource-dev] Review Request: VWR-24317: Fix of debug warning (printing of unassigned variable)

[Oz Linden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/87/#review172
-----------------------------------------------------------



indra/llui/llnotifications.cpp
<http://codereview.secondlife.com/r/87/#comment113>

    I don't like leaving in commented-out code.
    
    I would prefer that this either be changed to a debug level message or deleted.


- Oz


On Jan. 14, 2011, 12:56 p.m., Aleric Inglewood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/87/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2011, 12:56 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Fixed a typo that I stumbled upon and added quotes,
> and changed the warning to print something that makes
> more sense ('replacement' is always empty, since we
> didn't find it!)
> 
> 
> This addresses bug VWR-24317.
>     http://jira.secondlife.com/browse/VWR-24317
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt b0bd26c5638a 
>   indra/llui/llnotifications.cpp b0bd26c5638a 
> 
> Diff: http://codereview.secondlife.com/r/87/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleric
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110117/5703b669/attachment.htm