[opensource-dev] Review Request: VWR-24420: PNG images which specify "background color" lose alpha layer when imported.

[Oz Linden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/74/#review174
-----------------------------------------------------------

Ship it!


- Oz


On Jan. 9, 2011, 6:59 a.m., Thickbrick Sleaford wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/74/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2011, 6:59 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Current code composites RGBA PNG images that contain a bKGD chunk down to RGB, discarding the alpha channel. This patch removes that code, since it contradicts purpose of the bKGD chunk as described in the PNG spec and as commonly used.
> 
> 
> This addresses bug VWR-24420.
>     http://jira.secondlife.com/browse/VWR-24420
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt UNKNOWN 
>   indra/llimage/llpngwrapper.h UNKNOWN 
>   indra/llimage/llpngwrapper.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/74/diff
> 
> 
> Testing
> -------
> 
> Tested uploading the 2 images attached to VWR-24420 with and without the patch. Before patch, "bad alpha.png" was uploaded as RGB, after patch, both images were uploaded as RGBA.
> 
> 
> Thanks,
> 
> Thickbrick
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110117/667deead/attachment.htm