[opensource-dev] Review Request: VWR-24520: Don't use pkg_check_modules( ... QUIET ) on CMake < 2.8.2
Boroondas Gupte
sllists at boroon.dasgupta.ch
Mon Jan 17 10:03:31 PST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/97/
-----------------------------------------------------------
Review request for Viewer.
Summary
-------
Only use QUIET in pkg_check_modules() on CMake >=2.8.2 (where it's supported) rather than already on CMake >=2.8.
This addresses bug VWR-24520.
http://jira.secondlife.com/browse/VWR-24520
Diffs
-----
doc/contributions.txt 9e99b2c8fb28
indra/cmake/FindLLQtWebkit.cmake 9e99b2c8fb28
Diff: http://codereview.secondlife.com/r/97/diff
Testing
-------
Configured (standalone) without a .pgk file for libllqtwebkit on Linux with CMake 2.8.1 and CMake 2.8.3. Output as expected.
Not tested:
* CMake 2.8.2
* system with a .pgk file for libllqtwebkit
* non-standalone
* Mac, Win
Thanks,
Boroondas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110117/9359afa3/attachment.htm
More information about the opensource-dev
mailing list