[opensource-dev] SOCIAL-452 - new size of web profile floater

Hitomi Tiponi hitomi.tiponi at yahoo.co.uk
Tue Jan 18 15:20:19 PST 2011


re: "SOCIAL-452 FIX Default size of Web content floater is wrong - needs to be 
optimized for Web profile display".  I noticed this has been merged across to 
viewer-beta and am worried it is going to be deployed.  If you do I think you 
will face a lot of annoyance over the now very large size of this floater.  
Really it should have been made smaller - not bigger with the width set to match 
the width of the outline profile.




________________________________
From: "opensource-dev-request at lists.secondlife.com" 
<opensource-dev-request at lists.secondlife.com>
To: opensource-dev at lists.secondlife.com
Sent: Wed, 19 January, 2011 2:30:57
Subject: opensource-dev Digest, Vol 12, Issue 59

Send opensource-dev mailing list submissions to
    opensource-dev at lists.secondlife.com

To subscribe or unsubscribe via the World Wide Web, visit
    /index.html
or, via email, send a message with subject or body 'help' to
    opensource-dev-request at lists.secondlife.com

You can reach the person managing the list at
    opensource-dev-owner at lists.secondlife.com

When replying, please edit your Subject line so it is more specific
than "Re: Contents of opensource-dev digest..."


Today's Topics:

   1. Re: Review Request: STORM-2  As a User, I want to set my own
      default views with specific UI layout so I can tailor my Viewer
      experience to the activities I'm most interested in.
      (Vadim ProductEngine)
   2. STORM-243 - simulator version notifications
      (Kent Quirk (Q Linden))
   3. Re: STORM-243 - simulator version notifications (Lance Corrimal)
   4. Re: Review Request: STORM-2 As a User, I want to set my own
      default views with specific UI layout so I can tailor my Viewer
      experience to the activities I'm most interested in.
      (Opensource Obscure)
   5. Review Request: make PREHASH variables char const*    const
      (Boroondas Gupte)
   6. Re: STORM-243 - simulator version notifications (WolfPup Lowenhar)


----------------------------------------------------------------------

Message: 1
Date: Tue, 18 Jan 2011 14:31:11 -0000
From: "Vadim ProductEngine" <vsavchuk at productengine.com>
Subject: Re: [opensource-dev] Review Request: STORM-2  As a User, I
    want to set my own default views with specific UI layout so I can
    tailor my Viewer experience to the activities I'm most interested in.
To: "Vadim ProductEngine" <vsavchuk at productengine.com>,    "Andrew
    ProductEngine" <adyukov at productengine.com>,    "Viewer"
    <opensource-dev at lists.secondlife.com>
Message-ID:
    <20110118143111.25993.91253 at domU-12-31-38-00-90-68.compute-1.internal>
Content-Type: text/plain; charset="utf-8"


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/98/#review181
-----------------------------------------------------------

Ship it!


Looks good, given that this is a first pass implementation.

- Vadim


On Jan. 17, 2011, 1:24 p.m., Andrew ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/98/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2011, 1:24 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> First pass of saving of UI state into files.
> 
> Implemeted saving of floaters and bottombar buttons state into a named layout. 
>This layout is saved on disk into per-user folder. The folder with layout 
>contains LLSD files.
> 
> Currently the following features were implemeted:
> - Saving of bottomtray buttons order and visibility.
> - Saving floaters rect and visibility info (multiple instances of the same 
>floater are supported)
> - Saving of sidetray tabs state (docked/undocked).
> - UI for the feature.
> 
> TODO:
> - Add saving dock state for dockable floaters.
> - Add LL-created default layouts and support for them.
> - Refactor system of updating lists - get rid of ugly static dirty and it's 
>check in draw.
> - Add saving of sidetray open/closed state, open tab, etc.
> 
> 
> This addresses bug STORM-2.
>    http://jira.secondlife.com/browse/STORM-2
> 
> 
> Diffs
> -----
> 
>   indra/llui/llfloater.h 422f636c3343 
>   indra/llui/llfloaterreg.h 422f636c3343 
>   indra/newview/CMakeLists.txt 422f636c3343 
>   indra/newview/llbottomtray.h 422f636c3343 
>   indra/newview/llbottomtray.cpp 422f636c3343 
>   indra/newview/llfloaterlayouts.h PRE-CREATION 
>   indra/newview/llfloaterlayouts.cpp PRE-CREATION 
>   indra/newview/llsidetray.h 422f636c3343 
>   indra/newview/llsidetray.cpp 422f636c3343 
>   indra/newview/llviewerfloaterreg.cpp 422f636c3343 
>   indra/newview/llviewermenu.cpp 422f636c3343 
>   indra/newview/skins/default/xui/en/floater_layouts.xml PRE-CREATION 
>   indra/newview/skins/default/xui/en/floater_save_layout.xml PRE-CREATION 
>   indra/newview/skins/default/xui/en/menu_viewer.xml 422f636c3343 
>   indra/newview/skins/default/xui/en/notifications.xml 422f636c3343 
> 
> Diff: http://codereview.secondlife.com/r/98/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: 
http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110118/ea5e4514/attachment-0001.htm
 

------------------------------

Message: 2
Date: Tue, 18 Jan 2011 10:22:45 -0500
From: "Kent Quirk (Q Linden)" <q at lindenlab.com>
Subject: [opensource-dev] STORM-243 - simulator version notifications
To: OpenSource Mailing List <opensource-dev at lists.secondlife.com>
Message-ID: <5941ED4A-7D5D-4008-9FC9-A68B33EF2A44 at lindenlab.com>
Content-Type: text/plain; charset=us-ascii

Hi, folks. I've just commented on STORM-243, which requests that we have Yet 
Another Option to allow suppression of the toast that tells you the simulator 
version changed when you changed to a new region. 


I think we should delete it entirely. Does anyone care to still get that 
notification, now that there are usually 3 different simulator versions live on 
the grid at any time? I don't mean "I can think of an obscure scenario when 
someone might care." I mean does anyone really need a notification about this, 
or can we just delete it?



------------------------------

Message: 3
Date: Tue, 18 Jan 2011 16:28:21 +0100
From: Lance Corrimal <Lance.Corrimal at eregion.de>
Subject: Re: [opensource-dev] STORM-243 - simulator version
    notifications
To: opensource-dev at lists.secondlife.com
Message-ID: <201101181628.21597.Lance.Corrimal at eregion.de>
Content-Type: Text/Plain;  charset="iso-8859-1"

Am Dienstag, 18. Januar 2011, 16:22:45 schrieb Kent Quirk (Q Linden):
> Hi, folks. I've just commented on STORM-243, which requests that we have
> Yet Another Option to allow suppression of the toast that tells you the
> simulator version changed when you changed to a new region.
> 
> I think we should delete it entirely. Does anyone care to still get that
> notification, now that there are usually 3 different simulator versions
> live on the grid at any time? I don't mean "I can think of an obscure
> scenario when someone might care." I mean does anyone really need a
> notification about this, or can we just delete it?


on the contrary, i'm trying to port a patch from henri beauchamps cool viewer 
that makes that notification more detailed, as in it tells you the version of 
the sim you entered and the version of the sim you left.


bye,
LC



------------------------------

Message: 4
Date: Tue, 18 Jan 2011 16:28:47 +0100
From: Opensource Obscure <opensourceobscure at gmail.com>
Subject: Re: [opensource-dev] Review Request: STORM-2 As a User, I
    want to set my own default views with specific UI layout so I can
    tailor my Viewer experience to the activities I'm most interested in.
To: Vadim ProductEngine <vsavchuk at productengine.com>
Cc: Viewer <opensource-dev at lists.secondlife.com>
Message-ID:
    <AANLkTimKVyLXvKxTJJS8jRErJptMZHQw1t1M_mqENmQM at mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1

Just to say this new feature looks very promising!

A question. The 3rd note says
"the files associated with saved layouts will be LLSD text files, so you can
email or paste layouts into a notecard to share with other users".
(the note also explains why this is not the ideal behaviour ever,
and also why we have to deal with it for now)

This sounds even cooler! ...but - how would that process of
sharing LLSD files exactly work?
I mean, where will users have to put those LLSD files?

here is the scenario I'm thinking about:

- a "teacher" (or mentor, friend, etc) is explaining to a new user
how to build in SL
- the teacher shares with the new user an LLSD file that contains
an ideal layout for building, and says "put this in your SL folder"
- the new user is now confused: many newbies don't know
the difference between the software folder and the settings folder,
and they don't know where those are;
this gets even worst to solve for people trying to help them,
because pathnames are different across different operating systems,
across different releases of the same o.s. - or because of localization.

possible solutions:
- add another option in Preferences to choose the folder where we keep layouts
- add a menu command to choose a specific layout file  - then the viewer
would copy that file into the actual settings folder.

Opensource Obscure


------------------------------

Message: 5
Date: Tue, 18 Jan 2011 15:29:44 -0000
From: "Boroondas Gupte" <sllists at boroon.dasgupta.ch>
Subject: [opensource-dev] Review Request: make PREHASH variables char
    const*    const
To: "Viewer" <opensource-dev at lists.secondlife.com>,    "Boroondas Gupte"
    <sllists at boroon.dasgupta.ch>
Message-ID:
    <20110118152944.26007.14045 at domU-12-31-38-00-90-68.compute-1.internal>
Content-Type: text/plain; charset="utf-8"


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/100/
-----------------------------------------------------------

Review request for Viewer.


Summary
-------

For the reason for this change, see https://jira.secondlife.com/browse/VWR-24487 
and https://jira.secondlife.com/browse/VWR-24522

What I did:
In indra/llmessage/message_prehash.(h|cpp), I turned everything into constant 
pointers to constants by search/replace. Then I tried to compile and added const 
qualifiers in dependent code as needed to stop the compiler complaining.

Note that comments in indra/llmessage/message_prehash.(h|cpp) say these files 
have been generated from the message template. If this generation wasn't a 
one-off thing, the generating code must be changed, too, so it won't override 
this change here when the generation happens the next time.


This addresses bug VWR-24487.
    http://jira.secondlife.com/browse/VWR-24487


Diffs
-----

  doc/contributions.txt fc7e5dcf3059 
  indra/llmessage/message_prehash.h fc7e5dcf3059 
  indra/llmessage/message_prehash.cpp fc7e5dcf3059 
  indra/llprimitive/llprimitive.h fc7e5dcf3059 
  indra/llprimitive/llprimitive.cpp fc7e5dcf3059 
  indra/llprimitive/llvolumemessage.h fc7e5dcf3059 
  indra/llprimitive/llvolumemessage.cpp fc7e5dcf3059 
  indra/llui/tests/llurlentry_stub.cpp fc7e5dcf3059 
  indra/newview/tests/llremoteparcelrequest_test.cpp fc7e5dcf3059 

Diff: http://codereview.secondlife.com/r/100/diff


Testing
-------

Compiled (standalone, 64bit Linux) with and without LL_TESTS.
Started the viewer, logged in, walked and flew around a bit. Everything seems to 
work.


Thanks,

Boroondas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: 
http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110118/f2a2a883/attachment-0001.htm
 

------------------------------

Message: 6
Date: Tue, 18 Jan 2011 10:30:52 -0500
From: "WolfPup Lowenhar" <wolfpup67 at earthlink.net>
Subject: Re: [opensource-dev] STORM-243 - simulator version
    notifications
To: "OpenSource Mailing List" <opensource-dev at lists.secondlife.com>
Message-ID: <000f01cbb724$b13cd250$13b676f0$@net>
Content-Type: text/plain; charset="us-ascii"

Q,

I believe the jira in question was wanting to suppress the popup but not the
notification itself so that it would still show up in chat history if you
were logging it or kept your chat history open all the time.



From: opensource-dev-bounces at lists.secondlife.com
[mailto:opensource-dev-bounces at lists.secondlife.com] On Behalf Of Kent Quirk
(Q Linden)
Sent: Tuesday, January 18, 2011 10:23 AM
To: OpenSource Mailing List
Subject: [opensource-dev] STORM-243 - simulator version notifications



Hi, folks. I've just commented on STORM-243, which requests that we have Yet
Another Option to allow suppression of the toast that tells you the
simulator version changed when you changed to a new region.

I think we should delete it entirely. Does anyone care to still get that
notification, now that there are usually 3 different simulator versions live
on the grid at any time? I don't mean "I can think of an obscure scenario
when someone might care." I mean does anyone really need a notification
about this, or can we just delete it?

_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting
privileges 

  _____  

No virus found in this message.
Checked by AVG - www.avg.com
Version: 10.0.1191 / Virus Database: 1435/3387 - Release Date: 01/17/11

-------------- next part --------------
An HTML attachment was scrubbed...
URL: 
http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110118/3fc61156/attachment.htm
 

------------------------------

_______________________________________________
opensource-dev mailing list
opensource-dev at lists.secondlife.com
/index.html


End of opensource-dev Digest, Vol 12, Issue 59
**********************************************



      
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110118/a704172b/attachment-0001.htm 


More information about the opensource-dev mailing list