[opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

Boroondas Gupte sllists at boroon.dasgupta.ch
Wed Jan 19 14:52:52 PST 2011



> On Jan. 19, 2011, 2:44 p.m., Boroondas Gupte wrote:
> > indra/newview/lltexturecache.cpp, line 1595
> > <http://codereview.secondlife.com/r/90/diff/1/?file=413#file413line1595>
> >
> >     Old code:
> >     validate_idx will now be in [1,256]. (one higher than before)
> >     
> >     New code:
> >     validate_idx will stay in [0,256]. (untouched)
> >     
> >     Old and new code:
> >     next_idx will be in [0,256], but different than the new-code validate_idx (one higher modulo 256).

ok, tripple checked the ranges, but still typed them wrong ... this should be

New code:
validate_idx will stay in [0,255]. (untouched)

Old and new code:
next_idx will be in [0,255], but different than the new-code validate_idx (one higher modulo 256).


> On Jan. 19, 2011, 2:44 p.m., Boroondas Gupte wrote:
> > indra/newview/lltexturecache.cpp, lines 1596-1598
> > <http://codereview.secondlife.com/r/90/diff/1/?file=413#file413line1596>
> >
> >     next_idx (still in the range [0,256]) gets saved to setting. (Thus why the value we get from the setting above must be in that interval.)

make this [0,255], too ^_^


- Boroondas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/90/#review199
-----------------------------------------------------------


On Jan. 14, 2011, 1:02 p.m., Aleric Inglewood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/90/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2011, 1:02 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Trivial patch, just removes stupidity.
> 
> 
> This addresses bug VWR-24321.
>     http://jira.secondlife.com/browse/VWR-24321
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt b0bd26c5638a 
>   indra/newview/lltexturecache.cpp b0bd26c5638a 
> 
> Diff: http://codereview.secondlife.com/r/90/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleric
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110119/ea7a5f03/attachment-0001.htm 


More information about the opensource-dev mailing list