[opensource-dev] Review Request: Help Needed to debug small problem with code for STORM-236.

[Wolfpup Lowenhar]

> On Jan. 20, 2011, 10:45 a.m., Cron Stardust wrote:
> > Looks like you are only preventing the button from drawing and working, but not actually /removing/ it from the tray.  Have you hunted down the code that is used to remove tray buttons when the tray is right-clicked on and an item is checked/unchecked?  I would think that that is the functionality that needs to be copied onto the speak button.
> > 
> > Maybe, as a different JIRA entry and review, you might consider what it would take to add the speak button to that tray context menu.  Once the ability to remove and add the speak button via the context menu is working, it would then seem to me that this entry (STORM-236) would be trivial to implement, as all the core functionality will have been resolved already.  Even if the new entry for the context menu wasn't accepted, the core functionality can still be done here.

This Issue is for having the button hide(not be drawn) and free up the space that it normally take in the bottom tray. The problem I'm having is with the second part getting the space freed up right. Also the context menu is functional so there are no problems there.


- Wolfpup


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/112/#review210
-----------------------------------------------------------


On Jan. 20, 2011, 9:29 a.m., Wolfpup Lowenhar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/112/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2011, 9:29 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> This is actually a request for for help to debug what I have done so far to get this working.
> 1. In the current diff the button dose actualy hide and show according to if Voice is enabled or not.
> 2. i have two problems at this point.
>    a. the space taken up by the speak button is not freed up
>    b. when the speak button is shown after being hidden there is an error message saying no space avaiable
>       (I think this is related to the fact that the space is not freed to begin with).
> 
> 
> This addresses bug STORM-236.
>     http://jira.secondlife.com/browse/STORM-236
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 40d0806e9800 
>   indra/newview/llbottomtray.cpp 40d0806e9800 
>   indra/newview/llspeakbutton.cpp 40d0806e9800 
>   indra/newview/skins/default/xui/en/menu_bottomtray.xml 40d0806e9800 
> 
> Diff: http://codereview.secondlife.com/r/112/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Wolfpup
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110120/2e4bc752/attachment.htm