[opensource-dev] Review Request: STORM-236 Actual Code Review

Wolfpup Lowenhar wolfpup67 at earthlink.net
Thu Jan 20 18:37:18 PST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/113/
-----------------------------------------------------------

Review request for Viewer.


Summary
-------

This allows the Speak Button to auto-hide for those that do not use Voice at all.


This addresses bug STORM-236.
    http://jira.secondlife.com/browse/STORM-236


Diffs
-----

  doc/contributions.txt 9c7d543fd15d 
  indra/newview/llbottomtray.h 9c7d543fd15d 
  indra/newview/llbottomtray.cpp 9c7d543fd15d 
  indra/newview/llspeakbutton.cpp 9c7d543fd15d 
  indra/newview/skins/default/xui/en/menu_bottomtray.xml 9c7d543fd15d 

Diff: http://codereview.secondlife.com/r/113/diff


Testing
-------

Built locally and did the following:
1 Verified that when Voice is toggled via the preference panel the Speak Button auto hid/showed.
2 Verified that drag and drop functionality of the Speak Button was not affected.
3 Went to a non-Voice area with Voice active and verified that button was still there but grayed out.


Thanks,

Wolfpup

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110121/93ec6bd7/attachment-0001.htm 


More information about the opensource-dev mailing list