[opensource-dev] Review Request: VWR-24337: Possible crash on llassert_always(purge_list.size() >= entries_to_purge)

[Merov Linden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/93/#review224
-----------------------------------------------------------



indra/newview/lltexturecache.cpp
<http://codereview.secondlife.com/r/93/#comment154>

    I get it but it's a bit unsettling to have the condition seemingly unrelated to the iterator. I'd rather have a while () construction here so it's more clear what the intent is.


- Merov


On Jan. 14, 2011, 1:09 p.m., Aleric Inglewood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/93/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2011, 1:09 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Just fixed the logic, so entries_to_purge won't become negative anymore, and the rest.
> 
> 
> This addresses bug VWR-24337.
>     http://jira.secondlife.com/browse/VWR-24337
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt b0bd26c5638a 
>   indra/newview/lltexturecache.cpp b0bd26c5638a 
> 
> Diff: http://codereview.secondlife.com/r/93/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleric
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110121/0bd899b4/attachment-0001.htm