[opensource-dev] Review Request: VWR-24337: Possible crash on llassert_always(purge_list.size() >= entries_to_purge)

Merov Linden merov at lindenlab.com
Fri Jan 21 10:14:32 PST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/93/#review237
-----------------------------------------------------------

Ship it!


Better! You may want to reword a bit the comment above the "while()" statement though.

- Merov


On Jan. 21, 2011, 4:25 a.m., Aleric Inglewood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/93/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2011, 4:25 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Just fixed the logic, so entries_to_purge won't become negative anymore, and the rest.
> 
> 
> This addresses bug VWR-24337.
>     http://jira.secondlife.com/browse/VWR-24337
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 422f636c3343 
>   indra/newview/lltexturecache.cpp 422f636c3343 
> 
> Diff: http://codereview.secondlife.com/r/93/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleric
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110121/bc58ec6d/attachment.htm 


More information about the opensource-dev mailing list