[opensource-dev] Review Request: STORM-236 Actual Code Review

[Cron Stardust]

> On Jan. 21, 2011, 3:44 a.m., Boroondas Gupte wrote:
> > indra/newview/skins/default/xui/en/menu_bottomtray.xml, lines 11-13
> > <http://codereview.secondlife.com/r/113/diff/1/?file=620#file620line11>
> >
> >     Begin XML comments with just "<!--" and end them with "-->", not "<!-->" and "<-->".

Typically SGML/XML comments are supposed to start with "<!-- " and end with " -->" (note the post/pre-fixed whitespace) - however, http://www.w3.org/TR/2008/REC-xml-20081126/#sec-comments does not require the space in the syntax, it only demonstrates it.


- Cron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/113/#review229
-----------------------------------------------------------


On Jan. 20, 2011, 6:37 p.m., Wolfpup Lowenhar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/113/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2011, 6:37 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> This allows the Speak Button to auto-hide for those that do not use Voice at all.
> 
> 
> This addresses bug STORM-236.
>     http://jira.secondlife.com/browse/STORM-236
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 9c7d543fd15d 
>   indra/newview/llbottomtray.h 9c7d543fd15d 
>   indra/newview/llbottomtray.cpp 9c7d543fd15d 
>   indra/newview/llspeakbutton.cpp 9c7d543fd15d 
>   indra/newview/skins/default/xui/en/menu_bottomtray.xml 9c7d543fd15d 
> 
> Diff: http://codereview.secondlife.com/r/113/diff
> 
> 
> Testing
> -------
> 
> Built locally and did the following:
> 1 Verified that when Voice is toggled via the preference panel the Speak Button auto hid/showed.
> 2 Verified that drag and drop functionality of the Speak Button was not affected.
> 3 Went to a non-Voice area with Voice active and verified that button was still there but grayed out.
> 
> 
> Thanks,
> 
> Wolfpup
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110121/91b06d4d/attachment.htm