[opensource-dev] Review Request: Provide define LL_MSVC10 to customize Visual Studio 10 code submissions.
Jonathan Yap
jhwelch at gmail.com
Tue Jan 25 03:28:16 PST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/121/#review249
-----------------------------------------------------------
1) You should fill in the Bugs field with a Jira number.
2) Since VS2005 used the 80 code and VS2008 used 90, should you be using LL_MSVC100?
- Jonathan
On Jan. 25, 2011, 2:41 a.m., Nicky Perian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/121/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2011, 2:41 a.m.)
>
>
> Review request for Viewer.
>
>
> Summary
> -------
>
> Need additional eyes on this. My first RB.
>
>
> This addresses bug LL_MSVC10.
> http://jira.secondlife.com/browse/LL_MSVC10
>
>
> Diffs
> -----
>
> indra/llcommon/llpreprocessor.h 26c09ad4293e
>
> Diff: http://codereview.secondlife.com/r/121/diff
>
>
> Testing
> -------
>
> Complied with VS2010. Used with another patch around a microsoft bug. Have not used with VS 2005
>
>
> Thanks,
>
> Nicky
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110125/871ac9b4/attachment.htm
More information about the opensource-dev
mailing list