[opensource-dev] Review Request: VWR-24612 lscript_compile warnings treated as errors -- workaround
Nicky Perian
nickyperian at yahoo.com
Tue Jan 25 11:12:00 PST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/122/
-----------------------------------------------------------
Review request for Viewer.
Summary
-------
Correct marco redefinition warnings introduced in Visual Studio 10. Patch applies workaround documented at:
http://connect.microsoft.com/VisualStudio/feedback/details/621653/including-stdint-after-intsafe-generates-warnings
Depends on vwr-24610 which should be applied first.
This addresses bug vwr-24612.
http://jira.secondlife.com/browse/vwr-24612
Diffs
-----
indra/llcommon/llpreprocessor.h 26c09ad4293e
Diff: http://codereview.secondlife.com/r/122/diff
Testing
-------
Before (snip)
1>C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\include\stdint.h(81): warning C4005: 'UINT32_MAX' : macro redefinition
1> indra.l.cpp(85) : see previous definition of 'UINT32_MAX'
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========
After patch applied:
1>------ Build started: Project: lscript_compile, Configuration: Release Win32 ------
1> lscript_bytecode.cpp
1> lscript_error.cpp
1> lscript_resource.cpp
1> lscript_scope.cpp
1> lscript_tree.cpp
1> lscript_typecheck.cpp
1> indra.y.cpp
1> indra.l.cpp
1> lscript_compile.vcxproj -> C:\lindenhg\vcexpress2010build\indra\build-vc100\lscript\lscript_compile\Release\lscript_compile.lib
========== Build: 1 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========
Thanks,
Nicky
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110125/5d3c481f/attachment.htm
More information about the opensource-dev
mailing list