[opensource-dev] Review Request: STORM-643 mini-map control displayed at top of Nearby people tab

Twisted Laws twisted_laws at hotmail.com
Tue Jan 25 13:51:23 PST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/124/
-----------------------------------------------------------

Review request for Viewer.


Summary
-------

This patch fulfils STORM-643 by putting a copy of the mini-map control into the top of the Nearby tab of the People panel.  Both this and the mini-map can be open at the same time.  While working on this a bug was noticed in the hovertip of the minimap and a solution proposed for that as well although that adds a translation task.  Some of the code from llfloatermap.cpp is actually duplicated here without removing the code from there.  This doesn't have an effect since the control is pushed to the back in llfloatermap.cpp.  The code duplication could be removed from llfloatermap.cpp (the original source) but that may affect something I'm not aware of.


This addresses bug STORM-643.
    http://jira.secondlife.com/browse/STORM-643


Diffs
-----

  indra/newview/llfloatermap.cpp 26c09ad4293e 
  indra/newview/llnetmap.h 26c09ad4293e 
  indra/newview/llnetmap.cpp 26c09ad4293e 
  indra/newview/llpanelpeople.h 26c09ad4293e 
  indra/newview/llpanelpeople.cpp 26c09ad4293e 
  indra/newview/skins/default/xui/en/floater_map.xml 26c09ad4293e 
  indra/newview/skins/default/xui/en/panel_people.xml 26c09ad4293e 

Diff: http://codereview.secondlife.com/r/124/diff


Testing
-------

This patch seems to work fine and tested under by compiling and running under Windows 7.0 (64) and Ubuntu Linux.

Tested by having all combinations of mini-map (existing) open and closed, having the people panel open on all of the different tabs with the only effect on the Nearby tab, and having the panel docked in sidebar and not docked.  The highlighting of avatars that are selected in the avatar list only affect the copy of the mini-map displayed there.


Thanks,

Twisted

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110125/4b6880cc/attachment.htm 


More information about the opensource-dev mailing list