[opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

[Oz Linden]

> On Jan. 28, 2011, 5:51 a.m., Jonathan Yap wrote:
> > autobuild/common.py, line 106
> > <http://codereview.secondlife.com/r/127/diff/1/?file=654#file654line106>
> >
> >     Why send out a warning at this point?  Developers who will never use scp don't benefit from this message.  If scp is needed and is not present having the error sent out later should be sufficient.

I confess to being biased in favor of verbosity.  I'd be ok with changing this so that it only comes out if --verbose or --debug are specified (I'd have to figure out how to do that, but that's ok).


- Oz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/127/#review265
-----------------------------------------------------------


On Jan. 28, 2011, 5:20 a.m., Oz Linden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/127/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2011, 5:20 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> During initialization, if there is no scp or pscp command found then autobuild fails immediately.  This is true whether or not any scp urls need to be used.
> 
> This change modifies the behavior so that a warning is printed if no command is found, but execution proceeds until an scp command is needed, at which time execution fails with an explanatory message.
> 
> This patch can print the warning multiple times - I didn't attempt to suppress the extras.
> 
> 
> Diffs
> -----
> 
>   autobuild/common.py f49808fe3c07 
> 
> Diff: http://codereview.secondlife.com/r/127/diff
> 
> 
> Testing
> -------
> 
> I've tested this locally, simulating the error by temporarily modifying the names of the commands to be found for scp.
> 
> I have not checked it on Windows, where the original problem was found.
> 
> 
> Thanks,
> 
> Oz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110128/9456e73b/attachment.htm