[opensource-dev] Review Request: Use consistent path for all *.py scripts
Merov Linden
merov at lindenlab.com
Mon Jan 31 18:12:19 PST 2011
> On Jan. 31, 2011, 11:47 a.m., Kent Quirk wrote:
> > I would much prefer that we put the /usr/bin/env python form, since env can find whichever python is currently set up, including someone that has it in /usr/local/bin, or wherever they've chosen. Env is more likely to be found in /usr/bin than python is. So I'd like to see this change made the opposite way.
>
> Vadim ProductEngine wrote:
> +1
I'm all for it since everybody seems to agree on this syntax (which is less error prone for 3rd party devs, I agree). Still, as mentioned by Brad in the JIRA, we should revise and dust off the wiki: http://wiki.secondlife.com/wiki/Coding_standard#Python_File_Names. In particular, I don't think we want .pyo or .pyc files around anymore (all the .py files in lindenlab/viewer-development are open source).
- Merov
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/129/#review286
-----------------------------------------------------------
On Jan. 28, 2011, 5:56 p.m., Merov Linden wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/129/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2011, 5:56 p.m.)
>
>
> Review request for Viewer.
>
>
> Summary
> -------
>
> Simple consistency change, using "#!/usr/bin/python" in all python script.
>
>
> This addresses bug STORM-937.
> http://jira.secondlife.com/browse/STORM-937
>
>
> Diffs
> -----
>
> indra/copy_win_scripts/start-client.py b542f8134a2b
> indra/develop.py b542f8134a2b
> indra/lib/python/indra/util/simperf_host_xml_parser.py b542f8134a2b
> indra/lib/python/indra/util/simperf_oprof_interface.py b542f8134a2b
> indra/lib/python/indra/util/test_win32_manifest.py b542f8134a2b
> indra/newview/generate_breakpad_symbols.py b542f8134a2b
> scripts/build_version.py b542f8134a2b
> scripts/install.py b542f8134a2b
>
> Diff: http://codereview.secondlife.com/r/129/diff
>
>
> Testing
> -------
>
> Pulled into a test repo and build successfully on all platforms on TC so I guess no bad surprise here.
>
>
> Thanks,
>
> Merov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110201/1cfd8921/attachment.htm
More information about the opensource-dev
mailing list