From yoz at lindenlab.com Fri Jul 1 01:36:11 2011 From: yoz at lindenlab.com (Yoz Linden) Date: Fri, 1 Jul 2011 01:36:11 -0700 Subject: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields In-Reply-To: <20110630065753.22033.14086@domU-12-31-38-00-90-68.compute-1.internal> References: <20110630065753.22033.14086@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: No review, just gratitude: This is a seriously nifty feature, so thanks for picking up Aimee's work and helping it over the finish line! -- Yoz On Jun 29, 2011, at 11:57 PM, Kadah Coba wrote: > STORM-1315 -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110701/d93dc568/attachment.htm From oz at lindenlab.com Fri Jul 1 03:55:52 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Fri, 01 Jul 2011 06:55:52 -0400 Subject: [opensource-dev] No Viewer Evolution Meeting July 1 Message-ID: <4E0DA7B8.6060104@lindenlab.com> .... taking an extended holiday weekend. See you next week. From sllists at boroon.dasgupta.ch Fri Jul 1 05:14:08 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Fri, 01 Jul 2011 14:14:08 +0200 Subject: [opensource-dev] Shader typo In-Reply-To: <20110628204555.7e755d92.sythos@gmail.com> References: <20110628204555.7e755d92.sythos@gmail.com> Message-ID: <4E0DBA10.4030409@boroon.dasgupta.ch> On 06/28/2011 08:45 PM, Altair Sythos Memo wrote: > SecondLife-i686-2.7.6.233972/app_settings/shaders/class2/deferred/sunlightSSAOMSF.glsl > > should be sunLightSSAOMSF.glsl > > renaming turn ON again shadows Looks like that's already been fixed in b3e5a757f275 a week ago. Can you try whether it's working correctly in recent viewer-development test builds? Cheers, Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110701/d4d33184/attachment-0001.htm From malachi at tamzap.com Fri Jul 1 07:46:05 2011 From: malachi at tamzap.com (malachi at tamzap.com) Date: Fri, 1 Jul 2011 07:46:05 -0700 Subject: [opensource-dev] (no subject) Message-ID: <463c2fc793032ab209c83c9a8c3734aa.squirrel@webmail.lion.arvixe.com> I just tried to compile the viewer 2 source. Following the instructions on the wiki. And have come across a ton of errors. I do not have these errors while building snowglobe or 1.2x viewer source. Any help would be appreciated. Just want to start working on viewer 2 source. Have a bit of free time and would like something to keep me busy. ========== Build: 3 succeeded, 5 failed, 31 up-to-date, 2 skipped ========== Error 1 error MSB6006: "cmd.exe" exited with code 1. C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.targets 151 Error 2 error C2371: 'int_fast16_t' : redefinition; different basic types C:\Program Files (x86)\QuickTime SDK\CIncludes\GNUCompatibility\stdint.h 49 Error 3 error C2371: 'uint_fast16_t' : redefinition; different basic types C:\Program Files (x86)\QuickTime SDK\CIncludes\GNUCompatibility\stdint.h 50 Warning 4 warning C4005: 'INT8_C' : macro redefinition C:\Program Files (x86)\QuickTime SDK\CIncludes\GNUCompatibility\stdint.h 168 Warning 5 warning C4005: 'INT16_C' : macro redefinition C:\Program Files (x86)\QuickTime SDK\CIncludes\GNUCompatibility\stdint.h 169 Warning 6 warning C4005: 'INT32_C' : macro redefinition C:\Program Files (x86)\QuickTime SDK\CIncludes\GNUCompatibility\stdint.h 170 Warning 7 warning C4005: 'INT64_C' : macro redefinition C:\Program Files (x86)\QuickTime SDK\CIncludes\GNUCompatibility\stdint.h 171 Warning 8 warning C4005: 'UINT8_C' : macro redefinition C:\Program Files (x86)\QuickTime SDK\CIncludes\GNUCompatibility\stdint.h 173 Warning 9 warning C4005: 'UINT16_C' : macro redefinition C:\Program Files (x86)\QuickTime SDK\CIncludes\GNUCompatibility\stdint.h 174 Warning 10 warning C4005: 'UINT32_C' : macro redefinition C:\Program Files (x86)\QuickTime SDK\CIncludes\GNUCompatibility\stdint.h 175 Warning 11 warning C4005: 'UINT64_C' : macro redefinition C:\Program Files (x86)\QuickTime SDK\CIncludes\GNUCompatibility\stdint.h 176 Warning 12 warning C4005: 'INTMAX_C' : macro redefinition C:\Program Files (x86)\QuickTime SDK\CIncludes\GNUCompatibility\stdint.h 179 Warning 13 warning C4005: 'UINTMAX_C' : macro redefinition C:\Program Files (x86)\QuickTime SDK\CIncludes\GNUCompatibility\stdint.h 180 Error 14 error MSB6006: "cmd.exe" exited with code 1. C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.targets 151 Error 15 error MSB6006: "cmd.exe" exited with code 1. C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.targets 151 Error 16 error MSB3073: The command ""C:\Program Files (x86)\CMake 2.8\bin\cmake.exe" -E copy C:/v2/build-vc100/llplugin/slplugin/Release/SLPlugin.exe C:/v2/build-vc100/test_apps/llplugintest/Release/ if errorlevel 1 goto :VCEnd "C:\Program Files (x86)\CMake 2.8\bin\cmake.exe" -E copy C:/v2/build-vc100/sharedlibs/Release/llcommon.dll C:/v2/build-vc100/test_apps/llplugintest/Release/ if errorlevel 1 goto :VCEnd "C:\Program Files (x86)\CMake 2.8\bin\cmake.exe" -E copy C:/v2/build-vc100/media_plugins/webkit/Release/media_plugin_webkit.dll C:/v2/build-vc100/test_apps/llplugintest/Release/ if errorlevel 1 goto :VCEnd "C:\Program Files (x86)\CMake 2.8\bin\cmake.exe" -E copy C:/v2/build-vc100/media_plugins/quicktime/Release/media_plugin_quicktime.dll C:/v2/build-vc100/test_apps/llplugintest/Release/ if errorlevel 1 goto :VCEnd "C:\Program Files (x86)\CMake 2.8\bin\cmake.exe" -E copy C:/v2/build-vc100/media_plugins/example/Release/media_plugin_example.dll C:/v2/build-vc100/test_apps/llplugintest/Release/ if errorlevel 1 goto :VCEnd "C:\Program Files (x86)\CMake 2.8\bin\cmake.exe" -E copy C:/v2/indra/test_apps/llplugintest/bookmarks.txt C:/v2/build-vc100/test_apps/llplugintest/ if errorlevel 1 goto :VCEnd "C:\Program Files (x86)\CMake 2.8\bin\cmake.exe" -E copy C:/v2/indra/test_apps/llplugintest/bookmarks.txt C:/v2/build-vc100/test_apps/llplugintest/Release/ if errorlevel 1 goto :VCEnd "C:\Program Files (x86)\CMake 2.8\bin\cmake.exe" -DBIN_NAME="C:/v2/build-vc100/test_apps/llplugintest/Release/llmediaplugintest.exe" -DSEARCH_DIRS="C:/v2/build-vc100/sharedlibs/Release;C:/v2/build-vc100/sharedlibs/Release;C:\Windows/system32" -DDST_PATH="C:/v2/build-vc100/test_apps/llplugintest/Release" -P C:/v2/indra/cmake/DeploySharedLibs.cmake if errorlevel 1 goto :VCEnd :VCEnd" exited with code 1. C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.targets 113 17 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\aeregistry.h 814 18 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\folders.h 192 19 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\folders.h 197 20 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\folders.h 199 21 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\folders.h 200 22 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\folders.h 201 23 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\folders.h 202 24 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\folders.h 204 25 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\folders.h 205 26 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\folders.h 206 27 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\folders.h 209 28 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\folders.h 210 29 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\folders.h 211 30 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\folders.h 213 31 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\folders.h 220 32 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\folders.h 223 33 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\folders.h 228 34 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\folders.h 272 35 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\folders.h 297 36 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\imagecompression.h 4351 37 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 168 38 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 169 39 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 170 40 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 171 41 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 172 42 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 173 43 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 174 44 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 175 45 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 176 46 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 177 47 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 178 48 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 179 49 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 180 50 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 181 51 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 182 52 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 183 53 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 184 54 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 185 55 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 186 56 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 187 57 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 188 58 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 189 59 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 190 60 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 191 61 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 192 62 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 193 63 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 194 64 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 195 65 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 196 66 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 197 67 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 198 68 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\movies.h 199 69 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\icons.h 1106 70 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\icons.h 1110 71 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\icons.h 1115 72 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\icons.h 1121 73 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\icons.h 1122 74 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\icons.h 1123 75 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\icons.h 1125 76 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\icons.h 1126 77 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\icons.h 1128 78 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\icons.h 1130 79 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\icons.h 1135 80 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\icons.h 1136 81 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\icons.h 1137 82 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\icons.h 1145 83 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\icons.h 1146 84 IntelliSense: too many characters in character constant c:\program files (x86)\quicktime sdk\cincludes\icons.h 1147 From lee.ponzu at gmail.com Fri Jul 1 07:49:59 2011 From: lee.ponzu at gmail.com (Lee ponzu) Date: Fri, 1 Jul 2011 10:49:59 -0400 Subject: [opensource-dev] Shameless self-promotion... Message-ID: I sent in an application for a couple of the positions open at Linden Lab. (My real name is Lee Sailer.) If any of you feel inclined to put in a good word for me at HR, please feel free 8-) In fact, if LL has a finders fee for employees who recommend someone, I'd be glad to ay you recommended me. thanks mucho, Lee Sailer Ponzu -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110701/faa6ce89/attachment.htm From sythos at gmail.com Fri Jul 1 09:06:08 2011 From: sythos at gmail.com (Altair Sythos Memo) Date: Fri, 1 Jul 2011 18:06:08 +0200 Subject: [opensource-dev] Shader typo In-Reply-To: <4E0DBA10.4030409@boroon.dasgupta.ch> References: <20110628204555.7e755d92.sythos@gmail.com> <4E0DBA10.4030409@boroon.dasgupta.ch> Message-ID: <20110701180608.9016c0c7.sythos@gmail.com> On Fri, 01 Jul 2011 14:14:08 +0200 Boroondas Gupte wrote: > On 06/28/2011 08:45 PM, Altair Sythos Memo wrote: > > SecondLife-i686-2.7.6.233972/app_settings/shaders/class2/deferred/sunlightSSAOMSF.glsl > > > > should be sunLightSSAOMSF.glsl > > > > renaming turn ON again shadows > Looks like that's already been fixed in b3e5a757f275 > > a week ago. Can you try whether it's working correctly in recent > viewer-development test builds? i'll check asap, btw last night i've seen [COUNT] in prim cpunt edit floater... maybe my version is too old From ima.mechanique at blueyonder.co.uk Fri Jul 1 10:47:58 2011 From: ima.mechanique at blueyonder.co.uk (Ima Mechanique) Date: Fri, 01 Jul 2011 18:47:58 +0100 Subject: [opensource-dev] Compile errors (was: no subject) In-Reply-To: <463c2fc793032ab209c83c9a8c3734aa.squirrel@webmail.lion.arvixe.com> References: <463c2fc793032ab209c83c9a8c3734aa.squirrel@webmail.lion.arvixe.com> Message-ID: <20110701184002.E7A2.5FD3A259@blueyonder.co.uk> > I just tried to compile the viewer 2 source. Following the instructions on > the wiki. And have come across a ton of errors. I do not have these errors > while building snowglobe or 1.2x viewer source. Any help would be > appreciated. Just want to start working on viewer 2 source. Have a bit of > free time and would like something to keep me busy. Which wiki page. There are a few concerned with building on Windows. Some of them are more useful (and more up to date) than others. The one you should be reading is: http://wiki.secondlife.com/wiki/Viewer_2_Microsoft_Windows_Builds it assumes you are setting up from a clean system. So if you're not don't skip steps as that can mess things up if you used different instructions -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk From kf6kjg at gmail.com Fri Jul 1 15:25:25 2011 From: kf6kjg at gmail.com (Ricky) Date: Fri, 1 Jul 2011 15:25:25 -0700 Subject: [opensource-dev] Virtual Destructors Message-ID: Poking around in the llmanip* files working on VWR-25739, I started to get annoyed at the coding inconsistencies between those files. So I started looking at what it would take to make the 3 subclasses (translate, scale, and rotate) consistent, when I tripped across the detail that llmaniptranslate.h has the destructor declared virtual while llmanipscale.h has it declared plainly, and llmaniprotate.h doesn't explicitly declare a destructor. When I looked up some reasons why a destructor should be virtual it seems that it should be virtual when the class is going to be used in a polymorphic way and will have delete called on a pointer to it. IE: // MyClass is a ParentClass ParentClass* p = new MyClass(); destroy p; Apparently this is about the only case for declaring the destructor virtual. (see http://blogs.msdn.com/b/oldnewthing/archive/2004/05/07/127826.aspx and especially http://www.erata.net/programming/virtual-destructors/ ) It also comes with a minor performance hit, but that's outside of scope. It turns out that LLManipScale _is_ being used in such a way in LLToolComp - as are LLManipScale and LLManipRotate: lltoolcomp.h line 92: LLManip* mManip; lltoolcomp.cpp line 194: mManip = new LLManipTranslate(this); lltoolcomp.cpp line 203: delete mManip; lltoolcomp.cpp line 321: mManip = new LLManipScale(this); lltoolcomp.cpp line 330: delete mManip; lltoolcomp.cpp line 520: mManip = new LLManipRotate(this); lltoolcomp.cpp line 530: delete mManip; So it looks like to me that there might be a memory leak in the scale and rotate classes, as their destructors might NOT be being called. Of course, Translate's destructor has only an empty definition, and Rotate doesn't even have one, but Scale does have a full-on destructor. And because it is not virtual, it might not be being called. Looking over the history of the files gives me the following: The Rotate destructor was last touched by Steven Bennets on 2008-03-11 in rev 341 - when LLLinkedList was culled in favor of another technique. The Translate destructor was emptied by James Cook on 2009-12-10 in rev 4496 - switched to a std::vector The Scale destructor seems to have never existed in revision history. Anyone with more familiarity with C++'s nuances in such cases have any thoughts/suggestions? Ricky Cron Stardust From kf6kjg at gmail.com Fri Jul 1 16:02:15 2011 From: kf6kjg at gmail.com (Ricky) Date: Fri, 1 Jul 2011 16:02:15 -0700 Subject: [opensource-dev] Virtual Destructors In-Reply-To: References: Message-ID: Looks like the destructors might only be called at program termination, so this may not be a big problem anyway. However it IS inconsistent and weird. And I have it within reach to clean up if it seems good to do so. Ricky Cron Stardust On Fri, Jul 1, 2011 at 3:25 PM, Ricky wrote: > Poking around in the llmanip* files working on VWR-25739, I started to > get annoyed at the coding inconsistencies between those files. ?So I > started looking at what it would take to make the 3 subclasses > (translate, scale, and rotate) consistent, when I tripped across the > detail that llmaniptranslate.h has the destructor declared virtual > while llmanipscale.h has it declared plainly, and llmaniprotate.h > doesn't explicitly declare a destructor. > > When I looked up some reasons why a destructor should be virtual it > seems that it should be virtual when the class is going to be used in > a polymorphic way and will have delete called on a pointer to it. ?IE: > // MyClass is a ParentClass > ParentClass* p = new MyClass(); > destroy p; > > Apparently this is about the only case for declaring the destructor > virtual. (see http://blogs.msdn.com/b/oldnewthing/archive/2004/05/07/127826.aspx > and especially http://www.erata.net/programming/virtual-destructors/ ) > ?It also comes with a minor performance hit, but that's outside of > scope. > > It turns out that LLManipScale _is_ being used in such a way in > LLToolComp - as are LLManipScale and LLManipRotate: > lltoolcomp.h line 92: LLManip* mManip; > lltoolcomp.cpp line 194: mManip = new LLManipTranslate(this); > lltoolcomp.cpp line 203: delete mManip; > lltoolcomp.cpp line 321: mManip = new LLManipScale(this); > lltoolcomp.cpp line 330: delete mManip; > lltoolcomp.cpp line 520: mManip = new LLManipRotate(this); > lltoolcomp.cpp line 530: delete mManip; > > So it looks like to me that there might be a memory leak in the scale > and rotate classes, as their destructors might NOT be being called. > Of course, Translate's destructor has only an empty definition, and > Rotate doesn't even have one, but Scale does have a full-on > destructor. ?And because it is not virtual, it might not be being > called. > > Looking over the history of the files gives me the following: > The Rotate destructor was last touched by Steven Bennets on 2008-03-11 > in rev 341 - when LLLinkedList was culled in favor of another > technique. > The Translate destructor was emptied by James Cook on 2009-12-10 in > rev 4496 - switched to a std::vector > The Scale destructor seems to have never existed in revision history. > > Anyone with more familiarity with C++'s nuances in such cases have any > thoughts/suggestions? > > Ricky > Cron Stardust > From josh at lindenlab.com Fri Jul 1 16:08:45 2011 From: josh at lindenlab.com (Joshua Bell) Date: Fri, 1 Jul 2011 16:08:45 -0700 Subject: [opensource-dev] Virtual Destructors In-Reply-To: References: Message-ID: Destructors of derived classes are automatically virtual if the base class destructor is virtual. http://www.parashift.com/c++-faq-lite/virtual-functions.html#faq-20.7 The inheritance chain is: LLMouseHandler > LLTool > LLManip > LLManipScale ... and both LLMouseHandler and LLTool declare the destructor as virtual. It wouldn't hurt to explicitly mark ~LLManip and ~LLManipScale as virtual for clarity in the code, but it won't actually change anything. On Fri, Jul 1, 2011 at 4:02 PM, Ricky wrote: > Looks like the destructors might only be called at program > termination, so this may not be a big problem anyway. However it IS > inconsistent and weird. And I have it within reach to clean up if it > seems good to do so. > > Ricky > Cron Stardust > > On Fri, Jul 1, 2011 at 3:25 PM, Ricky wrote: > > Poking around in the llmanip* files working on VWR-25739, I started to > > get annoyed at the coding inconsistencies between those files. So I > > started looking at what it would take to make the 3 subclasses > > (translate, scale, and rotate) consistent, when I tripped across the > > detail that llmaniptranslate.h has the destructor declared virtual > > while llmanipscale.h has it declared plainly, and llmaniprotate.h > > doesn't explicitly declare a destructor. > > > > When I looked up some reasons why a destructor should be virtual it > > seems that it should be virtual when the class is going to be used in > > a polymorphic way and will have delete called on a pointer to it. IE: > > // MyClass is a ParentClass > > ParentClass* p = new MyClass(); > > destroy p; > > > > Apparently this is about the only case for declaring the destructor > > virtual. (see > http://blogs.msdn.com/b/oldnewthing/archive/2004/05/07/127826.aspx > > and especially http://www.erata.net/programming/virtual-destructors/ ) > > It also comes with a minor performance hit, but that's outside of > > scope. > > > > It turns out that LLManipScale _is_ being used in such a way in > > LLToolComp - as are LLManipScale and LLManipRotate: > > lltoolcomp.h line 92: LLManip* mManip; > > lltoolcomp.cpp line 194: mManip = new LLManipTranslate(this); > > lltoolcomp.cpp line 203: delete mManip; > > lltoolcomp.cpp line 321: mManip = new LLManipScale(this); > > lltoolcomp.cpp line 330: delete mManip; > > lltoolcomp.cpp line 520: mManip = new LLManipRotate(this); > > lltoolcomp.cpp line 530: delete mManip; > > > > So it looks like to me that there might be a memory leak in the scale > > and rotate classes, as their destructors might NOT be being called. > > Of course, Translate's destructor has only an empty definition, and > > Rotate doesn't even have one, but Scale does have a full-on > > destructor. And because it is not virtual, it might not be being > > called. > > > > Looking over the history of the files gives me the following: > > The Rotate destructor was last touched by Steven Bennets on 2008-03-11 > > in rev 341 - when LLLinkedList was culled in favor of another > > technique. > > The Translate destructor was emptied by James Cook on 2009-12-10 in > > rev 4496 - switched to a std::vector > > The Scale destructor seems to have never existed in revision history. > > > > Anyone with more familiarity with C++'s nuances in such cases have any > > thoughts/suggestions? > > > > Ricky > > Cron Stardust > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110701/e9c58729/attachment.htm From kf6kjg at gmail.com Fri Jul 1 16:22:11 2011 From: kf6kjg at gmail.com (Ricky) Date: Fri, 1 Jul 2011 16:22:11 -0700 Subject: [opensource-dev] Virtual Destructors In-Reply-To: References: Message-ID: Thanks Josh! That's good to know, and thanks for the link. While I've gotten used to a fair number of languages, C++ has a LOT of territory filled with dark corners and pits. So I try to proceed cautiously. :D Ricky Cron Stardust On Fri, Jul 1, 2011 at 4:08 PM, Joshua Bell wrote: > Destructors of derived classes are automatically virtual if the base class > destructor is virtual. > http://www.parashift.com/c++-faq-lite/virtual-functions.html#faq-20.7 > The inheritance chain is: > LLMouseHandler >?LLTool >?LLManip >?LLManipScale > ... and both LLMouseHandler and LLTool declare the destructor as virtual. > It wouldn't hurt to explicitly mark ~LLManip and ~LLManipScale as virtual > for clarity in the code, but it won't actually change anything. > On Fri, Jul 1, 2011 at 4:02 PM, Ricky wrote: >> >> Looks like the destructors might only be called at program >> termination, so this may not be a big problem anyway. ?However it IS >> inconsistent and weird. ?And I have it within reach to clean up if it >> seems good to do so. >> >> Ricky >> Cron Stardust >> >> On Fri, Jul 1, 2011 at 3:25 PM, Ricky wrote: >> > Poking around in the llmanip* files working on VWR-25739, I started to >> > get annoyed at the coding inconsistencies between those files. ?So I >> > started looking at what it would take to make the 3 subclasses >> > (translate, scale, and rotate) consistent, when I tripped across the >> > detail that llmaniptranslate.h has the destructor declared virtual >> > while llmanipscale.h has it declared plainly, and llmaniprotate.h >> > doesn't explicitly declare a destructor. >> > >> > When I looked up some reasons why a destructor should be virtual it >> > seems that it should be virtual when the class is going to be used in >> > a polymorphic way and will have delete called on a pointer to it. ?IE: >> > // MyClass is a ParentClass >> > ParentClass* p = new MyClass(); >> > destroy p; >> > >> > Apparently this is about the only case for declaring the destructor >> > virtual. (see >> > http://blogs.msdn.com/b/oldnewthing/archive/2004/05/07/127826.aspx >> > and especially http://www.erata.net/programming/virtual-destructors/ ) >> > ?It also comes with a minor performance hit, but that's outside of >> > scope. >> > >> > It turns out that LLManipScale _is_ being used in such a way in >> > LLToolComp - as are LLManipScale and LLManipRotate: >> > lltoolcomp.h line 92: LLManip* mManip; >> > lltoolcomp.cpp line 194: mManip = new LLManipTranslate(this); >> > lltoolcomp.cpp line 203: delete mManip; >> > lltoolcomp.cpp line 321: mManip = new LLManipScale(this); >> > lltoolcomp.cpp line 330: delete mManip; >> > lltoolcomp.cpp line 520: mManip = new LLManipRotate(this); >> > lltoolcomp.cpp line 530: delete mManip; >> > >> > So it looks like to me that there might be a memory leak in the scale >> > and rotate classes, as their destructors might NOT be being called. >> > Of course, Translate's destructor has only an empty definition, and >> > Rotate doesn't even have one, but Scale does have a full-on >> > destructor. ?And because it is not virtual, it might not be being >> > called. >> > >> > Looking over the history of the files gives me the following: >> > The Rotate destructor was last touched by Steven Bennets on 2008-03-11 >> > in rev 341 - when LLLinkedList was culled in favor of another >> > technique. >> > The Translate destructor was emptied by James Cook on 2009-12-10 in >> > rev 4496 - switched to a std::vector >> > The Scale destructor seems to have never existed in revision history. >> > >> > Anyone with more familiarity with C++'s nuances in such cases have any >> > thoughts/suggestions? >> > >> > Ricky >> > Cron Stardust >> > >> _______________________________________________ >> Policies and (un)subscribe information available here: >> http://wiki.secondlife.com/wiki/OpenSource-Dev >> Please read the policies before posting to keep unmoderated posting >> privileges > > From kadah.coba at gmail.com Fri Jul 1 17:25:30 2011 From: kadah.coba at gmail.com (Kadah Coba) Date: Sat, 02 Jul 2011 00:25:30 -0000 Subject: [opensource-dev] Review Request: Searching in the world map clears the destination arrow but not the destination beacon Message-ID: <20110702002530.22032.86122@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/379/ ----------------------------------------------------------- Review request for Viewer. Summary ------- A single line change to more completely clear the tracking beacon when text is entered in to the world map's search field. https://bitbucket.org/Kadah_Coba/vwr-25753 This addresses bug VWR-25753. http://jira.secondlife.com/browse/VWR-25753 Diffs ----- indra/newview/llfloaterworldmap.cpp c7a4b7a24e05 Diff: http://codereview.secondlife.com/r/379/diff Testing ------- Built and ran, world map's search field fallowed the expected behavior described in VWR-25753. Thanks, Kadah -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110702/43df3d71/attachment.htm From kadah.coba at gmail.com Sat Jul 2 22:21:02 2011 From: kadah.coba at gmail.com (Kadah Coba) Date: Sun, 03 Jul 2011 05:21:02 -0000 Subject: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields In-Reply-To: <20110630205022.23142.72943@domU-12-31-38-00-90-68.compute-1.internal> References: <20110630205022.23142.72943@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110703052102.16595.74348@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/377/ ----------------------------------------------------------- (Updated July 2, 2011, 10:21 p.m.) Review request for Viewer. Changes ------- Added the missing clears for the texture variables on no selection Summary ------- This is a direct adaptation of Aimee Trescothick's contributed patch from STORM-1315 for v-d. Adjustments were made where needed to make it work with the newer boost and llui code. Some changes were made to the variable names it uses on build; ie "PX" for x position instead of just "X". Patch allows for imputing simple math equations in to the spinner controls. On the build floater a series of variable names are available for using the objects current values in equations, like "sx+3" will take the current X scale and add 3. Repo: https://bitbucket.org/Kadah_Coba/storm-1315 Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370 This addresses bug STORM-1315. http://jira.secondlife.com/browse/STORM-1315 Diffs (updated) ----- indra/newview/llpanelobject.cpp 353807ed6a69 indra/newview/llpanelface.cpp 353807ed6a69 indra/newview/llappviewer.cpp 353807ed6a69 indra/llui/llspinctrl.cpp 353807ed6a69 indra/llui/lllineeditor.cpp 353807ed6a69 indra/llmath/llcalcparser.cpp PRE-CREATION indra/llui/lllineeditor.h 353807ed6a69 doc/contributions.txt 353807ed6a69 indra/llmath/CMakeLists.txt 353807ed6a69 indra/llmath/llcalc.h PRE-CREATION indra/llmath/llcalc.cpp PRE-CREATION indra/llmath/llcalcparser.h PRE-CREATION Diff: http://codereview.secondlife.com/r/377/diff Testing ------- Built and ran. Some testing done with simple equations on the build tools floater to edit an object, no issues were observed. Thanks, Kadah -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110703/6a66bf80/attachment.htm From opensourceobscure at gmail.com Sun Jul 3 13:26:00 2011 From: opensourceobscure at gmail.com (Opensource Obscure) Date: Sun, 3 Jul 2011 22:26:00 +0200 Subject: [opensource-dev] Shader typo In-Reply-To: <20110701180608.9016c0c7.sythos@gmail.com> References: <20110628204555.7e755d92.sythos@gmail.com> <4E0DBA10.4030409@boroon.dasgupta.ch> <20110701180608.9016c0c7.sythos@gmail.com> Message-ID: On Fri, Jul 1, 2011 at 18:06, Altair Sythos wrote: > On Fri, 01 Jul 2011 14:14:08 +0200 > Boroondas Gupte wrote: > >> On 06/28/2011 08:45 PM, Altair Sythos Memo wrote: >> > SecondLife-i686-2.7.6.233972/app_settings/shaders/class2/deferred/sunlightSSAOMSF.glsl >> > >> > should be sunLightSSAOMSF.glsl >> > >> > renaming turn ON again shadows >> Looks like that's already been fixed in b3e5a757f275 >> >> a week ago. Can you try whether it's working correctly in recent >> viewer-development test builds? > > i'll check asap, btw last night i've seen [COUNT] in prim cpunt edit > floater... maybe my version is too old Seems to be fixed in latest Linux viewer-development. Shadows work on Second Life 2.7.6 (234497) Jul 1 2011 01:33:10 while they were broken on Second Life 2.7.6 (234127) Jun 28 2011 18:35:42 bye Opensource Obscure -- http://twitter.com/oobscure - http://opensourceobscure.com/lol discuss Second Life Viewer 2: http://j.mp/slv2group From hyang.zhao at gmail.com Sun Jul 3 22:50:57 2011 From: hyang.zhao at gmail.com (Hyang Zhao) Date: Mon, 4 Jul 2011 09:50:57 +0400 Subject: [opensource-dev] Basic Shaders and FPS In-Reply-To: <1309374669.97334.YahooMailRC@web23903.mail.ird.yahoo.com> References: <1309374669.97334.YahooMailRC@web23903.mail.ird.yahoo.com> Message-ID: on same mac pro with radeon 5770, all shaders on Second Life 2.7.6 (234377) 75 fps with one avatar, 52-60 fps with 2 avatars in view, drops down to about 20 depends of how much avies around, eventually crashing, depends of how fast memory corruption going. Second Life 2.7.6 (234497) 15 fps with 1 avatar (own) and when about 2-3 and more avies around drops down to 2 fps and then coming nice hang or when we switching shaders off also crashing eventually. usual errors all the same and i guess Bao working on this bug currently llrender/llvertexbuffer.cpp(1082) : error ERROR: mapVertexBuffer: memory allocation for vertex data failed. newview/llappviewer.cpp(1401) : error ERROR: mainLoop: Bad memory allocation in LLAppViewer::mainLoop()! WARNING: log_glerror: GL Error: 1285 GL Error String: out of memory INFO: mapVertexBuffer: Available physical mwmory(KB): 4294967295 INFO: mapVertexBuffer: Available virtual memory(KB): 4294967295 llrender/llvertexbuffer.cpp(1082) : error ERROR: mapVertexBuffer: memory allocation for vertex data failed. but regardless of those errors above, i wonder why after fixing transparency bug we getting that fps drop. On 29.06.2011, at 23:11, Hitomi Tiponi wrote: > > That is why there are the Low-Medium-High-Ultra settings - so that people don't need to know about shaders, just that sliding the slider right makes things look better but slower. The individual settings for each standard setting (e.g. Low) could be debated, but the approach seems to work pretty well. And it is not just shaders that make a big difference - LOD and Draw Distance also have a big effect. > > >I was messing with my oldish iMac (ATI 2600 Pro) and I discovered that the > > main thing that makes all the difference to FPS is the shaders. > ... > >So, this made me crave a custom button for turning shaders on and off (yeah, > >CMD-P/Graphics/Basic Shader is easy. Just thinking of all the people who > >don't even know that preferences exists 8-) Need FPS? <>. > >Want things to look better? <> Easy peasy. > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110704/2ae82911/attachment.htm From stickman at gmail.com Mon Jul 4 03:55:50 2011 From: stickman at gmail.com (Stickman) Date: Mon, 4 Jul 2011 03:55:50 -0700 Subject: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields In-Reply-To: <20110703052102.16595.74348@domU-12-31-38-00-90-68.compute-1.internal> References: <20110630205022.23142.72943@domU-12-31-38-00-90-68.compute-1.internal> <20110703052102.16595.74348@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: > This is a direct adaptation of Aimee Trescothick's contributed patch from STORM-1315 for v-d. Adjustments were made where needed to make it work with the newer boost and llui code. Some changes were made to the variable names it uses on build; ie "PX" for x position instead of just "X". > > Will there be a tooltip that explains this? At the very least, will it be documented somewhere (like on the wiki)? This sounds useful, and like something I would want to use. But if I forget the "magic letters," even though they seem very straightforward, the feature disappears. Stickman -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110704/1bf440ea/attachment.htm From vsavchuk at productengine.com Mon Jul 4 13:01:00 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Mon, 04 Jul 2011 20:01:00 -0000 Subject: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields In-Reply-To: <20110703052102.16595.74348@domU-12-31-38-00-90-68.compute-1.internal> References: <20110703052102.16595.74348@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110704200100.16590.27537@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/377/#review836 ----------------------------------------------------------- Ship it! Looks good code-wise. indra/llmath/llcalc.cpp Why allocate dynamically? indra/llui/llspinctrl.cpp I'd add a note that we don't prevalidate because of the calculator. indra/llui/llspinctrl.cpp dead code - Vadim On July 2, 2011, 10:21 p.m., Kadah Coba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/377/ > ----------------------------------------------------------- > > (Updated July 2, 2011, 10:21 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > This is a direct adaptation of Aimee Trescothick's contributed patch from STORM-1315 for v-d. Adjustments were made where needed to make it work with the newer boost and llui code. Some changes were made to the variable names it uses on build; ie "PX" for x position instead of just "X". > > Patch allows for imputing simple math equations in to the spinner controls. On the build floater a series of variable names are available for using the objects current values in equations, like "sx+3" will take the current X scale and add 3. > > Repo: https://bitbucket.org/Kadah_Coba/storm-1315 > Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370 > > > This addresses bug STORM-1315. > http://jira.secondlife.com/browse/STORM-1315 > > > Diffs > ----- > > indra/newview/llpanelobject.cpp 353807ed6a69 > indra/newview/llpanelface.cpp 353807ed6a69 > indra/newview/llappviewer.cpp 353807ed6a69 > indra/llui/llspinctrl.cpp 353807ed6a69 > indra/llui/lllineeditor.cpp 353807ed6a69 > indra/llmath/llcalcparser.cpp PRE-CREATION > indra/llui/lllineeditor.h 353807ed6a69 > doc/contributions.txt 353807ed6a69 > indra/llmath/CMakeLists.txt 353807ed6a69 > indra/llmath/llcalc.h PRE-CREATION > indra/llmath/llcalc.cpp PRE-CREATION > indra/llmath/llcalcparser.h PRE-CREATION > > Diff: http://codereview.secondlife.com/r/377/diff > > > Testing > ------- > > Built and ran. Some testing done with simple equations on the build tools floater to edit an object, no issues were observed. > > > Thanks, > > Kadah > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110704/3afa6cd8/attachment.htm From vsavchuk at productengine.com Mon Jul 4 13:02:05 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Mon, 04 Jul 2011 20:02:05 -0000 Subject: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields In-Reply-To: <20110704200100.16590.27537@domU-12-31-38-00-90-68.compute-1.internal> References: <20110704200100.16590.27537@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110704200205.16724.44758@domU-12-31-38-00-90-68.compute-1.internal> > On July 4, 2011, 1:01 p.m., Vadim ProductEngine wrote: > > indra/llui/llspinctrl.cpp, line 127 > > > > > > I'd add a note that we don't prevalidate because of the calculator. Oops. Ignore this comment. - Vadim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/377/#review836 ----------------------------------------------------------- On July 2, 2011, 10:21 p.m., Kadah Coba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/377/ > ----------------------------------------------------------- > > (Updated July 2, 2011, 10:21 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > This is a direct adaptation of Aimee Trescothick's contributed patch from STORM-1315 for v-d. Adjustments were made where needed to make it work with the newer boost and llui code. Some changes were made to the variable names it uses on build; ie "PX" for x position instead of just "X". > > Patch allows for imputing simple math equations in to the spinner controls. On the build floater a series of variable names are available for using the objects current values in equations, like "sx+3" will take the current X scale and add 3. > > Repo: https://bitbucket.org/Kadah_Coba/storm-1315 > Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370 > > > This addresses bug STORM-1315. > http://jira.secondlife.com/browse/STORM-1315 > > > Diffs > ----- > > indra/newview/llpanelobject.cpp 353807ed6a69 > indra/newview/llpanelface.cpp 353807ed6a69 > indra/newview/llappviewer.cpp 353807ed6a69 > indra/llui/llspinctrl.cpp 353807ed6a69 > indra/llui/lllineeditor.cpp 353807ed6a69 > indra/llmath/llcalcparser.cpp PRE-CREATION > indra/llui/lllineeditor.h 353807ed6a69 > doc/contributions.txt 353807ed6a69 > indra/llmath/CMakeLists.txt 353807ed6a69 > indra/llmath/llcalc.h PRE-CREATION > indra/llmath/llcalc.cpp PRE-CREATION > indra/llmath/llcalcparser.h PRE-CREATION > > Diff: http://codereview.secondlife.com/r/377/diff > > > Testing > ------- > > Built and ran. Some testing done with simple equations on the build tools floater to edit an object, no issues were observed. > > > Thanks, > > Kadah > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110704/81cbecda/attachment-0001.htm From kadah.coba at gmail.com Mon Jul 4 13:06:34 2011 From: kadah.coba at gmail.com (Kadah Coba) Date: Mon, 04 Jul 2011 20:06:34 -0000 Subject: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields In-Reply-To: <20110704200100.16590.27537@domU-12-31-38-00-90-68.compute-1.internal> References: <20110704200100.16590.27537@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110704200634.16596.21370@domU-12-31-38-00-90-68.compute-1.internal> > On July 4, 2011, 1:01 p.m., Vadim ProductEngine wrote: > > indra/llmath/llcalc.cpp, lines 58-59 > > > > > > Why allocate dynamically? I'm not sure, there's a lot of c++ voodoo going on in the original patch. > On July 4, 2011, 1:01 p.m., Vadim ProductEngine wrote: > > indra/llui/llspinctrl.cpp, lines 128-135 > > > > > > dead code Remove? - Kadah ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/377/#review836 ----------------------------------------------------------- On July 2, 2011, 10:21 p.m., Kadah Coba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/377/ > ----------------------------------------------------------- > > (Updated July 2, 2011, 10:21 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > This is a direct adaptation of Aimee Trescothick's contributed patch from STORM-1315 for v-d. Adjustments were made where needed to make it work with the newer boost and llui code. Some changes were made to the variable names it uses on build; ie "PX" for x position instead of just "X". > > Patch allows for imputing simple math equations in to the spinner controls. On the build floater a series of variable names are available for using the objects current values in equations, like "sx+3" will take the current X scale and add 3. > > Repo: https://bitbucket.org/Kadah_Coba/storm-1315 > Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370 > > > This addresses bug STORM-1315. > http://jira.secondlife.com/browse/STORM-1315 > > > Diffs > ----- > > indra/newview/llpanelobject.cpp 353807ed6a69 > indra/newview/llpanelface.cpp 353807ed6a69 > indra/newview/llappviewer.cpp 353807ed6a69 > indra/llui/llspinctrl.cpp 353807ed6a69 > indra/llui/lllineeditor.cpp 353807ed6a69 > indra/llmath/llcalcparser.cpp PRE-CREATION > indra/llui/lllineeditor.h 353807ed6a69 > doc/contributions.txt 353807ed6a69 > indra/llmath/CMakeLists.txt 353807ed6a69 > indra/llmath/llcalc.h PRE-CREATION > indra/llmath/llcalc.cpp PRE-CREATION > indra/llmath/llcalcparser.h PRE-CREATION > > Diff: http://codereview.secondlife.com/r/377/diff > > > Testing > ------- > > Built and ran. Some testing done with simple equations on the build tools floater to edit an object, no issues were observed. > > > Thanks, > > Kadah > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110704/7b2c6032/attachment.htm From vsavchuk at productengine.com Mon Jul 4 13:54:56 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Mon, 04 Jul 2011 20:54:56 -0000 Subject: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields In-Reply-To: <20110704200100.16590.27537@domU-12-31-38-00-90-68.compute-1.internal> References: <20110704200100.16590.27537@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110704205456.16591.72925@domU-12-31-38-00-90-68.compute-1.internal> > On July 4, 2011, 1:01 p.m., Vadim ProductEngine wrote: > > indra/llui/llspinctrl.cpp, lines 128-135 > > > > > > dead code > > Kadah Coba wrote: > Remove? Yes, our coding standard explicitly requires not to leave dead code. > On July 4, 2011, 1:01 p.m., Vadim ProductEngine wrote: > > indra/llmath/llcalc.cpp, lines 58-59 > > > > > > Why allocate dynamically? > > Kadah Coba wrote: > I'm not sure, there's a lot of c++ voodoo going on in the original patch. I think dynamic allocation is redundant here, i.e. I'd convert the members to non-pointers and pass their addresses to the parser. - Vadim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/377/#review836 ----------------------------------------------------------- On July 2, 2011, 10:21 p.m., Kadah Coba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/377/ > ----------------------------------------------------------- > > (Updated July 2, 2011, 10:21 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > This is a direct adaptation of Aimee Trescothick's contributed patch from STORM-1315 for v-d. Adjustments were made where needed to make it work with the newer boost and llui code. Some changes were made to the variable names it uses on build; ie "PX" for x position instead of just "X". > > Patch allows for imputing simple math equations in to the spinner controls. On the build floater a series of variable names are available for using the objects current values in equations, like "sx+3" will take the current X scale and add 3. > > Repo: https://bitbucket.org/Kadah_Coba/storm-1315 > Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370 > > > This addresses bug STORM-1315. > http://jira.secondlife.com/browse/STORM-1315 > > > Diffs > ----- > > indra/newview/llpanelobject.cpp 353807ed6a69 > indra/newview/llpanelface.cpp 353807ed6a69 > indra/newview/llappviewer.cpp 353807ed6a69 > indra/llui/llspinctrl.cpp 353807ed6a69 > indra/llui/lllineeditor.cpp 353807ed6a69 > indra/llmath/llcalcparser.cpp PRE-CREATION > indra/llui/lllineeditor.h 353807ed6a69 > doc/contributions.txt 353807ed6a69 > indra/llmath/CMakeLists.txt 353807ed6a69 > indra/llmath/llcalc.h PRE-CREATION > indra/llmath/llcalc.cpp PRE-CREATION > indra/llmath/llcalcparser.h PRE-CREATION > > Diff: http://codereview.secondlife.com/r/377/diff > > > Testing > ------- > > Built and ran. Some testing done with simple equations on the build tools floater to edit an object, no issues were observed. > > > Thanks, > > Kadah > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110704/7b7374ae/attachment-0001.htm From vsavchuk at productengine.com Mon Jul 4 14:04:45 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Mon, 04 Jul 2011 21:04:45 -0000 Subject: [opensource-dev] Review Request: Searching in the world map clears the destination arrow but not the destination beacon In-Reply-To: <20110702002530.22032.86122@domU-12-31-38-00-90-68.compute-1.internal> References: <20110702002530.22032.86122@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110704210445.16919.68968@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/379/#review840 ----------------------------------------------------------- Ship it! - Vadim On July 1, 2011, 5:25 p.m., Kadah Coba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/379/ > ----------------------------------------------------------- > > (Updated July 1, 2011, 5:25 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > A single line change to more completely clear the tracking beacon when text is entered in to the world map's search field. > > https://bitbucket.org/Kadah_Coba/vwr-25753 > > > This addresses bug VWR-25753. > http://jira.secondlife.com/browse/VWR-25753 > > > Diffs > ----- > > indra/newview/llfloaterworldmap.cpp c7a4b7a24e05 > > Diff: http://codereview.secondlife.com/r/379/diff > > > Testing > ------- > > Built and ran, world map's search field fallowed the expected behavior described in VWR-25753. > > > Thanks, > > Kadah > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110704/4995ddcc/attachment.htm From kadah.coba at gmail.com Mon Jul 4 14:22:38 2011 From: kadah.coba at gmail.com (Kadah Coba) Date: Mon, 04 Jul 2011 21:22:38 -0000 Subject: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields In-Reply-To: <20110703052102.16595.74348@domU-12-31-38-00-90-68.compute-1.internal> References: <20110703052102.16595.74348@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110704212238.16593.36453@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/377/ ----------------------------------------------------------- (Updated July 4, 2011, 2:22 p.m.) Review request for Viewer. Summary ------- This is a direct adaptation of Aimee Trescothick's contributed patch from STORM-1315 for v-d. Adjustments were made where needed to make it work with the newer boost and llui code. Some changes were made to the variable names it uses on build; ie "PX" for x position instead of just "X". Patch allows for imputing simple math equations in to the spinner controls. On the build floater a series of variable names are available for using the objects current values in equations, like "sx+3" will take the current X scale and add 3. Repo: https://bitbucket.org/Kadah_Coba/storm-1315 Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370 This addresses bug STORM-1315. http://jira.secondlife.com/browse/STORM-1315 Diffs (updated) ----- indra/newview/llpanelobject.cpp 353807ed6a69 indra/newview/llpanelface.cpp 353807ed6a69 indra/newview/llappviewer.cpp 353807ed6a69 indra/llui/llspinctrl.cpp 353807ed6a69 indra/llui/lllineeditor.cpp 353807ed6a69 indra/llmath/llcalcparser.cpp PRE-CREATION indra/llui/lllineeditor.h 353807ed6a69 indra/llmath/llcalc.cpp PRE-CREATION indra/llmath/llcalcparser.h PRE-CREATION indra/llmath/llcalc.h PRE-CREATION indra/llmath/CMakeLists.txt 353807ed6a69 doc/contributions.txt 353807ed6a69 Diff: http://codereview.secondlife.com/r/377/diff Testing ------- Built and ran. Some testing done with simple equations on the build tools floater to edit an object, no issues were observed. Thanks, Kadah -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110704/c636c073/attachment.htm From vsavchuk at productengine.com Mon Jul 4 14:28:56 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Mon, 04 Jul 2011 21:28:56 -0000 Subject: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields In-Reply-To: <20110704212238.16593.36453@domU-12-31-38-00-90-68.compute-1.internal> References: <20110704212238.16593.36453@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110704212856.16596.34249@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/377/#review841 ----------------------------------------------------------- Ship it! Thanks. - Vadim On July 4, 2011, 2:22 p.m., Kadah Coba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/377/ > ----------------------------------------------------------- > > (Updated July 4, 2011, 2:22 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > This is a direct adaptation of Aimee Trescothick's contributed patch from STORM-1315 for v-d. Adjustments were made where needed to make it work with the newer boost and llui code. Some changes were made to the variable names it uses on build; ie "PX" for x position instead of just "X". > > Patch allows for imputing simple math equations in to the spinner controls. On the build floater a series of variable names are available for using the objects current values in equations, like "sx+3" will take the current X scale and add 3. > > Repo: https://bitbucket.org/Kadah_Coba/storm-1315 > Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370 > > > This addresses bug STORM-1315. > http://jira.secondlife.com/browse/STORM-1315 > > > Diffs > ----- > > indra/newview/llpanelobject.cpp 353807ed6a69 > indra/newview/llpanelface.cpp 353807ed6a69 > indra/newview/llappviewer.cpp 353807ed6a69 > indra/llui/llspinctrl.cpp 353807ed6a69 > indra/llui/lllineeditor.cpp 353807ed6a69 > indra/llmath/llcalcparser.cpp PRE-CREATION > indra/llui/lllineeditor.h 353807ed6a69 > indra/llmath/llcalc.cpp PRE-CREATION > indra/llmath/llcalcparser.h PRE-CREATION > indra/llmath/llcalc.h PRE-CREATION > indra/llmath/CMakeLists.txt 353807ed6a69 > doc/contributions.txt 353807ed6a69 > > Diff: http://codereview.secondlife.com/r/377/diff > > > Testing > ------- > > Built and ran. Some testing done with simple equations on the build tools floater to edit an object, no issues were observed. > > > Thanks, > > Kadah > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110704/67563c39/attachment.htm From oz at lindenlab.com Wed Jul 6 08:44:43 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Wed, 06 Jul 2011 11:44:43 -0400 Subject: [opensource-dev] SLCC ? Message-ID: <4E1482EB.9070100@lindenlab.com> I'd like to get a sense of whether or not people from this list are planning to attend SLCC.... if you are, please let me know ASAP by email (off list). From kadah.coba at gmail.com Wed Jul 6 14:55:18 2011 From: kadah.coba at gmail.com (Kadah Coba) Date: Wed, 06 Jul 2011 21:55:18 -0000 Subject: [opensource-dev] Review Request: STORM-1480: Searching in the world map clears the destination arrow but not the destination beacon In-Reply-To: <20110702002530.22032.86122@domU-12-31-38-00-90-68.compute-1.internal> References: <20110702002530.22032.86122@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110706215518.16724.52577@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/379/ ----------------------------------------------------------- (Updated July 6, 2011, 2:55 p.m.) Review request for Viewer. Summary (updated) ------- A single line change to more completely clear the tracking beacon when text is entered in to the world map's search field. https://bitbucket.org/Kadah_Coba/vwr-25753 This addresses bug VWR-25753. http://jira.secondlife.com/browse/VWR-25753 Diffs ----- indra/newview/llfloaterworldmap.cpp c7a4b7a24e05 Diff: http://codereview.secondlife.com/r/379/diff Testing ------- Built and ran, world map's search field fallowed the expected behavior described in VWR-25753. Thanks, Kadah -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110706/e0fba4b5/attachment.htm From vsavchuk at productengine.com Wed Jul 6 17:37:01 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Thu, 07 Jul 2011 00:37:01 -0000 Subject: [opensource-dev] Review Request: STORM-1481 Jerky transition when switching region from fixed sky to a day cycle Message-ID: <20110707003701.25515.30164@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/382/ ----------------------------------------------------------- Review request for Viewer. Summary ------- When uploading new region environment settings, we must also update the region sun phase/flags. If we do this too early we may get jerky transition from fixed sky to a day cycle. That is caused by the simulator re-sending the region info, which in turn makes us re-request and display old region environment settings while the new ones haven't been applied yet. The fix is to send the sun phase update only when new environment settings have been applied. This addresses bug STORM-1481. http://jira.secondlife.com/browse/STORM-1481 Diffs ----- indra/newview/llfloaterregioninfo.h UNKNOWN indra/newview/llfloaterregioninfo.cpp UNKNOWN indra/newview/llregioninfomodel.cpp UNKNOWN indra/newview/llviewermessage.cpp UNKNOWN indra/newview/llviewerregion.cpp UNKNOWN Diff: http://codereview.secondlife.com/r/382/diff Testing ------- Thanks, Vadim -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110707/880577aa/attachment.htm From Lance.Corrimal at eregion.de Thu Jul 7 07:55:01 2011 From: Lance.Corrimal at eregion.de (Lance Corrimal) Date: Thu, 07 Jul 2011 14:55:01 -0000 Subject: [opensource-dev] Review Request: STORM-1459 "Wearing Tab" - Add ability to copy displayed inventory names to clipboard In-Reply-To: <20110630180214.23142.23745@domU-12-31-38-00-90-68.compute-1.internal> References: <20110630180214.23142.23745@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110707145501.25514.13511@domU-12-31-38-00-90-68.compute-1.internal> > On June 30, 2011, 11:02 a.m., Vadim ProductEngine wrote: > > indra/newview/llpanelwearing.cpp, lines 297-302 > > > > > > Looks a bit confusing. but it's elegant! - Lance ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/370/#review834 ----------------------------------------------------------- On June 30, 2011, 1:27 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/370/ > ----------------------------------------------------------- > > (Updated June 30, 2011, 1:27 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Add a feature on the "Wearing TAB" where users could copy to the clipboard everything you see in the "Wearing TAB". This would make the blogging communities life soooooo much easier instead of having to type out all that information. > > The label on this button needs input from someone on the XD team. > > I would like to know if my code for adding a CR to the end of every line but the last one could be done in a more elegant way. > > > This addresses bug STORM-1459. > http://jira.secondlife.com/browse/STORM-1459 > > > Diffs > ----- > > doc/contributions.txt f9864a43ddf0 > indra/newview/llpanelwearing.h f9864a43ddf0 > indra/newview/llpanelwearing.cpp f9864a43ddf0 > indra/newview/skins/default/xui/en/menu_wearing_gear.xml f9864a43ddf0 > > Diff: http://codereview.secondlife.com/r/370/diff > > > Testing > ------- > > Clicked on Send to Clipboard button and was able to paste results into an editor. > > > Thanks, > > Jonathan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110707/37004d25/attachment.htm From slitovchuk at productengine.com Thu Jul 7 08:31:40 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Thu, 07 Jul 2011 15:31:40 -0000 Subject: [opensource-dev] Review Request: STORM-1481 Jerky transition when switching region from fixed sky to a day cycle In-Reply-To: <20110707003701.25515.30164@domU-12-31-38-00-90-68.compute-1.internal> References: <20110707003701.25515.30164@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110707153140.25499.40342@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/382/#review846 ----------------------------------------------------------- Ship it! Looks good to me. - Seth On July 6, 2011, 5:37 p.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/382/ > ----------------------------------------------------------- > > (Updated July 6, 2011, 5:37 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > When uploading new region environment settings, we must also update the region sun phase/flags. > If we do this too early we may get jerky transition from fixed sky to a day cycle. > > That is caused by the simulator re-sending the region info, which in turn makes us > re-request and display old region environment settings while the new ones haven't been applied yet. > > The fix is to send the sun phase update only when new environment settings have been applied. > > > This addresses bug STORM-1481. > http://jira.secondlife.com/browse/STORM-1481 > > > Diffs > ----- > > indra/newview/llfloaterregioninfo.h UNKNOWN > indra/newview/llfloaterregioninfo.cpp UNKNOWN > indra/newview/llregioninfomodel.cpp UNKNOWN > indra/newview/llviewermessage.cpp UNKNOWN > indra/newview/llviewerregion.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/382/diff > > > Testing > ------- > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110707/15245c3a/attachment-0001.htm From vsavchuk at productengine.com Thu Jul 7 08:33:17 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Thu, 07 Jul 2011 15:33:17 -0000 Subject: [opensource-dev] Review Request: STORM-1483 Unable to delete the last water/sky/day preset Message-ID: <20110707153317.16688.17707@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/384/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Fixed a wrong condition. This addresses bug STORM-1483. http://jira.secondlife.com/browse/STORM-1483 Diffs ----- indra/newview/llfloaterdeleteenvpreset.cpp UNKNOWN Diff: http://codereview.secondlife.com/r/384/diff Testing ------- Thanks, Vadim -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110707/2dac0869/attachment.htm From kf6kjg at gmail.com Thu Jul 7 08:50:12 2011 From: kf6kjg at gmail.com (Cron Stardust) Date: Thu, 07 Jul 2011 15:50:12 -0000 Subject: [opensource-dev] Review Request: STORM-1459 "Wearing Tab" - Add ability to copy displayed inventory names to clipboard In-Reply-To: <20110630180214.23142.23745@domU-12-31-38-00-90-68.compute-1.internal> References: <20110630180214.23142.23745@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110707155012.25516.4826@domU-12-31-38-00-90-68.compute-1.internal> > On June 30, 2011, 11:02 a.m., Vadim ProductEngine wrote: > > indra/newview/llpanelwearing.cpp, lines 297-302 > > > > > > Looks a bit confusing. > > Lance Corrimal wrote: > but it's elegant! Just needs some parens: text += (iter != data.end()) ? item->getName() + "\n" : item->getName(); But otherwise it looks just like a a lot of lines I've run across in the past, and with the comment it's not all that difficult to understand. - Cron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/370/#review834 ----------------------------------------------------------- On June 30, 2011, 1:27 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/370/ > ----------------------------------------------------------- > > (Updated June 30, 2011, 1:27 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Add a feature on the "Wearing TAB" where users could copy to the clipboard everything you see in the "Wearing TAB". This would make the blogging communities life soooooo much easier instead of having to type out all that information. > > The label on this button needs input from someone on the XD team. > > I would like to know if my code for adding a CR to the end of every line but the last one could be done in a more elegant way. > > > This addresses bug STORM-1459. > http://jira.secondlife.com/browse/STORM-1459 > > > Diffs > ----- > > doc/contributions.txt f9864a43ddf0 > indra/newview/llpanelwearing.h f9864a43ddf0 > indra/newview/llpanelwearing.cpp f9864a43ddf0 > indra/newview/skins/default/xui/en/menu_wearing_gear.xml f9864a43ddf0 > > Diff: http://codereview.secondlife.com/r/370/diff > > > Testing > ------- > > Clicked on Send to Clipboard button and was able to paste results into an editor. > > > Thanks, > > Jonathan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110707/8d14efea/attachment.htm From slitovchuk at productengine.com Thu Jul 7 09:07:03 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Thu, 07 Jul 2011 16:07:03 -0000 Subject: [opensource-dev] Review Request: STORM-1483 Unable to delete the last water/sky/day preset In-Reply-To: <20110707153317.16688.17707@domU-12-31-38-00-90-68.compute-1.internal> References: <20110707153317.16688.17707@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110707160703.16592.33288@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/384/#review848 ----------------------------------------------------------- Ship it! - Seth On July 7, 2011, 8:33 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/384/ > ----------------------------------------------------------- > > (Updated July 7, 2011, 8:33 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Fixed a wrong condition. > > > This addresses bug STORM-1483. > http://jira.secondlife.com/browse/STORM-1483 > > > Diffs > ----- > > indra/newview/llfloaterdeleteenvpreset.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/384/diff > > > Testing > ------- > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110707/31936b20/attachment.htm From lee.ponzu at gmail.com Thu Jul 7 09:27:42 2011 From: lee.ponzu at gmail.com (Lee ponzu) Date: Thu, 7 Jul 2011 12:27:42 -0400 Subject: [opensource-dev] Autobuild errors Message-ID: it has been a long time since I did a build. I tried to follow the instructions on the wiki, download autobuild, clone viewer-beta... Here is the error. Any advice welcome. Insults also accepted, since I am starved for human contact... ponzu mbpro:viewer-beta lee$ autobuild build --verbose -c Release executing configure command cmake -DCMAKE_BUILD_TYPE:STRING=Release -DWORD_SIZE:STRING=32 -DROOT_PROJECT_NAME:STRING=SecondLife -DINSTALL_PROPRIETARY=TRUE -G 'Xcode' ../indra checking package fmod installing fmod from archive downloading fmod archive from http://s3-proxy.lindenlab.com/private-builds-secondlife-com/hg/repo/3p-fmod-private/rev/221852/arch/Darwin/installer/fmod-3.75-darwin-20110222.tar.bz2 downloading http://s3-proxy.lindenlab.com/private-builds-secondlife-com/hg/repo/3p-fmod-private/rev/221852/arch/Darwin/installer/fmod-3.75-darwin-20110222.tar.bz2to /var/tmp/lee/install.cache/fmod-3.75-darwin-20110222.tar.bz2 unable to download file: HTTP Error 404: Not Found Traceback (most recent call last): File "/Users/lee/Documents/viewer/autobuild/autobuild/common.py", line 253, in download_package file(cachename, 'wb').write(urllib2.urlopen(package).read()) File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 124, in urlopen return _opener.open(url, data, timeout) File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 389, in open response = meth(req, response) File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 502, in http_response 'http', request, response, code, msg, hdrs) File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 427, in error return self._call_chain(*args) File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 361, in _call_chain result = func(*args) File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 510, in http_error_default raise HTTPError(req.get_full_url(), code, msg, hdrs, fp) HTTPError: HTTP Error 404: Not Found ERROR: failed to download http://s3-proxy.lindenlab.com/private-builds-secondlife-com/hg/repo/3p-fmod-private/rev/221852/arch/Darwin/installer/fmod-3.75-darwin-20110222.tar.bz2 For more information: try re-running your command with --verbose or --debug CMake Error at cmake/Prebuilt.cmake:48 (message): Failed to download or unpack prebuilt 'fmod'. Process returned 1. Call Stack (most recent call first): cmake/FMOD.cmake:27 (use_prebuilt_binary) llaudio/CMakeLists.txt:8 (include) -- Configuring incomplete, errors occurred! ERROR: configuring default configuration returned 1 For more information: try re-running your command with --verbose or --debug mbpro:viewer-beta lee$ -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110707/86bfae05/attachment-0001.htm From nickyperian at yahoo.com Thu Jul 7 09:37:30 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Thu, 7 Jul 2011 09:37:30 -0700 (PDT) Subject: [opensource-dev] Autobuild errors In-Reply-To: References: Message-ID: <1310056650.22929.YahooMailNeo@web43510.mail.sp1.yahoo.com> use ReleaseOS ________________________________ From: Lee ponzu To: Opensource_dev Sent: Thursday, July 7, 2011 11:27 AM Subject: [opensource-dev] Autobuild errors it has been a long time since I did a build. ?I tried to follow the instructions on the wiki, download autobuild, clone viewer-beta... Here is the error. ?Any advice welcome. ?Insults also accepted, since I am starved for human contact... ponzu mbpro:viewer-beta lee$ autobuild build --verbose -c Release executing configure command cmake -DCMAKE_BUILD_TYPE:STRING=Release -DWORD_SIZE:STRING=32 -DROOT_PROJECT_NAME:STRING=SecondLife -DINSTALL_PROPRIETARY=TRUE -G 'Xcode' ../indra checking package fmod installing fmod from archive downloading fmod archive from http://s3-proxy.lindenlab.com/private-builds-secondlife-com/hg/repo/3p-fmod-private/rev/221852/arch/Darwin/installer/fmod-3.75-darwin-20110222.tar.bz2 downloading http://s3-proxy.lindenlab.com/private-builds-secondlife-com/hg/repo/3p-fmod-private/rev/221852/arch/Darwin/installer/fmod-3.75-darwin-20110222.tar.bz2 to /var/tmp/lee/install.cache/fmod-3.75-darwin-20110222.tar.bz2 unable to download file: HTTP Error 404: Not Found Traceback (most recent call last): ? File "/Users/lee/Documents/viewer/autobuild/autobuild/common.py", line 253, in download_package ? ? file(cachename, 'wb').write(urllib2.urlopen(package).read()) ? File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 124, in urlopen ? ? return _opener.open(url, data, timeout) ? File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 389, in open ? ? response = meth(req, response) ? File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 502, in http_response ? ? 'http', request, response, code, msg, hdrs) ? File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 427, in error ? ? return self._call_chain(*args) ? File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 361, in _call_chain ? ? result = func(*args) ? File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 510, in http_error_default ? ? raise HTTPError(req.get_full_url(), code, msg, hdrs, fp) HTTPError: HTTP Error 404: Not Found ERROR: failed to download http://s3-proxy.lindenlab.com/private-builds-secondlife-com/hg/repo/3p-fmod-private/rev/221852/arch/Darwin/installer/fmod-3.75-darwin-20110222.tar.bz2 For more information: try re-running your command with --verbose or --debug CMake Error at cmake/Prebuilt.cmake:48 (message): ? Failed to download or unpack prebuilt 'fmod'. ?Process returned 1. Call Stack (most recent call first): ? cmake/FMOD.cmake:27 (use_prebuilt_binary) ? llaudio/CMakeLists.txt:8 (include) -- Configuring incomplete, errors occurred! ERROR: configuring default configuration returned 1 For more information: try re-running your command with --verbose or --debug mbpro:viewer-beta lee$? _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110707/34259401/attachment.htm From log at lindenlab.com Thu Jul 7 09:56:46 2011 From: log at lindenlab.com (Log Linden) Date: Thu, 07 Jul 2011 16:56:46 -0000 Subject: [opensource-dev] Review Request: Support SOCKS 5 proxy in the viewer. Message-ID: <20110707165646.25499.59738@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/374/ ----------------------------------------------------------- Review request for Viewer, Oz Linden, Monty Brandenberg, and Stone Linden. Summary ------- This is a continuation of Robin Cornelius's SOCKS 5 contribution, shown in https://codereview.secondlife.com/r/232/ . I have tried to address all of the comments on that code review and do as much cleanup as possible. The diff includes everything that was submitted by Robin, as well as my work. Major changes since I started working: * Changed SOCKS 5 proxy control channel to use the existing LLSocket class, which is a thin wrapper around APR sockets. * Worked with the Linden Lab UX team to revamp the proxy controls. * Proxy credentials are now stored in the LLSecAPI password storage, which is the same that is used for users' Second Life Credentials instead of as being stored in the clear as a preference. This addresses bug STORM-1112. http://jira.secondlife.com/browse/STORM-1112 Diffs ----- indra/newview/skins/default/xui/en/notifications.xml c7a4b7a24e05 indra/newview/skins/default/xui/en/panel_cof_wearables.xml c7a4b7a24e05 indra/newview/skins/default/xui/en/panel_preferences_privacy.xml c7a4b7a24e05 indra/newview/skins/default/xui/en/panel_preferences_setup.xml c7a4b7a24e05 indra/newview/skins/default/xui/en/floater_preferences_proxy.xml PRE-CREATION indra/newview/llviewerfloaterreg.cpp c7a4b7a24e05 indra/newview/llxmlrpctransaction.cpp c7a4b7a24e05 indra/newview/llstartup.h c7a4b7a24e05 indra/newview/llstartup.cpp c7a4b7a24e05 indra/newview/llloginhandler.cpp c7a4b7a24e05 indra/newview/llpanellogin.h c7a4b7a24e05 indra/newview/llsecapi.h c7a4b7a24e05 indra/llui/llfunctorregistry.h c7a4b7a24e05 indra/newview/app_settings/settings.xml c7a4b7a24e05 indra/newview/llappviewer.cpp c7a4b7a24e05 indra/newview/llfloaterpreference.h c7a4b7a24e05 indra/newview/llfloaterpreference.cpp c7a4b7a24e05 indra/llmessage/net.h c7a4b7a24e05 indra/llmessage/net.cpp c7a4b7a24e05 indra/llmessage/llproxy.cpp PRE-CREATION indra/llmessage/CMakeLists.txt c7a4b7a24e05 indra/llmessage/llcurl.cpp c7a4b7a24e05 indra/llmessage/lliosocket.h c7a4b7a24e05 indra/llmessage/lliosocket.cpp c7a4b7a24e05 indra/llmessage/llpacketring.h c7a4b7a24e05 indra/llmessage/llpacketring.cpp c7a4b7a24e05 indra/llmessage/llproxy.h PRE-CREATION Diff: http://codereview.secondlife.com/r/374/diff Testing ------- I've tested exclusively on Linux so far. I'm working on a more extensive test plan that includes setting up a gateway with a restrictive firewall to verify that all traffic is going through the proxy. Test builds and screenshots of the changed UI elements are available from the project page, located here: https://wiki.secondlife.com/wiki/User:Log_Linden/Socks5Viewer Thanks, Log -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110707/67e79e14/attachment.htm From vsavchuk at productengine.com Thu Jul 7 10:44:46 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Thu, 07 Jul 2011 17:44:46 -0000 Subject: [opensource-dev] Review Request: STORM-1484 No way to apply changes in estate settings like Allow public access or Allow Voice Chat after merging WLRS Message-ID: <20110707174446.16596.13181@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/385/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Restored Apply button in the Estate tab of the REGION / ESTATE floater. This addresses bug STORM-1484. http://jira.secondlife.com/browse/STORM-1484 Diffs ----- indra/newview/skins/default/xui/en/panel_region_estate.xml UNKNOWN Diff: http://codereview.secondlife.com/r/385/diff Testing ------- Thanks, Vadim -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110707/39883d94/attachment.htm From slitovchuk at productengine.com Thu Jul 7 11:35:41 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Thu, 07 Jul 2011 18:35:41 -0000 Subject: [opensource-dev] Review Request: STORM-1484 No way to apply changes in estate settings like Allow public access or Allow Voice Chat after merging WLRS In-Reply-To: <20110707174446.16596.13181@domU-12-31-38-00-90-68.compute-1.internal> References: <20110707174446.16596.13181@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110707183541.25513.22677@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/385/#review850 ----------------------------------------------------------- Ship it! - Seth On July 7, 2011, 10:44 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/385/ > ----------------------------------------------------------- > > (Updated July 7, 2011, 10:44 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Restored Apply button in the Estate tab of the REGION / ESTATE floater. > > > This addresses bug STORM-1484. > http://jira.secondlife.com/browse/STORM-1484 > > > Diffs > ----- > > indra/newview/skins/default/xui/en/panel_region_estate.xml UNKNOWN > > Diff: http://codereview.secondlife.com/r/385/diff > > > Testing > ------- > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110707/88e401b6/attachment-0001.htm From lee.ponzu at gmail.com Thu Jul 7 11:54:58 2011 From: lee.ponzu at gmail.com (Lee ponzu) Date: Thu, 7 Jul 2011 14:54:58 -0400 Subject: [opensource-dev] RenderTextureMaximumMultiply == 0.5 is annoying... Message-ID: My GPU only has 256 MB, so the default for texture mem is only 128MB. I am constantly adjusting it using Debug Settings...I am sick of it. I don't so much mind that the default setting is .5 * GPU memory. I just think it shouldn't be so cumbersome to increase it. ponzu -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110707/4ba27596/attachment.htm From wolfpup67 at earthlink.net Thu Jul 7 12:02:35 2011 From: wolfpup67 at earthlink.net (WolfPup Lowenhar) Date: Thu, 7 Jul 2011 15:02:35 -0400 Subject: [opensource-dev] RenderTextureMaximumMultiply == 0.5 is annoying... In-Reply-To: References: Message-ID: <004b01cc3cd8$6f3e7b30$4dbb7190$@net> I can understand your frustration. Most video cards use that memory for two thing textures and also the vortex buffer so if you limit the amount of textures stored in the video cards memory it will leave space for the vortex memory that the GPU uses. From: opensource-dev-bounces at lists.secondlife.com [mailto:opensource-dev-bounces at lists.secondlife.com] On Behalf Of Lee ponzu Sent: Thursday, July 07, 2011 2:55 PM To: Opensource_dev Subject: [opensource-dev] RenderTextureMaximumMultiply == 0.5 is annoying... My GPU only has 256 MB, so the default for texture mem is only 128MB. I am constantly adjusting it using Debug Settings...I am sick of it. I don't so much mind that the default setting is .5 * GPU memory. I just think it shouldn't be so cumbersome to increase it. ponzu _____ No virus found in this message. Checked by AVG - www.avg.com Version: 10.0.1388 / Virus Database: 1516/3749 - Release Date: 07/07/11 -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110707/d11fec6b/attachment.htm From kadah.coba at gmail.com Thu Jul 7 12:57:37 2011 From: kadah.coba at gmail.com (Kadah) Date: Thu, 07 Jul 2011 12:57:37 -0700 Subject: [opensource-dev] Autobuild errors In-Reply-To: <1310056650.22929.YahooMailNeo@web43510.mail.sp1.yahoo.com> References: <1310056650.22929.YahooMailNeo@web43510.mail.sp1.yahoo.com> Message-ID: <4E160FB1.8020005@gmail.com> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 The wiki documention should really be changed to not mention any of the configs without *OS first as only internal Linden builds can use those. On 7/7/2011 9:37 AM, Nicky Perian wrote: > use ReleaseOS > > ------------------------------------------------------------------------ > *From:* Lee ponzu > *To:* Opensource_dev > *Sent:* Thursday, July 7, 2011 11:27 AM > *Subject:* [opensource-dev] Autobuild errors > > it has been a long time since I did a build. I tried to follow the > instructions on the wiki, download autobuild, clone viewer-beta... > > Here is the error. Any advice welcome. Insults also accepted, since I > am starved for human contact... > > ponzu > > > mbpro:viewer-beta lee$ autobuild build --verbose -c Release > executing configure command cmake -DCMAKE_BUILD_TYPE:STRING=Release > -DWORD_SIZE:STRING=32 -DROOT_PROJECT_NAME:STRING=SecondLife > -DINSTALL_PROPRIETARY=TRUE -G 'Xcode' ../indra > checking package fmod > installing fmod from archive > downloading fmod archive from > http://s3-proxy.lindenlab.com/private-builds-secondlife-com/hg/repo/3p-fmod-private/rev/221852/arch/Darwin/installer/fmod-3.75-darwin-20110222.tar.bz2 > downloading > http://s3-proxy.lindenlab.com/private-builds-secondlife-com/hg/repo/3p-fmod-private/rev/221852/arch/Darwin/installer/fmod-3.75-darwin-20110222.tar.bz2 > to /var/tmp/lee/install.cache/fmod-3.75-darwin-20110222.tar.bz2 > unable to download file: HTTP Error 404: Not Found > Traceback (most recent call last): > File "/Users/lee/Documents/viewer/autobuild/autobuild/common.py", line > 253, in download_package > file(cachename, 'wb').write(urllib2.urlopen(package).read()) > File > "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", > line 124, in urlopen > return _opener.open(url, data, timeout) > File > "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", > line 389, in open > response = meth(req, response) > File > "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", > line 502, in http_response > 'http', request, response, code, msg, hdrs) > File > "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", > line 427, in error > return self._call_chain(*args) > File > "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", > line 361, in _call_chain > result = func(*args) > File > "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", > line 510, in http_error_default > raise HTTPError(req.get_full_url(), code, msg, hdrs, fp) > HTTPError: HTTP Error 404: Not Found > ERROR: failed to download > http://s3-proxy.lindenlab.com/private-builds-secondlife-com/hg/repo/3p-fmod-private/rev/221852/arch/Darwin/installer/fmod-3.75-darwin-20110222.tar.bz2 > For more information: try re-running your command with --verbose or --debug > CMake Error at cmake/Prebuilt.cmake:48 (message): > Failed to download or unpack prebuilt 'fmod'. Process returned 1. > Call Stack (most recent call first): > cmake/FMOD.cmake:27 (use_prebuilt_binary) > llaudio/CMakeLists.txt:8 (include) > > > -- Configuring incomplete, errors occurred! > ERROR: configuring default configuration returned 1 > For more information: try re-running your command with --verbose or --debug > mbpro:viewer-beta lee$ > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJOFg+xAAoJEIdLfPRu7qE2E5IIAIFwv9l3YlL5CQGTbPQwCZtW asV6cwd4yHP2a4mD+sMDhjgm1WJlROD4uvniJ86FAuHS1apjk9VS+U8nG0/XB0QU UsdWVA/bgntICaq7r5ilEZBxXnWr1Cd+VDFhhJXWQtyQZz0t77fS0SdbFTAK3/5C xApYtNfIvD3pHBcVpY9IexNXxX6kG2KOwY8W4qquWK0R/hwvA/zpLGBKy7KpmR7V m0ixyx62UMTYwr2CYUrJM1on58OjS6CKSvqn0NJUV2Fc6/Mv2DYWj4Z35d/Ol8WN G49ddZweUsWgr6eQGeuTXhc8iDW687duaPAOXLhkoLgMpM4CoqfXmNm4qrsePAA= =6Olx -----END PGP SIGNATURE----- From jhwelch at gmail.com Thu Jul 7 15:40:48 2011 From: jhwelch at gmail.com (Jonathan Welch) Date: Thu, 7 Jul 2011 18:40:48 -0400 Subject: [opensource-dev] Autobuild errors In-Reply-To: <4E160FB1.8020005@gmail.com> References: <1310056650.22929.YahooMailNeo@web43510.mail.sp1.yahoo.com> <4E160FB1.8020005@gmail.com> Message-ID: Anyone can change the wiki page -- please update it if you encounter problems. > The wiki documention should really be changed to not mention any of the > configs without *OS first as only internal Linden builds can use those. From pguslisty at productengine.com Fri Jul 8 05:16:10 2011 From: pguslisty at productengine.com (Paul ProductEngine) Date: Fri, 08 Jul 2011 12:16:10 -0000 Subject: [opensource-dev] Review Request: STORM-1460 (Cursor doesn't go to the input field on the Find Floater due to lack of window focus) Message-ID: <20110708121610.25510.50718@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/386/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Reason: Focus didn't go to the browser Solution: Set the focus to the browser if a page is loaded and a floater containing a browser has a focus This addresses bug storm-1460. http://jira.secondlife.com/browse/storm-1460 Diffs ----- indra/newview/llfloatersearch.h 68ad362920c1 indra/newview/llfloatersearch.cpp 68ad362920c1 Diff: http://codereview.secondlife.com/r/386/diff Testing ------- Thanks, Paul -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110708/624b5ce5/attachment.htm From slitovchuk at productengine.com Fri Jul 8 06:12:04 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Fri, 08 Jul 2011 13:12:04 -0000 Subject: [opensource-dev] Review Request: STORM-1460 (Cursor doesn't go to the input field on the Find Floater due to lack of window focus) In-Reply-To: <20110708121610.25510.50718@domU-12-31-38-00-90-68.compute-1.internal> References: <20110708121610.25510.50718@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110708131204.25511.30988@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/386/#review852 ----------------------------------------------------------- Ship it! Looks good. - Seth On July 8, 2011, 5:16 a.m., Paul ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/386/ > ----------------------------------------------------------- > > (Updated July 8, 2011, 5:16 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Reason: > Focus didn't go to the browser > > Solution: > Set the focus to the browser if a page is loaded and a floater containing a browser has a focus > > > This addresses bug storm-1460. > http://jira.secondlife.com/browse/storm-1460 > > > Diffs > ----- > > indra/newview/llfloatersearch.h 68ad362920c1 > indra/newview/llfloatersearch.cpp 68ad362920c1 > > Diff: http://codereview.secondlife.com/r/386/diff > > > Testing > ------- > > > Thanks, > > Paul > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110708/005b81ad/attachment.htm From oz at lindenlab.com Fri Jul 8 08:15:06 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Fri, 08 Jul 2011 11:15:06 -0400 Subject: [opensource-dev] Snowstorm Review Build Message-ID: <4E171EFA.2000100@lindenlab.com> There is a new PO review build available: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_viewer-poreview/rev/235148/index.html Issues to be reviewed in this build: STORM-1315 As a User, I want to be able to do simple math in numeric edit fields. STORM-1325 The viewer doesn't retry to upload baked textures if the initial upload failed STORM-1459 "Wearing Tab" - Add ability to copy displayed inventory names to clipboard STORM-1472 Favorites folder in inventory does not translate properly STORM-1480 searching in the world map clears the destination arrow but not the destination beacon STORM-1481 Jerky transition when switching region from fixed sky to a day cycle STORM-1483 Unable to delete the last water/sky/day preset STORM-1484 No way to apply changes in estate settings like Allow public access or Allow Voice Chat after merging WLRS VWR-25753 [#STORM-1480] searching in the world map clears the destination arrow but not the destination beacon -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110708/13da3ab5/attachment-0001.htm From vsavchuk at productengine.com Fri Jul 8 08:51:21 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Fri, 08 Jul 2011 15:51:21 -0000 Subject: [opensource-dev] Review Request: STORM-1460 (Cursor doesn't go to the input field on the Find Floater due to lack of window focus) In-Reply-To: <20110708121610.25510.50718@domU-12-31-38-00-90-68.compute-1.internal> References: <20110708121610.25510.50718@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110708155121.25513.75834@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/386/#review853 ----------------------------------------------------------- I think this is a hack. The embedded browser should not differ from other widgets in terms of focus hangling. Imagine you have a button. Once the floater is created, you focus the button. That's it. You're not waiting for some event within the button. So why don't you just focus the web browser control in postBuild()? Why does the floater have to know so much about page loading stuff? - Vadim On July 8, 2011, 5:16 a.m., Paul ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/386/ > ----------------------------------------------------------- > > (Updated July 8, 2011, 5:16 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Reason: > Focus didn't go to the browser > > Solution: > Set the focus to the browser if a page is loaded and a floater containing a browser has a focus > > > This addresses bug storm-1460. > http://jira.secondlife.com/browse/storm-1460 > > > Diffs > ----- > > indra/newview/llfloatersearch.h 68ad362920c1 > indra/newview/llfloatersearch.cpp 68ad362920c1 > > Diff: http://codereview.secondlife.com/r/386/diff > > > Testing > ------- > > > Thanks, > > Paul > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110708/bc98bf21/attachment.htm From lee.ponzu at gmail.com Fri Jul 8 10:27:39 2011 From: lee.ponzu at gmail.com (Lee ponzu) Date: Fri, 8 Jul 2011 13:27:39 -0400 Subject: [opensource-dev] Autobuild errors In-Reply-To: <1310056650.22929.YahooMailNeo@web43510.mail.sp1.yahoo.com> References: <1310056650.22929.YahooMailNeo@web43510.mail.sp1.yahoo.com> Message-ID: Still getting an error... mbpro:viewer-beta lee$ autobuild build --verbose -c ReleaseOS executing configure command cmake -DCMAKE_BUILD_TYPE:STRING=Release -DWORD_SIZE:STRING=32 -DROOT_PROJECT_NAME:STRING=SecondLife -DINSTALL_PROPRIETARY=FALSE -G 'Xcode' ../indra checking package fmod installing fmod from archive downloading fmod archive from http://s3-proxy.lindenlab.com/private-builds-secondlife-com/hg/repo/3p-fmod-private/rev/221852/arch/Darwin/installer/fmod-3.75-darwin-20110222.tar.bz2 downloading http://s3-proxy.lindenlab.com/private-builds-secondlife-com/hg/repo/3p-fmod-private/rev/221852/arch/Darwin/installer/fmod-3.75-darwin-20110222.tar.bz2to /var/tmp/lee/install.cache/fmod-3.75-darwin-20110222.tar.bz2 unable to download file: Traceback (most recent call last): File "/Users/lee/Documents/viewer/autobuild/autobuild/common.py", line 253, in download_package file(cachename, 'wb').write(urllib2.urlopen(package).read()) File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 124, in urlopen return _opener.open(url, data, timeout) File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 383, in open response = self._open(req, data) File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 401, in _open '_open', req) File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 361, in _call_chain result = func(*args) File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 1130, in http_open return self.do_open(httplib.HTTPConnection, req) File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 1105, in do_open raise URLError(err) URLError: ERROR: failed to download http://s3-proxy.lindenlab.com/private-builds-secondlife-com/hg/repo/3p-fmod-private/rev/221852/arch/Darwin/installer/fmod-3.75-darwin-20110222.tar.bz2 For more information: try re-running your command with --verbose or --debug CMake Error at cmake/Prebuilt.cmake:48 (message): Failed to download or unpack prebuilt 'fmod'. Process returned 1. Call Stack (most recent call first): cmake/FMOD.cmake:27 (use_prebuilt_binary) llaudio/CMakeLists.txt:8 (include) -- Configuring incomplete, errors occurred! ERROR: configuring default configuration returned 1 For more information: try re-running your command with --verbose or --debug On Thu, Jul 7, 2011 at 12:37 PM, Nicky Perian wrote: > use ReleaseOS > > ------------------------------ > *From:* Lee ponzu > *To:* Opensource_dev > *Sent:* Thursday, July 7, 2011 11:27 AM > *Subject:* [opensource-dev] Autobuild errors > > it has been a long time since I did a build. I tried to follow the > instructions on the wiki, download autobuild, clone viewer-beta... > > Here is the error. Any advice welcome. Insults also accepted, since I am > starved for human contact... > > ponzu > > > mbpro:viewer-beta lee$ autobuild build --verbose -c Release > executing configure command cmake -DCMAKE_BUILD_TYPE:STRING=Release > -DWORD_SIZE:STRING=32 -DROOT_PROJECT_NAME:STRING=SecondLife > -DINSTALL_PROPRIETARY=TRUE -G 'Xcode' ../indra > checking package fmod > installing fmod from archive > downloading fmod archive from > http://s3-proxy.lindenlab.com/private-builds-secondlife-com/hg/repo/3p-fmod-private/rev/221852/arch/Darwin/installer/fmod-3.75-darwin-20110222.tar.bz2 > downloading > http://s3-proxy.lindenlab.com/private-builds-secondlife-com/hg/repo/3p-fmod-private/rev/221852/arch/Darwin/installer/fmod-3.75-darwin-20110222.tar.bz2to /var/tmp/lee/install.cache/fmod-3.75-darwin-20110222.tar.bz2 > unable to download file: HTTP Error 404: Not Found > Traceback (most recent call last): > File "/Users/lee/Documents/viewer/autobuild/autobuild/common.py", line > 253, in download_package > file(cachename, 'wb').write(urllib2.urlopen(package).read()) > File > "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", > line 124, in urlopen > return _opener.open(url, data, timeout) > File > "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", > line 389, in open > response = meth(req, response) > File > "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", > line 502, in http_response > 'http', request, response, code, msg, hdrs) > File > "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", > line 427, in error > return self._call_chain(*args) > File > "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", > line 361, in _call_chain > result = func(*args) > File > "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", > line 510, in http_error_default > raise HTTPError(req.get_full_url(), code, msg, hdrs, fp) > HTTPError: HTTP Error 404: Not Found > ERROR: failed to download > http://s3-proxy.lindenlab.com/private-builds-secondlife-com/hg/repo/3p-fmod-private/rev/221852/arch/Darwin/installer/fmod-3.75-darwin-20110222.tar.bz2 > For more information: try re-running your command with --verbose or --debug > CMake Error at cmake/Prebuilt.cmake:48 (message): > Failed to download or unpack prebuilt 'fmod'. Process returned 1. > Call Stack (most recent call first): > cmake/FMOD.cmake:27 (use_prebuilt_binary) > llaudio/CMakeLists.txt:8 (include) > > > -- Configuring incomplete, errors occurred! > ERROR: configuring default configuration returned 1 > For more information: try re-running your command with --verbose or --debug > mbpro:viewer-beta lee$ > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110708/b14d2921/attachment.htm From richard at lindenlab.com Fri Jul 8 11:14:28 2011 From: richard at lindenlab.com (Richard Nelson) Date: Fri, 08 Jul 2011 18:14:28 -0000 Subject: [opensource-dev] Review Request: STORM-1460 (Cursor doesn't go to the input field on the Find Floater due to lack of window focus) In-Reply-To: <20110708121610.25510.50718@domU-12-31-38-00-90-68.compute-1.internal> References: <20110708121610.25510.50718@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110708181428.25510.84174@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/386/#review854 ----------------------------------------------------------- Please don't use code to manually set focus unless you know for sure that xui-based focus control doesn't work. In this case, just add tab_stop="true" to the web_browser widget inside floater_search.xml - Richard On July 8, 2011, 5:16 a.m., Paul ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/386/ > ----------------------------------------------------------- > > (Updated July 8, 2011, 5:16 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Reason: > Focus didn't go to the browser > > Solution: > Set the focus to the browser if a page is loaded and a floater containing a browser has a focus > > > This addresses bug storm-1460. > http://jira.secondlife.com/browse/storm-1460 > > > Diffs > ----- > > indra/newview/llfloatersearch.h 68ad362920c1 > indra/newview/llfloatersearch.cpp 68ad362920c1 > > Diff: http://codereview.secondlife.com/r/386/diff > > > Testing > ------- > > > Thanks, > > Paul > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110708/6c6b1a65/attachment-0001.htm From kadah.coba at gmail.com Fri Jul 8 11:39:09 2011 From: kadah.coba at gmail.com (Kadah) Date: Fri, 08 Jul 2011 11:39:09 -0700 Subject: [opensource-dev] Autobuild errors In-Reply-To: References: <1310056650.22929.YahooMailNeo@web43510.mail.sp1.yahoo.com> Message-ID: <4E174ECD.8040208@gmail.com> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 You have 3 options for fmod, 2 hacky workarounds: http://wiki.secondlife.com/wiki/Viewer_2_Microsoft_Windows_Builds#Prepare_third_party_libraries or skip fmod (add -- -DFMOD:BOOL=FALSE to the end of your autobuild command) On 7/8/2011 10:27 AM, Lee ponzu wrote: > Still getting an error... > > mbpro:viewer-beta lee$ autobuild build --verbose -c ReleaseOS > executing configure command cmake -DCMAKE_BUILD_TYPE:STRING=Release > -DWORD_SIZE:STRING=32 -DROOT_PROJECT_NAME:STRING=SecondLife > -DINSTALL_PROPRIETARY=FALSE -G 'Xcode' ../indra > checking package fmod > installing fmod from archive > downloading fmod archive from > http://s3-proxy.lindenlab.com/private-builds-secondlife-com/hg/repo/3p-fmod-private/rev/221852/arch/Darwin/installer/fmod-3.75-darwin-20110222.tar.bz2 > downloading > http://s3-proxy.lindenlab.com/private-builds-secondlife-com/hg/repo/3p-fmod-private/rev/221852/arch/Darwin/installer/fmod-3.75-darwin-20110222.tar.bz2 > to /var/tmp/lee/install.cache/fmod-3.75-darwin-20110222.tar.bz2 > unable to download file: > Traceback (most recent call last): > File "/Users/lee/Documents/viewer/autobuild/autobuild/common.py", line > 253, in download_package > file(cachename, 'wb').write(urllib2.urlopen(package).read()) > File > "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", > line 124, in urlopen > return _opener.open(url, data, timeout) > File > "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", > line 383, in open > response = self._open(req, data) > File > "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", > line 401, in _open > '_open', req) > File > "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", > line 361, in _call_chain > result = func(*args) > File > "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", > line 1130, in http_open > return self.do_open(httplib.HTTPConnection, req) > File > "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", > line 1105, in do_open > raise URLError(err) > URLError: > ERROR: failed to download > http://s3-proxy.lindenlab.com/private-builds-secondlife-com/hg/repo/3p-fmod-private/rev/221852/arch/Darwin/installer/fmod-3.75-darwin-20110222.tar.bz2 > For more information: try re-running your command with --verbose or --debug > CMake Error at cmake/Prebuilt.cmake:48 (message): > Failed to download or unpack prebuilt 'fmod'. Process returned 1. > Call Stack (most recent call first): > cmake/FMOD.cmake:27 (use_prebuilt_binary) > llaudio/CMakeLists.txt:8 (include) > > > -- Configuring incomplete, errors occurred! > ERROR: configuring default configuration returned 1 > For more information: try re-running your command with --verbose or --debug > > On Thu, Jul 7, 2011 at 12:37 PM, Nicky Perian > wrote: > > use ReleaseOS > > ------------------------------------------------------------------------ > *From:* Lee ponzu > > *To:* Opensource_dev > > *Sent:* Thursday, July 7, 2011 11:27 AM > *Subject:* [opensource-dev] Autobuild errors > > it has been a long time since I did a build. I tried to follow the > instructions on the wiki, download autobuild, clone viewer-beta... > > Here is the error. Any advice welcome. Insults also accepted, > since I am starved for human contact... > > ponzu > > > mbpro:viewer-beta lee$ autobuild build --verbose -c Release > executing configure command cmake -DCMAKE_BUILD_TYPE:STRING=Release > -DWORD_SIZE:STRING=32 -DROOT_PROJECT_NAME:STRING=SecondLife > -DINSTALL_PROPRIETARY=TRUE -G 'Xcode' ../indra > checking package fmod > installing fmod from archive > downloading fmod archive from > http://s3-proxy.lindenlab.com/private-builds-secondlife-com/hg/repo/3p-fmod-private/rev/221852/arch/Darwin/installer/fmod-3.75-darwin-20110222.tar.bz2 > downloading > http://s3-proxy.lindenlab.com/private-builds-secondlife-com/hg/repo/3p-fmod-private/rev/221852/arch/Darwin/installer/fmod-3.75-darwin-20110222.tar.bz2 > to /var/tmp/lee/install.cache/fmod-3.75-darwin-20110222.tar.bz2 > unable to download file: HTTP Error 404: Not Found > Traceback (most recent call last): > File "/Users/lee/Documents/viewer/autobuild/autobuild/common.py", > line 253, in download_package > file(cachename, 'wb').write(urllib2.urlopen(package).read()) > File > "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", > line 124, in urlopen > return _opener.open(url, data, timeout) > File > "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", > line 389, in open > response = meth(req, response) > File > "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", > line 502, in http_response > 'http', request, response, code, msg, hdrs) > File > "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", > line 427, in error > return self._call_chain(*args) > File > "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", > line 361, in _call_chain > result = func(*args) > File > "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", > line 510, in http_error_default > raise HTTPError(req.get_full_url(), code, msg, hdrs, fp) > HTTPError: HTTP Error 404: Not Found > ERROR: failed to download > http://s3-proxy.lindenlab.com/private-builds-secondlife-com/hg/repo/3p-fmod-private/rev/221852/arch/Darwin/installer/fmod-3.75-darwin-20110222.tar.bz2 > For more information: try re-running your command with --verbose or > --debug > CMake Error at cmake/Prebuilt.cmake:48 (message): > Failed to download or unpack prebuilt 'fmod'. Process returned 1. > Call Stack (most recent call first): > cmake/FMOD.cmake:27 (use_prebuilt_binary) > llaudio/CMakeLists.txt:8 (include) > > > -- Configuring incomplete, errors occurred! > ERROR: configuring default configuration returned 1 > For more information: try re-running your command with --verbose or > --debug > mbpro:viewer-beta lee$ > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > > > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJOF07NAAoJEIdLfPRu7qE2KssH/Ra7yFIuBlADLkxFAigfg4iX e2SyjBYAWNOjR+8Ou4ciqubc/VYqhFzvChT93CImElup/ANkmUhgoMyBaYgPtTg0 VbnpK/Rrrq1fJFGxCdyC5y6P4Aco+3ywbCWqJGQQg3V/xlsCsDJ5wluV8EelIAh6 2s4S9Q6ooooSA3x4ML1RBwtSj85AUkmK6/8U15rzKsc7Ck4SQ+2SMU59QFRIazn8 JNSgGMNzu3gs8Nu5uNLnzXTyqHbKoPQFqLqPo/SmBurCvK9dMjnaQ+9LnKHg02U/ yI8pPE/R6gp9VhXk4IIM1tLufkVEqiSlqUnlx9iyrmZJfZ3ZmLvAo6Ifa0uCYz0= =pr9Z -----END PGP SIGNATURE----- From log at lindenlab.com Fri Jul 8 11:55:07 2011 From: log at lindenlab.com (Log Linden) Date: Fri, 08 Jul 2011 18:55:07 -0000 Subject: [opensource-dev] Review Request: Support SOCKS 5 proxy in the viewer. In-Reply-To: <20110707165646.25499.59738@domU-12-31-38-00-90-68.compute-1.internal> References: <20110707165646.25499.59738@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110708185507.16590.76473@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/374/ ----------------------------------------------------------- (Updated July 8, 2011, 11:55 a.m.) Review request for Viewer, Oz Linden, Monty Brandenberg, and Stone Linden. Changes ------- Change the logging macros in llproxy.cpp to use the new LL_WARNS() style. Disabled the proxy by default. Summary ------- This is a continuation of Robin Cornelius's SOCKS 5 contribution, shown in https://codereview.secondlife.com/r/232/ . I have tried to address all of the comments on that code review and do as much cleanup as possible. The diff includes everything that was submitted by Robin, as well as my work. Major changes since I started working: * Changed SOCKS 5 proxy control channel to use the existing LLSocket class, which is a thin wrapper around APR sockets. * Worked with the Linden Lab UX team to revamp the proxy controls. * Proxy credentials are now stored in the LLSecAPI password storage, which is the same that is used for users' Second Life Credentials instead of as being stored in the clear as a preference. This addresses bug STORM-1112. http://jira.secondlife.com/browse/STORM-1112 Diffs (updated) ----- indra/llmessage/CMakeLists.txt c7a4b7a24e05 indra/llmessage/llcurl.cpp c7a4b7a24e05 indra/llmessage/lliosocket.h c7a4b7a24e05 indra/llmessage/lliosocket.cpp c7a4b7a24e05 indra/llmessage/llpacketring.h c7a4b7a24e05 indra/llmessage/llpacketring.cpp c7a4b7a24e05 indra/llmessage/llproxy.h PRE-CREATION indra/llmessage/llproxy.cpp PRE-CREATION indra/llmessage/net.h c7a4b7a24e05 indra/llmessage/net.cpp c7a4b7a24e05 indra/llui/llfunctorregistry.h c7a4b7a24e05 indra/newview/app_settings/settings.xml c7a4b7a24e05 indra/newview/llappviewer.cpp c7a4b7a24e05 indra/newview/llfloaterpreference.h c7a4b7a24e05 indra/newview/llfloaterpreference.cpp c7a4b7a24e05 indra/newview/llloginhandler.cpp c7a4b7a24e05 indra/newview/llpanellogin.h c7a4b7a24e05 indra/newview/llsecapi.h c7a4b7a24e05 indra/newview/llstartup.h c7a4b7a24e05 indra/newview/llstartup.cpp c7a4b7a24e05 indra/newview/llviewerfloaterreg.cpp c7a4b7a24e05 indra/newview/llxmlrpctransaction.cpp c7a4b7a24e05 indra/newview/skins/default/xui/en/floater_preferences_proxy.xml PRE-CREATION indra/newview/skins/default/xui/en/notifications.xml c7a4b7a24e05 indra/newview/skins/default/xui/en/panel_cof_wearables.xml c7a4b7a24e05 indra/newview/skins/default/xui/en/panel_preferences_privacy.xml c7a4b7a24e05 indra/newview/skins/default/xui/en/panel_preferences_setup.xml c7a4b7a24e05 Diff: http://codereview.secondlife.com/r/374/diff Testing ------- I've tested exclusively on Linux so far. I'm working on a more extensive test plan that includes setting up a gateway with a restrictive firewall to verify that all traffic is going through the proxy. Test builds and screenshots of the changed UI elements are available from the project page, located here: https://wiki.secondlife.com/wiki/User:Log_Linden/Socks5Viewer Thanks, Log -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110708/82d0ec48/attachment.htm From oz at lindenlab.com Fri Jul 8 12:30:56 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Fri, 08 Jul 2011 15:30:56 -0400 Subject: [opensource-dev] Autobuild errors In-Reply-To: References: <1310056650.22929.YahooMailNeo@web43510.mail.sp1.yahoo.com> Message-ID: <4E175AF0.6040704@lindenlab.com> On 2011-07-08 13:27, Lee ponzu wrote: > Still getting an error... > > mbpro:viewer-beta lee$ autobuild build --verbose -c ReleaseOS > executing configure command cmake -DCMAKE_BUILD_TYPE:STRING=Release > -DWORD_SIZE:STRING=32 -DROOT_PROJECT_NAME:STRING=SecondLife > -DINSTALL_PROPRIETARY=FALSE -G 'Xcode' ../indra > checking package fmod > installing fmod from archive You need to re-run the 'autobuild configure' with the *OS configuration. From Celierra at gmail.com Fri Jul 8 12:38:05 2011 From: Celierra at gmail.com (Celierra Darling) Date: Fri, 8 Jul 2011 15:38:05 -0400 Subject: [opensource-dev] Autobuild errors In-Reply-To: References: <1310056650.22929.YahooMailNeo@web43510.mail.sp1.yahoo.com> Message-ID: I don't have any familiarity with Xcode, so forwarding this thread back onto the list... Celi ---------- Forwarded message ---------- From: Lee ponzu Date: Fri, Jul 8, 2011 at 3:24 PM Subject: Re: [opensource-dev] Autobuild errors To: Celierra Darling No issues with KDU. The next problem is that I have Xcode 4 installed, so autobuild spit up on not finding the 10.5 SDK. I tried copying it over from Xcode 3, but that leads to new problems. Check dependencies Invalid value '4.0' for GCC_VERSION [WARN]Unable to determine concrete GCC compiler for file /Users/lee/Documents/viewer/viewer-beta/indra/cmake/cmake_dummy.cpp of type sourcecode.cpp.cpp. So, I suppose I wil have to figure out how to get autobuild to use Xcode 3.2 instead. Or just not build a viewer 8-( ponzu On Fri, Jul 8, 2011 at 1:49 PM, Celierra Darling wrote: > Cached in CMake. I'm guessing perhaps there's code in there where > -DINSTALL_PROPRIETARY=TRUE will cause DFMOD to be set to TRUE (like the > first time you ran it when you tried the Release configuration)? > > If the next error you're getting is about KDU, you want to add > -DUSE_KDU:BOOL=FALSE to the end of that. > > Celi > > > > On Fri, Jul 8, 2011 at 1:40 PM, Lee ponzu wrote: > >> Cached where? This is a fresh clone of viewer-beta, and the first time I >> ever tried autobuild... >> >> however, the advice is good. It didn't fail right away 8-) >> >> ponzu >> >> >> On Fri, Jul 8, 2011 at 1:33 PM, Celierra Darling wrote: >> >>> You might have some variables cached, maybe? Try explicitly setting -- >>> -DFMOD:BOOL=FALSE , like: >>> >>> autobuild build --verbose -c ReleaseOS -- -DFMOD:BOOL=FALSE >>> >>> (Feel free to Reply All to the list if this works. :p ) >>> >>> Celi >>> >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110708/40363223/attachment.htm From opensourceobscure at gmail.com Sat Jul 9 07:13:17 2011 From: opensourceobscure at gmail.com (opensourceobscure) Date: Sat, 9 Jul 2011 16:13:17 +0200 Subject: [opensource-dev] Snowstorm Review Build In-Reply-To: <4E171EFA.2000100@lindenlab.com> References: <4E171EFA.2000100@lindenlab.com> Message-ID: On Fri, Jul 8, 2011 at 17:15, Oz Linden (Scott Lawrence) wrote: > > There is a new PO review build available: > > http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_viewer-poreview/rev/235148/index.html > > Issues to be reviewed in this build: > STORM-1315 As a User, I want to be able to do simple math in numeric edit > fields. I only tried a few math operations and constants. Those worked. > STORM-1325 The viewer doesn't retry to upload baked textures if the > initial upload failed As said in the JIRA comments, it's hard to test this. I didn't test it. > STORM-1459 "Wearing Tab" - Add ability to copy > displayed inventory names to clipboard I confirm this works. Interestingly, I would have never thought this feature could be useful. But actually, the JIRA issue has almost 100 votes and lots of enthusiastic comments. I understand it will be very appreciated in the fashion community. This is a good occasion to note how our own personal needs, requirements and opinions are NOT representative of what should get into the Second Life viewer. > STORM-1472 Favorites folder in > inventory does not translate properly (Italian here) fixed. > STORM-1480 searching in the world map > clears the destination arrow but not the destination beacon Fixed. > STORM-1481 Jerky > transition when switching region from fixed sky to a day cycle Seems to be fixed. > STORM-1483 > Unable to delete the last water/sky/day preset This seems to be fixed for Sky presets only, BUT... I couldn't delete any Water or Day preset. When trying to delete Water or Day presets, the dropdown menu acts like there weren't any presets. > STORM-1484 No way to apply > changes in estate settings like Allow public access or Allow Voice Chat > after merging WLRS Fixed. Opensource Obscure -- http://twitter.com/oobscure - http://opensourceobscure.com/lol discuss Second Life Viewer 2: http://j.mp/slv2group From vsavchuk at productengine.com Sat Jul 9 08:03:27 2011 From: vsavchuk at productengine.com (Vadim Savchuk) Date: Sat, 9 Jul 2011 18:03:27 +0300 Subject: [opensource-dev] Snowstorm Review Build In-Reply-To: References: <4E171EFA.2000100@lindenlab.com> Message-ID: On Sat, Jul 9, 2011 at 5:13 PM, opensourceobscure < opensourceobscure at gmail.com> wrote: > > > STORM-1483 > > Unable to delete the last water/sky/day preset > > This seems to be fixed for Sky presets only, BUT... > I couldn't delete any Water or Day preset. > Have you created any water/day presets? System (out of the box) presets are not in the list. When trying to delete Water or Day presets, > the dropdown menu acts like there weren't any presets. > Right, not very nice. A better design is needed. -- Vadim -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110709/eec32b19/attachment.htm From opensourceobscure at gmail.com Sat Jul 9 08:17:24 2011 From: opensourceobscure at gmail.com (opensourceobscure) Date: Sat, 9 Jul 2011 17:17:24 +0200 Subject: [opensource-dev] Snowstorm Review Build In-Reply-To: References: <4E171EFA.2000100@lindenlab.com> Message-ID: On Sat, Jul 9, 2011 at 17:03, Vadim Savchuk wrote: > > On Sat, Jul 9, 2011 at 5:13 PM, opensourceobscure > wrote: >> >> > STORM-1483 >> > Unable to delete the last water/sky/day preset >> >> This seems to be fixed for Sky presets only, BUT... >> I couldn't delete any Water or Day preset. > > Have you created any water/day presets? System (out of the box) presets are > not in the list. I hadn't...sorry, I may have misread the JIRA description. Now that I created a Day preset and a Water preset, I could delete both of them. So, as far as I can tell, I confirm that STORM-1483 is fixed as well. Opensource Obscure -- http://twitter.com/oobscure - http://opensourceobscure.com/lol discuss Second Life Viewer 2: http://j.mp/slv2group From jaeger_Reg at hotmail.com Sun Jul 10 00:55:45 2011 From: jaeger_Reg at hotmail.com (Tankmaster Finesmith) Date: Sun, 10 Jul 2011 07:55:45 -0000 Subject: [opensource-dev] Review Request: Support SOCKS 5 proxy in the viewer. In-Reply-To: <20110708185507.16590.76473@domU-12-31-38-00-90-68.compute-1.internal> References: <20110708185507.16590.76473@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110710075545.7042.15657@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/374/#review855 ----------------------------------------------------------- It looks like you have the name= the same for the "Proxy Settings:" text as for "Software updates:" in the panel_preferences_setup.xml file. These need to be different for translations to work. - Tankmaster On July 8, 2011, 11:55 a.m., Log Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/374/ > ----------------------------------------------------------- > > (Updated July 8, 2011, 11:55 a.m.) > > > Review request for Viewer, Oz Linden, Monty Brandenberg, and Stone Linden. > > > Summary > ------- > > This is a continuation of Robin Cornelius's SOCKS 5 contribution, shown in https://codereview.secondlife.com/r/232/ . I have tried to address all of the comments on that code review and do as much cleanup as possible. The diff includes everything that was submitted by Robin, as well as my work. > Major changes since I started working: > * Changed SOCKS 5 proxy control channel to use the existing LLSocket class, which is a thin wrapper around APR sockets. > * Worked with the Linden Lab UX team to revamp the proxy controls. > * Proxy credentials are now stored in the LLSecAPI password storage, which is the same that is used for users' Second Life Credentials instead of as being stored in the clear as a preference. > > > This addresses bug STORM-1112. > http://jira.secondlife.com/browse/STORM-1112 > > > Diffs > ----- > > indra/llmessage/CMakeLists.txt c7a4b7a24e05 > indra/llmessage/llcurl.cpp c7a4b7a24e05 > indra/llmessage/lliosocket.h c7a4b7a24e05 > indra/llmessage/lliosocket.cpp c7a4b7a24e05 > indra/llmessage/llpacketring.h c7a4b7a24e05 > indra/llmessage/llpacketring.cpp c7a4b7a24e05 > indra/llmessage/llproxy.h PRE-CREATION > indra/llmessage/llproxy.cpp PRE-CREATION > indra/llmessage/net.h c7a4b7a24e05 > indra/llmessage/net.cpp c7a4b7a24e05 > indra/llui/llfunctorregistry.h c7a4b7a24e05 > indra/newview/app_settings/settings.xml c7a4b7a24e05 > indra/newview/llappviewer.cpp c7a4b7a24e05 > indra/newview/llfloaterpreference.h c7a4b7a24e05 > indra/newview/llfloaterpreference.cpp c7a4b7a24e05 > indra/newview/llloginhandler.cpp c7a4b7a24e05 > indra/newview/llpanellogin.h c7a4b7a24e05 > indra/newview/llsecapi.h c7a4b7a24e05 > indra/newview/llstartup.h c7a4b7a24e05 > indra/newview/llstartup.cpp c7a4b7a24e05 > indra/newview/llviewerfloaterreg.cpp c7a4b7a24e05 > indra/newview/llxmlrpctransaction.cpp c7a4b7a24e05 > indra/newview/skins/default/xui/en/floater_preferences_proxy.xml PRE-CREATION > indra/newview/skins/default/xui/en/notifications.xml c7a4b7a24e05 > indra/newview/skins/default/xui/en/panel_cof_wearables.xml c7a4b7a24e05 > indra/newview/skins/default/xui/en/panel_preferences_privacy.xml c7a4b7a24e05 > indra/newview/skins/default/xui/en/panel_preferences_setup.xml c7a4b7a24e05 > > Diff: http://codereview.secondlife.com/r/374/diff > > > Testing > ------- > > I've tested exclusively on Linux so far. I'm working on a more extensive test plan that includes setting up a gateway with a restrictive firewall to verify that all traffic is going through the proxy. > > Test builds and screenshots of the changed UI elements are available from the project page, located here: > https://wiki.secondlife.com/wiki/User:Log_Linden/Socks5Viewer > > > Thanks, > > Log > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110710/4e5f8bfb/attachment.htm From feedkatze at gmail.com Sun Jul 10 06:10:29 2011 From: feedkatze at gmail.com (feedkatze) Date: Sun, 10 Jul 2011 09:10:29 -0400 Subject: [opensource-dev] Autobuild errors In-Reply-To: <4E175AF0.6040704@lindenlab.com> References: <1310056650.22929.YahooMailNeo@web43510.mail.sp1.yahoo.com> <4E175AF0.6040704@lindenlab.com> Message-ID: <4E19A4C5.1080505@gmail.com> On 7/8/2011 3:30 PM, Oz Linden (Scott Lawrence) wrote: > On 2011-07-08 13:27, Lee ponzu wrote: >> Still getting an error... >> >> mbpro:viewer-beta lee$ autobuild build --verbose -c ReleaseOS >> executing configure command cmake -DCMAKE_BUILD_TYPE:STRING=Release >> -DWORD_SIZE:STRING=32 -DROOT_PROJECT_NAME:STRING=SecondLife >> -DINSTALL_PROPRIETARY=FALSE -G 'Xcode' ../indra >> checking package fmod >> installing fmod from archive > You need to re-run the 'autobuild configure' with the *OS configuration. > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges I am getting this same error on a clean VM with autobuild executed with "autobuild configure ReleaseOS --". From feedkatze at gmail.com Sun Jul 10 07:11:19 2011 From: feedkatze at gmail.com (feedkatze) Date: Sun, 10 Jul 2011 10:11:19 -0400 Subject: [opensource-dev] Autobuild errors In-Reply-To: <4E19A4C5.1080505@gmail.com> References: <1310056650.22929.YahooMailNeo@web43510.mail.sp1.yahoo.com> <4E175AF0.6040704@lindenlab.com> <4E19A4C5.1080505@gmail.com> Message-ID: <4E19B307.9060605@gmail.com> On 7/10/2011 9:10 AM, feedkatze wrote: > On 7/8/2011 3:30 PM, Oz Linden (Scott Lawrence) wrote: >> On 2011-07-08 13:27, Lee ponzu wrote: >>> Still getting an error... >>> >>> mbpro:viewer-beta lee$ autobuild build --verbose -c ReleaseOS >>> executing configure command cmake -DCMAKE_BUILD_TYPE:STRING=Release >>> -DWORD_SIZE:STRING=32 -DROOT_PROJECT_NAME:STRING=SecondLife >>> -DINSTALL_PROPRIETARY=FALSE -G 'Xcode' ../indra >>> checking package fmod >>> installing fmod from archive >> You need to re-run the 'autobuild configure' with the *OS configuration. >> _______________________________________________ >> Policies and (un)subscribe information available here: >> http://wiki.secondlife.com/wiki/OpenSource-Dev >> Please read the policies before posting to keep unmoderated posting >> privileges > I am getting this same error on a clean VM with autobuild executed > with "autobuild configure ReleaseOS --". Disregard, forgot the " -c " between configure and ReleaseOS. From sllists at boroon.dasgupta.ch Sun Jul 10 12:28:35 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Sun, 10 Jul 2011 19:28:35 -0000 Subject: [opensource-dev] Review Request: OPEN-99: use -march=pentium3 and -march=pentium4 only for 32 bit builds In-Reply-To: <20110622201936.24978.40203@domU-12-31-38-00-90-68.compute-1.internal> References: <20110622201936.24978.40203@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110710192835.7041.56874@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/351/ ----------------------------------------------------------- (Updated July 10, 2011, 12:28 p.m.) Review request for Viewer. Changes ------- added duplicate issues to 'Bugs' Summary ------- These flags prevent building for 64-bit (both standalone or non-standalone), so only use them for 32-bit builds. This addresses bugs CTS-315, OPEN-79 and OPEN-99. http://jira.secondlife.com/browse/CTS-315 http://jira.secondlife.com/browse/OPEN-79 http://jira.secondlife.com/browse/OPEN-99 Diffs ----- doc/contributions.txt e8f2a53c3d6e indra/cmake/00-Common.cmake e8f2a53c3d6e Diff: http://codereview.secondlife.com/r/351/diff Testing ------- Tried a non-standalone 64-bit build (without using 64-bit prebuilts, though): Fails with [ 11%] Building CXX object llcommon/CMakeFiles/llcommon.dir/u64.o Linking CXX shared library libllcommon.so /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible ${SRC_DIR}/build-linux-i686/packages/lib/release/libbreakpad_client.so when searching for -lbreakpad_client /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible ${SRC_DIR}/build-linux-i686/packages/lib/release/libaprutil-1.so when searching for -laprutil-1 /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible ${SRC_DIR}/build-linux-i686/packages/lib/release/libaprutil-1.a when searching for -laprutil-1 /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible ${SRC_DIR}/build-linux-i686/packages/lib/release/libdb-5.1.so when searching for -ldb-5.1 /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -ldb-5.1 collect2: ld returned 1 exit status make[2]: *** [llcommon/libllcommon.so] Error 1 make[1]: *** [llcommon/CMakeFiles/llcommon.dir/all] Error 2 make: *** [all] Error 2 ERROR: building default configuration returned 2 For more information: try re-running your command with --verbose or --debug (This is, off course, expected. Will have to produce my own 64bit prebuilts for local use.) Tried a standalone 64-bit build (after merging OPEN-38 changes): Fails by hitting https://jira.secondlife.com/browse/OPEN-100 (Both errors occur much later in the build process than the one that'd occur without this change.) Tried a non-standalone 32-bit build: Fails on https://jira.secondlife.com/browse/OPEN-23 , just as without this change. Thanks, Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110710/140bd4fd/attachment.htm From sllists at boroon.dasgupta.ch Sun Jul 10 12:59:47 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Sun, 10 Jul 2011 19:59:47 -0000 Subject: [opensource-dev] Review Request: OPEN-99: use -march=pentium3 and -march=pentium4 only for 32 bit builds In-Reply-To: <20110710192835.7041.56874@domU-12-31-38-00-90-68.compute-1.internal> References: <20110710192835.7041.56874@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110710195947.7040.48625@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/351/ ----------------------------------------------------------- (Updated July 10, 2011, 12:59 p.m.) Review request for Viewer and Nyx Linden. Changes ------- Added Nyx Linden to reviewers, as OPEN-79 is assigned to him. Summary ------- These flags prevent building for 64-bit (both standalone or non-standalone), so only use them for 32-bit builds. This addresses bugs CTS-315, OPEN-79 and OPEN-99. http://jira.secondlife.com/browse/CTS-315 http://jira.secondlife.com/browse/OPEN-79 http://jira.secondlife.com/browse/OPEN-99 Diffs ----- doc/contributions.txt e8f2a53c3d6e indra/cmake/00-Common.cmake e8f2a53c3d6e Diff: http://codereview.secondlife.com/r/351/diff Testing ------- Tried a non-standalone 64-bit build (without using 64-bit prebuilts, though): Fails with [ 11%] Building CXX object llcommon/CMakeFiles/llcommon.dir/u64.o Linking CXX shared library libllcommon.so /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible ${SRC_DIR}/build-linux-i686/packages/lib/release/libbreakpad_client.so when searching for -lbreakpad_client /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible ${SRC_DIR}/build-linux-i686/packages/lib/release/libaprutil-1.so when searching for -laprutil-1 /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible ${SRC_DIR}/build-linux-i686/packages/lib/release/libaprutil-1.a when searching for -laprutil-1 /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible ${SRC_DIR}/build-linux-i686/packages/lib/release/libdb-5.1.so when searching for -ldb-5.1 /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -ldb-5.1 collect2: ld returned 1 exit status make[2]: *** [llcommon/libllcommon.so] Error 1 make[1]: *** [llcommon/CMakeFiles/llcommon.dir/all] Error 2 make: *** [all] Error 2 ERROR: building default configuration returned 2 For more information: try re-running your command with --verbose or --debug (This is, off course, expected. Will have to produce my own 64bit prebuilts for local use.) Tried a standalone 64-bit build (after merging OPEN-38 changes): Fails by hitting https://jira.secondlife.com/browse/OPEN-100 (Both errors occur much later in the build process than the one that'd occur without this change.) Tried a non-standalone 32-bit build: Fails on https://jira.secondlife.com/browse/OPEN-23 , just as without this change. Thanks, Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110710/b48b3c30/attachment.htm From sllists at boroon.dasgupta.ch Sun Jul 10 18:24:17 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Mon, 11 Jul 2011 01:24:17 -0000 Subject: [opensource-dev] Review Request: STORM-1403: ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button names in People pane Message-ID: <20110711012417.10362.8489@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/387/ ----------------------------------------------------------- Review request for Viewer. Summary ------- The layout_panels containing the buttons didn't have unique names. Renamed them so that their names are now unique within their parent element. Removed the share_btn element and containing layout_panel from translations that contained it, as it doesn't occur in the English version. The English file mixed tabs and spaces. Converted tabs to spaces for that file. Stripped trailing whitespace from the English file. This addresses bug STORM-1403. http://jira.secondlife.com/browse/STORM-1403 Diffs ----- doc/contributions.txt 2204db549295 indra/newview/skins/minimal/xui/da/panel_people.xml 2204db549295 indra/newview/skins/minimal/xui/de/panel_people.xml 2204db549295 indra/newview/skins/minimal/xui/en/panel_people.xml 2204db549295 indra/newview/skins/minimal/xui/es/panel_people.xml 2204db549295 indra/newview/skins/minimal/xui/fr/panel_people.xml 2204db549295 indra/newview/skins/minimal/xui/it/panel_people.xml 2204db549295 indra/newview/skins/minimal/xui/ja/panel_people.xml 2204db549295 indra/newview/skins/minimal/xui/pl/panel_people.xml 2204db549295 indra/newview/skins/minimal/xui/pt/panel_people.xml 2204db549295 Diff: http://codereview.secondlife.com/r/387/diff Testing ------- Switched to French, relogged, changed to default mode and logged out. Applied this patch with -p3 to SecondLife-i686-2.7.5.233393/ (I'm using a downloaded build, as I still cannot complete a build again.) Logged in, clicked 'Personnes' button, then 'MES AMIS' tab. The Call and Teleport buttons were now labeled in French. Not tested: * Funktionality of the buttons. * Languages other than French. Thanks, Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110711/01dc426b/attachment.htm From slitovchuk at productengine.com Mon Jul 11 08:56:28 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Mon, 11 Jul 2011 15:56:28 -0000 Subject: [opensource-dev] Review Request: STORM-1403: ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button names in People pane In-Reply-To: <20110711012417.10362.8489@domU-12-31-38-00-90-68.compute-1.internal> References: <20110711012417.10362.8489@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110711155628.7036.30793@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/387/#review856 ----------------------------------------------------------- Ship it! Looks good. Works for me. - Seth On July 10, 2011, 6:24 p.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/387/ > ----------------------------------------------------------- > > (Updated July 10, 2011, 6:24 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > The layout_panels containing the buttons didn't have unique names. > Renamed them so that their names are now unique within their parent > element. > > Removed the share_btn element and containing layout_panel from translations that contained it, as it doesn't occur in the English version. > > The English file mixed tabs and spaces. Converted tabs to spaces for that file. > > Stripped trailing whitespace from the English file. > > > This addresses bug STORM-1403. > http://jira.secondlife.com/browse/STORM-1403 > > > Diffs > ----- > > doc/contributions.txt 2204db549295 > indra/newview/skins/minimal/xui/da/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/de/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/en/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/es/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/fr/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/it/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/ja/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/pl/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/pt/panel_people.xml 2204db549295 > > Diff: http://codereview.secondlife.com/r/387/diff > > > Testing > ------- > > Switched to French, relogged, changed to default mode and logged out. Applied this patch with -p3 to SecondLife-i686-2.7.5.233393/ (I'm using a downloaded build, as I still cannot complete a build again.) > > Logged in, clicked 'Personnes' button, then 'MES AMIS' tab. The Call and Teleport buttons were now labeled in French. > > Not tested: > * Funktionality of the buttons. > * Languages other than French. > > > Thanks, > > Boroondas > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110711/9079bb3e/attachment-0001.htm From sllists at boroon.dasgupta.ch Mon Jul 11 13:28:34 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Mon, 11 Jul 2011 20:28:34 -0000 Subject: [opensource-dev] Review Request: STORM-1403: ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button names in People pane In-Reply-To: <20110711155628.7036.30793@domU-12-31-38-00-90-68.compute-1.internal> References: <20110711155628.7036.30793@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110711202834.9774.80012@domU-12-31-38-00-90-68.compute-1.internal> > On July 11, 2011, 8:56 a.m., Seth ProductEngine wrote: > > Looks good. > > Works for me. Thanks for reviewing. As you write "Works for me.", I assume you tested it, too? Which languages did you try? - Boroondas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/387/#review856 ----------------------------------------------------------- On July 10, 2011, 6:24 p.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/387/ > ----------------------------------------------------------- > > (Updated July 10, 2011, 6:24 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > The layout_panels containing the buttons didn't have unique names. > Renamed them so that their names are now unique within their parent > element. > > Removed the share_btn element and containing layout_panel from translations that contained it, as it doesn't occur in the English version. > > The English file mixed tabs and spaces. Converted tabs to spaces for that file. > > Stripped trailing whitespace from the English file. > > > This addresses bug STORM-1403. > http://jira.secondlife.com/browse/STORM-1403 > > > Diffs > ----- > > doc/contributions.txt 2204db549295 > indra/newview/skins/minimal/xui/da/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/de/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/en/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/es/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/fr/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/it/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/ja/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/pl/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/pt/panel_people.xml 2204db549295 > > Diff: http://codereview.secondlife.com/r/387/diff > > > Testing > ------- > > Switched to French, relogged, changed to default mode and logged out. Applied this patch with -p3 to SecondLife-i686-2.7.5.233393/ (I'm using a downloaded build, as I still cannot complete a build again.) > > Logged in, clicked 'Personnes' button, then 'MES AMIS' tab. The Call and Teleport buttons were now labeled in French. > > Not tested: > * Funktionality of the buttons. > * Languages other than French. > > > Thanks, > > Boroondas > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110711/219d219c/attachment.htm From marinekelley at gmail.com Mon Jul 11 14:35:45 2011 From: marinekelley at gmail.com (Marine Kelley) Date: Mon, 11 Jul 2011 23:35:45 +0200 Subject: [opensource-dev] Viewer development 2.8.1 and a few new bugs Message-ID: Hi all, I was trying to adapt the RLV to the latest revision of viewer-development, and was quite satisfied with the results : - Far fewer crashes as opposed to 2.7.2 when the deferred renderer is activated - The "/me" issue in chat when the chat history is hidden is resolved too However, I am running into a few new issues, and I wonder if anyone spotted them too : - Invisiprims don't render well, they are completely black UNLESS they are set to fullbright (no matter whether deferred shading is on or off) - Alpha doesn't render well either, once again unless fullbright is on. Full strands of hair disappear, it's really ugly - The viewer slows down to a crawl when attaching or detaching objects (this is not a RLV bug, I've tested and observed this into the vanilla viewer too). Worse, if a second inventory window is visible but minimized, often it will bring it up ! - And the "/me" bug has now migrated to the chat history itself. It works on the chat floater, but if I say "/me smiles", I'll see "Marine KelleyMarine Kelley smiles" on the history. This is NOT due to the "Loading" bug though, this one is completely different and new. Is any of these new bugs in a JIRA already ? I don't even know what or where to search... Any pointer is appreciated. Thanks, Marine From laurent.bechir at madonie.org Mon Jul 11 15:42:52 2011 From: laurent.bechir at madonie.org (Laurent Bechir) Date: Tue, 12 Jul 2011 00:42:52 +0200 Subject: [opensource-dev] LLQtWebKit Mac OSX Build Instructions Message-ID: Hello, I'm trying to build LLQtWebKit and when it comes to JavaScriptCore, build fails with this message : http://pastie.org/2198921 Any idea which could help me ? I have a problem when building Kirstens Viewer on my Mac. LLQtWebKit doesn't work and always launch a 400 error. That's why I would like to try to build it from scratch to see if it could solve the problem. Thank you From wolfpup67 at earthlink.net Mon Jul 11 19:34:44 2011 From: wolfpup67 at earthlink.net (Wolfpup Lowenhar) Date: Tue, 12 Jul 2011 02:34:44 -0000 Subject: [opensource-dev] Review Request: Allow objects to have 99.99% max hollow for default hollow shape. Message-ID: <20110712023444.10261.34149@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/388/ ----------------------------------------------------------- Review request for Viewer. Summary ------- As a Builder, I want to be able to create prims that are more than 95 % hollow which will allow me to create more realistic paper sheets, flags, fabric bits, ribbons, etc. This addresses bug STORM-58. http://jira.secondlife.com/browse/STORM-58 Diffs ----- doc/contributions.txt d4cd5f0f33d2 indra/llmath/llvolume.cpp d4cd5f0f33d2 indra/newview/llpanelobject.cpp d4cd5f0f33d2 indra/newview/skins/default/xui/en/floater_tools.xml d4cd5f0f33d2 Diff: http://codereview.secondlife.com/r/388/diff Testing ------- Built viewer locally and testes Viewer Phase of Acceptance Criteria. Thanks, Wolfpup -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110712/e3d80c5d/attachment.htm From ardylay at gmail.com Mon Jul 11 19:57:48 2011 From: ardylay at gmail.com (Ardy Lay) Date: Mon, 11 Jul 2011 21:57:48 -0500 Subject: [opensource-dev] Viewer development 2.8.1 and a few new bugs In-Reply-To: References: Message-ID: <4E1BB82C.6030600@gmail.com> Shining SH-2048 Invisiprims that are members of an attached linkset are making the entire linkset invisible. https://jira.secondlife.com/browse/SH-2048 -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110711/1a305a91/attachment.htm From dahliatrimble at gmail.com Mon Jul 11 21:05:49 2011 From: dahliatrimble at gmail.com (Dahlia Trimble) Date: Mon, 11 Jul 2011 21:05:49 -0700 Subject: [opensource-dev] Review Request: Allow objects to have 99.99% max hollow for default hollow shape. In-Reply-To: <20110712023444.10261.34149@domU-12-31-38-00-90-68.compute-1.internal> References: <20110712023444.10261.34149@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: One thing I noticed while coding collision geometry for OpenSimulator is as hollow is increased and prims are twisted or otherwise manipulated such that the hollow shape doesnt exactly follow the outer shape, the probability increases that the surfaces formed by the triangles that make up the hollow shape may actually protrude beyond those that make up the outer surface. I'm not sure what SL sims do under these conditions but what ODE (Open Dynamics Engine - most commonly used physics engine in OpenSimulator) is create a condition where physical objects may become trapped between the resulting surfaces. ODE uses trimesh colliders and surface normals for determining collision surfaces and if prim hollow surfaces protrude outside of prim outer surfaces, the surface normals for these surfaces point in the wrong direction. This can be alleviated by increasing prim vertex count, but for some of these prims vertex count may already be even greater than 4000 vertices. Increasing it further would use excessive memory and likely increase the cost of computing collisions dramatically. I've found that a limit of 95% maximum hollow is a good compromise between prim complexity and usability. On Mon, Jul 11, 2011 at 7:34 PM, Wolfpup Lowenhar wrote: > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/388/ > Review request for Viewer. > By Wolfpup Lowenhar. > Description > > As a Builder, I want to be able to create prims that are more than 95 % hollow which will allow me to create more realistic paper sheets, flags, fabric bits, ribbons, etc. > > Testing > > Built viewer locally and testes Viewer Phase of Acceptance Criteria. > > *Bugs: * STORM-58 > Diffs > > - doc/contributions.txt (d4cd5f0f33d2) > - indra/llmath/llvolume.cpp (d4cd5f0f33d2) > - indra/newview/llpanelobject.cpp (d4cd5f0f33d2) > - indra/newview/skins/default/xui/en/floater_tools.xml (d4cd5f0f33d2) > > View Diff > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110711/07fa6517/attachment-0001.htm From marinekelley at gmail.com Mon Jul 11 23:11:44 2011 From: marinekelley at gmail.com (Marine Kelley) Date: Tue, 12 Jul 2011 08:11:44 +0200 Subject: [opensource-dev] Viewer development 2.8.1 and a few new bugs In-Reply-To: <4E1BB82C.6030600@gmail.com> References: <4E1BB82C.6030600@gmail.com> Message-ID: Thanks... That's not what I observe though, only the invisiprim goes black, obscuring the prims inside or behind it, but not the entire linkset On 12/07/2011, Ardy Lay wrote: > Shining SH-2048 Invisiprims that are members of an attached linkset are > making the entire linkset invisible. > https://jira.secondlife.com/browse/SH-2048 > > > From fleep513 at gmail.com Tue Jul 12 02:47:28 2011 From: fleep513 at gmail.com (Fleep Tuque) Date: Tue, 12 Jul 2011 05:47:28 -0400 Subject: [opensource-dev] SLCC 2011 - Call for Proposals Due 7/15 & Keynotes Announced Message-ID: Hi all, Just wanted to send a quick reminder that the Second Life Community Convention 2011 Call for Proposals is due this Friday, July 15th - so be sure to send in your proposal ASAP! * http://www.slconvention.org/program/call-for-proposals/ * Also, in appreciation for our speakers and presenters, all accepted speakers will be able to register for the Early Bird Registration price. The discount code to register at the reduced rate will be in your confirmation email. Thanks and let me know if you have any questions! - Chris/Fleep Second Life Community Convention 2011 Keynote Speakers Announced We are excited to announce the keynotes for this year?s 7th Annual Second Life Community Convention 2011, which will take place at the Oakland Marriott City Center in Oakland, CA from August 12-14, 2011. *Saturday, August 13, 2011 * AM Keynote Speaker - 8AM to 9AM PDT *Rik Panganiban (SL: Rik Riel)* *We Built This City: Creating a Better World* PM Keynote Speaker - 1PM to 2PM PDT *Rod Humble, CEO Linden Lab (SL: Rodvik Linden) * *The Future of Second Life* *Sunday, August 14, 2011* AM Keynote Speaker - 8AM to 9PM PDT *Aliza Sherman (SL: Cybergrrl Oh) * *FutureMobileGeekyTech: Our Virtual Lives* PM Keynote Panel - 1PM to 2PM PDT *John Laurence (SL: Durian Linden), Jeff Vogt (SL: Vogt Linden), Sarah Kuehnle (SL: Esbee Linden), Michael Gesner (SL: Gez Linden) and moderated by Peter Gray (SL: Peter Linden)* *The Future of the Second Life Platform* *Register* The Second Life Community Convention is three days of exciting activities, events, musical performances, machinima screenings, panels, workshops, and much more that showcases the abundant creativity of Second Life Residents. Register now and use the code SLCC-friend to receive 10% off! *Dont Just Attend - Be Part of the Convention* The July 15th Call for Proposalsdeadline is fast approaching, and with five new track themes and fun presentation formats, you still have the opportunity to share your hard work and creativity with the community that will most appreciate your efforts. Don?t want to give a full presentation? Consider doing a Speed Sparks session of 20 slides in 5 minutes to share the gist of your idea in a fast-paced presentation style that was a huge hit last year! *Volunteer* If you would like to help us run the show on the ground in Oakland or in-world, we invite you to join the team. It?s easy to ask ?Why don?t they do X?? but the real fun comes when you help make it happen! Apply to be a Staff Member (free registration), Oakland volunteer, or In-World volunteertoday! *Sponsor the Convention* If you have a product or service and want to get your message out to the most enthusiastic Second Life Residents, or if you just want to show your support, there?s no better place to spread the word than at the Second Life Community Convention. We have many levels of sponsorship, so it?s more than affordable to help support this non-profit, community produced event ? become a sponsor! *Organize a Social Event* We purposely keep the convention schedule light on Friday, August 12th to make sure there?s plenty of time for socializing and networking, and to give you the opportunity to organize your own fun events. Check out the Social Events & Mixers page to organize a social eventor outing for your friends and communities. Need ideas for things to do? We?ve put together a terrific guide of things to do In & Around Oakland to help you get started! *Planning Your Trip* We?ve also worked hard this year to help keep the cost of the convention affordable, and we have a number of resources available to help you plan your trip. The convention will be held at the Oakland Marriott City Center in the heart of downtown Oakland, CA ? just a 10 minute train ride from San Francisco. We?ve negotiated the best room rates we?ve ever gotten ? $109 a nightfor up to quad occupancy, and free wireless internet access in guest rooms. You must be registered for the convention to receive the group rate discount, and you will receive the link to reserve your rooms in the email confirmation you receive when you register for SLCC. Note that lunch on Saturday and Sunday is included in your convention registration, as well as free wireless internet access in all convention spaces. If you need information about flying, driving, or taking the train to SLCC, check out our transportation guideto get all the details you need to get to the convention. We hope you will join us for what promises to be a fun and thrilling three days of sharing, learning, and networking with Second Life Residents from around the world! See you in Oakland and we hope you can make it! Cheers, AvaCon, Inc Organizers of the Second Life Community Convention 275 Winthrop Street PO Box 618 Rehoboth, MA 02769-1819 (774) 654-0010 info at avacon.org http://slconvention.org -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110712/56941c9c/attachment.htm From wolfpup67 at earthlink.net Tue Jul 12 05:10:34 2011 From: wolfpup67 at earthlink.net (Brendan Wilson) Date: Tue, 12 Jul 2011 08:10:34 -0400 Subject: [opensource-dev] Review Request: Allow objects to have 99.99% max hollow for default hollow shape. In-Reply-To: References: <20110712023444.10261.34149@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <000c01cc408c$b401fcd0$1c05f670$@net> To try and help prevent this I selected to only have the default shape have a new max for instance if you have a cylinder and are using a hollow shape of say square in it then the max for that is still the same which is 70%. This way hopefully the issue you are talking about should not happen as the hollow default shape will follow the outside of the object more easily than the others. From: opensource-dev-bounces at lists.secondlife.com [mailto:opensource-dev-bounces at lists.secondlife.com] On Behalf Of Dahlia Trimble Sent: Tuesday, July 12, 2011 12:06 AM To: Viewer Subject: Re: [opensource-dev] Review Request: Allow objects to have 99.99% max hollow for default hollow shape. One thing I noticed while coding collision geometry for OpenSimulator is as hollow is increased and prims are twisted or otherwise manipulated such that the hollow shape doesnt exactly follow the outer shape, the probability increases that the surfaces formed by the triangles that make up the hollow shape may actually protrude beyond those that make up the outer surface. I'm not sure what SL sims do under these conditions but what ODE (Open Dynamics Engine - most commonly used physics engine in OpenSimulator) is create a condition where physical objects may become trapped between the resulting surfaces. ODE uses trimesh colliders and surface normals for determining collision surfaces and if prim hollow surfaces protrude outside of prim outer surfaces, the surface normals for these surfaces point in the wrong direction. This can be alleviated by increasing prim vertex count, but for some of these prims vertex count may already be even greater than 4000 vertices. Increasing it further would use excessive memory and likely increase the cost of computing collisions dramatically. I've found that a limit of 95% maximum hollow is a good compromise between prim complexity and usability. On Mon, Jul 11, 2011 at 7:34 PM, Wolfpup Lowenhar wrote: This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/388/ Review request for Viewer. By Wolfpup Lowenhar. Description As a Builder, I want to be able to create prims that are more than 95 % hollow which will allow me to create more realistic paper sheets, flags, fabric bits, ribbons, etc. Testing Built viewer locally and testes Viewer Phase of Acceptance Criteria. Bugs: STORM-58 Diffs * doc/contributions.txt (d4cd5f0f33d2) * indra/llmath/llvolume.cpp (d4cd5f0f33d2) * indra/newview/llpanelobject.cpp (d4cd5f0f33d2) * indra/newview/skins/default/xui/en/floater_tools.xml (d4cd5f0f33d2) View Diff _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges _____ No virus found in this message. Checked by AVG - www.avg.com Version: 10.0.1388 / Virus Database: 1516/3759 - Release Date: 07/11/11 -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110712/b2c54332/attachment-0001.htm From vsavchuk at productengine.com Tue Jul 12 08:45:42 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 12 Jul 2011 15:45:42 -0000 Subject: [opensource-dev] Review Request: OPEN-99: use -march=pentium3 and -march=pentium4 only for 32 bit builds In-Reply-To: <20110710195947.7040.48625@domU-12-31-38-00-90-68.compute-1.internal> References: <20110710195947.7040.48625@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110712154542.9687.25784@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/351/#review858 ----------------------------------------------------------- Ship it! Looks plausible. - Vadim On July 10, 2011, 12:59 p.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/351/ > ----------------------------------------------------------- > > (Updated July 10, 2011, 12:59 p.m.) > > > Review request for Viewer and Nyx Linden. > > > Summary > ------- > > These flags prevent building for 64-bit (both standalone or non-standalone), so only use them for 32-bit builds. > > > This addresses bugs CTS-315, OPEN-79 and OPEN-99. > http://jira.secondlife.com/browse/CTS-315 > http://jira.secondlife.com/browse/OPEN-79 > http://jira.secondlife.com/browse/OPEN-99 > > > Diffs > ----- > > doc/contributions.txt e8f2a53c3d6e > indra/cmake/00-Common.cmake e8f2a53c3d6e > > Diff: http://codereview.secondlife.com/r/351/diff > > > Testing > ------- > > Tried a non-standalone 64-bit build (without using 64-bit prebuilts, though): > Fails with > [ 11%] Building CXX object llcommon/CMakeFiles/llcommon.dir/u64.o > Linking CXX shared library libllcommon.so > /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible ${SRC_DIR}/build-linux-i686/packages/lib/release/libbreakpad_client.so when searching for -lbreakpad_client > /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible ${SRC_DIR}/build-linux-i686/packages/lib/release/libaprutil-1.so when searching for -laprutil-1 > /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible ${SRC_DIR}/build-linux-i686/packages/lib/release/libaprutil-1.a when searching for -laprutil-1 > /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible ${SRC_DIR}/build-linux-i686/packages/lib/release/libdb-5.1.so when searching for -ldb-5.1 > /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -ldb-5.1 > collect2: ld returned 1 exit status > make[2]: *** [llcommon/libllcommon.so] Error 1 > make[1]: *** [llcommon/CMakeFiles/llcommon.dir/all] Error 2 > make: *** [all] Error 2 > ERROR: building default configuration returned 2 > For more information: try re-running your command with --verbose or --debug > (This is, off course, expected. Will have to produce my own 64bit prebuilts for local use.) > > Tried a standalone 64-bit build (after merging OPEN-38 changes): > Fails by hitting https://jira.secondlife.com/browse/OPEN-100 > > (Both errors occur much later in the build process than the one that'd occur without this change.) > > Tried a non-standalone 32-bit build: > Fails on https://jira.secondlife.com/browse/OPEN-23 , just as without this change. > > > Thanks, > > Boroondas > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110712/e303b13c/attachment.htm From slitovchuk at productengine.com Tue Jul 12 08:59:45 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Tue, 12 Jul 2011 15:59:45 -0000 Subject: [opensource-dev] Review Request: STORM-1403: ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button names in People pane In-Reply-To: <20110711155628.7036.30793@domU-12-31-38-00-90-68.compute-1.internal> References: <20110711155628.7036.30793@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110712155945.9687.64011@domU-12-31-38-00-90-68.compute-1.internal> > On July 11, 2011, 8:56 a.m., Seth ProductEngine wrote: > > Looks good. > > Works for me. > > Boroondas Gupte wrote: > Thanks for reviewing. As you write "Works for me.", I assume you tested it, too? Which languages did you try? I tested for German and Spanish. - Seth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/387/#review856 ----------------------------------------------------------- On July 10, 2011, 6:24 p.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/387/ > ----------------------------------------------------------- > > (Updated July 10, 2011, 6:24 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > The layout_panels containing the buttons didn't have unique names. > Renamed them so that their names are now unique within their parent > element. > > Removed the share_btn element and containing layout_panel from translations that contained it, as it doesn't occur in the English version. > > The English file mixed tabs and spaces. Converted tabs to spaces for that file. > > Stripped trailing whitespace from the English file. > > > This addresses bug STORM-1403. > http://jira.secondlife.com/browse/STORM-1403 > > > Diffs > ----- > > doc/contributions.txt 2204db549295 > indra/newview/skins/minimal/xui/da/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/de/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/en/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/es/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/fr/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/it/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/ja/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/pl/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/pt/panel_people.xml 2204db549295 > > Diff: http://codereview.secondlife.com/r/387/diff > > > Testing > ------- > > Switched to French, relogged, changed to default mode and logged out. Applied this patch with -p3 to SecondLife-i686-2.7.5.233393/ (I'm using a downloaded build, as I still cannot complete a build again.) > > Logged in, clicked 'Personnes' button, then 'MES AMIS' tab. The Call and Teleport buttons were now labeled in French. > > Not tested: > * Funktionality of the buttons. > * Languages other than French. > > > Thanks, > > Boroondas > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110712/45cfd373/attachment.htm From vsavchuk at productengine.com Tue Jul 12 09:13:50 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 12 Jul 2011 16:13:50 -0000 Subject: [opensource-dev] Review Request: Allow objects to have 99.99% max hollow for default hollow shape. In-Reply-To: <20110712023444.10261.34149@domU-12-31-38-00-90-68.compute-1.internal> References: <20110712023444.10261.34149@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110712161350.7036.77355@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/388/#review860 ----------------------------------------------------------- Ship it! No objections. - Vadim On July 11, 2011, 7:34 p.m., Wolfpup Lowenhar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/388/ > ----------------------------------------------------------- > > (Updated July 11, 2011, 7:34 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > As a Builder, I want to be able to create prims that are more than 95 % hollow which will allow me to create more realistic paper sheets, flags, fabric bits, ribbons, etc. > > > This addresses bug STORM-58. > http://jira.secondlife.com/browse/STORM-58 > > > Diffs > ----- > > doc/contributions.txt d4cd5f0f33d2 > indra/llmath/llvolume.cpp d4cd5f0f33d2 > indra/newview/llpanelobject.cpp d4cd5f0f33d2 > indra/newview/skins/default/xui/en/floater_tools.xml d4cd5f0f33d2 > > Diff: http://codereview.secondlife.com/r/388/diff > > > Testing > ------- > > Built viewer locally and testes Viewer Phase of Acceptance Criteria. > > > Thanks, > > Wolfpup > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110712/e19507b7/attachment.htm From vsavchuk at productengine.com Tue Jul 12 11:04:42 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 12 Jul 2011 18:04:42 -0000 Subject: [opensource-dev] Review Request: OPEN-46: Copy3rdPartyLibs.cmake needs to account for Visual Studio 10 and Visual Studio 10 Express. In-Reply-To: <20110131153438.12722.5164@domU-12-31-38-00-90-68.compute-1.internal> References: <20110131153438.12722.5164@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110712180442.10322.3485@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/131/ ----------------------------------------------------------- (Updated July 12, 2011, 11:04 a.m.) Review request for Viewer. Changes ------- Updated ticket number. Summary (updated) ------- Copy3rdPartyLibs.cmake need to respond correctly under Visual Studio 10 and Visual Studio 10 Express Edition. This addresses bug OPEN-46. http://jira.secondlife.com/browse/OPEN-46 Diffs ----- indra/cmake/Copy3rdPartyLibs.cmake 691e3941d950 Diff: http://codereview.secondlife.com/r/131/diff Testing ------- Tested good under windows 7 64 bit and Visual Studio 10 Express Edition. Thanks, Nicky -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110712/42118a48/attachment-0001.htm From vsavchuk at productengine.com Tue Jul 12 11:07:52 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 12 Jul 2011 18:07:52 -0000 Subject: [opensource-dev] Review Request: STORM-64: Local Bitmap Browser implementation. In-Reply-To: <20110618150447.3681.36306@domU-12-31-38-00-90-68.compute-1.internal> References: <20110618150447.3681.36306@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110712180752.7037.81319@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/347/ ----------------------------------------------------------- (Updated July 12, 2011, 11:07 a.m.) Review request for Viewer. Summary (updated) ------- Local Bitmap Browser is a mechanism to locally load images into the viewer, track them and optionally (per each image) have it check if the image has been overwritten locally and if so - update it in the viewer and inworld. This change affects build menu by adding a way to open the floater there. This change also affects the texture picker - adding tabs that lets the user choose between the "Server" (regular inventory) and "Local" tabs (list of locally added files). This addresses bug STORM-64. http://jira.secondlife.com/browse/STORM-64 Diffs ----- doc/contributions.txt 6a3e7e403bd1 indra/llmath/llvolumemgr.h 6a3e7e403bd1 indra/llmath/llvolumemgr.cpp 6a3e7e403bd1 indra/newview/CMakeLists.txt 6a3e7e403bd1 indra/newview/llfloaterlocalbitmap.h PRE-CREATION indra/newview/llfloaterlocalbitmap.cpp PRE-CREATION indra/newview/lltexturectrl.h 6a3e7e403bd1 indra/newview/lltexturectrl.cpp 6a3e7e403bd1 indra/newview/llviewerfloaterreg.cpp 6a3e7e403bd1 indra/newview/llviewerobjectlist.h 6a3e7e403bd1 indra/newview/llviewertexturelist.h 6a3e7e403bd1 indra/newview/llvovolume.h 6a3e7e403bd1 indra/newview/skins/default/xui/en/floater_local_bitmap.xml PRE-CREATION indra/newview/skins/default/xui/en/floater_texture_ctrl.xml 6a3e7e403bd1 indra/newview/skins/default/xui/en/menu_viewer.xml 6a3e7e403bd1 Diff: http://codereview.secondlife.com/r/347/diff Testing ------- Texture/Sculptmap/Avatar Layer show. Texture/Sculptmap/Avatar Layer update. Multiple sculpties update. Opening multiple browser floaters works correctly. (two possible since one can be opened from menu above, one from texture picker. all of them + texture picker play nice.) Tested adding over 200 images at the same time. Thanks, Vaalith -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110712/cf7febe5/attachment.htm From vsavchuk at productengine.com Tue Jul 12 11:10:06 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 12 Jul 2011 18:10:06 -0000 Subject: [opensource-dev] Review Request: Viewer cache UI improvements. In-Reply-To: <20110603195652.7245.12799@domU-12-31-38-00-90-68.compute-1.internal> References: <20110603195652.7245.12799@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110712181006.7036.288@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/321/#review861 ----------------------------------------------------------- Log, is there a JIRA ticket associated with these changes? - Vadim On June 3, 2011, 12:56 p.m., Log Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/321/ > ----------------------------------------------------------- > > (Updated June 3, 2011, 12:56 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > This is mostly a UI change in support of the viewer cache improvements I have been making. The XUI changes were mocked up and approved by Wolf. > > * Moved viewer cache controls to the advanced tab of the preferences menu. > * Changed the cache size control to a spinner. > * Relabeled the reset button to "Default Location" to clarify the purpose. > * Readded a clear cache button. > * Increased the minimum cache size to 64MB and set the max to 9984MB. The increment in the spinner is 64 and both the min, max and default are multiples of 64. Wolf suggested using a high 4 digit number to allow the 4 digit wide spinner text box to suggest the maximum size of the cache. > > > Diffs > ----- > > indra/newview/skins/default/xui/en/panel_preferences_advanced.xml 9c0506d10226 > indra/newview/skins/default/xui/en/panel_preferences_setup.xml 9c0506d10226 > indra/newview/skins/default/xui/en/notifications.xml 9c0506d10226 > indra/newview/llappviewer.cpp 9c0506d10226 > indra/newview/llfloaterpreference.h 9c0506d10226 > indra/newview/llfloaterpreference.cpp 9c0506d10226 > > Diff: http://codereview.secondlife.com/r/321/diff > > > Testing > ------- > > I have built and tested all three platforms. I also tried switching between a viewer with a lower max or min. The value in the settings.xml file will be automatically clamped during the cache initialisation. On older viewers, when a user opens the settings tab with the cache size slider, it will jump to within the old bounds. When the user click ok in that preferences menu, the clamped value is saved in the settings file. In the new viewer with the spinner, the old out of bounds value will appear in the spinner until the user changes it. This won't have an effect on the value being used, because of the clamp during init. > > > Thanks, > > Log > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110712/3d242be6/attachment.htm From oz at lindenlab.com Tue Jul 12 11:10:13 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Tue, 12 Jul 2011 14:10:13 -0400 Subject: [opensource-dev] Search Backend Update - July 27th Message-ID: <4E1C8E05.7040003@lindenlab.com> -------- Original Message -------- Subject: Search Backend Update - July 27th Date: Tue, 12 Jul 2011 11:01:39 -0700 From: Nya Linden On July 27th, Search will be moving all web-based searching to the updated backend engine that has been in use in the ongoing Search beta. Any viewers or clients that point to http://search.secondlife.com will begin receiving results from the new system. The functionality will remain the same, however the results rankings will be different, as the new backend has updated algorithms for relevance. Change details: 1. Viewer 1 - All and Groups tabs will be moved to the new backend search engine. They will look the same, but the results will be ranked differently. Other tabs will not be affected. 2. Viewer 2 - Search will be moved to the new beta Search UI and backend in all versions of Viewer 2 3. Web searches will be moved to the new backend search engine - including Classifieds, Events, and Groups. 4. Any products using http://search.secondlife.com will begin receiving results from from the new backend. 5. The http://search-beta.secondlife.com url will still be live, and will be running the same version as search.secondlife.com for now. If you run into any issues, please use the feedback link at the top of the Search beta page, or file a jira in the Web project with a component of Search. Thank you! - Nya -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110712/6fc6b010/attachment-0001.htm From vsavchuk at productengine.com Tue Jul 12 11:12:50 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 12 Jul 2011 18:12:50 -0000 Subject: [opensource-dev] Review Request: OPEN-13: Debugging autobuild post build re-configuration error In-Reply-To: <20110208192554.29364.23941@domU-12-31-38-00-90-68.compute-1.internal> References: <20110208192554.29364.23941@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110712181250.7040.15852@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/137/ ----------------------------------------------------------- (Updated July 12, 2011, 11:12 a.m.) Review request for Viewer. Summary (updated) ------- Print out failed build_config from autobuild_tool_build.py This addresses bug OPEN-13. http://jira.secondlife.com/browse/OPEN-13 Diffs ----- autobuild/autobuild_tool_build.py ffcfcf7cde2c Diff: http://codereview.secondlife.com/r/137/diff Testing ------- Just started, trying to determine if the error can be corrected with autobuild.xml entries or by post-build string adjustments. Thanks, Nicky -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110712/88aa8188/attachment.htm From vsavchuk at productengine.com Tue Jul 12 11:15:20 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 12 Jul 2011 18:15:20 -0000 Subject: [opensource-dev] Review Request: STORM-1017: Attachments may loose their associated inventory item UUID In-Reply-To: <20110222124922.31178.48193@domU-12-31-38-00-90-68.compute-1.internal> References: <20110222124922.31178.48193@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110712181520.10362.88857@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/161/ ----------------------------------------------------------- (Updated July 12, 2011, 11:15 a.m.) Review request for Viewer. Summary (updated) ------- Current flow: 1) object->extractAttachmentItemID() 2) "same object reattached" condition evaluates true => removeObject calls object->setAttachmentItemID(LLUUID::null) 3) the remainder of addObject() executes but the object's mAttachmentItemID is now "LLUUID::null" Reversing the order of (1) and (2) should prevent mAttachmentItemID from being - in this specific case accidentally - cleared This addresses bug STORM-1017. http://jira.secondlife.com/browse/STORM-1017 Diffs ----- indra/newview/llviewerjointattachment.cpp UNKNOWN Diff: http://codereview.secondlife.com/r/161/diff Testing ------- I can't trigger that block for my avie's attachments "on demand" but I actually made this change a while back (before SVC-6766) in response to reports from users and this was the only possibility I could find in the viewer where an attachment may suddenly "forget" its associated inventory item. Thanks, Kitty -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110712/7c36e28a/attachment.htm From dahliatrimble at gmail.com Tue Jul 12 11:16:12 2011 From: dahliatrimble at gmail.com (Dahlia Trimble) Date: Tue, 12 Jul 2011 11:16:12 -0700 Subject: [opensource-dev] Review Request: Allow objects to have 99.99% max hollow for default hollow shape. In-Reply-To: <20110712161350.7036.77355@domU-12-31-38-00-90-68.compute-1.internal> References: <20110712023444.10261.34149@domU-12-31-38-00-90-68.compute-1.internal> <20110712161350.7036.77355@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: Unfortunately it does happen, especially when prims are twisted or otherwise skewed. 99.99 is too close. You may mot see it in a viewer but physics will not work with it. I believe the current 95% limits are there for a reason and the original designers may not be around to defend it or have documented it. On Tue, Jul 12, 2011 at 9:13 AM, Vadim ProductEngine < vsavchuk at productengine.com> wrote: > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/388/ > > Ship it! > > No objections. > > > - Vadim > > On July 11th, 2011, 7:34 p.m., Wolfpup Lowenhar wrote: > Review request for Viewer. > By Wolfpup Lowenhar. > > *Updated July 11, 2011, 7:34 p.m.* > Description > > As a Builder, I want to be able to create prims that are more than 95 % hollow which will allow me to create more realistic paper sheets, flags, fabric bits, ribbons, etc. > > Testing > > Built viewer locally and testes Viewer Phase of Acceptance Criteria. > > *Bugs: * STORM-58 > Diffs > > - doc/contributions.txt (d4cd5f0f33d2) > - indra/llmath/llvolume.cpp (d4cd5f0f33d2) > - indra/newview/llpanelobject.cpp (d4cd5f0f33d2) > - indra/newview/skins/default/xui/en/floater_tools.xml (d4cd5f0f33d2) > > View Diff > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110712/16017f4a/attachment.htm From vsavchuk at productengine.com Tue Jul 12 11:18:47 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 12 Jul 2011 18:18:47 -0000 Subject: [opensource-dev] Review Request: STORM-1112 Implement SOCKS 5 Proxy for the viewer In-Reply-To: <20110328114624.3746.23475@domU-12-31-38-00-90-68.compute-1.internal> References: <20110328114624.3746.23475@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110712181847.9625.2691@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/232/ ----------------------------------------------------------- (Updated July 12, 2011, 11:18 a.m.) Review request for Viewer. Summary (updated) ------- VWR-20801 - Add ability to use SOCKS 5 proxy to the viewer. This allows the UDP and/or the http requests to be sent via a SOCKS 5 proxy. This also allows http proxies to be used for other http operations such as caps etc as required. All the proxy settings have been unified on a single proxy floater accessable from preferences. This addresses bug STORM-1112. http://jira.secondlife.com/browse/STORM-1112 Diffs ----- indra/llmessage/CMakeLists.txt 65ff7415f171 indra/llmessage/llcurl.cpp 65ff7415f171 indra/llmessage/llpacketring.h 65ff7415f171 indra/llmessage/llpacketring.cpp 65ff7415f171 indra/llmessage/llsocks5.h PRE-CREATION indra/llmessage/llsocks5.cpp PRE-CREATION indra/llmessage/net.h 65ff7415f171 indra/llmessage/net.cpp 65ff7415f171 indra/newview/app_settings/settings.xml 65ff7415f171 indra/newview/llfloaterpreference.h 65ff7415f171 indra/newview/llfloaterpreference.cpp 65ff7415f171 indra/newview/llstartup.h 65ff7415f171 indra/newview/llstartup.cpp 65ff7415f171 indra/newview/llviewerfloaterreg.cpp 65ff7415f171 indra/newview/llxmlrpctransaction.cpp 65ff7415f171 indra/newview/skins/default/xui/en/floater_preferences_proxy.xml PRE-CREATION indra/newview/skins/default/xui/en/notifications.xml 65ff7415f171 indra/newview/skins/default/xui/en/panel_preferences_setup.xml 65ff7415f171 Diff: http://codereview.secondlife.com/r/232/diff Testing ------- Verified login and in world interaction with proxy disabled, verified login and in world interactionvia socks 5 proxy. Code has been tested on Windows very recently and has also worked fine on linux, but i'm not currently in a position to retest that or Mac at all. Much more testing is needed to verify this does not break anything unexpectedly and also works as expected when enabled. To test requires a working socks 5 proxy. Thanks, Robin -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110712/46cf9a83/attachment.htm From log at lindenlab.com Tue Jul 12 11:20:06 2011 From: log at lindenlab.com (Log Linden) Date: Tue, 12 Jul 2011 18:20:06 -0000 Subject: [opensource-dev] Review Request: Viewer cache UI improvements. In-Reply-To: <20110603195652.7245.12799@domU-12-31-38-00-90-68.compute-1.internal> References: <20110603195652.7245.12799@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110712182006.8726.9690@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/321/ ----------------------------------------------------------- (Updated July 12, 2011, 11:20 a.m.) Review request for Viewer. Changes ------- Added relevant jira tickets. Summary ------- This is mostly a UI change in support of the viewer cache improvements I have been making. The XUI changes were mocked up and approved by Wolf. * Moved viewer cache controls to the advanced tab of the preferences menu. * Changed the cache size control to a spinner. * Relabeled the reset button to "Default Location" to clarify the purpose. * Readded a clear cache button. * Increased the minimum cache size to 64MB and set the max to 9984MB. The increment in the spinner is 64 and both the min, max and default are multiples of 64. Wolf suggested using a high 4 digit number to allow the 4 digit wide spinner text box to suggest the maximum size of the cache. This addresses bugs ER-814, ER-818 and ER-831. http://jira.secondlife.com/browse/ER-814 http://jira.secondlife.com/browse/ER-818 http://jira.secondlife.com/browse/ER-831 Diffs ----- indra/newview/skins/default/xui/en/panel_preferences_advanced.xml 9c0506d10226 indra/newview/skins/default/xui/en/panel_preferences_setup.xml 9c0506d10226 indra/newview/skins/default/xui/en/notifications.xml 9c0506d10226 indra/newview/llappviewer.cpp 9c0506d10226 indra/newview/llfloaterpreference.h 9c0506d10226 indra/newview/llfloaterpreference.cpp 9c0506d10226 Diff: http://codereview.secondlife.com/r/321/diff Testing ------- I have built and tested all three platforms. I also tried switching between a viewer with a lower max or min. The value in the settings.xml file will be automatically clamped during the cache initialisation. On older viewers, when a user opens the settings tab with the cache size slider, it will jump to within the old bounds. When the user click ok in that preferences menu, the clamped value is saved in the settings file. In the new viewer with the spinner, the old out of bounds value will appear in the spinner until the user changes it. This won't have an effect on the value being used, because of the clamp during init. Thanks, Log -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110712/7fbf1474/attachment-0001.htm From vsavchuk at productengine.com Tue Jul 12 11:20:22 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 12 Jul 2011 18:20:22 -0000 Subject: [opensource-dev] Review Request: STORM-1112 Support SOCKS 5 proxy in the viewer (take 2) In-Reply-To: <20110708185507.16590.76473@domU-12-31-38-00-90-68.compute-1.internal> References: <20110708185507.16590.76473@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110712182022.7036.48966@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/374/ ----------------------------------------------------------- (Updated July 12, 2011, 11:20 a.m.) Review request for Viewer, Oz Linden, Monty Brandenberg, and Stone Linden. Summary (updated) ------- This is a continuation of Robin Cornelius's SOCKS 5 contribution, shown in https://codereview.secondlife.com/r/232/ . I have tried to address all of the comments on that code review and do as much cleanup as possible. The diff includes everything that was submitted by Robin, as well as my work. Major changes since I started working: * Changed SOCKS 5 proxy control channel to use the existing LLSocket class, which is a thin wrapper around APR sockets. * Worked with the Linden Lab UX team to revamp the proxy controls. * Proxy credentials are now stored in the LLSecAPI password storage, which is the same that is used for users' Second Life Credentials instead of as being stored in the clear as a preference. This addresses bug STORM-1112. http://jira.secondlife.com/browse/STORM-1112 Diffs ----- indra/llmessage/CMakeLists.txt c7a4b7a24e05 indra/llmessage/llcurl.cpp c7a4b7a24e05 indra/llmessage/lliosocket.h c7a4b7a24e05 indra/llmessage/lliosocket.cpp c7a4b7a24e05 indra/llmessage/llpacketring.h c7a4b7a24e05 indra/llmessage/llpacketring.cpp c7a4b7a24e05 indra/llmessage/llproxy.h PRE-CREATION indra/llmessage/llproxy.cpp PRE-CREATION indra/llmessage/net.h c7a4b7a24e05 indra/llmessage/net.cpp c7a4b7a24e05 indra/llui/llfunctorregistry.h c7a4b7a24e05 indra/newview/app_settings/settings.xml c7a4b7a24e05 indra/newview/llappviewer.cpp c7a4b7a24e05 indra/newview/llfloaterpreference.h c7a4b7a24e05 indra/newview/llfloaterpreference.cpp c7a4b7a24e05 indra/newview/llloginhandler.cpp c7a4b7a24e05 indra/newview/llpanellogin.h c7a4b7a24e05 indra/newview/llsecapi.h c7a4b7a24e05 indra/newview/llstartup.h c7a4b7a24e05 indra/newview/llstartup.cpp c7a4b7a24e05 indra/newview/llviewerfloaterreg.cpp c7a4b7a24e05 indra/newview/llxmlrpctransaction.cpp c7a4b7a24e05 indra/newview/skins/default/xui/en/floater_preferences_proxy.xml PRE-CREATION indra/newview/skins/default/xui/en/notifications.xml c7a4b7a24e05 indra/newview/skins/default/xui/en/panel_cof_wearables.xml c7a4b7a24e05 indra/newview/skins/default/xui/en/panel_preferences_privacy.xml c7a4b7a24e05 indra/newview/skins/default/xui/en/panel_preferences_setup.xml c7a4b7a24e05 Diff: http://codereview.secondlife.com/r/374/diff Testing ------- I've tested exclusively on Linux so far. I'm working on a more extensive test plan that includes setting up a gateway with a restrictive firewall to verify that all traffic is going through the proxy. Test builds and screenshots of the changed UI elements are available from the project page, located here: https://wiki.secondlife.com/wiki/User:Log_Linden/Socks5Viewer Thanks, Log -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110712/f6464400/attachment.htm From vsavchuk at productengine.com Tue Jul 12 11:23:38 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 12 Jul 2011 18:23:38 -0000 Subject: [opensource-dev] Review Request: STORM-1068 Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range In-Reply-To: <20110312160032.20109.88549@domU-12-31-38-00-90-68.compute-1.internal> References: <20110312160032.20109.88549@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110712182338.7037.95516@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/197/ ----------------------------------------------------------- (Updated July 12, 2011, 11:23 a.m.) Review request for Viewer. Summary (updated) ------- Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range. By default the range ring is off. To turn it on you right click on the mini-map and pick the menu entry "Range Ring". This addresses bug Storm-1068. http://jira.secondlife.com/browse/Storm-1068 Diffs ----- doc/contributions.txt aed94e854443 indra/newview/app_settings/settings.xml aed94e854443 indra/newview/llnetmap.h aed94e854443 indra/newview/llnetmap.cpp aed94e854443 indra/newview/skins/default/colors.xml aed94e854443 indra/newview/skins/default/xui/en/menu_mini_map.xml aed94e854443 Diff: http://codereview.secondlife.com/r/197/diff Testing ------- Tested with another avatar. When they are outside the ring they cannot see my local chat and when they are inside it they can, so the ring's radius is set correctly. Flew over various types of land to make sure my color choice (blue @10%) was always visible. Enabled range ring, logged out and back on; range ring is still present on mini-map. Panned mini-map, range ring remains centered over avatar. Used mouse wheel to zoom in and out as far as possible. Size of range ring varied with change in zoom level. Thanks, Jonathan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110712/a42f68ce/attachment.htm From vsavchuk at productengine.com Tue Jul 12 11:35:20 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 12 Jul 2011 18:35:20 -0000 Subject: [opensource-dev] Review Request: OPEN-69 Convert autobuild library builds to use msbuild.exe instead of devenv.com. In-Reply-To: <20110518121339.4556.78343@domU-12-31-38-00-90-68.compute-1.internal> References: <20110518121339.4556.78343@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110712183520.7038.82695@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/312/ ----------------------------------------------------------- (Updated July 12, 2011, 11:35 a.m.) Review request for Viewer. Summary (updated) ------- Convert autobuild library builds to use msbuild.exe instead of devenv.com. Includes Ima Mechanique change from http://codereview.secondlife.com/r/305/ This addresses bug OPEN-69. http://jira.secondlife.com/browse/OPEN-69 Diffs ----- autobuild/autobuild_tool_source_environment.py 2a560b1d8f95 Diff: http://codereview.secondlife.com/r/312/diff Testing ------- Made calling script 3p-ogvoribs/build-cmd.sh changes, which will be published later, to use msbuild parameters and successfully built and packaged library. Compared files in the package to those from LL prebuilt download and they match by name and size. TODO: Build the viewer with the local package. DONE: Built viewer (16169) prior to mesh and logged to agni and played audio streams with no problems. Built and packaged 3p-ogvorbis with added parameters. Thanks, Nicky -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110712/e6ef7532/attachment.htm From vsavchuk at productengine.com Tue Jul 12 11:36:28 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 12 Jul 2011 18:36:28 -0000 Subject: [opensource-dev] Review Request: OPEN-66 Update autobuilds default VC version to 2010 In-Reply-To: <20110603144338.6380.92934@domU-12-31-38-00-90-68.compute-1.internal> References: <20110603144338.6380.92934@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110712183628.9774.883@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/305/ ----------------------------------------------------------- (Updated July 12, 2011, 11:36 a.m.) Review request for Viewer. Summary (updated) ------- Autobuild defaults to VC 2005 if the environment variable AUTOBUILD_VSVER is unset. Now that LL have moved to VC 2010 completely, shouldn't this become the default version? This addresses bug open-66. http://jira.secondlife.com/browse/open-66 Diffs ----- autobuild/autobuild_tool_source_environment.py 2a560b1d8f95 Diff: http://codereview.secondlife.com/r/305/diff Testing ------- Thanks, Ima -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110712/b0cd57cc/attachment-0001.htm From vsavchuk at productengine.com Tue Jul 12 11:37:09 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 12 Jul 2011 18:37:09 -0000 Subject: [opensource-dev] Review Request: OPEN-21 patch to let 3D connexion devices work on linux with kernel 2.6.35 or newer In-Reply-To: <20110604011027.6381.3327@domU-12-31-38-00-90-68.compute-1.internal> References: <20110604011027.6381.3327@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110712183709.8726.39470@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/322/ ----------------------------------------------------------- (Updated July 12, 2011, 11:37 a.m.) Review request for Viewer. Summary (updated) ------- fix for OPEN-21 added EVDEV layer for linux users on 2.6.35+ kernels - added both personal 3P libs and indra subdir (and cmake NDOF.cmake file fix), first one less usefull, should be more better find a place where put prebuilt lib (jira affect only linux) This addresses bug OPEN-21. http://jira.secondlife.com/browse/OPEN-21 Diffs ----- autobuild.xml d74fd886c8a6 doc/contributions.txt d74fd886c8a6 indra/cmake/NDOF.cmake d74fd886c8a6 indra/llndof-linux/CMakeLists.txt PRE-CREATION indra/llndof-linux/Makefile PRE-CREATION indra/llndof-linux/ndofdev.c PRE-CREATION indra/llndof-linux/ndofdev_external.h PRE-CREATION Diff: http://codereview.secondlife.com/r/322/diff Testing ------- I suppose "on my linux system work" is a poor point, using prebuilt ?libs since long, the cmake and subdir work using autobuild with "ReleaseOS" Thanks, Altair -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110712/42875292/attachment.htm From vsavchuk at productengine.com Tue Jul 12 11:42:24 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 12 Jul 2011 18:42:24 -0000 Subject: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale In-Reply-To: <20110630173342.23142.27597@domU-12-31-38-00-90-68.compute-1.internal> References: <20110630173342.23142.27597@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110712184224.10322.38900@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/365/#review862 ----------------------------------------------------------- Diff r4 looks broken to me. And yes, a clean fork would be nice. - Vadim On June 30, 2011, 10:33 a.m., Kadah Coba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/365/ > ----------------------------------------------------------- > > (Updated June 30, 2011, 10:33 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > This change makes it so setting an object for sale or modifying the price or sale type requires explicitly applying the changes. Default behavior before this patch is all sale info is committed to sim on change. After this patch the sale info will only get set or modified after hitting a "mark for sale" button. There is no change to removing an object from sale, unchecking "For sale" will be committed to sim without further user interation. > > https://bitbucket.org/Kadah_Coba/vwr-21522 > Main Patch: https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/45df3e1e9f6f > German translation: https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/01dc58391588 > > > This addresses bug VWR-21522. > http://jira.secondlife.com/browse/VWR-21522 > > > Diffs > ----- > > doc/contributions.txt UNKNOWN > indra/newview/llpanelpermissions.h UNKNOWN > indra/newview/llpanelpermissions.cpp UNKNOWN > indra/newview/skins/default/xui/de/floater_tools.xml UNKNOWN > indra/newview/skins/default/xui/en/floater_tools.xml UNKNOWN > > Diff: http://codereview.secondlife.com/r/365/diff > > > Testing > ------- > > (I had stuff here but Review Board kept deleting it every time I tried to save.) > > > Thanks, > > Kadah > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110712/d6655087/attachment.htm From vsavchuk at productengine.com Tue Jul 12 11:42:56 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 12 Jul 2011 18:42:56 -0000 Subject: [opensource-dev] Review Request: STORM-1453: Prevent unintended 10L sale In-Reply-To: <20110630173342.23142.27597@domU-12-31-38-00-90-68.compute-1.internal> References: <20110630173342.23142.27597@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110712184256.7042.14648@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/365/ ----------------------------------------------------------- (Updated July 12, 2011, 11:42 a.m.) Review request for Viewer. Changes ------- Updated ticket number. Summary (updated) ------- This change makes it so setting an object for sale or modifying the price or sale type requires explicitly applying the changes. Default behavior before this patch is all sale info is committed to sim on change. After this patch the sale info will only get set or modified after hitting a "mark for sale" button. There is no change to removing an object from sale, unchecking "For sale" will be committed to sim without further user interation. https://bitbucket.org/Kadah_Coba/vwr-21522 Main Patch: https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/45df3e1e9f6f German translation: https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/01dc58391588 This addresses bug STORM-1453. http://jira.secondlife.com/browse/STORM-1453 Diffs ----- doc/contributions.txt UNKNOWN indra/newview/llpanelpermissions.h UNKNOWN indra/newview/llpanelpermissions.cpp UNKNOWN indra/newview/skins/default/xui/de/floater_tools.xml UNKNOWN indra/newview/skins/default/xui/en/floater_tools.xml UNKNOWN Diff: http://codereview.secondlife.com/r/365/diff Testing ------- (I had stuff here but Review Board kept deleting it every time I tried to save.) Thanks, Kadah -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110712/7980471e/attachment.htm From vsavchuk at productengine.com Tue Jul 12 11:47:18 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 12 Jul 2011 18:47:18 -0000 Subject: [opensource-dev] Review Request: STORM-58 Allow objects to have 99.99% max hollow for default hollow shape. In-Reply-To: <20110712023444.10261.34149@domU-12-31-38-00-90-68.compute-1.internal> References: <20110712023444.10261.34149@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110712184718.10350.92087@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/388/ ----------------------------------------------------------- (Updated July 12, 2011, 11:47 a.m.) Review request for Viewer. Summary (updated) ------- As a Builder, I want to be able to create prims that are more than 95 % hollow which will allow me to create more realistic paper sheets, flags, fabric bits, ribbons, etc. This addresses bug STORM-58. http://jira.secondlife.com/browse/STORM-58 Diffs ----- doc/contributions.txt d4cd5f0f33d2 indra/llmath/llvolume.cpp d4cd5f0f33d2 indra/newview/llpanelobject.cpp d4cd5f0f33d2 indra/newview/skins/default/xui/en/floater_tools.xml d4cd5f0f33d2 Diff: http://codereview.secondlife.com/r/388/diff Testing ------- Built viewer locally and testes Viewer Phase of Acceptance Criteria. Thanks, Wolfpup -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110712/b4678413/attachment.htm From vsavchuk at productengine.com Tue Jul 12 11:54:28 2011 From: vsavchuk at productengine.com (Vadim Savchuk) Date: Tue, 12 Jul 2011 21:54:28 +0300 Subject: [opensource-dev] Review Request: Allow objects to have 99.99% max hollow for default hollow shape. In-Reply-To: References: <20110712023444.10261.34149@domU-12-31-38-00-90-68.compute-1.internal> <20110712161350.7036.77355@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <4E1C9864.4000908@productengine.com> Dahlia, please comment in the ticket for the Product Owner to notice. On 07/12/2011 09:16 PM, Dahlia Trimble wrote: > Unfortunately it does happen, especially when prims are twisted or > otherwise skewed. 99.99 is too close. You may mot see it in a viewer > but physics will not work with it. I believe the current 95% limits > are there for a reason and the original designers may not be around to > defend it or have documented it. -- Vadim From dahliatrimble at gmail.com Tue Jul 12 12:47:13 2011 From: dahliatrimble at gmail.com (Dahlia Trimble) Date: Tue, 12 Jul 2011 12:47:13 -0700 Subject: [opensource-dev] Review Request: Allow objects to have 99.99% max hollow for default hollow shape. In-Reply-To: <4E1C9864.4000908@productengine.com> References: <20110712023444.10261.34149@domU-12-31-38-00-90-68.compute-1.internal> <20110712161350.7036.77355@domU-12-31-38-00-90-68.compute-1.internal> <4E1C9864.4000908@productengine.com> Message-ID: Unfortunately the official reply mechanism has the following restrictions: "*In order to post reviews or comment on them in this system, you must either: * * * - *be an employee of or contractor for Linden Lab* - *have executed a Contribution Agreement *** " I'll IM Oz and refer him to this discussion. On Tue, Jul 12, 2011 at 11:54 AM, Vadim Savchuk wrote: > Dahlia, please comment in the ticket for the Product Owner to notice. > > > On 07/12/2011 09:16 PM, Dahlia Trimble wrote: > >> Unfortunately it does happen, especially when prims are twisted or >> otherwise skewed. 99.99 is too close. You may mot see it in a viewer but >> physics will not work with it. I believe the current 95% limits are there >> for a reason and the original designers may not be around to defend it or >> have documented it. >> > > -- > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110712/4a4d68b4/attachment.htm From sllists at boroon.dasgupta.ch Tue Jul 12 12:57:12 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Tue, 12 Jul 2011 21:57:12 +0200 Subject: [opensource-dev] Review Request: Allow objects to have 99.99% max hollow for default hollow shape. In-Reply-To: References: <20110712023444.10261.34149@domU-12-31-38-00-90-68.compute-1.internal> <20110712161350.7036.77355@domU-12-31-38-00-90-68.compute-1.internal> <4E1C9864.4000908@productengine.com> Message-ID: <4E1CA718.7040807@boroon.dasgupta.ch> On 07/12/2011 09:47 PM, Dahlia Trimble wrote: > On Tue, Jul 12, 2011 at 11:54 AM, Vadim Savchuk > > wrote: > > Dahlia, please comment in the ticket for the Product Owner to notice. > > > Unfortunately the official reply mechanism has the following restrictions: > > "*In order to post reviews or comment on them in this system, you must > either: * > > * ** *be an employee of or contractor for Linden Lab* > * *have executed a Contribution Agreement > * > ** > > " > > I'll IM Oz and refer him to this discussion. I think by "ticket", Vadim meant the jira issue. I've already left a comment there with a reference to this discussion. Cheers, Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110712/92465948/attachment.htm From monty at lindenlab.com Tue Jul 12 14:35:02 2011 From: monty at lindenlab.com (Monty Brandenberg) Date: Tue, 12 Jul 2011 21:35:02 -0000 Subject: [opensource-dev] Review Request: STORM-1112 Support SOCKS 5 proxy in the viewer (take 2) In-Reply-To: <20110712182022.7036.48966@domU-12-31-38-00-90-68.compute-1.internal> References: <20110712182022.7036.48966@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110712213502.10427.45532@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/374/#review863 ----------------------------------------------------------- indra/llmessage/llcurl.cpp Correct whitespace. indra/llmessage/llpacketring.h A few things mostly on coding style here: 1. You'll mostly see method declarations separate from member declarations. It's often due to access controls but it's also a good organizational thing. I'd move the method up here. 2. This is really a private/protected method. No external user should call this. Making it so is compatible with 1. 3. Terrible name. SendPacket and doSendPacket. This is some sort of sendPacketImpl or routePacket, I think. indra/llmessage/llpacketring.cpp With the proxy code, we could get data larger than NET_BUFFER_SIZE. We don't detect this condition in receive_packet. Might just log initially. So much wrong with it.... indra/llmessage/llpacketring.cpp Magic number from original code review. Need these definitions (10) in the socks protocol definition set. indra/llmessage/llpacketring.cpp Not necessary now but something for a follow-on jira. This would have been a good place for a scatter/gather i/o using recvmsg to avoid the data copying. indra/llmessage/llpacketring.cpp Isn't packet_size '10' too large at this point? indra/llmessage/llpacketring.cpp I just looked into get_sender() and get_receiving_interface(). *weep* They use statics. So no thread safety. If we do improve the receive_packet interface to ever to scatter/gather, *this* will go. indra/llmessage/llpacketring.cpp Another perfect opportunity for scatter/gather i/o. indra/llmessage/llpacketring.cpp Caller may still reasonably try to write a full NET_BUFFER_SIZE of data in which case this smashes memory. - Monty On July 12, 2011, 11:20 a.m., Log Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/374/ > ----------------------------------------------------------- > > (Updated July 12, 2011, 11:20 a.m.) > > > Review request for Viewer, Oz Linden, Monty Brandenberg, and Stone Linden. > > > Summary > ------- > > This is a continuation of Robin Cornelius's SOCKS 5 contribution, shown in https://codereview.secondlife.com/r/232/ . I have tried to address all of the comments on that code review and do as much cleanup as possible. The diff includes everything that was submitted by Robin, as well as my work. > Major changes since I started working: > * Changed SOCKS 5 proxy control channel to use the existing LLSocket class, which is a thin wrapper around APR sockets. > * Worked with the Linden Lab UX team to revamp the proxy controls. > * Proxy credentials are now stored in the LLSecAPI password storage, which is the same that is used for users' Second Life Credentials instead of as being stored in the clear as a preference. > > > This addresses bug STORM-1112. > http://jira.secondlife.com/browse/STORM-1112 > > > Diffs > ----- > > indra/llmessage/CMakeLists.txt c7a4b7a24e05 > indra/llmessage/llcurl.cpp c7a4b7a24e05 > indra/llmessage/lliosocket.h c7a4b7a24e05 > indra/llmessage/lliosocket.cpp c7a4b7a24e05 > indra/llmessage/llpacketring.h c7a4b7a24e05 > indra/llmessage/llpacketring.cpp c7a4b7a24e05 > indra/llmessage/llproxy.h PRE-CREATION > indra/llmessage/llproxy.cpp PRE-CREATION > indra/llmessage/net.h c7a4b7a24e05 > indra/llmessage/net.cpp c7a4b7a24e05 > indra/llui/llfunctorregistry.h c7a4b7a24e05 > indra/newview/app_settings/settings.xml c7a4b7a24e05 > indra/newview/llappviewer.cpp c7a4b7a24e05 > indra/newview/llfloaterpreference.h c7a4b7a24e05 > indra/newview/llfloaterpreference.cpp c7a4b7a24e05 > indra/newview/llloginhandler.cpp c7a4b7a24e05 > indra/newview/llpanellogin.h c7a4b7a24e05 > indra/newview/llsecapi.h c7a4b7a24e05 > indra/newview/llstartup.h c7a4b7a24e05 > indra/newview/llstartup.cpp c7a4b7a24e05 > indra/newview/llviewerfloaterreg.cpp c7a4b7a24e05 > indra/newview/llxmlrpctransaction.cpp c7a4b7a24e05 > indra/newview/skins/default/xui/en/floater_preferences_proxy.xml PRE-CREATION > indra/newview/skins/default/xui/en/notifications.xml c7a4b7a24e05 > indra/newview/skins/default/xui/en/panel_cof_wearables.xml c7a4b7a24e05 > indra/newview/skins/default/xui/en/panel_preferences_privacy.xml c7a4b7a24e05 > indra/newview/skins/default/xui/en/panel_preferences_setup.xml c7a4b7a24e05 > > Diff: http://codereview.secondlife.com/r/374/diff > > > Testing > ------- > > I've tested exclusively on Linux so far. I'm working on a more extensive test plan that includes setting up a gateway with a restrictive firewall to verify that all traffic is going through the proxy. > > Test builds and screenshots of the changed UI elements are available from the project page, located here: > https://wiki.secondlife.com/wiki/User:Log_Linden/Socks5Viewer > > > Thanks, > > Log > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110712/1c6c27eb/attachment-0001.htm From monty at lindenlab.com Tue Jul 12 14:37:20 2011 From: monty at lindenlab.com (Monty Brandenberg) Date: Tue, 12 Jul 2011 17:37:20 -0400 Subject: [opensource-dev] Review Request: STORM-1112 Support SOCKS 5 proxy in the viewer (take 2) In-Reply-To: <20110712213502.10427.45532@domU-12-31-38-00-90-68.compute-1.internal> References: <20110712182022.7036.48966@domU-12-31-38-00-90-68.compute-1.internal> <20110712213502.10427.45532@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <4E1CBE90.6050007@lindenlab.com> On 7/12/2011 5:35 PM, Monty Brandenberg wrote: > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/374/ I'm doing this review in pieces, btw. Too much code for one go... From monty at lindenlab.com Tue Jul 12 23:50:51 2011 From: monty at lindenlab.com (Monty Brandenberg) Date: Wed, 13 Jul 2011 06:50:51 -0000 Subject: [opensource-dev] Review Request: STORM-1112 Support SOCKS 5 proxy in the viewer (take 2) In-Reply-To: <20110712182022.7036.48966@domU-12-31-38-00-90-68.compute-1.internal> References: <20110712182022.7036.48966@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110713065051.7025.70994@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/374/#review869 ----------------------------------------------------------- This finishes the first-pass review. Not ready to ship yet. indra/llmessage/llproxy.h Extra semicolon. indra/llmessage/llproxy.cpp Prefer sizeof(password_reply), it avoids an unverifiable duplicated name/type binding. indra/llmessage/llproxy.cpp The security minded would do several things at this point: 1. Scribble over password_auth before deleting it. 2. Scribble over mSocksPassword now that we've used it once. 3. Narrow the window from retrieving the password to this point as much as is practical. indra/llmessage/llproxy.cpp See above. indra/llmessage/llproxy.cpp Whitespace. indra/llmessage/llproxy.cpp Is anyone doing validation of the strings? What happens if they're over 255 bytes? Invalid utf-8 encodings? Do we care? Are these in the test plan? indra/llmessage/llproxy.cpp This block isn't reachable due to preceding 'if' clause. Also leaves 'rv' set to success if it failed to write all data for some reason. indra/llmessage/llproxy.cpp Possible to have legal short reads here. indra/llmessage/net.cpp Does net.cpp really need llproxy.h? I don't think it should. indra/newview/app_settings/settings.xml Is this still storing username and password in the settings file? Add this to the test plan. indra/newview/llfloaterpreference.cpp Whitespace (indentation & if) Also, this thing is now 'prefs_proxy', yes? indra/newview/llfloaterpreference.cpp whitespace indra/newview/llfloaterpreference.cpp Defensive programming on socksAuth being NULL? indra/newview/llstartup.cpp This may be too late. GPU/features table has already been loaded by HTTP, I believe. Then there's webkit and our browser. Need to check on this. (And test plan it.) indra/newview/llstartup.cpp There are a bunch of common strings shared between this and the UI code ("Web", "BrowserProxyEnabled", etc.) that feel like they should be #defines somewhere. Somewhere not llproxy.h but application/ ui/interface oriented. indra/newview/llstartup.cpp Left over from the previous review, I think, here's a place where the logic can be unsynchronized. 'use_socks_proxy' is actually identical to the 'else if' test above, isn't it? These should be consistent if I'm reading it correctly. indra/newview/llstartup.cpp All the credential code wants its own home, doesn't it? indra/newview/llstartup.cpp What does 'payload' do? indra/newview/llstartup.cpp I'd put this early return after startProxy(). We're in notification code here, long after we know we're okay. And what happens with an unrecognized status code? indra/newview/llxmlrpctransaction.cpp These combined with 328 feel like they should be a utility method on mCurlRequest. Or the whole block a method or free function in LLProxy... indra/newview/llxmlrpctransaction.cpp Whitespace. indra/newview/skins/default/xui/en/panel_preferences_setup.xml Bad name? indra/newview/skins/default/xui/en/panel_preferences_setup.xml Bad 'label_selected' value? - Monty On July 12, 2011, 11:20 a.m., Log Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/374/ > ----------------------------------------------------------- > > (Updated July 12, 2011, 11:20 a.m.) > > > Review request for Viewer, Oz Linden, Monty Brandenberg, and Stone Linden. > > > Summary > ------- > > This is a continuation of Robin Cornelius's SOCKS 5 contribution, shown in https://codereview.secondlife.com/r/232/ . I have tried to address all of the comments on that code review and do as much cleanup as possible. The diff includes everything that was submitted by Robin, as well as my work. > Major changes since I started working: > * Changed SOCKS 5 proxy control channel to use the existing LLSocket class, which is a thin wrapper around APR sockets. > * Worked with the Linden Lab UX team to revamp the proxy controls. > * Proxy credentials are now stored in the LLSecAPI password storage, which is the same that is used for users' Second Life Credentials instead of as being stored in the clear as a preference. > > > This addresses bug STORM-1112. > http://jira.secondlife.com/browse/STORM-1112 > > > Diffs > ----- > > indra/llmessage/CMakeLists.txt c7a4b7a24e05 > indra/llmessage/llcurl.cpp c7a4b7a24e05 > indra/llmessage/lliosocket.h c7a4b7a24e05 > indra/llmessage/lliosocket.cpp c7a4b7a24e05 > indra/llmessage/llpacketring.h c7a4b7a24e05 > indra/llmessage/llpacketring.cpp c7a4b7a24e05 > indra/llmessage/llproxy.h PRE-CREATION > indra/llmessage/llproxy.cpp PRE-CREATION > indra/llmessage/net.h c7a4b7a24e05 > indra/llmessage/net.cpp c7a4b7a24e05 > indra/llui/llfunctorregistry.h c7a4b7a24e05 > indra/newview/app_settings/settings.xml c7a4b7a24e05 > indra/newview/llappviewer.cpp c7a4b7a24e05 > indra/newview/llfloaterpreference.h c7a4b7a24e05 > indra/newview/llfloaterpreference.cpp c7a4b7a24e05 > indra/newview/llloginhandler.cpp c7a4b7a24e05 > indra/newview/llpanellogin.h c7a4b7a24e05 > indra/newview/llsecapi.h c7a4b7a24e05 > indra/newview/llstartup.h c7a4b7a24e05 > indra/newview/llstartup.cpp c7a4b7a24e05 > indra/newview/llviewerfloaterreg.cpp c7a4b7a24e05 > indra/newview/llxmlrpctransaction.cpp c7a4b7a24e05 > indra/newview/skins/default/xui/en/floater_preferences_proxy.xml PRE-CREATION > indra/newview/skins/default/xui/en/notifications.xml c7a4b7a24e05 > indra/newview/skins/default/xui/en/panel_cof_wearables.xml c7a4b7a24e05 > indra/newview/skins/default/xui/en/panel_preferences_privacy.xml c7a4b7a24e05 > indra/newview/skins/default/xui/en/panel_preferences_setup.xml c7a4b7a24e05 > > Diff: http://codereview.secondlife.com/r/374/diff > > > Testing > ------- > > I've tested exclusively on Linux so far. I'm working on a more extensive test plan that includes setting up a gateway with a restrictive firewall to verify that all traffic is going through the proxy. > > Test builds and screenshots of the changed UI elements are available from the project page, located here: > https://wiki.secondlife.com/wiki/User:Log_Linden/Socks5Viewer > > > Thanks, > > Log > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110713/567592e5/attachment-0001.htm From vsavchuk at productengine.com Wed Jul 13 02:06:10 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Wed, 13 Jul 2011 09:06:10 -0000 Subject: [opensource-dev] Review Request: STORM-1502 Disable "Delete Water/Sky/Day Preset" dialogs if no user presets exist Message-ID: <20110713090610.18259.4881@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/392/ ----------------------------------------------------------- Review request for Viewer. Summary ------- This patch disables the corresponding menu items when no user-created WL presets exist. This addresses bug STORM-1502. http://jira.secondlife.com/browse/STORM-1502 Diffs ----- indra/newview/llviewermenu.cpp UNKNOWN indra/newview/skins/default/xui/en/menu_viewer.xml UNKNOWN Diff: http://codereview.secondlife.com/r/392/diff Testing ------- Thanks, Vadim -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110713/7b005785/attachment.htm From pguslisty at productengine.com Wed Jul 13 08:48:53 2011 From: pguslisty at productengine.com (Paul ProductEngine) Date: Wed, 13 Jul 2011 15:48:53 -0000 Subject: [opensource-dev] Review Request: STORM-1503 (Find floater doesn't set focus to its browser) Message-ID: <20110713154853.10362.3963@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/393/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Just added tab_stop to the browser. This addresses bug storm-1503. http://jira.secondlife.com/browse/storm-1503 Diffs ----- indra/newview/skins/default/xui/en/floater_search.xml 68ad362920c1 Diff: http://codereview.secondlife.com/r/393/diff Testing ------- Thanks, Paul -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110713/4ccf9993/attachment.htm From vsavchuk at productengine.com Wed Jul 13 08:51:36 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Wed, 13 Jul 2011 15:51:36 -0000 Subject: [opensource-dev] Review Request: STORM-1503 (Find floater doesn't set focus to its browser) In-Reply-To: <20110713154853.10362.3963@domU-12-31-38-00-90-68.compute-1.internal> References: <20110713154853.10362.3963@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110713155136.9687.47150@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/393/#review870 ----------------------------------------------------------- Ship it! Looks like this is what Richard suggested. - Vadim On July 13, 2011, 8:48 a.m., Paul ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/393/ > ----------------------------------------------------------- > > (Updated July 13, 2011, 8:48 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Just added tab_stop to the browser. > > > This addresses bug storm-1503. > http://jira.secondlife.com/browse/storm-1503 > > > Diffs > ----- > > indra/newview/skins/default/xui/en/floater_search.xml 68ad362920c1 > > Diff: http://codereview.secondlife.com/r/393/diff > > > Testing > ------- > > > Thanks, > > Paul > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110713/b6535b58/attachment.htm From slitovchuk at productengine.com Wed Jul 13 08:56:10 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Wed, 13 Jul 2011 15:56:10 -0000 Subject: [opensource-dev] Review Request: STORM-1502 Disable "Delete Water/Sky/Day Preset" dialogs if no user presets exist In-Reply-To: <20110713090610.18259.4881@domU-12-31-38-00-90-68.compute-1.internal> References: <20110713090610.18259.4881@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110713155610.10350.88000@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/392/#review871 ----------------------------------------------------------- Ship it! Looks pretty straightforward. - Seth On July 13, 2011, 2:06 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/392/ > ----------------------------------------------------------- > > (Updated July 13, 2011, 2:06 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > This patch disables the corresponding menu items when no user-created WL presets exist. > > > This addresses bug STORM-1502. > http://jira.secondlife.com/browse/STORM-1502 > > > Diffs > ----- > > indra/newview/llviewermenu.cpp UNKNOWN > indra/newview/skins/default/xui/en/menu_viewer.xml UNKNOWN > > Diff: http://codereview.secondlife.com/r/392/diff > > > Testing > ------- > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110713/1393cf51/attachment.htm From slitovchuk at productengine.com Wed Jul 13 09:06:31 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Wed, 13 Jul 2011 16:06:31 -0000 Subject: [opensource-dev] Review Request: (STORM-1234) In Nearby Chat, Group Chat and IM Chat, URL selection frequently fails to grab last character Message-ID: <20110713160631.9587.80346@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/394/ ----------------------------------------------------------- Review request for Viewer and Richard Nelson. Summary ------- Fixed text editor selection which was skipping the last character in line. Added handling of the wrapped lines case when calculating the starting position for selection. The bug is a regression caused by the fix of STORM-320 which was dealing with calculating the position of the input cursor while navigating through the lines of text with word wrapping enabled. This addresses bug STORM-1234. http://jira.secondlife.com/browse/STORM-1234 Diffs ----- indra/llui/lltextbase.cpp 68ad362920c1 Diff: http://codereview.secondlife.com/r/394/diff Testing ------- Thanks, Seth -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110713/5f787654/attachment.htm From richard at lindenlab.com Wed Jul 13 11:15:26 2011 From: richard at lindenlab.com (Richard Nelson) Date: Wed, 13 Jul 2011 18:15:26 -0000 Subject: [opensource-dev] Review Request: (STORM-1234) In Nearby Chat, Group Chat and IM Chat, URL selection frequently fails to grab last character In-Reply-To: <20110713160631.9587.80346@domU-12-31-38-00-90-68.compute-1.internal> References: <20110713160631.9587.80346@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110713181526.10261.24220@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/394/#review872 ----------------------------------------------------------- Ship it! once again all the -1's start creeping back in :) At least it's clearly documented here. - Richard On July 13, 2011, 9:06 a.m., Seth ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/394/ > ----------------------------------------------------------- > > (Updated July 13, 2011, 9:06 a.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > ------- > > Fixed text editor selection which was skipping the last character in line. > > Added handling of the wrapped lines case when calculating the starting position for selection. > > The bug is a regression caused by the fix of STORM-320 which was dealing with calculating the position of the input cursor while navigating through the lines of text with word wrapping enabled. > > > This addresses bug STORM-1234. > http://jira.secondlife.com/browse/STORM-1234 > > > Diffs > ----- > > indra/llui/lltextbase.cpp 68ad362920c1 > > Diff: http://codereview.secondlife.com/r/394/diff > > > Testing > ------- > > > Thanks, > > Seth > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110713/87d38045/attachment-0001.htm From log at lindenlab.com Wed Jul 13 13:50:05 2011 From: log at lindenlab.com (Log Linden) Date: Wed, 13 Jul 2011 20:50:05 -0000 Subject: [opensource-dev] Review Request: STORM-1112 Support SOCKS 5 proxy in the viewer (take 2) In-Reply-To: <20110712182022.7036.48966@domU-12-31-38-00-90-68.compute-1.internal> References: <20110712182022.7036.48966@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110713205005.9625.26613@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/374/ ----------------------------------------------------------- (Updated July 13, 2011, 1:50 p.m.) Review request for Viewer, Oz Linden, Monty Brandenberg, and Stone Linden. Changes ------- Implemented changes to address Monty's first group of comments, as well of some of the trivial comments in the second group. Working on more fixes for the second group.. Summary ------- This is a continuation of Robin Cornelius's SOCKS 5 contribution, shown in https://codereview.secondlife.com/r/232/ . I have tried to address all of the comments on that code review and do as much cleanup as possible. The diff includes everything that was submitted by Robin, as well as my work. Major changes since I started working: * Changed SOCKS 5 proxy control channel to use the existing LLSocket class, which is a thin wrapper around APR sockets. * Worked with the Linden Lab UX team to revamp the proxy controls. * Proxy credentials are now stored in the LLSecAPI password storage, which is the same that is used for users' Second Life Credentials instead of as being stored in the clear as a preference. This addresses bug STORM-1112. http://jira.secondlife.com/browse/STORM-1112 Diffs (updated) ----- indra/llmessage/CMakeLists.txt 7c7d01be2310 indra/llmessage/llcurl.cpp 7c7d01be2310 indra/llmessage/lliosocket.h 7c7d01be2310 indra/llmessage/lliosocket.cpp 7c7d01be2310 indra/llmessage/llpacketring.h 7c7d01be2310 indra/llmessage/llpacketring.cpp 7c7d01be2310 indra/llmessage/llproxy.h PRE-CREATION indra/llmessage/llproxy.cpp PRE-CREATION indra/llmessage/net.h 7c7d01be2310 indra/llmessage/net.cpp 7c7d01be2310 indra/llui/llfunctorregistry.h 7c7d01be2310 indra/newview/app_settings/settings.xml 7c7d01be2310 indra/newview/llappviewer.cpp 7c7d01be2310 indra/newview/llfloaterpreference.h 7c7d01be2310 indra/newview/llfloaterpreference.cpp 7c7d01be2310 indra/newview/llloginhandler.cpp 7c7d01be2310 indra/newview/llpanellogin.h 7c7d01be2310 indra/newview/llsecapi.h 7c7d01be2310 indra/newview/llstartup.h 7c7d01be2310 indra/newview/llstartup.cpp 7c7d01be2310 indra/newview/llviewerfloaterreg.cpp 7c7d01be2310 indra/newview/llxmlrpctransaction.cpp 7c7d01be2310 indra/newview/skins/default/xui/en/floater_preferences_proxy.xml PRE-CREATION indra/newview/skins/default/xui/en/notifications.xml 7c7d01be2310 indra/newview/skins/default/xui/en/panel_cof_wearables.xml 7c7d01be2310 indra/newview/skins/default/xui/en/panel_preferences_privacy.xml 7c7d01be2310 indra/newview/skins/default/xui/en/panel_preferences_setup.xml 7c7d01be2310 Diff: http://codereview.secondlife.com/r/374/diff Testing ------- I've tested exclusively on Linux so far. I'm working on a more extensive test plan that includes setting up a gateway with a restrictive firewall to verify that all traffic is going through the proxy. Test builds and screenshots of the changed UI elements are available from the project page, located here: https://wiki.secondlife.com/wiki/User:Log_Linden/Socks5Viewer Thanks, Log -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110713/b443459b/attachment.htm From pguslisty at productengine.com Thu Jul 14 02:15:04 2011 From: pguslisty at productengine.com (Paul ProductEngine) Date: Thu, 14 Jul 2011 09:15:04 -0000 Subject: [opensource-dev] Review Request: STORM-519 ( "Delete" is enabled in the context menu for folders which contain worn items) Message-ID: <20110714091504.7036.71459@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/396/ ----------------------------------------------------------- Review request for Viewer. Summary ------- - Disable "Delete" menu item in case selected folder contains non-removable items. This addresses bug storm-519. http://jira.secondlife.com/browse/storm-519 Diffs ----- indra/newview/llinventorybridge.cpp 68ad362920c1 Diff: http://codereview.secondlife.com/r/396/diff Testing ------- Thanks, Paul -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110714/8604e1d7/attachment.htm From slitovchuk at productengine.com Thu Jul 14 07:01:24 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Thu, 14 Jul 2011 14:01:24 -0000 Subject: [opensource-dev] Review Request: STORM-519 ( "Delete" is enabled in the context menu for folders which contain worn items) In-Reply-To: <20110714091504.7036.71459@domU-12-31-38-00-90-68.compute-1.internal> References: <20110714091504.7036.71459@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110714140124.10261.23478@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/396/#review876 ----------------------------------------------------------- Ship it! Straightforward fix. - Seth On July 14, 2011, 2:15 a.m., Paul ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/396/ > ----------------------------------------------------------- > > (Updated July 14, 2011, 2:15 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > - Disable "Delete" menu item in case selected folder contains non-removable items. > > > This addresses bug storm-519. > http://jira.secondlife.com/browse/storm-519 > > > Diffs > ----- > > indra/newview/llinventorybridge.cpp 68ad362920c1 > > Diff: http://codereview.secondlife.com/r/396/diff > > > Testing > ------- > > > Thanks, > > Paul > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110714/7e4ef35d/attachment.htm From lee.ponzu at gmail.com Thu Jul 14 07:56:24 2011 From: lee.ponzu at gmail.com (Lee ponzu) Date: Thu, 14 Jul 2011 10:56:24 -0400 Subject: [opensource-dev] An SL appliance... Message-ID: Does the Linux viewer use X? If you DISPLAY SL on another computer running an XServer, does it behave OK. If so, could you assemble a small Linux host with a high end GPU and then DISPLAY SL on a different computer on the same local network? ponzu -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110714/0a8e1f28/attachment.htm From discrete.dreamscape at gmail.com Thu Jul 14 08:02:59 2011 From: discrete.dreamscape at gmail.com (Discrete Dreamscape) Date: Thu, 14 Jul 2011 11:02:59 -0400 Subject: [opensource-dev] An SL appliance... In-Reply-To: References: Message-ID: If you want to use X forwarding, you're probably not going to be happy with the results. Machines on the same gigabit switch can even have poor performance just loading or refreshing a file manager. There may be other ways, and there are always remote desktop-type layers like NX.. Discrete On Thu, Jul 14, 2011 at 10:56 AM, Lee ponzu wrote: > Does the Linux viewer use X? If you DISPLAY SL on another computer running > an XServer, does it behave OK. > > If so, could you assemble a small Linux host with a high end GPU and then > DISPLAY SL on a different computer on the same local network? > > ponzu > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110714/518b426f/attachment.htm From lee.ponzu at gmail.com Thu Jul 14 08:05:31 2011 From: lee.ponzu at gmail.com (Lee ponzu) Date: Thu, 14 Jul 2011 11:05:31 -0400 Subject: [opensource-dev] SOCKS viewer Message-ID: I notice this work being done on a viewer that can use a SOCKS proxy. In my limited knowledge, SOCKS is usually used to get through a firewall, right? But there are also SOCKS proxies that cache requests. So, suppose you had two or more clients using the same cacheing SOCKS proxy. If they needed the same data (say the two users were in the same classroom or sex club), would they both get their data from the SOCKS cache? For a classroom with many users, this could be a huge bandwidth win. Even for a few people on the same side of a slow network connection, it could be a big win. Can we get Wild Blue to put a cacheing SOCKS proxy on the satellite 8-). Save me 800ms for every request 8-) Maybe this is the whole point of the effort, and I only just woke up...that could be a huge win, for me at least 8-) regards, ponzu -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110714/428ab3d8/attachment-0001.htm From Lance.Corrimal at eregion.de Thu Jul 14 08:06:22 2011 From: Lance.Corrimal at eregion.de (Lance Corrimal) Date: Thu, 14 Jul 2011 17:06:22 +0200 Subject: [opensource-dev] An SL appliance... In-Reply-To: References: Message-ID: Am Do, 14.07.2011, 16:56 schrieb Lee ponzu: > Does the Linux viewer use X? yes. > If you DISPLAY SL on another computer running > an XServer, does it behave OK. no. no openGL app does. > If so, could you assemble a small Linux host with a high end GPU and then > DISPLAY SL on a different computer on the same local network? no. see above. bye, LC From arrehn at gmail.com Thu Jul 14 08:37:55 2011 From: arrehn at gmail.com (Arrehn Oberlander) Date: Thu, 14 Jul 2011 11:37:55 -0400 Subject: [opensource-dev] An SL appliance... In-Reply-To: References: Message-ID: In the past it has been possible to do accelerated openGL-over-X11 over a network with particular drivers, specifically some versions of the linux NVidia drivers. Still, it's quite exotic, limited, and probably would not result in the effect the original poster intended. On Thu, Jul 14, 2011 at 11:06 AM, Lance Corrimal wrote: > Am Do, 14.07.2011, 16:56 schrieb Lee ponzu: > > Does the Linux viewer use X? > > yes. > > > If you DISPLAY SL on another computer running > > an XServer, does it behave OK. > > no. no openGL app does. > > > > If so, could you assemble a small Linux host with a high end GPU and then > > DISPLAY SL on a different computer on the same local network? > > no. see above. > > bye, > LC > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110714/e718abc9/attachment.htm From sllists at boroon.dasgupta.ch Thu Jul 14 09:03:44 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Thu, 14 Jul 2011 16:03:44 -0000 Subject: [opensource-dev] Review Request: STORM-519 ( "Delete" is enabled in the context menu for folders which contain worn items) In-Reply-To: <20110714091504.7036.71459@domU-12-31-38-00-90-68.compute-1.internal> References: <20110714091504.7036.71459@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110714160344.18259.85998@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/396/#review877 ----------------------------------------------------------- indra/newview/llinventorybridge.cpp Why store this in a variable when the result is only used once and the call is this simple? (I assume the result of this call wouldn't change between here where the value is stored and the below where it's used.) indra/newview/llinventorybridge.cpp We could just use if (!isItemRemovable()) here, couldn't we? - Boroondas On July 14, 2011, 2:15 a.m., Paul ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/396/ > ----------------------------------------------------------- > > (Updated July 14, 2011, 2:15 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > - Disable "Delete" menu item in case selected folder contains non-removable items. > > > This addresses bug storm-519. > http://jira.secondlife.com/browse/storm-519 > > > Diffs > ----- > > indra/newview/llinventorybridge.cpp 68ad362920c1 > > Diff: http://codereview.secondlife.com/r/396/diff > > > Testing > ------- > > > Thanks, > > Paul > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110714/80b9f5fa/attachment.htm From sllists at boroon.dasgupta.ch Thu Jul 14 09:05:32 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Thu, 14 Jul 2011 16:05:32 -0000 Subject: [opensource-dev] Review Request: STORM-1503 (Find floater doesn't set focus to its browser) In-Reply-To: <20110713154853.10362.3963@domU-12-31-38-00-90-68.compute-1.internal> References: <20110713154853.10362.3963@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110714160532.7040.33325@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/393/#review878 ----------------------------------------------------------- Ship it! indra/newview/skins/default/xui/en/floater_search.xml While we're editing around here, fix indentation of line 42. - Boroondas On July 13, 2011, 8:48 a.m., Paul ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/393/ > ----------------------------------------------------------- > > (Updated July 13, 2011, 8:48 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Just added tab_stop to the browser. > > > This addresses bug storm-1503. > http://jira.secondlife.com/browse/storm-1503 > > > Diffs > ----- > > indra/newview/skins/default/xui/en/floater_search.xml 68ad362920c1 > > Diff: http://codereview.secondlife.com/r/393/diff > > > Testing > ------- > > > Thanks, > > Paul > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110714/74041817/attachment.htm From zoni at zoni.nl Thu Jul 14 10:31:58 2011 From: zoni at zoni.nl (Nick Groenen) Date: Thu, 14 Jul 2011 19:31:58 +0200 Subject: [opensource-dev] An SL appliance... In-Reply-To: References: Message-ID: <20110714193158.4c34ab4f@isis.zoni.nl> On Thu, 14 Jul 2011 17:06:22 +0200 "Lance Corrimal" wrote: > > If so, could you assemble a small Linux host with a high end GPU and then > > DISPLAY SL on a different computer on the same local network? > > no. see above. > > bye, > LC Actually, using VirtualGL[1] this should be possible. I've been using it to try and make my Nvidia chip usable on my Optimus enabled laptop with limited success. I got so far as to make SL run perfectly with it, so long as I didn't try to select anything inworld. Doing so resulted in an immediate crash. It's only a small step further to make the X server that VirtualGL uses run on another PC and stream the data using one of the various compression options it offers. [1]: http://www.virtualgl.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110714/34daf5a3/attachment-0001.pgp From monty at lindenlab.com Thu Jul 14 10:57:49 2011 From: monty at lindenlab.com (Monty Brandenberg) Date: Thu, 14 Jul 2011 13:57:49 -0400 Subject: [opensource-dev] SOCKS viewer In-Reply-To: References: Message-ID: <4E1F2E1D.3000801@lindenlab.com> On 7/14/2011 11:05 AM, Lee ponzu wrote: > So, suppose you had two or more clients using the same cacheing SOCKS > proxy. If they needed the same data (say the two users were in the same > classroom or sex club), would they both get their data from the SOCKS > cache? Not at this point. While two viewers will certainly fetch the same object, they'll do it with different URLs. Currently, our URLs are neither Resources nor Locators really and attempting to cache at the HTTP-level is problematic. That may change in the future but right now, that's what we have. So the immediate *proxy* work is to get HTTP & SOCKS5 proxying working correctly and uniformly in the viewer. As far as asset caching goes.... the cache maximum has been bumped up recently. Give it a try people and please report back any problems. m From armin.weatherwax at googlemail.com Thu Jul 14 11:39:04 2011 From: armin.weatherwax at googlemail.com (Armin Weatherwax) Date: Thu, 14 Jul 2011 20:39:04 +0200 Subject: [opensource-dev] An SL appliance... In-Reply-To: References: Message-ID: <201107142039.04644.Armin.Weatherwax@gmail.com> Lee ponzu schrieb: > Does the Linux viewer use X? If you DISPLAY SL on another computer > running an XServer, does it behave OK. > > If so, could you assemble a small Linux host with a high end GPU and > then DISPLAY SL on a different computer on the same local network? > > ponzu so far I used yukon only for local opengl capture, but if its network streaming works comparably well I guess https://github.com/wereHamster/yukon/tree/rewrite and its dependency https://github.com/wereHamster/seom/tree/packetized-stream is fine to DISPLAY SL on a remote computer in a reasonable fast local network. Armin From kiptic at hotmail.com Thu Jul 14 13:09:56 2011 From: kiptic at hotmail.com (=?windows-1256?B?S2lwdGljIJ0=?=) Date: Thu, 14 Jul 2011 22:09:56 +0200 Subject: [opensource-dev] icon_SeeAVs_On Message-ID: Hi, I'm trying to compile 19506, and everything works perfectly (as usual), I get the new binary, start it, and can even log in. Then after a little while, before I actually get on, I get this error: ERROR: LLPanel::getString: Failed to find string icon_SeeAVs_On in panel panel_place_profile ...and the viewer dies. What's with this? I can see that the string exists in indra/newview/skins/default/xui/en/panel_place_profile.xml (since 19504), so this shouldn't happen!? Please help :) /Kip -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110714/6b7c0357/attachment.htm From kiptic at hotmail.com Thu Jul 14 14:32:01 2011 From: kiptic at hotmail.com (=?windows-1256?B?S2lwdGljIJ0=?=) Date: Thu, 14 Jul 2011 23:32:01 +0200 Subject: [opensource-dev] icon_SeeAVs_On In-Reply-To: References: Message-ID: Ohh never mind, I found the problem: the files in my "roaming" profile thingy needed updating. Sorry for the fuss :) /Kip -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110714/73621e0b/attachment.htm From aklo at skyhighway.com Thu Jul 14 19:17:44 2011 From: aklo at skyhighway.com (aklo at skyhighway.com) Date: Thu, 14 Jul 2011 19:17:44 -0700 Subject: [opensource-dev] Blocked Message-ID: Hey y'all, i had something i wanted to do at work a coupla days ago that i coulda used SL for. It installed, but i couldn't get it to connect. Is there some kinda proxy setting that i need to fix to get SL to start from where i work? They have a proxy server there that all external traffic has to go through. i know i have to tell Firefox & everything else about it all the time to get them to work. i looked in the XML but didn't see anything inspiring in the little bit of time i had for it. The thing i have to do is just a dumb test, but SL is a pretty good thing to do it with, and an excuse to spend maybe 10 whole minutes doing SL from work about once a week. Thx! - AK From aklo at skyhighway.com Thu Jul 14 20:10:55 2011 From: aklo at skyhighway.com (aklo at skyhighway.com) Date: Thu, 14 Jul 2011 20:10:55 -0700 Subject: [opensource-dev] Blocked Message-ID: <11a944ec0f0b85d9175179a9669cca01.squirrel@cruziomail.cruzio.com> Robert, thx for the info, but i think the page is telling me the answer is actually, "No," because i don't have any access to the company's network stuff. They look at you funny if you even ask about it. i can configure a test machine any way i want to, but i can't do anything at all at all to the network. How depressing :-( Since it is for a real work project, i think i'll show the page to the IT guy, but i think this is just going to be another one of those funny looks experiences, and a "I'll get back to you later" that ends up being a not overly polite "helpful suggestion" from my boss. But i think it will be worth it just for the opportunity of getting to explain what i'm doing. - AK On Thu, Jul 14, 2011 at 10:17 PM, wrote: > > Hey y'all, i had something i wanted to do at work a coupla days ago that i > > coulda used SL for. It installed, but i couldn't get it to connect. Is > > there some kinda proxy setting that i need to fix to get SL to start from > > where i work? short answer is yes long answer is http://wiki.secondlife.com/wiki/Configuring_your_firewall -- Robert L Martin From Lance.Corrimal at eregion.de Thu Jul 14 22:45:38 2011 From: Lance.Corrimal at eregion.de (Lance Corrimal) Date: Fri, 15 Jul 2011 07:45:38 +0200 Subject: [opensource-dev] Blocked In-Reply-To: <11a944ec0f0b85d9175179a9669cca01.squirrel@cruziomail.cruzio.com> References: <11a944ec0f0b85d9175179a9669cca01.squirrel@cruziomail.cruzio.com> Message-ID: <201107150745.38704.Lance.Corrimal@eregion.de> Isn't it a good thing that there's a proxified viewer now... can someone point him/her at the downloads for a build with the proxy stuff? bye, LC Am Freitag, 15. Juli 2011 schrieb aklo at skyhighway.com: > Robert, > > thx for the info, but i think the page is telling me the answer is > actually, "No," because i don't have any access to the company's > network stuff. They look at you funny if you even ask about it. > i can configure a test machine any way i want to, but i can't do > anything at all at all to the network. How depressing :-( > > Since it is for a real work project, i think i'll show the page to > the IT guy, but i think this is just going to be another one of > those funny looks experiences, and a "I'll get back to you later" > that ends up being a not overly polite "helpful suggestion" from > my boss. But i think it will be worth it just for the opportunity > of getting to explain what i'm doing. > > - AK > > On Thu, Jul 14, 2011 at 10:17 PM, wrote: > > > Hey y'all, i had something i wanted to do at work a coupla days > > > ago > > that i > > > > coulda used SL for. It installed, but i couldn't get it to > > > connect. Is there some kinda proxy setting that i need to fix > > > to get SL to start from where i work? > > short answer is yes > long answer is > http://wiki.secondlife.com/wiki/Configuring_your_firewall > > -- Robert L Martin > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges From tateru.nino at gmail.com Thu Jul 14 22:53:09 2011 From: tateru.nino at gmail.com (Tateru Nino) Date: Fri, 15 Jul 2011 15:53:09 +1000 Subject: [opensource-dev] Blocked In-Reply-To: <201107150745.38704.Lance.Corrimal@eregion.de> References: <11a944ec0f0b85d9175179a9669cca01.squirrel@cruziomail.cruzio.com> <201107150745.38704.Lance.Corrimal@eregion.de> Message-ID: <4E1FD5C5.9040206@gmail.com> That's assuming they have the right kind of proxies there. HTTP proxies are commonplace, but SOCKS proxies are far less common and more tightly controlled on the corporate networks. He almost certainly has access to the former, but maybe not to the latter. On 15/07/2011 3:45 PM, Lance Corrimal wrote: > Isn't it a good thing that there's a proxified viewer now... can > someone point him/her at the downloads for a build with the proxy > stuff? > > > bye, > LC > > > Am Freitag, 15. Juli 2011 schrieb aklo at skyhighway.com: >> Robert, >> >> thx for the info, but i think the page is telling me the answer is >> actually, "No," because i don't have any access to the company's >> network stuff. They look at you funny if you even ask about it. >> i can configure a test machine any way i want to, but i can't do >> anything at all at all to the network. How depressing :-( >> >> Since it is for a real work project, i think i'll show the page to >> the IT guy, but i think this is just going to be another one of >> those funny looks experiences, and a "I'll get back to you later" >> that ends up being a not overly polite "helpful suggestion" from >> my boss. But i think it will be worth it just for the opportunity >> of getting to explain what i'm doing. >> >> - AK >> >> On Thu, Jul 14, 2011 at 10:17 PM, wrote: >>>> Hey y'all, i had something i wanted to do at work a coupla days >>>> ago >> that i >> >>>> coulda used SL for. It installed, but i couldn't get it to >>>> connect. Is there some kinda proxy setting that i need to fix >>>> to get SL to start from where i work? >> short answer is yes >> long answer is >> http://wiki.secondlife.com/wiki/Configuring_your_firewall >> >> -- Robert L Martin >> >> _______________________________________________ >> Policies and (un)subscribe information available here: >> http://wiki.secondlife.com/wiki/OpenSource-Dev >> Please read the policies before posting to keep unmoderated posting >> privileges > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges > From dave at meadowlakearts.com Thu Jul 14 23:12:51 2011 From: dave at meadowlakearts.com (Dave Booth) Date: Fri, 15 Jul 2011 01:12:51 -0500 Subject: [opensource-dev] Blocked In-Reply-To: <4E1FD5C5.9040206@gmail.com> References: <11a944ec0f0b85d9175179a9669cca01.squirrel@cruziomail.cruzio.com> <201107150745.38704.Lance.Corrimal@eregion.de> <4E1FD5C5.9040206@gmail.com> Message-ID: <4E1FDA63.7000105@meadowlakearts.com> Socksified works but yeah, takes more "liberal" corp IT attitudes than most will allow. I sent offlist the solution I used.. (openvpn to home networks static IP and route all SL traffic down that using local routes on client and openvpn server) On 7/15/2011 12:53 AM, Tateru Nino wrote: > That's assuming they have the right kind of proxies there. HTTP proxies > are commonplace, but SOCKS proxies are far less common and more tightly > controlled on the corporate networks. He almost certainly has access to > the former, but maybe not to the latter. > > On 15/07/2011 3:45 PM, Lance Corrimal wrote: >> Isn't it a good thing that there's a proxified viewer now... can >> someone point him/her at the downloads for a build with the proxy >> stuff? >> >> >> bye, >> LC >> >> >> Am Freitag, 15. Juli 2011 schrieb aklo at skyhighway.com: >>> Robert, >>> >>> thx for the info, but i think the page is telling me the answer is >>> actually, "No," because i don't have any access to the company's >>> network stuff. They look at you funny if you even ask about it. >>> i can configure a test machine any way i want to, but i can't do >>> anything at all at all to the network. How depressing :-( >>> >>> Since it is for a real work project, i think i'll show the page to >>> the IT guy, but i think this is just going to be another one of >>> those funny looks experiences, and a "I'll get back to you later" >>> that ends up being a not overly polite "helpful suggestion" from >>> my boss. But i think it will be worth it just for the opportunity >>> of getting to explain what i'm doing. >>> >>> - AK >>> >>> On Thu, Jul 14, 2011 at 10:17 PM, wrote: >>>>> Hey y'all, i had something i wanted to do at work a coupla days >>>>> ago >>> that i >>> >>>>> coulda used SL for. It installed, but i couldn't get it to >>>>> connect. Is there some kinda proxy setting that i need to fix >>>>> to get SL to start from where i work? >>> short answer is yes >>> long answer is >>> http://wiki.secondlife.com/wiki/Configuring_your_firewall >>> >>> -- Robert L Martin >>> >>> _______________________________________________ >>> Policies and (un)subscribe information available here: >>> http://wiki.secondlife.com/wiki/OpenSource-Dev >>> Please read the policies before posting to keep unmoderated posting >>> privileges >> _______________________________________________ >> Policies and (un)subscribe information available here: >> http://wiki.secondlife.com/wiki/OpenSource-Dev >> Please read the policies before posting to keep unmoderated posting privileges >> > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges > From Lance.Corrimal at eregion.de Fri Jul 15 00:44:04 2011 From: Lance.Corrimal at eregion.de (Lance Corrimal) Date: Fri, 15 Jul 2011 09:44:04 +0200 Subject: [opensource-dev] Blocked In-Reply-To: <4E1FDA63.7000105@meadowlakearts.com> References: <11a944ec0f0b85d9175179a9669cca01.squirrel@cruziomail.cruzio.com> <201107150745.38704.Lance.Corrimal@eregion.de> <4E1FD5C5.9040206@gmail.com> <4E1FDA63.7000105@meadowlakearts.com> Message-ID: <3527901ab2af9d9fd58b68573e6b1589.squirrel@eregion.kicks-ass.net> Am Fr, 15.07.2011, 08:12 schrieb Dave Booth: > (openvpn to home networks static IP and route all SL traffic > down that using local routes on client and openvpn server) how does that works in a http-proxy-only network? bye, LC From pguslisty at productengine.com Fri Jul 15 07:36:30 2011 From: pguslisty at productengine.com (Paul ProductEngine) Date: Fri, 15 Jul 2011 14:36:30 -0000 Subject: [opensource-dev] Review Request: STORM-1503 (Find floater doesn't set focus to its browser) In-Reply-To: <20110714160532.7040.33325@domU-12-31-38-00-90-68.compute-1.internal> References: <20110714160532.7040.33325@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110715143630.9687.85965@domU-12-31-38-00-90-68.compute-1.internal> > On July 14, 2011, 9:05 a.m., Boroondas Gupte wrote: > > indra/newview/skins/default/xui/en/floater_search.xml, lines 40-43 > > > > > > While we're editing around here, fix indentation of line 42. It's too late to fix this indentation because the repo for this fix has already been published. - Paul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/393/#review878 ----------------------------------------------------------- On July 13, 2011, 8:48 a.m., Paul ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/393/ > ----------------------------------------------------------- > > (Updated July 13, 2011, 8:48 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Just added tab_stop to the browser. > > > This addresses bug storm-1503. > http://jira.secondlife.com/browse/storm-1503 > > > Diffs > ----- > > indra/newview/skins/default/xui/en/floater_search.xml 68ad362920c1 > > Diff: http://codereview.secondlife.com/r/393/diff > > > Testing > ------- > > > Thanks, > > Paul > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110715/0ed99cc0/attachment-0001.htm From sllists at boroon.dasgupta.ch Fri Jul 15 08:35:53 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Fri, 15 Jul 2011 15:35:53 -0000 Subject: [opensource-dev] Review Request: STORM-1503 (Find floater doesn't set focus to its browser) In-Reply-To: <20110714160532.7040.33325@domU-12-31-38-00-90-68.compute-1.internal> References: <20110714160532.7040.33325@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110715153553.7037.35328@domU-12-31-38-00-90-68.compute-1.internal> > On July 14, 2011, 9:05 a.m., Boroondas Gupte wrote: > > indra/newview/skins/default/xui/en/floater_search.xml, lines 40-43 > > > > > > While we're editing around here, fix indentation of line 42. > > Paul ProductEngine wrote: > It's too late to fix this indentation because the repo for this fix has already been published. never mind, then - Boroondas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/393/#review878 ----------------------------------------------------------- On July 13, 2011, 8:48 a.m., Paul ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/393/ > ----------------------------------------------------------- > > (Updated July 13, 2011, 8:48 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Just added tab_stop to the browser. > > > This addresses bug storm-1503. > http://jira.secondlife.com/browse/storm-1503 > > > Diffs > ----- > > indra/newview/skins/default/xui/en/floater_search.xml 68ad362920c1 > > Diff: http://codereview.secondlife.com/r/393/diff > > > Testing > ------- > > > Thanks, > > Paul > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110715/784d1c01/attachment.htm From vsavchuk at productengine.com Fri Jul 15 09:13:56 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Fri, 15 Jul 2011 16:13:56 -0000 Subject: [opensource-dev] Review Request: STORM-1506 Regions set to Fixed Sun with viewers < 2.8 are not reset correctly when set to use a Day Cycle Message-ID: <20110715161356.7038.74516@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/397/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Reset the estate to global sun when changing region environment settings. By the way, moved estate info storage from the REGION/ESTATE floater to a model class. This addresses bug STORM-1506. http://jira.secondlife.com/browse/STORM-1506 Diffs ----- indra/newview/CMakeLists.txt UNKNOWN indra/newview/llestateinfomodel.h PRE-CREATION indra/newview/llestateinfomodel.cpp PRE-CREATION indra/newview/llfloaterauction.cpp UNKNOWN indra/newview/llfloaterregioninfo.h UNKNOWN indra/newview/llfloaterregioninfo.cpp UNKNOWN Diff: http://codereview.secondlife.com/r/397/diff Testing ------- Thanks, Vadim -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110715/4817f96e/attachment.htm From slitovchuk at productengine.com Fri Jul 15 12:15:17 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Fri, 15 Jul 2011 19:15:17 -0000 Subject: [opensource-dev] Review Request: STORM-1506 Regions set to Fixed Sun with viewers < 2.8 are not reset correctly when set to use a Day Cycle In-Reply-To: <20110715161356.7038.74516@domU-12-31-38-00-90-68.compute-1.internal> References: <20110715161356.7038.74516@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110715191517.8727.73349@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/397/#review881 ----------------------------------------------------------- Ship it! Looks good overall. - Seth On July 15, 2011, 9:13 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/397/ > ----------------------------------------------------------- > > (Updated July 15, 2011, 9:13 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Reset the estate to global sun when changing region environment settings. > > By the way, moved estate info storage from the REGION/ESTATE floater to a model class. > > > This addresses bug STORM-1506. > http://jira.secondlife.com/browse/STORM-1506 > > > Diffs > ----- > > indra/newview/CMakeLists.txt UNKNOWN > indra/newview/llestateinfomodel.h PRE-CREATION > indra/newview/llestateinfomodel.cpp PRE-CREATION > indra/newview/llfloaterauction.cpp UNKNOWN > indra/newview/llfloaterregioninfo.h UNKNOWN > indra/newview/llfloaterregioninfo.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/397/diff > > > Testing > ------- > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110715/34ebc0e8/attachment.htm From aklo at skyhighway.com Fri Jul 15 21:21:10 2011 From: aklo at skyhighway.com (aklo at skyhighway.com) Date: Fri, 15 Jul 2011 21:21:10 -0700 Subject: [opensource-dev] Blocked Message-ID: Hey Helpful People! Thx, Dave. i got your suggestion, but hadn't tried it out yet. See, i don't actually know as much about computers & stuff like that as i would like people to assume, my boss & present company included. To be honest, your message seemed really great, but it confused me and i was going to have to do a lot of reading to figure it out! :-) But, your parenthesized synopsis in the attached message here magically cleared a whole lot of it up. Maybe. We'll see. i don't get to do that test that i could've used SL for again until next month, but i'm going to do my best to be ready for it then. So, thx again for what looks like it's probably great advice! And, not to be all that picky or sensitive or whatever, if life hasn't taught me anything else it's to take what people give you and make the best of it, whatever it is. (Wasn't there someone Forrest Gump that said the same kinda thing, only comparing it to a box of chocolates or something?) Serious, it really doesn't matter all that much here, but if you're talking about me, "she" & those pronouns are the ones to use, if you don't mind? i mean thx for inviting me into the club and all, but i think the bathrooms in it have those gross stand-up things that i don't even ever wanna be in the same room with. Thx also for all the work y'all do to make SL - and make it a better place. i don't think of it in the same "game" way almost everyone else does, but it gets the job done just the same. This whole thing has been a great learning experience for me not just for the in-world part but for listening to y'all develop the source and the tantalizing opportunity to get involved in the whole exciting project myself. (One day...) Sorry for all the off-topic content. Please return to your regularly scheduled programming. ("Programming." hahahahaha) - AK Socksified works but yeah, takes more "liberal" corp IT attitudes than most will allow. I sent offlist the solution I used.. (openvpn to home networks static IP and route all SL traffic down that using local routes on client and openvpn server) On 7/15/2011 12:53 AM, Tateru Nino wrote: > > That's assuming they have the right kind of proxies there. HTTP proxies > > are commonplace, but SOCKS proxies are far less common and more tightly > > controlled on the corporate networks. He almost certainly has access to > > the former, but maybe not to the latter. > > > > On 15/07/2011 3:45 PM, Lance Corrimal wrote: >> >> Isn't it a good thing that there's a proxified viewer now... can >> >> someone point him/her at the downloads for a build with the proxy >> >> stuff? >> >> >> >> >> >> bye, >> >> LC >> >> >> >> >> >> Am Freitag, 15. Juli 2011 schrieb aklo at skyhighway.com: >>> >>> Robert, >>> >>> >>> >>> thx for the info, but i think the page is telling me the answer is >>> >>> actually, "No," because i don't have any access to the company's >>> >>> network stuff. They look at you funny if you even ask about it. >>> >>> i can configure a test machine any way i want to, but i can't do >>> >>> anything at all at all to the network. How depressing :-( >>> >>> >>> >>> Since it is for a real work project, i think i'll show the page to >>> >>> the IT guy, but i think this is just going to be another one of >>> >>> those funny looks experiences, and a "I'll get back to you later" >>> >>> that ends up being a not overly polite "helpful suggestion" from >>> >>> my boss. But i think it will be worth it just for the opportunity >>> >>> of getting to explain what i'm doing. >>> >>> >>> >>> - AK >>> >>> >>> >>> On Thu, Jul 14, 2011 at 10:17 PM, wrote: >>>>> >>>>> Hey y'all, i had something i wanted to do at work a coupla days >>>>> >>>>> ago >>> >>> that i >>> >>> >>>>> >>>>> coulda used SL for. It installed, but i couldn't get it to >>>>> >>>>> connect. Is there some kinda proxy setting that i need to fix >>>>> >>>>> to get SL to start from where i work? >>> >>> short answer is yes >>> >>> long answer is >>> >>> http://wiki.secondlife.com/wiki/Configuring_your_firewall >>> >>> >>> >>> -- Robert L Martin >>> >>> >>> >>> _______________________________________________ >>> >>> Policies and (un)subscribe information available here: >>> >>> http://wiki.secondlife.com/wiki/OpenSource-Dev >>> >>> Please read the policies before posting to keep unmoderated posting >>> >>> privileges >> >> _______________________________________________ >> >> Policies and (un)subscribe information available here: >> >> http://wiki.secondlife.com/wiki/OpenSource-Dev >> >> Please read the policies before posting to keep unmoderated posting privileges >> >> > > _______________________________________________ > > Policies and (un)subscribe information available here: > > http://wiki.secondlife.com/wiki/OpenSource-Dev > > Please read the policies before posting to keep unmoderated posting privileges > > _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges From oz at lindenlab.com Sat Jul 16 06:12:02 2011 From: oz at lindenlab.com (Oz Linden) Date: Sat, 16 Jul 2011 13:12:02 -0000 Subject: [opensource-dev] Review Request: Change pre-login viewer display URL to prepare for new community information display Message-ID: <20110716131202.7040.35385@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/399/ ----------------------------------------------------------- Review request for Viewer. Summary ------- This changes the URL from which the upper part of the viewer window is loaded prior to login. At the moment, the new URL is internally redirected to the same content as before, but shortly it will have new community and activity information on what's going on in Second Life. This addresses bug storm-1510. http://jira.secondlife.com/browse/storm-1510 Diffs ----- indra/newview/app_settings/settings.xml c6f2f4af65e5 indra/newview/llviewernetwork.cpp c6f2f4af65e5 indra/newview/tests/llviewernetwork_test.cpp c6f2f4af65e5 Diff: http://codereview.secondlife.com/r/399/diff Testing ------- Confirmed using the log file that the new URL is being requested. Changed the settings file locally to point to an internal prototype of the new screen and confirmed that it is displayed correctly. Thanks, Oz -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110716/719b557d/attachment.htm From thickbrick.sleaford at gmail.com Sat Jul 16 06:48:43 2011 From: thickbrick.sleaford at gmail.com (Thickbrick Sleaford) Date: Sat, 16 Jul 2011 13:48:43 -0000 Subject: [opensource-dev] Review Request: Change pre-login viewer display URL to prepare for new community information display In-Reply-To: <20110716131202.7040.35385@domU-12-31-38-00-90-68.compute-1.internal> References: <20110716131202.7040.35385@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110716134843.9587.58225@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/399/#review883 ----------------------------------------------------------- indra/newview/app_settings/settings.xml Setting the default value to something other than an empty string would override the selected grid's login page in LLGridManager::getGridInfo and LLGridManager::getLoginPage, which is probably not the desired result. In fact, I wonder why this setting is persistent at all. This should probably be renamed to CmdLineLoginPage, to be consistent with CmdLineLoginURI etc. - Thickbrick On July 16, 2011, 6:12 a.m., Oz Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/399/ > ----------------------------------------------------------- > > (Updated July 16, 2011, 6:12 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > This changes the URL from which the upper part of the viewer window is loaded prior to login. > > At the moment, the new URL is internally redirected to the same content as before, but shortly it will have new community and activity information on what's going on in Second Life. > > > This addresses bug storm-1510. > http://jira.secondlife.com/browse/storm-1510 > > > Diffs > ----- > > indra/newview/app_settings/settings.xml c6f2f4af65e5 > indra/newview/llviewernetwork.cpp c6f2f4af65e5 > indra/newview/tests/llviewernetwork_test.cpp c6f2f4af65e5 > > Diff: http://codereview.secondlife.com/r/399/diff > > > Testing > ------- > > Confirmed using the log file that the new URL is being requested. > Changed the settings file locally to point to an internal prototype of the new screen and confirmed that it is displayed correctly. > > > Thanks, > > Oz > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110716/0880555e/attachment.htm From dave at meadowlakearts.com Sat Jul 16 09:41:13 2011 From: dave at meadowlakearts.com (Dave Booth) Date: Sat, 16 Jul 2011 11:41:13 -0500 Subject: [opensource-dev] Blocked In-Reply-To: <3527901ab2af9d9fd58b68573e6b1589.squirrel@eregion.kicks-ass.net> References: <11a944ec0f0b85d9175179a9669cca01.squirrel@cruziomail.cruzio.com> <201107150745.38704.Lance.Corrimal@eregion.de> <4E1FD5C5.9040206@gmail.com> <4E1FDA63.7000105@meadowlakearts.com> <3527901ab2af9d9fd58b68573e6b1589.squirrel@eregion.kicks-ass.net> Message-ID: <4E21BF29.6030907@meadowlakearts.com> On 7/15/2011 2:44 AM, Lance Corrimal wrote: > > how does that works in a http-proxy-only network? > if it's locked down that tight, with only http connections allowed outbound and all those forced to go via proxy then of course it doesnt. But all you need is ONE outbound service that can avoid the proxy - I've had best results setting the vpn endpoint to use the https port, but if necessary, all you need is outbound ssh whether its proxied or not - you can "add a layer" and tunnel a ssl-based vpn over that. I know "tunneling a tunnel" isnt exactly best practice, and theoretically you could just tunnel the SL ports with ssh alone but the advantage of using a vpn is that it appears as a separate network interface to the local machine and it's therefore easier to route the LL public subnets traffic through it reliably. It's always easier to poke holes in a firewall or proxy from the inside out, they are designed to prevent unpleasantness coming the other way :) From secret.argent at gmail.com Sat Jul 16 10:08:12 2011 From: secret.argent at gmail.com (Argent Stonecutter) Date: Sat, 16 Jul 2011 12:08:12 -0500 Subject: [opensource-dev] Review Request: Allow objects to have 99.99% max hollow for default hollow shape. In-Reply-To: References: <20110712023444.10261.34149@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <6531C630-96A7-4DC7-A6D1-0A77E84115B8@gmail.com> On 2011-07-11, at 23:05, Dahlia Trimble wrote: > One thing I noticed while coding collision geometry for OpenSimulator is as hollow is increased and prims are twisted or otherwise manipulated such that the hollow shape doesnt exactly follow the outer shape, the probability increases that the surfaces formed by the triangles that make up the hollow shape may actually protrude beyond those that make up the outer surface. I'm not sure what SL sims do under these conditions but what ODE (Open Dynamics Engine - most commonly used physics engine in OpenSimulator) is create a condition where physical objects may become trapped between the resulting surfaces. ODE uses trimesh colliders and surface normals for determining collision surfaces and if prim hollow surfaces protrude outside of prim outer surfaces, the surface normals for these surfaces point in the wrong direction. This can be alleviated by increasing prim vertex count, but for some of these prims vertex count may already be even greater than 4000 vertices. Increasing it further would use excessive memory and likely increase the cost of computing collisions dramatically. I've found that a limit of 95% maximum hollow is a good compromise between prim complexity and usability. > > > On Mon, Jul 11, 2011 at 7:34 PM, Wolfpup Lowenhar wrote: > This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/388/ > > Review request for Viewer. > By Wolfpup Lowenhar. Given the possible uses of this capability, it would be acceptable for the physics shape to pin at 95% while the rendered shape is allowed to be thinner. From secret.argent at gmail.com Sat Jul 16 10:10:35 2011 From: secret.argent at gmail.com (Argent Stonecutter) Date: Sat, 16 Jul 2011 12:10:35 -0500 Subject: [opensource-dev] Review Request: Allow objects to have 99.99% max hollow for default hollow shape. In-Reply-To: <4E1CA718.7040807@boroon.dasgupta.ch> References: <20110712023444.10261.34149@domU-12-31-38-00-90-68.compute-1.internal> <20110712161350.7036.77355@domU-12-31-38-00-90-68.compute-1.internal> <4E1C9864.4000908@productengine.com> <4E1CA718.7040807@boroon.dasgupta.ch> Message-ID: On 2011-07-12, at 14:57, Boroondas Gupte wrote: > > I think by "ticket", Vadim meant the jira issue. I've already left a comment there with a reference to this discussion. Ah, thank you, I added my comment there as well. From oz at lindenlab.com Sat Jul 16 11:38:54 2011 From: oz at lindenlab.com (Oz Linden) Date: Sat, 16 Jul 2011 18:38:54 -0000 Subject: [opensource-dev] Review Request: Change pre-login viewer display URL to prepare for new community information display In-Reply-To: <20110716134843.9587.58225@domU-12-31-38-00-90-68.compute-1.internal> References: <20110716134843.9587.58225@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110716183854.9074.72797@domU-12-31-38-00-90-68.compute-1.internal> > On July 16, 2011, 6:48 a.m., Thickbrick Sleaford wrote: > > indra/newview/app_settings/settings.xml, line 4875 > > > > > > Setting the default value to something other than an empty string would override the selected grid's login page in LLGridManager::getGridInfo and LLGridManager::getLoginPage, which is probably not the desired result. In fact, I wonder why this setting is persistent at all. This should probably be renamed to CmdLineLoginPage, to be consistent with CmdLineLoginURI etc. That may be true (have not checked), but this same URL is the login page for all our grids, it doesn't matter. I confirmed that overriding on the command line does work. - Oz ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/399/#review883 ----------------------------------------------------------- On July 16, 2011, 6:12 a.m., Oz Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/399/ > ----------------------------------------------------------- > > (Updated July 16, 2011, 6:12 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > This changes the URL from which the upper part of the viewer window is loaded prior to login. > > At the moment, the new URL is internally redirected to the same content as before, but shortly it will have new community and activity information on what's going on in Second Life. > > > This addresses bug storm-1510. > http://jira.secondlife.com/browse/storm-1510 > > > Diffs > ----- > > indra/newview/app_settings/settings.xml c6f2f4af65e5 > indra/newview/llviewernetwork.cpp c6f2f4af65e5 > indra/newview/tests/llviewernetwork_test.cpp c6f2f4af65e5 > > Diff: http://codereview.secondlife.com/r/399/diff > > > Testing > ------- > > Confirmed using the log file that the new URL is being requested. > Changed the settings file locally to point to an internal prototype of the new screen and confirmed that it is displayed correctly. > > > Thanks, > > Oz > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110716/6fa4b7df/attachment.htm From sl.nicky.ml at googlemail.com Mon Jul 18 03:32:18 2011 From: sl.nicky.ml at googlemail.com (Nicky D.) Date: Mon, 18 Jul 2011 12:32:18 +0200 Subject: [opensource-dev] Viewer development 2.8.1 and a few new bugs In-Reply-To: References: Message-ID: Hello everyone, > - Invisiprims don't render well, they are completely black UNLESS they > are set to fullbright (no matter whether deferred shading is on or > off) > - Alpha doesn't render well either, once again unless fullbright is > on. Full strands of hair disappear, it's really ugly Over the weekend, I pulled the latest sources and build a new viewer. In short: I have those issues as well. It looks really odd. - I see 'shades' of attachments other people have hidden. - My HUD (Magical Compass) has buttons who are half hidden, the background of the HUD seems to be some texture with alpha. On some logins I see the back- ground, then on the next login everything is fine again. (The background is supposed to be invisible). - Issue with colours being black, same here. Sometimes zooming in fixes it, sometimes it just worsens it. - Some colours are really, really odd. They show like some rainbowish colour gradient, or maybe more like oil/fuel when poured in water. Again zooming can heal it at times, zooming out worsens it again. Right now I have no real clue what causes it. I tried the alpha switches on and off, no help. Playing with the advanced gfx settings (vbo buffers) and such did not help either. Disabling shaders is another thing that did not improve it much. I think I saw that problem with the textures crop up when mesh landed in viewer-development, but than did not have the time to investigate any more. And I have a ATI card, maybe that one helps too as info? Any ideas what do try would be really appreciated. > - And the "/me" bug has now migrated to the chat history itself. It > works on the chat floater, but if I say "/me smiles", I'll see "Marine > KelleyMarine Kelley smiles" on the history. Noticed that too. Cheers, Nicky From richard at lindenlab.com Mon Jul 18 10:02:42 2011 From: richard at lindenlab.com (Richard Nelson) Date: Mon, 18 Jul 2011 17:02:42 -0000 Subject: [opensource-dev] Review Request: Change pre-login viewer display URL to prepare for new community information display In-Reply-To: <20110716131202.7040.35385@domU-12-31-38-00-90-68.compute-1.internal> References: <20110716131202.7040.35385@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110718170242.2251.6590@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/399/#review885 ----------------------------------------------------------- Ship it! Looks good, let's try it without the change to settings.xml, though. - Richard On July 16, 2011, 6:12 a.m., Oz Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/399/ > ----------------------------------------------------------- > > (Updated July 16, 2011, 6:12 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > This changes the URL from which the upper part of the viewer window is loaded prior to login. > > At the moment, the new URL is internally redirected to the same content as before, but shortly it will have new community and activity information on what's going on in Second Life. > > > This addresses bug storm-1510. > http://jira.secondlife.com/browse/storm-1510 > > > Diffs > ----- > > indra/newview/app_settings/settings.xml c6f2f4af65e5 > indra/newview/llviewernetwork.cpp c6f2f4af65e5 > indra/newview/tests/llviewernetwork_test.cpp c6f2f4af65e5 > > Diff: http://codereview.secondlife.com/r/399/diff > > > Testing > ------- > > Confirmed using the log file that the new URL is being requested. > Changed the settings file locally to point to an internal prototype of the new screen and confirmed that it is displayed correctly. > > > Thanks, > > Oz > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110718/aac9c86b/attachment.htm From sllists at boroon.dasgupta.ch Mon Jul 18 10:53:38 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Mon, 18 Jul 2011 17:53:38 -0000 Subject: [opensource-dev] Review Request: STORM-1403: ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button names in People pane In-Reply-To: <20110711012417.10362.8489@domU-12-31-38-00-90-68.compute-1.internal> References: <20110711012417.10362.8489@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110718175338.2256.90870@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/387/ ----------------------------------------------------------- (Updated July 18, 2011, 10:53 a.m.) Review request for Viewer. Changes ------- Did complete testing. Summary ------- The layout_panels containing the buttons didn't have unique names. Renamed them so that their names are now unique within their parent element. Removed the share_btn element and containing layout_panel from translations that contained it, as it doesn't occur in the English version. The English file mixed tabs and spaces. Converted tabs to spaces for that file. Stripped trailing whitespace from the English file. This addresses bug STORM-1403. http://jira.secondlife.com/browse/STORM-1403 Diffs ----- doc/contributions.txt 2204db549295 indra/newview/skins/minimal/xui/da/panel_people.xml 2204db549295 indra/newview/skins/minimal/xui/de/panel_people.xml 2204db549295 indra/newview/skins/minimal/xui/en/panel_people.xml 2204db549295 indra/newview/skins/minimal/xui/es/panel_people.xml 2204db549295 indra/newview/skins/minimal/xui/fr/panel_people.xml 2204db549295 indra/newview/skins/minimal/xui/it/panel_people.xml 2204db549295 indra/newview/skins/minimal/xui/ja/panel_people.xml 2204db549295 indra/newview/skins/minimal/xui/pl/panel_people.xml 2204db549295 indra/newview/skins/minimal/xui/pt/panel_people.xml 2204db549295 Diff: http://codereview.secondlife.com/r/387/diff Testing (updated) ------- Switched to French, relogged, changed to default mode and logged out. Applied this patch with -p3 to SecondLife-i686-2.7.5.233393/ (I'm using a downloaded build, as I still cannot complete a build again.) Logged in, clicked 'Personnes' button, then 'MES AMIS' tab. The Call and Teleport buttons were now labeled in French. Not tested: * Funktionality of the buttons. * Languages other than French. Update: Tested "My Friends" tab of "People" floater (basic mode) in da, de, en, es, fr, it, ja, pl and pt: Verified for each language that * labels on all 4 buttons on that tab are translated (or as translated as in the XML files. "IM" seems to be the wanted label for the chat button in most of them.) * tool-tips of all 4 buttons are translated * all 4 buttons cause the action they're intended to cause when clicked Thanks, Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110718/a5dc4801/attachment.htm From jhwelch at gmail.com Mon Jul 18 10:55:56 2011 From: jhwelch at gmail.com (Jonathan Yap) Date: Mon, 18 Jul 2011 17:55:56 -0000 Subject: [opensource-dev] Review Request: Change pre-login viewer display URL to prepare for new community information display In-Reply-To: <20110716134843.9587.58225@domU-12-31-38-00-90-68.compute-1.internal> References: <20110716134843.9587.58225@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110718175556.5193.44138@domU-12-31-38-00-90-68.compute-1.internal> > On July 16, 2011, 6:48 a.m., Thickbrick Sleaford wrote: > > indra/newview/app_settings/settings.xml, line 4875 > > > > > > Setting the default value to something other than an empty string would override the selected grid's login page in LLGridManager::getGridInfo and LLGridManager::getLoginPage, which is probably not the desired result. In fact, I wonder why this setting is persistent at all. This should probably be renamed to CmdLineLoginPage, to be consistent with CmdLineLoginURI etc. > > Oz Linden wrote: > That may be true (have not checked), but this same URL is the login page for all our grids, it doesn't matter. > > I confirmed that overriding on the command line does work. > Would this change affect anything when connecting to a non-LL grid? - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/399/#review883 ----------------------------------------------------------- On July 16, 2011, 6:12 a.m., Oz Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/399/ > ----------------------------------------------------------- > > (Updated July 16, 2011, 6:12 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > This changes the URL from which the upper part of the viewer window is loaded prior to login. > > At the moment, the new URL is internally redirected to the same content as before, but shortly it will have new community and activity information on what's going on in Second Life. > > > This addresses bug storm-1510. > http://jira.secondlife.com/browse/storm-1510 > > > Diffs > ----- > > indra/newview/app_settings/settings.xml c6f2f4af65e5 > indra/newview/llviewernetwork.cpp c6f2f4af65e5 > indra/newview/tests/llviewernetwork_test.cpp c6f2f4af65e5 > > Diff: http://codereview.secondlife.com/r/399/diff > > > Testing > ------- > > Confirmed using the log file that the new URL is being requested. > Changed the settings file locally to point to an internal prototype of the new screen and confirmed that it is displayed correctly. > > > Thanks, > > Oz > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110718/1f392e6c/attachment-0001.htm From slitovchuk at productengine.com Mon Jul 18 16:01:42 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Mon, 18 Jul 2011 23:01:42 -0000 Subject: [opensource-dev] Review Request: (STORM-1221) [HARD CODED] ALL LANGS Several strings are untranslated under Group Profile Land/Assets (French viewer) Message-ID: <20110718230142.3131.73097@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/400/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Hard coded dates made localizable under Group Profile Land/Assets. Added a function for parsing a date string of specific format. Added strings defining the date format in Group Profile Land/Assets that should be localized. This addresses bug STORM-1221. http://jira.secondlife.com/browse/STORM-1221 Diffs ----- indra/newview/lldateutil.h d8c37b383028 indra/newview/lldateutil.cpp d8c37b383028 indra/newview/llpanelgrouplandmoney.cpp d8c37b383028 indra/newview/skins/default/xui/en/strings.xml d8c37b383028 Diff: http://codereview.secondlife.com/r/400/diff Testing ------- Thanks, Seth -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110718/2b44b1bf/attachment.htm From slitovchuk at productengine.com Mon Jul 18 16:07:43 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Mon, 18 Jul 2011 23:07:43 -0000 Subject: [opensource-dev] Review Request: (STORM-1221) [HARD CODED] ALL LANGS Several strings are untranslated under Group Profile Land/Assets (French viewer) In-Reply-To: <20110718230142.3131.73097@domU-12-31-38-00-90-68.compute-1.internal> References: <20110718230142.3131.73097@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110718230743.2253.60171@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/400/#review888 ----------------------------------------------------------- indra/newview/lldateutil.h Yes, there should be no "this" in this line. - Seth On July 18, 2011, 4:01 p.m., Seth ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/400/ > ----------------------------------------------------------- > > (Updated July 18, 2011, 4:01 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Hard coded dates made localizable under Group Profile Land/Assets. > > Added a function for parsing a date string of specific format. > Added strings defining the date format in Group Profile Land/Assets that should be localized. > > > This addresses bug STORM-1221. > http://jira.secondlife.com/browse/STORM-1221 > > > Diffs > ----- > > indra/newview/lldateutil.h d8c37b383028 > indra/newview/lldateutil.cpp d8c37b383028 > indra/newview/llpanelgrouplandmoney.cpp d8c37b383028 > indra/newview/skins/default/xui/en/strings.xml d8c37b383028 > > Diff: http://codereview.secondlife.com/r/400/diff > > > Testing > ------- > > > Thanks, > > Seth > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110718/c66fd72b/attachment.htm From psimerlin at gmail.com Mon Jul 18 17:57:02 2011 From: psimerlin at gmail.com (Psi Merlin) Date: Tue, 19 Jul 2011 01:57:02 +0100 Subject: [opensource-dev] Viewer development 2.8.1 and a few new bugs In-Reply-To: References: Message-ID: <4E24D65E.9050407@gmail.com> On 18/07/11 11:32, Nicky D. wrote: > Over the weekend, I pulled the latest sources and build a new viewer. > In short: I have those issues as well. > > It looks really odd. > - I see 'shades' of attachments other people have hidden. > - My HUD (Magical Compass) has buttons who are half hidden, the background > of the HUD seems to be some texture with alpha. On some logins I see the back- > ground, then on the next login everything is fine again. (The > background is supposed > to be invisible). > - Issue with colours being black, same here. Sometimes zooming in > fixes it, sometimes > it just worsens it. > - Some colours are really, really odd. They show like some rainbowish > colour gradient, or > maybe more like oil/fuel when poured in water. Again zooming can heal > it at times, zooming > out worsens it again. > > Right now I have no real clue what causes it. I tried the alpha > switches on and off, no help. > Playing with the advanced gfx settings (vbo buffers) and such did not > help either. Disabling > shaders is another thing that did not improve it much. > > I think I saw that problem with the textures crop up when mesh landed > in viewer-development, > but than did not have the time to investigate any more. > > And I have a ATI card, maybe that one helps too as info? > > Any ideas what do try would be really appreciated. Nicky, I get the same artefacts - Objects having a rainbow 'overlay' or blackened surfaces, Shiny generating wild colours. The colours vary as the camera moves, some parts of the image may render normally. The colours are superimposed on the object textures and blend across the triangle fragments. Tweaking graphic parameters tends to produce a new set of colours. Sky, terrain, Avatars appear normal. I've tried playing with most render options - the effect shows with or without basic shaders / VBO / Lighting... Thsi is on a standalong 64bit Linux build on Gentoo, core i7 920 / nVidia GTX 580. It started with the big mesh merge and continues with the current viewer-development. I've been trying to locate the problem but delving into the graphics system is something of an adventure - any clues would be welcome. - Psi From aklo at skyhighway.com Mon Jul 18 18:52:49 2011 From: aklo at skyhighway.com (aklo at skyhighway.com) Date: Mon, 18 Jul 2011 18:52:49 -0700 Subject: [opensource-dev] Viewer development 2.8.1 and a few new bugs Message-ID: <80ec8e8fd11d414c3cbc9e3116c083d3.squirrel@cruziomail.cruzio.com> On 18/07/11 11:32, Nicky D. wrote: > > Over the weekend, I pulled the latest sources and build a new viewer. > > In short: I have those issues as well. > > > > It looks really odd. > > - I see 'shades' of attachments other people have hidden. > > - My HUD (Magical Compass) has buttons who are half hidden, the background > > of the HUD seems to be some texture with alpha. On some logins I see the back- > > ground, then on the next login everything is fine again. (The > > background is supposed > > to be invisible). > > - Issue with colours being black, same here. Sometimes zooming in > > fixes it, sometimes > > it just worsens it. > > - Some colours are really, really odd. They show like some rainbowish > > colour gradient, or > > maybe more like oil/fuel when poured in water. Again zooming can heal > > it at times, zooming > > out worsens it again. > > > > Right now I have no real clue what causes it. I tried the alpha > > switches on and off, no help. > > Playing with the advanced gfx settings (vbo buffers) and such did not > > help either. Disabling > > shaders is another thing that did not improve it much. > > > > I think I saw that problem with the textures crop up when mesh landed > > in viewer-development, > > but than did not have the time to investigate any more. > > > > And I have a ATI card, maybe that one helps too as info? > > > > Any ideas what do try would be really appreciated. Nicky, I get the same artefacts - Objects having a rainbow 'overlay' or blackened surfaces, Shiny generating wild colours. The colours vary as the camera moves, some parts of the image may render normally. The colours are superimposed on the object textures and blend across the triangle fragments. Tweaking graphic parameters tends to produce a new set of colours. Sky, terrain, Avatars appear normal. i don't have any idea what the problem is, but i think it's really interesting that i see the same kinds of things in Blender when i'm making sculpties! Since you say something about "the big mesh merge" and that is related to the kind of things that sculpties are for, it makes me go, "Hmmm..." Good Luck! - AK --------------------------------------------------------------------------- I've tried playing with most render options - the effect shows with or without basic shaders / VBO / Lighting... Thsi is on a standalong 64bit Linux build on Gentoo, core i7 920 / nVidia GTX 580. It started with the big mesh merge and continues with the current viewer-development. I've been trying to locate the problem but delving into the graphics system is something of an adventure - any clues would be welcome. - Psi _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges From thomas.shikami at online.de Mon Jul 18 19:02:11 2011 From: thomas.shikami at online.de (Thomas Shikami) Date: Tue, 19 Jul 2011 04:02:11 +0200 Subject: [opensource-dev] Blocked In-Reply-To: References: Message-ID: <4E24E5A3.9040606@online.de> If you want to connect through your corporate network, you should talk to the network administrator about it, they know how to do it. There are SL versions supporting SOCKS5. About installing Second Life on corporate PCs, talk to the system administrator about it in before, they want to know and there might be policies not allowing those. Myself being administrator, I would prefer if the users would use tunneling to their home network, preferably SSH or http-tunnel over SSL. Traffic would originate from the home network of the user then, not from the corporation. The most preferable solution to that issue though would be, if you bring your own notebook using a 3G UMTS/HDSPA or other wireless-modem to connect to the internet. That way the corporate network would be isolated and unaffected by your experiments. There is a reason the corporate network is proxified instead of just NAT routed. Am 15.07.2011 04:17, schrieb aklo at skyhighway.com: > Hey y'all, i had something i wanted to do at work a coupla days ago that i > coulda used SL for. It installed, but i couldn't get it to connect. Is > there some kinda proxy setting that i need to fix to get SL to start from > where i work? They have a proxy server there that all external traffic > has to go through. i know i have to tell Firefox& everything else about > it all the time to get them to work. i looked in the XML but didn't see > anything inspiring in the little bit of time i had for it. > > The thing i have to do is just a dumb test, but SL is a pretty good thing > to do it with, and an excuse to spend maybe 10 whole minutes doing SL from > work about once a week. From aklo at skyhighway.com Mon Jul 18 20:23:33 2011 From: aklo at skyhighway.com (aklo at skyhighway.com) Date: Mon, 18 Jul 2011 20:23:33 -0700 Subject: [opensource-dev] Blocked Message-ID: Thanks for the info! Between you and Dave i may figure something out yet! But i think tunneling to my home network is not a way to make it happen. My download speed at home is never much better than 1 Mbit and usually a lot lower. Upload is never over about 150 Kbit. (i just checked: 880 up, 115 down.) See, the part of town i live in is not treated very well by anyone. AT&T oversubscribes our lines and well, more detail isn't helpful. Unlike you, the IT guy at work isn't any more helpful than he has to be, either, but the people at school are. If tunneling somewhere is a solution, maybe i can get them to help me connect to something at school. - AK --------------------------------------------------------------------------- If you want to connect through your corporate network, you should talk to the network administrator about it, they know how to do it. There are SL versions supporting SOCKS5. About installing Second Life on corporate PCs, talk to the system administrator about it in before, they want to know and there might be policies not allowing those. Myself being administrator, I would prefer if the users would use tunneling to their home network, preferably SSH or http-tunnel over SSL. Traffic would originate from the home network of the user then, not from the corporation. The most preferable solution to that issue though would be, if you bring your own notebook using a 3G UMTS/HDSPA or other wireless-modem to connect to the internet. That way the corporate network would be isolated and unaffected by your experiments. There is a reason the corporate network is proxified instead of just NAT routed. Am 15.07.2011 04:17, schrieb aklo at skyhighway.com: > > Hey y'all, i had something i wanted to do at work a coupla days ago that i > > coulda used SL for. It installed, but i couldn't get it to connect. Is > > there some kinda proxy setting that i need to fix to get SL to start from > > where i work? They have a proxy server there that all external traffic > > has to go through. i know i have to tell Firefox& everything else about > > it all the time to get them to work. i looked in the XML but didn't see > > anything inspiring in the little bit of time i had for it. > > > > The thing i have to do is just a dumb test, but SL is a pretty good thing > > to do it with, and an excuse to spend maybe 10 whole minutes doing SL from > > work about once a week. _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges From jhwelch at gmail.com Tue Jul 19 02:11:16 2011 From: jhwelch at gmail.com (Jonathan Yap) Date: Tue, 19 Jul 2011 09:11:16 -0000 Subject: [opensource-dev] Review Request: (STORM-1221) [HARD CODED] ALL LANGS Several strings are untranslated under Group Profile Land/Assets (French viewer) In-Reply-To: <20110718230142.3131.73097@domU-12-31-38-00-90-68.compute-1.internal> References: <20110718230142.3131.73097@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110719091116.5193.32006@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/400/#review889 ----------------------------------------------------------- indra/newview/lldateutil.cpp Fix spelling of with (h is missing) - Jonathan On July 18, 2011, 4:01 p.m., Seth ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/400/ > ----------------------------------------------------------- > > (Updated July 18, 2011, 4:01 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Hard coded dates made localizable under Group Profile Land/Assets. > > Added a function for parsing a date string of specific format. > Added strings defining the date format in Group Profile Land/Assets that should be localized. > > > This addresses bug STORM-1221. > http://jira.secondlife.com/browse/STORM-1221 > > > Diffs > ----- > > indra/newview/lldateutil.h d8c37b383028 > indra/newview/lldateutil.cpp d8c37b383028 > indra/newview/llpanelgrouplandmoney.cpp d8c37b383028 > indra/newview/skins/default/xui/en/strings.xml d8c37b383028 > > Diff: http://codereview.secondlife.com/r/400/diff > > > Testing > ------- > > > Thanks, > > Seth > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110719/6a6d187c/attachment.htm From vsavchuk at productengine.com Tue Jul 19 06:22:51 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 19 Jul 2011 13:22:51 -0000 Subject: [opensource-dev] Review Request: (STORM-1221) [HARD CODED] ALL LANGS Several strings are untranslated under Group Profile Land/Assets (French viewer) In-Reply-To: <20110718230142.3131.73097@domU-12-31-38-00-90-68.compute-1.internal> References: <20110718230142.3131.73097@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110719132251.2251.59873@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/400/#review890 ----------------------------------------------------------- Looking good overall. indra/newview/skins/default/xui/en/strings.xml Irrelevant change? - Vadim On July 18, 2011, 4:01 p.m., Seth ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/400/ > ----------------------------------------------------------- > > (Updated July 18, 2011, 4:01 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Hard coded dates made localizable under Group Profile Land/Assets. > > Added a function for parsing a date string of specific format. > Added strings defining the date format in Group Profile Land/Assets that should be localized. > > > This addresses bug STORM-1221. > http://jira.secondlife.com/browse/STORM-1221 > > > Diffs > ----- > > indra/newview/lldateutil.h d8c37b383028 > indra/newview/lldateutil.cpp d8c37b383028 > indra/newview/llpanelgrouplandmoney.cpp d8c37b383028 > indra/newview/skins/default/xui/en/strings.xml d8c37b383028 > > Diff: http://codereview.secondlife.com/r/400/diff > > > Testing > ------- > > > Thanks, > > Seth > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110719/66c3a406/attachment.htm From slitovchuk at productengine.com Tue Jul 19 07:20:29 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Tue, 19 Jul 2011 14:20:29 -0000 Subject: [opensource-dev] Review Request: (STORM-1221) [HARD CODED] ALL LANGS Several strings are untranslated under Group Profile Land/Assets (French viewer) In-Reply-To: <20110718230142.3131.73097@domU-12-31-38-00-90-68.compute-1.internal> References: <20110718230142.3131.73097@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110719142029.2252.47275@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/400/ ----------------------------------------------------------- (Updated July 19, 2011, 7:20 a.m.) Review request for Viewer. Changes ------- Fixed typos. Removed irrelevant changes. Summary ------- Hard coded dates made localizable under Group Profile Land/Assets. Added a function for parsing a date string of specific format. Added strings defining the date format in Group Profile Land/Assets that should be localized. This addresses bug STORM-1221. http://jira.secondlife.com/browse/STORM-1221 Diffs (updated) ----- indra/newview/lldateutil.h d8c37b383028 indra/newview/lldateutil.cpp d8c37b383028 indra/newview/llpanelgrouplandmoney.cpp d8c37b383028 indra/newview/skins/default/xui/en/strings.xml d8c37b383028 Diff: http://codereview.secondlife.com/r/400/diff Testing ------- Thanks, Seth -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110719/2798bd35/attachment.htm From vsavchuk at productengine.com Tue Jul 19 09:11:55 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 19 Jul 2011 16:11:55 -0000 Subject: [opensource-dev] Review Request: (STORM-1221) [HARD CODED] ALL LANGS Several strings are untranslated under Group Profile Land/Assets (French viewer) In-Reply-To: <20110719142029.2252.47275@domU-12-31-38-00-90-68.compute-1.internal> References: <20110719142029.2252.47275@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110719161155.3133.33032@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/400/#review891 ----------------------------------------------------------- Ship it! - Vadim On July 19, 2011, 7:20 a.m., Seth ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/400/ > ----------------------------------------------------------- > > (Updated July 19, 2011, 7:20 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Hard coded dates made localizable under Group Profile Land/Assets. > > Added a function for parsing a date string of specific format. > Added strings defining the date format in Group Profile Land/Assets that should be localized. > > > This addresses bug STORM-1221. > http://jira.secondlife.com/browse/STORM-1221 > > > Diffs > ----- > > indra/newview/lldateutil.h d8c37b383028 > indra/newview/lldateutil.cpp d8c37b383028 > indra/newview/llpanelgrouplandmoney.cpp d8c37b383028 > indra/newview/skins/default/xui/en/strings.xml d8c37b383028 > > Diff: http://codereview.secondlife.com/r/400/diff > > > Testing > ------- > > > Thanks, > > Seth > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110719/1e0ceeaa/attachment.htm From pguslisty at productengine.com Tue Jul 19 11:11:45 2011 From: pguslisty at productengine.com (Paul ProductEngine) Date: Tue, 19 Jul 2011 18:11:45 -0000 Subject: [opensource-dev] Review Request: STORM-519 ( "Delete" is enabled in the context menu for folders which contain worn items) In-Reply-To: <20110714091504.7036.71459@domU-12-31-38-00-90-68.compute-1.internal> References: <20110714091504.7036.71459@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110719181145.2253.56901@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/396/ ----------------------------------------------------------- (Updated July 19, 2011, 11:11 a.m.) Review request for Viewer. Summary ------- - Disable "Delete" menu item in case selected folder contains non-removable items. This addresses bug storm-519. http://jira.secondlife.com/browse/storm-519 Diffs (updated) ----- indra/newview/llinventorybridge.cpp 7c7d01be2310 Diff: http://codereview.secondlife.com/r/396/diff Testing ------- Thanks, Paul -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110719/9d731ffe/attachment-0001.htm From pguslisty at productengine.com Tue Jul 19 11:13:57 2011 From: pguslisty at productengine.com (Paul ProductEngine) Date: Tue, 19 Jul 2011 18:13:57 -0000 Subject: [opensource-dev] Review Request: STORM-519 ( "Delete" is enabled in the context menu for folders which contain worn items) In-Reply-To: <20110714160344.18259.85998@domU-12-31-38-00-90-68.compute-1.internal> References: <20110714160344.18259.85998@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110719181357.3132.37143@domU-12-31-38-00-90-68.compute-1.internal> > On July 14, 2011, 9:03 a.m., Boroondas Gupte wrote: > > indra/newview/llinventorybridge.cpp, line 2502 > > > > > > We could just use > > if (!isItemRemovable()) > > here, couldn't we? You are right. Changed according to your commentaries. - Paul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/396/#review877 ----------------------------------------------------------- On July 19, 2011, 11:11 a.m., Paul ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/396/ > ----------------------------------------------------------- > > (Updated July 19, 2011, 11:11 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > - Disable "Delete" menu item in case selected folder contains non-removable items. > > > This addresses bug storm-519. > http://jira.secondlife.com/browse/storm-519 > > > Diffs > ----- > > indra/newview/llinventorybridge.cpp 7c7d01be2310 > > Diff: http://codereview.secondlife.com/r/396/diff > > > Testing > ------- > > > Thanks, > > Paul > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110719/3aa0eff0/attachment.htm From vsavchuk at productengine.com Tue Jul 19 11:20:14 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 19 Jul 2011 18:20:14 -0000 Subject: [opensource-dev] Review Request: STORM-1487 Gestures -> Get more leads to wrong URL Message-ID: <20110719182014.2257.79443@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/401/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Changed the URL. This addresses bug STORM-1487. http://jira.secondlife.com/browse/STORM-1487 Diffs ----- indra/newview/app_settings/settings.xml UNKNOWN Diff: http://codereview.secondlife.com/r/401/diff Testing ------- Thanks, Vadim -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110719/1ac8bf3e/attachment.htm From sllists at boroon.dasgupta.ch Tue Jul 19 11:22:30 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Tue, 19 Jul 2011 18:22:30 -0000 Subject: [opensource-dev] Review Request: STORM-519 ( "Delete" is enabled in the context menu for folders which contain worn items) In-Reply-To: <20110719181145.2253.56901@domU-12-31-38-00-90-68.compute-1.internal> References: <20110719181145.2253.56901@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110719182230.2251.47064@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/396/#review893 ----------------------------------------------------------- Ship it! :-) - Boroondas On July 19, 2011, 11:11 a.m., Paul ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/396/ > ----------------------------------------------------------- > > (Updated July 19, 2011, 11:11 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > - Disable "Delete" menu item in case selected folder contains non-removable items. > > > This addresses bug storm-519. > http://jira.secondlife.com/browse/storm-519 > > > Diffs > ----- > > indra/newview/llinventorybridge.cpp 7c7d01be2310 > > Diff: http://codereview.secondlife.com/r/396/diff > > > Testing > ------- > > > Thanks, > > Paul > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110719/62e45df4/attachment.htm From sitearm at gmail.com Tue Jul 19 12:25:17 2011 From: sitearm at gmail.com (Sitearm) Date: Tue, 19 Jul 2011 14:25:17 -0500 Subject: [opensource-dev] SLCC 2011 Updates In-Reply-To: References: Message-ID: *includes list of 23 Linden Lab Staffers attending* ** http://sitearm.wordpress.com/2011/07/19/slcc-2011-updates/ SLCC 2011 Updates July 19, 2011 ? sitearm *[image: slcc 2011 logo]Important Dates ? Mark Your Calendar!* 7/18 ? In Memoriam entries due 7/21 ? Hotel group rate discountends 7/22 ? Early Registrationends 7/31 ? Presenters must be registered 8/1 ? Custom badgesdue 8/5 ? Social Events & Mixersdue 8/11 ? Track Leaders & Volunteers arrive 8/12 ? *7th Annual SLCC* begins!! *Check out **Who?s Coming to SLCC* *?* *[image: slcc sims map view 512x512]Who Said SLCC Isn?t Virtual?* Presentations are webcast live to SLor your favorite Internet browser. Have a party with your friends, and watch and discuss the 30+ presentations covering all areas of SL Resident interest. Presentations are recorded to watch again at a time that best suits your schedule. Live attendance fees cover webcasts and recordings, which are provided free of charge to all SL residents. *Background* Second Life? is the world?s leading 3D Web virtual environment and virtual goods economy. SLCC is the Second Life Community Convention, held once a year *for* residents *by* residents. This year SLCC is in Oakland, California, eight miles from Linden Lab Headquarters. SLCC is a non-profit, "mixed-mode" conference, meaning you can attend it Live or you can attend it Remote. All presentations are webcast live and recorded, so that all Second Life Residents have access to the materials. SLCC 2011 features key updates from Linden Lab and SL Residents. *[image: oakland_night_skyline_web_by_thedude] Keynotes* . Rod Humble (SL: Rodvik Linden) *The Future of Second Life* . Rik Panganiban (SL: Rik Riel) *Creating a Better World* . Aliza Sherman (SL: Cybergrrl Oh) *Our Virtual Lives* 30 plus presentations are scheduled into five conference tracks: . Artistic & Creative Expression, . Commerce & Marketing, . Developers & Open Source, . Public Service & Education, and . Social Experience & Communities. *[image: slcc panel by jeska d]Linden Lab Staffers Attending **Meet and talk with your favorite Linden*: Bagman, BK, Brett, Brooke, Charlar, Colossus, Delby, Durian, Elise, Esbee, Fredrik, Gez, Kim, Leonidas, Madhavi, Nyx, Pete, Rodvik, Runitai, Tiggs, Viale. Vogt, Yoz . Marc Viale (SL: Viale Linden) *The Future of Second Life Social Experience and Communities *. Charlie Hite (SL: Charlar Linden) *The Future of Mesh in Second Life *. Brett Atwood (SL: Brett Linden) *Destination Guide & Beyond: New SL Promotional Channels Today *. Jeff Vogt (SL: Vogt Linden) *The Future of Commerce in Second Life *. John Laurence (SL: Durian Linden), Jeff Vogt (SL: Vogt Linden), Sarah Kuehnle (SL: Esbee Linden), Michael Gesner (SL: Gez Linden), Peter Gray (SL: Peter Linden). *The Future of the Second Life Platform* *More *Web: www.slconvention.org Email: info @ avacon . org Live attendance fees cover webcasts and recordings. Enjoy! -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110719/7187daef/attachment.htm From oz at lindenlab.com Wed Jul 20 03:40:11 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Wed, 20 Jul 2011 06:40:11 -0400 Subject: [opensource-dev] Snowstorm PO review viewer Message-ID: <4E26B08B.1000002@lindenlab.com> Review viewer for checking whether or not issues are properly resolved: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_viewer-poreview/rev/236138/index.html STORM-1221 [HARD CODED] ALL LANGS Several strings are untranslated under Group Profile Land/Assets (French viewer) STORM-1476 [crashhunters] Crash loading local chat log STORM-1487 Gestures -> Get more leads to wrong URL STORM-1502 Disable "Delete Water/Sky/Day Preset" dialogs if no user presets exist STORM-1503 Find floater doesn't set focus to its browser. VWR-26066 [#STORM-1397] [VWR-26066] Opening the map floater consistently produces a warning on stdout and debug console. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110720/dc82abbd/attachment.htm From pguslisty at productengine.com Wed Jul 20 09:09:45 2011 From: pguslisty at productengine.com (Paul ProductEngine) Date: Wed, 20 Jul 2011 16:09:45 -0000 Subject: [opensource-dev] Review Request: STORM-1474 Implement Show Last Search in viewer chrome Message-ID: <20110720160945.2253.47159@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/402/ ----------------------------------------------------------- Review request for Viewer. Summary ------- - Removed hiding floater on teleport This addresses bug storm-1474. http://jira.secondlife.com/browse/storm-1474 Diffs ----- indra/newview/llagent.cpp d8c37b383028 Diff: http://codereview.secondlife.com/r/402/diff Testing ------- Thanks, Paul -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110720/ba045d11/attachment.htm From sllists at boroon.dasgupta.ch Wed Jul 20 09:19:57 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Wed, 20 Jul 2011 16:19:57 -0000 Subject: [opensource-dev] Review Request: STORM-1474 Implement Show Last Search in viewer chrome In-Reply-To: <20110720160945.2253.47159@domU-12-31-38-00-90-68.compute-1.internal> References: <20110720160945.2253.47159@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110720161957.4919.52856@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/402/#review894 ----------------------------------------------------------- Ship it! - Boroondas On July 20, 2011, 9:09 a.m., Paul ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/402/ > ----------------------------------------------------------- > > (Updated July 20, 2011, 9:09 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > - Removed hiding floater on teleport > > > This addresses bug storm-1474. > http://jira.secondlife.com/browse/storm-1474 > > > Diffs > ----- > > indra/newview/llagent.cpp d8c37b383028 > > Diff: http://codereview.secondlife.com/r/402/diff > > > Testing > ------- > > > Thanks, > > Paul > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110720/12c3ce86/attachment.htm From sllists at boroon.dasgupta.ch Wed Jul 20 11:14:14 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Wed, 20 Jul 2011 18:14:14 -0000 Subject: [opensource-dev] Review Request: STORM-49 As a Content Creator, I have to select a regular prim type and than choose sculpt from a drop-down menu in order to create a sculpted prim. In-Reply-To: <20110602210325.6377.56894@domU-12-31-38-00-90-68.compute-1.internal> References: <20110602210325.6377.56894@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110720181414.9786.64870@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/317/#review895 ----------------------------------------------------------- (The first 4 comments aren't about your change, but about pre-existing code. Feel free to ignore them. Please do take note of the last 4 comments of this review which do concern your change.) indra/llmath/llvolume.h Why are the primitive shapes in decimal notation, but the masks for them in hexadecimal notation? That's confusing. indra/llprimitive/llprimitive.cpp Could be re-written as a switch-case structure. (Not that that would be any shorter, as we'd need break;s everywhere.) indra/newview/llfloatertools.cpp An empty line wouldn't hurt here. indra/newview/lltoolplacer.cpp Why are we mentioning all these cases when we just let them fall through to the default case? This could be handled like https://codereview.secondlife.com/r/231/diff/1-2/#chunk1.14 , i.e. make the list of valid cases exhaustive, move their common action (incl. the break;) before the default: label and output a warning if we reach the default case. indra/newview/lltoolplacer.cpp Remove the empty line. indra/newview/lltoolplacer.cpp Where are these numbers coming from? Are they used elsewhere in the code? indra/newview/llviewerobjectlist.h Please re-introduce the empty line before // Inlines indra/newview/llviewerobjectlist.cpp Is a global variable really the way to go here? Also, please add a short comment explaining the semantics of this variable. - Boroondas On June 2, 2011, 2:03 p.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/317/ > ----------------------------------------------------------- > > (Updated June 2, 2011, 2:03 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > As a Content Creator, I have to select a regular prim type and than choose sculpt from a drop-down menu in order to create a sculpted prim. > > I have added a new Sculpt icon to the list of available object types that can be selected on the build menu. You can now rez a sculpt the same way you do a cube. > > Possible issue: I made up a new Pcode used only by the viewer. > > > This addresses bug STORM-49. > http://jira.secondlife.com/browse/STORM-49 > > > Diffs > ----- > > doc/contributions.txt a36a329e77cc > indra/llmath/llvolume.h a36a329e77cc > indra/llprimitive/llprimitive.cpp a36a329e77cc > indra/newview/llfloatertools.cpp a36a329e77cc > indra/newview/lltoolplacer.cpp a36a329e77cc > indra/newview/llviewerobjectlist.h a36a329e77cc > indra/newview/llviewerobjectlist.cpp a36a329e77cc > indra/newview/skins/default/textures/build/Object_Sculpt.png a36a329e77cc > indra/newview/skins/default/textures/build/Object_Sculpt_Selected.png a36a329e77cc > indra/newview/skins/default/textures/textures.xml a36a329e77cc > indra/newview/skins/default/xui/en/floater_tools.xml a36a329e77cc > > Diff: http://codereview.secondlife.com/r/317/diff > > > Testing > ------- > > Rezzed a sculpt both alone and with someone watching. > > Rezzed sculpts as fast as I could click (poor mans load test). > > > Thanks, > > Jonathan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110720/eb0c8acf/attachment-0001.htm From pguslisty at productengine.com Wed Jul 20 11:16:19 2011 From: pguslisty at productengine.com (Paul ProductEngine) Date: Wed, 20 Jul 2011 18:16:19 -0000 Subject: [opensource-dev] Review Request: STORM-1458 ([crashhunters] crash at LLParticipantList::LLParticipantListMenu::isGroupModerator() [secondlife-bin llparticipantlist.cpp]) Message-ID: <20110720181619.2254.3279@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/404/ ----------------------------------------------------------- Review request for Viewer. Summary ------- - Added null checking This addresses bug storm-1458. http://jira.secondlife.com/browse/storm-1458 Diffs ----- indra/newview/llparticipantlist.cpp d8c37b383028 Diff: http://codereview.secondlife.com/r/404/diff Testing ------- Thanks, Paul -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110720/ef0b2e16/attachment.htm From sllists at boroon.dasgupta.ch Wed Jul 20 11:31:24 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Wed, 20 Jul 2011 18:31:24 -0000 Subject: [opensource-dev] Review Request: STORM-1458 ([crashhunters] crash at LLParticipantList::LLParticipantListMenu::isGroupModerator() [secondlife-bin llparticipantlist.cpp]) In-Reply-To: <20110720181619.2254.3279@domU-12-31-38-00-90-68.compute-1.internal> References: <20110720181619.2254.3279@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110720183124.5193.51566@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/404/#review896 ----------------------------------------------------------- indra/newview/llparticipantlist.cpp Either this comment should be moved inside the if-block or it should be formulated as a question: // Is agent in group call? Otherwise it might give the wrong impression that it is already known that the agent is in a group call at the point where the comment appears. Also, is this really about group calls (i.e. voice) or rather/also group chat (i.e. text). indra/newview/llparticipantlist.cpp I think if the speaker manager is missing (pointer is null), at least a warning in the log would be warranted. I'm not sure whether the same applies for missing (i.e. null) speaker. (Could the agent have left the group call/chat meanwhile thus not be in the speaker list anymore?) indra/newview/llparticipantlist.cpp This comment should read // Is agent a moderator? or similar. - Boroondas On July 20, 2011, 11:16 a.m., Paul ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/404/ > ----------------------------------------------------------- > > (Updated July 20, 2011, 11:16 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > - Added null checking > > > This addresses bug storm-1458. > http://jira.secondlife.com/browse/storm-1458 > > > Diffs > ----- > > indra/newview/llparticipantlist.cpp d8c37b383028 > > Diff: http://codereview.secondlife.com/r/404/diff > > > Testing > ------- > > > Thanks, > > Paul > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110720/92369682/attachment.htm From LockwoodN at mst.edu Wed Jul 20 11:36:44 2011 From: LockwoodN at mst.edu (Lockwood, Nicholas S.) Date: Wed, 20 Jul 2011 13:36:44 -0500 Subject: [opensource-dev] Return drawable/object at mouse point Message-ID: <6212FB22FD17584D90840DD8370D7B37487367@mst-vmail01.srv.mst.edu> I'm writing some code for a research project to log the object at a particular point on the screen (using mouse coordinates). So far I've made use of the LLViewerWindow::cursorIntersect function which seems to work pretty well. However, I can't seem to capture certain things like avatars, the sky, clouds, water, etc. Is there a way that I can capture everything being rendered in the scene? I was hoping it is possible to capture a particular drawable being displayed at a given point. Then, I should be able to get the object associated with that drawable as well as the render type. I just haven't figured out an easy way to do that yet. Are there any functions I'm missing, or does anyone have a suggestion as to how I can capture these data? Thanks! Nick -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110720/7b187d15/attachment-0001.htm From sllists at boroon.dasgupta.ch Thu Jul 21 02:38:06 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Thu, 21 Jul 2011 09:38:06 -0000 Subject: [opensource-dev] Review Request: STORM-1521 [previously VWR-25588]: Zi's proposed fix for FIRE-543 - Hovertext renders as overlay on top of everything else Message-ID: <20110721093806.2250.50732@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/405/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Set the z coordinate of hovertext such that it gets occluded by stuff in front of it. This addresses bugs SH-489, VWR-24017 and VWR-25588. http://jira.secondlife.com/browse/SH-489 http://jira.secondlife.com/browse/VWR-24017 http://jira.secondlife.com/browse/VWR-25588 Diffs ----- doc/contributions.txt 46c7b36793c9 indra/llrender/llfontgl.cpp 46c7b36793c9 Diff: http://codereview.secondlife.com/r/405/diff Testing ------- Merged this change with e67da2c6e312 (as I still cannot build viewer-development tip) and rebuilt. Verified that my nametag and an objects llSetText hovertext were correctly occluded by another object in front of them. Thanks, Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110721/27d6d615/attachment.htm From sllists at boroon.dasgupta.ch Thu Jul 21 02:44:19 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Thu, 21 Jul 2011 09:44:19 -0000 Subject: [opensource-dev] Review Request: STORM-1521 [previously VWR-25588]: Zi's proposed fix for FIRE-543 - Hovertext renders as overlay on top of everything else In-Reply-To: <20110721093806.2250.50732@domU-12-31-38-00-90-68.compute-1.internal> References: <20110721093806.2250.50732@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110721094419.9685.34009@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/405/ ----------------------------------------------------------- (Updated July 21, 2011, 2:44 a.m.) Review request for Viewer. Summary (updated) ------- Set the z (depth) coordinate of hovertext such that the hovertext gets occluded by stuff in front of it. This addresses bugs SH-489, VWR-24017 and VWR-25588. http://jira.secondlife.com/browse/SH-489 http://jira.secondlife.com/browse/VWR-24017 http://jira.secondlife.com/browse/VWR-25588 Diffs ----- doc/contributions.txt 46c7b36793c9 indra/llrender/llfontgl.cpp 46c7b36793c9 Diff: http://codereview.secondlife.com/r/405/diff Testing ------- Merged this change with e67da2c6e312 (as I still cannot build viewer-development tip) and rebuilt. Verified that my nametag and an objects llSetText hovertext were correctly occluded by another object in front of them. Thanks, Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110721/61e57a65/attachment.htm From sllists at boroon.dasgupta.ch Thu Jul 21 02:55:57 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Thu, 21 Jul 2011 09:55:57 -0000 Subject: [opensource-dev] Review Request: STORM-1521 [previously VWR-25588]: Zi's proposed fix for FIRE-543 - Hovertext renders as overlay on top of everything else In-Reply-To: <20110721094419.9685.34009@domU-12-31-38-00-90-68.compute-1.internal> References: <20110721094419.9685.34009@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110721095557.9726.52977@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/405/ ----------------------------------------------------------- (Updated July 21, 2011, 2:55 a.m.) Review request for Viewer. Changes ------- Made in-code comment a bit clearer. Summary ------- Set the z (depth) coordinate of hovertext such that the hovertext gets occluded by stuff in front of it. This addresses bugs SH-489, VWR-24017 and VWR-25588. http://jira.secondlife.com/browse/SH-489 http://jira.secondlife.com/browse/VWR-24017 http://jira.secondlife.com/browse/VWR-25588 Diffs (updated) ----- doc/contributions.txt 46c7b36793c9 indra/llrender/llfontgl.cpp 46c7b36793c9 Diff: http://codereview.secondlife.com/r/405/diff Testing ------- Merged this change with e67da2c6e312 (as I still cannot build viewer-development tip) and rebuilt. Verified that my nametag and an objects llSetText hovertext were correctly occluded by another object in front of them. Thanks, Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110721/bd16fe43/attachment.htm From pguslisty at productengine.com Thu Jul 21 03:27:45 2011 From: pguslisty at productengine.com (Paul ProductEngine) Date: Thu, 21 Jul 2011 10:27:45 -0000 Subject: [opensource-dev] Review Request: STORM-1458 ([crashhunters] crash at LLParticipantList::LLParticipantListMenu::isGroupModerator() [secondlife-bin llparticipantlist.cpp]) In-Reply-To: <20110720181619.2254.3279@domU-12-31-38-00-90-68.compute-1.internal> References: <20110720181619.2254.3279@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110721102745.2254.30339@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/404/ ----------------------------------------------------------- (Updated July 21, 2011, 3:27 a.m.) Review request for Viewer. Changes ------- Updated diff according to Boroondas' commentaries Summary ------- - Added null checking This addresses bug storm-1458. http://jira.secondlife.com/browse/storm-1458 Diffs (updated) ----- indra/newview/llparticipantlist.cpp d8c37b383028 Diff: http://codereview.secondlife.com/r/404/diff Testing ------- Thanks, Paul -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110721/4f17059c/attachment.htm From sllists at boroon.dasgupta.ch Thu Jul 21 04:21:00 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Thu, 21 Jul 2011 11:21:00 -0000 Subject: [opensource-dev] Review Request: STORM-1458 ([crashhunters] crash at LLParticipantList::LLParticipantListMenu::isGroupModerator() [secondlife-bin llparticipantlist.cpp]) In-Reply-To: <20110721102745.2254.30339@domU-12-31-38-00-90-68.compute-1.internal> References: <20110721102745.2254.30339@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110721112100.4919.20939@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/404/#review898 ----------------------------------------------------------- indra/newview/llparticipantlist.cpp Hmm ... looking at the comment at https://bitbucket.org/lindenlab/viewer-development/src/d8c37b383028/indra/newview/llagent.h#cl-705 and the implementation of isInGroup at https://bitbucket.org/lindenlab/viewer-development/src/d8c37b383028/indra/newview/llagent.cpp#cl-2414 , this test actually checks whether the agent in question is a member of the group which has an UUID matching the conversation's session ID. Because the session IDs of group chats will match the UUID of the respective groups (and all other chat session types should have session IDs not matching any group UUIDs), this also tells us whether the session is a group chat. So maybe the comment should be yet different to reflect this. (Sorry, should have looked up this stuff for the first review already.) Maybe: // Is session a group chat? (It is if the session ID is the UUID of a group of which the agent is a member.) I wonder whether there is a better way (as in: making less assumptions / not using an agent as pivot) to test for this. - Boroondas On July 21, 2011, 3:27 a.m., Paul ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/404/ > ----------------------------------------------------------- > > (Updated July 21, 2011, 3:27 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > - Added null checking > > > This addresses bug storm-1458. > http://jira.secondlife.com/browse/storm-1458 > > > Diffs > ----- > > indra/newview/llparticipantlist.cpp d8c37b383028 > > Diff: http://codereview.secondlife.com/r/404/diff > > > Testing > ------- > > > Thanks, > > Paul > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110721/25559905/attachment-0001.htm From pguslisty at productengine.com Thu Jul 21 05:27:40 2011 From: pguslisty at productengine.com (Paul ProductEngine) Date: Thu, 21 Jul 2011 12:27:40 -0000 Subject: [opensource-dev] Review Request: STORM-1458 ([crashhunters] crash at LLParticipantList::LLParticipantListMenu::isGroupModerator() [secondlife-bin llparticipantlist.cpp]) In-Reply-To: <20110721112100.4919.20939@domU-12-31-38-00-90-68.compute-1.internal> References: <20110721112100.4919.20939@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110721122740.4919.57648@domU-12-31-38-00-90-68.compute-1.internal> > On July 21, 2011, 4:21 a.m., Boroondas Gupte wrote: > > indra/newview/llparticipantlist.cpp, lines 807-808 > > > > > > Hmm ... looking at the comment at https://bitbucket.org/lindenlab/viewer-development/src/d8c37b383028/indra/newview/llagent.h#cl-705 and the implementation of isInGroup at https://bitbucket.org/lindenlab/viewer-development/src/d8c37b383028/indra/newview/llagent.cpp#cl-2414 , this test actually checks whether the agent in question is a member of the group which has an UUID matching the conversation's session ID. > > > > Because the session IDs of group chats will match the UUID of the respective groups (and all other chat session types should have session IDs not matching any group UUIDs), this also tells us whether the session is a group chat. > > > > So maybe the comment should be yet different to reflect this. (Sorry, should have looked up this stuff for the first review already.) Maybe: > > // Is session a group chat? (It is if the session ID is the UUID of a group of which the agent is a member.) > > > > I wonder whether there is a better way (as in: making less assumptions / not using an agent as pivot) to test for this. I think the comment may be: "Is agent in group call/chat ?" - Paul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/404/#review898 ----------------------------------------------------------- On July 21, 2011, 3:27 a.m., Paul ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/404/ > ----------------------------------------------------------- > > (Updated July 21, 2011, 3:27 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > - Added null checking > > > This addresses bug storm-1458. > http://jira.secondlife.com/browse/storm-1458 > > > Diffs > ----- > > indra/newview/llparticipantlist.cpp d8c37b383028 > > Diff: http://codereview.secondlife.com/r/404/diff > > > Testing > ------- > > > Thanks, > > Paul > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110721/a61352ee/attachment.htm From pguslisty at productengine.com Thu Jul 21 07:01:54 2011 From: pguslisty at productengine.com (Paul ProductEngine) Date: Thu, 21 Jul 2011 14:01:54 -0000 Subject: [opensource-dev] Review Request: STORM-1458 ([crashhunters] crash at LLParticipantList::LLParticipantListMenu::isGroupModerator() [secondlife-bin llparticipantlist.cpp]) In-Reply-To: <20110721102745.2254.30339@domU-12-31-38-00-90-68.compute-1.internal> References: <20110721102745.2254.30339@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110721140154.2257.39940@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/404/ ----------------------------------------------------------- (Updated July 21, 2011, 7:01 a.m.) Review request for Viewer. Summary ------- - Added null checking This addresses bug storm-1458. http://jira.secondlife.com/browse/storm-1458 Diffs (updated) ----- indra/newview/llparticipantlist.cpp d8c37b383028 Diff: http://codereview.secondlife.com/r/404/diff Testing ------- Thanks, Paul -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110721/c09c9529/attachment.htm From sllists at boroon.dasgupta.ch Thu Jul 21 07:03:21 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Thu, 21 Jul 2011 14:03:21 -0000 Subject: [opensource-dev] Review Request: STORM-1458 ([crashhunters] crash at LLParticipantList::LLParticipantListMenu::isGroupModerator() [secondlife-bin llparticipantlist.cpp]) In-Reply-To: <20110721140154.2257.39940@domU-12-31-38-00-90-68.compute-1.internal> References: <20110721140154.2257.39940@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110721140321.2255.31113@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/404/#review901 ----------------------------------------------------------- Ship it! - Boroondas On July 21, 2011, 7:01 a.m., Paul ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/404/ > ----------------------------------------------------------- > > (Updated July 21, 2011, 7:01 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > - Added null checking > > > This addresses bug storm-1458. > http://jira.secondlife.com/browse/storm-1458 > > > Diffs > ----- > > indra/newview/llparticipantlist.cpp d8c37b383028 > > Diff: http://codereview.secondlife.com/r/404/diff > > > Testing > ------- > > > Thanks, > > Paul > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110721/e957ea63/attachment.htm From sllists at boroon.dasgupta.ch Thu Jul 21 06:15:02 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Thu, 21 Jul 2011 13:15:02 -0000 Subject: [opensource-dev] Review Request: STORM-1458 ([crashhunters] crash at LLParticipantList::LLParticipantListMenu::isGroupModerator() [secondlife-bin llparticipantlist.cpp]) In-Reply-To: <20110721112100.4919.20939@domU-12-31-38-00-90-68.compute-1.internal> References: <20110721112100.4919.20939@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110721131502.2252.11845@domU-12-31-38-00-90-68.compute-1.internal> > On July 21, 2011, 4:21 a.m., Boroondas Gupte wrote: > > indra/newview/llparticipantlist.cpp, lines 807-808 > > > > > > Hmm ... looking at the comment at https://bitbucket.org/lindenlab/viewer-development/src/d8c37b383028/indra/newview/llagent.h#cl-705 and the implementation of isInGroup at https://bitbucket.org/lindenlab/viewer-development/src/d8c37b383028/indra/newview/llagent.cpp#cl-2414 , this test actually checks whether the agent in question is a member of the group which has an UUID matching the conversation's session ID. > > > > Because the session IDs of group chats will match the UUID of the respective groups (and all other chat session types should have session IDs not matching any group UUIDs), this also tells us whether the session is a group chat. > > > > So maybe the comment should be yet different to reflect this. (Sorry, should have looked up this stuff for the first review already.) Maybe: > > // Is session a group chat? (It is if the session ID is the UUID of a group of which the agent is a member.) > > > > I wonder whether there is a better way (as in: making less assumptions / not using an agent as pivot) to test for this. > > Paul ProductEngine wrote: > I think the comment may be: "Is agent in group call/chat ?" We don't really care here whether the *agent* is in a group call/chat, but whether the *session* here is that of a *group* call/chat (as opposed to resident-to-resident chat and ad-hoc chat sessions). We just (ab)use the agent to get a list of candidate groups one of which might have the session ID as UUID. At least, that's what the code here seems to do. If the intention is something else, we might have a bug here. Though it would make sense that this be in fact the intention, as the notion of "moderators" does not exist in ad-hoc and resi2resi chat sessions. > I wonder whether there is a better way (as in: making less assumptions / not using an agent as pivot) to test for this. It looks like there isn't a better way, currently: LLIMModel::LLIMSession keeps track of the session type and offers this information through e.g. bool isGroupSessionType(), but LLParticipantList::LLParticipantListMenu seems neither directly nor indirectly (e.g. via mParent.mSpeakerMgr) aware of the LLIMSession it belongs to, so can't query that. Off course, some refactoring could solve that, but that's not in-scope for this crash fix. - Boroondas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/404/#review898 ----------------------------------------------------------- On July 21, 2011, 3:27 a.m., Paul ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/404/ > ----------------------------------------------------------- > > (Updated July 21, 2011, 3:27 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > - Added null checking > > > This addresses bug storm-1458. > http://jira.secondlife.com/browse/storm-1458 > > > Diffs > ----- > > indra/newview/llparticipantlist.cpp d8c37b383028 > > Diff: http://codereview.secondlife.com/r/404/diff > > > Testing > ------- > > > Thanks, > > Paul > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110721/5cd2a774/attachment-0001.htm From sllists at boroon.dasgupta.ch Thu Jul 21 08:43:51 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Thu, 21 Jul 2011 15:43:51 -0000 Subject: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer) In-Reply-To: <20110525202505.20619.33404@domU-12-31-38-00-90-68.compute-1.internal> References: <20110525202505.20619.33404@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110721154351.2253.70492@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/313/ ----------------------------------------------------------- (Updated July 21, 2011, 8:43 a.m.) Review request for Viewer. Changes ------- Omit directory separator conversion, which is unnecessary for "paths" that are only filenames. Summary ------- Context: We are currently using Boost 1.45, which already comes with the new Boost Filesystem Library API (Version 3) but still defaults to the old one (Version 2). From Boost 1.46 on, V3 will be the default and Boost 1.47 will be the last one to come with V2. The Boost Filesystem Library documentation recommends "Existing code should be moved to Version 3 as soon as convenient. New code should be written for Version 3. Version 2 is deprecated, and will not be included in Boost releases 1.48 and later." This change overrides the default, so that the V3 API is used, and makes the necessary code changes. (So we can stick to Boost 1.45 and upgrade whenever we feel like it.) Note: I only changed stuff that the compiler complained about. If the new API also changes semantic of still-compiling library usage, more changes might be necessary. This addresses bug OPEN-67. http://jira.secondlife.com/browse/OPEN-67 Diffs (updated) ----- doc/contributions.txt 959f9340da92 indra/llvfs/lldiriterator.cpp 959f9340da92 Diff: http://codereview.secondlife.com/r/313/diff Testing ------- * Compiled Viewer (standalone) with Boost 1.45 * Started Viewer * Logged in * Compiled Viewer (standalone) with Boost 1.46 * Started Viewer * Logged in Not tested: * non-standalone Thanks, Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110721/ff18b52a/attachment.htm From oz at lindenlab.com Thu Jul 21 13:25:07 2011 From: oz at lindenlab.com (Oz Linden) Date: Thu, 21 Jul 2011 20:25:07 -0000 Subject: [opensource-dev] Review Request: STORM-1487 Gestures -> Get more leads to wrong URL In-Reply-To: <20110719182014.2257.79443@domU-12-31-38-00-90-68.compute-1.internal> References: <20110719182014.2257.79443@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110721202507.9685.59615@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/401/#review902 ----------------------------------------------------------- Ship it! - Oz On July 19, 2011, 11:20 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/401/ > ----------------------------------------------------------- > > (Updated July 19, 2011, 11:20 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Changed the URL. > > > This addresses bug STORM-1487. > http://jira.secondlife.com/browse/STORM-1487 > > > Diffs > ----- > > indra/newview/app_settings/settings.xml UNKNOWN > > Diff: http://codereview.secondlife.com/r/401/diff > > > Testing > ------- > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110721/616be5c7/attachment.htm From nickyperian at yahoo.com Thu Jul 21 13:29:54 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Thu, 21 Jul 2011 20:29:54 -0000 Subject: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer) In-Reply-To: <20110721154351.2253.70492@domU-12-31-38-00-90-68.compute-1.internal> References: <20110721154351.2253.70492@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110721202954.9805.86052@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/313/#review903 ----------------------------------------------------------- applied open-67_d.diff @r15984; windows fails link with unresolved externals as follows: "windows-crash-logger.dir\RelWithDebInfo\/win_crash_logger.obj" /machine:X86 /debug llvfs.lib(lldiriterator.obj) : error LNK2019: unresolved external symbol "private: static class std::codecvt const * & __cdecl boost::filesystem3::path::wchar_t_codecvt_facet(void)" (?wchar_t_codecvt_facet at path@filesystem3 at boost@@CAAAPBV?$codecvt at GDH@std@@XZ) referenced in function "public: __thiscall LLDirIterator::Impl::Impl(class std::basic_string,class std::allocator > const &,class std::basic_string,class std::allocator > const &)" (??0Impl at LLDirIterator@@QAE at ABV?$basic_string at DU?$char_traits at D@std@@V?$allocator at D@2@@std@@0 at Z) [c:\Users\Bill\lindenhg\viewer-development-mesh\build-vc100\win_crash_logger\windows-crash-logger.vcxproj] llvfs.lib(lldiriterator.obj) : error LNK2019: unresolved external symbol "void __cdecl boost::filesystem3::path_traits::convert(unsigned short const *,unsigned short const *,class std::basic_string,class std::allocator > &,class std::codecvt const &)" (?convert at path_traits@filesystem3 at boost@@YAXPBG0AAV?$basic_string at DU?$char_traits at D@std@@V?$allocator at D@2@@std@@ABV?$codecvt at GDH@5@@Z) referenced in function "public: class std::basic_string,class std::allocator > const __thiscall boost::filesystem3::path::string(class std::codecvt const &)const " (?string at path@filesystem3 at boost@@QBE?BV?$basic_string at DU?$char_traits at D@std@@V?$allocator at D@2@@std@@ABV?$codecvt at GDH@5@@Z) [c:\Users\Bill\lindenhg\viewer-development-mesh\build-vc100\win_crash_logger\windows-crash-logger.vcxproj] llvfs.lib(lldiriterator.obj) : error LNK2019: unresolved external symbol "public: class std::basic_string,class std::allocator > const __thiscall boost::filesystem3::path::generic_string(class std::codecvt const &)const " (?generic_string at path@filesystem3 at boost@@QBE?BV?$basic_string at DU?$char_traits at D@std@@V?$allocator at D@2@@std@@ABV?$codecvt at GDH@5@@Z) referenced in function "public: class std::basic_string,class std::allocator > const __thiscall boost::filesystem3::path::generic_string(void)const " (?generic_string at path@filesystem3 at boost@@QBE?BV?$basic_string at DU?$char_traits at D@std@@V?$allocator at D@2@@std@@XZ) [c:\Users\Bill\lindenhg\viewer-development-mesh\build-vc100\win_crash_logger\windows-crash-logger.vcxproj] llvfs.lib(lldiriterator.obj) : error LNK2019: unresolved external symbol "void __cdecl boost::filesystem3::path_traits::convert(char const *,char const *,class std::basic_string,class std::allocator > &,class std::codecvt const &)" (?convert at path_traits@filesystem3 at boost@@YAXPBD0AAV?$basic_string at GU?$char_traits at G@std@@V?$allocator at G@2@@std@@ABV?$codecvt at GDH@5@@Z) referenced in function "void __cdecl boost::filesystem3::path_traits::dispatch,class std::allocator > >(class std::basic_string,class std::allocator > const &,class std::basic_string,class std::allocator > &,class std::codecvt const &)" (??$dispatch at V?$basic_string at GU?$char_traits at G@std@@V?$allocator at G@2@@std@@@path_traits at filesystem3@boost@@YAXABV?$basic_string at DU?$char_traits at D@std@@V?$allocator at D@2@@std@@AAV?$basic_string at GU?$char_traits at G@std@@V?$allocator at G@2@@4 at ABV?$codecvt at GDH@4@@Z) [c:\Users\Bill\lindenhg\viewer-development-mesh\build-vc100\win_crash_logger\windows-crash-logger.vcxproj] - Nicky On July 21, 2011, 8:43 a.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/313/ > ----------------------------------------------------------- > > (Updated July 21, 2011, 8:43 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Context: We are currently using Boost 1.45, which already comes with the new Boost Filesystem Library API (Version 3) but still defaults to the old one (Version 2). From Boost 1.46 on, V3 will be the default and Boost 1.47 will be the last one to come with V2. The Boost Filesystem Library documentation recommends "Existing code should be moved to Version 3 as soon as convenient. New code should be written for Version 3. Version 2 is deprecated, and will not be included in Boost releases 1.48 and later." > > This change overrides the default, so that the V3 API is used, and makes the necessary code changes. (So we can stick to Boost 1.45 and upgrade whenever we feel like it.) > > Note: I only changed stuff that the compiler complained about. If the new API also changes semantic of still-compiling library usage, more changes might be necessary. > > > This addresses bug OPEN-67. > http://jira.secondlife.com/browse/OPEN-67 > > > Diffs > ----- > > doc/contributions.txt 959f9340da92 > indra/llvfs/lldiriterator.cpp 959f9340da92 > > Diff: http://codereview.secondlife.com/r/313/diff > > > Testing > ------- > > * Compiled Viewer (standalone) with Boost 1.45 > * Started Viewer > * Logged in > > * Compiled Viewer (standalone) with Boost 1.46 > * Started Viewer > * Logged in > > Not tested: > * non-standalone > > > Thanks, > > Boroondas > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110721/c3c66292/attachment.htm From sllists at boroon.dasgupta.ch Thu Jul 21 13:37:50 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Thu, 21 Jul 2011 20:37:50 -0000 Subject: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer) In-Reply-To: <20110721202954.9805.86052@domU-12-31-38-00-90-68.compute-1.internal> References: <20110721202954.9805.86052@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110721203750.9615.46699@domU-12-31-38-00-90-68.compute-1.internal> > On July 21, 2011, 1:29 p.m., Nicky Perian wrote: > > applied open-67_d.diff @r15984; windows fails link with unresolved externals as follows: > > "windows-crash-logger.dir\RelWithDebInfo\/win_crash_logger.obj" /machine:X86 /debug > > llvfs.lib(lldiriterator.obj) : error LNK2019: unresolved external symbol "private: static class std::codecvt const * & __cdecl boost::filesystem3::path::wchar_t_codecvt_facet(void)" (?wchar_t_codecvt_facet at path@filesystem3 at boost@@CAAAPBV?$codecvt at GDH@std@@XZ) referenced in function "public: __thiscall LLDirIterator::Impl::Impl(class std::basic_string,class std::allocator > const &,class std::basic_string,class std::allocator > const &)" (??0Impl at LLDirIterator@@QAE at ABV?$basic_string at DU?$char_traits at D@std@@V?$allocator at D@2@@std@@0 at Z) [c:\Users\Bill\lindenhg\viewer-development-mesh\build-vc100\win_crash_logger\windows-crash-logger.vcxproj] > > llvfs.lib(lldiriterator.obj) : error LNK2019: unresolved external symbol "void __cdecl boost::filesystem3::path_traits::convert(unsigned short const *,unsigned short const *,class std::basic_string,class std::allocator > &,class std::codecvt const &)" (?convert at path_traits@filesystem3 at boost@@YAXPBG0AAV?$basic_string at DU?$char_traits at D@std@@V?$allocator at D@2@@std@@ABV?$codecvt at GDH@5@@Z) referenced in function "public: class std::basic_string,class std::allocator > const __thiscall boost::filesystem3::path::string(class std::codecvt const &)const " (?string at path@filesystem3 at boost@@QBE?BV?$basic_string at DU?$char_traits at D@std@@V?$allocator at D@2@@std@@ABV?$codecvt at GDH@5@@Z) [c:\Users\Bill\lindenhg\viewer-development-mesh\build-vc100\win_crash_logger\windows-crash-logger.vcxproj] > > llvfs.lib(lldiriterator.obj) : error LNK2019: unresolved external symbol "public: class std::basic_string,class std::allocator > const __thiscall boost::filesystem3::path::generic_string(class std::codecvt const &)const " (?generic_string at path@filesystem3 at boost@@QBE?BV?$basic_string at DU?$char_traits at D@std@@V?$allocator at D@2@@std@@ABV?$codecvt at GDH@5@@Z) referenced in function "public: class std::basic_string,class std::allocator > const __thiscall boost::filesystem3::path::generic_string(void)const " (?generic_string at path@filesystem3 at boost@@QBE?BV?$basic_string at DU?$char_traits at D@std@@V?$allocator at D@2@@std@@XZ) [c:\Users\Bill\lindenhg\viewer-development-mesh\build-vc100\win_crash_logger\windows-crash-logger.vcxproj] > > llvfs.lib(lldiriterator.obj) : error LNK2019: unresolved external symbol "void __cdecl boost::filesystem3::path_traits::convert(char const *,char const *,class std::basic_string,class std::allocator > &,class std::codecvt const &)" (?convert at path_traits@filesystem3 at boost@@YAXPBD0AAV?$basic_string at GU?$char_traits at G@std@@V?$allocator at G@2@@std@@ABV?$codecvt at GDH@5@@Z) referenced in function "void __cdecl boost::filesystem3::path_traits::dispatch,class std::allocator > >(class std::basic_string,class std::allocator > const &,class std::basic_string,class std::allocator > &,class std::codecvt const &)" (??$dispatch at V?$basic_string at GU?$char_traits at G@std@@V?$allocator at G@2@@std@@@path_traits at filesystem3@boost@@YAXABV?$basic_string at DU?$char_traits at D@std@@V?$allocator at D@2@@std@@AAV?$basic_string at GU?$char_traits at G@std@@V?$allocator at G@2@@4 at ABV?$codecvt at GDH@4@@Z) [c:\Users\Bill\lindenhg\viewer-development-mesh\build-vc100\win_crash_logger\windows-crash-logger.vcxproj] Did the patch apply cleanly? To maintain readability, I didn't include the merge with tip, so you might want to pull https://bitbucket.org/boroondas/viewer-development-open-67 instead of manually applying patches. - Boroondas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/313/#review903 ----------------------------------------------------------- On July 21, 2011, 8:43 a.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/313/ > ----------------------------------------------------------- > > (Updated July 21, 2011, 8:43 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Context: We are currently using Boost 1.45, which already comes with the new Boost Filesystem Library API (Version 3) but still defaults to the old one (Version 2). From Boost 1.46 on, V3 will be the default and Boost 1.47 will be the last one to come with V2. The Boost Filesystem Library documentation recommends "Existing code should be moved to Version 3 as soon as convenient. New code should be written for Version 3. Version 2 is deprecated, and will not be included in Boost releases 1.48 and later." > > This change overrides the default, so that the V3 API is used, and makes the necessary code changes. (So we can stick to Boost 1.45 and upgrade whenever we feel like it.) > > Note: I only changed stuff that the compiler complained about. If the new API also changes semantic of still-compiling library usage, more changes might be necessary. > > > This addresses bug OPEN-67. > http://jira.secondlife.com/browse/OPEN-67 > > > Diffs > ----- > > doc/contributions.txt 959f9340da92 > indra/llvfs/lldiriterator.cpp 959f9340da92 > > Diff: http://codereview.secondlife.com/r/313/diff > > > Testing > ------- > > * Compiled Viewer (standalone) with Boost 1.45 > * Started Viewer > * Logged in > > * Compiled Viewer (standalone) with Boost 1.46 > * Started Viewer > * Logged in > > Not tested: > * non-standalone > > > Thanks, > > Boroondas > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110721/8e162c2c/attachment-0001.htm From sllists at boroon.dasgupta.ch Thu Jul 21 15:42:50 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Thu, 21 Jul 2011 22:42:50 -0000 Subject: [opensource-dev] Review Request: VWR-26458: fixing a simple typo in German translation Message-ID: <20110721224250.2250.76877@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/408/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Found this coincidentally when looking through recent changesets. Thought I'd fix it right away. This addresses bug VWR-26458. http://jira.secondlife.com/browse/VWR-26458 Diffs ----- doc/contributions.txt 06874d04d57e indra/newview/skins/default/xui/de/floater_delete_env_preset.xml 06874d04d57e Diff: http://codereview.secondlife.com/r/408/diff Testing ------- none Thanks, Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110721/9680b5a2/attachment.htm From sllists at boroon.dasgupta.ch Thu Jul 21 15:58:00 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Thu, 21 Jul 2011 22:58:00 -0000 Subject: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer) In-Reply-To: <20110721202954.9805.86052@domU-12-31-38-00-90-68.compute-1.internal> References: <20110721202954.9805.86052@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110721225800.4919.82637@domU-12-31-38-00-90-68.compute-1.internal> > On July 21, 2011, 1:29 p.m., Nicky Perian wrote: > > applied open-67_d.diff @r15984; windows fails link with unresolved externals as follows: > > "windows-crash-logger.dir\RelWithDebInfo\/win_crash_logger.obj" /machine:X86 /debug > > llvfs.lib(lldiriterator.obj) : error LNK2019: unresolved external symbol "private: static class std::codecvt const * & __cdecl boost::filesystem3::path::wchar_t_codecvt_facet(void)" (?wchar_t_codecvt_facet at path@filesystem3 at boost@@CAAAPBV?$codecvt at GDH@std@@XZ) referenced in function "public: __thiscall LLDirIterator::Impl::Impl(class std::basic_string,class std::allocator > const &,class std::basic_string,class std::allocator > const &)" (??0Impl at LLDirIterator@@QAE at ABV?$basic_string at DU?$char_traits at D@std@@V?$allocator at D@2@@std@@0 at Z) [c:\Users\Bill\lindenhg\viewer-development-mesh\build-vc100\win_crash_logger\windows-crash-logger.vcxproj] > > llvfs.lib(lldiriterator.obj) : error LNK2019: unresolved external symbol "void __cdecl boost::filesystem3::path_traits::convert(unsigned short const *,unsigned short const *,class std::basic_string,class std::allocator > &,class std::codecvt const &)" (?convert at path_traits@filesystem3 at boost@@YAXPBG0AAV?$basic_string at DU?$char_traits at D@std@@V?$allocator at D@2@@std@@ABV?$codecvt at GDH@5@@Z) referenced in function "public: class std::basic_string,class std::allocator > const __thiscall boost::filesystem3::path::string(class std::codecvt const &)const " (?string at path@filesystem3 at boost@@QBE?BV?$basic_string at DU?$char_traits at D@std@@V?$allocator at D@2@@std@@ABV?$codecvt at GDH@5@@Z) [c:\Users\Bill\lindenhg\viewer-development-mesh\build-vc100\win_crash_logger\windows-crash-logger.vcxproj] > > llvfs.lib(lldiriterator.obj) : error LNK2019: unresolved external symbol "public: class std::basic_string,class std::allocator > const __thiscall boost::filesystem3::path::generic_string(class std::codecvt const &)const " (?generic_string at path@filesystem3 at boost@@QBE?BV?$basic_string at DU?$char_traits at D@std@@V?$allocator at D@2@@std@@ABV?$codecvt at GDH@5@@Z) referenced in function "public: class std::basic_string,class std::allocator > const __thiscall boost::filesystem3::path::generic_string(void)const " (?generic_string at path@filesystem3 at boost@@QBE?BV?$basic_string at DU?$char_traits at D@std@@V?$allocator at D@2@@std@@XZ) [c:\Users\Bill\lindenhg\viewer-development-mesh\build-vc100\win_crash_logger\windows-crash-logger.vcxproj] > > llvfs.lib(lldiriterator.obj) : error LNK2019: unresolved external symbol "void __cdecl boost::filesystem3::path_traits::convert(char const *,char const *,class std::basic_string,class std::allocator > &,class std::codecvt const &)" (?convert at path_traits@filesystem3 at boost@@YAXPBD0AAV?$basic_string at GU?$char_traits at G@std@@V?$allocator at G@2@@std@@ABV?$codecvt at GDH@5@@Z) referenced in function "void __cdecl boost::filesystem3::path_traits::dispatch,class std::allocator > >(class std::basic_string,class std::allocator > const &,class std::basic_string,class std::allocator > &,class std::codecvt const &)" (??$dispatch at V?$basic_string at GU?$char_traits at G@std@@V?$allocator at G@2@@std@@@path_traits at filesystem3@boost@@YAXABV?$basic_string at DU?$char_traits at D@std@@V?$allocator at D@2@@std@@AAV?$basic_string at GU?$char_traits at G@std@@V?$allocator at G@2@@4 at ABV?$codecvt at GDH@4@@Z) [c:\Users\Bill\lindenhg\viewer-development-mesh\build-vc100\win_crash_logger\windows-crash-logger.vcxproj] > > Boroondas Gupte wrote: > Did the patch apply cleanly? To maintain readability, I didn't include the merge with tip, so you might want to pull https://bitbucket.org/boroondas/viewer-development-open-67 instead of manually applying patches. Just saw that you mentioned a revision: 15984 Though, this is a revision number, thus valid for the local repository only. What is the corresponding revision ID? - Boroondas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/313/#review903 ----------------------------------------------------------- On July 21, 2011, 8:43 a.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/313/ > ----------------------------------------------------------- > > (Updated July 21, 2011, 8:43 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Context: We are currently using Boost 1.45, which already comes with the new Boost Filesystem Library API (Version 3) but still defaults to the old one (Version 2). From Boost 1.46 on, V3 will be the default and Boost 1.47 will be the last one to come with V2. The Boost Filesystem Library documentation recommends "Existing code should be moved to Version 3 as soon as convenient. New code should be written for Version 3. Version 2 is deprecated, and will not be included in Boost releases 1.48 and later." > > This change overrides the default, so that the V3 API is used, and makes the necessary code changes. (So we can stick to Boost 1.45 and upgrade whenever we feel like it.) > > Note: I only changed stuff that the compiler complained about. If the new API also changes semantic of still-compiling library usage, more changes might be necessary. > > > This addresses bug OPEN-67. > http://jira.secondlife.com/browse/OPEN-67 > > > Diffs > ----- > > doc/contributions.txt 959f9340da92 > indra/llvfs/lldiriterator.cpp 959f9340da92 > > Diff: http://codereview.secondlife.com/r/313/diff > > > Testing > ------- > > * Compiled Viewer (standalone) with Boost 1.45 > * Started Viewer > * Logged in > > * Compiled Viewer (standalone) with Boost 1.46 > * Started Viewer > * Logged in > > Not tested: > * non-standalone > > > Thanks, > > Boroondas > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110721/2065af32/attachment.htm From kadah.coba at gmail.com Thu Jul 21 17:34:25 2011 From: kadah.coba at gmail.com (Kadah Coba) Date: Fri, 22 Jul 2011 00:34:25 -0000 Subject: [opensource-dev] Review Request: STORM-1453: Prevent unintended 10L sale In-Reply-To: <20110712184256.7042.14648@domU-12-31-38-00-90-68.compute-1.internal> References: <20110712184256.7042.14648@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110722003425.2254.8860@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/365/ ----------------------------------------------------------- (Updated July 21, 2011, 5:34 p.m.) Review request for Viewer. Summary (updated) ------- This change makes it so setting an object for sale or modifying the price or sale type requires explicitly applying the changes. Default behavior before this patch is all sale info is committed to sim on change. After this patch the sale info will only get set or modified after hitting a "mark for sale" button. There is no change to removing an object from sale, unchecking "For sale" will be committed to sim without further user interation. https://bitbucket.org/Kadah_Coba/storm-1453 This addresses bug STORM-1453. http://jira.secondlife.com/browse/STORM-1453 Diffs (updated) ----- indra/newview/llpanelpermissions.cpp UNKNOWN Diff: http://codereview.secondlife.com/r/365/diff Testing ------- (I had stuff here but Review Board kept deleting it every time I tried to save.) Thanks, Kadah -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110722/186f3111/attachment.htm From kadah.coba at gmail.com Thu Jul 21 17:35:53 2011 From: kadah.coba at gmail.com (Kadah Coba) Date: Fri, 22 Jul 2011 00:35:53 -0000 Subject: [opensource-dev] Review Request: STORM-1453: Prevent unintended 10L sale In-Reply-To: <20110722003425.2254.8860@domU-12-31-38-00-90-68.compute-1.internal> References: <20110722003425.2254.8860@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110722003553.9805.18138@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/365/#review906 ----------------------------------------------------------- Made the requested changes. Allow setting object price without needing to commit the object for sale at the default 10L first. - Kadah On July 21, 2011, 5:34 p.m., Kadah Coba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/365/ > ----------------------------------------------------------- > > (Updated July 21, 2011, 5:34 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > This change makes it so setting an object for sale or modifying the price or sale type requires explicitly applying the changes. Default behavior before this patch is all sale info is committed to sim on change. After this patch the sale info will only get set or modified after hitting a "mark for sale" button. There is no change to removing an object from sale, unchecking "For sale" will be committed to sim without further user interation. > > https://bitbucket.org/Kadah_Coba/storm-1453 > > > This addresses bug STORM-1453. > http://jira.secondlife.com/browse/STORM-1453 > > > Diffs > ----- > > indra/newview/llpanelpermissions.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/365/diff > > > Testing > ------- > > (I had stuff here but Review Board kept deleting it every time I tried to save.) > > > Thanks, > > Kadah > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110722/4071c977/attachment-0001.htm From nickyperian at yahoo.com Thu Jul 21 18:24:09 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Fri, 22 Jul 2011 01:24:09 -0000 Subject: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer) In-Reply-To: <20110721154351.2253.70492@domU-12-31-38-00-90-68.compute-1.internal> References: <20110721154351.2253.70492@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110722012409.2250.87892@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/313/#review907 ----------------------------------------------------------- Hash was 216ebc0442d29a8ba4a66ae8c7211b7aaa225892. However, the result is the same when building a clone of https://bitbucket.org/boroondas/viewer-development-open-67. I'll try to sort out a solution as time allows. Maybe another windows developer can pitch in. - Nicky On July 21, 2011, 8:43 a.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/313/ > ----------------------------------------------------------- > > (Updated July 21, 2011, 8:43 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Context: We are currently using Boost 1.45, which already comes with the new Boost Filesystem Library API (Version 3) but still defaults to the old one (Version 2). From Boost 1.46 on, V3 will be the default and Boost 1.47 will be the last one to come with V2. The Boost Filesystem Library documentation recommends "Existing code should be moved to Version 3 as soon as convenient. New code should be written for Version 3. Version 2 is deprecated, and will not be included in Boost releases 1.48 and later." > > This change overrides the default, so that the V3 API is used, and makes the necessary code changes. (So we can stick to Boost 1.45 and upgrade whenever we feel like it.) > > Note: I only changed stuff that the compiler complained about. If the new API also changes semantic of still-compiling library usage, more changes might be necessary. > > > This addresses bug OPEN-67. > http://jira.secondlife.com/browse/OPEN-67 > > > Diffs > ----- > > doc/contributions.txt 959f9340da92 > indra/llvfs/lldiriterator.cpp 959f9340da92 > > Diff: http://codereview.secondlife.com/r/313/diff > > > Testing > ------- > > * Compiled Viewer (standalone) with Boost 1.45 > * Started Viewer > * Logged in > > * Compiled Viewer (standalone) with Boost 1.46 > * Started Viewer > * Logged in > > Not tested: > * non-standalone > > > Thanks, > > Boroondas > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110722/628fa146/attachment.htm From wolfpup67 at earthlink.net Thu Jul 21 20:59:31 2011 From: wolfpup67 at earthlink.net (Wolfpup Lowenhar) Date: Fri, 22 Jul 2011 03:59:31 -0000 Subject: [opensource-dev] Review Request: STORM-1453: Prevent unintended 10L sale In-Reply-To: <20110722003553.9805.18138@domU-12-31-38-00-90-68.compute-1.internal> References: <20110722003553.9805.18138@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110722035931.9726.37612@domU-12-31-38-00-90-68.compute-1.internal> > On July 21, 2011, 5:35 p.m., Kadah Coba wrote: > > Made the requested changes. Allow setting object price without needing to commit the object for sale at the default 10L first. 1. Can the price be set to 0$L. 2. Dose this also fix it in the side tray? - Wolfpup ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/365/#review906 ----------------------------------------------------------- On July 21, 2011, 5:34 p.m., Kadah Coba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/365/ > ----------------------------------------------------------- > > (Updated July 21, 2011, 5:34 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > This change makes it so setting an object for sale or modifying the price or sale type requires explicitly applying the changes. Default behavior before this patch is all sale info is committed to sim on change. After this patch the sale info will only get set or modified after hitting a "mark for sale" button. There is no change to removing an object from sale, unchecking "For sale" will be committed to sim without further user interation. > > https://bitbucket.org/Kadah_Coba/storm-1453 > > > This addresses bug STORM-1453. > http://jira.secondlife.com/browse/STORM-1453 > > > Diffs > ----- > > indra/newview/llpanelpermissions.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/365/diff > > > Testing > ------- > > (I had stuff here but Review Board kept deleting it every time I tried to save.) > > > Thanks, > > Kadah > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110722/ab841504/attachment.htm From pguslisty at productengine.com Fri Jul 22 05:10:11 2011 From: pguslisty at productengine.com (Paul ProductEngine) Date: Fri, 22 Jul 2011 12:10:11 -0000 Subject: [opensource-dev] Review Request: STORM-1474 Implement Show Last Search in viewer chrome In-Reply-To: <20110720160945.2253.47159@domU-12-31-38-00-90-68.compute-1.internal> References: <20110720160945.2253.47159@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110722121011.9726.51849@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/402/ ----------------------------------------------------------- (Updated July 22, 2011, 5:10 a.m.) Review request for Viewer. Changes ------- Updated diff according to the new acceptance criteria of this issue. Now floater should be minimized on teleport. Summary (updated) ------- - Minimize the search floater on teleport This addresses bug storm-1474. http://jira.secondlife.com/browse/storm-1474 Diffs (updated) ----- indra/newview/llagent.cpp 216ebc0442d2 Diff: http://codereview.secondlife.com/r/402/diff Testing ------- Thanks, Paul -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110722/a5b9552e/attachment.htm From vsavchuk at productengine.com Fri Jul 22 05:29:18 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Fri, 22 Jul 2011 12:29:18 -0000 Subject: [opensource-dev] Review Request: STORM-1474 Implement Show Last Search in viewer chrome In-Reply-To: <20110722121011.9726.51849@domU-12-31-38-00-90-68.compute-1.internal> References: <20110722121011.9726.51849@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110722122918.9805.82155@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/402/#review909 ----------------------------------------------------------- Ship it! - Vadim On July 22, 2011, 5:10 a.m., Paul ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/402/ > ----------------------------------------------------------- > > (Updated July 22, 2011, 5:10 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > - Minimize the search floater on teleport > > > This addresses bug storm-1474. > http://jira.secondlife.com/browse/storm-1474 > > > Diffs > ----- > > indra/newview/llagent.cpp 216ebc0442d2 > > Diff: http://codereview.secondlife.com/r/402/diff > > > Testing > ------- > > > Thanks, > > Paul > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110722/094a6621/attachment.htm From oz at lindenlab.com Fri Jul 22 06:35:52 2011 From: oz at lindenlab.com (Oz Linden) Date: Fri, 22 Jul 2011 13:35:52 -0000 Subject: [opensource-dev] Review Request: OPEN-76 Fix autobuild so that --config-file option is honoured by subsequent (possibly recursive) commands In-Reply-To: <20110610094731.17341.70320@domU-12-31-38-00-90-68.compute-1.internal> References: <20110610094731.17341.70320@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110722133552.9726.73849@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/335/ ----------------------------------------------------------- (Updated July 22, 2011, 6:35 a.m.) Review request for Viewer and Alain Linden. Changes ------- Alain... would you please have a look at how this is done? Summary ------- When running a command such as: autobuild configure --config-file ab-test.xml -c ReleaseOS the configuration is only partially completed correctly. When the installables are processed, it does not use the correct configuration file. This is due to cmake calling autobuild install to do the actual install, but not passing the --config-file option. Autobuild falls back to the default autobuild.xml, because the correct configuration file is not saved at any point, which is not the intention and can cause configuration to be done with incorrect libraries. If autobuild.xml is missing or corrupt, an error occurs (which is how I discovered this), stopping the configure command. This fix saves the current value of the configuration file into the AUTOBUILD_CONFIG_FILE environmental variable so that it becomes the default value should any subsequent command need it. I believe that something like this was the original intention when adding this environment variable as part of the default check, but was overlooked. This addresses bug OPEN-76. http://jira.secondlife.com/browse/OPEN-76 Diffs ----- autobuild/configfile.py 2a560b1d8f95 Diff: http://codereview.secondlife.com/r/335/diff Testing ------- Ran 'autobuild configure --config-file ab-test.xml -c ReleaseOS' successfully without any errors and was able to build the expected viewer afterwards. Thanks, Ima -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110722/4d86edab/attachment-0001.htm From oz at lindenlab.com Fri Jul 22 07:02:06 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Fri, 22 Jul 2011 10:02:06 -0400 Subject: [opensource-dev] Quick test of open-38 integration Message-ID: <4E2982DE.6090506@lindenlab.com> I'm planning to integrate the changes from https://codereview.secondlife.com/r/167/ to better support standalone builds. I've done a test (non-standalone) build in our build farm, which appears to have completed successfully. I'd appreciate it if a few users would run the resulting viewers: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_project-1/rev/236387/index.html and let me know if anything is broken (that is not broken in a beta or development build). From vsavchuk at productengine.com Fri Jul 22 07:42:54 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Fri, 22 Jul 2011 14:42:54 -0000 Subject: [opensource-dev] Review Request: STORM-1311 Place Profile only shows 2 lines and users have to click More link to see full description Message-ID: <20110722144254.10060.65125@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/409/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Provide more space for parcel description in the Place Profile when coming from search. This also affects the way teleport history items look. In the first place I tried to make the description occupy all available space and follow viewer window shape. However that triggered numerous bugs in the text widgets, which spoiled the whole fix. So I'm coming up with a temporary hacky solution that should fit the ticket requirements. This addresses bug STORM-1311. http://jira.secondlife.com/browse/STORM-1311 Diffs ----- indra/newview/llexpandabletextbox.h UNKNOWN indra/newview/llexpandabletextbox.cpp UNKNOWN indra/newview/llpanelplaceprofile.cpp UNKNOWN Diff: http://codereview.secondlife.com/r/409/diff Testing ------- Thanks, Vadim -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110722/b35e7ed4/attachment.htm From ima.mechanique at blueyonder.co.uk Fri Jul 22 08:31:38 2011 From: ima.mechanique at blueyonder.co.uk (Ima Mechanique) Date: Fri, 22 Jul 2011 16:31:38 +0100 Subject: [opensource-dev] Quick test of open-38 integration In-Reply-To: <4E2982DE.6090506@lindenlab.com> References: <4E2982DE.6090506@lindenlab.com> Message-ID: <20110722163105.A2A7.5FD3A259@blueyonder.co.uk> > > I'm planning to integrate the changes from > > https://codereview.secondlife.com/r/167/ > > to better support standalone builds. > > I've done a test (non-standalone) build in our build farm, which appears > to have completed successfully. I'd appreciate it if a few users would > run the resulting viewers: > > http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_project-1/rev/236387/index.html > > and let me know if anything is broken (that is not broken in a beta or > development build). Did a (very) quick test with the cygwin version. Seems fine. I had audio, MoaP, Shared Media. > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk From vsavchuk at productengine.com Fri Jul 22 08:41:11 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Fri, 22 Jul 2011 15:41:11 -0000 Subject: [opensource-dev] Review Request: STORM-1451 "Login failed" message is empty in Danish Message-ID: <20110722154111.3132.9715@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/410/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Straightforward notification template fix. This addresses bug STORM-1451. http://jira.secondlife.com/browse/STORM-1451 Diffs ----- indra/newview/skins/default/xui/da/notifications.xml UNKNOWN Diff: http://codereview.secondlife.com/r/410/diff Testing ------- Thanks, Vadim -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110722/46d77dd1/attachment.htm From vsavchuk at productengine.com Fri Jul 22 09:02:02 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Fri, 22 Jul 2011 16:02:02 -0000 Subject: [opensource-dev] Review Request: STORM-1408 [DE] Text truncation in Edit outfit floater Message-ID: <20110722160202.5193.52144@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/411/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Overridden the Save button width for German. This addresses bug STORM-1408. http://jira.secondlife.com/browse/STORM-1408 Diffs ----- indra/newview/skins/default/xui/de/panel_outfit_edit.xml UNKNOWN Diff: http://codereview.secondlife.com/r/411/diff Testing ------- Thanks, Vadim -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110722/61b7450c/attachment.htm From oz at lindenlab.com Fri Jul 22 10:22:30 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Fri, 22 Jul 2011 13:22:30 -0400 Subject: [opensource-dev] Snowstorm PO Review build (yes... another one) Message-ID: <4E29B1D6.4050408@lindenlab.com> ... we're just crankin them out this week.... http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_viewer-poreview/rev/236537/index.html STORM-320 Script Editor in Viewer 2.0+ "tabs" incorrectly STORM-519 "Delete" is enabled in the context menu for folders which contain worn items STORM-1234 In Nearby Chat, Group Chat and IM Chat, URL selection frequently fails to grab last character STORM-1458 [crashhunters] crash at LLParticipantList::LLParticipantListMenu::isGroupModerator() [secondlife-bin llparticipantlist.cpp] STORM-1474 Implement Show Last Search in viewer chrome -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110722/9ac3ff9f/attachment.htm From kadah.coba at gmail.com Fri Jul 22 10:50:06 2011 From: kadah.coba at gmail.com (Kadah Coba) Date: Fri, 22 Jul 2011 17:50:06 -0000 Subject: [opensource-dev] Review Request: STORM-1453: Prevent unintended 10L sale In-Reply-To: <20110722003553.9805.18138@domU-12-31-38-00-90-68.compute-1.internal> References: <20110722003553.9805.18138@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110722175006.4919.34803@domU-12-31-38-00-90-68.compute-1.internal> > On July 21, 2011, 5:35 p.m., Kadah Coba wrote: > > Made the requested changes. Allow setting object price without needing to commit the object for sale at the default 10L first. > > Wolfpup Lowenhar wrote: > 1. Can the price be set to 0$L. > 2. Dose this also fix it in the side tray? 1. Yes, anything <0 is clammed to 0$L. 2. Yeah, side tray... I could park a freight train in the blind spot I have there. - Kadah ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/365/#review906 ----------------------------------------------------------- On July 21, 2011, 5:34 p.m., Kadah Coba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/365/ > ----------------------------------------------------------- > > (Updated July 21, 2011, 5:34 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > This change makes it so setting an object for sale or modifying the price or sale type requires explicitly applying the changes. Default behavior before this patch is all sale info is committed to sim on change. After this patch the sale info will only get set or modified after hitting a "mark for sale" button. There is no change to removing an object from sale, unchecking "For sale" will be committed to sim without further user interation. > > https://bitbucket.org/Kadah_Coba/storm-1453 > > > This addresses bug STORM-1453. > http://jira.secondlife.com/browse/STORM-1453 > > > Diffs > ----- > > indra/newview/llpanelpermissions.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/365/diff > > > Testing > ------- > > (I had stuff here but Review Board kept deleting it every time I tried to save.) > > > Thanks, > > Kadah > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110722/4eb206ea/attachment-0001.htm From vsavchuk at productengine.com Fri Jul 22 10:51:03 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Fri, 22 Jul 2011 17:51:03 -0000 Subject: [opensource-dev] Review Request: STORM-1404 Light viewer: untranslated buttons in the People panel Message-ID: <20110722175103.2253.33276@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/412/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Bug reason: incorrect reuse of an xml element name. Fix: provided unique names for the buttons. This addresses bug STORM-1404. http://jira.secondlife.com/browse/STORM-1404 Diffs ----- indra/newview/skins/minimal/xui/da/panel_people.xml UNKNOWN indra/newview/skins/minimal/xui/de/panel_people.xml UNKNOWN indra/newview/skins/minimal/xui/en/panel_people.xml UNKNOWN indra/newview/skins/minimal/xui/es/panel_people.xml UNKNOWN indra/newview/skins/minimal/xui/fr/panel_people.xml UNKNOWN indra/newview/skins/minimal/xui/it/panel_people.xml UNKNOWN indra/newview/skins/minimal/xui/ja/panel_people.xml UNKNOWN indra/newview/skins/minimal/xui/pl/panel_people.xml UNKNOWN indra/newview/skins/minimal/xui/pt/panel_people.xml UNKNOWN Diff: http://codereview.secondlife.com/r/412/diff Testing ------- Thanks, Vadim -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110722/55cbc162/attachment.htm From hitomi.tiponi at yahoo.co.uk Fri Jul 22 11:18:14 2011 From: hitomi.tiponi at yahoo.co.uk (Hitomi Tiponi) Date: Fri, 22 Jul 2011 19:18:14 +0100 (BST) Subject: [opensource-dev] Viewer Evolution User Group Meetings Message-ID: <1311358694.60290.YahooMailRC@web23901.mail.ird.yahoo.com> Have these weekly meetings being cancelled - as they seem to have been removed from the calendar - or are LL just missing one or two? If they have been cancelled then the relevant wiki pages need to be amended. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110722/4e2e8494/attachment.htm From kadah.coba at gmail.com Fri Jul 22 11:47:32 2011 From: kadah.coba at gmail.com (Kadah Coba) Date: Fri, 22 Jul 2011 18:47:32 -0000 Subject: [opensource-dev] Review Request: STORM-1453: Prevent unintended 10L sale In-Reply-To: <20110722003425.2254.8860@domU-12-31-38-00-90-68.compute-1.internal> References: <20110722003425.2254.8860@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110722184732.9615.86436@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/365/ ----------------------------------------------------------- (Updated July 22, 2011, 11:47 a.m.) Review request for Viewer. Changes ------- Updated for sidebar's object profile panel. Summary ------- This change makes it so setting an object for sale or modifying the price or sale type requires explicitly applying the changes. Default behavior before this patch is all sale info is committed to sim on change. After this patch the sale info will only get set or modified after hitting a "mark for sale" button. There is no change to removing an object from sale, unchecking "For sale" will be committed to sim without further user interation. https://bitbucket.org/Kadah_Coba/storm-1453 This addresses bug STORM-1453. http://jira.secondlife.com/browse/STORM-1453 Diffs (updated) ----- indra/newview/llpanelpermissions.cpp UNKNOWN indra/newview/llsidepaneltaskinfo.cpp UNKNOWN Diff: http://codereview.secondlife.com/r/365/diff Testing ------- (I had stuff here but Review Board kept deleting it every time I tried to save.) Thanks, Kadah -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110722/5238b3ca/attachment.htm From slitovchuk at productengine.com Fri Jul 22 12:50:01 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Fri, 22 Jul 2011 19:50:01 -0000 Subject: [opensource-dev] Review Request: STORM-1451 "Login failed" message is empty in Danish In-Reply-To: <20110722154111.3132.9715@domU-12-31-38-00-90-68.compute-1.internal> References: <20110722154111.3132.9715@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110722195001.2251.46415@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/410/#review912 ----------------------------------------------------------- Ship it! Works for me. - Seth On July 22, 2011, 8:41 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/410/ > ----------------------------------------------------------- > > (Updated July 22, 2011, 8:41 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Straightforward notification template fix. > > > This addresses bug STORM-1451. > http://jira.secondlife.com/browse/STORM-1451 > > > Diffs > ----- > > indra/newview/skins/default/xui/da/notifications.xml UNKNOWN > > Diff: http://codereview.secondlife.com/r/410/diff > > > Testing > ------- > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110722/40ea6120/attachment.htm From slitovchuk at productengine.com Fri Jul 22 12:55:35 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Fri, 22 Jul 2011 19:55:35 -0000 Subject: [opensource-dev] Review Request: STORM-1408 [DE] Text truncation in Edit outfit floater In-Reply-To: <20110722160202.5193.52144@domU-12-31-38-00-90-68.compute-1.internal> References: <20110722160202.5193.52144@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110722195535.10060.9039@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/411/#review913 ----------------------------------------------------------- Ship it! Looks good. - Seth On July 22, 2011, 9:02 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/411/ > ----------------------------------------------------------- > > (Updated July 22, 2011, 9:02 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Overridden the Save button width for German. > > > This addresses bug STORM-1408. > http://jira.secondlife.com/browse/STORM-1408 > > > Diffs > ----- > > indra/newview/skins/default/xui/de/panel_outfit_edit.xml UNKNOWN > > Diff: http://codereview.secondlife.com/r/411/diff > > > Testing > ------- > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110722/3b089e66/attachment.htm From trilobyte550m at gmail.com Fri Jul 22 16:08:25 2011 From: trilobyte550m at gmail.com (Trilo Byte) Date: Fri, 22 Jul 2011 16:08:25 -0700 Subject: [opensource-dev] Viewer Evolution User Group Meetings In-Reply-To: <1311358694.60290.YahooMailRC@web23901.mail.ird.yahoo.com> References: <1311358694.60290.YahooMailRC@web23901.mail.ird.yahoo.com> Message-ID: <28B1BDC0-90C8-4F85-ADDD-E15B44BA1353@gmail.com> The 'Viewer Evolution' Friday meetings recently transitioned from Oz to Esbee Linden as owner. However, since the handoff there hasn't been a meeting (3 weeks now) but it lingered on the wiki schedule as an oversight. She said the meetings will continue and expand in scope, and that when that happens she'll put them back on the calendar. Trilo On Jul 22, 2011, at 11:18 AM, Hitomi Tiponi wrote: > Have these weekly meetings being cancelled - as they seem to have been removed from the calendar - or are LL just missing one or two? > > If they have been cancelled then the relevant wiki pages need to be amended. > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110722/db51c8e1/attachment.htm From vsavchuk at productengine.com Sat Jul 23 06:48:08 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Sat, 23 Jul 2011 13:48:08 -0000 Subject: [opensource-dev] Review Request: VWR-26458: fixing a simple typo in German translation In-Reply-To: <20110721224250.2250.76877@domU-12-31-38-00-90-68.compute-1.internal> References: <20110721224250.2250.76877@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110723134808.3133.74925@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/408/#review914 ----------------------------------------------------------- Ship it! - Vadim On July 21, 2011, 3:42 p.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/408/ > ----------------------------------------------------------- > > (Updated July 21, 2011, 3:42 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Found this coincidentally when looking through recent changesets. Thought I'd fix it right away. > > > This addresses bug VWR-26458. > http://jira.secondlife.com/browse/VWR-26458 > > > Diffs > ----- > > doc/contributions.txt 06874d04d57e > indra/newview/skins/default/xui/de/floater_delete_env_preset.xml 06874d04d57e > > Diff: http://codereview.secondlife.com/r/408/diff > > > Testing > ------- > > none > > > Thanks, > > Boroondas > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110723/c8bcff73/attachment.htm From vsavchuk at productengine.com Sat Jul 23 06:49:24 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Sat, 23 Jul 2011 13:49:24 -0000 Subject: [opensource-dev] Review Request: STORM-1523: fixing a simple typo in German translation In-Reply-To: <20110721224250.2250.76877@domU-12-31-38-00-90-68.compute-1.internal> References: <20110721224250.2250.76877@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110723134924.2254.75917@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/408/ ----------------------------------------------------------- (Updated July 23, 2011, 6:49 a.m.) Review request for Viewer. Changes ------- Updated JIRA ticket number. Summary (updated) ------- Found this coincidentally when looking through recent changesets. Thought I'd fix it right away. This addresses bug STORM-1523. http://jira.secondlife.com/browse/STORM-1523 Diffs ----- doc/contributions.txt 06874d04d57e indra/newview/skins/default/xui/de/floater_delete_env_preset.xml 06874d04d57e Diff: http://codereview.secondlife.com/r/408/diff Testing ------- none Thanks, Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110723/71d7d64b/attachment.htm From nickyperian at yahoo.com Sat Jul 23 09:53:08 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Sat, 23 Jul 2011 16:53:08 -0000 Subject: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer) In-Reply-To: <20110721154351.2253.70492@domU-12-31-38-00-90-68.compute-1.internal> References: <20110721154351.2253.70492@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110723165308.2252.78631@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/313/#review915 ----------------------------------------------------------- https://bitbucket.org/lindenlab/viewer-development/changeset/a0b400b5ff0e/ The comments in this changeset describe the windows build / link issues for this CR. - Nicky On July 21, 2011, 8:43 a.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/313/ > ----------------------------------------------------------- > > (Updated July 21, 2011, 8:43 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Context: We are currently using Boost 1.45, which already comes with the new Boost Filesystem Library API (Version 3) but still defaults to the old one (Version 2). From Boost 1.46 on, V3 will be the default and Boost 1.47 will be the last one to come with V2. The Boost Filesystem Library documentation recommends "Existing code should be moved to Version 3 as soon as convenient. New code should be written for Version 3. Version 2 is deprecated, and will not be included in Boost releases 1.48 and later." > > This change overrides the default, so that the V3 API is used, and makes the necessary code changes. (So we can stick to Boost 1.45 and upgrade whenever we feel like it.) > > Note: I only changed stuff that the compiler complained about. If the new API also changes semantic of still-compiling library usage, more changes might be necessary. > > > This addresses bug OPEN-67. > http://jira.secondlife.com/browse/OPEN-67 > > > Diffs > ----- > > doc/contributions.txt 959f9340da92 > indra/llvfs/lldiriterator.cpp 959f9340da92 > > Diff: http://codereview.secondlife.com/r/313/diff > > > Testing > ------- > > * Compiled Viewer (standalone) with Boost 1.45 > * Started Viewer > * Logged in > > * Compiled Viewer (standalone) with Boost 1.46 > * Started Viewer > * Logged in > > Not tested: > * non-standalone > > > Thanks, > > Boroondas > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110723/9a27b2a1/attachment-0001.htm From sllists at boroon.dasgupta.ch Sun Jul 24 03:49:11 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Sun, 24 Jul 2011 12:49:11 +0200 Subject: [opensource-dev] LL Windows Boost prebuilt not API-conformant? (was: Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)) In-Reply-To: <20110723165308.2252.78631@domU-12-31-38-00-90-68.compute-1.internal> References: <20110721154351.2253.70492@domU-12-31-38-00-90-68.compute-1.internal> <20110723165308.2252.78631@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <4E2BF8A7.9040203@boroon.dasgupta.ch> On 07/23/2011 06:53 PM, Nicky Perian wrote: > https://bitbucket.org/lindenlab/viewer-development/changeset/a0b400b5ff0e/ > The comments in this changeset describe the windows build / link > issues for this CR. Hmm ... interesting. Thanks for investigating this. Alone from the Boost API documentation, I wouldn't have been able to find the cause of the undefined symbols errors you're seeing, I guess. From nat at lindenlab.com Sun Jul 24 04:35:38 2011 From: nat at lindenlab.com (Nat Goodspeed) Date: Sun, 24 Jul 2011 07:35:38 -0400 Subject: [opensource-dev] LL Windows Boost prebuilt not API-conformant? (was: Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)) In-Reply-To: <4E2BF8A7.9040203@boroon.dasgupta.ch> References: <20110721154351.2253.70492@domU-12-31-38-00-90-68.compute-1.internal> <20110723165308.2252.78631@domU-12-31-38-00-90-68.compute-1.internal> <4E2BF8A7.9040203@boroon.dasgupta.ch> Message-ID: On Jul 24, 2011, at 6:49 AM, Boroondas Gupte wrote: > Is that somehow related to the compile flag mismatch mentioned in changeset 740d8b8e509f? > > If the lib binary indeed deviates from the API, shouldn't we try to fix the binary rather than hacking around these problems in the calling viewer code? If I'm correct about that problem, then yes, the "right" fix would be to repackage our Boost library tarball, at least for Windows. Had I been writing viewer code, I would have tried that. This particular bit of code was to add tests, and I was trying to get it done fairly quickly as my schedule window was closing. I was unaware that this problem was biting anyone else; indeed I assumed that if it had, it would already have been fixed. May I recommend filing a Jira explaining the link errors you're encountering, along with the Boost mailing-list link and the cited Microsoft page? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110724/e36cda76/attachment.htm From sllists at boroon.dasgupta.ch Sun Jul 24 04:54:05 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Sun, 24 Jul 2011 13:54:05 +0200 Subject: [opensource-dev] LL Windows Boost prebuilt not API-conformant? In-Reply-To: References: <20110721154351.2253.70492@domU-12-31-38-00-90-68.compute-1.internal> <20110723165308.2252.78631@domU-12-31-38-00-90-68.compute-1.internal> <4E2BF8A7.9040203@boroon.dasgupta.ch> Message-ID: <4E2C07DD.3050809@boroon.dasgupta.ch> On 07/24/2011 01:35 PM, Nat Goodspeed wrote: > I was unaware that this problem was biting anyone else; indeed I > assumed that if it had, it would already have been fixed. > > May I recommend filing a Jira explaining the link errors you're > encountering, along with the Boost mailing-list link and the cited > Microsoft page? The current viewer-development code isn't having this issue, only my proposed fix for OPEN-67 (being reviewed at https://codereview.secondlife.com/r/313/) will exhibit it. As I build on Linux only, I didn't observe the problem myself. NickyP made me aware of it in his review. Cheers, Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110724/580a5a3d/attachment.htm From laurent.bechir at madonie.org Sun Jul 24 06:13:14 2011 From: laurent.bechir at madonie.org (Laurent Bechir) Date: Sun, 24 Jul 2011 15:13:14 +0200 Subject: [opensource-dev] Python broken on Lion - autobuild doesn't work Message-ID: <48385D90-9E76-4A45-A873-C1DF2768E583@madonie.org> Hello, I've just upgraded to Lion and python seems to be broken. I can't use either autobuild and git. : autobuild Traceback (most recent call last): File "/usr/local/bin/autobuild", line 5, in from pkg_resources import load_entry_point File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources.py", line 2603, in working_set.require(__requires__) File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources.py", line 666, in require needed = self.resolve(parse_requirements(requirements)) File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources.py", line 565, in resolve raise DistributionNotFound(req) # XXX put more info here pkg_resources.DistributionNotFound: autobuild==0.8.5 And Xcode is suddenly half english, half eastern language... Perhaps installing the new version of Xcode would solve the problem ? But I don't know if I can still build Second Life viewer with Xcode 4.1. Thank you From wolfpup67 at earthlink.net Sun Jul 24 07:16:27 2011 From: wolfpup67 at earthlink.net (WolfPup Lowenhar) Date: Sun, 24 Jul 2011 10:16:27 -0400 Subject: [opensource-dev] Python broken on Lion - autobuild doesn't work In-Reply-To: <48385D90-9E76-4A45-A873-C1DF2768E583@madonie.org> References: <48385D90-9E76-4A45-A873-C1DF2768E583@madonie.org> Message-ID: <000f01cc4a0c$46dec7d0$d49c5770$@net> It looks like your trying to use python 2.7 there maybe be an issue when autobuild is trying to run. I would suggest removing 2.7 and try it with 2.6 instead. > -----Original Message----- > From: opensource-dev-bounces at lists.secondlife.com [mailto:opensource-dev- > bounces at lists.secondlife.com] On Behalf Of Laurent Bechir > Sent: Sunday, July 24, 2011 9:13 AM > To: Viewer > Subject: [opensource-dev] Python broken on Lion - autobuild doesn't work > > > Hello, > > I've just upgraded to Lion and python seems to be broken. I can't use either > autobuild and git. : > > autobuild > Traceback (most recent call last): > File "/usr/local/bin/autobuild", line 5, in > from pkg_resources import load_entry_point > File > "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/pyth > on/pkg_resources.py", line 2603, in > working_set.require(__requires__) > File > "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/pyth > on/pkg_resources.py", line 666, in require > needed = self.resolve(parse_requirements(requirements)) > File > "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/pyth > on/pkg_resources.py", line 565, in resolve > raise DistributionNotFound(req) # XXX put more info here > pkg_resources.DistributionNotFound: autobuild==0.8.5 > > And Xcode is suddenly half english, half eastern language... > > > Perhaps installing the new version of Xcode would solve the problem ? But I > don't know if I can still build Second Life viewer with Xcode 4.1. > > Thank you > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > ----- > No virus found in this message. > Checked by AVG - www.avg.com > Version: 10.0.1390 / Virus Database: 1518/3785 - Release Date: 07/24/11 From bunny at bunnynet.org Sun Jul 24 09:06:02 2011 From: bunny at bunnynet.org (Bunny Halberd) Date: Sun, 24 Jul 2011 11:06:02 -0500 Subject: [opensource-dev] Pervious Version Archive? Message-ID: Hello! Does anyone know if there's a place where the older viewer are archived and still available for download? I searched the Wiki and found this: http://wiki.secondlife.com/wiki/Old_Viewer_versions ...but it stops around 2.2. I'm looking for something in the 2.7 line that's older than 2.7.5. Thanks! - Bunny From sllists at boroon.dasgupta.ch Sun Jul 24 09:48:16 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Sun, 24 Jul 2011 18:48:16 +0200 Subject: [opensource-dev] Pervious Version Archive? In-Reply-To: References: Message-ID: <4E2C4CD0.5020600@boroon.dasgupta.ch> On 07/24/2011 06:06 PM, Bunny Halberd wrote: > Does anyone know if there's a place where the older viewer are > archived and still available for download? > > I searched the Wiki and found this: > http://wiki.secondlife.com/wiki/Old_Viewer_versions ...but it stops > around 2.2. I'm looking for something in the 2.7 line that's older > than 2.7.5. The release notes page for each version usually has links to corresponding downloads. All release notes pages should all be in category Release Notes . The link to 2.7.4 can also still be found on Supported Viewers > SL Viewer Downloads > Channel: Second Life Release . Cheers, Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110724/9ea905b6/attachment.htm From bunny at bunnynet.org Sun Jul 24 09:50:51 2011 From: bunny at bunnynet.org (Bunny Halberd) Date: Sun, 24 Jul 2011 11:50:51 -0500 Subject: [opensource-dev] Pervious Version Archive? In-Reply-To: <4E2C4CD0.5020600@boroon.dasgupta.ch> References: <4E2C4CD0.5020600@boroon.dasgupta.ch> Message-ID: On Sun, Jul 24, 2011 at 11:48 AM, Boroondas Gupte wrote: > The release notes page for each version usually has links to corresponding > downloads. All release notes pages should all be in category Release Notes. > The link to 2.7.4 can also still be found on Supported Viewers > SL Viewer > Downloads? > Channel: Second Life Release. Ah, thank you! I knew I had seen that before but couldn't remember where. - Bunny From stone at lindenlab.com Sun Jul 24 11:12:00 2011 From: stone at lindenlab.com (Stone Linden) Date: Sun, 24 Jul 2011 11:12:00 -0700 Subject: [opensource-dev] Python broken on Lion - autobuild doesn't work In-Reply-To: <48385D90-9E76-4A45-A873-C1DF2768E583@madonie.org> References: <48385D90-9E76-4A45-A873-C1DF2768E583@madonie.org> Message-ID: On Sun, Jul 24, 2011 at 6:13 AM, Laurent Bechir wrote: > > Hello, > > I've just upgraded to Lion and python seems to be broken. I can't use > either autobuild and git. : > > autobuild > Traceback (most recent call last): > File "/usr/local/bin/autobuild", line 5, in > from pkg_resources import load_entry_point > File > "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources.py", > line 2603, in > working_set.require(__requires__) > File > "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources.py", > line 666, in require > needed = self.resolve(parse_requirements(requirements)) > File > "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources.py", > line 565, in resolve > raise DistributionNotFound(req) # XXX put more info here > pkg_resources.DistributionNotFound: autobuild==0.8.5 > > Did you easy_install autobuild under Snow Leopard? Try easy_install-ing it again; the autobuild components were probably installed under the Python 2.6 search paths and so cannot be found under the 2.7 search paths. > And Xcode is suddenly half english, half eastern language... > > > Perhaps installing the new version of Xcode would solve the problem ? But I > don't know if I can still build Second Life viewer with Xcode 4.1. > We continue to use Xcode 3.2 at LL and haven't started testing under 4.1 or 4.2 yet. You're welcome to try, but you'll be on your own! Cheers, Stone -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110724/fcd3fab9/attachment.htm From sythos at gmail.com Sun Jul 24 11:16:57 2011 From: sythos at gmail.com (Altair Sythos Memo) Date: Sun, 24 Jul 2011 20:16:57 +0200 Subject: [opensource-dev] Python broken on Lion - autobuild doesn't work In-Reply-To: <48385D90-9E76-4A45-A873-C1DF2768E583@madonie.org> References: <48385D90-9E76-4A45-A873-C1DF2768E583@madonie.org> Message-ID: <20110724201657.fe2e68cd5101a813824bc14b@gmail.com> On Sun, 24 Jul 2011 15:13:14 +0200 Laurent Bechir wrote: > > Hello, > > I've just upgraded to Lion and python seems to be broken. I can't use > either autobuild and git. : > > autobuild > Traceback (most recent call last): > File "/usr/local/bin/autobuild", line 5, in > from pkg_resources import load_entry_point > File > "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources.py", > line 2603, in working_set.require(__requires__) File > "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources.py", > line 666, in require needed = self.resolve(parse_requirements > (requirements)) File > "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources.py", > line 565, in resolve raise DistributionNotFound(req) # XXX put more > info here pkg_resources.DistributionNotFound: autobuild==0.8.5 > > And Xcode is suddenly half english, half eastern language... > > > Perhaps installing the new version of Xcode would solve the problem ? > But I don't know if I can still build Second Life viewer with Xcode > 4.1. Lion is shipped with Pythn2.7, you need to install "by hand" from python homepage 2.6 package for macosx and modify your autobuild script (text editor) changing first line from trailing "python" to "python-2.6" From katharine at katharineberry.co.uk Sun Jul 24 11:37:24 2011 From: katharine at katharineberry.co.uk (Katharine Berry) Date: Sun, 24 Jul 2011 14:37:24 -0400 Subject: [opensource-dev] Python broken on Lion - autobuild doesn't work In-Reply-To: <20110724201657.fe2e68cd5101a813824bc14b@gmail.com> References: <48385D90-9E76-4A45-A873-C1DF2768E583@madonie.org> <20110724201657.fe2e68cd5101a813824bc14b@gmail.com> Message-ID: <6491CC43-FB3F-4A58-A643-6F3738231CC7@katharineberry.co.uk> On Jul 24, 2011, at 2:16 PM, Altair Sythos Memo wrote: > Lion is shipped with Pythn2.7, you need to install "by hand" from > python homepage 2.6 package for macosx and modify your autobuild script > (text editor) changing first line from trailing "python" to "python-2.6" Not true; Lion comes with 2.5, 2.6 and 2.7 preinstalled. I'd recommend simply trying to easy_install autobuild again; changing python versions will require you to reinstall all your packages. Failing that, you can do this to universally switch back to 2.6 (unless you invoke python2.5, python2.6 or python2.7): defaults write com.apple.versioner.python Version 2.6 As for fixing Xcode, I believe that only Xcode 4 is fully supported under Lion; good luck. ? Katharine Berry From laurent.bechir at madonie.org Sun Jul 24 16:01:52 2011 From: laurent.bechir at madonie.org (Laurent Bechir) Date: Mon, 25 Jul 2011 01:01:52 +0200 Subject: [opensource-dev] Python broken on Lion - autobuild doesn't work In-Reply-To: <6491CC43-FB3F-4A58-A643-6F3738231CC7@katharineberry.co.uk> References: <48385D90-9E76-4A45-A873-C1DF2768E583@madonie.org> <20110724201657.fe2e68cd5101a813824bc14b@gmail.com> <6491CC43-FB3F-4A58-A643-6F3738231CC7@katharineberry.co.uk> Message-ID: <5D59613C-EAC2-4FD7-9E25-C0067331FA22@madonie.org> Le 24 juil. 2011 ? 20:37, Katharine Berry a ?crit : > On Jul 24, 2011, at 2:16 PM, Altair Sythos Memo wrote: >> Lion is shipped with Pythn2.7, you need to install "by hand" from >> python homepage 2.6 package for macosx and modify your autobuild script >> (text editor) changing first line from trailing "python" to "python-2.6" > > > Not true; Lion comes with 2.5, 2.6 and 2.7 preinstalled. > > I'd recommend simply trying to easy_install autobuild again; changing python versions will require you to reinstall all your packages. Failing that, you can do this to universally switch back to 2.6 (unless you invoke python2.5, python2.6 or python2.7): > > defaults write com.apple.versioner.python Version 2.6 I've removed autobuild in /usr/local/bin and set up the path to the one I had took from Second Life repository. It seems to work, now the problem comes from Xcode, CMAKE_MAKE_PROGRAM being not set. But I guess it is because XCode 3.2.x is not supported anymore with Lion. > > As for fixing Xcode, I believe that only Xcode 4 is fully supported under Lion; good luck. > > ? Katharine Berry > Yes, only XCode 4 is supported on Lion. It's not possible anymore to install 3.x versions. So I'll keep my fingers crossed and install it hoping it will work. From wolfpup67 at earthlink.net Sun Jul 24 19:18:58 2011 From: wolfpup67 at earthlink.net (WolfPup Lowenhar) Date: Sun, 24 Jul 2011 22:18:58 -0400 Subject: [opensource-dev] PAGEING ALL MAC Devs!!!!!!!!!! Message-ID: <000001cc4a71$361d6e00$a2584a00$@net> Please refer to https://jira.secondlife.com/browse/OPEN-105 .I need a Mac dev to help with getting this buildable for Mac. Please let me know if you can help and also work for the tip of my repository listed in the JIRA. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110724/497c30dc/attachment.htm From vsavchuk at productengine.com Mon Jul 25 06:29:44 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Mon, 25 Jul 2011 13:29:44 -0000 Subject: [opensource-dev] Review Request: STORM-565 llGiveInventory window is suppressed if avatar in Busy mode Message-ID: <20110725132944.21539.76098@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/413/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Allow inventory offers from objects in Busy mode. This addresses bug STORM-565. http://jira.secondlife.com/browse/STORM-565 Diffs ----- indra/newview/llviewermessage.cpp UNKNOWN Diff: http://codereview.secondlife.com/r/413/diff Testing ------- Tried inventory offers from objects and avatars in normal and busy modes. Thanks, Vadim -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110725/2640633b/attachment.htm From slitovchuk at productengine.com Mon Jul 25 07:14:27 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Mon, 25 Jul 2011 14:14:27 -0000 Subject: [opensource-dev] Review Request: STORM-1404 Light viewer: untranslated buttons in the People panel In-Reply-To: <20110722175103.2253.33276@domU-12-31-38-00-90-68.compute-1.internal> References: <20110722175103.2253.33276@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110725141427.25768.89681@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/412/#review916 ----------------------------------------------------------- Ship it! Looks like a duplicate of https://codereview.secondlife.com/r/387 which deals with STORM-1403, the issue caused by the same widget naming problem. - Seth On July 22, 2011, 10:51 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/412/ > ----------------------------------------------------------- > > (Updated July 22, 2011, 10:51 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Bug reason: incorrect reuse of an xml element name. > Fix: provided unique names for the buttons. > > > This addresses bug STORM-1404. > http://jira.secondlife.com/browse/STORM-1404 > > > Diffs > ----- > > indra/newview/skins/minimal/xui/da/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/de/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/en/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/es/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/fr/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/it/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/ja/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/pl/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/pt/panel_people.xml UNKNOWN > > Diff: http://codereview.secondlife.com/r/412/diff > > > Testing > ------- > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110725/110510ac/attachment.htm From vsavchuk at productengine.com Mon Jul 25 07:36:35 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Mon, 25 Jul 2011 14:36:35 -0000 Subject: [opensource-dev] Review Request: STORM-1220 Region / Estate > Covenant - Type of region is in EN: "Estate / Full Region" Message-ID: <20110725143635.25768.33911@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/414/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Localized sim product name (e.g. "Estate / Full Region") everywhere. This addresses bug STORM-1220. http://jira.secondlife.com/browse/STORM-1220 Diffs ----- indra/newview/llfloaterbuyland.cpp UNKNOWN indra/newview/llfloaterland.cpp UNKNOWN indra/newview/llfloaterregioninfo.cpp UNKNOWN indra/newview/llpanelplaceprofile.cpp UNKNOWN indra/newview/llviewerregion.h UNKNOWN indra/newview/llviewerregion.cpp UNKNOWN Diff: http://codereview.secondlife.com/r/414/diff Testing ------- Thanks, Vadim -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110725/7cc4cdab/attachment.htm From vsavchuk at productengine.com Mon Jul 25 07:50:31 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Mon, 25 Jul 2011 14:50:31 -0000 Subject: [opensource-dev] Review Request: STORM-1403: ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button names in People pane In-Reply-To: <20110718175338.2256.90870@domU-12-31-38-00-90-68.compute-1.internal> References: <20110718175338.2256.90870@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110725145031.24989.5978@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/387/#review917 ----------------------------------------------------------- Rejecting this fix in favor of a duplicate (but I think better) one: https://codereview.secondlife.com/r/412/ indra/newview/skins/minimal/xui/da/panel_people.xml Missing rename here. indra/newview/skins/minimal/xui/da/panel_people.xml Unclear why this was removed. indra/newview/skins/minimal/xui/es/panel_people.xml missing rename indra/newview/skins/minimal/xui/fr/panel_people.xml ditto indra/newview/skins/minimal/xui/it/panel_people.xml ditto indra/newview/skins/minimal/xui/ja/panel_people.xml ditto indra/newview/skins/minimal/xui/pl/panel_people.xml ditto indra/newview/skins/minimal/xui/pt/panel_people.xml ditto - Vadim On July 18, 2011, 10:53 a.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/387/ > ----------------------------------------------------------- > > (Updated July 18, 2011, 10:53 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > The layout_panels containing the buttons didn't have unique names. > Renamed them so that their names are now unique within their parent > element. > > Removed the share_btn element and containing layout_panel from translations that contained it, as it doesn't occur in the English version. > > The English file mixed tabs and spaces. Converted tabs to spaces for that file. > > Stripped trailing whitespace from the English file. > > > This addresses bug STORM-1403. > http://jira.secondlife.com/browse/STORM-1403 > > > Diffs > ----- > > doc/contributions.txt 2204db549295 > indra/newview/skins/minimal/xui/da/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/de/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/en/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/es/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/fr/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/it/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/ja/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/pl/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/pt/panel_people.xml 2204db549295 > > Diff: http://codereview.secondlife.com/r/387/diff > > > Testing > ------- > > Switched to French, relogged, changed to default mode and logged out. Applied this patch with -p3 to SecondLife-i686-2.7.5.233393/ (I'm using a downloaded build, as I still cannot complete a build again.) > > Logged in, clicked 'Personnes' button, then 'MES AMIS' tab. The Call and Teleport buttons were now labeled in French. > > Not tested: > * Funktionality of the buttons. > * Languages other than French. > > Update: > Tested "My Friends" tab of "People" floater (basic mode) in da, de, en, es, fr, it, ja, pl and pt: > Verified for each language that > * labels on all 4 buttons on that tab are translated (or as translated as in the XML files. "IM" seems to be the wanted label for the chat button in most of them.) > * tool-tips of all 4 buttons are translated > * all 4 buttons cause the action they're intended to cause when clicked > > > Thanks, > > Boroondas > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110725/48030f69/attachment-0001.htm From slitovchuk at productengine.com Mon Jul 25 09:41:22 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Mon, 25 Jul 2011 16:41:22 -0000 Subject: [opensource-dev] Review Request: STORM-1311 Place Profile only shows 2 lines and users have to click More link to see full description In-Reply-To: <20110722144254.10060.65125@domU-12-31-38-00-90-68.compute-1.internal> References: <20110722144254.10060.65125@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110725164122.21539.78685@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/409/#review918 ----------------------------------------------------------- Ship it! Looks good to me. - Seth On July 22, 2011, 7:42 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/409/ > ----------------------------------------------------------- > > (Updated July 22, 2011, 7:42 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Provide more space for parcel description in the Place Profile when coming from search. > > This also affects the way teleport history items look. > > In the first place I tried to make the description occupy all available space > and follow viewer window shape. However that triggered numerous bugs in the > text widgets, which spoiled the whole fix. > So I'm coming up with a temporary hacky solution that should fit > the ticket requirements. > > > This addresses bug STORM-1311. > http://jira.secondlife.com/browse/STORM-1311 > > > Diffs > ----- > > indra/newview/llexpandabletextbox.h UNKNOWN > indra/newview/llexpandabletextbox.cpp UNKNOWN > indra/newview/llpanelplaceprofile.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/409/diff > > > Testing > ------- > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110725/e71b8b90/attachment.htm From sllists at boroon.dasgupta.ch Mon Jul 25 09:47:41 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Mon, 25 Jul 2011 16:47:41 -0000 Subject: [opensource-dev] Review Request: STORM-1403: ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button names in People pane In-Reply-To: <20110725145031.24989.5978@domU-12-31-38-00-90-68.compute-1.internal> References: <20110725145031.24989.5978@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110725164741.21541.4455@domU-12-31-38-00-90-68.compute-1.internal> > On July 25, 2011, 7:50 a.m., Vadim ProductEngine wrote: > > indra/newview/skins/minimal/xui/da/panel_people.xml, line 69 > > > > > > Missing rename here. For some reason I thought STORM-1403 was only about the "My Friends" tab of "People" floater, but re-reading the issue, it is indeed about all of the "People" floater, even thought the explicitly mentioned labels are all from the "My Friends" tab, so you are right that this element should have been renamed, too. > On July 25, 2011, 7:50 a.m., Vadim ProductEngine wrote: > > indra/newview/skins/minimal/xui/da/panel_people.xml, lines 76-78 > > > > > > Unclear why this was removed. As mentioned in the description, share_btn doesn't seem to have any correspondence in the English-language master file indra/newview/skins/minimal/xui/en/panel_people.xml, so I think it should be removed from the translation files, too. - Boroondas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/387/#review917 ----------------------------------------------------------- On July 18, 2011, 10:53 a.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/387/ > ----------------------------------------------------------- > > (Updated July 18, 2011, 10:53 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > The layout_panels containing the buttons didn't have unique names. > Renamed them so that their names are now unique within their parent > element. > > Removed the share_btn element and containing layout_panel from translations that contained it, as it doesn't occur in the English version. > > The English file mixed tabs and spaces. Converted tabs to spaces for that file. > > Stripped trailing whitespace from the English file. > > > This addresses bug STORM-1403. > http://jira.secondlife.com/browse/STORM-1403 > > > Diffs > ----- > > doc/contributions.txt 2204db549295 > indra/newview/skins/minimal/xui/da/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/de/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/en/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/es/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/fr/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/it/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/ja/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/pl/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/pt/panel_people.xml 2204db549295 > > Diff: http://codereview.secondlife.com/r/387/diff > > > Testing > ------- > > Switched to French, relogged, changed to default mode and logged out. Applied this patch with -p3 to SecondLife-i686-2.7.5.233393/ (I'm using a downloaded build, as I still cannot complete a build again.) > > Logged in, clicked 'Personnes' button, then 'MES AMIS' tab. The Call and Teleport buttons were now labeled in French. > > Not tested: > * Funktionality of the buttons. > * Languages other than French. > > Update: > Tested "My Friends" tab of "People" floater (basic mode) in da, de, en, es, fr, it, ja, pl and pt: > Verified for each language that > * labels on all 4 buttons on that tab are translated (or as translated as in the XML files. "IM" seems to be the wanted label for the chat button in most of them.) > * tool-tips of all 4 buttons are translated > * all 4 buttons cause the action they're intended to cause when clicked > > > Thanks, > > Boroondas > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110725/ba0849a7/attachment.htm From vsavchuk at productengine.com Mon Jul 25 09:54:24 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Mon, 25 Jul 2011 16:54:24 -0000 Subject: [opensource-dev] Review Request: STORM-1233 Untranslated Profile button in the Places panel Message-ID: <20110725165424.22629.17407@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/415/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Made the button translatable by providing its layout stack with a unique name. This addresses bug STORM-1233. http://jira.secondlife.com/browse/STORM-1233 Diffs ----- indra/newview/skins/default/xui/da/panel_places.xml e59aaade1113 indra/newview/skins/default/xui/de/panel_places.xml e59aaade1113 indra/newview/skins/default/xui/en/panel_places.xml e59aaade1113 indra/newview/skins/default/xui/es/panel_places.xml e59aaade1113 indra/newview/skins/default/xui/fr/panel_places.xml e59aaade1113 indra/newview/skins/default/xui/it/panel_places.xml e59aaade1113 indra/newview/skins/default/xui/ja/panel_places.xml e59aaade1113 indra/newview/skins/default/xui/pl/panel_places.xml e59aaade1113 indra/newview/skins/default/xui/pt/panel_places.xml e59aaade1113 indra/newview/skins/default/xui/zh/panel_places.xml e59aaade1113 Diff: http://codereview.secondlife.com/r/415/diff Testing ------- Thanks, Vadim -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110725/36db31e7/attachment-0001.htm From sllists at boroon.dasgupta.ch Mon Jul 25 09:57:38 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Mon, 25 Jul 2011 16:57:38 -0000 Subject: [opensource-dev] Review Request: STORM-1403: ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button names in People pane In-Reply-To: <20110725145031.24989.5978@domU-12-31-38-00-90-68.compute-1.internal> References: <20110725145031.24989.5978@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110725165738.24989.26389@domU-12-31-38-00-90-68.compute-1.internal> > On July 25, 2011, 7:50 a.m., Vadim ProductEngine wrote: > > indra/newview/skins/minimal/xui/da/panel_people.xml, line 69 > > > > > > Missing rename here. > > Boroondas Gupte wrote: > For some reason I thought STORM-1403 was only about the "My Friends" tab of "People" floater, but re-reading the issue, it is indeed about all of the "People" floater, even thought the explicitly mentioned labels are all from the "My Friends" tab, so you are right that this element should have been renamed, too. Err ... wait ... this /is/ about the same 'My Friends' tab. (Sorry, it's a while ago I worked on this issue.) I did not rename this because I assumed that was the proper name for the layout_panel containing the im_btn, and that the following entries (for call and teleport) had duplicate names because they were copied from it. Looking at the name inconsistency, it might be that actually all 3 buttons have been copied from the group_chat_btn on the other tab. - Boroondas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/387/#review917 ----------------------------------------------------------- On July 18, 2011, 10:53 a.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/387/ > ----------------------------------------------------------- > > (Updated July 18, 2011, 10:53 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > The layout_panels containing the buttons didn't have unique names. > Renamed them so that their names are now unique within their parent > element. > > Removed the share_btn element and containing layout_panel from translations that contained it, as it doesn't occur in the English version. > > The English file mixed tabs and spaces. Converted tabs to spaces for that file. > > Stripped trailing whitespace from the English file. > > > This addresses bug STORM-1403. > http://jira.secondlife.com/browse/STORM-1403 > > > Diffs > ----- > > doc/contributions.txt 2204db549295 > indra/newview/skins/minimal/xui/da/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/de/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/en/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/es/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/fr/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/it/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/ja/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/pl/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/pt/panel_people.xml 2204db549295 > > Diff: http://codereview.secondlife.com/r/387/diff > > > Testing > ------- > > Switched to French, relogged, changed to default mode and logged out. Applied this patch with -p3 to SecondLife-i686-2.7.5.233393/ (I'm using a downloaded build, as I still cannot complete a build again.) > > Logged in, clicked 'Personnes' button, then 'MES AMIS' tab. The Call and Teleport buttons were now labeled in French. > > Not tested: > * Funktionality of the buttons. > * Languages other than French. > > Update: > Tested "My Friends" tab of "People" floater (basic mode) in da, de, en, es, fr, it, ja, pl and pt: > Verified for each language that > * labels on all 4 buttons on that tab are translated (or as translated as in the XML files. "IM" seems to be the wanted label for the chat button in most of them.) > * tool-tips of all 4 buttons are translated > * all 4 buttons cause the action they're intended to cause when clicked > > > Thanks, > > Boroondas > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110725/77a3644c/attachment.htm From sllists at boroon.dasgupta.ch Mon Jul 25 09:59:19 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Mon, 25 Jul 2011 16:59:19 -0000 Subject: [opensource-dev] Review Request: STORM-1404 Light viewer: untranslated buttons in the People panel In-Reply-To: <20110722175103.2253.33276@domU-12-31-38-00-90-68.compute-1.internal> References: <20110722175103.2253.33276@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110725165919.21535.92098@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/412/#review920 ----------------------------------------------------------- indra/newview/skins/minimal/xui/da/panel_people.xml share_btn doesn't occur (yet?/anymore?) in the English original, so I think it should be removed from the translations, too, to be consistent. (Ditto for languages other than 'da') - Boroondas On July 22, 2011, 10:51 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/412/ > ----------------------------------------------------------- > > (Updated July 22, 2011, 10:51 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Bug reason: incorrect reuse of an xml element name. > Fix: provided unique names for the buttons. > > > This addresses bug STORM-1404. > http://jira.secondlife.com/browse/STORM-1404 > > > Diffs > ----- > > indra/newview/skins/minimal/xui/da/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/de/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/en/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/es/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/fr/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/it/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/ja/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/pl/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/pt/panel_people.xml UNKNOWN > > Diff: http://codereview.secondlife.com/r/412/diff > > > Testing > ------- > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110725/871ee890/attachment.htm From vsavchuk at productengine.com Mon Jul 25 10:02:05 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Mon, 25 Jul 2011 17:02:05 -0000 Subject: [opensource-dev] Review Request: STORM-1404 Light viewer: untranslated buttons in the People panel In-Reply-To: <20110725165919.21535.92098@domU-12-31-38-00-90-68.compute-1.internal> References: <20110725165919.21535.92098@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110725170205.21535.96331@domU-12-31-38-00-90-68.compute-1.internal> > On July 25, 2011, 9:59 a.m., Boroondas Gupte wrote: > > indra/newview/skins/minimal/xui/da/panel_people.xml, lines 75-77 > > > > > > share_btn doesn't occur (yet?/anymore?) in the English original, so I think it should be removed from the translations, too, to be consistent. > > > > (Ditto for languages other than 'da') It's up to the translation team to remove obsolete translations. - Vadim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/412/#review920 ----------------------------------------------------------- On July 22, 2011, 10:51 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/412/ > ----------------------------------------------------------- > > (Updated July 22, 2011, 10:51 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Bug reason: incorrect reuse of an xml element name. > Fix: provided unique names for the buttons. > > > This addresses bug STORM-1404. > http://jira.secondlife.com/browse/STORM-1404 > > > Diffs > ----- > > indra/newview/skins/minimal/xui/da/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/de/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/en/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/es/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/fr/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/it/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/ja/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/pl/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/pt/panel_people.xml UNKNOWN > > Diff: http://codereview.secondlife.com/r/412/diff > > > Testing > ------- > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110725/1ab7683b/attachment-0001.htm From sllists at boroon.dasgupta.ch Mon Jul 25 10:04:55 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Mon, 25 Jul 2011 17:04:55 -0000 Subject: [opensource-dev] Review Request: STORM-1404 Light viewer: untranslated buttons in the People panel In-Reply-To: <20110722175103.2253.33276@domU-12-31-38-00-90-68.compute-1.internal> References: <20110722175103.2253.33276@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110725170455.21538.29428@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/412/#review923 ----------------------------------------------------------- Ship it! > It's up to the translation team to remove obsolete translations. In that case, no further concerns. Should we file a jira issue to make the translation team aware of the obsolete elements? - Boroondas On July 22, 2011, 10:51 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/412/ > ----------------------------------------------------------- > > (Updated July 22, 2011, 10:51 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Bug reason: incorrect reuse of an xml element name. > Fix: provided unique names for the buttons. > > > This addresses bug STORM-1404. > http://jira.secondlife.com/browse/STORM-1404 > > > Diffs > ----- > > indra/newview/skins/minimal/xui/da/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/de/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/en/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/es/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/fr/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/it/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/ja/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/pl/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/pt/panel_people.xml UNKNOWN > > Diff: http://codereview.secondlife.com/r/412/diff > > > Testing > ------- > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110725/ddbbde0a/attachment.htm From sllists at boroon.dasgupta.ch Mon Jul 25 10:20:36 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Mon, 25 Jul 2011 17:20:36 -0000 Subject: [opensource-dev] Review Request: STORM-1233 Untranslated Profile button in the Places panel In-Reply-To: <20110725165424.22629.17407@domU-12-31-38-00-90-68.compute-1.internal> References: <20110725165424.22629.17407@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110725172036.21541.87558@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/415/#review924 ----------------------------------------------------------- Ship it! - Boroondas On July 25, 2011, 9:54 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/415/ > ----------------------------------------------------------- > > (Updated July 25, 2011, 9:54 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Made the button translatable by providing its layout stack with a unique name. > > > This addresses bug STORM-1233. > http://jira.secondlife.com/browse/STORM-1233 > > > Diffs > ----- > > indra/newview/skins/default/xui/da/panel_places.xml e59aaade1113 > indra/newview/skins/default/xui/de/panel_places.xml e59aaade1113 > indra/newview/skins/default/xui/en/panel_places.xml e59aaade1113 > indra/newview/skins/default/xui/es/panel_places.xml e59aaade1113 > indra/newview/skins/default/xui/fr/panel_places.xml e59aaade1113 > indra/newview/skins/default/xui/it/panel_places.xml e59aaade1113 > indra/newview/skins/default/xui/ja/panel_places.xml e59aaade1113 > indra/newview/skins/default/xui/pl/panel_places.xml e59aaade1113 > indra/newview/skins/default/xui/pt/panel_places.xml e59aaade1113 > indra/newview/skins/default/xui/zh/panel_places.xml e59aaade1113 > > Diff: http://codereview.secondlife.com/r/415/diff > > > Testing > ------- > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110725/ef73b66c/attachment.htm From sllists at boroon.dasgupta.ch Mon Jul 25 10:44:06 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Mon, 25 Jul 2011 17:44:06 -0000 Subject: [opensource-dev] Review Request: STORM-1220 Region / Estate > Covenant - Type of region is in EN: "Estate / Full Region" In-Reply-To: <20110725143635.25768.33911@domU-12-31-38-00-90-68.compute-1.internal> References: <20110725143635.25768.33911@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110725174406.21535.38393@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/414/#review925 ----------------------------------------------------------- indra/newview/llfloaterland.cpp +1 for moving this re-occurring code into a method. :-) indra/newview/llfloaterland.cpp Is it save to remove this NULL-check? AFAIK getChild<...>() can fail. indra/newview/llfloaterregioninfo.cpp Is it save to remove this NULL-check? AFAIK getChild<...>() can fail. indra/newview/llviewerregion.h Can (and maybe should) be made private now. I don't think any other class has a valid reason to use the unlocalized name. Or just remove it, and use directly use mProductName in getLocalizedSimProductName(). - Boroondas On July 25, 2011, 7:36 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/414/ > ----------------------------------------------------------- > > (Updated July 25, 2011, 7:36 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Localized sim product name (e.g. "Estate / Full Region") everywhere. > > > This addresses bug STORM-1220. > http://jira.secondlife.com/browse/STORM-1220 > > > Diffs > ----- > > indra/newview/llfloaterbuyland.cpp UNKNOWN > indra/newview/llfloaterland.cpp UNKNOWN > indra/newview/llfloaterregioninfo.cpp UNKNOWN > indra/newview/llpanelplaceprofile.cpp UNKNOWN > indra/newview/llviewerregion.h UNKNOWN > indra/newview/llviewerregion.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/414/diff > > > Testing > ------- > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110725/babea7dd/attachment-0001.htm From vsavchuk at productengine.com Mon Jul 25 12:21:43 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Mon, 25 Jul 2011 19:21:43 -0000 Subject: [opensource-dev] Review Request: STORM-1404 Light viewer: untranslated buttons in the People panel In-Reply-To: <20110725170455.21538.29428@domU-12-31-38-00-90-68.compute-1.internal> References: <20110725170455.21538.29428@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110725192143.25764.88107@domU-12-31-38-00-90-68.compute-1.internal> > On July 25, 2011, 10:04 a.m., Boroondas Gupte wrote: > > > It's up to the translation team to remove obsolete translations. > > > > In that case, no further concerns. Should we file a jira issue to make the translation team aware of the obsolete elements? Not sure whether it makes sense. I'll find out. - Vadim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/412/#review923 ----------------------------------------------------------- On July 22, 2011, 10:51 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/412/ > ----------------------------------------------------------- > > (Updated July 22, 2011, 10:51 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Bug reason: incorrect reuse of an xml element name. > Fix: provided unique names for the buttons. > > > This addresses bug STORM-1404. > http://jira.secondlife.com/browse/STORM-1404 > > > Diffs > ----- > > indra/newview/skins/minimal/xui/da/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/de/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/en/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/es/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/fr/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/it/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/ja/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/pl/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/pt/panel_people.xml UNKNOWN > > Diff: http://codereview.secondlife.com/r/412/diff > > > Testing > ------- > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110725/ae8699e5/attachment.htm From vsavchuk at productengine.com Mon Jul 25 12:39:07 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Mon, 25 Jul 2011 19:39:07 -0000 Subject: [opensource-dev] Review Request: STORM-1220 Region / Estate > Covenant - Type of region is in EN: "Estate / Full Region" In-Reply-To: <20110725174406.21535.38393@domU-12-31-38-00-90-68.compute-1.internal> References: <20110725174406.21535.38393@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110725193907.25764.7155@domU-12-31-38-00-90-68.compute-1.internal> > On July 25, 2011, 10:44 a.m., Boroondas Gupte wrote: > > indra/newview/llfloaterland.cpp, lines 2885-2886 > > > > > > Is it save to remove this NULL-check? AFAIK getChild<...>() can fail. Yes. getChild() never returns NULL: if the view is not found, a dummy widget is created and returned. > On July 25, 2011, 10:44 a.m., Boroondas Gupte wrote: > > indra/newview/llviewerregion.h, line 195 > > > > > > Can (and maybe should) be made private now. I don't think any other class has a valid reason to use the unlocalized name. > > > > Or just remove it, and use directly use mProductName in getLocalizedSimProductName(). I can do it if you insist. However, I'm not sure that the sim product name is completely useless without translation. There is lots of stuff in the viewer not directly related to UI. - Vadim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/414/#review925 ----------------------------------------------------------- On July 25, 2011, 7:36 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/414/ > ----------------------------------------------------------- > > (Updated July 25, 2011, 7:36 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Localized sim product name (e.g. "Estate / Full Region") everywhere. > > > This addresses bug STORM-1220. > http://jira.secondlife.com/browse/STORM-1220 > > > Diffs > ----- > > indra/newview/llfloaterbuyland.cpp UNKNOWN > indra/newview/llfloaterland.cpp UNKNOWN > indra/newview/llfloaterregioninfo.cpp UNKNOWN > indra/newview/llpanelplaceprofile.cpp UNKNOWN > indra/newview/llviewerregion.h UNKNOWN > indra/newview/llviewerregion.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/414/diff > > > Testing > ------- > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110725/e5c3f28b/attachment.htm From sllists at boroon.dasgupta.ch Mon Jul 25 13:25:54 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Mon, 25 Jul 2011 20:25:54 -0000 Subject: [opensource-dev] Review Request: STORM-1220 Region / Estate > Covenant - Type of region is in EN: "Estate / Full Region" In-Reply-To: <20110725174406.21535.38393@domU-12-31-38-00-90-68.compute-1.internal> References: <20110725174406.21535.38393@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110725202554.22629.9048@domU-12-31-38-00-90-68.compute-1.internal> > On July 25, 2011, 10:44 a.m., Boroondas Gupte wrote: > > indra/newview/llviewerregion.h, line 195 > > > > > > Can (and maybe should) be made private now. I don't think any other class has a valid reason to use the unlocalized name. > > > > Or just remove it, and use directly use mProductName in getLocalizedSimProductName(). > > Vadim ProductEngine wrote: > I can do it if you insist. However, I'm not sure that the sim product name is completely useless without translation. There is lots of stuff in the viewer not directly related to UI. I certainly don't insist, merely suggest. As far as I have seen, after your change getSimProductName will only be used by getLocalizedSimProductName, so there is currently no other code needing it. I believe that any new code is more likely to need getLocalizedSimProductName than getSimProductName, so hiding the latter could avoid oversights. If someone knows he needs the unlocalized name (e.g. for logging, which we always do in English), they can still make getSimProductName public again, but has to make a conscious decision for that. If you considered this and decided getSimProductName should stay public for now, anyway, I'll trust your judgment on that. For avoiding people picking the wrong method, making getSimProductName private or removing it is of course not the only possibility. Renaming getSimProductName to getEnglishSimProductName or getUnlocalizedSimProductName and/or adding some doxigen documentation indicating what it will return would probably serve the same purpose well enough. - Boroondas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/414/#review925 ----------------------------------------------------------- On July 25, 2011, 7:36 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/414/ > ----------------------------------------------------------- > > (Updated July 25, 2011, 7:36 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Localized sim product name (e.g. "Estate / Full Region") everywhere. > > > This addresses bug STORM-1220. > http://jira.secondlife.com/browse/STORM-1220 > > > Diffs > ----- > > indra/newview/llfloaterbuyland.cpp UNKNOWN > indra/newview/llfloaterland.cpp UNKNOWN > indra/newview/llfloaterregioninfo.cpp UNKNOWN > indra/newview/llpanelplaceprofile.cpp UNKNOWN > indra/newview/llviewerregion.h UNKNOWN > indra/newview/llviewerregion.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/414/diff > > > Testing > ------- > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110725/77a2114d/attachment-0001.htm From vsavchuk at productengine.com Mon Jul 25 13:51:43 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Mon, 25 Jul 2011 20:51:43 -0000 Subject: [opensource-dev] Review Request: STORM-1220 Region / Estate > Covenant - Type of region is in EN: "Estate / Full Region" In-Reply-To: <20110725143635.25768.33911@domU-12-31-38-00-90-68.compute-1.internal> References: <20110725143635.25768.33911@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110725205143.21535.5180@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/414/ ----------------------------------------------------------- (Updated July 25, 2011, 1:51 p.m.) Review request for Viewer. Changes ------- Removed LLViewerRegion::getSimProductName() so that it doesn't mistakenly get used in UI code, thus causing localization bugs. Summary ------- Localized sim product name (e.g. "Estate / Full Region") everywhere. This addresses bug STORM-1220. http://jira.secondlife.com/browse/STORM-1220 Diffs (updated) ----- indra/newview/llfloaterbuyland.cpp e59aaade1113 indra/newview/llfloaterland.cpp e59aaade1113 indra/newview/llfloaterregioninfo.cpp e59aaade1113 indra/newview/llpanelplaceprofile.cpp e59aaade1113 indra/newview/llviewerregion.h e59aaade1113 indra/newview/llviewerregion.cpp e59aaade1113 Diff: http://codereview.secondlife.com/r/414/diff Testing ------- Thanks, Vadim -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110725/a2bb83a2/attachment.htm From sllists at boroon.dasgupta.ch Mon Jul 25 14:02:32 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Mon, 25 Jul 2011 21:02:32 -0000 Subject: [opensource-dev] Review Request: STORM-1220 Region / Estate > Covenant - Type of region is in EN: "Estate / Full Region" In-Reply-To: <20110725205143.21535.5180@domU-12-31-38-00-90-68.compute-1.internal> References: <20110725205143.21535.5180@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110725210232.22115.73873@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/414/#review929 ----------------------------------------------------------- Ship it! - Boroondas On July 25, 2011, 1:51 p.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/414/ > ----------------------------------------------------------- > > (Updated July 25, 2011, 1:51 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Localized sim product name (e.g. "Estate / Full Region") everywhere. > > > This addresses bug STORM-1220. > http://jira.secondlife.com/browse/STORM-1220 > > > Diffs > ----- > > indra/newview/llfloaterbuyland.cpp e59aaade1113 > indra/newview/llfloaterland.cpp e59aaade1113 > indra/newview/llfloaterregioninfo.cpp e59aaade1113 > indra/newview/llpanelplaceprofile.cpp e59aaade1113 > indra/newview/llviewerregion.h e59aaade1113 > indra/newview/llviewerregion.cpp e59aaade1113 > > Diff: http://codereview.secondlife.com/r/414/diff > > > Testing > ------- > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110725/6c59018b/attachment.htm From slitovchuk at productengine.com Tue Jul 26 05:52:36 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Tue, 26 Jul 2011 12:52:36 -0000 Subject: [opensource-dev] Review Request: STORM-565 llGiveInventory window is suppressed if avatar in Busy mode In-Reply-To: <20110725132944.21539.76098@domU-12-31-38-00-90-68.compute-1.internal> References: <20110725132944.21539.76098@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110726125236.24989.83644@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/413/#review930 ----------------------------------------------------------- Ship it! Looks good. - Seth On July 25, 2011, 6:29 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/413/ > ----------------------------------------------------------- > > (Updated July 25, 2011, 6:29 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Allow inventory offers from objects in Busy mode. > > > This addresses bug STORM-565. > http://jira.secondlife.com/browse/STORM-565 > > > Diffs > ----- > > indra/newview/llviewermessage.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/413/diff > > > Testing > ------- > > Tried inventory offers from objects and avatars in normal and busy modes. > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110726/018d196d/attachment.htm From Lance.Corrimal at eregion.de Tue Jul 26 06:34:17 2011 From: Lance.Corrimal at eregion.de (Lance Corrimal) Date: Tue, 26 Jul 2011 15:34:17 +0200 Subject: [opensource-dev] mesh upload? Message-ID: <401f663e7ed658a707801450ff246fe8.squirrel@eregion.kicks-ass.net> Hi gang, is there any news about mesh upload in OS-viewers? The last that I've found with google was a bit of discussion to the effect that "we need to find out what license bullet and that other lib are under", with no result... ... took me about 5 minutes with the websites and source code to see that bullet is under its own open source license which basically says "free to use for anyone for any purpose including alering it as long as you mention where it came from", and that other one by john ratcliffe is under MIT license which is basically the same... to my understanding. is anyone working on anything? From vsavchuk at productengine.com Tue Jul 26 08:32:16 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 26 Jul 2011 15:32:16 -0000 Subject: [opensource-dev] Review Request: STORM-1291 [STRING IN ENG] Gestos button. Many gestures. Message-ID: <20110726153216.21536.45436@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/416/ ----------------------------------------------------------- Review request for Viewer and Richard Nelson. Summary ------- Localize names of inventory items fetched via HTTP POST requests. These were not localized, unlike ones fetched via the message system. This addresses bug STORM-1291. http://jira.secondlife.com/browse/STORM-1291 Diffs ----- indra/newview/llviewerinventory.cpp 2f9a87538ca1 Diff: http://codereview.secondlife.com/r/416/diff Testing ------- Thanks, Vadim -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110726/dbb74cf2/attachment.htm From sllists at boroon.dasgupta.ch Tue Jul 26 08:45:35 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Tue, 26 Jul 2011 15:45:35 -0000 Subject: [opensource-dev] Review Request: STORM-1291 [STRING IN ENG] Gestos button. Many gestures. In-Reply-To: <20110726153216.21536.45436@domU-12-31-38-00-90-68.compute-1.internal> References: <20110726153216.21536.45436@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110726154535.24989.63726@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/416/#review931 ----------------------------------------------------------- Ship it! - Boroondas On July 26, 2011, 8:32 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/416/ > ----------------------------------------------------------- > > (Updated July 26, 2011, 8:32 a.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > ------- > > Localize names of inventory items fetched via HTTP POST requests. > > These were not localized, unlike ones fetched via the message system. > > > This addresses bug STORM-1291. > http://jira.secondlife.com/browse/STORM-1291 > > > Diffs > ----- > > indra/newview/llviewerinventory.cpp 2f9a87538ca1 > > Diff: http://codereview.secondlife.com/r/416/diff > > > Testing > ------- > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110726/679d2938/attachment-0001.htm From wolfpup67 at earthlink.net Tue Jul 26 09:09:06 2011 From: wolfpup67 at earthlink.net (WolfPup Lowenhar) Date: Tue, 26 Jul 2011 12:09:06 -0400 Subject: [opensource-dev] mesh upload? In-Reply-To: <401f663e7ed658a707801450ff246fe8.squirrel@eregion.kicks-ass.net> References: <401f663e7ed658a707801450ff246fe8.squirrel@eregion.kicks-ass.net> Message-ID: <001501cc4bae$58699950$093ccbf0$@net> Yes see https://jira.secondlife.com/browse/OPEN-105 that is tracking the work being done. > -----Original Message----- > From: opensource-dev-bounces at lists.secondlife.com [mailto:opensource-dev- > bounces at lists.secondlife.com] On Behalf Of Lance Corrimal > Sent: Tuesday, July 26, 2011 9:34 AM > To: opensource-dev at lists.secondlife.com > Subject: [opensource-dev] mesh upload? > > Hi gang, > > > is there any news about mesh upload in OS-viewers? > > The last that I've found with google was a bit of discussion to the effect that > "we need to > find out what license bullet and that other lib are under", with no result... > > ... took me about 5 minutes with the websites and source code to see that > bullet is under its > own open source license which basically says "free to use for anyone for any > purpose including > alering it as long as you mention where it came from", and that other one by > john ratcliffe is > under MIT license which is basically the same... to my understanding. > > is anyone working on anything? > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > ----- > No virus found in this message. > Checked by AVG - www.avg.com > Version: 10.0.1390 / Virus Database: 1518/3789 - Release Date: 07/26/11 From log at lindenlab.com Tue Jul 26 10:20:48 2011 From: log at lindenlab.com (Log Linden) Date: Tue, 26 Jul 2011 17:20:48 -0000 Subject: [opensource-dev] Review Request: STORM-1112 Support SOCKS 5 proxy in the viewer (take 2) In-Reply-To: <20110713205005.9625.26613@domU-12-31-38-00-90-68.compute-1.internal> References: <20110713205005.9625.26613@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110726172048.21536.92399@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/374/ ----------------------------------------------------------- (Updated July 26, 2011, 10:20 a.m.) Review request for Viewer, Oz Linden, Monty Brandenberg, and Stone Linden. Changes ------- Added proxy support to other places libcurl is used in the viewer. This is still a WIP, but I wanted to update to match what is available on bitbucket. Summary ------- This is a continuation of Robin Cornelius's SOCKS 5 contribution, shown in https://codereview.secondlife.com/r/232/ . I have tried to address all of the comments on that code review and do as much cleanup as possible. The diff includes everything that was submitted by Robin, as well as my work. Major changes since I started working: * Changed SOCKS 5 proxy control channel to use the existing LLSocket class, which is a thin wrapper around APR sockets. * Worked with the Linden Lab UX team to revamp the proxy controls. * Proxy credentials are now stored in the LLSecAPI password storage, which is the same that is used for users' Second Life Credentials instead of as being stored in the clear as a preference. This addresses bug STORM-1112. http://jira.secondlife.com/browse/STORM-1112 Diffs (updated) ----- indra/llcommon/llsingleton.h 216ebc0442d2 indra/llmessage/CMakeLists.txt 216ebc0442d2 indra/llmessage/llcurl.h 216ebc0442d2 indra/llmessage/llcurl.cpp 216ebc0442d2 indra/llmessage/llhttpassetstorage.cpp 216ebc0442d2 indra/llmessage/llhttpclient.cpp 216ebc0442d2 indra/llmessage/lliosocket.h 216ebc0442d2 indra/llmessage/lliosocket.cpp 216ebc0442d2 indra/llmessage/llpacketring.h 216ebc0442d2 indra/llmessage/llpacketring.cpp 216ebc0442d2 indra/llmessage/llproxy.h PRE-CREATION indra/llmessage/llproxy.cpp PRE-CREATION indra/llmessage/llurlrequest.cpp 216ebc0442d2 indra/llmessage/net.h 216ebc0442d2 indra/llmessage/net.cpp 216ebc0442d2 indra/llui/llfunctorregistry.h 216ebc0442d2 indra/newview/app_settings/settings.xml 216ebc0442d2 indra/newview/llappviewer.cpp 216ebc0442d2 indra/newview/llfloaterpreference.h 216ebc0442d2 indra/newview/llfloaterpreference.cpp 216ebc0442d2 indra/newview/llloginhandler.cpp 216ebc0442d2 indra/newview/llpanellogin.h 216ebc0442d2 indra/newview/llsecapi.h 216ebc0442d2 indra/newview/llstartup.h 216ebc0442d2 indra/newview/llstartup.cpp 216ebc0442d2 indra/newview/llviewerfloaterreg.cpp 216ebc0442d2 indra/newview/llxmlrpctransaction.cpp 216ebc0442d2 indra/newview/skins/default/xui/en/floater_preferences_proxy.xml PRE-CREATION indra/newview/skins/default/xui/en/notifications.xml 216ebc0442d2 indra/newview/skins/default/xui/en/panel_cof_wearables.xml 216ebc0442d2 indra/newview/skins/default/xui/en/panel_preferences_privacy.xml 216ebc0442d2 indra/newview/skins/default/xui/en/panel_preferences_setup.xml 216ebc0442d2 Diff: http://codereview.secondlife.com/r/374/diff Testing ------- I've tested exclusively on Linux so far. I'm working on a more extensive test plan that includes setting up a gateway with a restrictive firewall to verify that all traffic is going through the proxy. Test builds and screenshots of the changed UI elements are available from the project page, located here: https://wiki.secondlife.com/wiki/User:Log_Linden/Socks5Viewer Thanks, Log -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110726/644f2e09/attachment.htm From LockwoodN at mst.edu Tue Jul 26 11:51:59 2011 From: LockwoodN at mst.edu (Lockwood, Nick) Date: Tue, 26 Jul 2011 13:51:59 -0500 Subject: [opensource-dev] Return drawable/object at mouse point Message-ID: <6212FB22FD17584D90840DD8370D7B374874C8@mst-vmail01.srv.mst.edu> I'm writing some code for a research project to log the object at a particular point on the screen (using mouse coordinates). So far I've made use of the LLViewerWindow::cursorIntersect function which seems to work pretty well. However, I can't seem to capture certain things like the sky, clouds, water, etc. Is there a way that I can capture everything being rendered in the scene? I was hoping it is possible to capture a particular drawable being displayed at a given point. Then, I should be able to get the object associated with that drawable as well as the render type. I just haven't figured out an easy way to do that yet. Are there any functions I'm missing, or does anyone have a suggestion as to how I can capture these data? Thanks! Nick -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110726/96b05dc4/attachment.htm From vsavchuk at productengine.com Tue Jul 26 14:02:10 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 26 Jul 2011 21:02:10 -0000 Subject: [opensource-dev] Review Request: STORM-1405 Untranslated items in Sound Devices drop-down list Message-ID: <20110726210210.21539.90759@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/417/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Localized the "No Device" and "Default System Device" strings in the sound devices panel. By the way: * Fixed improper localization of the "Default" device name which caused saving a localized string in settings. * Eliminated redundant getChild() calls. This addresses bug STORM-1405. http://jira.secondlife.com/browse/STORM-1405 Diffs ----- indra/newview/llpanelvoicedevicesettings.h 2f9a87538ca1 indra/newview/llpanelvoicedevicesettings.cpp 2f9a87538ca1 indra/newview/skins/default/xui/en/panel_sound_devices.xml 2f9a87538ca1 Diff: http://codereview.secondlife.com/r/417/diff Testing ------- Thanks, Vadim -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110726/7c5faf99/attachment.htm From vsavchuk at productengine.com Tue Jul 26 14:25:39 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 26 Jul 2011 21:25:39 -0000 Subject: [opensource-dev] Review Request: STORM-1404 Light viewer: untranslated buttons in the People panel In-Reply-To: <20110725170455.21538.29428@domU-12-31-38-00-90-68.compute-1.internal> References: <20110725170455.21538.29428@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110726212539.21541.94301@domU-12-31-38-00-90-68.compute-1.internal> > On July 25, 2011, 10:04 a.m., Boroondas Gupte wrote: > > > It's up to the translation team to remove obsolete translations. > > > > In that case, no further concerns. Should we file a jira issue to make the translation team aware of the obsolete elements? > > Vadim ProductEngine wrote: > Not sure whether it makes sense. I'll find out. So, their localization tool does detect obsolete translations, but only when the "en" file changes. If you want to get rid of them earlier, please feel free to file a jira. - Vadim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/412/#review923 ----------------------------------------------------------- On July 22, 2011, 10:51 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/412/ > ----------------------------------------------------------- > > (Updated July 22, 2011, 10:51 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Bug reason: incorrect reuse of an xml element name. > Fix: provided unique names for the buttons. > > > This addresses bug STORM-1404. > http://jira.secondlife.com/browse/STORM-1404 > > > Diffs > ----- > > indra/newview/skins/minimal/xui/da/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/de/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/en/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/es/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/fr/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/it/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/ja/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/pl/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/pt/panel_people.xml UNKNOWN > > Diff: http://codereview.secondlife.com/r/412/diff > > > Testing > ------- > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110726/7b844901/attachment.htm From vsavchuk at productengine.com Tue Jul 26 14:40:49 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 26 Jul 2011 21:40:49 -0000 Subject: [opensource-dev] Review Request: STORM-1529 Sound Devices floater is too narrow for its widgets Message-ID: <20110726214049.25768.72863@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/418/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Made the Sound Devices floater wider. It still doesn't look very nice (probable needs redesign), but the widgets fit and work. This addresses bug STORM-1529. http://jira.secondlife.com/browse/STORM-1529 Diffs ----- indra/newview/skins/default/xui/en/floater_sound_devices.xml 2f9a87538ca1 Diff: http://codereview.secondlife.com/r/418/diff Testing ------- Thanks, Vadim -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110726/62438790/attachment.htm From vsavchuk at productengine.com Tue Jul 26 14:43:14 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 26 Jul 2011 21:43:14 -0000 Subject: [opensource-dev] Review Request: STORM-1529 Sound Devices floater is too narrow for its widgets In-Reply-To: <20110726214049.25768.72863@domU-12-31-38-00-90-68.compute-1.internal> References: <20110726214049.25768.72863@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110726214314.21539.21371@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/418/ ----------------------------------------------------------- (Updated July 26, 2011, 2:43 p.m.) Review request for Viewer. Changes ------- typo Summary (updated) ------- Made the Sound Devices floater wider. It still doesn't look very nice (probably needs redesign), but the widgets fit and work. This addresses bug STORM-1529. http://jira.secondlife.com/browse/STORM-1529 Diffs ----- indra/newview/skins/default/xui/en/floater_sound_devices.xml 2f9a87538ca1 Diff: http://codereview.secondlife.com/r/418/diff Testing ------- Thanks, Vadim -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110726/84f0f499/attachment.htm From sllists at boroon.dasgupta.ch Tue Jul 26 16:18:55 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Wed, 27 Jul 2011 01:18:55 +0200 Subject: [opensource-dev] Quick test of open-38 integration In-Reply-To: <4E2982DE.6090506@lindenlab.com> References: <4E2982DE.6090506@lindenlab.com> Message-ID: <4E2F4B5F.3040804@boroon.dasgupta.ch> On 07/22/2011 04:02 PM, Oz Linden (Scott Lawrence) wrote: > I'm planning to integrate the changes from > > https://codereview.secondlife.com/r/167/ > > to better support standalone builds. > > I've done a test (non-standalone) build in our build farm, which appears > to have completed successfully. I'd appreciate it if a few users would > run the resulting viewers: > > http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_project-1/rev/236387/index.html > > and let me know if anything is broken (that is not broken in a beta or > development build). I have used this build for a while now and haven't notice any problems except some that I could also repro in http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/snowstorm_viewer-development/rev/23638*8*/index.html (which is a regular viewer-dev build without the OPEN-38 changes) Cheers, Boroondas -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110727/77266b46/attachment.htm From lee.ponzu at gmail.com Wed Jul 27 07:14:45 2011 From: lee.ponzu at gmail.com (Lee ponzu) Date: Wed, 27 Jul 2011 10:14:45 -0400 Subject: [opensource-dev] Latest mesh Viewer... Message-ID: I downloaded the latest mesh viewer today. It crashes every five or ten minutes or so. I know it is the latest build blah blah blah..I just wanted to let people know. Process: Second Life [17049] Path: /Applications/Viewers/Project Viewer - Mesh.app/Contents/MacOS/Second Life Identifier: com.secondlife.indra.viewer Version: Second Life version 2.8.2.236932 (2.8.2.236932) Code Type: X86 (Native) Parent Process: launchd [200] Date/Time: 2011-07-27 09:58:49.099 -0400 OS Version: Mac OS X 10.6.8 (10K540) Report Version: 6 Interval Since Last Report: 892568 sec Crashes Since Last Report: 4 Per-App Interval Since Last Report: 2495 sec Per-App Crashes Since Last Report: 3 Anonymous UUID: 18404959-AFD8-476A-807F-8B2EE7A368F6 Exception Type: EXC_CRASH (SIGQUIT) Exception Codes: 0x0000000000000000, 0x0000000000000000 Crashed Thread: 1 Dispatch queue: com.apple.libdispatch-manager Thread 0: Dispatch queue: com.apple.main-thread 0 libSystem.B.dylib 0x94718c5a __kill + 10 1 libSystem.B.dylib 0x94718c4c kill$UNIX2003 + 32 2 libSystem.B.dylib 0x947ab5a5 raise + 26 3 libllcommon.dylib 0x04964480 default_unix_signal_handler(int, __siginfo*, void*) + 432 4 libSystem.B.dylib 0x9471e05b _sigtramp + 43 5 libSystem.B.dylib 0x946e3f56 wait4 + 10 6 libSystem.B.dylib 0x947455e5 pclose + 215 7 libllcommon.dylib 0x04a323de LLMemoryInfo::loadStatsMap() + 3598 8 libllcommon.dylib 0x04a33763 LLMemoryInfo::refresh() + 35 9 libllcommon.dylib 0x04a3f1ee FrameWatcher::tick(LLSD const&) + 606 10 libllcommon.dylib 0x04a346d2 boost::detail::function::function_obj_invoker1, boost::_bi::list2, boost::arg<1> > >, bool, LLSD const&>::invoke(boost::detail::function::function_buffer&, LLSD const&) + 82 11 com.secondlife.indra.viewer 0x0175e589 boost::signals2::detail::signal1_impl, boost::function, boost::function, boost::signals2::mutex>::slot_invoker::m_invoke(boost::shared_ptr >, boost::signals2::slot1 >, boost::signals2::mutex> > const&, ...) const + 57 12 com.secondlife.indra.viewer 0x0175e84d boost::signals2::detail::signal1_impl, boost::function, boost::function, boost::signals2::mutex>::operator()(LLSD const&) + 525 13 libllcommon.dylib 0x049a61df LLEventStream::post(LLSD const&) + 63 14 com.secondlife.indra.viewer 0x000ddc0d LLAppViewer::mainLoop() + 1453 15 com.secondlife.indra.viewer 0x01350978 main + 568 16 com.secondlife.indra.viewer 0x000093b6 start + 54 Thread 1 Crashed: Dispatch queue: com.apple.libdispatch-manager 0 libSystem.B.dylib 0x946de382 kevent + 10 1 libSystem.B.dylib 0x946dea9c _dispatch_mgr_invoke + 215 2 libSystem.B.dylib 0x946ddf59 _dispatch_queue_invoke + 163 3 libSystem.B.dylib 0x946ddcfe _dispatch_worker_thread2 + 240 4 libSystem.B.dylib 0x946dd781 _pthread_wqthread + 390 5 libSystem.B.dylib 0x946dd5c6 start_wqthread + 30 Thread 2: 0 libSystem.B.dylib 0x946b7afa mach_msg_trap + 10 1 libSystem.B.dylib 0x946b8267 mach_msg + 68 2 libexception_handler.dylib 0x04d26bcd google_breakpad::ExceptionHandler::WaitForMessage(void*) + 125 3 libSystem.B.dylib 0x946e5259 _pthread_start + 345 4 libSystem.B.dylib 0x946e50de thread_start + 34 Thread 3: 0 libSystem.B.dylib 0x946e5aa2 __semwait_signal + 10 1 libSystem.B.dylib 0x946e575e _pthread_cond_wait + 1191 2 libSystem.B.dylib 0x946e73f8 pthread_cond_wait$UNIX2003 + 73 3 libapr-1.0.dylib 0x04d658a7 apr_thread_cond_wait + 30 4 libllcommon.dylib 0x04a40e61 LLThread::checkPause() + 177 5 libllcommon.dylib 0x049e0c4b LLQueuedThread::run() + 139 6 libllcommon.dylib 0x04a3fed2 LLThread::staticRun(apr_thread_t*, void*) + 18 7 libapr-1.0.dylib 0x04d7455e dummy_worker + 36 8 libSystem.B.dylib 0x946e5259 _pthread_start + 345 9 libSystem.B.dylib 0x946e50de thread_start + 34 Thread 4: 0 libSystem.B.dylib 0x946e5aa2 __semwait_signal + 10 1 libSystem.B.dylib 0x946e575e _pthread_cond_wait + 1191 2 libSystem.B.dylib 0x946e73f8 pthread_cond_wait$UNIX2003 + 73 3 libapr-1.0.dylib 0x04d658a7 apr_thread_cond_wait + 30 4 libllcommon.dylib 0x04a40e61 LLThread::checkPause() + 177 5 libllcommon.dylib 0x049e0c4b LLQueuedThread::run() + 139 6 libllcommon.dylib 0x04a3fed2 LLThread::staticRun(apr_thread_t*, void*) + 18 7 libapr-1.0.dylib 0x04d7455e dummy_worker + 36 8 libSystem.B.dylib 0x946e5259 _pthread_start + 345 9 libSystem.B.dylib 0x946e50de thread_start + 34 Thread 5: 0 libSystem.B.dylib 0x946e5aa2 __semwait_signal + 10 1 libSystem.B.dylib 0x946e575e _pthread_cond_wait + 1191 2 libSystem.B.dylib 0x946e73f8 pthread_cond_wait$UNIX2003 + 73 3 libapr-1.0.dylib 0x04d658a7 apr_thread_cond_wait + 30 4 libllcommon.dylib 0x04a40e61 LLThread::checkPause() + 177 5 libllcommon.dylib 0x049e0c4b LLQueuedThread::run() + 139 6 libllcommon.dylib 0x04a3fed2 LLThread::staticRun(apr_thread_t*, void*) + 18 7 libapr-1.0.dylib 0x04d7455e dummy_worker + 36 8 libSystem.B.dylib 0x946e5259 _pthread_start + 345 9 libSystem.B.dylib 0x946e50de thread_start + 34 Thread 6: 0 libSystem.B.dylib 0x946e5aa2 __semwait_signal + 10 1 libSystem.B.dylib 0x946e575e _pthread_cond_wait + 1191 2 libSystem.B.dylib 0x946e73f8 pthread_cond_wait$UNIX2003 + 73 3 libapr-1.0.dylib 0x04d658a7 apr_thread_cond_wait + 30 4 libllcommon.dylib 0x04a40984 LLCondition::wait() + 68 5 com.secondlife.indra.viewer 0x008f9528 LLPhysicsDecomp::run() + 696 6 libllcommon.dylib 0x04a3fed2 LLThread::staticRun(apr_thread_t*, void*) + 18 7 libapr-1.0.dylib 0x04d7455e dummy_worker + 36 8 libSystem.B.dylib 0x946e5259 _pthread_start + 345 9 libSystem.B.dylib 0x946e50de thread_start + 34 Thread 7: 0 libSystem.B.dylib 0x946e5aa2 __semwait_signal + 10 1 libSystem.B.dylib 0x946e575e _pthread_cond_wait + 1191 2 libSystem.B.dylib 0x946e73f8 pthread_cond_wait$UNIX2003 + 73 3 libapr-1.0.dylib 0x04d658a7 apr_thread_cond_wait + 30 4 libllcommon.dylib 0x04a40984 LLCondition::wait() + 68 5 com.secondlife.indra.viewer 0x0090e911 LLMeshRepoThread::run() + 81 6 libllcommon.dylib 0x04a3fed2 LLThread::staticRun(apr_thread_t*, void*) + 18 7 libapr-1.0.dylib 0x04d7455e dummy_worker + 36 8 libSystem.B.dylib 0x946e5259 _pthread_start + 345 9 libSystem.B.dylib 0x946e50de thread_start + 34 Thread 8: 0 libSystem.B.dylib 0x946b7afa mach_msg_trap + 10 1 libSystem.B.dylib 0x946b8267 mach_msg + 68 2 com.apple.opengl 0x980b215e glcDebugListener + 426 3 libSystem.B.dylib 0x946e5259 _pthread_start + 345 4 libSystem.B.dylib 0x946e50de thread_start + 34 Thread 9: 0 libSystem.B.dylib 0x946b7afa mach_msg_trap + 10 1 libSystem.B.dylib 0x946b8267 mach_msg + 68 2 com.apple.CoreFoundation 0x924dc30f __CFRunLoopRun + 2079 3 com.apple.CoreFoundation 0x924db3f4 CFRunLoopRunSpecific + 452 4 com.apple.CoreFoundation 0x924e1334 CFRunLoopRun + 84 5 libndofdev.dylib 0x04b8c7ba ndof_hotplug_loop + 137 6 ...ple.CoreServices.CarbonCore 0x948d754a PrivateMPEntryPoint + 68 7 libSystem.B.dylib 0x946e5259 _pthread_start + 345 8 libSystem.B.dylib 0x946e50de thread_start + 34 Thread 10: 0 libSystem.B.dylib 0x946b7afa mach_msg_trap + 10 1 libSystem.B.dylib 0x946b8267 mach_msg + 68 2 ....audio_hijack_server.hermes 0x05b453a3 ah_serv_loop + 161 3 libSystem.B.dylib 0x946e5259 _pthread_start + 345 4 libSystem.B.dylib 0x946e50de thread_start + 34 Thread 11: 0 libSystem.B.dylib 0x946b7b5a semaphore_timedwait_signal_trap + 10 1 libSystem.B.dylib 0x946e56e1 _pthread_cond_wait + 1066 2 libSystem.B.dylib 0x947145a8 pthread_cond_timedwait_relative_np + 47 3 com.apple.audio.CoreAudio 0x9735a3ab CAGuard::WaitFor(unsigned long long) + 219 4 com.apple.audio.CoreAudio 0x9735d3dd CAGuard::WaitUntil(unsigned long long) + 289 5 com.apple.audio.CoreAudio 0x9735acda HP_IOThread::WorkLoop() + 1892 6 com.apple.audio.CoreAudio 0x9735a571 HP_IOThread::ThreadEntry(HP_IOThread*) + 17 7 com.apple.audio.CoreAudio 0x9735a488 CAPThread::Entry(CAPThread*) + 140 8 libSystem.B.dylib 0x946e5259 _pthread_start + 345 9 libSystem.B.dylib 0x946e50de thread_start + 34 Thread 12: 0 libSystem.B.dylib 0x946b7c0e mach_wait_until + 10 1 ...ple.CoreServices.CarbonCore 0x9497b7f0 MPDelayUntil + 43 2 libfmodwrapper.dylib 0x04bc6e40 FSOUND_Time_Sleep + 65 3 libfmodwrapper.dylib 0x04ba0fad FSOUND_Stream_UpdateThread + 138 4 ...ple.CoreServices.CarbonCore 0x948d754a PrivateMPEntryPoint + 68 5 libSystem.B.dylib 0x946e5259 _pthread_start + 345 6 libSystem.B.dylib 0x946e50de thread_start + 34 Thread 13: 0 libSystem.B.dylib 0x946dd412 __workq_kernreturn + 10 1 libSystem.B.dylib 0x946dd9a8 _pthread_wqthread + 941 2 libSystem.B.dylib 0x946dd5c6 start_wqthread + 30 Thread 1 crashed with X86 Thread State (32-bit): eax: 0x00000004 ebx: 0x946de9d6 ecx: 0xb0080d5c edx: 0x946de382 edi: 0xa05721ec esi: 0xb0080ed8 ebp: 0xb0080ef8 esp: 0xb0080d5c ss: 0x0000001f efl: 0x00000247 eip: 0x946de382 cs: 0x00000007 ds: 0x0000001f es: 0x0000001f fs: 0x0000001f gs: 0x00000037 cr2: 0x0061e000 Binary Images: 0x1000 - 0x2c1bfff +com.secondlife.indra.viewer Second Life version 2.8.2.236932 (2.8.2.236932) <880B8085-F825-9C41-D38B-D7EA8B620C90> /Applications/Viewers/Project Viewer - Mesh.app/Contents/MacOS/Second Life 0x4556000 - 0x47befe7 +libcollada14dom.dylib 2.2.0 (compatibility 2.2.0) <90575608-7CC7-EBAF-5340-A099968CF879> /Applications/Viewers/Project Viewer - Mesh.app/Contents/Resources/libcollada14dom.dylib 0x495a000 - 0x4a9afff +libllcommon.dylib ??? (???) <04788C66-9D39-8596-E672-8EA967227CC4> /Applications/Viewers/Project Viewer - Mesh.app/Contents/Resources/libllcommon.dylib 0x4b7e000 - 0x4b8dffd +libndofdev.dylib ??? (???) <87B1AD1D-538A-4616-389C-F693B6928B8F> /Applications/Viewers/Project Viewer - Mesh.app/Contents/Resources/libndofdev.dylib 0x4b92000 - 0x4bdafe7 +libfmodwrapper.dylib ??? (???) <36FA3062-F59D-317D-A0A9-56234B0FDE1A> /Applications/Viewers/Project Viewer - Mesh.app/Contents/Resources/libfmodwrapper.dylib 0x4c28000 - 0x4c8aff6 +libGLOD.dylib ??? (???) <970711AA-EEF2-39A1-9B47-4ECFFBD6CB80> /Applications/Viewers/Project Viewer - Mesh.app/Contents/Resources/libGLOD.dylib 0x4cf4000 - 0x4d19ffb +libexpat.1.5.2.dylib 7.2.0 (compatibility 7.0.0) /Applications/Viewers/Project Viewer - Mesh.app/Contents/Resources/libexpat.1.5.2.dylib 0x4d21000 - 0x4d2efe6 +libexception_handler.dylib ??? (???) /Applications/Viewers/Project Viewer - Mesh.app/Contents/Resources/libexception_handler.dylib 0x4d36000 - 0x4d4fff3 +libaprutil-1.0.dylib 4.10.0 (compatibility 4.0.0) /Applications/Viewers/Project Viewer - Mesh.app/Contents/Resources/libaprutil-1.0.dylib 0x4d59000 - 0x4d77fef +libapr-1.0.dylib 5.2.0 (compatibility 5.0.0) <4E2B143A-10FA-BE8A-9B04-AB14506BF8AB> /Applications/Viewers/Project Viewer - Mesh.app/Contents/Resources/libapr-1.0.dylib 0x4d83000 - 0x4e38fe7 libcrypto.0.9.7.dylib 0.9.7 (compatibility 0.9.7) <0B69B1F5-3440-B0BF-957F-E0ADD49F13CB> /usr/lib/libcrypto.0.9.7.dylib 0x5b40000 - 0x5b4cff7 +com.rogueamoeba.audio_hijack_server.hermes 2.2.8 (2.2.8) /usr/local/hermes/modules/Instant Hijack Server.hermesmodule/Contents/MacOS/Instant Hijack Server 0x5fce000 - 0x5ff2fe7 GLRendererFloat ??? (???) /System/Library/Frameworks/OpenGL.framework/Resources/GLRendererFloat.bundle/GLRendererFloat 0x17f1f000 - 0x18098ff7 GLEngine ??? (???) <64C74F67-44B5-7DEF-CCA6-C8A9FF9BB60A> /System/Library/Frameworks/OpenGL.framework/Resources/GLEngine.bundle/GLEngine 0x195f5000 - 0x19a08fef com.apple.ATIRadeonX2000GLDriver 1.6.36 (6.3.6) <257CAA1D-6573-2932-E344-E96F6C9CDA84> /System/Library/Extensions/ATIRadeonX2000GLDriver.bundle/Contents/MacOS/ATIRadeonX2000GLDriver 0x1fb19000 - 0x1fb26ff7 com.apple.iokit.IOHIDLib 1.6.6 (1.6.6) <665A3308-8C50-655A-ED3F-49AF695A408E> /System/Library/Extensions/IOHIDFamily.kext/Contents/PlugIns/IOHIDLib.plugin/Contents/MacOS/IOHIDLib 0x24d2b000 - 0x24d2fff3 com.apple.audio.AudioIPCPlugIn 1.1.6 (1.1.6) /System/Library/Extensions/AudioIPCDriver.kext/Contents/Resources/AudioIPCPlugIn.bundle/Contents/MacOS/AudioIPCPlugIn 0x24d34000 - 0x24d3aff7 com.apple.audio.AppleHDAHALPlugIn 2.0.5 (2.0.5f13) <76BC9284-582A-EF9A-960D-5CD0801B1917> /System/Library/Extensions/AppleHDA.kext/Contents/PlugIns/AppleHDAHALPlugIn.bundle/Contents/MacOS/AppleHDAHALPlugIn 0x29da5000 - 0x29de6fe3 com.apple.audio.SoundManager.Components 3.9.4 (3.9.4) /System/Library/Components/SoundManagerComponents.component/Contents/MacOS/SoundManagerComponents 0x2c532000 - 0x2c59ffff +com.DivXInc.DivXDecoder 6.6.0 (6.6.0) /Library/QuickTime/DivX Decoder.component/Contents/MacOS/DivX Decoder 0x2c5ae000 - 0x2c5eafe3 com.apple.QuickTimeFireWireDV.component 7.6.6 (1783) <9D242689-A430-BD2D-3CF0-3AC6F6CCD1D9> /System/Library/QuickTime/QuickTimeFireWireDV.component/Contents/MacOS/QuickTimeFireWireDV 0x2c800000 - 0x2c88efff +net.sourceforge.webcam-osx.common 0.8.8 (0.8.8) /Library/QuickTime/macam.component/Contents/MacOS/macam 0x3e000000 - 0x3e046ff7 com.apple.glut 3.4.4 (GLUT-3.4.4) /System/Library/Frameworks/GLUT.framework/Versions/A/GLUT 0x8fe00000 - 0x8fe4162b dyld 132.1 (???) /usr/lib/dyld 0x90003000 - 0x900ddfff com.apple.DesktopServices 1.5.11 (1.5.11) <800F2040-9211-81A7-B438-7712BF51DEE3> /System/Library/PrivateFrameworks/DesktopServicesPriv.framework/Versions/A/DesktopServicesPriv 0x90e90000 - 0x90fbefe7 com.apple.CoreData 102.1 (251) /System/Library/Frameworks/CoreData.framework/Versions/A/CoreData 0x90fbf000 - 0x90ff9ff7 libcups.2.dylib 2.8.0 (compatibility 2.0.0) <038731B1-CC44-3943-E3DE-4BAAA203EB72> /usr/lib/libcups.2.dylib 0x90ffa000 - 0x9100bff7 com.apple.LangAnalysis 1.6.6 (1.6.6) <97511CC7-FE23-5AC3-2EE2-B5479FAEB316> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis 0x9100c000 - 0x91422ff7 libBLAS.dylib 219.0.0 (compatibility 1.0.0) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib 0x91423000 - 0x914bbfe7 edu.mit.Kerberos 6.5.11 (6.5.11) /System/Library/Frameworks/Kerberos.framework/Versions/A/Kerberos 0x9153a000 - 0x91bb5ff7 com.apple.CoreAUC 6.11.03 (6.11.03) <42B31B0F-18F9-29D2-A67C-7B81A47F6D67> /System/Library/PrivateFrameworks/CoreAUC.framework/Versions/A/CoreAUC 0x91bb6000 - 0x91bf3ff7 com.apple.CoreMedia 0.484.52 (484.52) <62B0C876-A931-372F-8947-7CBA0379F427> /System/Library/PrivateFrameworks/CoreMedia.framework/Versions/A/CoreMedia 0x91bf4000 - 0x91c27fff libTrueTypeScaler.dylib ??? (???) <0F04DAC3-829A-FA1B-E9D0-1E9505713C5C> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/Resources/libTrueTypeScaler.dylib 0x91c28000 - 0x91d29fe7 libxml2.2.dylib 10.3.0 (compatibility 10.0.0) /usr/lib/libxml2.2.dylib 0x91d2a000 - 0x921e5ff7 com.apple.VideoToolbox 0.484.52 (484.52) /System/Library/PrivateFrameworks/VideoToolbox.framework/Versions/A/VideoToolbox 0x92238000 - 0x9249eff7 com.apple.security 6.1.2 (55002) <64A20CEB-E614-D35F-7B9F-246BCB25BA23> /System/Library/Frameworks/Security.framework/Versions/A/Security 0x9249f000 - 0x9261afe7 com.apple.CoreFoundation 6.6.5 (550.43) <10B8470A-88B7-FC74-1C2F-E5CBD966C051> /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation 0x9262b000 - 0x926dbfe3 com.apple.QuickTimeImporters.component 7.6.6 (1783) /System/Library/QuickTime/QuickTimeImporters.component/Contents/MacOS/QuickTimeImporters 0x926dc000 - 0x92717feb libFontRegistry.dylib ??? (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/Resources/libFontRegistry.dylib 0x92718000 - 0x92737ff7 com.apple.CoreVideo 1.6.2 (45.6) /System/Library/Frameworks/CoreVideo.framework/Versions/A/CoreVideo 0x92738000 - 0x92743ff7 libCSync.A.dylib 545.0.0 (compatibility 64.0.0) <287DECA3-7821-32B6-724D-AE03A9A350F9> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libCSync.A.dylib 0x92971000 - 0x92983ff7 com.apple.MultitouchSupport.framework 207.11 (207.11) <6FF4F2D6-B8CD-AE13-56CB-17437EE5B741> /System/Library/PrivateFrameworks/MultitouchSupport.framework/Versions/A/MultitouchSupport 0x92984000 - 0x92a16fe7 com.apple.print.framework.PrintCore 6.3 (312.7) <7410D1B2-655D-68DA-D4B9-2C65747B6817> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore 0x92a22000 - 0x92a22ff7 com.apple.CoreServices 44 (44) <51CFA89A-33DB-90ED-26A8-67D461718A4A> /System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices 0x92a23000 - 0x92a24ff7 com.apple.audio.units.AudioUnit 1.6.7 (1.6.7) <838E1760-F7D9-3239-B3A8-20E25EFD1379> /System/Library/Frameworks/AudioUnit.framework/Versions/A/AudioUnit 0x92a31000 - 0x92a31ff7 liblangid.dylib ??? (???) /usr/lib/liblangid.dylib 0x92a32000 - 0x92a3cfe7 com.apple.audio.SoundManager 3.9.3 (3.9.3) <5F494955-7290-2D91-DA94-44B590191771> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CarbonSound.framework/Versions/A/CarbonSound 0x92a3d000 - 0x92b31ff7 libiconv.2.dylib 7.0.0 (compatibility 7.0.0) <9EC28185-D26F-533F-90C4-FBAA13A15947> /usr/lib/libiconv.2.dylib 0x92b33000 - 0x92b5bff7 libxslt.1.dylib 3.24.0 (compatibility 3.0.0) <315D97C2-4E1F-A95F-A759-4A3FA5639E75> /usr/lib/libxslt.1.dylib 0x92c19000 - 0x92c2dfe7 libbsm.0.dylib ??? (???) <14CB053A-7C47-96DA-E415-0906BA1B78C9> /usr/lib/libbsm.0.dylib 0x92ca4000 - 0x92ca9ff7 com.apple.OpenDirectory 10.6 (10.6) /System/Library/Frameworks/OpenDirectory.framework/Versions/A/OpenDirectory 0x92cb8000 - 0x92d05feb com.apple.DirectoryService.PasswordServerFramework 6.1 (6.1) <136BFA48-D456-B677-3B5D-40A6946C3A09> /System/Library/PrivateFrameworks/PasswordServer.framework/Versions/A/PasswordServer 0x92d06000 - 0x92ec8feb com.apple.ImageIO.framework 3.0.4 (3.0.4) <20E90968-E04B-7B68-DBA2-92C729A8243F> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/ImageIO 0x92ec9000 - 0x92f64fe7 com.apple.ApplicationServices.ATS 275.16 (???) <873C8B8A-B563-50F7-7628-524EE9E8DF0F> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS 0x935ac000 - 0x939e1ff7 libLAPACK.dylib 219.0.0 (compatibility 1.0.0) <5E2D2283-57DE-9A49-1DB0-CD027FEFA6C2> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libLAPACK.dylib 0x939e2000 - 0x93a01fe3 libexpat.1.dylib 7.2.0 (compatibility 7.0.0) <82E6F83F-9667-2E39-1D9D-4A49C642527D> /usr/lib/libexpat.1.dylib 0x93a02000 - 0x93a04ff7 com.apple.securityhi 4.0 (36638) <38D36D4D-C798-6ACE-5FA8-5C001993AD6B> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI 0x93a0a000 - 0x93e5bfef com.apple.RawCamera.bundle 3.7.1 (570) /System/Library/CoreServices/RawCamera.bundle/Contents/MacOS/RawCamera 0x93e5c000 - 0x93e5dff7 com.apple.TrustEvaluationAgent 1.1 (1) <6C04C4C5-667E-2EBE-EB96-5B67BD4B2185> /System/Library/PrivateFrameworks/TrustEvaluationAgent.framework/Versions/A/TrustEvaluationAgent 0x93e5e000 - 0x93e64fe7 com.apple.CommerceCore 1.0 (9.1) <521D067B-3BDA-D04E-E1FA-CFA526C87EB5> /System/Library/PrivateFrameworks/CommerceKit.framework/Versions/A/Frameworks/CommerceCore.framework/Versions/A/CommerceCore 0x93e65000 - 0x93f45fe7 com.apple.vImage 4.1 (4.1) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vImage.framework/Versions/A/vImage 0x93f46000 - 0x93fa3ff7 com.apple.framework.IOKit 2.0 (???) <3DABAB9C-4949-F441-B077-0498F8E47A35> /System/Library/Frameworks/IOKit.framework/Versions/A/IOKit 0x93fa4000 - 0x94052ff3 com.apple.ink.framework 1.3.3 (107) <57B54F6F-CE35-D546-C7EC-DBC5FDC79938> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink 0x94053000 - 0x94086ff7 com.apple.AE 496.5 (496.5) /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE 0x94087000 - 0x94140fe7 libsqlite3.dylib 9.6.0 (compatibility 9.0.0) <52438E77-55D1-C231-1936-76F1369518E4> /usr/lib/libsqlite3.dylib 0x942ad000 - 0x9435afe7 libobjc.A.dylib 227.0.0 (compatibility 1.0.0) <9F8413A6-736D-37D9-8EB3-7986D4699957> /usr/lib/libobjc.A.dylib 0x94587000 - 0x9458afe7 libmathCommon.A.dylib 315.0.0 (compatibility 1.0.0) <1622A54F-1A98-2CBE-B6A4-2122981A500E> /usr/lib/system/libmathCommon.A.dylib 0x9458b000 - 0x9458bff7 com.apple.Accelerate.vecLib 3.6 (vecLib 3.6) <1DEC639C-173D-F808-DE0D-4070CC6F5BC7> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/vecLib 0x9458c000 - 0x9458fffb com.apple.help 1.3.2 (41.1) <8AC20B01-4A3B-94BA-D8AF-E39034B97D8C> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help 0x946b7000 - 0x9485eff7 libSystem.B.dylib 125.2.11 (compatibility 1.0.0) <2DCD13E3-1BD1-6F25-119A-3863A3848B90> /usr/lib/libSystem.B.dylib 0x948b1000 - 0x94bd1ff3 com.apple.CoreServices.CarbonCore 861.39 (861.39) <5C59805C-AF39-9010-B8B5-D673C9C38538> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore 0x94bd2000 - 0x94bd8fff com.apple.CommonPanels 1.2.4 (91) <2438AF5D-067B-B9FD-1248-2C9987F360BA> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels 0x94bd9000 - 0x94ce5ff7 libGLProgrammability.dylib ??? (???) <04D7E5C3-B0C3-054B-DF49-3B333DCDEE22> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLProgrammability.dylib 0x94e82000 - 0x94ec6ff3 com.apple.coreui 2 (114) <29F8F1A4-1C96-6A0F-4CC2-9B85CF83209F> /System/Library/PrivateFrameworks/CoreUI.framework/Versions/A/CoreUI 0x94eee000 - 0x94efaff7 libkxld.dylib ??? (???) <9A441C48-2D18-E716-5F38-CBEAE6A0BB3E> /usr/lib/system/libkxld.dylib 0x94efb000 - 0x94efbff7 com.apple.vecLib 3.6 (vecLib 3.6) <7362077A-890F-3AEF-A8AB-22247B10E106> /System/Library/Frameworks/vecLib.framework/Versions/A/vecLib 0x94efc000 - 0x95e4eff7 com.apple.QuickTimeComponents.component 7.6.6 (1783) /System/Library/QuickTime/QuickTimeComponents.component/Contents/MacOS/QuickTimeComponents 0x95eca000 - 0x95f95fef com.apple.CoreServices.OSServices 359 (359) /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices 0x95f96000 - 0x95fe9ff7 com.apple.HIServices 1.8.3 (???) <1D3C4587-6318-C339-BD0F-1988F246BE2E> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices 0x95fea000 - 0x96127fe7 com.apple.audio.toolbox.AudioToolbox 1.6.7 (1.6.7) <2D31CC6F-32CC-72FF-34EC-AB40CEE496A7> /System/Library/Frameworks/AudioToolbox.framework/Versions/A/AudioToolbox 0x9616e000 - 0x9618afe3 com.apple.openscripting 1.3.1 (???) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting 0x9618b000 - 0x96228fe3 com.apple.LaunchServices 362.3 (362.3) <15B47388-16C8-97DA-EEBB-1709E136169E> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices 0x96229000 - 0x9654dfef com.apple.HIToolbox 1.6.5 (???) <21164164-41CE-61DE-C567-32E89755CB34> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox 0x96736000 - 0x96739ff7 libCGXType.A.dylib 545.0.0 (compatibility 64.0.0) <4D766435-EB76-C384-0127-1D20ACD74076> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libCGXType.A.dylib 0x9673c000 - 0x96f2b557 com.apple.CoreGraphics 1.545.0 (???) <1D9DC7A5-228B-42CB-7018-66F42C3A9BB3> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics 0x96f4e000 - 0x96fc9fff com.apple.AppleVAFramework 4.10.26 (4.10.26) /System/Library/PrivateFrameworks/AppleVA.framework/Versions/A/AppleVA 0x96fca000 - 0x96febfe7 com.apple.opencl 12.3.6 (12.3.6) /System/Library/Frameworks/OpenCL.framework/Versions/A/OpenCL 0x96fec000 - 0x96ff0ff7 libGFXShared.dylib ??? (???) <801B2C2C-1692-475A-BAD6-99F85B6E7C25> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGFXShared.dylib 0x9703a000 - 0x9703dff7 libCoreVMClient.dylib ??? (???) /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libCoreVMClient.dylib 0x9733a000 - 0x973b4fff com.apple.audio.CoreAudio 3.2.6 (3.2.6) <156A532C-0B60-55B0-EE27-D02B82AA6217> /System/Library/Frameworks/CoreAudio.framework/Versions/A/CoreAudio 0x973b5000 - 0x973c9ffb com.apple.speech.synthesis.framework 3.10.35 (3.10.35) <57DD5458-4F24-DA7D-0927-C3321A65D743> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis 0x974c6000 - 0x9757efeb libFontParser.dylib ??? (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/Resources/libFontParser.dylib 0x97586000 - 0x978f1ff7 com.apple.QuartzCore 1.6.3 (227.37) /System/Library/Frameworks/QuartzCore.framework/Versions/A/QuartzCore 0x97906000 - 0x9791eff7 com.apple.CFOpenDirectory 10.6 (10.6) /System/Library/Frameworks/OpenDirectory.framework/Versions/A/Frameworks/CFOpenDirectory.framework/Versions/A/CFOpenDirectory 0x9791f000 - 0x9791fff7 com.apple.Accelerate 1.6 (Accelerate 1.6) /System/Library/Frameworks/Accelerate.framework/Versions/A/Accelerate 0x97920000 - 0x97a22fe7 libcrypto.0.9.8.dylib 0.9.8 (compatibility 0.9.8) <015563C4-81E2-8C8A-82AC-31B38D904A42> /usr/lib/libcrypto.0.9.8.dylib 0x97a76000 - 0x97ac6ff7 com.apple.framework.familycontrols 2.0.2 (2020) /System/Library/PrivateFrameworks/FamilyControls.framework/Versions/A/FamilyControls 0x97eed000 - 0x97ef7ffb com.apple.speech.recognition.framework 3.11.1 (3.11.1) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition 0x97ef8000 - 0x97f3aff7 libvDSP.dylib 268.0.1 (compatibility 1.0.0) <3F0ED200-741B-4E27-B89F-634B131F5E9E> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libvDSP.dylib 0x9803e000 - 0x980adff7 libvMisc.dylib 268.0.1 (compatibility 1.0.0) <2FC2178F-FEF9-6E3F-3289-A6307B1A154C> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libvMisc.dylib 0x980ae000 - 0x980bcff7 com.apple.opengl 1.6.13 (1.6.13) <025A905D-C1A3-B24A-1585-37C328D77148> /System/Library/Frameworks/OpenGL.framework/Versions/A/OpenGL 0x980d1000 - 0x98118ffb com.apple.CoreMediaIOServices 140.0 (1496) /System/Library/PrivateFrameworks/CoreMediaIOServices.framework/Versions/A/CoreMediaIOServices 0x98119000 - 0x98413fef com.apple.QuickTime 7.6.6 (1783) <1EC8DC5E-12E3-1DB8-1F7D-44C6EF193C58> /System/Library/Frameworks/QuickTime.framework/Versions/A/QuickTime 0x98414000 - 0x98457ff7 com.apple.NavigationServices 3.5.4 (182) <753B8906-06C0-3AE0-3D6A-8FF5AC18ED12> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/NavigationServices.framework/Versions/A/NavigationServices 0x98458000 - 0x984d8feb com.apple.SearchKit 1.3.0 (1.3.0) <9E18AEA5-F4B4-8BE5-EEA9-818FC4F46FD9> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit 0x98563000 - 0x985a7fe7 com.apple.Metadata 10.6.3 (507.15) <460BEF23-B89F-6F4C-4940-45556C0671B5> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata 0x9865f000 - 0x9867ffe7 libresolv.9.dylib 41.0.0 (compatibility 1.0.0) <751955F3-21FB-A03A-4E92-1F3D4EFB8C5B> /usr/lib/libresolv.9.dylib 0x98680000 - 0x986c6ff7 libauto.dylib ??? (???) <29422A70-87CF-10E2-CE59-FEE1234CFAAE> /usr/lib/libauto.dylib 0x98722000 - 0x98753ff7 libGLImage.dylib ??? (???) <0EE86397-A867-0BBA-E5B1-B800E43FC5CF> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLImage.dylib 0x9876a000 - 0x9878eff7 libJPEG.dylib ??? (???) <0C406884-DAAF-0409-2659-9D1602D752D9> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libJPEG.dylib 0x9878f000 - 0x987a4fff com.apple.ImageCapture 6.1 (6.1) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture 0x987a5000 - 0x987b0ff7 libGL.dylib ??? (???) <3E34468F-E9A7-8EFB-FF66-5204BD5B4E21> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.dylib 0x98810000 - 0x98853ff7 libGLU.dylib ??? (???) /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.dylib 0x98854000 - 0x9885bff7 com.apple.agl 3.0.12 (AGL-3.0.12) <6877F0D8-0DCF-CB98-5304-913667FF50FA> /System/Library/Frameworks/AGL.framework/Versions/A/AGL 0x9895e000 - 0x98ae0fe7 libicucore.A.dylib 40.0.0 (compatibility 1.0.0) /usr/lib/libicucore.A.dylib 0x98ae1000 - 0x98ae5ff7 IOSurface ??? (???) /System/Library/Frameworks/IOSurface.framework/Versions/A/IOSurface 0x98ae6000 - 0x98aedff3 com.apple.print.framework.Print 6.1 (237.1) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print 0x98aee000 - 0x98b70ffb SecurityFoundation ??? (???) <3670AE8B-06DA-C447-EB14-79423DB9C474> /System/Library/Frameworks/SecurityFoundation.framework/Versions/A/SecurityFoundation 0x98b71000 - 0x98cb4fef com.apple.QTKit 7.7 (1783) <0C6814E2-98C2-74F4-770F-BA355CA86F0F> /System/Library/Frameworks/QTKit.framework/Versions/A/QTKit 0x9930f000 - 0x99580fef com.apple.Foundation 6.6.7 (751.62) <5C995C7F-2EA9-50DC-9F2A-30237CDB31B1> /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation 0x995f0000 - 0x99ed3ff7 com.apple.AppKit 6.6.8 (1038.36) /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit 0x99f17000 - 0x99f25fe7 libz.1.dylib 1.2.3 (compatibility 1.0.0) <3CE8AA79-F077-F1B0-A039-9103A4A02E92> /usr/lib/libz.1.dylib 0x99f27000 - 0x99f34ff7 com.apple.NetFS 3.2.2 (3.2.2) /System/Library/Frameworks/NetFS.framework/Versions/A/NetFS 0x9a0d7000 - 0x9a0dbff7 libGIF.dylib ??? (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libGIF.dylib 0x9a161000 - 0x9a187ffb com.apple.DictionaryServices 1.1.2 (1.1.2) <43E1D565-6E01-3681-F2E5-72AE4C3A097A> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices 0x9a188000 - 0x9a198ff7 libsasl2.2.dylib 3.15.0 (compatibility 3.0.0) /usr/lib/libsasl2.2.dylib 0x9a199000 - 0x9a1daff7 libRIP.A.dylib 545.0.0 (compatibility 64.0.0) <80998F66-0AD7-AD12-B9AF-3E8D2CE6DE05> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libRIP.A.dylib 0x9a1db000 - 0x9a1dbff7 com.apple.Cocoa 6.6 (???) /System/Library/Frameworks/Cocoa.framework/Versions/A/Cocoa 0x9a1dc000 - 0x9a1f7ff7 libPng.dylib ??? (???) <4C105512-6FA8-2AE0-D058-6A8AA00F9DA1> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libPng.dylib 0x9a205000 - 0x9a2c1fff com.apple.ColorSync 4.6.6 (4.6.6) <7CD8B191-039A-02C3-EA5E-4194EC59995B> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSync.framework/Versions/A/ColorSync 0x9a2c2000 - 0x9a323fe7 com.apple.CoreText 151.10 (???) <5C2DEFBE-D54B-4DC7-D456-9ED02880BE98> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreText.framework/Versions/A/CoreText 0x9a324000 - 0x9a324ff7 com.apple.ApplicationServices 38 (38) <8012B504-3D83-BFBB-DA65-065E061CFE03> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/ApplicationServices 0x9a325000 - 0x9a325ff7 com.apple.Carbon 150 (152) <9252D5F2-462D-2C15-80F3-109644D6F704> /System/Library/Frameworks/Carbon.framework/Versions/A/Carbon 0x9a326000 - 0x9a390fe7 libstdc++.6.dylib 7.9.0 (compatibility 7.0.0) <411D87F4-B7E1-44EB-F201-F8B4F9227213> /usr/lib/libstdc++.6.dylib 0x9a3aa000 - 0x9a3e7ff7 com.apple.SystemConfiguration 1.10.8 (1.10.2) <50E4D49B-4F61-446F-1C21-1B2BA814713D> /System/Library/Frameworks/SystemConfiguration.framework/Versions/A/SystemConfiguration 0x9a3e8000 - 0x9a40afef com.apple.DirectoryService.Framework 3.6 (621.11) /System/Library/Frameworks/DirectoryService.framework/Versions/A/DirectoryService 0x9a40b000 - 0x9a46fffb com.apple.htmlrendering 72 (1.1.4) <4D451A35-FAB6-1288-71F6-F24A4B6E2371> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HTMLRendering.framework/Versions/A/HTMLRendering 0x9a58a000 - 0x9a593ff7 com.apple.DiskArbitration 2.3 (2.3) /System/Library/Frameworks/DiskArbitration.framework/Versions/A/DiskArbitration 0x9a7ac000 - 0x9a7f5fe7 libTIFF.dylib ??? (???) <10F7E21B-EC59-6594-004F-798DA3F37789> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libTIFF.dylib 0x9a7f6000 - 0x9a8a2fe7 com.apple.CFNetwork 454.12.4 (454.12.4) /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork 0x9a8c2000 - 0x9a96affb com.apple.QD 3.36 (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD 0x9a9ea000 - 0x9a9ecff7 libRadiance.dylib ??? (???) <47E300B5-DBEF-86C4-29BD-86DBEDD2FBB5> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libRadiance.dylib 0x9aa00000 - 0x9ab2dffb com.apple.MediaToolbox 0.484.52 (484.52) /System/Library/PrivateFrameworks/MediaToolbox.framework/Versions/A/MediaToolbox 0xffff0000 - 0xffff1fff libSystem.B.dylib ??? (???) <2DCD13E3-1BD1-6F25-119A-3863A3848B90> /usr/lib/libSystem.B.dylib Model: iMac7,1, BootROM IM71.007A.B03, 2 processors, Intel Core 2 Duo, 2.4 GHz, 3 GB, SMC 1.20f4 Graphics: ATI Radeon HD 2600 Pro, ATI,RadeonHD2600, PCIe, 256 MB Memory Module: global_name AirPort: spairport_wireless_card_type_airport_extreme (0x14E4, 0x88), Broadcom BCM43xx 1.0 (5.10.131.42.4) Bluetooth: Version 2.4.5f3, 2 service, 19 devices, 1 incoming serial ports Network Service: AirPort, AirPort, en1 Serial ATA Device: WDC WD3200AAJS-40RYA0, 298.09 GB Parallel ATA Device: ?P?I?R? D?D R? ?D-5630A USB Device: Keyboard Hub, 0x05ac (Apple Inc.), 0x1006, 0xfa400000 / 2 USB Device: Apple Optical USB Mouse, 0x05ac (Apple Inc.), 0x0304, 0xfa430000 / 4 USB Device: Apple Keyboard, 0x05ac (Apple Inc.), 0x0220, 0xfa420000 / 3 USB Device: Built-in iSight, 0x05ac (Apple Inc.), 0x8502, 0xfd400000 / 3 USB Device: USB2.0 Hub, 0x05e3 (Genesys Logic, Inc.), 0x0606, 0xfd100000 / 2 USB Device: USB Mass Storage Device, 0x13fd (Initio Corporation), 0x0841, 0xfd120000 / 4 USB Device: Bluetooth USB Host Controller, 0x05ac (Apple Inc.), 0x8206, 0x1a100000 / 2 USB Device: IR Receiver, 0x05ac (Apple Inc.), 0x8242, 0x5d100000 / 2 -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110727/354e86bb/attachment-0001.htm From lee.ponzu at gmail.com Wed Jul 27 07:22:23 2011 From: lee.ponzu at gmail.com (Lee ponzu) Date: Wed, 27 Jul 2011 10:22:23 -0400 Subject: [opensource-dev] Python broken on Lion - autobuild doesn't work In-Reply-To: References: <48385D90-9E76-4A45-A873-C1DF2768E583@madonie.org> Message-ID: On Sun, Jul 24, 2011 at 2:12 PM, Stone Linden wrote: > > We continue to use Xcode 3.2 at LL and haven't started testing under 4.1 or > 4.2 yet. You're welcome to try, but you'll be on your own! > > Cheers, > Stone > > > ...and be careful when you do this...When you install Xcode 4, it wants to put everything in /Developer where Xcode 3 and all the supporting stuff is already. Be sure to investigate how to keep both Xcode 3 and 4 co-existing on the same machine, or keep them separate. ponzu -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110727/56c26de1/attachment.htm From oz at lindenlab.com Wed Jul 27 12:41:44 2011 From: oz at lindenlab.com (Oz Linden) Date: Wed, 27 Jul 2011 19:41:44 -0000 Subject: [opensource-dev] Review Request: OPEN-54: Making CMake variable name for JsonCpp include dir(s) consistent In-Reply-To: <20110408114110.23400.5557@domU-12-31-38-00-90-68.compute-1.internal> References: <20110408114110.23400.5557@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110727194144.22642.27133@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/257/#review933 ----------------------------------------------------------- Ship it! - Oz On April 8, 2011, 4:41 a.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/257/ > ----------------------------------------------------------- > > (Updated April 8, 2011, 4:41 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Chose the singular form as that seems to be what most of the Find*.cmake files use for their *_INCLUDE_DIR[S] variables. > > > This addresses bug OPEN-54. > http://jira.secondlife.com/browse/OPEN-54 > > > Diffs > ----- > > doc/contributions.txt 9ff8625cadec > indra/cmake/JsonCpp.cmake 9ff8625cadec > indra/newview/CMakeLists.txt 9ff8625cadec > > Diff: http://codereview.secondlife.com/r/257/diff > > > Testing > ------- > > None, except for grep'ing around to make sure there's now only a single name for this. > > > Thanks, > > Boroondas > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110727/e83d43c0/attachment.htm From ardylay at gmail.com Wed Jul 27 20:52:30 2011 From: ardylay at gmail.com (ardylay at gmail.com) Date: Thu, 28 Jul 2011 03:52:30 -0000 Subject: [opensource-dev] Review Request: /me emote doubles name in chat history Message-ID: <20110728035230.21541.92631@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/419/ ----------------------------------------------------------- Review request for Viewer. Summary ------- As a resident of Second Life I find the displaying an emoter's name twice in nearby chat history rather unnecessary. Please lay eyes on this proposed code change and let me know what you think. I took care to remove the unlinked sender name instead of the linked one. This addresses bug VWR-26393. http://jira.secondlife.com/browse/VWR-26393 Diffs ----- indra/newview/llchathistory.cpp 2f9a87538ca1 Diff: http://codereview.secondlife.com/r/419/diff Testing ------- Tell a crowd what you are testing and many will start talking to you prefixed with /me, if they are good sports. I have been using this change for 3 days now and have not noticed any ill effects. Please note: This changest is not intended to affect nearby chat toasts, nearby chat log files, IM history, IM toasts or IM log files. Thanks, ardy.lay -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110728/6337cbc7/attachment.htm From sllists at boroon.dasgupta.ch Thu Jul 28 02:58:58 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Thu, 28 Jul 2011 09:58:58 -0000 Subject: [opensource-dev] Review Request: /me emote doubles name in chat history In-Reply-To: <20110728035230.21541.92631@domU-12-31-38-00-90-68.compute-1.internal> References: <20110728035230.21541.92631@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110728095858.21538.18595@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/419/#review934 ----------------------------------------------------------- indra/newview/llchathistory.cpp Yay for removing redundant code! Was irc_me even set correctly before your change, or did this only work due to the || chat.mChatStyle == CHAT_STYLE_IRC part? indra/newview/llchathistory.cpp As you cut away a substring of the length of chat.mFrontName, I assume chat.mText contains the content of chat.mFrontName at the beginning, not "/me " or "/me'"? chat.mText doesn't seem to have been modified since (old) line 747, so I guess the comparison you removed there was nonsense, anyway? Btw., where does mFromName get added to the beginning of mText? Wouldn't it be better to not add it in the first place rather than cutting it away again here? - Boroondas On July 27, 2011, 8:52 p.m., ardy.lay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/419/ > ----------------------------------------------------------- > > (Updated July 27, 2011, 8:52 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > As a resident of Second Life I find the displaying an emoter's name twice in nearby chat history rather unnecessary. Please lay eyes on this proposed code change and let me know what you think. > > I took care to remove the unlinked sender name instead of the linked one. > > > This addresses bug VWR-26393. > http://jira.secondlife.com/browse/VWR-26393 > > > Diffs > ----- > > indra/newview/llchathistory.cpp 2f9a87538ca1 > > Diff: http://codereview.secondlife.com/r/419/diff > > > Testing > ------- > > Tell a crowd what you are testing and many will start talking to you prefixed with /me, if they are good sports. I have been using this change for 3 days now and have not noticed any ill effects. Please note: This changest is not intended to affect nearby chat toasts, nearby chat log files, IM history, IM toasts or IM log files. > > > Thanks, > > ardy.lay > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110728/e5c5a344/attachment-0001.htm From oz at lindenlab.com Thu Jul 28 07:13:13 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Thu, 28 Jul 2011 10:13:13 -0400 Subject: [opensource-dev] Snowstorm Product Owner Review build Message-ID: <4E316E79.80608@lindenlab.com> http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_viewer-poreview/rev/237151/index.html a couple of these may be spurious - they were mentioned in commit comments for other issues and so show up in the list. I'm going to be lazy and not attempt to filter them out. STORM-320 Script Editor in Viewer 2.0+ "tabs" incorrectly STORM-519 "Delete" is enabled in the context menu for folders which contain worn items STORM-565 llGiveInventory window is suppressed if avatar in Busy mode STORM-1220 Region / Estate > Covenant - Type of region is in EN: "Estate / Full Region" STORM-1233 [TRANSLATED BUT IN EN] "Profile" button and tooltip appear untranslated at the bottom of the "Places" sidepanel pages (French viewer) STORM-1234 In Nearby Chat, Group Chat and IM Chat, URL selection frequently fails to grab last character STORM-1291 (Spanish) [STRING IN ENG] Gestos button. Many gestures. STORM-1311 Place Profile only shows 2 lines and users have to click More link to see full description STORM-1404 ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button labels and tooltips in People pane STORM-1405 [HARDCODED] Light Viewer - Untranslated items in Sound Devices drop-down list STORM-1408 [DE] Text truncation in Edit outfit floater STORM-1451 [DA] "Login failed" message is empty in Danish STORM-1458 [crashhunters] crash at LLParticipantList::LLParticipantListMenu::isGroupModerator() [secondlife-bin llparticipantlist.cpp] STORM-1474 Implement Show Last Search in viewer chrome STORM-1529 Sound Devices floater is too narrow for its widgets -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110728/de21a73f/attachment.htm From log at lindenlab.com Thu Jul 28 11:06:19 2011 From: log at lindenlab.com (Log Linden) Date: Thu, 28 Jul 2011 18:06:19 -0000 Subject: [opensource-dev] Review Request: STORM-1112 Support SOCKS 5 proxy in the viewer (take 2) In-Reply-To: <20110726172048.21536.92399@domU-12-31-38-00-90-68.compute-1.internal> References: <20110726172048.21536.92399@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110728180619.8798.35532@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/374/ ----------------------------------------------------------- (Updated July 28, 2011, 11:06 a.m.) Review request for Viewer, Oz Linden, Monty Brandenberg, and Stone Linden. Changes ------- More cleanup to address Monty's comments. More fixes to come. Summary ------- This is a continuation of Robin Cornelius's SOCKS 5 contribution, shown in https://codereview.secondlife.com/r/232/ . I have tried to address all of the comments on that code review and do as much cleanup as possible. The diff includes everything that was submitted by Robin, as well as my work. Major changes since I started working: * Changed SOCKS 5 proxy control channel to use the existing LLSocket class, which is a thin wrapper around APR sockets. * Worked with the Linden Lab UX team to revamp the proxy controls. * Proxy credentials are now stored in the LLSecAPI password storage, which is the same that is used for users' Second Life Credentials instead of as being stored in the clear as a preference. This addresses bug STORM-1112. http://jira.secondlife.com/browse/STORM-1112 Diffs (updated) ----- indra/llcommon/llsingleton.h 2f9a87538ca1 indra/llmessage/CMakeLists.txt 2f9a87538ca1 indra/llmessage/llcurl.h 2f9a87538ca1 indra/llmessage/llcurl.cpp 2f9a87538ca1 indra/llmessage/llhttpassetstorage.cpp 2f9a87538ca1 indra/llmessage/llhttpclient.cpp 2f9a87538ca1 indra/llmessage/lliosocket.h 2f9a87538ca1 indra/llmessage/lliosocket.cpp 2f9a87538ca1 indra/llmessage/llpacketring.h 2f9a87538ca1 indra/llmessage/llpacketring.cpp 2f9a87538ca1 indra/llmessage/llproxy.h PRE-CREATION indra/llmessage/llproxy.cpp PRE-CREATION indra/llmessage/llurlrequest.cpp 2f9a87538ca1 indra/llmessage/net.h 2f9a87538ca1 indra/llmessage/net.cpp 2f9a87538ca1 indra/llui/llfunctorregistry.h 2f9a87538ca1 indra/newview/app_settings/settings.xml 2f9a87538ca1 indra/newview/llappviewer.cpp 2f9a87538ca1 indra/newview/llfloaterpreference.h 2f9a87538ca1 indra/newview/llfloaterpreference.cpp 2f9a87538ca1 indra/newview/llloginhandler.cpp 2f9a87538ca1 indra/newview/llpanellogin.h 2f9a87538ca1 indra/newview/llsecapi.h 2f9a87538ca1 indra/newview/llstartup.h 2f9a87538ca1 indra/newview/llstartup.cpp 2f9a87538ca1 indra/newview/llviewerfloaterreg.cpp 2f9a87538ca1 indra/newview/llxmlrpctransaction.cpp 2f9a87538ca1 indra/newview/skins/default/xui/en/floater_preferences_proxy.xml PRE-CREATION indra/newview/skins/default/xui/en/notifications.xml 2f9a87538ca1 indra/newview/skins/default/xui/en/panel_cof_wearables.xml 2f9a87538ca1 indra/newview/skins/default/xui/en/panel_preferences_privacy.xml 2f9a87538ca1 indra/newview/skins/default/xui/en/panel_preferences_setup.xml 2f9a87538ca1 Diff: http://codereview.secondlife.com/r/374/diff Testing ------- I've tested exclusively on Linux so far. I'm working on a more extensive test plan that includes setting up a gateway with a restrictive firewall to verify that all traffic is going through the proxy. Test builds and screenshots of the changed UI elements are available from the project page, located here: https://wiki.secondlife.com/wiki/User:Log_Linden/Socks5Viewer Thanks, Log -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110728/d109515f/attachment.htm From slitovchuk at productengine.com Thu Jul 28 12:45:27 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Thu, 28 Jul 2011 19:45:27 -0000 Subject: [opensource-dev] Review Request: STORM-1529 Sound Devices floater is too narrow for its widgets In-Reply-To: <20110726214314.21539.21371@domU-12-31-38-00-90-68.compute-1.internal> References: <20110726214314.21539.21371@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110728194527.22115.40181@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/418/#review935 ----------------------------------------------------------- Ship it! The code looks perfect. No remarks, no objections. - Seth On July 26, 2011, 2:43 p.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/418/ > ----------------------------------------------------------- > > (Updated July 26, 2011, 2:43 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Made the Sound Devices floater wider. > It still doesn't look very nice (probably needs redesign), but the widgets fit and work. > > > This addresses bug STORM-1529. > http://jira.secondlife.com/browse/STORM-1529 > > > Diffs > ----- > > indra/newview/skins/default/xui/en/floater_sound_devices.xml 2f9a87538ca1 > > Diff: http://codereview.secondlife.com/r/418/diff > > > Testing > ------- > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110728/423becab/attachment.htm From slitovchuk at productengine.com Thu Jul 28 12:56:41 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Thu, 28 Jul 2011 19:56:41 -0000 Subject: [opensource-dev] Review Request: STORM-1405 Untranslated items in Sound Devices drop-down list In-Reply-To: <20110726210210.21539.90759@domU-12-31-38-00-90-68.compute-1.internal> References: <20110726210210.21539.90759@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110728195641.21540.36847@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/417/#review936 ----------------------------------------------------------- Ship it! Looks good to me. - Seth On July 26, 2011, 2:02 p.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/417/ > ----------------------------------------------------------- > > (Updated July 26, 2011, 2:02 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Localized the "No Device" and "Default System Device" strings in the sound devices panel. > > By the way: > * Fixed improper localization of the "Default" device name which caused saving a localized string in settings. > * Eliminated redundant getChild() calls. > > > This addresses bug STORM-1405. > http://jira.secondlife.com/browse/STORM-1405 > > > Diffs > ----- > > indra/newview/llpanelvoicedevicesettings.h 2f9a87538ca1 > indra/newview/llpanelvoicedevicesettings.cpp 2f9a87538ca1 > indra/newview/skins/default/xui/en/panel_sound_devices.xml 2f9a87538ca1 > > Diff: http://codereview.secondlife.com/r/417/diff > > > Testing > ------- > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110728/2cc5c5ac/attachment.htm From laurent.bechir at madonie.org Thu Jul 28 15:14:44 2011 From: laurent.bechir at madonie.org (Laurent Bechir) Date: Fri, 29 Jul 2011 00:14:44 +0200 Subject: [opensource-dev] Problem to download libkdu and fmod Message-ID: <13D5C4ED-0020-4818-8710-B679F9A5E6EB@madonie.org> Hello, I'm trying to build the viewer on my Mac and I can't go further the autobuild step, since I always get a time out for fmod and libkdu. I've found a solution for fmod putting an archive I have in my Dropbox, but I can't do that for libkdu. Anyone knows what can cause these time out ? I've noticed that when I try traceroute on s3-proxy-lindenlab.com, it stops at my router and doesn't go beyond. It's not the case for automated-builds-secondlife-com.s3.amazonaws.com, or any other destination. Any clue to solve that ? Thank you From ardylay at gmail.com Thu Jul 28 16:16:29 2011 From: ardylay at gmail.com (ardylay at gmail.com) Date: Thu, 28 Jul 2011 23:16:29 -0000 Subject: [opensource-dev] Review Request: /me emote doubles name in chat history In-Reply-To: <20110728095858.21538.18595@domU-12-31-38-00-90-68.compute-1.internal> References: <20110728095858.21538.18595@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110728231629.21536.81907@domU-12-31-38-00-90-68.compute-1.internal> > On July 28, 2011, 2:58 a.m., Boroondas Gupte wrote: > > indra/newview/llchathistory.cpp, line 929 > > > > > > As you cut away a substring of the length of chat.mFrontName, I assume chat.mText contains the content of chat.mFrontName at the beginning, not "/me " or "/me'"? chat.mText doesn't seem to have been modified since (old) line 747, so I guess the comparison you removed there was nonsense, anyway? > > > > Btw., where does mFromName get added to the beginning of mText? Wouldn't it be better to not add it in the first place rather than cutting it away again here? llviewermessage.cpp line2 3300 - 3368 is where you can find chat.mChatStyle = CHAT_STYLE_IRC; The test I removed was occuring AFTER the /me "emote" was stripped from the message from the simulator so was ineffective. See changeset at https://bitbucket.org/lindenlab/viewer-development/changeset/741e44af9f02 line 493. It prepends sender name, if it exists, then removes the leading 3 characters "/me" from the message. I did not see that display context was available at the time the name was prepended so was removed the name after context was available. Perhaps there is a better way? - ardy.lay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/419/#review934 ----------------------------------------------------------- On July 27, 2011, 8:52 p.m., ardy.lay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/419/ > ----------------------------------------------------------- > > (Updated July 27, 2011, 8:52 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > As a resident of Second Life I find the displaying an emoter's name twice in nearby chat history rather unnecessary. Please lay eyes on this proposed code change and let me know what you think. > > I took care to remove the unlinked sender name instead of the linked one. > > > This addresses bug VWR-26393. > http://jira.secondlife.com/browse/VWR-26393 > > > Diffs > ----- > > indra/newview/llchathistory.cpp 2f9a87538ca1 > > Diff: http://codereview.secondlife.com/r/419/diff > > > Testing > ------- > > Tell a crowd what you are testing and many will start talking to you prefixed with /me, if they are good sports. I have been using this change for 3 days now and have not noticed any ill effects. Please note: This changest is not intended to affect nearby chat toasts, nearby chat log files, IM history, IM toasts or IM log files. > > > Thanks, > > ardy.lay > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110728/7ae0166f/attachment.htm From wolfpup67 at earthlink.net Thu Jul 28 16:23:36 2011 From: wolfpup67 at earthlink.net (WolfPup Lowenhar) Date: Thu, 28 Jul 2011 19:23:36 -0400 Subject: [opensource-dev] Problem to download libkdu and fmod In-Reply-To: <13D5C4ED-0020-4818-8710-B679F9A5E6EB@madonie.org> References: <13D5C4ED-0020-4818-8710-B679F9A5E6EB@madonie.org> Message-ID: <003901cc4d7d$607eb870$217c2950$@net> First is sounds like you using something besides the configurations that end in OS as those are for the Open Source Developers to use so that you do not have the problem of DLing the private libs that those of us on the outside do not have access to. Second there is an autobuild 3p-fmod that you can build locally and then place the information generated during the packaging in the autobuild.xml file and set fmod=on in the settings for OS builds in the autobuild.xml and then fmod wil 'dl' and install to the build tree. > -----Original Message----- > From: opensource-dev-bounces at lists.secondlife.com [mailto:opensource-dev- > bounces at lists.secondlife.com] On Behalf Of Laurent Bechir > Sent: Thursday, July 28, 2011 6:15 PM > To: Viewer > Subject: [opensource-dev] Problem to download libkdu and fmod > > > Hello, > > I'm trying to build the viewer on my Mac and I can't go further the autobuild > step, since I always get a time out for fmod and libkdu. I've found a solution > for fmod putting an archive I have in my Dropbox, but I can't do that for > libkdu. Anyone knows what can cause these time out ? I've noticed that when I > try traceroute on s3-proxy-lindenlab.com, it stops at my router and doesn't go > beyond. It's not the case for automated-builds-secondlife- > com.s3.amazonaws.com, or any other destination. Any clue to solve that ? > > Thank you > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > ----- > No virus found in this message. > Checked by AVG - www.avg.com > Version: 10.0.1390 / Virus Database: 1518/3793 - Release Date: 07/28/11 From akanevsky at productengine.com Thu Jul 28 16:33:28 2011 From: akanevsky at productengine.com (Anya Kanevsky) Date: Thu, 28 Jul 2011 16:33:28 -0700 Subject: [opensource-dev] Snowstorm Product Owner Review build In-Reply-To: <4E316E79.80608@lindenlab.com> References: <4E316E79.80608@lindenlab.com> Message-ID: Awesomeness, all approved. Except for the ones that were already integrated and got in by accident. thank you! 2011/7/28 Oz Linden (Scott Lawrence) > > http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_viewer-poreview/rev/237151/index.html > > a couple of these may be spurious - they were mentioned in commit comments > for other issues and so show up in the list. I'm going to be lazy and not > attempt to filter them out. > > STORM-320 Script Editor in > Viewer 2.0+ "tabs" incorrectly STORM-519 "Delete" > is enabled in the context menu for folders which contain worn items > STORM-565 llGiveInventory > window is suppressed if avatar in Busy mode STORM-1220 Region > / Estate > Covenant - Type of region is in EN: "Estate / Full Region" > STORM-1233 [TRANSLATED BUT > IN EN] "Profile" button and tooltip appear untranslated at the bottom of the > "Places" sidepanel pages (French viewer) STORM-1234 In > Nearby Chat, Group Chat and IM Chat, URL selection frequently fails to grab > last character STORM-1291 (Spanish) > [STRING IN ENG] Gestos button. Many gestures. STORM-1311 Place > Profile only shows 2 lines and users have to click More link to see full > description STORM-1404 ALL > LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button labels and > tooltips in People pane STORM-1405 [HARDCODED] > Light Viewer - Untranslated items in Sound Devices drop-down list > STORM-1408 [DE] Text > truncation in Edit outfit floater STORM-1451 [DA] > "Login failed" message is empty in Danish STORM-1458 [crashhunters] > crash at LLParticipantList::LLParticipantListMenu::isGroupModerator() > [secondlife-bin llparticipantlist.cpp] STORM-1474 Implement > Show Last Search in viewer chrome STORM-1529 Sound > Devices floater is too narrow for its widgets > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110728/7af80741/attachment.htm From laurent.bechir at madonie.org Thu Jul 28 17:02:20 2011 From: laurent.bechir at madonie.org (Laurent Bechir) Date: Fri, 29 Jul 2011 02:02:20 +0200 Subject: [opensource-dev] Problem to download libkdu and fmod In-Reply-To: <003901cc4d7d$607eb870$217c2950$@net> References: <13D5C4ED-0020-4818-8710-B679F9A5E6EB@madonie.org> <003901cc4d7d$607eb870$217c2950$@net> Message-ID: <48BAB5C4-3FA5-4C7F-B177-C9C441E0AF8B@madonie.org> Thank you for all your answers :) I've put an archive of fmod on my server, and the link and md5sum in autobuild.xml. I've used -c ReleaseOS, and it worked. Le 29 juil. 2011 ? 01:23, WolfPup Lowenhar a ?crit : > First is sounds like you using something besides the configurations that end > in OS as those are for the Open Source Developers to use so that you do not > have the problem of DLing the private libs that those of us on the outside > do not have access to. > Second there is an autobuild 3p-fmod that you can build locally and then > place the information generated during the packaging in the autobuild.xml > file and set fmod=on in the settings for OS builds in the autobuild.xml and > then fmod wil 'dl' and install to the build tree. > >> -----Original Message----- >> From: opensource-dev-bounces at lists.secondlife.com [mailto:opensource-dev- >> bounces at lists.secondlife.com] On Behalf Of Laurent Bechir >> Sent: Thursday, July 28, 2011 6:15 PM >> To: Viewer >> Subject: [opensource-dev] Problem to download libkdu and fmod >> >> >> Hello, >> >> I'm trying to build the viewer on my Mac and I can't go further the > autobuild >> step, since I always get a time out for fmod and libkdu. I've found a > solution >> for fmod putting an archive I have in my Dropbox, but I can't do that for >> libkdu. Anyone knows what can cause these time out ? I've noticed that > when I >> try traceroute on s3-proxy-lindenlab.com, it stops at my router and > doesn't go >> beyond. It's not the case for automated-builds-secondlife- >> com.s3.amazonaws.com, or any other destination. Any clue to solve that ? >> >> Thank you >> _______________________________________________ >> Policies and (un)subscribe information available here: >> http://wiki.secondlife.com/wiki/OpenSource-Dev >> Please read the policies before posting to keep unmoderated posting >> privileges >> ----- >> No virus found in this message. >> Checked by AVG - www.avg.com >> Version: 10.0.1390 / Virus Database: 1518/3793 - Release Date: 07/28/11 > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges From richard at lindenlab.com Thu Jul 28 18:00:44 2011 From: richard at lindenlab.com (Richard Nelson) Date: Fri, 29 Jul 2011 01:00:44 -0000 Subject: [opensource-dev] Review Request: STORM-1521 [previously VWR-25588]: Zi's proposed fix for FIRE-543 - Hovertext renders as overlay on top of everything else In-Reply-To: <20110721095557.9726.52977@domU-12-31-38-00-90-68.compute-1.internal> References: <20110721095557.9726.52977@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110729010044.22115.26093@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/405/#review938 ----------------------------------------------------------- Ship it! Looks good - Richard On July 21, 2011, 2:55 a.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/405/ > ----------------------------------------------------------- > > (Updated July 21, 2011, 2:55 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Set the z (depth) coordinate of hovertext such that the hovertext gets occluded by stuff in front of it. > > > This addresses bugs SH-489, VWR-24017 and VWR-25588. > http://jira.secondlife.com/browse/SH-489 > http://jira.secondlife.com/browse/VWR-24017 > http://jira.secondlife.com/browse/VWR-25588 > > > Diffs > ----- > > doc/contributions.txt 46c7b36793c9 > indra/llrender/llfontgl.cpp 46c7b36793c9 > > Diff: http://codereview.secondlife.com/r/405/diff > > > Testing > ------- > > Merged this change with e67da2c6e312 (as I still cannot build viewer-development tip) and rebuilt. Verified that my nametag and an objects llSetText hovertext were correctly occluded by another object in front of them. > > > Thanks, > > Boroondas > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110729/9708e783/attachment.htm From ardylay at gmail.com Thu Jul 28 18:27:31 2011 From: ardylay at gmail.com (ardylay at gmail.com) Date: Fri, 29 Jul 2011 01:27:31 -0000 Subject: [opensource-dev] Review Request: STORM-1521 [previously VWR-25588]: Zi's proposed fix for FIRE-543 - Hovertext renders as overlay on top of everything else In-Reply-To: <20110721095557.9726.52977@domU-12-31-38-00-90-68.compute-1.internal> References: <20110721095557.9726.52977@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110729012731.21538.35412@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/405/#review939 ----------------------------------------------------------- Ship it! I am using it without noticing any functional issues. Does this return floating text and nametags to a previous behavior I haven't seen for a long time? I think it does. It feels comfortable to me and really decluters the display. - ardy.lay On July 21, 2011, 2:55 a.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/405/ > ----------------------------------------------------------- > > (Updated July 21, 2011, 2:55 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Set the z (depth) coordinate of hovertext such that the hovertext gets occluded by stuff in front of it. > > > This addresses bugs SH-489, VWR-24017 and VWR-25588. > http://jira.secondlife.com/browse/SH-489 > http://jira.secondlife.com/browse/VWR-24017 > http://jira.secondlife.com/browse/VWR-25588 > > > Diffs > ----- > > doc/contributions.txt 46c7b36793c9 > indra/llrender/llfontgl.cpp 46c7b36793c9 > > Diff: http://codereview.secondlife.com/r/405/diff > > > Testing > ------- > > Merged this change with e67da2c6e312 (as I still cannot build viewer-development tip) and rebuilt. Verified that my nametag and an objects llSetText hovertext were correctly occluded by another object in front of them. > > > Thanks, > > Boroondas > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110729/34323b8e/attachment.htm From vsavchuk at productengine.com Thu Jul 28 19:29:27 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Fri, 29 Jul 2011 02:29:27 -0000 Subject: [opensource-dev] Review Request: STORM-1436 [JP]"Contents" and "New Script" folder text are missing in "Content" tab for "Build" floater Message-ID: <20110729022927.21536.91203@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/420/ ----------------------------------------------------------- Review request for Viewer and Richard Nelson. Summary ------- Fixed broken localization of "Contents" and "New Script" items in the Contents tab of Build Tools. The bug happened when the translations contained non-ASCII characters. Reason: Names of inventory items are limited to ASCII characters. Fix: Leave names in English, localize them when displaying (on the fly). The fix only affects object's inventory (i.e. not agent inventory). This addresses bug STORM-1436. http://jira.secondlife.com/browse/STORM-1436 Diffs ----- indra/newview/llpanelcontents.cpp 2f9a87538ca1 indra/newview/llpanelobjectinventory.cpp 2f9a87538ca1 indra/newview/llviewerobject.cpp 2f9a87538ca1 Diff: http://codereview.secondlife.com/r/420/diff Testing ------- Tested Japanese and Polish translations. The "Contents", "New Script", ""New Script 1", "New Script 2", etc names were correctly localized. Thanks, Vadim -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110729/cd01fdb6/attachment-0001.htm From sllists at boroon.dasgupta.ch Fri Jul 29 02:05:50 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Fri, 29 Jul 2011 09:05:50 -0000 Subject: [opensource-dev] Review Request: STORM-1521 [previously VWR-25588]: Zi's proposed fix for FIRE-543 - Hovertext renders as overlay on top of everything else In-Reply-To: <20110729012731.21538.35412@domU-12-31-38-00-90-68.compute-1.internal> References: <20110729012731.21538.35412@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110729090550.22642.53572@domU-12-31-38-00-90-68.compute-1.internal> > On July 28, 2011, 6:27 p.m., ardy.lay wrote: > > I am using it without noticing any functional issues. Does this return floating text and nametags to a previous behavior I haven't seen for a long time? I think it does. It feels comfortable to me and really decluters the display. > Does this return floating text and nametags to a previous behavior I haven't seen for a long time? Yes, that's what it's supposed to do. See the linked SL jira issues and http://jira.phoenixviewer.com/browse/FIRE-543 (and duplicates there). - Boroondas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/405/#review939 ----------------------------------------------------------- On July 21, 2011, 2:55 a.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/405/ > ----------------------------------------------------------- > > (Updated July 21, 2011, 2:55 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Set the z (depth) coordinate of hovertext such that the hovertext gets occluded by stuff in front of it. > > > This addresses bugs SH-489, VWR-24017 and VWR-25588. > http://jira.secondlife.com/browse/SH-489 > http://jira.secondlife.com/browse/VWR-24017 > http://jira.secondlife.com/browse/VWR-25588 > > > Diffs > ----- > > doc/contributions.txt 46c7b36793c9 > indra/llrender/llfontgl.cpp 46c7b36793c9 > > Diff: http://codereview.secondlife.com/r/405/diff > > > Testing > ------- > > Merged this change with e67da2c6e312 (as I still cannot build viewer-development tip) and rebuilt. Verified that my nametag and an objects llSetText hovertext were correctly occluded by another object in front of them. > > > Thanks, > > Boroondas > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110729/c5c519a4/attachment.htm From sllists at boroon.dasgupta.ch Fri Jul 29 06:49:03 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Fri, 29 Jul 2011 15:49:03 +0200 Subject: [opensource-dev] Problem to download libkdu and fmod In-Reply-To: <48BAB5C4-3FA5-4C7F-B177-C9C441E0AF8B@madonie.org> References: <13D5C4ED-0020-4818-8710-B679F9A5E6EB@madonie.org> <003901cc4d7d$607eb870$217c2950$@net> <48BAB5C4-3FA5-4C7F-B177-C9C441E0AF8B@madonie.org> Message-ID: <4E32BA4F.5050707@boroon.dasgupta.ch> On 07/29/2011 02:02 AM, Laurent Bechir wrote: > Thank you for all your answers :) I've put an archive of fmod on my server, and the link and md5sum in autobuild.xml. I've used -c ReleaseOS, and it worked. Tip: You can use file:// urls to refer to local files, so you don't have to put the archive on a server. Doing the latter and thereby publishing your package of the lib might not be covered by the applicable FMOD license, which is the very reason why LL doesn't offer a pre-built FMOD package. Cheers, Boroondas PS: Off course, IANALTINLABBQETC. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110729/bbba7360/attachment.htm From vsavchuk at productengine.com Fri Jul 29 06:52:01 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Fri, 29 Jul 2011 13:52:01 -0000 Subject: [opensource-dev] Review Request: STORM-1473 [VIEWER DEV] ALL LANGS Untranslated Voice Morph Names in the French viewer Message-ID: <20110729135201.21538.96860@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/421/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Localized voice morph names. This addresses bug STORM-1473. http://jira.secondlife.com/browse/STORM-1473 Diffs ----- indra/newview/llfloatervoiceeffect.cpp abd84f85d848 indra/newview/skins/default/xui/en/floater_voice_effect.xml abd84f85d848 Diff: http://codereview.secondlife.com/r/421/diff Testing ------- Thanks, Vadim -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110729/777d742c/attachment.htm From vsavchuk at productengine.com Fri Jul 29 07:05:03 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Fri, 29 Jul 2011 14:05:03 -0000 Subject: [opensource-dev] Review Request: STORM-1194 Web browser opens clicking URL-name of object in Object Contents floater Message-ID: <20110729140503.21540.75425@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/422/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Object Contents floater: disabled links in the object name text box. This addresses bug STORM-1194. http://jira.secondlife.com/browse/STORM-1194 Diffs ----- indra/newview/skins/default/xui/en/floater_openobject.xml abd84f85d848 Diff: http://codereview.secondlife.com/r/422/diff Testing ------- Thanks, Vadim -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110729/f87c489f/attachment.htm From vsavchuk at productengine.com Fri Jul 29 08:01:39 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Fri, 29 Jul 2011 15:01:39 -0000 Subject: [opensource-dev] Review Request: STORM-632 URL-like resident display name is shown as clickable HTTP URL in various places Message-ID: <20110729150139.25764.67541@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/423/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Disallow showing URL-like avatar display names as Web links in various places. Fixed in: * People panel -> friend list * IM toast * Friend online/offline notification toasts * IM well * Avatar inspector This addresses bug STORM-632. http://jira.secondlife.com/browse/STORM-632 Diffs ----- indra/newview/skins/default/xui/en/inspect_avatar.xml abd84f85d848 indra/newview/skins/default/xui/en/notifications.xml abd84f85d848 indra/newview/skins/default/xui/en/panel_activeim_row.xml abd84f85d848 indra/newview/skins/default/xui/en/panel_avatar_list_item.xml abd84f85d848 indra/newview/skins/default/xui/en/panel_instant_message.xml abd84f85d848 Diff: http://codereview.secondlife.com/r/423/diff Testing ------- Thanks, Vadim -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110729/b6cddf7e/attachment.htm From laurent.bechir at madonie.org Fri Jul 29 09:16:06 2011 From: laurent.bechir at madonie.org (Laurent Bechir) Date: Fri, 29 Jul 2011 18:16:06 +0200 Subject: [opensource-dev] llqtwebki fails Message-ID: Since several days llqtwebkit build fails with this error : http://pastie.org/2290530 I'm using Mac Os X Lion, Xcode 3.2.6, llqtwebkit-4.6+cookies-darwin-20100519. I'm trying to build the viewer with this older version just in case it could work better than the new one with the web profiles. I'm trying to build viewer-release branch. Thank you From kadah.coba at gmail.com Fri Jul 29 16:40:13 2011 From: kadah.coba at gmail.com (Kadah Coba) Date: Fri, 29 Jul 2011 23:40:13 -0000 Subject: [opensource-dev] Review Request: [STORM-56] As Builder, I want more decimal places allowed in the Build tool so that I can more precisely align small prims. Message-ID: <20110729234013.21535.59227@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/424/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Adds 2 features: Adds the ability to use modifier keys to change the defined increment on LLSpinCtrl. Alt: increment x10 Ctrl: increment x0.1 Shift: increment x0.01 Adds extra decimal places to position, size, and rotation on build floater. Also changes LLPanelObject::sendPosition and LLPanelObject::sendScale to set smaller changes in the associated values, no change was needed for LLPanelObject::sendRotation. There should be no ill effects from this, changes are still only sent to sim on button release. https://bitbucket.org/Kadah_Coba/storm-56 This addresses bug STORM-56. http://jira.secondlife.com/browse/STORM-56 Diffs ----- indra/llui/llspinctrl.cpp UNKNOWN indra/newview/llpanelobject.cpp UNKNOWN indra/newview/skins/default/xui/en/floater_tools.xml UNKNOWN Diff: http://codereview.secondlife.com/r/424/diff Testing ------- Same code has been in use on FS beta for some time. I have built and tested this myself on v-d. Thanks, Kadah -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110729/c46a074c/attachment.htm From sllists at boroon.dasgupta.ch Fri Jul 29 17:03:12 2011 From: sllists at boroon.dasgupta.ch (Boroondas Gupte) Date: Sat, 30 Jul 2011 00:03:12 -0000 Subject: [opensource-dev] Review Request: [STORM-56] As Builder, I want more decimal places allowed in the Build tool so that I can more precisely align small prims. In-Reply-To: <20110729234013.21535.59227@domU-12-31-38-00-90-68.compute-1.internal> References: <20110729234013.21535.59227@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20110730000312.25766.49524@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/424/#review941 ----------------------------------------------------------- indra/llui/llspinctrl.cpp Put a space between '//' and the actual comment for better readability and for consistence with other comments nearby. indra/llui/llspinctrl.cpp So if several modifier keys are pressed, Ctrl overrides Shift and Alt overrides Ctrl, Shift or both? (Fine with me, just want to make sure this is intended.) indra/newview/llpanelobject.cpp You might want to write '0.05' instead of '1/20' in this comment. indra/newview/llpanelobject.cpp Same here. - Boroondas On July 29, 2011, 4:40 p.m., Kadah Coba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/424/ > ----------------------------------------------------------- > > (Updated July 29, 2011, 4:40 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Adds 2 features: > > Adds the ability to use modifier keys to change the defined increment on LLSpinCtrl. > Alt: increment x10 > Ctrl: increment x0.1 > Shift: increment x0.01 > > Adds extra decimal places to position, size, and rotation on build floater. > Also changes LLPanelObject::sendPosition and LLPanelObject::sendScale to set smaller changes in the associated values, no change was needed for LLPanelObject::sendRotation. There should be no ill effects from this, changes are still only sent to sim on button release. > > https://bitbucket.org/Kadah_Coba/storm-56 > > > This addresses bug STORM-56. > http://jira.secondlife.com/browse/STORM-56 > > > Diffs > ----- > > indra/llui/llspinctrl.cpp UNKNOWN > indra/newview/llpanelobject.cpp UNKNOWN > indra/newview/skins/default/xui/en/floater_tools.xml UNKNOWN > > Diff: http://codereview.secondlife.com/r/424/diff > > > Testing > ------- > > Same code has been in use on FS beta for some time. I have built and tested this myself on v-d. > > > Thanks, > > Kadah > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110730/c06052fe/attachment.htm From sitearm at gmail.com Sun Jul 31 18:11:58 2011 From: sitearm at gmail.com (Sitearm) Date: Sun, 31 Jul 2011 20:11:58 -0500 Subject: [opensource-dev] SLCC 2011 Two Week Warning In-Reply-To: References: Message-ID: ; http://sitearm.wordpress.com/2011/08/01/slcc-2011-two-week-warning/ SLCC 2011 Two Week Warning August 1, 2011 ? sitearm [image: slcc 2011 bridge logo] In two weeks, *August 13-14*, *SLCC 2011* will be up and running on *three media channels*: . Real World: *California*, Oakland Marriott City Center . In World: *Second Life*, SLCC Sims . Internet: *Ustream*, Your Favorite Internet Browser Highlights SLCC presentations are *webcast live, *and *recorded*, *available to all SL Residents*, *at their convenience*: . *Attending Real World* requires a 300 USD registration fee, which includes *venue*, *gift bag*, *meals* and also covers *webcasting and recording fees*. . *Attending In World* is free. . *Attending Internet* is free. SLCC is the *Second Life Community Convention*, held once a year *for*residents, *by* residents. *Second Life?* is the world?s *leading 3D Web virtual environment* and *virtual goods economy*. SLCC is a mixed modality, Live + Remote Conference, with *twice the speakers, audience, and impact* of traditional, live-only conferences. [image: slcc11_inworld_schedule_FINAL] Content Viewing Schedule . SLCC 2011 has confirmed *30+ presentations* and *mixers*, addressing *all areas of SL Resident interest*. . *Presentation summaries *are available, now, for *advance review*, at http://schedule.slconvention.org: ? Keynotes[4] ? Artistic & Creative Expression[4] ? Commerce & Marketing[8] ? Developers & Open Source[4] ? Public Service & Education[8] ? Social Experience & Communities[5] ? Oakland Mixers[5] ? In World Mixers[5] Oakland Updates *Conference registration * is now 300 USD. When registering in advance, you may take 10% off by using *discount code*, *SLCC-friend*. *Day Passes* are available for 150 USD per day. No discounts are available *On-site Registration* is limited. You will need a credit card or PayPal account. No discounts are available. [image: slcc inworld teeshirt image]In World Updates *SLCC sims* are now *open to the public * for advance review. SLCC sims include *gift giver boxes* with *Avatar tee-shirts* and more. Internet Updates Ustream URL?s will be posted on the home page of www.slconvention.org under ?Live Streams?. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110731/6e597ec4/attachment.htm