[opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields
Vadim ProductEngine
vsavchuk at productengine.com
Mon Jul 4 13:54:56 PDT 2011
> On July 4, 2011, 1:01 p.m., Vadim ProductEngine wrote:
> > indra/llui/llspinctrl.cpp, lines 128-135
> > <http://codereview.secondlife.com/r/377/diff/6/?file=6493#file6493line128>
> >
> > dead code
>
> Kadah Coba wrote:
> Remove?
Yes, our coding standard explicitly requires not to leave dead code.
> On July 4, 2011, 1:01 p.m., Vadim ProductEngine wrote:
> > indra/llmath/llcalc.cpp, lines 58-59
> > <http://codereview.secondlife.com/r/377/diff/6/?file=6488#file6488line58>
> >
> > Why allocate dynamically?
>
> Kadah Coba wrote:
> I'm not sure, there's a lot of c++ voodoo going on in the original patch.
I think dynamic allocation is redundant here, i.e. I'd convert the members to non-pointers and pass their addresses to the parser.
- Vadim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/377/#review836
-----------------------------------------------------------
On July 2, 2011, 10:21 p.m., Kadah Coba wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/377/
> -----------------------------------------------------------
>
> (Updated July 2, 2011, 10:21 p.m.)
>
>
> Review request for Viewer.
>
>
> Summary
> -------
>
> This is a direct adaptation of Aimee Trescothick's contributed patch from STORM-1315 for v-d. Adjustments were made where needed to make it work with the newer boost and llui code. Some changes were made to the variable names it uses on build; ie "PX" for x position instead of just "X".
>
> Patch allows for imputing simple math equations in to the spinner controls. On the build floater a series of variable names are available for using the objects current values in equations, like "sx+3" will take the current X scale and add 3.
>
> Repo: https://bitbucket.org/Kadah_Coba/storm-1315
> Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370
>
>
> This addresses bug STORM-1315.
> http://jira.secondlife.com/browse/STORM-1315
>
>
> Diffs
> -----
>
> indra/newview/llpanelobject.cpp 353807ed6a69
> indra/newview/llpanelface.cpp 353807ed6a69
> indra/newview/llappviewer.cpp 353807ed6a69
> indra/llui/llspinctrl.cpp 353807ed6a69
> indra/llui/lllineeditor.cpp 353807ed6a69
> indra/llmath/llcalcparser.cpp PRE-CREATION
> indra/llui/lllineeditor.h 353807ed6a69
> doc/contributions.txt 353807ed6a69
> indra/llmath/CMakeLists.txt 353807ed6a69
> indra/llmath/llcalc.h PRE-CREATION
> indra/llmath/llcalc.cpp PRE-CREATION
> indra/llmath/llcalcparser.h PRE-CREATION
>
> Diff: http://codereview.secondlife.com/r/377/diff
>
>
> Testing
> -------
>
> Built and ran. Some testing done with simple equations on the build tools floater to edit an object, no issues were observed.
>
>
> Thanks,
>
> Kadah
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110704/7b7374ae/attachment-0001.htm
More information about the opensource-dev
mailing list