[opensource-dev] Review Request: STORM-1481 Jerky transition when switching region from fixed sky to a day cycle

[Seth ProductEngine]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/382/#review846
-----------------------------------------------------------

Ship it!


Looks good to me.

- Seth


On July 6, 2011, 5:37 p.m., Vadim ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/382/
> -----------------------------------------------------------
> 
> (Updated July 6, 2011, 5:37 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> When uploading new region environment settings, we must also update the region sun phase/flags.
> If we do this too early we may get jerky transition from fixed sky to a day cycle.
> 
> That is caused by the simulator re-sending the region info, which in turn makes us
> re-request and display old region environment settings while the new ones haven't been applied yet.
> 
> The fix is to send the sun phase update only when new environment settings have been applied.
> 
> 
> This addresses bug STORM-1481.
>     http://jira.secondlife.com/browse/STORM-1481
> 
> 
> Diffs
> -----
> 
>   indra/newview/llfloaterregioninfo.h UNKNOWN 
>   indra/newview/llfloaterregioninfo.cpp UNKNOWN 
>   indra/newview/llregioninfomodel.cpp UNKNOWN 
>   indra/newview/llviewermessage.cpp UNKNOWN 
>   indra/newview/llviewerregion.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/382/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vadim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110707/15245c3a/attachment-0001.htm