[opensource-dev] Review Request: Support SOCKS 5 proxy in the viewer.

[Tankmaster Finesmith]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/374/#review855
-----------------------------------------------------------


It looks like you have the name= the same for the "Proxy Settings:" text as for "Software updates:" in the panel_preferences_setup.xml file.  These need to be different for translations to work. 

- Tankmaster


On July 8, 2011, 11:55 a.m., Log Linden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/374/
> -----------------------------------------------------------
> 
> (Updated July 8, 2011, 11:55 a.m.)
> 
> 
> Review request for Viewer, Oz Linden, Monty Brandenberg, and Stone Linden.
> 
> 
> Summary
> -------
> 
> This is a continuation of Robin Cornelius's SOCKS 5 contribution, shown in https://codereview.secondlife.com/r/232/ .  I have tried to address all of the comments on that code review and do as much cleanup as possible. The diff includes everything that was submitted by Robin, as well as my work.
> Major changes since I started working:
> * Changed SOCKS 5 proxy control channel to use the existing LLSocket class, which is a thin wrapper around APR sockets.
> * Worked with the Linden Lab UX team to revamp the proxy controls.
> * Proxy credentials are now stored in the LLSecAPI password storage, which is the same that is used for users' Second Life Credentials instead of as being stored in the clear as a preference.
> 
> 
> This addresses bug STORM-1112.
>     http://jira.secondlife.com/browse/STORM-1112
> 
> 
> Diffs
> -----
> 
>   indra/llmessage/CMakeLists.txt c7a4b7a24e05 
>   indra/llmessage/llcurl.cpp c7a4b7a24e05 
>   indra/llmessage/lliosocket.h c7a4b7a24e05 
>   indra/llmessage/lliosocket.cpp c7a4b7a24e05 
>   indra/llmessage/llpacketring.h c7a4b7a24e05 
>   indra/llmessage/llpacketring.cpp c7a4b7a24e05 
>   indra/llmessage/llproxy.h PRE-CREATION 
>   indra/llmessage/llproxy.cpp PRE-CREATION 
>   indra/llmessage/net.h c7a4b7a24e05 
>   indra/llmessage/net.cpp c7a4b7a24e05 
>   indra/llui/llfunctorregistry.h c7a4b7a24e05 
>   indra/newview/app_settings/settings.xml c7a4b7a24e05 
>   indra/newview/llappviewer.cpp c7a4b7a24e05 
>   indra/newview/llfloaterpreference.h c7a4b7a24e05 
>   indra/newview/llfloaterpreference.cpp c7a4b7a24e05 
>   indra/newview/llloginhandler.cpp c7a4b7a24e05 
>   indra/newview/llpanellogin.h c7a4b7a24e05 
>   indra/newview/llsecapi.h c7a4b7a24e05 
>   indra/newview/llstartup.h c7a4b7a24e05 
>   indra/newview/llstartup.cpp c7a4b7a24e05 
>   indra/newview/llviewerfloaterreg.cpp c7a4b7a24e05 
>   indra/newview/llxmlrpctransaction.cpp c7a4b7a24e05 
>   indra/newview/skins/default/xui/en/floater_preferences_proxy.xml PRE-CREATION 
>   indra/newview/skins/default/xui/en/notifications.xml c7a4b7a24e05 
>   indra/newview/skins/default/xui/en/panel_cof_wearables.xml c7a4b7a24e05 
>   indra/newview/skins/default/xui/en/panel_preferences_privacy.xml c7a4b7a24e05 
>   indra/newview/skins/default/xui/en/panel_preferences_setup.xml c7a4b7a24e05 
> 
> Diff: http://codereview.secondlife.com/r/374/diff
> 
> 
> Testing
> -------
> 
> I've tested exclusively on Linux so far.  I'm working on a more extensive test plan that includes setting up a gateway with a restrictive firewall to verify that all traffic is going through the proxy. 
> 
> Test builds and screenshots of the changed UI elements are available from the project page, located here:
> https://wiki.secondlife.com/wiki/User:Log_Linden/Socks5Viewer
> 
> 
> Thanks,
> 
> Log
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110710/4e5f8bfb/attachment.htm