[opensource-dev] Review Request: (STORM-1234) In Nearby Chat, Group Chat and IM Chat, URL selection frequently fails to grab last character

[Richard Nelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/394/#review872
-----------------------------------------------------------

Ship it!


once again all the -1's start creeping back in :)  At least it's clearly documented here.

- Richard


On July 13, 2011, 9:06 a.m., Seth ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/394/
> -----------------------------------------------------------
> 
> (Updated July 13, 2011, 9:06 a.m.)
> 
> 
> Review request for Viewer and Richard Nelson.
> 
> 
> Summary
> -------
> 
> Fixed text editor selection which was skipping the last character in line.
> 
> Added handling of the wrapped lines case when calculating the starting position for selection.
> 
> The bug is a regression caused by the fix of STORM-320 which was dealing with calculating the position of the input cursor while navigating through the lines of text with word wrapping enabled.
> 
> 
> This addresses bug STORM-1234.
>     http://jira.secondlife.com/browse/STORM-1234
> 
> 
> Diffs
> -----
> 
>   indra/llui/lltextbase.cpp 68ad362920c1 
> 
> Diff: http://codereview.secondlife.com/r/394/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Seth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110713/87d38045/attachment-0001.htm