[opensource-dev] Review Request: STORM-519 ( "Delete" is enabled in the context menu for folders which contain worn items)

[Boroondas Gupte]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/396/#review877
-----------------------------------------------------------



indra/newview/llinventorybridge.cpp
<http://codereview.secondlife.com/r/396/#comment917>

    Why store this in a variable when the result is only used once and the call is this simple? (I assume the result of this call wouldn't change between here where the value is stored and the below where it's used.)



indra/newview/llinventorybridge.cpp
<http://codereview.secondlife.com/r/396/#comment918>

    We could just use
    	if (!isItemRemovable())
    here, couldn't we?


- Boroondas


On July 14, 2011, 2:15 a.m., Paul ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/396/
> -----------------------------------------------------------
> 
> (Updated July 14, 2011, 2:15 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> - Disable "Delete" menu item in case selected folder contains non-removable items.
> 
> 
> This addresses bug storm-519.
>     http://jira.secondlife.com/browse/storm-519
> 
> 
> Diffs
> -----
> 
>   indra/newview/llinventorybridge.cpp 68ad362920c1 
> 
> Diff: http://codereview.secondlife.com/r/396/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110714/80b9f5fa/attachment.htm