[opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)

[Nicky Perian]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/313/#review903
-----------------------------------------------------------


applied open-67_d.diff @r15984; windows fails link with unresolved externals as follows:
"windows-crash-logger.dir\RelWithDebInfo\/win_crash_logger.obj"  /machine:X86 /debug 
llvfs.lib(lldiriterator.obj) : error LNK2019: unresolved external symbol "private: static class std::codecvt<unsigned short,char,int> const * & __cdecl boost::filesystem3::path::wchar_t_codecvt_facet(void)" (?wchar_t_codecvt_facet at path@filesystem3 at boost@@CAAAPBV?$codecvt at GDH@std@@XZ) referenced in function "public: __thiscall LLDirIterator::Impl::Impl(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (??0Impl at LLDirIterator@@QAE at ABV?$basic_string at DU?$char_traits at D@std@@V?$allocator at D@2@@std@@0 at Z) [c:\Users\Bill\lindenhg\viewer-development-mesh\build-vc100\win_crash_logger\windows-crash-logger.vcxproj]
llvfs.lib(lldiriterator.obj) : error LNK2019: unresolved external symbol "void __cdecl boost::filesystem3::path_traits::convert(unsigned short const *,unsigned short const *,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > &,class std::codecvt<unsigned short,char,int> const &)" (?convert at path_traits@filesystem3 at boost@@YAXPBG0AAV?$basic_string at DU?$char_traits at D@std@@V?$allocator at D@2@@std@@ABV?$codecvt at GDH@5@@Z) referenced in function "public: class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const __thiscall boost::filesystem3::path::string(class std::codecvt<unsigned short,char,int> const &)const " (?string at path@filesystem3 at boost@@QBE?BV?$basic_string at DU?$char_traits at D@std@@V?$allocator at D@2@@std@@ABV?$codecvt at GDH@5@@Z) [c:\Users\Bill\lindenhg\viewer-development-mesh\build-vc100\win_crash_logger\windows-crash-logger.vcxproj]
llvfs.lib(lldiriterator.obj) : error LNK2019: unresolved external symbol "public: class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const __thiscall boost::filesystem3::path::generic_string(class std::codecvt<unsigned short,char,int> const &)const " (?generic_string at path@filesystem3 at boost@@QBE?BV?$basic_string at DU?$char_traits at D@std@@V?$allocator at D@2@@std@@ABV?$codecvt at GDH@5@@Z) referenced in function "public: class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const __thiscall boost::filesystem3::path::generic_string(void)const " (?generic_string at path@filesystem3 at boost@@QBE?BV?$basic_string at DU?$char_traits at D@std@@V?$allocator at D@2@@std@@XZ) [c:\Users\Bill\lindenhg\viewer-development-mesh\build-vc100\win_crash_logger\windows-crash-logger.vcxproj]
llvfs.lib(lldiriterator.obj) : error LNK2019: unresolved external symbol "void __cdecl boost::filesystem3::path_traits::convert(char const *,char const *,class std::basic_string<unsigned short,struct std::char_traits<unsigned short>,class std::allocator<unsigned short> > &,class std::codecvt<unsigned short,char,int> const &)" (?convert at path_traits@filesystem3 at boost@@YAXPBD0AAV?$basic_string at GU?$char_traits at G@std@@V?$allocator at G@2@@std@@ABV?$codecvt at GDH@5@@Z) referenced in function "void __cdecl boost::filesystem3::path_traits::dispatch<class std::basic_string<unsigned short,struct std::char_traits<unsigned short>,class std::allocator<unsigned short> > >(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::basic_string<unsigned short,struct std::char_traits<unsigned short>,class std::allocator<unsigned short> > &,class std::codecvt<unsigned short,char,int> const &)" (??$dispatch at V?$basic_string at GU?$char_traits at G@std@@V?$allocator at G@2@@std@@@path_traits at filesystem3@boost@@YAXABV?$basic_string at DU?$char_traits at D@std@@V?$allocator at D@2@@std@@AAV?$basic_string at GU?$char_traits at G@std@@V?$allocator at G@2@@4 at ABV?$codecvt at GDH@4@@Z) [c:\Users\Bill\lindenhg\viewer-development-mesh\build-vc100\win_crash_logger\windows-crash-logger.vcxproj]

- Nicky


On July 21, 2011, 8:43 a.m., Boroondas Gupte wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/313/
> -----------------------------------------------------------
> 
> (Updated July 21, 2011, 8:43 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Context: We are currently using Boost 1.45, which already comes with the new Boost Filesystem Library API (Version 3) but still defaults to the old one (Version 2). From Boost 1.46 on, V3 will be the default and Boost 1.47 will be the last one to come with V2. The Boost Filesystem Library documentation recommends "Existing code should be moved to Version 3 as soon as convenient. New code should be written for Version 3. Version 2 is deprecated, and will not be included in Boost releases 1.48 and later."
> 
> This change overrides the default, so that the V3 API is used, and makes the necessary code changes. (So we can stick to Boost 1.45 and upgrade whenever we feel like it.)
> 
> Note: I only changed stuff that the compiler complained about. If the new API also changes semantic of still-compiling library usage, more changes might be necessary.
> 
> 
> This addresses bug OPEN-67.
>     http://jira.secondlife.com/browse/OPEN-67
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 959f9340da92 
>   indra/llvfs/lldiriterator.cpp 959f9340da92 
> 
> Diff: http://codereview.secondlife.com/r/313/diff
> 
> 
> Testing
> -------
> 
> * Compiled Viewer (standalone) with Boost 1.45
> * Started Viewer
> * Logged in
> 
> * Compiled Viewer (standalone) with Boost 1.46
> * Started Viewer
> * Logged in
> 
> Not tested:
> * non-standalone
> 
> 
> Thanks,
> 
> Boroondas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110721/c3c66292/attachment.htm